Merge branch 'master' into careminster-presence-refactor

Integrate the next large patch.
Don't use this version, it has a ghost avatar issue. Next push
will fix it.

28 files changed, 830 insertions, 1259 deletions

diff --git a/OpenSim/Region/ClientStack/LindenUDP/LLClientView.cs b/OpenSim/Region/ClientStack/LindenUDP/LLClientView.cs
index 0f1a1ca..dca1346 100644
--- a/OpenSim/Region/ClientStack/LindenUDP/LLClientView.cs
+++ b/OpenSim/Region/ClientStack/LindenUDP/LLClientView.cs
@@ -1533,7 +1533,12 @@ namespace OpenSim.Region.ClientStack.LindenUDP
                 lock (m_entityUpdates.SyncRoot)
                 {
                     m_killRecord.Add(localID);
-                    OutPacket(kill, ThrottleOutPacketType.State);
+                    
+                    // The throttle queue used here must match that being used for updates.  Otherwise, there is a 
+                    // chance that a kill packet put on a separate queue will be sent to the client before an existing
+                    // update packet on another queue.  Receiving updates after kills results in unowned and undeletable
+                    // scene objects in a viewer until that viewer is relogged in.
+                    OutPacket(kill, ThrottleOutPacketType.Task);
                 }
             }
         }
diff --git a/OpenSim/Region/ClientStack/LindenUDP/LLUDPClient.cs b/OpenSim/Region/ClientStack/LindenUDP/LLUDPClient.cs
index eebbfa5..a4738ff 100644
--- a/OpenSim/Region/ClientStack/LindenUDP/LLUDPClient.cs
+++ b/OpenSim/Region/ClientStack/LindenUDP/LLUDPClient.cs
@@ -420,8 +420,14 @@ namespace OpenSim.Region.ClientStack.LindenUDP
 
         /// <summary>
         /// Loops through all of the packet queues for this client and tries to send
-        /// any outgoing packets, obeying the throttling bucket limits
+        /// an outgoing packet from each, obeying the throttling bucket limits
         /// </summary>
+        /// 
+        /// Packet queues are inspected in ascending numerical order starting from 0.  Therefore, queues with a lower 
+        /// ThrottleOutPacketType number will see their packet get sent first (e.g. if both Land and Wind queues have
+        /// packets, then the packet at the front of the Land queue will be sent before the packet at the front of the
+        /// wind queue).
+        /// 
         /// <remarks>This function is only called from a synchronous loop in the
         /// UDPServer so we don't need to bother making this thread safe</remarks>
         /// <returns>True if any packets were sent, otherwise false</returns>
diff --git a/OpenSim/Region/ClientStack/LindenUDP/LLUDPServer.cs b/OpenSim/Region/ClientStack/LindenUDP/LLUDPServer.cs
index 5aeca83..e2cda6d 100644
--- a/OpenSim/Region/ClientStack/LindenUDP/LLUDPServer.cs
+++ b/OpenSim/Region/ClientStack/LindenUDP/LLUDPServer.cs
@@ -500,6 +500,10 @@ namespace OpenSim.Region.ClientStack.LindenUDP
             // FIXME: Implement?
         }
 
+        /// <summary>
+        /// Actually send a packet to a client.
+        /// </summary>
+        /// <param name="outgoingPacket"></param>
         internal void SendPacketFinal(OutgoingPacket outgoingPacket)
         {
             UDPPacketBuffer buffer = outgoingPacket.Buffer;
diff --git a/OpenSim/Region/CoreModules/Avatar/Attachments/AttachmentsModule.cs b/OpenSim/Region/CoreModules/Avatar/Attachments/AttachmentsModule.cs
index 7c95658..6f7256e 100644
--- a/OpenSim/Region/CoreModules/Avatar/Attachments/AttachmentsModule.cs
+++ b/OpenSim/Region/CoreModules/Avatar/Attachments/AttachmentsModule.cs
@@ -586,13 +586,9 @@ namespace OpenSim.Region.CoreModules.Avatar.Attachments
             so.RootPart.AttachedAvatar = avatar.UUID;
 
             //Anakin Lohner bug #3839 
-            lock (so.Children)
-            {
-                foreach (SceneObjectPart p in so.Children.Values)
-                {
-                    p.AttachedAvatar = avatar.UUID;
-                }
-            }
+            SceneObjectPart[] parts = so.Parts;
+            for (int i = 0; i < parts.Length; i++)
+                parts[i].AttachedAvatar = avatar.UUID;
 
             if (so.RootPart.PhysActor != null)
             {
diff --git a/OpenSim/Region/CoreModules/Framework/InventoryAccess/InventoryAccessModule.cs b/OpenSim/Region/CoreModules/Framework/InventoryAccess/InventoryAccessModule.cs
index a2ba498..42e3359 100644
--- a/OpenSim/Region/CoreModules/Framework/InventoryAccess/InventoryAccessModule.cs
+++ b/OpenSim/Region/CoreModules/Framework/InventoryAccess/InventoryAccessModule.cs
@@ -544,7 +544,7 @@ namespace OpenSim.Region.CoreModules.Framework.InventoryAccess
                     if (!attachment)
                     {
                         group.RootPart.CreateSelected = true;
-                        foreach (SceneObjectPart child in group.Children.Values)
+                        foreach (SceneObjectPart child in group.Parts)
                             child.CreateSelected = true;
                     }
 
@@ -629,10 +629,6 @@ namespace OpenSim.Region.CoreModules.Framework.InventoryAccess
                     rootPart.Name = item.Name;
                     rootPart.Description = item.Description;
 
-                    List<SceneObjectPart> partList = null;
-                    lock (group.Children)
-                        partList = new List<SceneObjectPart>(group.Children.Values);
-
                     group.SetGroup(remoteClient.ActiveGroupId, remoteClient);
                     if ((rootPart.OwnerID != item.Owner) || (item.CurrentPermissions & 16) != 0)
                     {
@@ -642,7 +638,7 @@ namespace OpenSim.Region.CoreModules.Framework.InventoryAccess
 
                         if (m_Scene.Permissions.PropagatePermissions())
                         {
-                            foreach (SceneObjectPart part in partList)
+                            foreach (SceneObjectPart part in group.Parts)
                             {
                                 part.EveryoneMask = item.EveryOnePermissions;
                                 part.NextOwnerMask = item.NextPermissions;
@@ -656,7 +652,8 @@ namespace OpenSim.Region.CoreModules.Framework.InventoryAccess
                     {
                         m_log.Debug("[InventoryAccessModule]: Inventory object has UUID.Zero! Position 8");
                     }
-                    foreach (SceneObjectPart part in partList)
+
+                    foreach (SceneObjectPart part in group.Parts)
                     {
                         if ((part.OwnerID != item.Owner) || (item.CurrentPermissions & 16) != 0)
                         {
diff --git a/OpenSim/Region/CoreModules/World/Archiver/ArchiveReadRequest.cs b/OpenSim/Region/CoreModules/World/Archiver/ArchiveReadRequest.cs
index e51f118..4af7a1b 100644
--- a/OpenSim/Region/CoreModules/World/Archiver/ArchiveReadRequest.cs
+++ b/OpenSim/Region/CoreModules/World/Archiver/ArchiveReadRequest.cs
@@ -243,11 +243,7 @@ namespace OpenSim.Region.CoreModules.World.Archiver
                 // to the same scene (when this is possible).
                 sceneObject.ResetIDs();
 
-                List<SceneObjectPart> partList = null;
-                lock (sceneObject.Children)
-                    partList = new List<SceneObjectPart>(sceneObject.Children.Values);
-                
-                foreach (SceneObjectPart part in partList)
+                foreach (SceneObjectPart part in sceneObject.Parts)
                 {
                     if (!ResolveUserUuid(part.CreatorID))
                         part.CreatorID = m_scene.RegionInfo.EstateSettings.EstateOwner;
diff --git a/OpenSim/Region/CoreModules/World/Objects/BuySell/BuySellModule.cs b/OpenSim/Region/CoreModules/World/Objects/BuySell/BuySellModule.cs
index db50339..d91c36c 100644
--- a/OpenSim/Region/CoreModules/World/Objects/BuySell/BuySellModule.cs
+++ b/OpenSim/Region/CoreModules/World/Objects/BuySell/BuySellModule.cs
@@ -128,14 +128,9 @@ namespace OpenSim.Region.CoreModules.World.Objects.BuySell
                 group.SetOwnerId(remoteClient.AgentId);
                 group.SetRootPartOwner(part, remoteClient.AgentId, remoteClient.ActiveGroupId);
 
-                List<SceneObjectPart> partList = null;
-                
-                lock (group.Children)
-                    partList = new List<SceneObjectPart>(group.Children.Values);
-
                 if (m_scene.Permissions.PropagatePermissions())
                 {
-                    foreach (SceneObjectPart child in partList)
+                    foreach (SceneObjectPart child in group.Parts)
                     {
                         child.Inventory.ChangeInventoryOwner(remoteClient.AgentId);
                         child.TriggerScriptChangedEvent(Changed.OWNER);
diff --git a/OpenSim/Region/CoreModules/World/WorldMap/MapImageModule.cs b/OpenSim/Region/CoreModules/World/WorldMap/MapImageModule.cs
index 1bd1371..c83ac85 100644
--- a/OpenSim/Region/CoreModules/World/WorldMap/MapImageModule.cs
+++ b/OpenSim/Region/CoreModules/World/WorldMap/MapImageModule.cs
@@ -229,11 +229,7 @@ namespace OpenSim.Region.CoreModules.World.WorldMap
                         Color mapdotspot = Color.Gray; // Default color when prim color is white
                         
                         // Loop over prim in group
-                        List<SceneObjectPart> partList = null;
-                        lock (mapdot.Children)
-                            partList = new List<SceneObjectPart>(mapdot.Children.Values);
-                            
-                        foreach (SceneObjectPart part in partList)
+                        foreach (SceneObjectPart part in mapdot.Parts)
                         {
                             if (part == null)
                                 continue;
diff --git a/OpenSim/Region/Framework/Scenes/Scene.Inventory.cs b/OpenSim/Region/Framework/Scenes/Scene.Inventory.cs
index 867fb10..ac82fda 100644
--- a/OpenSim/Region/Framework/Scenes/Scene.Inventory.cs
+++ b/OpenSim/Region/Framework/Scenes/Scene.Inventory.cs
@@ -2064,9 +2064,7 @@ namespace OpenSim.Region.Framework.Scenes
                     sog.SetGroup(groupID, remoteClient);
                     sog.ScheduleGroupForFullUpdate();
 
-                    List<SceneObjectPart> partList = null;
-                    lock (sog.Children)
-                        partList = new List<SceneObjectPart>(sog.Children.Values);
+                    SceneObjectPart[] partList = sog.Parts;
                     
                     foreach (SceneObjectPart child in partList)
                         child.Inventory.ChangeInventoryOwner(ownerID);
@@ -2079,9 +2077,7 @@ namespace OpenSim.Region.Framework.Scenes
                     if (sog.GroupID != groupID)
                         continue;
                     
-                    List<SceneObjectPart> partList = null;
-                    lock (sog.Children)
-                        partList = new List<SceneObjectPart>(sog.Children.Values);
+                    SceneObjectPart[] partList = sog.Parts;
 
                     foreach (SceneObjectPart child in partList)
                     {
diff --git a/OpenSim/Region/Framework/Scenes/Scene.PacketHandlers.cs b/OpenSim/Region/Framework/Scenes/Scene.PacketHandlers.cs
index 7788e43..4d97db7 100644
--- a/OpenSim/Region/Framework/Scenes/Scene.PacketHandlers.cs
+++ b/OpenSim/Region/Framework/Scenes/Scene.PacketHandlers.cs
@@ -161,11 +161,8 @@ namespace OpenSim.Region.Framework.Scenes
                         bool foundPrim = false;
                         
                         SceneObjectGroup sog = ent as SceneObjectGroup;
-                        
-                        List<SceneObjectPart> partList = null;
-                        lock (sog.Children)
-                            partList = new List<SceneObjectPart>(sog.Children.Values);
 
+                        SceneObjectPart[] partList = sog.Parts;
                         foreach (SceneObjectPart part in partList)
                         {
                             if (part.LocalId == primLocalID) 
diff --git a/OpenSim/Region/Framework/Scenes/Scene.cs b/OpenSim/Region/Framework/Scenes/Scene.cs
index 33e3e5d..240d33c 100644
--- a/OpenSim/Region/Framework/Scenes/Scene.cs
+++ b/OpenSim/Region/Framework/Scenes/Scene.cs
@@ -1819,7 +1819,7 @@ namespace OpenSim.Region.Framework.Scenes
                 {
                     m_log.ErrorFormat(
                         "[SCENE]: Found a SceneObjectGroup with m_rootPart == null and {0} children",
-                        group.Children == null ? 0 : group.PrimCount);
+                        group.Parts == null ? 0 : group.PrimCount);
                 }
 
                 AddRestoredSceneObject(group, true, true);
@@ -2160,9 +2160,7 @@ namespace OpenSim.Region.Framework.Scenes
                 group.RemoveScriptInstances(true);
             }
 
-            List<SceneObjectPart> partList = null;
-            lock (group.Children)
-                partList = new List<SceneObjectPart>(group.Children.Values);
+            SceneObjectPart[] partList = group.Parts;
 
             foreach (SceneObjectPart part in partList)
             {
@@ -2540,11 +2538,9 @@ namespace OpenSim.Region.Framework.Scenes
 
             // Force allocation of new LocalId
             //
-            lock (sceneObject.Children)
-            {
-                foreach (SceneObjectPart p in sceneObject.Children.Values)
-                    p.LocalId = 0;
-            }
+            SceneObjectPart[] parts = sceneObject.Parts;
+            for (int i = 0; i < parts.Length; i++)
+                parts[i].LocalId = 0;
 
             if (sceneObject.IsAttachmentCheckFull()) // Attachment
             {
diff --git a/OpenSim/Region/Framework/Scenes/SceneGraph.cs b/OpenSim/Region/Framework/Scenes/SceneGraph.cs
index 9c3486e..5ef14bf 100644
--- a/OpenSim/Region/Framework/Scenes/SceneGraph.cs
+++ b/OpenSim/Region/Framework/Scenes/SceneGraph.cs
@@ -270,7 +270,7 @@ namespace OpenSim.Region.Framework.Scenes
                     if (npos.X > Constants.RegionSize) npos.X = Constants.RegionSize - 1.0f;
                     if (npos.Y > Constants.RegionSize) npos.Y = Constants.RegionSize - 1.0f;
      
-                    foreach (SceneObjectPart part in sceneObject.Children.Values)
+                    foreach (SceneObjectPart part in sceneObject.Parts)
                     {
                         part.GroupPosition = npos;
                     }
@@ -370,9 +370,7 @@ namespace OpenSim.Region.Framework.Scenes
             if (Entities.ContainsKey(sceneObject.UUID))
                 return false;
 
-            List<SceneObjectPart> children;
-            lock (sceneObject.Children)
-                children = new List<SceneObjectPart>(sceneObject.Children.Values);
+            SceneObjectPart[] children = sceneObject.Parts;
 
             // Clamp child prim sizes and add child prims to the m_numPrim count
             if (m_parentScene.m_clampPrimSize)
@@ -391,7 +389,7 @@ namespace OpenSim.Region.Framework.Scenes
                     part.Shape.Scale = scale;
                 }
             }
-            m_numPrim += children.Count;
+            m_numPrim += children.Length;
 
             sceneObject.AttachToScene(m_parentScene);
 
@@ -448,15 +446,17 @@ namespace OpenSim.Region.Framework.Scenes
 
             lock (SceneObjectGroupsByFullID)
             {
-                foreach (SceneObjectPart part in grp.Children.Values)
-                    SceneObjectGroupsByFullID.Remove(part.UUID);
+                SceneObjectPart[] parts = grp.Parts;
+                for (int i = 0; i < parts.Length; i++)
+                    SceneObjectGroupsByFullID.Remove(parts[i].UUID);
                 SceneObjectGroupsByFullID.Remove(grp.RootPart.UUID);
             }
 
             lock (SceneObjectGroupsByLocalID)
             {
-                foreach (SceneObjectPart part in grp.Children.Values)
-                    SceneObjectGroupsByLocalID.Remove(part.LocalId);
+                SceneObjectPart[] parts = grp.Parts;
+                for (int i = 0; i < parts.Length; i++)
+                    SceneObjectGroupsByLocalID.Remove(parts[i].LocalId);
                 SceneObjectGroupsByLocalID.Remove(grp.RootPart.LocalId);
             }
 
@@ -943,11 +943,8 @@ namespace OpenSim.Region.Framework.Scenes
 
             if (sog != null)
             {
-                lock (sog.Children)
-                {
-                    if (sog.Children.ContainsKey(fullID))
-                        return sog;
-                }
+                if (sog.ContainsPart(fullID))
+                    return sog;
 
                 lock (SceneObjectGroupsByFullID)
                     SceneObjectGroupsByFullID.Remove(fullID);
@@ -1021,7 +1018,7 @@ namespace OpenSim.Region.Framework.Scenes
                 {
                     if (entity is SceneObjectGroup)
                     {
-                        foreach (SceneObjectPart p in ((SceneObjectGroup)entity).GetParts())
+                        foreach (SceneObjectPart p in ((SceneObjectGroup)entity).Parts)
                         {
                             if (p.Name == name)
                             {
@@ -1686,14 +1683,8 @@ namespace OpenSim.Region.Framework.Scenes
                     SceneObjectGroup group = root.ParentGroup;
                     group.areUpdatesSuspended = true;
                     
-                    List<SceneObjectPart> newSet = null;
-                    int numChildren;
-                    
-                    lock (group.Children)
-                    {
-                        newSet = new List<SceneObjectPart>(group.Children.Values);
-                        numChildren = group.PrimCount;
-                    }
+                    List<SceneObjectPart> newSet = new List<SceneObjectPart>(group.Parts);
+                    int numChildren = newSet.Count;
 
                     if (numChildren == 1)
                         break;
@@ -1783,16 +1774,13 @@ namespace OpenSim.Region.Framework.Scenes
                 if (ent is SceneObjectGroup)
                 {
                     SceneObjectGroup sog = ent as SceneObjectGroup;
-                    
-                    lock (sog.Children)
+
+                    foreach (SceneObjectPart part in sog.Parts)
                     {
-                        foreach (KeyValuePair<UUID, SceneObjectPart> subent in sog.Children)
+                        if (part.LocalId == localID)
                         {
-                            if (subent.Value.LocalId == localID)
-                            {
-                                objid = subent.Key;
-                                obj = subent.Value;
-                            }
+                            objid = part.UUID;
+                            obj = part;
                         }
                     }
                 }
@@ -1868,8 +1856,7 @@ namespace OpenSim.Region.Framework.Scenes
                         copy.SetOwnerId(AgentID);
                         copy.SetRootPartOwner(copy.RootPart, AgentID, GroupID);
 
-                        List<SceneObjectPart> partList =
-                            new List<SceneObjectPart>(copy.Children.Values);
+                        SceneObjectPart[] partList = copy.Parts;
 
                         if (m_parentScene.Permissions.PropagatePermissions())
                         {
@@ -1891,7 +1878,7 @@ namespace OpenSim.Region.Framework.Scenes
                     // think it's selected, so it will never send a deselect...
                     copy.IsSelected = false;
 
-                    m_numPrim += copy.Children.Count;
+                    m_numPrim += copy.Parts.Length;
 
                     if (rot != Quaternion.Identity)
                     {
diff --git a/OpenSim/Region/Framework/Scenes/SceneObjectGroup.Inventory.cs b/OpenSim/Region/Framework/Scenes/SceneObjectGroup.Inventory.cs
index a7003c4..6cc7231 100644
--- a/OpenSim/Region/Framework/Scenes/SceneObjectGroup.Inventory.cs
+++ b/OpenSim/Region/Framework/Scenes/SceneObjectGroup.Inventory.cs
@@ -46,13 +46,9 @@ namespace OpenSim.Region.Framework.Scenes
         /// </summary>
         public void ForceInventoryPersistence()
         {
-            lockPartsForRead(true);
-            List<SceneObjectPart> values = new List<SceneObjectPart>(m_parts.Values);
-            lockPartsForRead(false);
-            foreach (SceneObjectPart part in values)
-            {
-                part.Inventory.ForceInventoryPersistence();
-            }
+            SceneObjectPart[] parts = m_parts.GetArray();
+            for (int i = 0; i < parts.Length; i++)
+                parts[i].Inventory.ForceInventoryPersistence();
         }
 
         /// <summary>
@@ -64,10 +60,9 @@ namespace OpenSim.Region.Framework.Scenes
             // Don't start scripts if they're turned off in the region!
             if (!m_scene.RegionInfo.RegionSettings.DisableScripts)
             {
-                foreach (SceneObjectPart part in m_parts.Values)
-                {
-                    part.Inventory.CreateScriptInstances(startParam, postOnRez, engine, stateSource);
-                }
+                SceneObjectPart[] parts = m_parts.GetArray();
+                for (int i = 0; i < parts.Length; i++)
+                    parts[i].Inventory.CreateScriptInstances(startParam, postOnRez, engine, stateSource);
             }
         }
 
@@ -76,15 +71,9 @@ namespace OpenSim.Region.Framework.Scenes
         /// </summary>
         public void RemoveScriptInstances(bool sceneObjectBeingDeleted)
         {
-            lockPartsForRead(true);
-            List<SceneObjectPart> values = new List<SceneObjectPart>(m_parts.Values);
-            lockPartsForRead(false);
-            
-            foreach (SceneObjectPart part in values)
-            {
-                part.Inventory.RemoveScriptInstances(sceneObjectBeingDeleted);
-            }
-            
+            SceneObjectPart[] parts = m_parts.GetArray();
+            for (int i = 0; i < parts.Length; i++)
+                parts[i].Inventory.RemoveScriptInstances(sceneObjectBeingDeleted);
         }
 
         /// <summary>
@@ -281,8 +270,11 @@ namespace OpenSim.Region.Framework.Scenes
                               PermissionMask.Transfer) | 7;
 
             uint ownerMask = 0x7fffffff;
-            foreach (SceneObjectPart part in m_parts.Values)
+
+            SceneObjectPart[] parts = m_parts.GetArray();
+            for (int i = 0; i < parts.Length; i++)
             {
+                SceneObjectPart part = parts[i];
                 ownerMask &= part.OwnerMask;
                 perms &= part.Inventory.MaskEffectivePermissions();
             }
@@ -310,39 +302,40 @@ namespace OpenSim.Region.Framework.Scenes
 
         public void ApplyNextOwnerPermissions()
         {
-            foreach (SceneObjectPart part in m_parts.Values)
-            {
-                part.ApplyNextOwnerPermissions();
-            }
+            SceneObjectPart[] parts = m_parts.GetArray();
+            for (int i = 0; i < parts.Length; i++)
+                parts[i].ApplyNextOwnerPermissions();
         }
 
         public string GetStateSnapshot()
         {
             Dictionary<UUID, string> states = new Dictionary<UUID, string>();
 
-            foreach (SceneObjectPart part in m_parts.Values)
+            SceneObjectPart[] parts = m_parts.GetArray();
+            for (int i = 0; i < parts.Length; i++)
             {
+                SceneObjectPart part = parts[i];
                 foreach (KeyValuePair<UUID, string> s in part.Inventory.GetScriptStates())
                     states[s.Key] = s.Value;
             }
 
             if (states.Count < 1)
-                return "";
+                return String.Empty;
 
             XmlDocument xmldoc = new XmlDocument();
 
             XmlNode xmlnode = xmldoc.CreateNode(XmlNodeType.XmlDeclaration,
-                    "", "");
+                    String.Empty, String.Empty);
 
             xmldoc.AppendChild(xmlnode);
             XmlElement rootElement = xmldoc.CreateElement("", "ScriptData",
-                    "");
+                    String.Empty);
             
             xmldoc.AppendChild(rootElement);
 
             
             XmlElement wrapper = xmldoc.CreateElement("", "ScriptStates",
-                    "");
+                    String.Empty);
             
             rootElement.AppendChild(wrapper);
 
@@ -425,10 +418,9 @@ namespace OpenSim.Region.Framework.Scenes
             if (m_scene.RegionInfo.RegionSettings.DisableScripts)
                 return;
 
-            foreach (SceneObjectPart part in m_parts.Values)
-            {
-                part.Inventory.ResumeScripts();
-            }
+            SceneObjectPart[] parts = m_parts.GetArray();
+            for (int i = 0; i < parts.Length; i++)
+                parts[i].Inventory.ResumeScripts();
         }
     }
 }
diff --git a/OpenSim/Region/Framework/Scenes/SceneObjectGroup.cs b/OpenSim/Region/Framework/Scenes/SceneObjectGroup.cs
index 142f5d8..3bc7834 100644
--- a/OpenSim/Region/Framework/Scenes/SceneObjectGroup.cs
+++ b/OpenSim/Region/Framework/Scenes/SceneObjectGroup.cs
@@ -131,89 +131,6 @@ namespace OpenSim.Region.Framework.Scenes
             }
         }
 
-        public void lockPartsForRead(bool locked)
-        {
-            if (locked)
-            {
-                if (m_partsLock.RecursiveReadCount > 0)
-                {
-                    m_log.Error("[SceneObjectGroup.m_parts] Recursive read lock requested. This should not happen and means something needs to be fixed. For now though, it's safe to continue.");
-                    try
-                    {
-                        StackTrace stackTrace = new StackTrace();           // get call stack
-                        StackFrame[] stackFrames = stackTrace.GetFrames();  // get method calls (frames)
-
-                        // write call stack method names
-                        foreach (StackFrame stackFrame in stackFrames)
-                        {
-                            m_log.Error("[SceneObjectGroup.m_parts]  "+(stackFrame.GetMethod().Name));   // write method name
-                        }
-
-                        m_partsLock.ExitReadLock();
-                    }
-                    catch { } // Ignore errors, to allow resync
-                }
-                if (m_partsLock.RecursiveWriteCount > 0)
-                {
-                    m_log.Error("[SceneObjectGroup.m_parts] Recursive read lock requested (write lock exists on this thread). This should not happen and means something needs to be fixed.");
-                    try
-                    {
-                        m_partsLock.ExitWriteLock();
-                    }
-                    catch { }
-
-                }
-
-                while (!m_partsLock.TryEnterReadLock(60000))
-                {
-                    m_log.Error("[SceneObjectGroup.m_parts] Thread lock detected while trying to aquire READ lock of m_parts in SceneObjectGroup. I'm going to try to solve the thread lock automatically to preserve region stability, but this needs to be fixed.");
-                    if (m_partsLock.IsWriteLockHeld)
-                    {
-                        m_partsLock = new System.Threading.ReaderWriterLockSlim();
-                    }
-                }
-            }
-            else
-            {
-                if (m_partsLock.RecursiveReadCount > 0)
-                {
-                    m_partsLock.ExitReadLock();
-                }
-            }
-        }
-        public void lockPartsForWrite(bool locked)
-        {
-            if (locked)
-            {
-                if (m_partsLock.RecursiveReadCount > 0)
-                {
-                    m_log.Error("[SceneObjectGroup.m_parts] Recursive write lock requested. This should not happen and means something needs to be fixed. For now though, it's safe to continue.");
-                    m_partsLock.ExitReadLock();
-                }
-                if (m_partsLock.RecursiveWriteCount > 0)
-                {
-                    m_log.Error("[SceneObjectGroup.m_parts] Recursive write lock requested. This should not happen and means something needs to be fixed.");
-                    m_partsLock.ExitWriteLock();
-                }
-
-                while (!m_partsLock.TryEnterWriteLock(60000))
-                {
-                    m_log.Error("[SceneObjectGroup.m_parts] Thread lock detected while trying to aquire WRITE lock of m_scripts in XEngine. I'm going to try to solve the thread lock automatically to preserve region stability, but this needs to be fixed.");
-                    if (m_partsLock.IsWriteLockHeld)
-                    {
-                        m_partsLock = new System.Threading.ReaderWriterLockSlim();
-                    }
-                }
-            }
-            else
-            {
-                if (m_partsLock.RecursiveWriteCount > 0)
-                {
-                    m_partsLock.ExitWriteLock();
-                }
-            }
-        }
-
         public bool HasGroupChanged
         {
             set
@@ -305,17 +222,14 @@ namespace OpenSim.Region.Framework.Scenes
             }
         }
 
-        public float scriptScore = 0f;
+        public float scriptScore;
 
         private Vector3 lastPhysGroupPos;
         private Quaternion lastPhysGroupRot;
 
-        private bool m_isBackedUp = false;
+        private bool m_isBackedUp;
 
-        /// <summary>
-        /// The constituent parts of this group
-        /// </summary>
-        protected Dictionary<UUID, SceneObjectPart> m_parts = new Dictionary<UUID, SceneObjectPart>();
+        protected MapAndArray<UUID, SceneObjectPart> m_parts = new MapAndArray<UUID, SceneObjectPart>();
 
         protected ulong m_regionHandle;
         protected SceneObjectPart m_rootPart;
@@ -324,13 +238,13 @@ namespace OpenSim.Region.Framework.Scenes
         private Dictionary<uint, scriptPosTarget> m_targets = new Dictionary<uint, scriptPosTarget>();
         private Dictionary<uint, scriptRotTarget> m_rotTargets = new Dictionary<uint, scriptRotTarget>();
 
-        private bool m_scriptListens_atTarget = false;
-        private bool m_scriptListens_notAtTarget = false;
+        private bool m_scriptListens_atTarget;
+        private bool m_scriptListens_notAtTarget;
+        private bool m_scriptListens_atRotTarget;
+        private bool m_scriptListens_notAtRotTarget;
 
-        private bool m_scriptListens_atRotTarget = false;
-        private bool m_scriptListens_notAtRotTarget = false;
         public bool m_dupeInProgress = false;
-        internal Dictionary<UUID, string> m_savedScriptState = null;
+        internal Dictionary<UUID, string> m_savedScriptState;
 
         #region Properties
 
@@ -341,7 +255,7 @@ namespace OpenSim.Region.Framework.Scenes
         {
             get {
                 if (RootPart == null)
-                    return "";
+                    return String.Empty;
                 return RootPart.Name;
             }
             set { RootPart.Name = value; }
@@ -361,7 +275,7 @@ namespace OpenSim.Region.Framework.Scenes
         /// </summary>
         public int PrimCount
         {
-            get { lock (m_parts) { return m_parts.Count; } }
+            get { return m_parts.Count; }
         }
 
         protected Quaternion m_rotation = Quaternion.Identity;
@@ -370,17 +284,9 @@ namespace OpenSim.Region.Framework.Scenes
         {
             get { return m_rotation; }
             set {
-                lockPartsForRead(true);
-                try
+                foreach(SceneObjectPart p in m_parts.GetArray())
                 {
-                    foreach(SceneObjectPart p in m_parts.Values)
-                    {
-                        p.StoreUndoState(UndoType.STATE_GROUP_ROTATION);
-                    }
-                }
-                finally
-                {
-                    lockPartsForRead(false);
+                    p.StoreUndoState(UndoType.STATE_GROUP_ROTATION);
                 }
                 m_rotation = value; 
             }
@@ -397,16 +303,14 @@ namespace OpenSim.Region.Framework.Scenes
             set { m_rootPart.GroupID = value; }
         }
 
-        /// <value>
-        /// The parts of this scene object group.  You must lock this property before using it.
-        /// If you're doing anything other than reading values, please take a copy of the values rather than locking
-        /// the dictionary for the entirety of the operation.  This increases liveness and reduces the danger of deadlock
-        /// If you want to know the number of children, consider using the PrimCount property instead
-        /// </value>
-        public Dictionary<UUID, SceneObjectPart> Children
+        public SceneObjectPart[] Parts
+        {
+            get { return m_parts.GetArray(); }
+        }
+
+        public bool ContainsPart(UUID partID)
         {
-            get { return m_parts; }
-            set { m_parts = value; }
+            return m_parts.ContainsKey(partID);
         }
 
         /// <value>
@@ -423,16 +327,9 @@ namespace OpenSim.Region.Framework.Scenes
             set
             {
                 m_regionHandle = value;
-                lockPartsForRead(true);
-                {
-                    foreach (SceneObjectPart part in m_parts.Values)
-                    {
-                        
-                        part.RegionHandle = m_regionHandle;
-                        
-                    }
-                }
-                lockPartsForRead(false);
+                SceneObjectPart[] parts = m_parts.GetArray();
+                for (int i = 0; i < parts.Length; i++)
+                    parts[i].RegionHandle = value;
             }
         }
 
@@ -467,8 +364,7 @@ namespace OpenSim.Region.Framework.Scenes
                     m_scene.CrossPrimGroupIntoNewRegion(val, this, true);
                 }
 
-                lockPartsForRead(true);
-                foreach (SceneObjectPart part in m_parts.Values)
+                foreach (SceneObjectPart part in m_parts.GetArray())
                 {
                     part.IgnoreUndoUpdate = true;
                 }
@@ -479,12 +375,10 @@ namespace OpenSim.Region.Framework.Scenes
                         RootPart.ScriptSetPhysicsStatus(false);
                         Scene.SimChat(Utils.StringToBytes("Hit Sandbox Limit"),
                               ChatTypeEnum.DebugChannel, 0x7FFFFFFF, RootPart.AbsolutePosition, Name, UUID, false);
-                        lockPartsForRead(false);
                         return;
                     }
                 }
-                List<SceneObjectPart> parts = new List<SceneObjectPart>(m_parts.Values);
-                lockPartsForRead(false);
+                SceneObjectPart[] parts = m_parts.GetArray();
                 foreach (SceneObjectPart part in parts)
                 {
                     part.IgnoreUndoUpdate = false;
@@ -499,10 +393,14 @@ namespace OpenSim.Region.Framework.Scenes
                 {
                     foreach (ScenePresence av in m_linkedAvatars)
                     {
-                        Vector3 offset = m_parts[av.LinkedPrim].GetWorldPosition() - av.ParentPosition;
-                        av.AbsolutePosition += offset;
-                        av.ParentPosition = m_parts[av.LinkedPrim].GetWorldPosition(); //ParentPosition gets cleared by AbsolutePosition
-                        av.SendFullUpdateToAllClients();
+                        SceneObjectPart p;
+                        if (m_parts.TryGetValue(av.LinkedPrim, out p))
+                        {
+                            Vector3 offset = p.GetWorldPosition() - av.ParentPosition;
+                            av.AbsolutePosition += offset;
+                            av.ParentPosition = p.GetWorldPosition(); //ParentPosition gets cleared by AbsolutePosition
+                            av.SendFullUpdateToAllClients();
+                        }
                     }
                 }
 
@@ -526,14 +424,9 @@ namespace OpenSim.Region.Framework.Scenes
         {
             get { return m_rootPart.UUID; }
             set 
-            { 
-                m_rootPart.UUID = value; 
-                
-                lock (m_parts)
-                {
-                    m_parts.Remove(m_rootPart.UUID);
-                    m_parts.Add(m_rootPart.UUID, m_rootPart);
-                }
+            {
+                m_rootPart.UUID = value;
+                m_parts.AddOrReplace(value, m_rootPart);
             }
         }
 
@@ -595,12 +488,12 @@ namespace OpenSim.Region.Framework.Scenes
                 {
                     m_rootPart.PhysActor.Selected = value;
                     // Pass it on to the children.
-                    foreach (SceneObjectPart child in Children.Values)
+                    SceneObjectPart[] parts = m_parts.GetArray();
+                    for (int i = 0; i < parts.Length; i++)
                     {
+                        SceneObjectPart child = parts[i];
                         if (child.PhysActor != null)
-                        {
                             child.PhysActor.Selected = value;
-                        }
                     }
                 }
             }
@@ -704,16 +597,9 @@ namespace OpenSim.Region.Framework.Scenes
 
         public void SetFromItemID(UUID AssetId)
         {
-            lockPartsForRead(true);
-            {
-                foreach (SceneObjectPart part in m_parts.Values)
-                {
-                    
-                    part.FromItemID = AssetId;
-                    
-                }
-            }
-            lockPartsForRead(false);
+            SceneObjectPart[] parts = m_parts.GetArray();
+            for (int i = 0; i < parts.Length; i++)
+                parts[i].FromItemID = AssetId;
         }
 
         public UUID GetFromItemID()
@@ -755,23 +641,18 @@ namespace OpenSim.Region.Framework.Scenes
             if (m_rootPart.LocalId == 0)
                 m_rootPart.LocalId = m_scene.AllocateLocalId();
 
-            lock (m_parts)
+            SceneObjectPart[] parts = m_parts.GetArray();
+            for (int i = 0; i < parts.Length; i++)
             {
-                foreach (SceneObjectPart part in m_parts.Values)
-                {
-                    if (Object.ReferenceEquals(part, m_rootPart))
-                    {
-                        continue;
-                    }
-    
-                    if (part.LocalId == 0)
-                    {
-                        part.LocalId = m_scene.AllocateLocalId();
-                    }
-    
-                    part.ParentID = m_rootPart.LocalId;
-                    //m_log.DebugFormat("[SCENE]: Given local id {0} to part {1}, linknum {2}, parent {3} {4}", part.LocalId, part.UUID, part.LinkNum, part.ParentID, part.ParentUUID);
-                }
+                SceneObjectPart part = parts[i];
+                if (Object.ReferenceEquals(part, m_rootPart))
+                    continue;
+
+                if (part.LocalId == 0)
+                    part.LocalId = m_scene.AllocateLocalId();
+
+                part.ParentID = m_rootPart.LocalId;
+                //m_log.DebugFormat("[SCENE]: Given local id {0} to part {1}, linknum {2}, parent {3} {4}", part.LocalId, part.UUID, part.LinkNum, part.ParentID, part.ParentUUID);
             }
             
             ApplyPhysics(m_scene.m_physicalPrim);
@@ -787,24 +668,21 @@ namespace OpenSim.Region.Framework.Scenes
             Vector3 maxScale = Vector3.Zero;
             Vector3 finalScale = new Vector3(0.5f, 0.5f, 0.5f);
 
-            lockPartsForRead(true);
+            SceneObjectPart[] parts = m_parts.GetArray();
+            for (int i = 0; i < parts.Length; i++)
             {
-                foreach (SceneObjectPart part in m_parts.Values)
-                {
-                    Vector3 partscale = part.Scale;
-                    Vector3 partoffset = part.OffsetPosition;
+                SceneObjectPart part = parts[i];
+                Vector3 partscale = part.Scale;
+                Vector3 partoffset = part.OffsetPosition;
 
-                    minScale.X = (partscale.X + partoffset.X < minScale.X) ? partscale.X + partoffset.X : minScale.X;
-                    minScale.Y = (partscale.Y + partoffset.Y < minScale.Y) ? partscale.Y + partoffset.Y : minScale.Y;
-                    minScale.Z = (partscale.Z + partoffset.Z < minScale.Z) ? partscale.Z + partoffset.Z : minScale.Z;
+                minScale.X = (partscale.X + partoffset.X < minScale.X) ? partscale.X + partoffset.X : minScale.X;
+                minScale.Y = (partscale.Y + partoffset.Y < minScale.Y) ? partscale.Y + partoffset.Y : minScale.Y;
+                minScale.Z = (partscale.Z + partoffset.Z < minScale.Z) ? partscale.Z + partoffset.Z : minScale.Z;
 
-                    maxScale.X = (partscale.X + partoffset.X > maxScale.X) ? partscale.X + partoffset.X : maxScale.X;
-                    maxScale.Y = (partscale.Y + partoffset.Y > maxScale.Y) ? partscale.Y + partoffset.Y : maxScale.Y;
-                    maxScale.Z = (partscale.Z + partoffset.Z > maxScale.Z) ? partscale.Z + partoffset.Z : maxScale.Z;
-                    
-                }
+                maxScale.X = (partscale.X + partoffset.X > maxScale.X) ? partscale.X + partoffset.X : maxScale.X;
+                maxScale.Y = (partscale.Y + partoffset.Y > maxScale.Y) ? partscale.Y + partoffset.Y : maxScale.Y;
+                maxScale.Z = (partscale.Z + partoffset.Z > maxScale.Z) ? partscale.Z + partoffset.Z : maxScale.Z;
             }
-            lockPartsForRead(false);
 
             finalScale.X = (minScale.X > maxScale.X) ? minScale.X : maxScale.X;
             finalScale.Y = (minScale.Y > maxScale.Y) ? minScale.Y : maxScale.Y;
@@ -821,42 +699,40 @@ namespace OpenSim.Region.Framework.Scenes
 
             EntityIntersection result = new EntityIntersection();
 
-            lockPartsForRead(true);
+            SceneObjectPart[] parts = m_parts.GetArray();
+            for (int i = 0; i < parts.Length; i++)
             {
-                foreach (SceneObjectPart part in m_parts.Values)
-                {
-                    
-                    // Temporary commented to stop compiler warning
-                    //Vector3 partPosition =
-                    //    new Vector3(part.AbsolutePosition.X, part.AbsolutePosition.Y, part.AbsolutePosition.Z);
-                    Quaternion parentrotation = GroupRotation;
+                SceneObjectPart part = parts[i];
+
+                // Temporary commented to stop compiler warning
+                //Vector3 partPosition =
+                //    new Vector3(part.AbsolutePosition.X, part.AbsolutePosition.Y, part.AbsolutePosition.Z);
+                Quaternion parentrotation = GroupRotation;
 
-                    // Telling the prim to raytrace.
-                    //EntityIntersection inter = part.TestIntersection(hRay, parentrotation);
+                // Telling the prim to raytrace.
+                //EntityIntersection inter = part.TestIntersection(hRay, parentrotation);
 
-                    EntityIntersection inter = part.TestIntersectionOBB(hRay, parentrotation,frontFacesOnly, faceCenters);
+                EntityIntersection inter = part.TestIntersectionOBB(hRay, parentrotation, frontFacesOnly, faceCenters);
 
-                    // This may need to be updated to the maximum draw distance possible..
-                    // We might (and probably will) be checking for prim creation from other sims
-                    // when the camera crosses the border.
-                    float idist = Constants.RegionSize;
+                // This may need to be updated to the maximum draw distance possible..
+                // We might (and probably will) be checking for prim creation from other sims
+                // when the camera crosses the border.
+                float idist = Constants.RegionSize;
 
-                    if (inter.HitTF)
+                if (inter.HitTF)
+                {
+                    // We need to find the closest prim to return to the testcaller along the ray
+                    if (inter.distance < idist)
                     {
-                        // We need to find the closest prim to return to the testcaller along the ray
-                        if (inter.distance < idist)
-                        {
-                            result.HitTF = true;
-                            result.ipoint = inter.ipoint;
-                            result.obj = part;
-                            result.normal = inter.normal;
-                            result.distance = inter.distance;
-                        }
+                        result.HitTF = true;
+                        result.ipoint = inter.ipoint;
+                        result.obj = part;
+                        result.normal = inter.normal;
+                        result.distance = inter.distance;
                     }
                     
                 }
             }
-            lockPartsForRead(false);
             return result;
         }
 
@@ -875,243 +751,239 @@ namespace OpenSim.Region.Framework.Scenes
             minY = 256f;
             minZ = 8192f;
 
-            lockPartsForRead(true);
+            SceneObjectPart[] parts = m_parts.GetArray();
+            foreach (SceneObjectPart part in parts)
             {
-                foreach (SceneObjectPart part in m_parts.Values)
+                Vector3 worldPos = part.GetWorldPosition();
+                Vector3 offset = worldPos - AbsolutePosition;
+                Quaternion worldRot;
+                if (part.ParentID == 0)
                 {
-                    
-                    Vector3 worldPos = part.GetWorldPosition();
-                    Vector3 offset = worldPos - AbsolutePosition;
-                    Quaternion worldRot;
-                    if (part.ParentID == 0)
-                    {
-                        worldRot = part.RotationOffset;
-                    }
-                    else
-                    {
-                        worldRot = part.GetWorldRotation();
-                    }
+                    worldRot = part.RotationOffset;
+                }
+                else
+                {
+                    worldRot = part.GetWorldRotation();
+                }
 
-                    Vector3 frontTopLeft;
-                    Vector3 frontTopRight;
-                    Vector3 frontBottomLeft;
-                    Vector3 frontBottomRight;
+                Vector3 frontTopLeft;
+                Vector3 frontTopRight;
+                Vector3 frontBottomLeft;
+                Vector3 frontBottomRight;
 
-                    Vector3 backTopLeft;
-                    Vector3 backTopRight;
-                    Vector3 backBottomLeft;
-                    Vector3 backBottomRight;
+                Vector3 backTopLeft;
+                Vector3 backTopRight;
+                Vector3 backBottomLeft;
+                Vector3 backBottomRight;
 
-                   // Vector3[] corners = new Vector3[8];
+               // Vector3[] corners = new Vector3[8];
 
-                    Vector3 orig = Vector3.Zero;
+                Vector3 orig = Vector3.Zero;
 
-                    frontTopLeft.X = orig.X - (part.Scale.X / 2);
-                    frontTopLeft.Y = orig.Y - (part.Scale.Y / 2);
-                    frontTopLeft.Z = orig.Z + (part.Scale.Z / 2);
+                frontTopLeft.X = orig.X - (part.Scale.X / 2);
+                frontTopLeft.Y = orig.Y - (part.Scale.Y / 2);
+                frontTopLeft.Z = orig.Z + (part.Scale.Z / 2);
 
-                    frontTopRight.X = orig.X - (part.Scale.X / 2);
-                    frontTopRight.Y = orig.Y + (part.Scale.Y / 2);
-                    frontTopRight.Z = orig.Z + (part.Scale.Z / 2);
+                frontTopRight.X = orig.X - (part.Scale.X / 2);
+                frontTopRight.Y = orig.Y + (part.Scale.Y / 2);
+                frontTopRight.Z = orig.Z + (part.Scale.Z / 2);
 
-                    frontBottomLeft.X = orig.X - (part.Scale.X / 2);
-                    frontBottomLeft.Y = orig.Y - (part.Scale.Y / 2);
-                    frontBottomLeft.Z = orig.Z - (part.Scale.Z / 2);
+                frontBottomLeft.X = orig.X - (part.Scale.X / 2);
+                frontBottomLeft.Y = orig.Y - (part.Scale.Y / 2);
+                frontBottomLeft.Z = orig.Z - (part.Scale.Z / 2);
 
-                    frontBottomRight.X = orig.X - (part.Scale.X / 2);
-                    frontBottomRight.Y = orig.Y + (part.Scale.Y / 2);
-                    frontBottomRight.Z = orig.Z - (part.Scale.Z / 2);
+                frontBottomRight.X = orig.X - (part.Scale.X / 2);
+                frontBottomRight.Y = orig.Y + (part.Scale.Y / 2);
+                frontBottomRight.Z = orig.Z - (part.Scale.Z / 2);
 
-                    backTopLeft.X = orig.X + (part.Scale.X / 2);
-                    backTopLeft.Y = orig.Y - (part.Scale.Y / 2);
-                    backTopLeft.Z = orig.Z + (part.Scale.Z / 2);
+                backTopLeft.X = orig.X + (part.Scale.X / 2);
+                backTopLeft.Y = orig.Y - (part.Scale.Y / 2);
+                backTopLeft.Z = orig.Z + (part.Scale.Z / 2);
 
-                    backTopRight.X = orig.X + (part.Scale.X / 2);
-                    backTopRight.Y = orig.Y + (part.Scale.Y / 2);
-                    backTopRight.Z = orig.Z + (part.Scale.Z / 2);
+                backTopRight.X = orig.X + (part.Scale.X / 2);
+                backTopRight.Y = orig.Y + (part.Scale.Y / 2);
+                backTopRight.Z = orig.Z + (part.Scale.Z / 2);
 
-                    backBottomLeft.X = orig.X + (part.Scale.X / 2);
-                    backBottomLeft.Y = orig.Y - (part.Scale.Y / 2);
-                    backBottomLeft.Z = orig.Z - (part.Scale.Z / 2);
+                backBottomLeft.X = orig.X + (part.Scale.X / 2);
+                backBottomLeft.Y = orig.Y - (part.Scale.Y / 2);
+                backBottomLeft.Z = orig.Z - (part.Scale.Z / 2);
 
-                    backBottomRight.X = orig.X + (part.Scale.X / 2);
-                    backBottomRight.Y = orig.Y + (part.Scale.Y / 2);
-                    backBottomRight.Z = orig.Z - (part.Scale.Z / 2);
+                backBottomRight.X = orig.X + (part.Scale.X / 2);
+                backBottomRight.Y = orig.Y + (part.Scale.Y / 2);
+                backBottomRight.Z = orig.Z - (part.Scale.Z / 2);
 
-                    
+                
 
-                    //m_log.InfoFormat("pre corner 1 is {0} {1} {2}", frontTopLeft.X, frontTopLeft.Y, frontTopLeft.Z);
-                    //m_log.InfoFormat("pre corner 2 is {0} {1} {2}", frontTopRight.X, frontTopRight.Y, frontTopRight.Z);
-                    //m_log.InfoFormat("pre corner 3 is {0} {1} {2}", frontBottomRight.X, frontBottomRight.Y, frontBottomRight.Z);
-                    //m_log.InfoFormat("pre corner 4 is {0} {1} {2}", frontBottomLeft.X, frontBottomLeft.Y, frontBottomLeft.Z);
-                    //m_log.InfoFormat("pre corner 5 is {0} {1} {2}", backTopLeft.X, backTopLeft.Y, backTopLeft.Z);
-                    //m_log.InfoFormat("pre corner 6 is {0} {1} {2}", backTopRight.X, backTopRight.Y, backTopRight.Z);
-                    //m_log.InfoFormat("pre corner 7 is {0} {1} {2}", backBottomRight.X, backBottomRight.Y, backBottomRight.Z);
-                    //m_log.InfoFormat("pre corner 8 is {0} {1} {2}", backBottomLeft.X, backBottomLeft.Y, backBottomLeft.Z);
-
-                    //for (int i = 0; i < 8; i++)
-                    //{
-                    //    corners[i] = corners[i] * worldRot;
-                    //    corners[i] += offset;
-
-                    //    if (corners[i].X > maxX)
-                    //        maxX = corners[i].X;
-                    //    if (corners[i].X < minX)
-                    //        minX = corners[i].X;
-
-                    //    if (corners[i].Y > maxY)
-                    //        maxY = corners[i].Y;
-                    //    if (corners[i].Y < minY)
-                    //        minY = corners[i].Y;
-
-                    //    if (corners[i].Z > maxZ)
-                    //        maxZ = corners[i].Y;
-                    //    if (corners[i].Z < minZ)
-                    //        minZ = corners[i].Z;
-                    //}
-
-                    frontTopLeft = frontTopLeft * worldRot;
-                    frontTopRight = frontTopRight * worldRot;
-                    frontBottomLeft = frontBottomLeft * worldRot;
-                    frontBottomRight = frontBottomRight * worldRot;
-
-                    backBottomLeft = backBottomLeft * worldRot;
-                    backBottomRight = backBottomRight * worldRot;
-                    backTopLeft = backTopLeft * worldRot;
-                    backTopRight = backTopRight * worldRot;
-
-
-                    frontTopLeft += offset;
-                    frontTopRight += offset;
-                    frontBottomLeft += offset;
-                    frontBottomRight += offset;
-
-                    backBottomLeft += offset;
-                    backBottomRight += offset;
-                    backTopLeft += offset;
-                    backTopRight += offset;
-
-                    //m_log.InfoFormat("corner 1 is {0} {1} {2}", frontTopLeft.X, frontTopLeft.Y, frontTopLeft.Z);
-                    //m_log.InfoFormat("corner 2 is {0} {1} {2}", frontTopRight.X, frontTopRight.Y, frontTopRight.Z);
-                    //m_log.InfoFormat("corner 3 is {0} {1} {2}", frontBottomRight.X, frontBottomRight.Y, frontBottomRight.Z);
-                    //m_log.InfoFormat("corner 4 is {0} {1} {2}", frontBottomLeft.X, frontBottomLeft.Y, frontBottomLeft.Z);
-                    //m_log.InfoFormat("corner 5 is {0} {1} {2}", backTopLeft.X, backTopLeft.Y, backTopLeft.Z);
-                    //m_log.InfoFormat("corner 6 is {0} {1} {2}", backTopRight.X, backTopRight.Y, backTopRight.Z);
-                    //m_log.InfoFormat("corner 7 is {0} {1} {2}", backBottomRight.X, backBottomRight.Y, backBottomRight.Z);
-                    //m_log.InfoFormat("corner 8 is {0} {1} {2}", backBottomLeft.X, backBottomLeft.Y, backBottomLeft.Z);
-
-                    if (frontTopRight.X > maxX)
-                        maxX = frontTopRight.X;
-                    if (frontTopLeft.X > maxX)
-                        maxX = frontTopLeft.X;
-                    if (frontBottomRight.X > maxX)
-                        maxX = frontBottomRight.X;
-                    if (frontBottomLeft.X > maxX)
-                        maxX = frontBottomLeft.X;
-
-                    if (backTopRight.X > maxX)
-                        maxX = backTopRight.X;
-                    if (backTopLeft.X > maxX)
-                        maxX = backTopLeft.X;
-                    if (backBottomRight.X > maxX)
-                        maxX = backBottomRight.X;
-                    if (backBottomLeft.X > maxX)
-                        maxX = backBottomLeft.X;
-
-                    if (frontTopRight.X < minX)
-                        minX = frontTopRight.X;
-                    if (frontTopLeft.X < minX)
-                        minX = frontTopLeft.X;
-                    if (frontBottomRight.X < minX)
-                        minX = frontBottomRight.X;
-                    if (frontBottomLeft.X < minX)
-                        minX = frontBottomLeft.X;
-
-                    if (backTopRight.X < minX)
-                        minX = backTopRight.X;
-                    if (backTopLeft.X < minX)
-                        minX = backTopLeft.X;
-                    if (backBottomRight.X < minX)
-                        minX = backBottomRight.X;
-                    if (backBottomLeft.X < minX)
-                        minX = backBottomLeft.X;
+                //m_log.InfoFormat("pre corner 1 is {0} {1} {2}", frontTopLeft.X, frontTopLeft.Y, frontTopLeft.Z);
+                //m_log.InfoFormat("pre corner 2 is {0} {1} {2}", frontTopRight.X, frontTopRight.Y, frontTopRight.Z);
+                //m_log.InfoFormat("pre corner 3 is {0} {1} {2}", frontBottomRight.X, frontBottomRight.Y, frontBottomRight.Z);
+                //m_log.InfoFormat("pre corner 4 is {0} {1} {2}", frontBottomLeft.X, frontBottomLeft.Y, frontBottomLeft.Z);
+                //m_log.InfoFormat("pre corner 5 is {0} {1} {2}", backTopLeft.X, backTopLeft.Y, backTopLeft.Z);
+                //m_log.InfoFormat("pre corner 6 is {0} {1} {2}", backTopRight.X, backTopRight.Y, backTopRight.Z);
+                //m_log.InfoFormat("pre corner 7 is {0} {1} {2}", backBottomRight.X, backBottomRight.Y, backBottomRight.Z);
+                //m_log.InfoFormat("pre corner 8 is {0} {1} {2}", backBottomLeft.X, backBottomLeft.Y, backBottomLeft.Z);
 
-                    //
-                    if (frontTopRight.Y > maxY)
-                        maxY = frontTopRight.Y;
-                    if (frontTopLeft.Y > maxY)
-                        maxY = frontTopLeft.Y;
-                    if (frontBottomRight.Y > maxY)
-                        maxY = frontBottomRight.Y;
-                    if (frontBottomLeft.Y > maxY)
-                        maxY = frontBottomLeft.Y;
-
-                    if (backTopRight.Y > maxY)
-                        maxY = backTopRight.Y;
-                    if (backTopLeft.Y > maxY)
-                        maxY = backTopLeft.Y;
-                    if (backBottomRight.Y > maxY)
-                        maxY = backBottomRight.Y;
-                    if (backBottomLeft.Y > maxY)
-                        maxY = backBottomLeft.Y;
-
-                    if (frontTopRight.Y < minY)
-                        minY = frontTopRight.Y;
-                    if (frontTopLeft.Y < minY)
-                        minY = frontTopLeft.Y;
-                    if (frontBottomRight.Y < minY)
-                        minY = frontBottomRight.Y;
-                    if (frontBottomLeft.Y < minY)
-                        minY = frontBottomLeft.Y;
-
-                    if (backTopRight.Y < minY)
-                        minY = backTopRight.Y;
-                    if (backTopLeft.Y < minY)
-                        minY = backTopLeft.Y;
-                    if (backBottomRight.Y < minY)
-                        minY = backBottomRight.Y;
-                    if (backBottomLeft.Y < minY)
-                        minY = backBottomLeft.Y;
+                //for (int i = 0; i < 8; i++)
+                //{
+                //    corners[i] = corners[i] * worldRot;
+                //    corners[i] += offset;
+
+                //    if (corners[i].X > maxX)
+                //        maxX = corners[i].X;
+                //    if (corners[i].X < minX)
+                //        minX = corners[i].X;
+
+                //    if (corners[i].Y > maxY)
+                //        maxY = corners[i].Y;
+                //    if (corners[i].Y < minY)
+                //        minY = corners[i].Y;
+
+                //    if (corners[i].Z > maxZ)
+                //        maxZ = corners[i].Y;
+                //    if (corners[i].Z < minZ)
+                //        minZ = corners[i].Z;
+                //}
 
-                    //
-                    if (frontTopRight.Z > maxZ)
-                        maxZ = frontTopRight.Z;
-                    if (frontTopLeft.Z > maxZ)
-                        maxZ = frontTopLeft.Z;
-                    if (frontBottomRight.Z > maxZ)
-                        maxZ = frontBottomRight.Z;
-                    if (frontBottomLeft.Z > maxZ)
-                        maxZ = frontBottomLeft.Z;
-
-                    if (backTopRight.Z > maxZ)
-                        maxZ = backTopRight.Z;
-                    if (backTopLeft.Z > maxZ)
-                        maxZ = backTopLeft.Z;
-                    if (backBottomRight.Z > maxZ)
-                        maxZ = backBottomRight.Z;
-                    if (backBottomLeft.Z > maxZ)
-                        maxZ = backBottomLeft.Z;
-
-                    if (frontTopRight.Z < minZ)
-                        minZ = frontTopRight.Z;
-                    if (frontTopLeft.Z < minZ)
-                        minZ = frontTopLeft.Z;
-                    if (frontBottomRight.Z < minZ)
-                        minZ = frontBottomRight.Z;
-                    if (frontBottomLeft.Z < minZ)
-                        minZ = frontBottomLeft.Z;
-
-                    if (backTopRight.Z < minZ)
-                        minZ = backTopRight.Z;
-                    if (backTopLeft.Z < minZ)
-                        minZ = backTopLeft.Z;
-                    if (backBottomRight.Z < minZ)
-                        minZ = backBottomRight.Z;
-                    if (backBottomLeft.Z < minZ)
-                        minZ = backBottomLeft.Z;
-                }
+                frontTopLeft = frontTopLeft * worldRot;
+                frontTopRight = frontTopRight * worldRot;
+                frontBottomLeft = frontBottomLeft * worldRot;
+                frontBottomRight = frontBottomRight * worldRot;
+
+                backBottomLeft = backBottomLeft * worldRot;
+                backBottomRight = backBottomRight * worldRot;
+                backTopLeft = backTopLeft * worldRot;
+                backTopRight = backTopRight * worldRot;
+
+
+                frontTopLeft += offset;
+                frontTopRight += offset;
+                frontBottomLeft += offset;
+                frontBottomRight += offset;
+
+                backBottomLeft += offset;
+                backBottomRight += offset;
+                backTopLeft += offset;
+                backTopRight += offset;
+
+                //m_log.InfoFormat("corner 1 is {0} {1} {2}", frontTopLeft.X, frontTopLeft.Y, frontTopLeft.Z);
+                //m_log.InfoFormat("corner 2 is {0} {1} {2}", frontTopRight.X, frontTopRight.Y, frontTopRight.Z);
+                //m_log.InfoFormat("corner 3 is {0} {1} {2}", frontBottomRight.X, frontBottomRight.Y, frontBottomRight.Z);
+                //m_log.InfoFormat("corner 4 is {0} {1} {2}", frontBottomLeft.X, frontBottomLeft.Y, frontBottomLeft.Z);
+                //m_log.InfoFormat("corner 5 is {0} {1} {2}", backTopLeft.X, backTopLeft.Y, backTopLeft.Z);
+                //m_log.InfoFormat("corner 6 is {0} {1} {2}", backTopRight.X, backTopRight.Y, backTopRight.Z);
+                //m_log.InfoFormat("corner 7 is {0} {1} {2}", backBottomRight.X, backBottomRight.Y, backBottomRight.Z);
+                //m_log.InfoFormat("corner 8 is {0} {1} {2}", backBottomLeft.X, backBottomLeft.Y, backBottomLeft.Z);
+
+                if (frontTopRight.X > maxX)
+                    maxX = frontTopRight.X;
+                if (frontTopLeft.X > maxX)
+                    maxX = frontTopLeft.X;
+                if (frontBottomRight.X > maxX)
+                    maxX = frontBottomRight.X;
+                if (frontBottomLeft.X > maxX)
+                    maxX = frontBottomLeft.X;
+
+                if (backTopRight.X > maxX)
+                    maxX = backTopRight.X;
+                if (backTopLeft.X > maxX)
+                    maxX = backTopLeft.X;
+                if (backBottomRight.X > maxX)
+                    maxX = backBottomRight.X;
+                if (backBottomLeft.X > maxX)
+                    maxX = backBottomLeft.X;
+
+                if (frontTopRight.X < minX)
+                    minX = frontTopRight.X;
+                if (frontTopLeft.X < minX)
+                    minX = frontTopLeft.X;
+                if (frontBottomRight.X < minX)
+                    minX = frontBottomRight.X;
+                if (frontBottomLeft.X < minX)
+                    minX = frontBottomLeft.X;
+
+                if (backTopRight.X < minX)
+                    minX = backTopRight.X;
+                if (backTopLeft.X < minX)
+                    minX = backTopLeft.X;
+                if (backBottomRight.X < minX)
+                    minX = backBottomRight.X;
+                if (backBottomLeft.X < minX)
+                    minX = backBottomLeft.X;
+
+                //
+                if (frontTopRight.Y > maxY)
+                    maxY = frontTopRight.Y;
+                if (frontTopLeft.Y > maxY)
+                    maxY = frontTopLeft.Y;
+                if (frontBottomRight.Y > maxY)
+                    maxY = frontBottomRight.Y;
+                if (frontBottomLeft.Y > maxY)
+                    maxY = frontBottomLeft.Y;
+
+                if (backTopRight.Y > maxY)
+                    maxY = backTopRight.Y;
+                if (backTopLeft.Y > maxY)
+                    maxY = backTopLeft.Y;
+                if (backBottomRight.Y > maxY)
+                    maxY = backBottomRight.Y;
+                if (backBottomLeft.Y > maxY)
+                    maxY = backBottomLeft.Y;
+
+                if (frontTopRight.Y < minY)
+                    minY = frontTopRight.Y;
+                if (frontTopLeft.Y < minY)
+                    minY = frontTopLeft.Y;
+                if (frontBottomRight.Y < minY)
+                    minY = frontBottomRight.Y;
+                if (frontBottomLeft.Y < minY)
+                    minY = frontBottomLeft.Y;
+
+                if (backTopRight.Y < minY)
+                    minY = backTopRight.Y;
+                if (backTopLeft.Y < minY)
+                    minY = backTopLeft.Y;
+                if (backBottomRight.Y < minY)
+                    minY = backBottomRight.Y;
+                if (backBottomLeft.Y < minY)
+                    minY = backBottomLeft.Y;
+
+                //
+                if (frontTopRight.Z > maxZ)
+                    maxZ = frontTopRight.Z;
+                if (frontTopLeft.Z > maxZ)
+                    maxZ = frontTopLeft.Z;
+                if (frontBottomRight.Z > maxZ)
+                    maxZ = frontBottomRight.Z;
+                if (frontBottomLeft.Z > maxZ)
+                    maxZ = frontBottomLeft.Z;
+
+                if (backTopRight.Z > maxZ)
+                    maxZ = backTopRight.Z;
+                if (backTopLeft.Z > maxZ)
+                    maxZ = backTopLeft.Z;
+                if (backBottomRight.Z > maxZ)
+                    maxZ = backBottomRight.Z;
+                if (backBottomLeft.Z > maxZ)
+                    maxZ = backBottomLeft.Z;
+
+                if (frontTopRight.Z < minZ)
+                    minZ = frontTopRight.Z;
+                if (frontTopLeft.Z < minZ)
+                    minZ = frontTopLeft.Z;
+                if (frontBottomRight.Z < minZ)
+                    minZ = frontBottomRight.Z;
+                if (frontBottomLeft.Z < minZ)
+                    minZ = frontBottomLeft.Z;
+
+                if (backTopRight.Z < minZ)
+                    minZ = backTopRight.Z;
+                if (backTopLeft.Z < minZ)
+                    minZ = backTopLeft.Z;
+                if (backBottomRight.Z < minZ)
+                    minZ = backBottomRight.Z;
+                if (backBottomLeft.Z < minZ)
+                    minZ = backBottomLeft.Z;
             }
-            lockPartsForRead(false);
         }
 
         public Vector3 GetAxisAlignedBoundingBox(out float offsetHeight)
@@ -1155,21 +1027,13 @@ namespace OpenSim.Region.Framework.Scenes
             XmlDocument doc = new XmlDocument();
             Dictionary<UUID,string> states = new Dictionary<UUID,string>();
 
-            // Capture script state while holding the lock
-            lockPartsForRead(true);
+            SceneObjectPart[] parts = m_parts.GetArray();
+            for (int i = 0; i < parts.Length; i++)
             {
-                foreach (SceneObjectPart part in m_parts.Values)
-                {
-                    
-                    Dictionary<UUID,string> pstates = part.Inventory.GetScriptStates(oldIDs);
-                    foreach (UUID itemid in pstates.Keys)
-                    {
-                        states.Add(itemid, pstates[itemid]);
-                    }
-                    
-                }
+                Dictionary<UUID, string> pstates = parts[i].Inventory.GetScriptStates();
+                foreach (KeyValuePair<UUID, string> kvp in pstates)
+                    states.Add(kvp.Key, kvp.Value);
             }
-            lockPartsForRead(false);
 
             if (states.Count > 0)
             {
@@ -1255,7 +1119,7 @@ namespace OpenSim.Region.Framework.Scenes
                 //Anakin Lohner bug #3839 
                 lock (m_parts)
                 {
-                    foreach (SceneObjectPart p in m_parts.Values)
+                    foreach (SceneObjectPart p in m_parts.GetArray())
                     {
                         p.AttachedAvatar = agentID;
                     }
@@ -1326,15 +1190,10 @@ namespace OpenSim.Region.Framework.Scenes
 
             AbsolutePosition = detachedpos;
             m_rootPart.AttachedAvatar = UUID.Zero;
-            
-            //Anakin Lohner bug #3839
-            lock (m_parts)
-            {
-                foreach (SceneObjectPart p in m_parts.Values)
-                {
-                    p.AttachedAvatar = UUID.Zero;
-                }
-            }
+
+            SceneObjectPart[] parts = m_parts.GetArray();
+            for (int i = 0; i < parts.Length; i++)
+                parts[i].AttachedAvatar = UUID.Zero;
 
             m_rootPart.SetParentLocalId(0);
             SetAttachmentPoint((byte)0);
@@ -1359,15 +1218,10 @@ namespace OpenSim.Region.Framework.Scenes
             }
 
             m_rootPart.AttachedAvatar = UUID.Zero;
-            
-            //Anakin Lohner bug #3839 
-            lock (m_parts)
-            {
-                foreach (SceneObjectPart p in m_parts.Values)
-                {
-                    p.AttachedAvatar = UUID.Zero;
-                }
-            }
+
+            SceneObjectPart[] parts = m_parts.GetArray();
+            for (int i = 0; i < parts.Length; i++)
+                parts[i].AttachedAvatar = UUID.Zero;
 
             m_rootPart.SetParentLocalId(0);
             //m_rootPart.SetAttachmentPoint((byte)0);
@@ -1390,16 +1244,9 @@ namespace OpenSim.Region.Framework.Scenes
 
         public override void UpdateMovement()
         {
-            lockPartsForRead(true);
-            {
-                foreach (SceneObjectPart part in m_parts.Values)
-                {
-                    
-                    part.UpdateMovement();
-                    
-                }
-            }
-            lockPartsForRead(false);
+            SceneObjectPart[] parts = m_parts.GetArray();
+            for (int i = 0; i < parts.Length; i++)
+                parts[i].UpdateMovement();
         }
 
         public ushort GetTimeDilation()
@@ -1432,8 +1279,7 @@ namespace OpenSim.Region.Framework.Scenes
                 part.ParentID = 0;
             part.LinkNum = 0;
             
-            lock (m_parts)
-                m_parts.Add(m_rootPart.UUID, m_rootPart);
+            m_parts.Add(m_rootPart.UUID, m_rootPart);
         }
 
         /// <summary>
@@ -1442,17 +1288,13 @@ namespace OpenSim.Region.Framework.Scenes
         /// <param name="part"></param>
         public void AddPart(SceneObjectPart part)
         {
-            lockPartsForWrite(true);
-            {
-                part.SetParent(this);
-                m_parts.Add(part.UUID, part);
+            part.SetParent(this);
+            m_parts.Add(part.UUID, part);
 
-                part.LinkNum = m_parts.Count;
+            part.LinkNum = m_parts.Count;
 
-                if (part.LinkNum == 2 && RootPart != null)
-                    RootPart.LinkNum = 1;
-            }
-            lockPartsForWrite(false);
+            if (part.LinkNum == 2 && RootPart != null)
+                RootPart.LinkNum = 1;
         }
 
         /// <summary>
@@ -1460,33 +1302,20 @@ namespace OpenSim.Region.Framework.Scenes
         /// </summary>
         private void UpdateParentIDs()
         {
-            lockPartsForRead(true);
+            SceneObjectPart[] parts = m_parts.GetArray();
+            for (int i = 0; i < parts.Length; i++)
             {
-                foreach (SceneObjectPart part in m_parts.Values)
-                {
-                    
-                    if (part.UUID != m_rootPart.UUID)
-                    {
-                        part.ParentID = m_rootPart.LocalId;
-                    }
-                    
-                }
+                SceneObjectPart part = parts[i];
+                if (part.UUID != m_rootPart.UUID)
+                    part.ParentID = m_rootPart.LocalId;
             }
-            lockPartsForRead(false);
         }
 
         public void RegenerateFullIDs()
         {
-            lockPartsForRead(true);
-            {
-                foreach (SceneObjectPart part in m_parts.Values)
-                {
-                    
-                    part.UUID = UUID.Random();
-                    
-                }
-            }
-            lockPartsForRead(false);
+            SceneObjectPart[] parts = m_parts.GetArray();
+            for (int i = 0; i < parts.Length; i++)
+                parts[i].UUID = UUID.Random();
         }
 
         // helper provided for parts.
@@ -1519,7 +1348,7 @@ namespace OpenSim.Region.Framework.Scenes
 
             // teravus: AbsolutePosition is NOT a normal property!
             // the code in the getter of AbsolutePosition is significantly different then the code in the setter!
-            
+            // jhurliman: Then why is it a property instead of two methods?
         }
 
         public UUID GetPartsFullID(uint localID)
@@ -1572,18 +1401,15 @@ namespace OpenSim.Region.Framework.Scenes
 
             DetachFromBackup();
 
-            lockPartsForRead(true);
-            List<SceneObjectPart> parts = new List<SceneObjectPart>(m_parts.Values);
-            lockPartsForRead(false);
-            
-            foreach (SceneObjectPart part in parts)
+            SceneObjectPart[] parts = m_parts.GetArray();
+            for (int i = 0; i < parts.Length; i++)
             {
-                Scene.ForEachScenePresence(delegate (ScenePresence avatar)
+                SceneObjectPart part = parts[i];
+
+                Scene.ForEachScenePresence(delegate(ScenePresence avatar)
                 {
                     if (avatar.ParentID == LocalId)
-                    {
                         avatar.StandUp();
-                    }
 
                     if (!silent)
                     {
@@ -1619,20 +1445,16 @@ namespace OpenSim.Region.Framework.Scenes
 
             scriptEvents aggregateScriptEvents = 0;
 
-            lockPartsForRead(true);
+            SceneObjectPart[] parts = m_parts.GetArray();
+            for (int i = 0; i < parts.Length; i++)
             {
-                foreach (SceneObjectPart part in m_parts.Values)
-                {
-                    
-                    if (part == null)
-                        continue;
-                    if (part != RootPart)
-                        part.Flags = objectflagupdate;
-                    aggregateScriptEvents |= part.AggregateScriptEvents;
-                    
-                }
+                SceneObjectPart part = parts[i];
+                if (part == null)
+                    continue;
+                if (part != RootPart)
+                    part.Flags = objectflagupdate;
+                aggregateScriptEvents |= part.AggregateScriptEvents;
             }
-            lockPartsForRead(false);
 
             m_scriptListens_atTarget = ((aggregateScriptEvents & scriptEvents.at_target) != 0);
             m_scriptListens_notAtTarget = ((aggregateScriptEvents & scriptEvents.not_at_target) != 0);
@@ -1674,30 +1496,23 @@ namespace OpenSim.Region.Framework.Scenes
         /// <param name="m_physicalPrim"></param>
         public void ApplyPhysics(bool m_physicalPrim)
         {
-            lockPartsForRead(true);
+            // Apply physics to the root prim
+            m_rootPart.ApplyPhysics(m_rootPart.GetEffectiveObjectFlags(), m_rootPart.VolumeDetectActive, m_physicalPrim);
             
-            if (m_parts.Count > 1)
+            // Apply physics to child prims
+            SceneObjectPart[] parts = m_parts.GetArray();
+            if (parts.Length > 1)
             {
-                List<SceneObjectPart> values = new List<SceneObjectPart>(m_parts.Values);
-                lockPartsForRead(false);
-                m_rootPart.ApplyPhysics(m_rootPart.GetEffectiveObjectFlags(), m_rootPart.VolumeDetectActive, m_physicalPrim);
-                foreach (SceneObjectPart part in values)
+                for (int i = 0; i < parts.Length; i++)
                 {
-                    
+                    SceneObjectPart part = parts[i];
                     if (part.LocalId != m_rootPart.LocalId)
-                    {
                         part.ApplyPhysics(m_rootPart.GetEffectiveObjectFlags(), part.VolumeDetectActive, m_physicalPrim);
-                    }
-                    
                 }
+
                 // Hack to get the physics scene geometries in the right spot
                 ResetChildPrimPhysicsPositions();
             }
-            else
-            {
-                lockPartsForRead(false);
-                m_rootPart.ApplyPhysics(m_rootPart.GetEffectiveObjectFlags(), m_rootPart.VolumeDetectActive, m_physicalPrim);
-            }
         }
 
         public void SetOwnerId(UUID userId)
@@ -1712,15 +1527,9 @@ namespace OpenSim.Region.Framework.Scenes
 
         public void ForEachPart(Action<SceneObjectPart> whatToDo)
         {
-            lockPartsForRead(true);
-            List<SceneObjectPart> values = new List<SceneObjectPart>(m_parts.Values);
-            lockPartsForRead(false);    
-            foreach (SceneObjectPart part in values)
-            {
-                
-                whatToDo(part);
-                
-            }
+            SceneObjectPart[] parts = m_parts.GetArray();
+            for (int i = 0; i < parts.Length; i++)
+                whatToDo(parts[i]);
         }
 
         #region Events
@@ -1790,7 +1599,7 @@ namespace OpenSim.Region.Framework.Scenes
                             // Possible ghost prim
                             if (m_rootPart.PhysActor.Position != m_rootPart.GroupPosition)
                             {
-                                foreach (SceneObjectPart part in Children.Values)
+                                foreach (SceneObjectPart part in m_parts.GetArray())
                                 {
                                     // Re-set physics actor positions and
                                     // orientations
@@ -1842,17 +1651,13 @@ namespace OpenSim.Region.Framework.Scenes
             RootPart.SendFullUpdate(
                 remoteClient, m_scene.Permissions.GenerateClientFlags(remoteClient.AgentId, RootPart.UUID));
 
-            lockPartsForRead(true);
+            SceneObjectPart[] parts = m_parts.GetArray();
+            for (int i = 0; i < parts.Length; i++)
             {
-                foreach (SceneObjectPart part in m_parts.Values)
-                {
-                    
-                    if (part != RootPart)
-                        part.SendFullUpdate(
-                            remoteClient, m_scene.Permissions.GenerateClientFlags(remoteClient.AgentId, part.UUID));
-                }
+                SceneObjectPart part = parts[i];
+                if (part != RootPart)
+                    part.SendFullUpdate(remoteClient, m_scene.Permissions.GenerateClientFlags(remoteClient.AgentId, part.UUID));
             }
-            lockPartsForRead(false);
         }
 
         #region Copying
@@ -1870,7 +1675,7 @@ namespace OpenSim.Region.Framework.Scenes
                 m_dupeInProgress = true;
                 dupe = (SceneObjectGroup)MemberwiseClone();
                 dupe.m_isBackedUp = false;
-                dupe.m_parts = new Dictionary<UUID, SceneObjectPart>();
+                dupe.m_parts = new MapAndArray<OpenMetaverse.UUID, SceneObjectPart>();
 
                 // Warning, The following code related to previousAttachmentStatus is needed so that clones of 
                 // attachments do not bordercross while they're being duplicated.  This is hacktastic!
@@ -1916,13 +1721,7 @@ namespace OpenSim.Region.Framework.Scenes
                     dupe.RootPart.DoPhysicsPropertyUpdate(dupe.RootPart.PhysActor.IsPhysical, true);
                 }
 
-                lockPartsForRead(true);
-
-                List<SceneObjectPart> partList;
-
-                partList = new List<SceneObjectPart>(m_parts.Values);
-
-                lockPartsForRead(false);
+                List<SceneObjectPart> partList = new List<SceneObjectPart>(m_parts.GetArray());
 
                 partList.Sort(delegate(SceneObjectPart p1, SceneObjectPart p2)
                     {
@@ -2261,14 +2060,9 @@ namespace OpenSim.Region.Framework.Scenes
             SceneObjectPart newPart = part.Copy(m_scene.AllocateLocalId(), OwnerID, GroupID, m_parts.Count, userExposed);
             newPart.SetParent(this);
 
-            lockPartsForWrite(true);
-            {
-                m_parts.Add(newPart.UUID, newPart);
-            }
-            lockPartsForWrite(false);
+            AddPart(newPart);
 
             SetPartAsNonRoot(newPart);
-
             return newPart;
         }
 
@@ -2280,9 +2074,9 @@ namespace OpenSim.Region.Framework.Scenes
         /// </summary>
         public void ResetIDs()
         {
-            lock (m_parts)
+            lock (m_parts.SyncRoot)
             {
-                List<SceneObjectPart> partsList = new List<SceneObjectPart>(m_parts.Values);
+                List<SceneObjectPart> partsList = new List<SceneObjectPart>(m_parts.GetArray());
                 m_parts.Clear();
                 foreach (SceneObjectPart part in partsList)
                 {
@@ -2298,7 +2092,6 @@ namespace OpenSim.Region.Framework.Scenes
         /// <param name="part"></param>
         public void ServiceObjectPropertiesFamilyRequest(IClientAPI remoteClient, UUID AgentID, uint RequestFlags)
         {
-
             remoteClient.SendObjectPropertiesFamilyData(RequestFlags, RootPart.UUID, RootPart.OwnerID, RootPart.GroupID, RootPart.BaseMask,
                                                         RootPart.OwnerMask, RootPart.GroupMask, RootPart.EveryoneMask, RootPart.NextOwnerMask,
                                                         RootPart.OwnershipCost, RootPart.ObjectSaleType, RootPart.SalePrice, RootPart.Category,
@@ -2329,8 +2122,6 @@ namespace OpenSim.Region.Framework.Scenes
             //if ((RootPart.Flags & PrimFlags.TemporaryOnRez) != 0)
             //    return;
 
-            lockPartsForRead(true);
-
             bool UsePhysics = ((RootPart.Flags & PrimFlags.Physics) != 0);
 
             if (UsePhysics && !AbsolutePosition.ApproxEquals(lastPhysGroupPos, 0.02f))
@@ -2345,16 +2136,14 @@ namespace OpenSim.Region.Framework.Scenes
                 lastPhysGroupRot = GroupRotation;
             }
 
-            List<SceneObjectPart> partList = null;
-            partList = new List<SceneObjectPart>(m_parts.Values);
-                
-            foreach (SceneObjectPart part in partList)
+            SceneObjectPart[] parts = m_parts.GetArray();
+            for (int i = 0; i < parts.Length; i++)
             {
+                SceneObjectPart part = parts[i];
                 if (!IsSelected)
                     part.UpdateLookAt();
                 part.SendScheduledUpdates();
             }
-            lockPartsForRead(false);
         }
 
         public void ScheduleFullUpdateToAvatar(ScenePresence presence)
@@ -2363,29 +2152,22 @@ namespace OpenSim.Region.Framework.Scenes
             
             RootPart.AddFullUpdateToAvatar(presence);
 
-            lockPartsForRead(true);
+            SceneObjectPart[] parts = m_parts.GetArray();
+            for (int i = 0; i < parts.Length; i++)
             {
-                foreach (SceneObjectPart part in m_parts.Values)
-                {
-                    
-                    if (part != RootPart)
-                        part.AddFullUpdateToAvatar(presence);
-                    
-                }
+                SceneObjectPart part = parts[i];
+                if (part != RootPart)
+                    part.AddFullUpdateToAvatar(presence);
             }
-            lockPartsForRead(false);
         }
 
         public void ScheduleTerseUpdateToAvatar(ScenePresence presence)
         {
-            lockPartsForRead(true);
-
-            foreach (SceneObjectPart part in m_parts.Values)
-            {
-                part.AddTerseUpdateToAvatar(presence);
-            }
+//            m_log.DebugFormat("[SOG]: Scheduling terse update for {0} {1} just to avatar {2}", Name, UUID, presence.Name);
 
-            lockPartsForRead(false);
+            SceneObjectPart[] parts = m_parts.GetArray();
+            for (int i = 0; i < parts.Length; i++)
+                parts[i].AddTerseUpdateToAvatar(presence);
         }
 
         /// <summary>
@@ -2399,17 +2181,13 @@ namespace OpenSim.Region.Framework.Scenes
             checkAtTargets();
             RootPart.ScheduleFullUpdate();
 
-            lockPartsForRead(true);
+            SceneObjectPart[] parts = m_parts.GetArray();
+            for (int i = 0; i < parts.Length; i++)
             {
-                foreach (SceneObjectPart part in m_parts.Values)
-                {
-                    
-                    if (part != RootPart)
-                        part.ScheduleFullUpdate();
-                    
-                }
+                SceneObjectPart part = parts[i];
+                if (part != RootPart)
+                    part.ScheduleFullUpdate();
             }
-            lockPartsForRead(false);
         }
 
         /// <summary>
@@ -2417,13 +2195,11 @@ namespace OpenSim.Region.Framework.Scenes
         /// </summary>
         public void ScheduleGroupForTerseUpdate()
         {
-            lockPartsForRead(true);
-            foreach (SceneObjectPart part in m_parts.Values)
-            {
-                part.ScheduleTerseUpdate();
-            }
+//            m_log.DebugFormat("[SOG]: Scheduling terse update for {0} {1}", Name, UUID);
 
-            lockPartsForRead(false);
+            SceneObjectPart[] parts = m_parts.GetArray();
+            for (int i = 0; i < parts.Length; i++)
+                parts[i].ScheduleTerseUpdate();
         }
 
         /// <summary>
@@ -2438,17 +2214,13 @@ namespace OpenSim.Region.Framework.Scenes
             
             RootPart.SendFullUpdateToAllClients();
 
-            lockPartsForRead(true);
+            SceneObjectPart[] parts = m_parts.GetArray();
+            for (int i = 0; i < parts.Length; i++)
             {
-                foreach (SceneObjectPart part in m_parts.Values)
-                {
-                    
-                    if (part != RootPart)
-                        part.SendFullUpdateToAllClients();
-                    
-                }
+                SceneObjectPart part = parts[i];
+                if (part != RootPart)
+                    part.SendFullUpdateToAllClients();
             }
-            lockPartsForRead(false);
         }
 
         /// <summary>
@@ -2481,14 +2253,9 @@ namespace OpenSim.Region.Framework.Scenes
             if (IsDeleted)
                 return;
 
-            lockPartsForRead(true);
-            {
-                foreach (SceneObjectPart part in m_parts.Values)
-                {
-                    part.SendTerseUpdateToAllClients();
-                }
-            }
-            lockPartsForRead(false);
+            SceneObjectPart[] parts = m_parts.GetArray();
+            for (int i = 0; i < parts.Length; i++)
+                parts[i].SendTerseUpdateToAllClients();
         }
 
         #endregion
@@ -2502,18 +2269,12 @@ namespace OpenSim.Region.Framework.Scenes
         /// <returns>null if no child part with that linknum or child part</returns>
         public SceneObjectPart GetLinkNumPart(int linknum)
         {
-            lockPartsForRead(true);
+            SceneObjectPart[] parts = m_parts.GetArray();
+            for (int i = 0; i < parts.Length; i++)
             {
-                foreach (SceneObjectPart part in m_parts.Values)
-                {
-                    if (part.LinkNum == linknum)
-                    {
-                        lockPartsForRead(false);
-                        return part;
-                    }
-                }
+                if (parts[i].LinkNum == linknum)
+                    return parts[i];
             }
-            lockPartsForRead(false);
 
             return null;
         }
@@ -2526,8 +2287,7 @@ namespace OpenSim.Region.Framework.Scenes
         public SceneObjectPart GetChildPart(UUID primID)
         {
             SceneObjectPart childPart;
-            lock (m_parts)
-                m_parts.TryGetValue(primID, out childPart);
+            m_parts.TryGetValue(primID, out childPart);
             return childPart;
         }
 
@@ -2538,20 +2298,12 @@ namespace OpenSim.Region.Framework.Scenes
         /// <returns>null if a child part with the local ID was not found</returns>
         public SceneObjectPart GetChildPart(uint localID)
         {
-            //m_log.DebugFormat("Entered looking for {0}", localID);
-            lockPartsForRead(true);
+            SceneObjectPart[] parts = m_parts.GetArray();
+            for (int i = 0; i < parts.Length; i++)
             {
-                foreach (SceneObjectPart part in m_parts.Values)
-                {
-                    //m_log.DebugFormat("Found {0}", part.LocalId);
-                    if (part.LocalId == localID)
-                    {
-                        lockPartsForRead(false);
-                        return part;
-                    }
-                }
+                if (parts[i].LocalId == localID)
+                    return parts[i];
             }
-            lockPartsForRead(false);
 
             return null;
         }
@@ -2564,13 +2316,7 @@ namespace OpenSim.Region.Framework.Scenes
         /// <returns></returns>
         public bool HasChildPrim(UUID primID)
         {
-            lock (m_parts)
-            {
-                if (m_parts.ContainsKey(primID))
-                    return true;
-            }
-
-            return false;
+            return m_parts.ContainsKey(primID);
         }
 
         /// <summary>
@@ -2581,20 +2327,12 @@ namespace OpenSim.Region.Framework.Scenes
         /// <returns></returns>
         public bool HasChildPrim(uint localID)
         {
-            //m_log.DebugFormat("Entered HasChildPrim looking for {0}", localID);
-            lockPartsForRead(true);
+            SceneObjectPart[] parts = m_parts.GetArray();
+            for (int i = 0; i < parts.Length; i++)
             {
-                foreach (SceneObjectPart part in m_parts.Values)
-                {
-                    //m_log.DebugFormat("Found {0}", part.LocalId);
-                    if (part.LocalId == localID)
-                    {
-                        lockPartsForRead(false);
-                        return true;
-                    }
-                }
+                if (parts[i].LocalId == localID)
+                    return true;
             }
-            lockPartsForRead(false);
 
             return false;
         }
@@ -2644,58 +2382,56 @@ namespace OpenSim.Region.Framework.Scenes
             if (m_rootPart.LinkNum == 0)
                 m_rootPart.LinkNum = 1;
 
-            lockPartsForWrite(true);
-            
-            m_parts.Add(linkPart.UUID, linkPart);
-
-            lockPartsForWrite(false);
-
-            // Insert in terms of link numbers, the new links
-            // before the current ones (with the exception of 
-            // the root prim. Shuffle the old ones up
-            lockPartsForRead(true);
-            foreach (KeyValuePair<UUID, SceneObjectPart> kvp in m_parts) 
+            lock (m_parts.SyncRoot)
             {
-                if (kvp.Value.LinkNum != 1)
+                m_parts.Add(linkPart.UUID, linkPart);
+
+                // Insert in terms of link numbers, the new links
+                // before the current ones (with the exception of 
+                // the root prim. Shuffle the old ones up
+                SceneObjectPart[] parts = m_parts.GetArray();
+                for (int i = 0; i < parts.Length; i++)
                 {
-                    // Don't update root prim link number
-                    kvp.Value.LinkNum += objectGroup.PrimCount;
+                    SceneObjectPart part = parts[i];
+                    if (part.LinkNum != 1)
+                    {
+                        // Don't update root prim link number
+                        part.LinkNum += objectGroup.PrimCount;
+                    }
                 }
             }
-            lockPartsForRead(false);
 
             linkPart.LinkNum = 2;
 
             linkPart.SetParent(this);
             linkPart.CreateSelected = true;
 
-            //if (linkPart.PhysActor != null)
-            //{
-            // m_scene.PhysicsScene.RemovePrim(linkPart.PhysActor);
-    
-            //linkPart.PhysActor = null;
-            //}
-
-            //TODO: rest of parts
-            int linkNum = 3;
-            foreach (SceneObjectPart part in objectGroup.Children.Values)
+            lock (m_parts.SyncRoot)
             {
-                if (part.UUID != objectGroup.m_rootPart.UUID)
+                //if (linkPart.PhysActor != null)
+                //{
+                // m_scene.PhysicsScene.RemovePrim(linkPart.PhysActor);
+
+                //linkPart.PhysActor = null;
+                //}
+
+                //TODO: rest of parts
+                int linkNum = 3;
+                SceneObjectPart[] ogParts = objectGroup.Parts;
+                for (int i = 0; i < ogParts.Length; i++)
                 {
-                    LinkNonRootPart(part, oldGroupPosition, oldRootRotation, linkNum++);
+                    SceneObjectPart part = ogParts[i];
+                    if (part.UUID != objectGroup.m_rootPart.UUID)
+                        LinkNonRootPart(part, oldGroupPosition, oldRootRotation, linkNum++);
+                    part.ClearUndoState();
                 }
-                part.ClearUndoState();
             }
 
             m_scene.UnlinkSceneObject(objectGroup, true);
             objectGroup.m_isDeleted = true;
 
-            objectGroup.lockPartsForWrite(true);
-            
             objectGroup.m_parts.Clear();
             
-            objectGroup.lockPartsForWrite(false);
-            
             // Can't do this yet since backup still makes use of the root part without any synchronization
 //            objectGroup.m_rootPart = null;
 
@@ -2764,23 +2500,27 @@ namespace OpenSim.Region.Framework.Scenes
             Quaternion worldRot = linkPart.GetWorldRotation();
 
             // Remove the part from this object
-            lockPartsForWrite(true);
+            lock (m_parts.SyncRoot)
             {
                 m_parts.Remove(linkPart.UUID);
-            }
-            lockPartsForWrite(false);
-            lockPartsForRead(true);
-            if (m_parts.Count == 1 && RootPart != null) //Single prim is left
-                RootPart.LinkNum = 0;
-            else
-            {
-                foreach (SceneObjectPart p in m_parts.Values)
+
+                SceneObjectPart[] parts = m_parts.GetArray();
+
+                if (parts.Length == 1 && RootPart != null)
                 {
-                    if (p.LinkNum > linkPart.LinkNum)
-                        p.LinkNum--;
+                    // Single prim left
+                    RootPart.LinkNum = 0;
+                }
+                else
+                {
+                    for (int i = 0; i < parts.Length; i++)
+                    {
+                        SceneObjectPart part = parts[i];
+                        if (part.LinkNum > linkPart.LinkNum)
+                            part.LinkNum--;
+                    }
                 }
             }
-            lockPartsForRead(false);
 
             linkPart.ParentID = 0;
             linkPart.LinkNum = 0;
@@ -2851,7 +2591,6 @@ namespace OpenSim.Region.Framework.Scenes
             part.SetParent(this);
             part.ParentID = m_rootPart.LocalId;
 
-            // Caller locks m_parts for us
             m_parts.Add(part.UUID, part);
 
             part.LinkNum = linkNum;
@@ -3104,28 +2843,21 @@ namespace OpenSim.Region.Framework.Scenes
 
             if (selectionPart != null)
             {
-                lockPartsForRead(true);
-                List<SceneObjectPart> parts = new List<SceneObjectPart>(m_parts.Values);
-                lockPartsForRead(false);
-                foreach (SceneObjectPart part in parts)
+                SceneObjectPart[] parts = m_parts.GetArray();
+                for (int i = 0; i < parts.Length; i++)
                 {
-                    if (part.Scale.X > 10.0 || part.Scale.Y > 10.0 || part.Scale.Z > 10.0)
+                    SceneObjectPart part = parts[i];
+                    if (part.Scale.X > m_scene.RegionInfo.PhysPrimMax || 
+                        part.Scale.Y > m_scene.RegionInfo.PhysPrimMax || 
+                        part.Scale.Z > m_scene.RegionInfo.PhysPrimMax)
                     {
-                        if (part.Scale.X > m_scene.RegionInfo.PhysPrimMax || 
-                            part.Scale.Y > m_scene.RegionInfo.PhysPrimMax ||
-                            part.Scale.Z > m_scene.RegionInfo.PhysPrimMax)
-                        {
-                            UsePhysics = false; // Reset physics
-                            break;
-                        }
+                        UsePhysics = false; // Reset physics
+                        break;
                     }
                 }
 
-                foreach (SceneObjectPart part in parts)
-                {
-                    part.UpdatePrimFlags(UsePhysics, IsTemporary, IsPhantom, IsVolumeDetect);
-                }
-                
+                for (int i = 0; i < parts.Length; i++)
+                    parts[i].UpdatePrimFlags(UsePhysics, IsTemporary, IsPhantom, IsVolumeDetect);
             }
         }
 
@@ -3146,19 +2878,7 @@ namespace OpenSim.Region.Framework.Scenes
         /// <returns></returns>
         public int GetPartCount()
         {
-            return Children.Count;
-        }
-
-        /// <summary>
-        /// Get the parts of this scene object
-        /// </summary>
-        /// <returns></returns>
-        public SceneObjectPart[] GetParts()
-        {
-            int numParts = Children.Count;
-            SceneObjectPart[] partArray = new SceneObjectPart[numParts];
-            Children.Values.CopyTo(partArray, 0);
-            return partArray;
+            return Parts.Count();
         }
 
         /// <summary>
@@ -3178,12 +2898,9 @@ namespace OpenSim.Region.Framework.Scenes
         public void UpdatePermissions(UUID AgentID, byte field, uint localID,
                 uint mask, byte addRemTF)
         {
-            List<SceneObjectPart> partList = null;
-            lock (m_parts)
-                partList = new List<SceneObjectPart>(m_parts.Values);
-
-            foreach (SceneObjectPart part in partList)
-                part.UpdatePermissions(AgentID, field, localID, mask, addRemTF);
+            SceneObjectPart[] parts = m_parts.GetArray();
+            for (int i = 0; i < parts.Length; i++)
+                parts[i].UpdatePermissions(AgentID, field, localID, mask, addRemTF);
 
             HasGroupChanged = true;
         }
@@ -3283,15 +3000,17 @@ namespace OpenSim.Region.Framework.Scenes
                 float y = (scale.Y / part.Scale.Y);
                 float z = (scale.Z / part.Scale.Z);
 
-                lockPartsForRead(true);
+                SceneObjectPart[] parts;
                 if (x > 1.0f || y > 1.0f || z > 1.0f)
                 {
-                    foreach (SceneObjectPart obPart in m_parts.Values)
+                    parts = m_parts.GetArray();
+                    for (int i = 0; i < parts.Length; i++)
                     {
+                        SceneObjectPart obPart = parts[i];
                         if (obPart.UUID != m_rootPart.UUID)
                         {
-                            Vector3 oldSize = new Vector3(obPart.Scale);
                             obPart.IgnoreUndoUpdate = true;
+                            Vector3 oldSize = new Vector3(obPart.Scale);
 
                             float f = 1.0f;
                             float a = 1.0f;
@@ -3349,12 +3068,11 @@ namespace OpenSim.Region.Framework.Scenes
                                     y *= a;
                                     z *= a;
                                 }
-                                
                             }
+                            obPart.IgnoreUndoUpdate = false;
                         }
                     }
                 }
-                lockPartsForRead(false);
 
                 Vector3 prevScale = part.Scale;
                 prevScale.X *= x;
@@ -3367,9 +3085,12 @@ namespace OpenSim.Region.Framework.Scenes
                 part.Resize(prevScale);
                 part.IgnoreUndoUpdate = false;
 
-                lockPartsForRead(true);
+                parts = m_parts.GetArray();
+                for (int i = 0; i < parts.Length; i++)
                 {
-                    foreach (SceneObjectPart obPart in m_parts.Values)
+                    SceneObjectPart obPart = parts[i];
+                    obPart.IgnoreUndoUpdate = true;
+                    if (obPart.UUID != m_rootPart.UUID)
                     {
                         if (obPart.UUID != m_rootPart.UUID)
                         {
@@ -3390,8 +3111,8 @@ namespace OpenSim.Region.Framework.Scenes
                         }
                         obPart.IgnoreUndoUpdate = false;
                     }
+                    obPart.IgnoreUndoUpdate = false;
                 }
-                lockPartsForRead(false);
 
                 if (part.PhysActor != null)
                 {
@@ -3450,10 +3171,11 @@ namespace OpenSim.Region.Framework.Scenes
         public void UpdateSinglePosition(Vector3 pos, uint localID)
         {
             SceneObjectPart part = GetChildPart(localID);
-            foreach (SceneObjectPart parts in Children.Values)
-            {
-                parts.StoreUndoState(UndoType.STATE_PRIM_POSITION);
-            }
+
+            SceneObjectPart[] parts = m_parts.GetArray();
+            for (int i = 0; i < parts.Length; i++)
+                parts[i].StoreUndoState(UndoType.STATE_PRIM_POSITION);
+
             if (part != null)
             {
                 if (part.UUID == m_rootPart.UUID)
@@ -3475,10 +3197,10 @@ namespace OpenSim.Region.Framework.Scenes
         /// <param name="pos"></param>
         private void UpdateRootPosition(Vector3 pos)
         {
-            foreach (SceneObjectPart part in Children.Values)
-            {
-                part.StoreUndoState(UndoType.STATE_PRIM_POSITION);
-            }
+            SceneObjectPart[] parts = m_parts.GetArray();
+            for (int i = 0; i < parts.Length; i++)
+                parts[i].StoreUndoState(UndoType.STATE_PRIM_POSITION);
+
             Vector3 newPos = new Vector3(pos.X, pos.Y, pos.Z);
             Vector3 oldPos =
                 new Vector3(AbsolutePosition.X + m_rootPart.OffsetPosition.X,
@@ -3490,17 +3212,13 @@ namespace OpenSim.Region.Framework.Scenes
             axDiff *= Quaternion.Inverse(partRotation);
             diff = axDiff;
 
-            lockPartsForRead(true);
+            parts = m_parts.GetArray();
+            for (int i = 0; i < parts.Length; i++)
             {
-                foreach (SceneObjectPart obPart in m_parts.Values)
-                {
-                    if (obPart.UUID != m_rootPart.UUID)
-                    {
-                        obPart.OffsetPosition = obPart.OffsetPosition + diff;
-                    }
-                }
+                SceneObjectPart obPart = parts[i];
+                if (obPart.UUID != m_rootPart.UUID)
+                    obPart.OffsetPosition = obPart.OffsetPosition + diff;
             }
-            lockPartsForRead(false);
 
             //We have to set undoing here because otherwise an undo state will be saved
             if (!m_rootPart.Undoing)
@@ -3540,10 +3258,10 @@ namespace OpenSim.Region.Framework.Scenes
         /// <param name="rot"></param>
         public void UpdateGroupRotationR(Quaternion rot)
         {
-            foreach (SceneObjectPart parts in Children.Values)
-            {
-                parts.StoreUndoState(UndoType.STATE_GROUP_ROTATION);
-            }
+            SceneObjectPart[] parts = m_parts.GetArray();
+            for (int i = 0; i < parts.Length; i++)
+                parts[i].StoreUndoState(UndoType.STATE_GROUP_ROTATION);
+
             m_rootPart.UpdateRotation(rot);
 
             PhysicsActor actor = m_rootPart.PhysActor;
@@ -3564,10 +3282,10 @@ namespace OpenSim.Region.Framework.Scenes
         /// <param name="rot"></param>
         public void UpdateGroupRotationPR(Vector3 pos, Quaternion rot)
         {
-            foreach (SceneObjectPart parts in Children.Values)
-            {
-                parts.StoreUndoState(UndoType.STATE_GROUP_ROTATION);
-            }
+            SceneObjectPart[] parts = m_parts.GetArray();
+            for (int i = 0; i < parts.Length; i++)
+                parts[i].StoreUndoState(UndoType.STATE_GROUP_ROTATION);
+
             m_rootPart.UpdateRotation(rot);
 
             PhysicsActor actor = m_rootPart.PhysActor;
@@ -3591,10 +3309,10 @@ namespace OpenSim.Region.Framework.Scenes
         public void UpdateSingleRotation(Quaternion rot, uint localID)
         {
             SceneObjectPart part = GetChildPart(localID);
-            foreach (SceneObjectPart parts in Children.Values)
-            {
-                parts.StoreUndoState(UndoType.STATE_PRIM_ROTATION);
-            }
+            SceneObjectPart[] parts = m_parts.GetArray();
+            for (int i = 0; i < parts.Length; i++)
+                parts[i].StoreUndoState(UndoType.STATE_PRIM_ROTATION);
+
             if (part != null)
             {
                 if (part.UUID == m_rootPart.UUID)
@@ -3666,10 +3384,10 @@ namespace OpenSim.Region.Framework.Scenes
                 m_scene.PhysicsScene.AddPhysicsActorTaint(m_rootPart.PhysActor);
             }
 
-            lockPartsForRead(true);
-
-            foreach (SceneObjectPart prim in m_parts.Values)
+            SceneObjectPart[] parts = m_parts.GetArray();
+            for (int i = 0; i < parts.Length; i++)
             {
+                SceneObjectPart prim = parts[i];
                 if (prim.UUID != m_rootPart.UUID)
                 {
                     prim.IgnoreUndoUpdate = true;
@@ -3689,7 +3407,6 @@ namespace OpenSim.Region.Framework.Scenes
             {
                 m_rootPart.Undoing = false;
             }
-            lockPartsForRead(false);
 
             m_rootPart.ScheduleTerseUpdate();
         }
@@ -3811,18 +3528,10 @@ namespace OpenSim.Region.Framework.Scenes
                     
                     if (atTargets.Count > 0)
                     {
-                        uint[] localids = new uint[0];
-                        lockPartsForRead(true);
-                        {
-                            localids = new uint[m_parts.Count];
-                            int cntr = 0;
-                            foreach (SceneObjectPart part in m_parts.Values)
-                            {
-                                localids[cntr] = part.LocalId;
-                                cntr++;
-                            }
-                        }
-                        lockPartsForRead(false);
+                        SceneObjectPart[] parts = m_parts.GetArray();
+                        uint[] localids = new uint[parts.Length];
+                        for (int i = 0; i < parts.Length; i++)
+                            localids[i] = parts[i].LocalId;
                         
                         for (int ctr = 0; ctr < localids.Length; ctr++)
                         {
@@ -3840,19 +3549,11 @@ namespace OpenSim.Region.Framework.Scenes
                     if (m_scriptListens_notAtTarget && !at_target)
                     {
                         //trigger not_at_target
-                        uint[] localids = new uint[0];
-                        lockPartsForRead(true);
-                        {
-                            localids = new uint[m_parts.Count];
-                            int cntr = 0;
-                            foreach (SceneObjectPart part in m_parts.Values)
-                            {
-                                localids[cntr] = part.LocalId;
-                                cntr++;
-                            }
-                        }
-                        lockPartsForRead(false);    
-
+                        SceneObjectPart[] parts = m_parts.GetArray();
+                        uint[] localids = new uint[parts.Length];
+                        for (int i = 0; i < parts.Length; i++)
+                            localids[i] = parts[i].LocalId;
+                        
                         for (int ctr = 0; ctr < localids.Length; ctr++)
                         {
                             m_scene.EventManager.TriggerNotAtTargetEvent(localids[ctr]);
@@ -3892,22 +3593,10 @@ namespace OpenSim.Region.Framework.Scenes
 
                     if (atRotTargets.Count > 0)
                     {
-                        uint[] localids = new uint[0];
-                        lockPartsForRead(true);
-                        try
-                        {
-                            localids = new uint[m_parts.Count];
-                            int cntr = 0;
-                            foreach (SceneObjectPart part in m_parts.Values)
-                            {
-                                localids[cntr] = part.LocalId;
-                                cntr++;
-                            }
-                        }
-                        finally
-                        {
-                            lockPartsForRead(false);
-                        }
+                        SceneObjectPart[] parts = m_parts.GetArray();
+                        uint[] localids = new uint[parts.Length];
+                        for (int i = 0; i < parts.Length; i++)
+                            localids[i] = parts[i].LocalId;
 
                         for (int ctr = 0; ctr < localids.Length; ctr++)
                         {
@@ -3925,22 +3614,10 @@ namespace OpenSim.Region.Framework.Scenes
                     if (m_scriptListens_notAtRotTarget && !at_Rottarget)
                     {
                         //trigger not_at_target
-                        uint[] localids = new uint[0];
-                        lockPartsForRead(true);
-                        try
-                        {
-                            localids = new uint[m_parts.Count];
-                            int cntr = 0;
-                            foreach (SceneObjectPart part in m_parts.Values)
-                            {
-                                localids[cntr] = part.LocalId;
-                                cntr++;
-                            }
-                        }
-                        finally
-                        {
-                            lockPartsForRead(false);
-                        }
+                        SceneObjectPart[] parts = m_parts.GetArray();
+                        uint[] localids = new uint[parts.Length];
+                        for (int i = 0; i < parts.Length; i++)
+                            localids[i] = parts[i].LocalId;
 
                         for (int ctr = 0; ctr < localids.Length; ctr++)
                         {
@@ -3954,45 +3631,38 @@ namespace OpenSim.Region.Framework.Scenes
         public float GetMass()
         {
             float retmass = 0f;
-            lockPartsForRead(true);
-            {
-                foreach (SceneObjectPart part in m_parts.Values)
-                {
-                    retmass += part.GetMass();
-                }
-            }
-            lockPartsForRead(false);
+            SceneObjectPart[] parts = m_parts.GetArray();
+            for (int i = 0; i < parts.Length; i++)
+                retmass += parts[i].GetMass();
+
             return retmass;
         }
         
         public void CheckSculptAndLoad()
         {
-            lockPartsForRead(true);
+            if (IsDeleted)
+                return;
+            if ((RootPart.GetEffectiveObjectFlags() & (uint)PrimFlags.Phantom) != 0)
+                return;
+
+            SceneObjectPart[] parts = m_parts.GetArray();
+            for (int i = 0; i < parts.Length; i++)
             {
-                if (!IsDeleted)
+                SceneObjectPart part = parts[i];
+                if (part.Shape.SculptEntry && part.Shape.SculptTexture != UUID.Zero)
                 {
-                    if ((RootPart.GetEffectiveObjectFlags() & (uint)PrimFlags.Phantom) == 0)
+                    // check if a previously decoded sculpt map has been cached
+                    if (File.Exists(System.IO.Path.Combine("j2kDecodeCache", "smap_" + part.Shape.SculptTexture.ToString())))
                     {
-                        foreach (SceneObjectPart part in m_parts.Values)
-                        {
-                            if (part.Shape.SculptEntry && part.Shape.SculptTexture != UUID.Zero)
-                            {
-                                // check if a previously decoded sculpt map has been cached
-                                if (File.Exists(System.IO.Path.Combine("j2kDecodeCache", "smap_" + part.Shape.SculptTexture.ToString())))
-                                {
-                                    part.SculptTextureCallback(part.Shape.SculptTexture, null);
-                                }
-                                else
-                                {
-                                    m_scene.AssetService.Get(
-                                        part.Shape.SculptTexture.ToString(), part, AssetReceived);
-                                }
-                            }
-                        }
+                        part.SculptTextureCallback(part.Shape.SculptTexture, null);
+                    }
+                    else
+                    {
+                        m_scene.AssetService.Get(
+                            part.Shape.SculptTexture.ToString(), part, AssetReceived);
                     }
                 }
             }
-            lockPartsForRead(false);
         }
 
         protected void AssetReceived(string id, Object sender, AssetBase asset)
@@ -4013,17 +3683,13 @@ namespace OpenSim.Region.Framework.Scenes
         /// <param name="client"></param>
         public void SetGroup(UUID GroupID, IClientAPI client)
         {
-            lockPartsForRead(true);
+            SceneObjectPart[] parts = m_parts.GetArray();
+            for (int i = 0; i < parts.Length; i++)
             {
-                foreach (SceneObjectPart part in m_parts.Values)
-                {
-                    part.SetGroup(GroupID, client);
-                    part.Inventory.ChangeInventoryGroup(GroupID);
-                }
-
-                HasGroupChanged = true;
+                SceneObjectPart part = parts[i];
+                part.SetGroup(GroupID, client);
+                part.Inventory.ChangeInventoryGroup(GroupID);
             }
-            lockPartsForRead(false);
 
             // Don't trigger the update here - otherwise some client issues occur when multiple updates are scheduled
             // for the same object with very different properties.  The caller must schedule the update.
@@ -4032,10 +3698,9 @@ namespace OpenSim.Region.Framework.Scenes
 
         public void TriggerScriptChangedEvent(Changed val)
         {
-            foreach (SceneObjectPart part in Children.Values)
-            {
-                part.TriggerScriptChangedEvent(val);
-            }
+            SceneObjectPart[] parts = m_parts.GetArray();
+            for (int i = 0; i < parts.Length; i++)
+                parts[i].TriggerScriptChangedEvent(val);
         }
         
         public override string ToString()
@@ -4045,12 +3710,9 @@ namespace OpenSim.Region.Framework.Scenes
 
         public void SetAttachmentPoint(byte point)
         {
-            lockPartsForRead(true);
-            {
-                foreach (SceneObjectPart part in m_parts.Values)
-                    part.SetAttachmentPoint(point);
-            }
-            lockPartsForRead(false);
+            SceneObjectPart[] parts = m_parts.GetArray();
+            for (int i = 0; i < parts.Length; i++)
+                parts[i].SetAttachmentPoint(point);
         }
 
         #region ISceneObject
diff --git a/OpenSim/Region/Framework/Scenes/SceneObjectPartInventory.cs b/OpenSim/Region/Framework/Scenes/SceneObjectPartInventory.cs
index b205503..8aa17a1 100644
--- a/OpenSim/Region/Framework/Scenes/SceneObjectPartInventory.cs
+++ b/OpenSim/Region/Framework/Scenes/SceneObjectPartInventory.cs
@@ -780,10 +780,7 @@ namespace OpenSim.Region.Framework.Scenes
             rootPart.Name = item.Name;
             rootPart.Description = item.Description;
 
-            List<SceneObjectPart> partList = null;
-            
-            lock (group.Children)
-                partList = new List<SceneObjectPart>(group.Children.Values);
+            SceneObjectPart[] partList = group.Parts;
 
             group.SetGroup(m_part.GroupID, null);
 
diff --git a/OpenSim/Region/Framework/Scenes/ScenePresence.cs b/OpenSim/Region/Framework/Scenes/ScenePresence.cs
index 8da9bdc..b3df1ea 100644
--- a/OpenSim/Region/Framework/Scenes/ScenePresence.cs
+++ b/OpenSim/Region/Framework/Scenes/ScenePresence.cs
@@ -1884,7 +1884,7 @@ namespace OpenSim.Region.Framework.Scenes
             // If the primitive the player clicked on has no sit target, and one or more other linked objects have sit targets that are not full, the sit target of the object with the lowest link number will be used.
 
             // Get our own copy of the part array, and sort into the order we want to test
-            SceneObjectPart[] partArray = targetPart.ParentGroup.GetParts();
+            SceneObjectPart[] partArray = targetPart.ParentGroup.Parts;
             Array.Sort(partArray, delegate(SceneObjectPart p1, SceneObjectPart p2)
                        {
                            // we want the originally selected part first, then the rest in link order -- so make the selected part link num (-1)
diff --git a/OpenSim/Region/Framework/Scenes/Serialization/SceneObjectSerializer.cs b/OpenSim/Region/Framework/Scenes/Serialization/SceneObjectSerializer.cs
index 77e477f..dc8957c 100644
--- a/OpenSim/Region/Framework/Scenes/Serialization/SceneObjectSerializer.cs
+++ b/OpenSim/Region/Framework/Scenes/Serialization/SceneObjectSerializer.cs
@@ -158,16 +158,15 @@ namespace OpenSim.Region.Framework.Scenes.Serialization
             writer.WriteEndElement();
             writer.WriteStartElement(String.Empty, "OtherParts", String.Empty);
 
-            lock (sceneObject.Children)
+            SceneObjectPart[] parts = sceneObject.Parts;
+            for (int i = 0; i < parts.Length; i++)
             {
-                foreach (SceneObjectPart part in sceneObject.Children.Values)
+                SceneObjectPart part = parts[i];
+                if (part.UUID != sceneObject.RootPart.UUID)
                 {
-                    if (part.UUID != sceneObject.RootPart.UUID)
-                    {
-                        writer.WriteStartElement(String.Empty, "Part", String.Empty);
-                        ToOriginalXmlFormat(part, writer);
-                        writer.WriteEndElement();
-                    }
+                    writer.WriteStartElement(String.Empty, "Part", String.Empty);
+                    ToOriginalXmlFormat(part, writer);
+                    writer.WriteEndElement();
                 }
             }
 
@@ -281,15 +280,12 @@ namespace OpenSim.Region.Framework.Scenes.Serialization
             sceneObject.RootPart.ToXml(writer);
             writer.WriteStartElement(String.Empty, "OtherParts", String.Empty);
 
-            lock (sceneObject.Children)
+            SceneObjectPart[] parts = sceneObject.Parts;
+            for (int i = 0; i < parts.Length; i++)
             {
-                foreach (SceneObjectPart part in sceneObject.Children.Values)
-                {
-                    if (part.UUID != sceneObject.RootPart.UUID)
-                    {
-                        part.ToXml(writer);
-                    }
-                }
+                SceneObjectPart part = parts[i];
+                if (part.UUID != sceneObject.RootPart.UUID)
+                    part.ToXml(writer);
             }
 
             writer.WriteEndElement(); // End of OtherParts
diff --git a/OpenSim/Region/Framework/Scenes/Tests/SceneGraphTests.cs b/OpenSim/Region/Framework/Scenes/Tests/SceneGraphTests.cs
index 7d9a6a9..9244bc3 100644
--- a/OpenSim/Region/Framework/Scenes/Tests/SceneGraphTests.cs
+++ b/OpenSim/Region/Framework/Scenes/Tests/SceneGraphTests.cs
@@ -68,7 +68,7 @@ namespace OpenSim.Region.Framework.Scenes.Tests
             SceneObjectGroup dupeSo 
                 = scene.SceneGraph.DuplicateObject(
                     part1.LocalId, new Vector3(10, 0, 0), 0, ownerId, UUID.Zero, Quaternion.Identity);
-            Assert.That(dupeSo.Children.Count, Is.EqualTo(2));
+            Assert.That(dupeSo.Parts.Length, Is.EqualTo(2));
             
             SceneObjectPart dupePart1 = dupeSo.GetLinkNumPart(1);
             SceneObjectPart dupePart2 = dupeSo.GetLinkNumPart(2);
diff --git a/OpenSim/Region/Framework/Scenes/Tests/SceneObjectLinkingTests.cs b/OpenSim/Region/Framework/Scenes/Tests/SceneObjectLinkingTests.cs
index 60824be..f57cf98 100644
--- a/OpenSim/Region/Framework/Scenes/Tests/SceneObjectLinkingTests.cs
+++ b/OpenSim/Region/Framework/Scenes/Tests/SceneObjectLinkingTests.cs
@@ -81,12 +81,12 @@ namespace OpenSim.Region.Framework.Scenes.Tests
             // FIXME: Can't do this test yet since group 2 still has its root part!  We can't yet null this since
             // it might cause SOG.ProcessBackup() to fail due to the race condition.  This really needs to be fixed.
             Assert.That(grp2.IsDeleted, "SOG 2 was not registered as deleted after link.");
-            Assert.That(grp2.Children.Count, Is.EqualTo(0), "Group 2 still contained children after delink.");
-            Assert.That(grp1.Children.Count == 2);
+            Assert.That(grp2.Parts.Length, Is.EqualTo(0), "Group 2 still contained children after delink.");
+            Assert.That(grp1.Parts.Length == 2);
 
             if (debugtest)
             {
-                m_log.Debug("parts: " + grp1.Children.Count);
+                m_log.Debug("parts: " + grp1.Parts.Length);
                 m_log.Debug("Group1: Pos:"+grp1.AbsolutePosition+", Rot:"+grp1.Rotation);
                 m_log.Debug("Group1: Prim1: OffsetPosition:"+ part1.OffsetPosition+", OffsetRotation:"+part1.RotationOffset);
                 m_log.Debug("Group1: Prim2: OffsetPosition:"+part2.OffsetPosition+", OffsetRotation:"+part2.RotationOffset);
@@ -126,7 +126,7 @@ namespace OpenSim.Region.Framework.Scenes.Tests
             if (debugtest)
                 m_log.Debug("Group2: Prim2: OffsetPosition:" + part2.AbsolutePosition + ", OffsetRotation:" + part2.RotationOffset);
 
-            Assert.That(grp1.Children.Count, Is.EqualTo(1), "Group 1 still contained part2 after delink.");
+            Assert.That(grp1.Parts.Length, Is.EqualTo(1), "Group 1 still contained part2 after delink.");
             Assert.That(part2.AbsolutePosition == Vector3.Zero, "The absolute position should be zero");
         }
 
@@ -177,22 +177,22 @@ namespace OpenSim.Region.Framework.Scenes.Tests
             grp3.LinkToGroup(grp4);
             
             // At this point we should have 4 parts total in two groups.
-            Assert.That(grp1.Children.Count == 2, "Group1 children count should be 2");
+            Assert.That(grp1.Parts.Length == 2, "Group1 children count should be 2");
             Assert.That(grp2.IsDeleted, "Group 2 was not registered as deleted after link.");
-            Assert.That(grp2.Children.Count, Is.EqualTo(0), "Group 2 still contained parts after delink.");
-            Assert.That(grp3.Children.Count == 2, "Group3 children count should be 2");
+            Assert.That(grp2.Parts.Length, Is.EqualTo(0), "Group 2 still contained parts after delink.");
+            Assert.That(grp3.Parts.Length == 2, "Group3 children count should be 2");
             Assert.That(grp4.IsDeleted, "Group 4 was not registered as deleted after link.");
-            Assert.That(grp4.Children.Count, Is.EqualTo(0), "Group 4 still contained parts after delink.");
+            Assert.That(grp4.Parts.Length, Is.EqualTo(0), "Group 4 still contained parts after delink.");
             
             if (debugtest)
             {
                 m_log.Debug("--------After Link-------");
-                m_log.Debug("Group1: parts:" + grp1.Children.Count);
+                m_log.Debug("Group1: parts:" + grp1.Parts.Length);
                 m_log.Debug("Group1: Pos:"+grp1.AbsolutePosition+", Rot:"+grp1.Rotation);
                 m_log.Debug("Group1: Prim1: OffsetPosition:" + part1.OffsetPosition + ", OffsetRotation:" + part1.RotationOffset);
                 m_log.Debug("Group1: Prim2: OffsetPosition:"+part2.OffsetPosition+", OffsetRotation:"+ part2.RotationOffset);
-                
-                m_log.Debug("Group3: parts:"+grp3.Children.Count);
+
+                m_log.Debug("Group3: parts:" + grp3.Parts.Length);
                 m_log.Debug("Group3: Pos:"+grp3.AbsolutePosition+", Rot:"+grp3.Rotation);
                 m_log.Debug("Group3: Prim1: OffsetPosition:"+part3.OffsetPosition+", OffsetRotation:"+part3.RotationOffset);
                 m_log.Debug("Group3: Prim2: OffsetPosition:"+part4.OffsetPosition+", OffsetRotation:"+part4.RotationOffset);
@@ -240,12 +240,12 @@ namespace OpenSim.Region.Framework.Scenes.Tests
             if (debugtest)
             {
                 m_log.Debug("--------After De-Link-------");
-                m_log.Debug("Group1: parts:" + grp1.Children.Count);
+                m_log.Debug("Group1: parts:" + grp1.Parts.Length);
                 m_log.Debug("Group1: Pos:" + grp1.AbsolutePosition + ", Rot:" + grp1.Rotation);
                 m_log.Debug("Group1: Prim1: OffsetPosition:" + part1.OffsetPosition + ", OffsetRotation:" + part1.RotationOffset);
                 m_log.Debug("Group1: Prim2: OffsetPosition:" + part2.OffsetPosition + ", OffsetRotation:" + part2.RotationOffset);
 
-                m_log.Debug("Group3: parts:" + grp3.Children.Count);
+                m_log.Debug("Group3: parts:" + grp3.Parts.Length);
                 m_log.Debug("Group3: Pos:" + grp3.AbsolutePosition + ", Rot:" + grp3.Rotation);
                 m_log.Debug("Group3: Prim1: OffsetPosition:" + part3.OffsetPosition + ", OffsetRotation:" + part3.RotationOffset);
                 m_log.Debug("Group3: Prim2: OffsetPosition:" + part4.OffsetPosition + ", OffsetRotation:" + part4.RotationOffset);
@@ -295,9 +295,9 @@ namespace OpenSim.Region.Framework.Scenes.Tests
             List<SceneObjectGroup> storedObjects = scene.SimulationDataService.LoadObjects(scene.RegionInfo.RegionID);
             
             Assert.That(storedObjects.Count, Is.EqualTo(1));
-            Assert.That(storedObjects[0].Children.Count, Is.EqualTo(2));
-            Assert.That(storedObjects[0].Children.ContainsKey(rootPartUuid));
-            Assert.That(storedObjects[0].Children.ContainsKey(linkPartUuid));
+            Assert.That(storedObjects[0].Parts.Length, Is.EqualTo(2));
+            Assert.That(storedObjects[0].ContainsPart(rootPartUuid));
+            Assert.That(storedObjects[0].ContainsPart(linkPartUuid));
         }
         
         /// <summary>
@@ -338,8 +338,8 @@ namespace OpenSim.Region.Framework.Scenes.Tests
             List<SceneObjectGroup> storedObjects = scene.SimulationDataService.LoadObjects(scene.RegionInfo.RegionID);
             
             Assert.That(storedObjects.Count, Is.EqualTo(1));
-            Assert.That(storedObjects[0].Children.Count, Is.EqualTo(1));
-            Assert.That(storedObjects[0].Children.ContainsKey(rootPartUuid));
+            Assert.That(storedObjects[0].Parts.Length, Is.EqualTo(1));
+            Assert.That(storedObjects[0].ContainsPart(rootPartUuid));
         }
     }
 }
diff --git a/OpenSim/Region/Framework/Scenes/UuidGatherer.cs b/OpenSim/Region/Framework/Scenes/UuidGatherer.cs
index e3965ce..65baa52 100644
--- a/OpenSim/Region/Framework/Scenes/UuidGatherer.cs
+++ b/OpenSim/Region/Framework/Scenes/UuidGatherer.cs
@@ -121,8 +121,11 @@ namespace OpenSim.Region.Framework.Scenes
 //            m_log.DebugFormat(
 //                "[ASSET GATHERER]: Getting assets for object {0}, {1}", sceneObject.Name, sceneObject.UUID);
 
-            foreach (SceneObjectPart part in sceneObject.GetParts())
+            SceneObjectPart[] parts = sceneObject.Parts;
+            for (int i = 0; i < parts.Length; i++)
             {
+                SceneObjectPart part = parts[i];
+
 //                m_log.DebugFormat(
 //                    "[ARCHIVER]: Getting part {0}, {1} for object {2}", part.Name, part.UUID, sceneObject.UUID);
 
diff --git a/OpenSim/Region/OptionalModules/ContentManagementSystem/CMEntityCollection.cs b/OpenSim/Region/OptionalModules/ContentManagementSystem/CMEntityCollection.cs
index d21b652..7f64ebd 100644
--- a/OpenSim/Region/OptionalModules/ContentManagementSystem/CMEntityCollection.cs
+++ b/OpenSim/Region/OptionalModules/ContentManagementSystem/CMEntityCollection.cs
@@ -121,19 +121,16 @@ namespace OpenSim.Region.OptionalModules.ContentManagement
                     continue;
                 temp = (SceneObjectGroup) currObj;
 
-                lock (temp.Children)
+                if (m_CMEntityHash.ContainsKey(temp.UUID))
                 {
-                    if (m_CMEntityHash.ContainsKey(temp.UUID))
-                    {
-                        foreach (SceneObjectPart part in temp.Children.Values)
-                            if (!((ContentManagementEntity)m_CMEntityHash[temp.UUID]).HasChildPrim(part.UUID))
-                                missingList.Add(part);
-                    }
-                    else //Entire group is missing from revision. (and is a new part in region)
-                    {
-                        foreach (SceneObjectPart part in temp.Children.Values)
+                    foreach (SceneObjectPart part in temp.Parts)
+                        if (!((ContentManagementEntity)m_CMEntityHash[temp.UUID]).HasChildPrim(part.UUID))
                             missingList.Add(part);
-                    }
+                }
+                else //Entire group is missing from revision. (and is a new part in region)
+                {
+                    foreach (SceneObjectPart part in temp.Parts)
+                        missingList.Add(part);
                 }
             }
             return missingList;
diff --git a/OpenSim/Region/OptionalModules/ContentManagementSystem/CMModel.cs b/OpenSim/Region/OptionalModules/ContentManagementSystem/CMModel.cs
index 0b02a9f..3a6996e 100644
--- a/OpenSim/Region/OptionalModules/ContentManagementSystem/CMModel.cs
+++ b/OpenSim/Region/OptionalModules/ContentManagementSystem/CMModel.cs
@@ -167,11 +167,11 @@ namespace OpenSim.Region.OptionalModules.ContentManagement
         public void RemoveOrUpdateDeletedEntity(SceneObjectGroup group)
         {
             // Deal with new parts not revisioned that have been deleted.
-            lock (group.Children)
+            SceneObjectPart[] parts = group.Parts;
+            for (int i = 0; i < parts.Length; i++)
             {
-                foreach (SceneObjectPart part in group.Children.Values)
-                    if (m_MetaEntityCollection.Auras.ContainsKey(part.UUID))
-                        m_MetaEntityCollection.RemoveNewlyCreatedEntityAura(part.UUID);
+                if (m_MetaEntityCollection.Auras.ContainsKey(parts[i].UUID))
+                        m_MetaEntityCollection.RemoveNewlyCreatedEntityAura(parts[i].UUID);
             }
         }
 
@@ -210,12 +210,10 @@ namespace OpenSim.Region.OptionalModules.ContentManagement
                 {
                     temp = SceneObjectSerializer.FromXml2Format(xml);
                     temp.SetScene(scene);
-                    
-                    lock (temp.Children)
-                    {
-                        foreach (SceneObjectPart part in temp.Children.Values)
-                            part.RegionHandle = scene.RegionInfo.RegionHandle;
-                    }
+
+                    SceneObjectPart[] parts = temp.Parts;
+                    for (int i = 0; i < parts.Length; i++)
+                        parts[i].RegionHandle = scene.RegionInfo.RegionHandle;
                     
                     ReplacementList.Add(temp.UUID, (EntityBase)temp);
                 }
@@ -346,17 +344,16 @@ namespace OpenSim.Region.OptionalModules.ContentManagement
             System.Collections.ArrayList auraList = new System.Collections.ArrayList();
             if (group == null)
                 return null;
-            
-            lock (group.Children)
+
+            SceneObjectPart[] parts = group.Parts;
+            for (int i = 0; i < parts.Length; i++)
             {
-                foreach (SceneObjectPart part in group.Children.Values)
+                SceneObjectPart part = parts[i];
+                if (m_MetaEntityCollection.Auras.ContainsKey(part.UUID))
                 {
-                    if (m_MetaEntityCollection.Auras.ContainsKey(part.UUID))
-                    {
-                        ((AuraMetaEntity)m_MetaEntityCollection.Auras[part.UUID]).SetAura(new Vector3(0,254,0), part.Scale);
-                        ((AuraMetaEntity)m_MetaEntityCollection.Auras[part.UUID]).RootPart.GroupPosition = part.GetWorldPosition();
-                        auraList.Add((AuraMetaEntity)m_MetaEntityCollection.Auras[part.UUID]);
-                    }
+                    ((AuraMetaEntity)m_MetaEntityCollection.Auras[part.UUID]).SetAura(new Vector3(0, 254, 0), part.Scale);
+                    ((AuraMetaEntity)m_MetaEntityCollection.Auras[part.UUID]).RootPart.GroupPosition = part.GetWorldPosition();
+                    auraList.Add((AuraMetaEntity)m_MetaEntityCollection.Auras[part.UUID]);
                 }
             }
             
diff --git a/OpenSim/Region/OptionalModules/ContentManagementSystem/CMView.cs b/OpenSim/Region/OptionalModules/ContentManagementSystem/CMView.cs
index f75f40a..3807ccd 100644
--- a/OpenSim/Region/OptionalModules/ContentManagementSystem/CMView.cs
+++ b/OpenSim/Region/OptionalModules/ContentManagementSystem/CMView.cs
@@ -186,12 +186,9 @@ namespace OpenSim.Region.OptionalModules.ContentManagement
                 ((ContentManagementEntity)m_model.MetaEntityCollection.Entities[group.UUID]).SendFullDiffUpdateToAll();
 
             // Deal with new parts not revisioned that have been deleted.
-            lock (group.Children)
-            {
-                foreach (SceneObjectPart part in group.Children.Values)
-                    if (m_model.MetaEntityCollection.Auras.ContainsKey(part.UUID))
-                        ((AuraMetaEntity)m_model.MetaEntityCollection.Auras[part.UUID]).HideFromAll();
-            }
+            foreach (SceneObjectPart part in group.Parts)
+                if (m_model.MetaEntityCollection.Auras.ContainsKey(part.UUID))
+                    ((AuraMetaEntity)m_model.MetaEntityCollection.Auras[part.UUID]).HideFromAll();
         }
 
         public void SendMetaEntitiesToNewClient(IClientAPI client)
diff --git a/OpenSim/Region/OptionalModules/ContentManagementSystem/ContentManagementEntity.cs b/OpenSim/Region/OptionalModules/ContentManagementSystem/ContentManagementEntity.cs
index 49d20e1..0248f36 100644
--- a/OpenSim/Region/OptionalModules/ContentManagementSystem/ContentManagementEntity.cs
+++ b/OpenSim/Region/OptionalModules/ContentManagementSystem/ContentManagementEntity.cs
@@ -132,33 +132,30 @@ namespace OpenSim.Region.OptionalModules.ContentManagement
             // if group is not contained in scene's list
             if (!ContainsKey(sceneEntityList, m_UnchangedEntity.UUID))
             {
-                lock (m_UnchangedEntity.Children)
+                foreach (SceneObjectPart part in m_UnchangedEntity.Parts)
                 {
-                    foreach (SceneObjectPart part in m_UnchangedEntity.Children.Values)
+                    // if scene list no longer contains this part, display translucent part and mark with red aura
+                    if (!ContainsKey(sceneEntityList, part.UUID))
                     {
-                        // if scene list no longer contains this part, display translucent part and mark with red aura
-                        if (!ContainsKey(sceneEntityList, part.UUID))
+                        // if already displaying a red aura over part, make sure its red
+                        if (m_AuraEntities.ContainsKey(part.UUID))
                         {
-                            // if already displaying a red aura over part, make sure its red
-                            if (m_AuraEntities.ContainsKey(part.UUID))
-                            {
-                                m_AuraEntities[part.UUID].SetAura(new Vector3(254,0,0), part.Scale);
-                            }
-                            else
-                            {
-                                AuraMetaEntity auraGroup = new AuraMetaEntity(m_Entity.Scene,
-                                                                              part.GetWorldPosition(),
-                                                                              MetaEntity.TRANSLUCENT,
-                                                                              new Vector3(254,0,0),
-                                                                              part.Scale
-                                                                              );
-                                m_AuraEntities.Add(part.UUID, auraGroup);
-                            }
-                            SceneObjectPart metaPart = m_Entity.GetLinkNumPart(part.LinkNum);
-                            SetPartTransparency(metaPart, MetaEntity.TRANSLUCENT);
+                            m_AuraEntities[part.UUID].SetAura(new Vector3(254, 0, 0), part.Scale);
+                        }
+                        else
+                        {
+                            AuraMetaEntity auraGroup = new AuraMetaEntity(m_Entity.Scene,
+                                                                          part.GetWorldPosition(),
+                                                                          MetaEntity.TRANSLUCENT,
+                                                                          new Vector3(254, 0, 0),
+                                                                          part.Scale
+                                                                          );
+                            m_AuraEntities.Add(part.UUID, auraGroup);
                         }
-                        // otherwise, scene will not contain the part. note: a group can not remove a part without changing group id
+                        SceneObjectPart metaPart = m_Entity.GetLinkNumPart(part.LinkNum);
+                        SetPartTransparency(metaPart, MetaEntity.TRANSLUCENT);
                     }
+                    // otherwise, scene will not contain the part. note: a group can not remove a part without changing group id
                 }
 
                 // a deleted part has no where to point a beam particle system,
@@ -183,11 +180,7 @@ namespace OpenSim.Region.OptionalModules.ContentManagement
         /// </summary>
         public bool HasChildPrim(UUID uuid)
         {
-            lock (m_UnchangedEntity.Children)
-                if (m_UnchangedEntity.Children.ContainsKey(uuid))
-                    return true;
-            
-            return false;
+            return m_UnchangedEntity.ContainsPart(uuid);
         }
 
         /// <summary>
@@ -195,12 +188,9 @@ namespace OpenSim.Region.OptionalModules.ContentManagement
         /// </summary>
         public bool HasChildPrim(uint localID)
         {
-            lock (m_UnchangedEntity.Children)
-            {
-                foreach (SceneObjectPart part in m_UnchangedEntity.Children.Values)
-                    if (part.LocalId == localID)
-                        return true;
-            }
+            foreach (SceneObjectPart part in m_UnchangedEntity.Parts)
+                if (part.LocalId == localID)
+                    return true;
             
             return false;
         }
@@ -237,72 +227,37 @@ namespace OpenSim.Region.OptionalModules.ContentManagement
             // Use "UnchangedEntity" to do comparisons because its text, transparency, and other attributes will be just as the user
             // had originally saved.
             // m_Entity will NOT necessarily be the same entity as the user had saved.
-            lock (m_UnchangedEntity.Children)
+            foreach (SceneObjectPart UnchangedPart in m_UnchangedEntity.Parts)
             {
-                foreach (SceneObjectPart UnchangedPart in m_UnchangedEntity.Children.Values)
+                //This is the part that we use to show changes.
+                metaEntityPart = m_Entity.GetLinkNumPart(UnchangedPart.LinkNum);
+                if (sceneEntityGroup.ContainsPart(UnchangedPart.UUID))
                 {
-                    //This is the part that we use to show changes.
-                    metaEntityPart = m_Entity.GetLinkNumPart(UnchangedPart.LinkNum);
-                    if (sceneEntityGroup.Children.ContainsKey(UnchangedPart.UUID))
+                    sceneEntityPart = sceneEntityGroup.GetChildPart(UnchangedPart.UUID);
+                    differences = Difference.FindDifferences(UnchangedPart, sceneEntityPart);
+                    if (differences != Diff.NONE)
+                        metaEntityPart.Text = "CHANGE: " + differences.ToString();
+                    if (differences != 0)
                     {
-                        sceneEntityPart = sceneEntityGroup.Children[UnchangedPart.UUID];
-                        differences = Difference.FindDifferences(UnchangedPart,  sceneEntityPart);
-                        if (differences != Diff.NONE)
-                            metaEntityPart.Text = "CHANGE: " + differences.ToString();
-                        if (differences != 0)
-                        {
-                            // Root Part that has been modified
-                            if ((differences&Diff.POSITION) > 0)
-                            {
-                                // If the position of any part has changed, make sure the RootPart of the
-                                // meta entity is pointing with a beam particle system
-                                if (m_BeamEntities.ContainsKey(m_UnchangedEntity.RootPart.UUID))
-                                {
-                                    m_BeamEntities[m_UnchangedEntity.RootPart.UUID].HideFromAll();
-                                    m_BeamEntities.Remove(m_UnchangedEntity.RootPart.UUID);
-                                }
-                                BeamMetaEntity beamGroup = new BeamMetaEntity(m_Entity.Scene,
-                                                                              m_UnchangedEntity.RootPart.GetWorldPosition(),
-                                                                              MetaEntity.TRANSLUCENT,
-                                                                              sceneEntityPart,
-                                                                              new Vector3(0,0,254)
-                                                                              );
-                                m_BeamEntities.Add(m_UnchangedEntity.RootPart.UUID, beamGroup);
-                            }
-    
-                            if (m_AuraEntities.ContainsKey(UnchangedPart.UUID))
-                            {
-                                m_AuraEntities[UnchangedPart.UUID].HideFromAll();
-                                m_AuraEntities.Remove(UnchangedPart.UUID);
-                            }
-                            AuraMetaEntity auraGroup = new AuraMetaEntity(m_Entity.Scene,
-                                                                          UnchangedPart.GetWorldPosition(),
-                                                                          MetaEntity.TRANSLUCENT,
-                                                                          new Vector3(0,0,254),
-                                                                          UnchangedPart.Scale
-                                                                          );
-                            m_AuraEntities.Add(UnchangedPart.UUID, auraGroup);
-                            SetPartTransparency(metaEntityPart, MetaEntity.TRANSLUCENT);
-    
-                            DiffersFromSceneGroup = true;
-                        }
-                        else // no differences between scene part and meta part
+                        // Root Part that has been modified
+                        if ((differences & Diff.POSITION) > 0)
                         {
+                            // If the position of any part has changed, make sure the RootPart of the
+                            // meta entity is pointing with a beam particle system
                             if (m_BeamEntities.ContainsKey(m_UnchangedEntity.RootPart.UUID))
                             {
                                 m_BeamEntities[m_UnchangedEntity.RootPart.UUID].HideFromAll();
                                 m_BeamEntities.Remove(m_UnchangedEntity.RootPart.UUID);
                             }
-                            if (m_AuraEntities.ContainsKey(UnchangedPart.UUID))
-                            {
-                                m_AuraEntities[UnchangedPart.UUID].HideFromAll();
-                                m_AuraEntities.Remove(UnchangedPart.UUID);
-                            }
-                            SetPartTransparency(metaEntityPart, MetaEntity.NONE);
+                            BeamMetaEntity beamGroup = new BeamMetaEntity(m_Entity.Scene,
+                                                                          m_UnchangedEntity.RootPart.GetWorldPosition(),
+                                                                          MetaEntity.TRANSLUCENT,
+                                                                          sceneEntityPart,
+                                                                          new Vector3(0, 0, 254)
+                                                                          );
+                            m_BeamEntities.Add(m_UnchangedEntity.RootPart.UUID, beamGroup);
                         }
-                    }
-                    else  //The entity currently in the scene is missing parts from the metaentity saved, so mark parts red as deleted.
-                    {
+
                         if (m_AuraEntities.ContainsKey(UnchangedPart.UUID))
                         {
                             m_AuraEntities[UnchangedPart.UUID].HideFromAll();
@@ -311,14 +266,46 @@ namespace OpenSim.Region.OptionalModules.ContentManagement
                         AuraMetaEntity auraGroup = new AuraMetaEntity(m_Entity.Scene,
                                                                       UnchangedPart.GetWorldPosition(),
                                                                       MetaEntity.TRANSLUCENT,
-                                                                      new Vector3(254,0,0),
+                                                                      new Vector3(0, 0, 254),
                                                                       UnchangedPart.Scale
                                                                       );
                         m_AuraEntities.Add(UnchangedPart.UUID, auraGroup);
                         SetPartTransparency(metaEntityPart, MetaEntity.TRANSLUCENT);
-                       
+
                         DiffersFromSceneGroup = true;
                     }
+                    else // no differences between scene part and meta part
+                    {
+                        if (m_BeamEntities.ContainsKey(m_UnchangedEntity.RootPart.UUID))
+                        {
+                            m_BeamEntities[m_UnchangedEntity.RootPart.UUID].HideFromAll();
+                            m_BeamEntities.Remove(m_UnchangedEntity.RootPart.UUID);
+                        }
+                        if (m_AuraEntities.ContainsKey(UnchangedPart.UUID))
+                        {
+                            m_AuraEntities[UnchangedPart.UUID].HideFromAll();
+                            m_AuraEntities.Remove(UnchangedPart.UUID);
+                        }
+                        SetPartTransparency(metaEntityPart, MetaEntity.NONE);
+                    }
+                }
+                else  //The entity currently in the scene is missing parts from the metaentity saved, so mark parts red as deleted.
+                {
+                    if (m_AuraEntities.ContainsKey(UnchangedPart.UUID))
+                    {
+                        m_AuraEntities[UnchangedPart.UUID].HideFromAll();
+                        m_AuraEntities.Remove(UnchangedPart.UUID);
+                    }
+                    AuraMetaEntity auraGroup = new AuraMetaEntity(m_Entity.Scene,
+                                                                  UnchangedPart.GetWorldPosition(),
+                                                                  MetaEntity.TRANSLUCENT,
+                                                                  new Vector3(254, 0, 0),
+                                                                  UnchangedPart.Scale
+                                                                  );
+                    m_AuraEntities.Add(UnchangedPart.UUID, auraGroup);
+                    SetPartTransparency(metaEntityPart, MetaEntity.TRANSLUCENT);
+
+                    DiffersFromSceneGroup = true;
                 }
             }
             
diff --git a/OpenSim/Region/OptionalModules/ContentManagementSystem/MetaEntity.cs b/OpenSim/Region/OptionalModules/ContentManagementSystem/MetaEntity.cs
index d7838c5..c7b1ed7 100644
--- a/OpenSim/Region/OptionalModules/ContentManagementSystem/MetaEntity.cs
+++ b/OpenSim/Region/OptionalModules/ContentManagementSystem/MetaEntity.cs
@@ -98,10 +98,9 @@ namespace OpenSim.Region.OptionalModules.ContentManagement
 
         #region Public Properties
 
-        public Dictionary<UUID, SceneObjectPart> Children
+        public SceneObjectPart[] Parts
         {
-            get { return m_Entity.Children; }
-            set { m_Entity.Children = value; }
+            get { return m_Entity.Parts; }
         }
 
         public uint LocalId
@@ -150,19 +149,17 @@ namespace OpenSim.Region.OptionalModules.ContentManagement
         {
             //make new uuids
             Dictionary<UUID, SceneObjectPart> parts = new Dictionary<UUID, SceneObjectPart>();
-            
-            lock (m_Entity.Children)
+
+            foreach (SceneObjectPart part in m_Entity.Parts)
             {
-                foreach (SceneObjectPart part in m_Entity.Children.Values)
-                {
-                    part.ResetIDs(part.LinkNum);
-                    parts.Add(part.UUID, part);
-                }
-                
-                //finalize
-                m_Entity.RootPart.PhysActor = null;
-                m_Entity.Children = parts;
+                part.ResetIDs(part.LinkNum);
+                parts.Add(part.UUID, part);
             }
+
+            //finalize
+            m_Entity.RootPart.PhysActor = null;
+            foreach (SceneObjectPart part in parts.Values)
+                m_Entity.AddPart(part);
         }
 
         #endregion Protected Methods
@@ -177,11 +174,8 @@ namespace OpenSim.Region.OptionalModules.ContentManagement
             //This deletes the group without removing from any databases.
             //This is important because we are not IN any database.
             //m_Entity.FakeDeleteGroup();
-            lock (m_Entity.Children)
-            {
-                foreach (SceneObjectPart part in m_Entity.Children.Values)
-                    client.SendKillObject(m_Entity.RegionHandle, part.LocalId);
-            }
+            foreach (SceneObjectPart part in m_Entity.Parts)
+                client.SendKillObject(m_Entity.RegionHandle, part.LocalId);
         }
 
         /// <summary>
@@ -189,15 +183,12 @@ namespace OpenSim.Region.OptionalModules.ContentManagement
         /// </summary>
         public virtual void HideFromAll()
         {
-            lock (m_Entity.Children)
+            foreach (SceneObjectPart part in m_Entity.Parts)
             {
-                foreach (SceneObjectPart part in m_Entity.Children.Values)
-                {
-                    m_Entity.Scene.ForEachClient(
-                        delegate(IClientAPI controller)
-                        { controller.SendKillObject(m_Entity.RegionHandle, part.LocalId); }
-                    );
-                }
+                m_Entity.Scene.ForEachClient(
+                    delegate(IClientAPI controller)
+                    { controller.SendKillObject(m_Entity.RegionHandle, part.LocalId); }
+                );
             }
         }
 
diff --git a/OpenSim/Region/OptionalModules/Scripting/Minimodule/SOPObject.cs b/OpenSim/Region/OptionalModules/Scripting/Minimodule/SOPObject.cs
index 59ad9d8..faed522 100644
--- a/OpenSim/Region/OptionalModules/Scripting/Minimodule/SOPObject.cs
+++ b/OpenSim/Region/OptionalModules/Scripting/Minimodule/SOPObject.cs
@@ -193,11 +193,7 @@ namespace OpenSim.Region.OptionalModules.Scripting.Minimodule
 
                 int i = 0;
                     
-                List<SceneObjectPart> partList = null;
-                lock (my.ParentGroup.Children)
-                    partList = new List<SceneObjectPart>(my.ParentGroup.Children.Values);
-                    
-                foreach (SceneObjectPart part in partList)
+                foreach (SceneObjectPart part in my.ParentGroup.Parts)
                 {
                     rets[i++] = new SOPObject(m_rootScene, part.LocalId, m_security);
                 }
diff --git a/OpenSim/Region/ScriptEngine/Shared/Api/Implementation/LSL_Api.cs b/OpenSim/Region/ScriptEngine/Shared/Api/Implementation/LSL_Api.cs
index 0dd1787..caa39ba 100644
--- a/OpenSim/Region/ScriptEngine/Shared/Api/Implementation/LSL_Api.cs
+++ b/OpenSim/Region/ScriptEngine/Shared/Api/Implementation/LSL_Api.cs
@@ -294,8 +294,7 @@ namespace OpenSim.Region.ScriptEngine.Shared.Api
             case ScriptBaseClass.LINK_SET:
                 if (m_host.ParentGroup != null)
                 {
-                    lock (m_host.ParentGroup.Children)
-                        return new List<SceneObjectPart>(m_host.ParentGroup.Children.Values);
+                    return new List<SceneObjectPart>(m_host.ParentGroup.Parts);
                 }
                 return ret;
 
@@ -312,8 +311,7 @@ namespace OpenSim.Region.ScriptEngine.Shared.Api
                 if (m_host.ParentGroup ==  null)
                     return new List<SceneObjectPart>();
                 
-                lock (m_host.ParentGroup.Children)
-                    ret = new List<SceneObjectPart>(m_host.ParentGroup.Children.Values);
+                ret = new List<SceneObjectPart>(m_host.ParentGroup.Parts);
                 
                 if (ret.Contains(m_host))
                     ret.Remove(m_host);
@@ -323,8 +321,7 @@ namespace OpenSim.Region.ScriptEngine.Shared.Api
                 if (m_host.ParentGroup ==  null)
                     return new List<SceneObjectPart>();
                 
-                lock (m_host.ParentGroup.Children)
-                    ret = new List<SceneObjectPart>(m_host.ParentGroup.Children.Values);
+                ret = new List<SceneObjectPart>(m_host.ParentGroup.Parts);
                 
                 if (ret.Contains(m_host.ParentGroup.RootPart))
                     ret.Remove(m_host.ParentGroup.RootPart);
@@ -1281,16 +1278,13 @@ namespace OpenSim.Region.ScriptEngine.Shared.Api
                     if (group == null)
                         return;
                     bool allow = true;
-                    
-                    lock (group.Children)
+
+                    foreach (SceneObjectPart part in group.Parts)
                     {
-                        foreach (SceneObjectPart part in group.Children.Values)
+                        if (part.Scale.X > World.m_maxPhys || part.Scale.Y > World.m_maxPhys || part.Scale.Z > World.m_maxPhys)
                         {
-                            if (part.Scale.X > World.m_maxPhys || part.Scale.Y > World.m_maxPhys || part.Scale.Z > World.m_maxPhys)
-                            {
-                                allow = false;
-                                break;
-                            }
+                            allow = false;
+                            break;
                         }
                     }
 
@@ -3889,18 +3883,15 @@ namespace OpenSim.Region.ScriptEngine.Shared.Api
                 case ScriptBaseClass.LINK_ALL_OTHERS:
                 case ScriptBaseClass.LINK_ALL_CHILDREN:
                 case ScriptBaseClass.LINK_THIS:
-                    lock (parentPrim.Children)
+                    foreach (SceneObjectPart part in parentPrim.Parts)
                     {
-                        foreach (SceneObjectPart part in parentPrim.Children.Values)
+                        if (part.UUID != m_host.UUID)
                         {
-                            if (part.UUID != m_host.UUID)
-                            {
-                                childPrim = part;
-                                break;
-                            }
+                            childPrim = part;
+                            break;
                         }
-                        break;
                     }
+                    break;
                 default:
                     childPrim = parentPrim.GetLinkNumPart(linknum);
                     if (childPrim.UUID == m_host.UUID)
@@ -3911,7 +3902,7 @@ namespace OpenSim.Region.ScriptEngine.Shared.Api
             if (linknum == ScriptBaseClass.LINK_ROOT)
             {
                 // Restructuring Multiple Prims.
-                List<SceneObjectPart> parts = new List<SceneObjectPart>(parentPrim.Children.Values);
+                List<SceneObjectPart> parts = new List<SceneObjectPart>(parentPrim.Parts);
                 parts.Remove(parentPrim.RootPart);
                 if (parts.Count > 0)
                 {
@@ -3976,19 +3967,16 @@ namespace OpenSim.Region.ScriptEngine.Shared.Api
             if (parentPrim.RootPart.AttachmentPoint != 0)
                 return; // Fail silently if attached
 
-            lock (parentPrim.Children)
+            List<SceneObjectPart> parts = new List<SceneObjectPart>(parentPrim.Parts);
+            parts.Remove(parentPrim.RootPart);
+
+            foreach (SceneObjectPart part in parts)
             {
-                List<SceneObjectPart> parts = new List<SceneObjectPart>(parentPrim.Children.Values);
-                parts.Remove(parentPrim.RootPart);
-    
-                foreach (SceneObjectPart part in parts)
-                {
-                    parentPrim.DelinkFromGroup(part.LocalId, true);
-                    parentPrim.TriggerScriptChangedEvent(Changed.LINK);
-                }
-                parentPrim.HasGroupChanged = true;
-                parentPrim.ScheduleGroupForFullUpdate();
+                parentPrim.DelinkFromGroup(part.LocalId, true);
+                parentPrim.TriggerScriptChangedEvent(Changed.LINK);
             }
+            parentPrim.HasGroupChanged = true;
+            parentPrim.ScheduleGroupForFullUpdate();
         }
 
         public LSL_String llGetLinkKey(int linknum)
diff --git a/OpenSim/Region/ScriptEngine/Shared/Helpers.cs b/OpenSim/Region/ScriptEngine/Shared/Helpers.cs
index 41501f2..3575889 100644
--- a/OpenSim/Region/ScriptEngine/Shared/Helpers.cs
+++ b/OpenSim/Region/ScriptEngine/Shared/Helpers.cs
@@ -209,15 +209,12 @@ namespace OpenSim.Region.ScriptEngine.Shared
             else
                 Type = 0x02; // Passive
 
-            lock (part.ParentGroup.Children)
+            foreach (SceneObjectPart p in part.ParentGroup.Parts)
             {
-                foreach (SceneObjectPart p in part.ParentGroup.Children.Values)
+                if (p.Inventory.ContainsScripts())
                 {
-                    if (p.Inventory.ContainsScripts())
-                    {
-                        Type |= 0x08; // Scripted
-                        break;
-                    }
+                    Type |= 0x08; // Scripted
+                    break;
                 }
             }