| Commit message (Collapse) | Author | Age | Files | Lines | |
|---|---|---|---|---|---|
| * | Don't try and delete attachments for child agent close | Justin Clark-Casey (justincc) | 2011-09-13 | 1 | -0/+32 |
| | | |||||
| * | Remove code from DetachSingleAttachmentToInv() that sets group changed on ↵ | Justin Clark-Casey (justincc) | 2011-09-13 | 1 | -11/+0 |
| | | | | | all parts, now that we're performing this check in UpdateKnownItem() for other purposes | ||||
| * | remove redunant itemID and agentID arguments from UpdateKnownItem(). | Justin Clark-Casey (justincc) | 2011-09-13 | 1 | -6/+4 |
| | | | | | itemID is always taken taken from the group's stored item id, and agentID is never used. | ||||
| * | Remove UpdateKnownItem() from IAttachmentsModule. | Justin Clark-Casey (justincc) | 2011-09-13 | 1 | -1/+1 |
| | | | | | It's not appropriate for code outside the attachments module to call this. | ||||
| * | minor: remove redundant grp != null check from AM.UpdateKnownItem() | Justin Clark-Casey (justincc) | 2011-09-13 | 1 | -36/+33 |
| | | |||||
| * | Stop attempts to rewear already worn items from removing and reattaching. | Justin Clark-Casey (justincc) | 2011-09-13 | 1 | -42/+77 |
| | | | | | | | | | Viewer 2/3 will sometimes attempt to rewear attachments, even though they have already been attached during the main login process. This change ignores those attempts. This stops script failures during login, as the rewearing was racing with the script startup code. It might also help with attachments being abnormally put into deleted state. Hopefully resolves some more of http://opensimulator.org/mantis/view.php?id=5644 | ||||
| * | Comment out attachments code in Scene.IncomingCreateObject(UUID userID, UUID ↵ | Justin Clark-Casey (justincc) | 2011-09-13 | 1 | -3/+14 |
| | | | | | | | | | | itemID) for now As far as I can see, this is only invoked by a PUT request to ObjectHandlers, which is not being used anyway. Invoking attachments code at this point is probably inappropriate since it would still be invoked when the client entered the scene. Being commented to simplify analysis of attachments issues. Can be uncommented when in use. Also, small tweak to lock and log removal of a SOG from the SceneObjectGroupsByLocalPartID collection in SceneGraph.GetGroupByPrim() if an inconsistency is found. | ||||
| * | Start locking entire add/remove operations on an ↵ | Justin Clark-Casey (justincc) | 2011-09-12 | 1 | -175/+207 |
| | | | | | | | | | | IScenePresence.AttachmentsSyncLock object Attach and detach packets are processed asynchronously when received from a viewer. Bugs like http://opensimulator.org/mantis/view.php?id=5644 indicate that in some situations (such as attaching/detaching entire folders of objects at once), there are race conditions between these threads. Since multiple data structures need to be updated on attach/detach, it's not enough to lock the individual collections. Therefore, this commit introduces a new IScenePresence.AttachmentsSyncLock which add/remove operations lock on. | ||||
| * | Remember to set and unset the fire and forget method at the top of the ↵ | Justin Clark-Casey (justincc) | 2011-09-08 | 1 | -3/+7 |
| | | | | | attachment and npc tests | ||||
| * | refactor: Make logic in AM.AttachObject() clearer by not reusing existing ↵ | Justin Clark-Casey (justincc) | 2011-09-06 | 1 | -14/+19 |
| | | | | | variables in different contexts | ||||
| * | rename AM.AddSceneObjectAsAttachment() to AddSceneObjectAsNewAttachmentInInv | Justin Clark-Casey (justincc) | 2011-09-06 | 1 | -3/+3 |
| | | |||||
| * | In SetAttachment, if the existing attachment has no asset id then carry on ↵ | Justin Clark-Casey (justincc) | 2011-09-06 | 1 | -0/+8 |
| | | | | | | | | | | | | rather than abort. When a user logs in, the attachment item ids are pulled from persistence in the Avatars table. However, the asset ids are not saved. When the avatar enters a simulator the attachments are set again. If we simply perform an item check then the asset ids (which are now present) are never set, and NPC attachments later fail unless the attachment is detached and reattached. Hopefully resolves part of http://opensimulator.org/mantis/view.php?id=5653 | ||||
| * | Get rid of the confusing version of ↵ | Justin Clark-Casey (justincc) | 2011-09-06 | 1 | -11/+2 |
| | | | | | IAttachmentsModule.RezSingleAttachmentFromInventory() with the updateInventoryStatus switch, since this is never called with false | ||||
| * | get rid of the unused AttachmentsModule.ShowAttachInUserInventory() | Justin Clark-Casey (justincc) | 2011-09-06 | 1 | -28/+0 |
| | | |||||
| * | Stop the pointless double setting of every attachment in AvatarAppearance. | Justin Clark-Casey (justincc) | 2011-09-06 | 2 | -6/+3 |
| | | | | | The second was already being filtered out so this has no user level effect | ||||
| * | Stop NPCs losing attachments when the source avatar takes them off. | Justin Clark-Casey (justincc) | 2011-09-03 | 1 | -28/+48 |
| | | | | | | | | This was happening because we were using the source avatar's item IDs in the clone appearance. Switch to using the asset IDs of attachments instead for NPCs. The InventoryAccessModule and AttachmentModule had to be changed to allow rezzing of an object without an associated inventory item. Hopefully goes some way towards resolving http://opensimulator.org/mantis/view.php?id=5653 | ||||
| * | Eliminate pointless checks of SOG.RootPart != null | Justin Clark-Casey (justincc) | 2011-09-01 | 1 | -6/+0 |
| | | | | | It's never possible for SOG to have no RootPart, except in the first few picosends of the big bang when it's pulled from region persistence or deserialized | ||||
| * | move common code into AttachmentsModule.DeleteAttachmentsFromScene() | Justin Clark-Casey (justincc) | 2011-08-31 | 1 | -0/+10 |
| | | |||||
| * | Make SP.Attachments available as sp.GetAttachments() instead. | Justin Clark-Casey (justincc) | 2011-08-31 | 2 | -17/+12 |
| | | | | | | | | The approach here, as in other parts of OpenSim, is to return a copy of the list rather than the attachments list itself This prevents callers from forgetting to lock the list when they read it, as was happening in various parts of the codebase. It also improves liveness. This might improve attachment anomolies when performing region crossings. | ||||
| * | remove pointless ToArray() call in AttachmentsModule.SaveChangedAttachments() | Justin Clark-Casey (justincc) | 2011-08-30 | 1 | -1/+1 |
| | | |||||
| * | minor: remove already processed avatar null check in Scene.RemoveClient() | Justin Clark-Casey (justincc) | 2011-08-30 | 1 | -1/+0 |
| | | | | | remove some now duplicated method doc | ||||
| * | refactor: move SP.SaveChangedAttachments() fully into AttachmentsModule | Justin Clark-Casey (justincc) | 2011-08-30 | 1 | -0/+18 |
| | | |||||
| * | refactor: Move ScenePresence.RezAttachments() into AttachmentsModule | Justin Clark-Casey (justincc) | 2011-08-30 | 1 | -0/+38 |
| | | | | | This adds an incomplete IScenePresence to match ISceneEntity | ||||
| * | refactor: migrate DropObject handling fully into AttachmentsModule from Scene | Justin Clark-Casey (justincc) | 2011-08-30 | 2 | -16/+12 |
| | | |||||
| * | Fix bug where attachments were remaining on the avatar after being dropped. | Justin Clark-Casey (justincc) | 2011-08-30 | 2 | -6/+20 |
| | | | | | If the inventory service is configured not to allow deletion then these will not disappear from inventory | ||||
| * | Eliminate duplicate AttachmentPoint properties by always using the one ↵ | Justin Clark-Casey (justincc) | 2011-08-27 | 2 | -24/+21 |
| | | | | | stored in the root part's state field. | ||||
| * | refactor: camel case AttachmentPoint method arg as per code standards | Justin Clark-Casey (justincc) | 2011-08-27 | 1 | -4/+4 |
| | | |||||
| * | refactor: move SOP.IsAttachment and AttachmentPoint up into SOG to avoid ↵ | Justin Clark-Casey (justincc) | 2011-08-27 | 2 | -16/+15 |
| | | | | | pointless duplication of identical values | ||||
| * | refactor: simplify SOP.AttachedAvatar into SOG.AttachedAvatar | Justin Clark-Casey (justincc) | 2011-08-26 | 1 | -10/+5 |
| | | | | | This does a tiny bit to reduce code complexity, memory requirement and the cpu time of pointlessly setting this field to the same value in every SOP | ||||
| * | refactor: move SOG.DetachToGround() to ↵ | Justin Clark-Casey (justincc) | 2011-08-26 | 1 | -1/+29 |
| | | | | | AttachmentsModule.DetachSceneObjectToGround() and remove redundant code | ||||
| * | refactor: simplify DetachSingleAttachmentToGround() by retrieving the scene ↵ | Justin Clark-Casey (justincc) | 2011-08-26 | 1 | -9/+10 |
| | | | | | object group direct | ||||
| * | refactor: remove common presence set up in attachments tests | Justin Clark-Casey (justincc) | 2011-08-26 | 1 | -32/+38 |
| | | |||||
| * | comment out verbose test logging from last commit | Justin Clark-Casey (justincc) | 2011-08-26 | 1 | -1/+1 |
| | | |||||
| * | add regression test for detaching an attachment to the scene | Justin Clark-Casey (justincc) | 2011-08-26 | 1 | -0/+33 |
| | | |||||
| * | refactor: move sog.DetachToInventoryPrep() into ↵ | Justin Clark-Casey (justincc) | 2011-08-26 | 2 | -8/+19 |
| | | | | | AttachmentsModule.DetachSingleAttachmentToInv() | ||||
| * | Downgrade warning about not saving unchanged attachment to debug instead, ↵ | Justin Clark-Casey (justincc) | 2011-08-26 | 1 | -1/+4 |
| | | | | | and change text to better indicate what it's saying | ||||
| * | Fix a very recent regression from llAttachToAvatar() fix where I ↵ | Justin Clark-Casey (justincc) | 2011-08-26 | 1 | -5/+1 |
| | | | | | accidentally stopped normal script state persistence on login/logout and attach/detach | ||||
| * | Remove forcing of phantom on ground attached objects - attachments can be ↵ | Justin Clark-Casey (justincc) | 2011-08-24 | 2 | -5/+0 |
| | | | | | | | both non-phantom and flagged as physical. As per Melanie | ||||
| * | extend initial rez regression test to check that attachment is phantom | Justin Clark-Casey (justincc) | 2011-08-24 | 1 | -9/+14 |
| | | |||||
| * | Make objects attached from the ground phantom | Justin Clark-Casey (justincc) | 2011-08-24 | 2 | -2/+12 |
| | | |||||
| * | return InventoryItemBase from AddSceneObjectAsAttachment() | Justin Clark-Casey (justincc) | 2011-08-24 | 1 | -8/+4 |
| | | |||||
| * | refactor: move Scene.Inventory.attachObjectAssetStore() into ↵ | Justin Clark-Casey (justincc) | 2011-08-24 | 1 | -2/+100 |
| | | | | | AttachmentsModule.AddSceneObjectAsAttachment() | ||||
| * | refactor: remove pointless AgentId argument from attachObjectAssetStore() | Justin Clark-Casey (justincc) | 2011-08-24 | 1 | -1/+1 |
| | | |||||
| * | add TestAddAttachmentFromGround() regression test | Justin Clark-Casey (justincc) | 2011-08-24 | 2 | -2/+32 |
| | | |||||
| * | Fix llAttachToAvatar() | Justin Clark-Casey (justincc) | 2011-08-24 | 1 | -10/+25 |
| | | | | | | | Apart from one obvious bug, this was failing because attempting to serialize the script from inside the script (as part of saving the attachment as an inventory asset) was triggering an extremely long delay. So we now don't do this. The state will be serialized anyway when the avatar normally logs out. The worst that can happen is that if the client/server crashes, the attachment scripts start without previous state. | ||||
| * | rename AttachmentsModule.ShowDetachInUserInventory() to ↵ | Justin Clark-Casey (justincc) | 2011-08-23 | 2 | -7/+6 |
| | | | | | DetachSingleAttachmentToInv() for consistency and to reflect it's actual behaviour | ||||
| * | remove mono compiler warnings | Justin Clark-Casey (justincc) | 2011-08-23 | 1 | -2/+0 |
| | | |||||
| * | replace TestRemoveAttachments() with a more thorough TestRemoveAttachment() | Justin Clark-Casey (justincc) | 2011-08-23 | 1 | -51/+27 |
| | | |||||
| * | replace old TestAddAttachments() with a more thorough TestAddAttachment() | Justin Clark-Casey (justincc) | 2011-08-23 | 1 | -7/+28 |
| | | |||||
| * | If an object failed to attach due to an exception, then try and detach it ↵ | Justin Clark-Casey (justincc) | 2011-08-23 | 1 | -1/+2 |
| | | | | | | | | from the avatar's list of attachments as well as delete it from the scene. This may help with the "Inconsistent attachment state" errors seen on teleport. See http://opensimulator.org/mantis/view.php?id=5644 and linked reports | ||||
 |
index : opensim-SC_OLD | |
| My fork of OpenSim for IG and MG, called SledjChisl. |
| aboutsummaryrefslogtreecommitdiffstatshomepage |