4 files changed, 162 insertions, 106 deletions
diff --git a/OpenSim/Framework/General/Interfaces/IWorld.cs b/OpenSim/Framework/General/Interfaces/IWorld.cs
index 4857417..2edc0b4 100644
--- a/OpenSim/Framework/General/Interfaces/IWorld.cs
+++ b/OpenSim/Framework/General/Interfaces/IWorld.cs
@@ -35,7 +35,7 @@ namespace OpenSim.Framework.Interfaces
 {
    public interface IWorld
    {
-        void AddNewClient(IClientAPI remoteClient, LLUUID agentID, bool child);
+        void AddNewClient(IClientAPI client, bool child);
        void RemoveClient(LLUUID agentID);
        
        RegionInfo RegionInfo { get; }
diff --git a/OpenSim/Framework/General/OpenSim.Framework.csproj b/OpenSim/Framework/General/OpenSim.Framework.csproj
index 57076a1..7d3d53a 100644
--- a/OpenSim/Framework/General/OpenSim.Framework.csproj
+++ b/OpenSim/Framework/General/OpenSim.Framework.csproj
@@ -1,4 +1,4 @@
-<Project DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
+<Project DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
  <PropertyGroup>
    <ProjectType>Local</ProjectType>
    <ProductVersion>8.0.50727</ProductVersion>
@@ -6,8 +6,7 @@
    <ProjectGuid>{8ACA2445-0000-0000-0000-000000000000}</ProjectGuid>
    <Configuration Condition=" '$(Configuration)' == '' ">Debug</Configuration>
    <Platform Condition=" '$(Platform)' == '' ">AnyCPU</Platform>
-    <ApplicationIcon>
+    <ApplicationIcon></ApplicationIcon>
-    </ApplicationIcon>
    <AssemblyKeyContainerName>
    </AssemblyKeyContainerName>
    <AssemblyName>OpenSim.Framework</AssemblyName>
@@ -16,11 +15,9 @@
    <DefaultTargetSchema>IE50</DefaultTargetSchema>
    <DelaySign>false</DelaySign>
    <OutputType>Library</OutputType>
-    <AppDesignerFolder>
+    <AppDesignerFolder></AppDesignerFolder>
-    </AppDesignerFolder>
    <RootNamespace>OpenSim.Framework</RootNamespace>
-    <StartupObject>
+    <StartupObject></StartupObject>
-    </StartupObject>
    <FileUpgradeFlags>
    </FileUpgradeFlags>
  </PropertyGroup>
@@ -31,8 +28,7 @@
    <ConfigurationOverrideFile>
    </ConfigurationOverrideFile>
    <DefineConstants>TRACE;DEBUG</DefineConstants>
-    <DocumentationFile>
+    <DocumentationFile></DocumentationFile>
-    </DocumentationFile>
    <DebugSymbols>True</DebugSymbols>
    <FileAlignment>4096</FileAlignment>
    <Optimize>False</Optimize>
@@ -41,8 +37,7 @@
    <RemoveIntegerChecks>False</RemoveIntegerChecks>
    <TreatWarningsAsErrors>False</TreatWarningsAsErrors>
    <WarningLevel>4</WarningLevel>
-    <NoWarn>
+    <NoWarn></NoWarn>
-    </NoWarn>
  </PropertyGroup>
  <PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Release|AnyCPU' ">
    <AllowUnsafeBlocks>False</AllowUnsafeBlocks>
@@ -51,8 +46,7 @@
    <ConfigurationOverrideFile>
    </ConfigurationOverrideFile>
    <DefineConstants>TRACE</DefineConstants>
-    <DocumentationFile>
+    <DocumentationFile></DocumentationFile>
-    </DocumentationFile>
    <DebugSymbols>False</DebugSymbols>
    <FileAlignment>4096</FileAlignment>
    <Optimize>True</Optimize>
@@ -61,28 +55,26 @@
    <RemoveIntegerChecks>False</RemoveIntegerChecks>
    <TreatWarningsAsErrors>False</TreatWarningsAsErrors>
    <WarningLevel>4</WarningLevel>
-    <NoWarn>
+    <NoWarn></NoWarn>
-    </NoWarn>
  </PropertyGroup>
  <ItemGroup>
-    <Reference Include="Db4objects.Db4o.dll">
+    <Reference Include="Db4objects.Db4o.dll" >
      <HintPath>..\..\..\bin\Db4objects.Db4o.dll</HintPath>
      <Private>False</Private>
    </Reference>
-    <Reference Include="libsecondlife.dll">
+    <Reference Include="libsecondlife.dll" >
      <HintPath>..\..\..\bin\libsecondlife.dll</HintPath>
      <Private>False</Private>
    </Reference>
-    <Reference Include="System">
+    <Reference Include="System" >
      <HintPath>System.dll</HintPath>
      <Private>False</Private>
    </Reference>
-    <Reference Include="System.Data" />
+    <Reference Include="System.Xml" >
-    <Reference Include="System.Xml">
      <HintPath>System.Xml.dll</HintPath>
      <Private>False</Private>
    </Reference>
-    <Reference Include="XMLRPC.dll">
+    <Reference Include="XMLRPC.dll" >
      <HintPath>..\..\..\bin\XMLRPC.dll</HintPath>
      <Private>False</Private>
    </Reference>
@@ -92,17 +84,14 @@
      <Name>OpenSim.Framework.Console</Name>
      <Project>{A7CD0630-0000-0000-0000-000000000000}</Project>
      <Package>{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}</Package>
-      <Private>False</Private>
+                        <Private>False</Private>
    </ProjectReference>
  </ItemGroup>
  <ItemGroup>
-    <Compile Include="AuthenticateSessionBase.cs">
+    <Compile Include="AgentInventory.cs">
-      <SubType>Code</SubType>
-    </Compile>
-    <Compile Include="Remoting.cs">
      <SubType>Code</SubType>
    </Compile>
-    <Compile Include="RegionCommsListener.cs">
+    <Compile Include="AuthenticateSessionBase.cs">
      <SubType>Code</SubType>
    </Compile>
    <Compile Include="BlockingQueue.cs">
@@ -111,92 +100,97 @@
    <Compile Include="IRegionCommsListener.cs">
      <SubType>Code</SubType>
    </Compile>
-    <Compile Include="Types\UUID.cs" />
+    <Compile Include="LoginService.cs">
-    <Compile Include="Util.cs">
      <SubType>Code</SubType>
    </Compile>
-    <Compile Include="UserProfile.cs">
+    <Compile Include="RegionCommsListener.cs">
+      <SubType>Code</SubType>
+    </Compile>
+    <Compile Include="Remoting.cs">
      <SubType>Code</SubType>
    </Compile>
    <Compile Include="SimProfile.cs">
      <SubType>Code</SubType>
    </Compile>
-    <Compile Include="LoginService.cs">
+    <Compile Include="UserProfile.cs">
      <SubType>Code</SubType>
    </Compile>
-    <Compile Include="AgentInventory.cs">
+    <Compile Include="Util.cs">
      <SubType>Code</SubType>
    </Compile>
    <Compile Include="Interfaces\AuthenticateResponse.cs">
      <SubType>Code</SubType>
    </Compile>
-    <Compile Include="Interfaces\IUserServer.cs">
+    <Compile Include="Interfaces\IAssetServer.cs">
      <SubType>Code</SubType>
    </Compile>
-    <Compile Include="Interfaces\IAssetServer.cs">
+    <Compile Include="Interfaces\IClientAPI.cs">
      <SubType>Code</SubType>
    </Compile>
-    <Compile Include="Interfaces\IWorld.cs">
+    <Compile Include="Interfaces\ILocalStorage.cs">
      <SubType>Code</SubType>
    </Compile>
-    <Compile Include="Interfaces\IClientAPI.cs">
+    <Compile Include="Interfaces\IUserServer.cs">
      <SubType>Code</SubType>
    </Compile>
-    <Compile Include="Interfaces\ILocalStorage.cs">
+    <Compile Include="Interfaces\IWorld.cs">
      <SubType>Code</SubType>
    </Compile>
    <Compile Include="Interfaces\Config\IGenericConfig.cs">
      <SubType>Code</SubType>
    </Compile>
-    <Compile Include="Interfaces\Config\IUserConfig.cs">
+    <Compile Include="Interfaces\Config\IGridConfig.cs">
      <SubType>Code</SubType>
    </Compile>
-    <Compile Include="Interfaces\Config\IGridConfig.cs">
+    <Compile Include="Interfaces\Config\IUserConfig.cs">
      <SubType>Code</SubType>
    </Compile>
    <Compile Include="Properties\AssemblyInfo.cs">
      <SubType>Code</SubType>
    </Compile>
-    <Compile Include="Types\NeighbourInfo.cs">
+    <Compile Include="Types\AgentCiruitData.cs">
      <SubType>Code</SubType>
    </Compile>
-    <Compile Include="Types\NetworkServersInfo.cs">
+    <Compile Include="Types\AgentWearable.cs">
      <SubType>Code</SubType>
    </Compile>
-    <Compile Include="Types\RegionHandle.cs">
+    <Compile Include="Types\AssetBase.cs">
      <SubType>Code</SubType>
    </Compile>
-    <Compile Include="Types\RegionInfo.cs">
+    <Compile Include="Types\AssetLandmark.cs">
      <SubType>Code</SubType>
    </Compile>
-    <Compile Include="Types\ParcelData.cs">
+    <Compile Include="Types\AssetStorage.cs">
      <SubType>Code</SubType>
    </Compile>
-    <Compile Include="Types\AgentWearable.cs">
+    <Compile Include="Types\EstateSettings.cs">
      <SubType>Code</SubType>
    </Compile>
-    <Compile Include="Types\PrimData.cs">
+    <Compile Include="Types\Login.cs">
      <SubType>Code</SubType>
    </Compile>
    <Compile Include="Types\MapBlockData.cs">
      <SubType>Code</SubType>
    </Compile>
-    <Compile Include="Types\AssetStorage.cs">
+    <Compile Include="Types\NeighbourInfo.cs">
      <SubType>Code</SubType>
    </Compile>
-    <Compile Include="Types\EstateSettings.cs">
+    <Compile Include="Types\NetworkServersInfo.cs">
      <SubType>Code</SubType>
    </Compile>
-    <Compile Include="Types\AgentCiruitData.cs">
+    <Compile Include="Types\ParcelData.cs">
      <SubType>Code</SubType>
    </Compile>
-    <Compile Include="Types\Login.cs">
+    <Compile Include="Types\PrimData.cs">
      <SubType>Code</SubType>
    </Compile>
-    <Compile Include="Types\AssetLandmark.cs">
+    <Compile Include="Types\RegionHandle.cs">
      <SubType>Code</SubType>
    </Compile>
-    <Compile Include="Types\AssetBase.cs">
+    <Compile Include="Types\RegionInfo.cs">
+      <SubType>Code</SubType>
+    </Compile>
+    <Compile Include="Types\UUID.cs">
      <SubType>Code</SubType>
    </Compile>
  </ItemGroup>
@@ -207,4 +201,4 @@
    <PostBuildEvent>
    </PostBuildEvent>
  </PropertyGroup>
-</Project>
-\ No newline at end of file
+</Project>
diff --git a/OpenSim/Framework/General/OpenSim.Framework.dll.build b/OpenSim/Framework/General/OpenSim.Framework.dll.build
index 0d8077b..239e3e5 100644
--- a/OpenSim/Framework/General/OpenSim.Framework.dll.build
+++ b/OpenSim/Framework/General/OpenSim.Framework.dll.build
@@ -11,40 +11,41 @@
            <resources prefix="OpenSim.Framework" dynamicprefix="true" >
            </resources>
            <sources failonempty="true">
+                <include name="AgentInventory.cs" />
                <include name="AuthenticateSessionBase.cs" />
-                <include name="Remoting.cs" />
-                <include name="RegionCommsListener.cs" />
                <include name="BlockingQueue.cs" />
                <include name="IRegionCommsListener.cs" />
-                <include name="Util.cs" />
-                <include name="UserProfile.cs" />
-                <include name="SimProfile.cs" />
                <include name="LoginService.cs" />
-                <include name="AgentInventory.cs" />
+                <include name="RegionCommsListener.cs" />
+                <include name="Remoting.cs" />
+                <include name="SimProfile.cs" />
+                <include name="UserProfile.cs" />
+                <include name="Util.cs" />
                <include name="Interfaces/AuthenticateResponse.cs" />
-                <include name="Interfaces/IUserServer.cs" />
                <include name="Interfaces/IAssetServer.cs" />
-                <include name="Interfaces/IWorld.cs" />
                <include name="Interfaces/IClientAPI.cs" />
                <include name="Interfaces/ILocalStorage.cs" />
+                <include name="Interfaces/IUserServer.cs" />
+                <include name="Interfaces/IWorld.cs" />
                <include name="Interfaces/Config/IGenericConfig.cs" />
-                <include name="Interfaces/Config/IUserConfig.cs" />
                <include name="Interfaces/Config/IGridConfig.cs" />
+                <include name="Interfaces/Config/IUserConfig.cs" />
                <include name="Properties/AssemblyInfo.cs" />
-                <include name="Types/NeighbourInfo.cs" />
+                <include name="Types/AgentCiruitData.cs" />
-                <include name="Types/NetworkServersInfo.cs" />
-                <include name="Types/RegionHandle.cs" />
-                <include name="Types/RegionInfo.cs" />
-                <include name="Types/ParcelData.cs" />
                <include name="Types/AgentWearable.cs" />
-                <include name="Types/PrimData.cs" />
+                <include name="Types/AssetBase.cs" />
-                <include name="Types/MapBlockData.cs" />
+                <include name="Types/AssetLandmark.cs" />
                <include name="Types/AssetStorage.cs" />
                <include name="Types/EstateSettings.cs" />
-                <include name="Types/AgentCiruitData.cs" />
                <include name="Types/Login.cs" />
-                <include name="Types/AssetLandmark.cs" />
+                <include name="Types/MapBlockData.cs" />
-                <include name="Types/AssetBase.cs" />
+                <include name="Types/NeighbourInfo.cs" />
+                <include name="Types/NetworkServersInfo.cs" />
+                <include name="Types/ParcelData.cs" />
+                <include name="Types/PrimData.cs" />
+                <include name="Types/RegionHandle.cs" />
+                <include name="Types/RegionInfo.cs" />
+                <include name="Types/UUID.cs" />
            </sources>
            <references basedir="${project::get-base-directory()}">
                <lib>
diff --git a/OpenSim/Framework/General/Types/RegionInfo.cs b/OpenSim/Framework/General/Types/RegionInfo.cs
index 0fba6ca..1ead3c4 100644
--- a/OpenSim/Framework/General/Types/RegionInfo.cs
+++ b/OpenSim/Framework/General/Types/RegionInfo.cs
@@ -40,9 +40,38 @@ namespace OpenSim.Framework.Types
    {
        public LLUUID SimUUID = new LLUUID();
        public string RegionName = "";
-        public uint RegionLocX = 0;
-        public uint RegionLocY = 0;
+        private uint? m_regionLocX;
-        public ulong RegionHandle = 0;
+        public uint RegionLocX
+        {
+            get
+            {
+                return m_regionLocX.Value;
+            }
+        }
+        private uint? m_regionLocY;
+        public uint RegionLocY
+        {
+            get
+            {
+                return m_regionLocY.Value;
+            }
+        }
+        private ulong? m_regionHandle;
+        public ulong RegionHandle
+        {
+            get
+            {
+                if (!m_regionHandle.HasValue)
+                {
+                    m_regionHandle = Util.UIntsToLong((RegionLocX * 256), (RegionLocY * 256));
+                }
+                return m_regionHandle.Value;
+            }
+        }
        public string DataStore = "";
        public bool isSandbox = false;
@@ -52,19 +81,43 @@ namespace OpenSim.Framework.Types
        public string MasterAvatarLastName = "";
        public string MasterAvatarSandboxPassword = "";
+        private int? m_commsIPListenPort;
        /// <summary>
        /// Port used for listening (TCP and UDP)
        /// </summary>
        /// <remarks>Seperate TCP and UDP</remarks>
-        public int CommsIPListenPort = 0;
+        public int CommsIPListenPort
+        {
+            get
+            {
+                return m_commsIPListenPort.Value;
+            }
+        }
+        
+        private string m_commsIPListenAddr;
        /// <summary>
        /// Address used for internal listening (default: 0.0.0.0?)
        /// </summary>
-        public string CommsIPListenAddr = "";
+        public string CommsIPListenAddr        
+        {
+            get
+            {
+                return m_commsIPListenAddr;
+            }            
+        }
+        
+        private string m_commsExternalAddress;
        /// <summary>
        /// Address used for external addressing (DNS or IP)
        /// </summary>
-        public string CommsExternalAddress = "";
+        public string CommsExternalAddress
+        {
+            get
+            {
+                return m_commsExternalAddress;
+            }
+        }
        public EstateSettings estateSettings;
@@ -73,7 +126,16 @@ namespace OpenSim.Framework.Types
        {
            estateSettings = new EstateSettings();
        }
+        
+        public RegionInfo( uint regionLocX, uint regionLocY, string simIp, int simPort, string simUri ) : this()
+        {
+            m_regionLocX = regionLocX;
+            m_regionLocY = regionLocY;            
+            
+            m_commsIPListenAddr = simIp;
+            m_commsIPListenPort = simPort;
+            m_commsExternalAddress = simUri;
+        }
        public void InitConfig(bool sandboxMode, IGenericConfig configData)
        {
@@ -112,11 +174,11 @@ namespace OpenSim.Framework.Types
                {
                    string location = OpenSim.Framework.Console.MainLog.Instance.CmdPrompt("Grid Location X", "1000");
                    configData.SetAttribute("SimLocationX", location);
-                    this.RegionLocX = (uint)Convert.ToUInt32(location);
+                    m_regionLocX = (uint)Convert.ToUInt32(location);
                }
                else
                {
-                    this.RegionLocX = (uint)Convert.ToUInt32(attri);
+                    m_regionLocX = (uint)Convert.ToUInt32(attri);
                }
                // Sim/Grid location Y
                attri = "";
@@ -125,13 +187,15 @@ namespace OpenSim.Framework.Types
                {
                    string location = OpenSim.Framework.Console.MainLog.Instance.CmdPrompt("Grid Location Y", "1000");
                    configData.SetAttribute("SimLocationY", location);
-                    this.RegionLocY = (uint)Convert.ToUInt32(location);
+                    m_regionLocY = (uint)Convert.ToUInt32(location);
                }
                else
                {
-                    this.RegionLocY = (uint)Convert.ToUInt32(attri);
+                    m_regionLocY = (uint)Convert.ToUInt32(attri);
                }
+                m_regionHandle = null;
+                
                // Local storage datastore
                attri = "";
                attri = configData.GetAttribute("Datastore");
@@ -153,11 +217,11 @@ namespace OpenSim.Framework.Types
                {
                    string port = OpenSim.Framework.Console.MainLog.Instance.CmdPrompt("UDP port for client connections", "9000");
                    configData.SetAttribute("SimListenPort", port);
-                    this.CommsIPListenPort = Convert.ToInt32(port);
+                    m_commsIPListenPort = Convert.ToInt32(port);
                }
                else
                {
-                    this.CommsIPListenPort = Convert.ToInt32(attri);
+                    m_commsIPListenPort = Convert.ToInt32(attri);
                }
                //Sim Listen Address
@@ -165,8 +229,8 @@ namespace OpenSim.Framework.Types
                attri = configData.GetAttribute("SimListenAddress");
                if (attri == "")
                {
-                    this.CommsIPListenAddr = OpenSim.Framework.Console.MainLog.Instance.CmdPrompt("IP Address to listen on for client connections", "0.0.0.0");
+                    m_commsIPListenAddr = OpenSim.Framework.Console.MainLog.Instance.CmdPrompt("IP Address to listen on for client connections", "0.0.0.0");
-                    configData.SetAttribute("SimListenAddress", this.CommsIPListenAddr);
+                    configData.SetAttribute("SimListenAddress", CommsIPListenAddr );
                }
                else
                {
@@ -177,26 +241,25 @@ namespace OpenSim.Framework.Types
                        System.Net.IPAddress[] ips = System.Net.Dns.GetHostAddresses(localhostname);
                        try
                        {
-                            this.CommsIPListenAddr = "0.0.0.0"; // Incase a IPv4 address isnt found
+                            m_commsIPListenAddr = "0.0.0.0"; // Incase a IPv4 address isnt found
                            foreach (System.Net.IPAddress ip in ips)
                            {
                                if (ip.AddressFamily.ToString() == System.Net.Sockets.ProtocolFamily.InterNetwork.ToString())
                                {
-                                    this.CommsIPListenAddr = ip.ToString();
+                                    m_commsIPListenAddr = ip.ToString();
                                    break;
                                }
                            }
                        }
-                        catch (Exception e)
+                        catch (Exception)
                        {
-                            e.ToString();
+                            m_commsIPListenAddr = "0.0.0.0"; // Use the default if we fail
-                            this.CommsIPListenAddr = "0.0.0.0"; // Use the default if we fail
                        }
                    }
                    else
                    {
-                        this.CommsIPListenAddr = attri;
+                        m_commsIPListenAddr = attri;
                    }
                }
@@ -205,12 +268,12 @@ namespace OpenSim.Framework.Types
                attri = configData.GetAttribute("SimExternalAddress");
                if (attri == "")
                {
-                    this.CommsExternalAddress = OpenSim.Framework.Console.MainLog.Instance.CmdPrompt("IP or DNS address to send external clients to", "localhost");
+                    m_commsExternalAddress = OpenSim.Framework.Console.MainLog.Instance.CmdPrompt("IP or DNS address to send external clients to", "localhost");
-                    configData.SetAttribute("SimExternalAddress", this.CommsExternalAddress);
+                    configData.SetAttribute("SimExternalAddress", CommsExternalAddress);
                }
                else
                {
-                    this.CommsExternalAddress = attri;
+                    m_commsExternalAddress = attri;
                }
                attri = "";
@@ -281,8 +344,6 @@ namespace OpenSim.Framework.Types
                    }
                }
-                this.RegionHandle = Util.UIntsToLong((RegionLocX * 256), (RegionLocY * 256));
-               
                configData.Commit();
            }
            catch (Exception e)
@@ -292,13 +353,13 @@ namespace OpenSim.Framework.Types
            }
            OpenSim.Framework.Console.MainLog.Instance.Verbose("Sim settings loaded:");
-            OpenSim.Framework.Console.MainLog.Instance.Verbose( "UUID: " + this.SimUUID.ToStringHyphenated());
+            OpenSim.Framework.Console.MainLog.Instance.Verbose("UUID: " + this.SimUUID.ToStringHyphenated());
-            OpenSim.Framework.Console.MainLog.Instance.Verbose( "Name: " + this.RegionName);
+            OpenSim.Framework.Console.MainLog.Instance.Verbose("Name: " + this.RegionName);
-            OpenSim.Framework.Console.MainLog.Instance.Verbose( "Region Location: [" + this.RegionLocX.ToString() + "," + this.RegionLocY + "]");
+            OpenSim.Framework.Console.MainLog.Instance.Verbose("Region Location: [" + this.RegionLocX.ToString() + "," + this.RegionLocY + "]");
-            OpenSim.Framework.Console.MainLog.Instance.Verbose( "Region Handle: " + this.RegionHandle.ToString());
+            OpenSim.Framework.Console.MainLog.Instance.Verbose("Region Handle: " + this.RegionHandle.ToString());
-            OpenSim.Framework.Console.MainLog.Instance.Verbose( "Listening on IP: " + this.CommsIPListenAddr + ":" + this.CommsIPListenPort);
+            OpenSim.Framework.Console.MainLog.Instance.Verbose("Listening on IP: " + this.CommsIPListenAddr + ":" + this.CommsIPListenPort);
-            OpenSim.Framework.Console.MainLog.Instance.Verbose( "Sandbox Mode? " + isSandbox.ToString());
+            OpenSim.Framework.Console.MainLog.Instance.Verbose("Sandbox Mode? " + isSandbox.ToString());
-  
        }
    }
 }