Replace sit position and rotation code with older, working version

1 files changed, 28 insertions, 26 deletions

diff --git a/OpenSim/Region/ScriptEngine/Shared/Api/Implementation/LSL_Api.cs b/OpenSim/Region/ScriptEngine/Shared/Api/Implementation/LSL_Api.cs
index d2dab6f..b20ca6d 100644
--- a/OpenSim/Region/ScriptEngine/Shared/Api/Implementation/LSL_Api.cs
+++ b/OpenSim/Region/ScriptEngine/Shared/Api/Implementation/LSL_Api.cs
@@ -8015,31 +8015,37 @@ namespace OpenSim.Region.ScriptEngine.Shared.Api
 
                     switch (code)
                     {
-                        // a avatar is a child 
                         case (int)ScriptBaseClass.PRIM_POSITION:
                         case (int)ScriptBaseClass.PRIM_POS_LOCAL:
                             {
                                 if (remain < 1)
                                     return;
+
                                 LSL_Vector v;
                                 v = rules.GetVector3Item(idx++);
 
-                                if (sitpart == null)
+                                SceneObjectPart part = World.GetSceneObjectPart(av.ParentID);
+                                if (part == null)
                                     break;
 
-                                Vector3 pos = new Vector3((float)v.x, (float)v.y, (float)v.z); // requested absolute position
-
-                                if (sitpart != sitpart.ParentGroup.RootPart)
+                                LSL_Rotation localRot = ScriptBaseClass.ZERO_ROTATION;
+                                LSL_Vector localPos = ScriptBaseClass.ZERO_VECTOR;
+                                if (llGetLinkNumber() > 1)
                                 {
-                                    pos -= sitpart.OffsetPosition; // remove sit part offset
-                                    Quaternion rot = sitpart.RotationOffset;
-                                    pos *= Quaternion.Conjugate(rot); // removed sit part rotation
+                                    localRot = llGetLocalRot();
+                                    localPos = llGetLocalPos();
                                 }
-                                Vector3 sitOffset = (Zrot(av.Rotation)) * (av.Appearance.AvatarHeight * 0.02638f * 2.0f);
-                                pos += sitOffset;
 
-                                finalPos = pos;
-                                positionChanged = true;
+                                v -= localPos;
+                                v /= localRot;
+
+                                LSL_Vector sitOffset = (llRot2Up(new LSL_Rotation(av.Rotation.X, av.Rotation.Y, av.Rotation.Z, av.Rotation.W)) * av.Appearance.AvatarHeight * 0.02638f);
+
+                                v = v + 2 * sitOffset;
+
+                                av.OffsetPosition = new Vector3((float)v.x, (float)v.y, (float)v.z);
+                                av.SendAvatarDataToAllAgents();
+
                             }
                             break;
 
@@ -8048,24 +8054,20 @@ namespace OpenSim.Region.ScriptEngine.Shared.Api
                                 if (remain < 1)
                                     return;
 
-                                if (sitpart == null)
-                                    break;
-
-                                LSL_Rotation r = rules.GetQuaternionItem(idx++);
-                                Quaternion rot = new Quaternion((float)r.x, (float)r.y, (float)r.z, (float)r.s); // requested world rotation
+                                LSL_Rotation localRot = ScriptBaseClass.ZERO_ROTATION;
+                                LSL_Vector localPos = ScriptBaseClass.ZERO_VECTOR;
 
-// need to replicate SL bug
-                                SceneObjectGroup sitgrp = sitpart.ParentGroup;
-                                if (sitgrp != null && sitgrp.RootPart != sitpart)
+                                if (llGetLinkNumber() > 1)
                                 {
-                                    rot = sitgrp.RootPart.RotationOffset * rot;
+                                    localRot = llGetLocalRot();
+                                    localPos = llGetLocalPos();
                                 }
 
-                                Quaternion srot = sitpart.RotationOffset;
-                                rot = Quaternion.Conjugate(srot) * rot; // removed sit part offset rotation
-                                av.Rotation = rot;
-//                                av.SendAvatarDataToAllAgents();
-                                av.SendTerseUpdateToAllClients();
+                                LSL_Rotation r;
+                                r = rules.GetQuaternionItem(idx++);
+                                r = r * llGetRootRotation() / localRot;
+                                av.Rotation = new Quaternion((float)r.x, (float)r.y, (float)r.z, (float)r.s);
+                                av.SendAvatarDataToAllAgents();
                             }
                             break;