Mantis#3218. Thank you kindly, TLaukkan (Tommil) for a patch that:

* Added log4net dependency to physxplugin in prebuild.xml.
* Added missing m_log fields to classes.
* Replaced Console.WriteLine with appropriate m_log.Xxxx
* Tested that nant test target runs succesfully.
* Tested that local opensim sandbox starts up without errors.

2 files changed, 20 insertions, 15 deletions

diff --git a/OpenSim/Region/ScriptEngine/Shared/Api/Runtime/Executor.cs b/OpenSim/Region/ScriptEngine/Shared/Api/Runtime/Executor.cs
index d76c7c1..3a73674 100644
--- a/OpenSim/Region/ScriptEngine/Shared/Api/Runtime/Executor.cs
+++ b/OpenSim/Region/ScriptEngine/Shared/Api/Runtime/Executor.cs
@@ -31,11 +31,14 @@ using System.Reflection;
 using System.Runtime.Remoting.Lifetime;
 using OpenSim.Region.ScriptEngine.Shared;
 using OpenSim.Region.ScriptEngine.Shared.ScriptBase;
+using log4net;
 
 namespace OpenSim.Region.ScriptEngine.Shared.ScriptBase
 {
     public class Executor : MarshalByRefObject
     {
+        private static readonly ILog m_log = LogManager.GetLogger(MethodBase.GetCurrentMethod().DeclaringType);
+
         /// <summary>
         /// Contains the script to execute functions in.
         /// </summary>
@@ -92,7 +95,7 @@ namespace OpenSim.Region.ScriptEngine.Shared.ScriptBase
         /// <returns></returns>
         public override Object InitializeLifetimeService()
         {
-            //Console.WriteLine("Executor: InitializeLifetimeService()");
+            //m_log.Debug("Executor: InitializeLifetimeService()");
             //            return null;
             ILease lease = (ILease)base.InitializeLifetimeService();
 
@@ -108,7 +111,7 @@ namespace OpenSim.Region.ScriptEngine.Shared.ScriptBase
 
         public scriptEvents GetStateEventFlags(string state)
         {
-            //Console.WriteLine("Get event flags for " + state);
+            //m_log.Debug("Get event flags for " + state);
 
             // Check to see if we've already computed the flags for this state
             scriptEvents eventFlags = scriptEvents.None;
@@ -124,19 +127,19 @@ namespace OpenSim.Region.ScriptEngine.Shared.ScriptBase
             foreach (KeyValuePair<string, scriptEvents> kvp in m_eventFlagsMap)
             {
                 string evname = state + "_event_" + kvp.Key;
-                //Console.WriteLine("Trying event "+evname);
+                //m_log.Debug("Trying event "+evname);
                 try
                 {
                     MethodInfo mi = type.GetMethod(evname);
                     if (mi != null)
                     {
-                        //Console.WriteLine("Found handler for " + kvp.Key);
+                        //m_log.Debug("Found handler for " + kvp.Key);
                         eventFlags |= kvp.Value;
                     }
                 }
                 catch(Exception)
                 {
-                    //Console.WriteLine("Exeption in GetMethod:\n"+e.ToString());
+                    //m_log.Debug("Exeption in GetMethod:\n"+e.ToString());
                 }
             }
 
@@ -144,7 +147,7 @@ namespace OpenSim.Region.ScriptEngine.Shared.ScriptBase
             if (eventFlags != 0)
                 m_stateEvents.Add(state, eventFlags);
 
-            //Console.WriteLine("Returning {0:x}", eventFlags);
+            //m_log.Debug("Returning {0:x}", eventFlags);
             return (eventFlags);
         }
 
@@ -156,7 +159,7 @@ namespace OpenSim.Region.ScriptEngine.Shared.ScriptBase
             string EventName = state + "_event_" + FunctionName;
 
 //#if DEBUG
-            //Console.WriteLine("ScriptEngine: Script event function name: " + EventName);
+            //m_log.Debug("ScriptEngine: Script event function name: " + EventName);
 //#endif
 
             if (Events.ContainsKey(EventName) == false)
@@ -170,7 +173,7 @@ namespace OpenSim.Region.ScriptEngine.Shared.ScriptBase
                 }
                 catch
                 {
-                    Console.WriteLine("Event {0}not found", EventName);
+                    m_log.Error("Event "+EventName+" not found.");
                     // Event name not found, cache it as not found
                     Events.Add(EventName, null);
                 }
@@ -182,13 +185,13 @@ namespace OpenSim.Region.ScriptEngine.Shared.ScriptBase
 
             if (ev == null) // No event by that name!
             {
-                //Console.WriteLine("ScriptEngine Can not find any event named: \String.Empty + EventName + "\String.Empty);
+                //m_log.Debug("ScriptEngine Can not find any event named: \String.Empty + EventName + "\String.Empty);
                 return;
             }
 
 //cfk 2-7-08 dont need this right now and the default Linux build has DEBUG defined
 #if DEBUG
-            //Console.WriteLine("ScriptEngine: Executing function name: " + EventName);
+            //m_log.Debug("ScriptEngine: Executing function name: " + EventName);
 #endif
             // Found
             try
diff --git a/OpenSim/Region/ScriptEngine/Shared/Api/Runtime/YieldProlog/YP.cs b/OpenSim/Region/ScriptEngine/Shared/Api/Runtime/YieldProlog/YP.cs
index 5a9b0aa..9cdffaa 100644
--- a/OpenSim/Region/ScriptEngine/Shared/Api/Runtime/YieldProlog/YP.cs
+++ b/OpenSim/Region/ScriptEngine/Shared/Api/Runtime/YieldProlog/YP.cs
@@ -36,6 +36,7 @@ using System.Reflection;
 using System.Net.Sockets;
 using System.Text;
 using System.Text.RegularExpressions;
+using log4net;
 
 namespace OpenSim.Region.ScriptEngine.Shared.YieldProlog
 {
@@ -45,6 +46,7 @@ namespace OpenSim.Region.ScriptEngine.Shared.YieldProlog
     /// </summary>
     public class YP
     {
+        private static readonly ILog m_log = LogManager.GetLogger(MethodBase.GetCurrentMethod().DeclaringType);
         private static Fail _fail = new Fail();
         private static Repeat _repeat = new Repeat();
         private static Dictionary<NameArity, List<IClause>> _predicatesStore =
@@ -2341,7 +2343,7 @@ namespace OpenSim.Region.ScriptEngine.Shared.YieldProlog
             string results = "";
             for (Match m = Regex.Match(inData,inPattern); m.Success; m=m.NextMatch())
             {
-                //Console.WriteLine( m );
+                //m_log.Debug( m );
                 results += presep+ m + postsep;
             }
             return results;
@@ -2359,7 +2361,7 @@ namespace OpenSim.Region.ScriptEngine.Shared.YieldProlog
             }
             catch
             {
-                Console.WriteLine("Failed to connect to server at {0}:999", "localhost");
+                m_log.Error("Failed to connect to server at localhost:999");
                 return "";
             }
 
@@ -2379,16 +2381,16 @@ namespace OpenSim.Region.ScriptEngine.Shared.YieldProlog
                     streamWriter.Flush();
 
                     cycOutputString = streamReader.ReadLine();
-                    Console.WriteLine("Cycoutput:" + cycOutputString);
+                    m_log.Debug("Cycoutput:" + cycOutputString);
                     //streamWriter.WriteLine("Client Message");
-                    //Console.WriteLine("Client Message");
+                    //m_log.Debug("Client Message");
                     streamWriter.Flush();
                 }
 
             }
             catch
             {
-                Console.WriteLine("Exception reading from Server");
+                m_log.Error("Exception reading from Server");
                 return "";
             }
             // tidy up