diff options
| author | Justin Clark-Casey (justincc) | 2011-11-15 15:57:53 +0000 |
|---|---|---|
| committer | Justin Clark-Casey (justincc) | 2011-11-15 15:57:53 +0000 |
| commit | 50803dfe2ca8818f438d740e788762e1faf1078c (patch) | |
| tree | 17b06e2666f45748399539994d41d4c400f2e09f /OpenSim/Region/CoreModules/World/Permissions/PermissionsModule.cs | |
| parent | refactor: Don't create a new UUID for passing uuids to client - UUIDs are str... (diff) | |
| download | opensim-SC_OLD-50803dfe2ca8818f438d740e788762e1faf1078c.zip opensim-SC_OLD-50803dfe2ca8818f438d740e788762e1faf1078c.tar.gz opensim-SC_OLD-50803dfe2ca8818f438d740e788762e1faf1078c.tar.bz2 opensim-SC_OLD-50803dfe2ca8818f438d740e788762e1faf1078c.tar.xz | |
For clients that are entering a simulator from initial login, stop executing FriendsModule.FetchFriendslist() asychronously.
Executing this asynchronously allows a race condition where subsequent friends fetches hit a cache that FetchFriendsList() had not yet populated.
Changing this to synchronous may improve issues where a user does not see friends as online even though they are.
I don't believe synchronous is a problem here, but if it is, then a more complicated signalling mechanism is required. Locking the cache isn't sufficient.
Diffstat (limited to 'OpenSim/Region/CoreModules/World/Permissions/PermissionsModule.cs')
| -rw-r--r-- | OpenSim/Region/CoreModules/World/Permissions/PermissionsModule.cs | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/OpenSim/Region/CoreModules/World/Permissions/PermissionsModule.cs b/OpenSim/Region/CoreModules/World/Permissions/PermissionsModule.cs index 3b661ed..f416f06 100644 --- a/OpenSim/Region/CoreModules/World/Permissions/PermissionsModule.cs +++ b/OpenSim/Region/CoreModules/World/Permissions/PermissionsModule.cs | |||
| @@ -479,8 +479,7 @@ namespace OpenSim.Region.CoreModules.World.Permissions | |||
| 479 | } | 479 | } |
| 480 | 480 | ||
| 481 | protected bool IsFriendWithPerms(UUID user,UUID objectOwner) | 481 | protected bool IsFriendWithPerms(UUID user,UUID objectOwner) |
| 482 | { | 482 | { |
| 483 | |||
| 484 | if (user == UUID.Zero) | 483 | if (user == UUID.Zero) |
| 485 | return false; | 484 | return false; |
| 486 | 485 | ||