refactor: Stop passing both IClientAPI and agentID to friend event listeners, these are redundant. Replace a few magic numbers with FriendRights enum already used elsewhere.

1 files changed, 28 insertions, 0 deletions

diff --git a/OpenSim/Region/CoreModules/Avatar/Friends/Tests/FriendModuleTests.cs b/OpenSim/Region/CoreModules/Avatar/Friends/Tests/FriendModuleTests.cs
index 34c68cc..94a78cb 100644
--- a/OpenSim/Region/CoreModules/Avatar/Friends/Tests/FriendModuleTests.cs
+++ b/OpenSim/Region/CoreModules/Avatar/Friends/Tests/FriendModuleTests.cs
@@ -120,6 +120,34 @@ namespace OpenSim.Region.CoreModules.Avatar.Friends.Tests
             Assert.That(((TestClient)sp1Redux.ControllingClient).ReceivedOnlineNotifications.Count, Is.EqualTo(0));
         }
 
+//        [Test]
+//        public void TestLoginWithOnlineFriends()
+//        {
+//            TestHelpers.InMethod();
+//            log4net.Config.XmlConfigurator.Configure();
+//
+//            UUID user1Id = TestHelpers.ParseTail(0x1);
+//            UUID user2Id = TestHelpers.ParseTail(0x2);
+//
+////            UserAccountHelpers.CreateUserWithInventory(m_scene, user1Id);
+////            UserAccountHelpers.CreateUserWithInventory(m_scene, user2Id);
+////
+////            m_fm.AddFriendship(user1Id, user2Id);
+//
+//            ScenePresence sp1 = SceneHelpers.AddScenePresence(m_scene, user1Id);
+//            SceneHelpers.AddScenePresence(m_scene, user2Id);
+//
+//            m_fm.AddFriendship(sp1.ControllingClient, user2Id);
+////            m_fm.LocalGrantRights
+//
+//            m_scene.RemoveClient(sp1.UUID, true);
+//
+//            ScenePresence sp1Redux = SceneHelpers.AddScenePresence(m_scene, user1Id);
+//
+//            Assert.That(((TestClient)sp1Redux.ControllingClient).ReceivedOfflineNotifications.Count, Is.EqualTo(0));
+//            Assert.That(((TestClient)sp1Redux.ControllingClient).ReceivedOnlineNotifications.Count, Is.EqualTo(1));
+//        }
+
         [Test]
         public void TestAddFriendshipWhileOnline()
         {