diff options
| author | Justin Clark-Casey (justincc) | 2015-05-12 19:54:25 +0100 |
|---|---|---|
| committer | Justin Clark-Casey (justincc) | 2015-05-12 19:54:25 +0100 |
| commit | d52f58a7339aba40035f9bcc1f5b26232c714c48 (patch) | |
| tree | a173ce3b4779091c7827207944b9cedde8159665 /OpenSim/Framework | |
| parent | One more test in UserAccountsClient. (diff) | |
| download | opensim-SC_OLD-d52f58a7339aba40035f9bcc1f5b26232c714c48.zip opensim-SC_OLD-d52f58a7339aba40035f9bcc1f5b26232c714c48.tar.gz opensim-SC_OLD-d52f58a7339aba40035f9bcc1f5b26232c714c48.tar.bz2 opensim-SC_OLD-d52f58a7339aba40035f9bcc1f5b26232c714c48.tar.xz | |
Disable the "show threadpool calls active" console command for now.
Whilst this can be very useful to identify threads held too long by incoming packet processing,
it can also be very misleading as the count updates are not atomic (race conditions lead to growth in numbers over time).
This could be solved by making the counts volatile but I don't currently have time to assess the performance impact, though it's almost certainly negligible.
If anybody else wants to do that and re-enable this command then please feel free.
Diffstat (limited to 'OpenSim/Framework')
| -rw-r--r-- | OpenSim/Framework/Servers/ServerBase.cs | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/OpenSim/Framework/Servers/ServerBase.cs b/OpenSim/Framework/Servers/ServerBase.cs index c22c119..e403ba0 100644 --- a/OpenSim/Framework/Servers/ServerBase.cs +++ b/OpenSim/Framework/Servers/ServerBase.cs | |||
| @@ -292,11 +292,11 @@ namespace OpenSim.Framework.Servers | |||
| 292 | + " 3 = full stack trace, including common threads\n", | 292 | + " 3 = full stack trace, including common threads\n", |
| 293 | HandleDebugThreadpoolLevel); | 293 | HandleDebugThreadpoolLevel); |
| 294 | 294 | ||
| 295 | m_console.Commands.AddCommand( | 295 | // m_console.Commands.AddCommand( |
| 296 | "Debug", false, "show threadpool calls active", | 296 | // "Debug", false, "show threadpool calls active", |
| 297 | "show threadpool calls active", | 297 | // "show threadpool calls active", |
| 298 | "Show details about threadpool calls that are still active (currently waiting or in progress)", | 298 | // "Show details about threadpool calls that are still active (currently waiting or in progress)", |
| 299 | HandleShowThreadpoolCallsActive); | 299 | // HandleShowThreadpoolCallsActive); |
| 300 | 300 | ||
| 301 | m_console.Commands.AddCommand( | 301 | m_console.Commands.AddCommand( |
| 302 | "Debug", false, "show threadpool calls complete", | 302 | "Debug", false, "show threadpool calls complete", |