5 files changed, 361 insertions, 88 deletions

diff --git a/OpenSim/Services/Connectors/Asset/AssetServicesConnector.cs b/OpenSim/Services/Connectors/Asset/AssetServicesConnector.cs
index 7ac7917..99119d3 100644
--- a/OpenSim/Services/Connectors/Asset/AssetServicesConnector.cs
+++ b/OpenSim/Services/Connectors/Asset/AssetServicesConnector.cs
@@ -46,10 +46,13 @@ namespace OpenSim.Services.Connectors
                 LogManager.GetLogger(
                 MethodBase.GetCurrentMethod().DeclaringType);
 
+        const int MAXSENDRETRIESLEN = 30;
+
         private string m_ServerURI = String.Empty;
         private IImprovedAssetCache m_Cache = null;
         private int m_retryCounter;
-        private Dictionary<int, List<AssetBase>> m_retryQueue = new Dictionary<int, List<AssetBase>>();
+        private bool m_inRetries;
+        private List<AssetBase>[] m_sendRetries = new  List<AssetBase>[MAXSENDRETRIESLEN];
         private System.Timers.Timer m_retryTimer;
         private int m_maxAssetRequestConcurrency = 30;
         
@@ -110,9 +113,9 @@ namespace OpenSim.Services.Connectors
                 throw new Exception("Asset connector init error");
             }
 
-
             m_retryTimer = new System.Timers.Timer();
             m_retryTimer.Elapsed += new ElapsedEventHandler(retryCheck);
+            m_retryTimer.AutoReset = true;
             m_retryTimer.Interval = 60000;
 
             Uri serverUri = new Uri(m_ServerURI);
@@ -166,48 +169,67 @@ namespace OpenSim.Services.Connectors
 
         protected void retryCheck(object source, ElapsedEventArgs e)
         {
-            m_retryCounter++;
-            if (m_retryCounter > 60)
-                m_retryCounter -= 60;
-
-            List<int> keys = new List<int>();
-            foreach (int a in m_retryQueue.Keys)
+            lock(m_sendRetries)
             {
-                keys.Add(a);
+                if(m_inRetries)
+                    return;
+                m_inRetries = true;
             }
-            foreach (int a in keys)
+
+            m_retryCounter++;
+            if(m_retryCounter >= 61 ) // avoid overflow 60 is max in use below
+                m_retryCounter = 1;
+
+            int inUse = 0; 
+            int nextlevel;
+            int timefactor; 
+            List<AssetBase> retrylist;
+            // we need to go down            
+            for(int i = MAXSENDRETRIESLEN - 1; i >= 0; i--)
             {
+                lock(m_sendRetries)
+                    retrylist = m_sendRetries[i];
+
+                if(retrylist == null)
+                    continue;
+
+                inUse++;
+                nextlevel = i + 1;
+
                 //We exponentially fall back on frequency until we reach one attempt per hour
                 //The net result is that we end up in the queue for roughly 24 hours..
                 //24 hours worth of assets could be a lot, so the hope is that the region admin
                 //will have gotten the asset connector back online quickly!
-
-                int timefactor = a ^ 2; 
-                if (timefactor > 60)
+                if(i == 0)
+                    timefactor = 1;
+                else
                 {
-                    timefactor = 60;
+                    timefactor = 1 << nextlevel;
+                    if (timefactor > 60)
+                        timefactor = 60;
                 }
 
-                //First, find out if we care about this timefactor
-                if (timefactor % a == 0)
-                {
-                    //Yes, we do!   
-                    List<AssetBase> retrylist = m_retryQueue[a];
-                    m_retryQueue.Remove(a);
+                if(m_retryCounter < timefactor)
+                    continue; // to update inUse;
 
-                    foreach(AssetBase ass in retrylist)
-                    {
-                        Store(ass); //Store my ass. This function will put it back in the dictionary if it fails
-                    }
-                }
+                if (m_retryCounter % timefactor != 0)
+                    continue;
+
+                // a list to retry
+                lock(m_sendRetries)
+                    m_sendRetries[i] = null;
+
+                // we are the only ones with a copy of this retrylist now                
+                foreach(AssetBase ass in retrylist)
+                   retryStore(ass, nextlevel);
             }
 
-            if (m_retryQueue.Count == 0)
-            {
-                //It might only be one tick per minute, but I have
-                //repented and abandoned my wasteful ways
-                m_retryCounter = 0;
-                m_retryTimer.Stop();
+            lock(m_sendRetries)
+            {          
+                if(inUse == 0 )
+                    m_retryTimer.Stop();
+
+                m_inRetries = false;
             }
         }
 
@@ -237,8 +259,9 @@ namespace OpenSim.Services.Connectors
 
                 asset = SynchronousRestObjectRequester.MakeRequest<int, AssetBase>("GET", uri, 0, m_Auth);
 
-                if (m_Cache != null)
-                    m_Cache.Cache(asset);
+ 
+                if (asset != null && m_Cache != null)
+                   m_Cache.Cache(asset);
             }
             return asset;
         }
@@ -340,25 +363,18 @@ namespace OpenSim.Services.Connectors
                             m_AssetHandlers.Remove(id);
                         }
 
-                        Util.FireAndForget(x =>
+                        if(handlers != null)
+                        {
+                            Util.FireAndForget(x =>
                             {
-
                                 foreach (AssetRetrievedEx h in handlers)
                                 {
-                                    // Util.FireAndForget(x =>
-                                    // {
                                     try { h.Invoke(a); }
                                     catch { }
-                                    // });
                                 }
-
-                                if (handlers != null)
-                                    handlers.Clear();
-
+                                handlers.Clear();
                             });
-
-//                        if (handlers != null)
-//                            handlers.Clear();
+                        }
                         success = true;
                     }
                 }
@@ -393,29 +409,24 @@ namespace OpenSim.Services.Connectors
                 {
                     AssetRetrievedEx handlerEx = new AssetRetrievedEx(delegate(AssetBase _asset) { handler(id, sender, _asset); });
 
-//                    AssetRetrievedEx handlers;
                     List<AssetRetrievedEx> handlers;
                     if (m_AssetHandlers.TryGetValue(id, out handlers))
                     {
                         // Someone else is already loading this asset. It will notify our handler when done.
-//                        handlers += handlerEx;
                         handlers.Add(handlerEx);
                         return true;
                     }
 
-                    // Load the asset ourselves
-//                    handlers += handlerEx;
                     handlers = new List<AssetRetrievedEx>();
                     handlers.Add(handlerEx);
 
                     m_AssetHandlers.Add(id, handlers);
-                }
-
-                QueuedAssetRequest request = new QueuedAssetRequest();
-                request.id = id;
-                request.uri = uri;
 
-                m_requestQueue.Enqueue(request);
+                    QueuedAssetRequest request = new QueuedAssetRequest();
+                    request.id = id;
+                    request.uri = uri;
+                    m_requestQueue.Enqueue(request);
+                }
             }
             else
             {
@@ -495,43 +506,34 @@ namespace OpenSim.Services.Connectors
                 newID = SynchronousRestObjectRequester.
                         MakeRequest<AssetBase, string>("POST", uri, asset, 100000, m_Auth);
             }
-            catch {}
+            catch
+            {
+                newID = null;
+            }
 
             if (newID == null || newID == String.Empty || newID == stringUUIDZero)
             {
-                //The asset upload failed, put it in a queue for later
-                asset.UploadAttempts++;
-                if (asset.UploadAttempts > 30)
+                //The asset upload failed, try later
+                lock(m_sendRetries)
                 {
-                    //By this stage we've been in the queue for a good few hours;
-                    //We're going to drop the asset.
-                    m_log.ErrorFormat("[Assets] Dropping asset {0} - Upload has been in the queue for too long.", asset.ID.ToString());
-                }
-                else
-                {
-                    if (!m_retryQueue.ContainsKey(asset.UploadAttempts))
-                    {
-                        m_retryQueue.Add(asset.UploadAttempts, new List<AssetBase>());
-                    }
-                    List<AssetBase> m_queue = m_retryQueue[asset.UploadAttempts];
+                    if (m_sendRetries[0] == null)
+                        m_sendRetries[0] = new List<AssetBase>();
+                    List<AssetBase> m_queue = m_sendRetries[0];
                     m_queue.Add(asset);
-                    m_log.WarnFormat("[Assets] Upload failed: {0} - Requeuing asset for another run.", asset.ID.ToString());
+                    m_log.WarnFormat("[Assets] Upload failed: {0} type {1} will retry later",
+                            asset.ID.ToString(), asset.Type.ToString());
                     m_retryTimer.Start();
                 }
             }
             else
             {
-                if (asset.UploadAttempts > 0)
-                {
-                    m_log.InfoFormat("[Assets] Upload of {0} succeeded after {1} failed attempts", asset.ID.ToString(), asset.UploadAttempts.ToString());
-                }
                 if (newID != asset.ID)
                 {
                     // Placing this here, so that this work with old asset servers that don't send any reply back
                     // SynchronousRestObjectRequester returns somethins that is not an empty string
 
                     asset.ID = newID;
-// what about FullID ????
+
                     if (m_Cache != null)
                         m_Cache.Cache(asset);
                 }
@@ -539,6 +541,62 @@ namespace OpenSim.Services.Connectors
             return asset.ID;
         }
 
+        public void retryStore(AssetBase asset, int nextRetryLevel)
+        {
+/* this may be bad, so excluding
+            if (m_Cache != null && !m_Cache.Check(asset.ID))
+            {
+                m_log.WarnFormat("[Assets] Upload giveup asset bc no longer in local cache: {0}",
+                    asset.ID.ToString();
+                return; // if no longer in cache, it was deleted or expired
+            }
+*/
+            string uri = MapServer(asset.FullID.ToString()) + "/assets/";
+
+            string newID = null;
+            try
+            {
+                newID = SynchronousRestObjectRequester.
+                        MakeRequest<AssetBase, string>("POST", uri, asset, 100000, m_Auth);
+            }
+            catch
+            {
+                newID = null;
+            }
+
+            if (newID == null || newID == String.Empty || newID == stringUUIDZero)
+            {
+                if(nextRetryLevel >= MAXSENDRETRIESLEN)
+                    m_log.WarnFormat("[Assets] Upload giveup after several retries id: {0} type {1}",
+                            asset.ID.ToString(), asset.Type.ToString());
+                else                
+                {
+                    lock(m_sendRetries)
+                    {
+                        if (m_sendRetries[nextRetryLevel] == null)
+                        {
+                            m_sendRetries[nextRetryLevel] = new List<AssetBase>();
+                        }
+                        List<AssetBase> m_queue = m_sendRetries[nextRetryLevel];
+                        m_queue.Add(asset);
+                    m_log.WarnFormat("[Assets] Upload failed: {0} type {1} will retry later",
+                            asset.ID.ToString(), asset.Type.ToString());
+                    }
+                }
+            }
+            else
+            {
+                m_log.InfoFormat("[Assets] Upload of {0} succeeded after {1} failed attempts", asset.ID.ToString(), nextRetryLevel.ToString());
+                if (newID != asset.ID)
+                {
+                     asset.ID = newID;
+
+                    if (m_Cache != null)
+                        m_Cache.Cache(asset);
+                }
+            }
+        }
+
         public bool UpdateContent(string id, byte[] data)
         {
             AssetBase asset = null;
@@ -569,6 +627,7 @@ namespace OpenSim.Services.Connectors
             return false;
         }
 
+
         public bool Delete(string id)
         {
             string uri = MapServer(id) + "/assets/" + id;
diff --git a/OpenSim/Services/Connectors/Hypergrid/GatekeeperServiceConnector.cs b/OpenSim/Services/Connectors/Hypergrid/GatekeeperServiceConnector.cs
index 2340998..aad3bd2 100644
--- a/OpenSim/Services/Connectors/Hypergrid/GatekeeperServiceConnector.cs
+++ b/OpenSim/Services/Connectors/Hypergrid/GatekeeperServiceConnector.cs
@@ -159,8 +159,7 @@ namespace OpenSim.Services.Connectors.Hypergrid
             string filename = string.Empty;
 
             try
-            {
-                WebClient c = new WebClient();
+            {               
                 //m_log.Debug("JPEG: " + imageURL);
                 string name = regionID.ToString();
                 filename = Path.Combine(storagePath, name + ".jpg");
@@ -168,7 +167,8 @@ namespace OpenSim.Services.Connectors.Hypergrid
                 if (!File.Exists(filename))
                 {
                     m_log.DebugFormat("[GATEKEEPER SERVICE CONNECTOR]: downloading...");
-                    c.DownloadFile(imageURL, filename);
+                    using(WebClient c = new WebClient())
+                        c.DownloadFile(imageURL, filename);
                 }
                 else
                 {
diff --git a/OpenSim/Services/Connectors/Simulation/SimulationServiceConnector.cs b/OpenSim/Services/Connectors/Simulation/SimulationServiceConnector.cs
index 3a0d197..8e1bf37 100644
--- a/OpenSim/Services/Connectors/Simulation/SimulationServiceConnector.cs
+++ b/OpenSim/Services/Connectors/Simulation/SimulationServiceConnector.cs
@@ -106,17 +106,18 @@ namespace OpenSim.Services.Connectors.Simulation
 
         public bool CreateAgent(GridRegion source, GridRegion destination, AgentCircuitData aCircuit, uint flags, EntityTransferContext ctx, out string myipaddress, out string reason)
         {
-            m_log.DebugFormat("[REMOTE SIMULATION CONNECTOR]: Creating agent at {0}", destination.ServerURI);
             reason = String.Empty;
             myipaddress = String.Empty;
 
             if (destination == null)
             {
                 reason = "Destination not found";
-                m_log.Debug("[REMOTE SIMULATION CONNECTOR]: Given destination is null");
+                m_log.Debug("[REMOTE SIMULATION CONNECTOR]: Create agent destination is null");
                 return false;
             }
 
+            m_log.DebugFormat("[REMOTE SIMULATION CONNECTOR]: Creating agent at {0}", destination.ServerURI);
+
             string uri = destination.ServerURI + AgentPath() + aCircuit.AgentID + "/";
             
             try
diff --git a/OpenSim/Services/LLLoginService/LLLoginService.cs b/OpenSim/Services/LLLoginService/LLLoginService.cs
index 6681f1a..92b3137 100644
--- a/OpenSim/Services/LLLoginService/LLLoginService.cs
+++ b/OpenSim/Services/LLLoginService/LLLoginService.cs
@@ -512,8 +512,8 @@ namespace OpenSim.Services.LLLoginService
                 //
                 if (m_MessageUrl != String.Empty)
                 {
-                    WebClient client = new WebClient();
-                    processedMessage = client.DownloadString(m_MessageUrl);
+                    using(WebClient client = new WebClient())
+                        processedMessage = client.DownloadString(m_MessageUrl);
                 }
                 else
                 {
diff --git a/OpenSim/Services/UserAccountService/UserAccountService.cs b/OpenSim/Services/UserAccountService/UserAccountService.cs
index 668fe53..706d475 100644
--- a/OpenSim/Services/UserAccountService/UserAccountService.cs
+++ b/OpenSim/Services/UserAccountService/UserAccountService.cs
@@ -92,7 +92,7 @@ namespace OpenSim.Services.UserAccountService
                 m_RootInstance = this;
                 MainConsole.Instance.Commands.AddCommand("Users", false,
                         "create user",
-                        "create user [<first> [<last> [<pass> [<email> [<user id>]]]]]",
+                        "create user [<first> [<last> [<pass> [<email> [<user id> [<model>]]]]]]",
                         "Create a new user", HandleCreateUser);
 
                 MainConsole.Instance.Commands.AddCommand("Users", false,
@@ -353,7 +353,7 @@ namespace OpenSim.Services.UserAccountService
         /// <summary>
         /// Handle the create user command from the console.
         /// </summary>
-        /// <param name="cmdparams">string array with parameters: firstname, lastname, password, locationX, locationY, email</param>
+        /// <param name="cmdparams">string array with parameters: firstname, lastname, password, locationX, locationY, email, userID, model name </param>
         protected void HandleCreateUser(string module, string[] cmdparams)
         {
             string firstName;
@@ -361,6 +361,7 @@ namespace OpenSim.Services.UserAccountService
             string password;
             string email;
             string rawPrincipalId;
+            string model;
 
             List<char> excluded = new List<char>(new char[]{' '});
 
@@ -385,11 +386,16 @@ namespace OpenSim.Services.UserAccountService
             else
                 rawPrincipalId = cmdparams[6];
 
+            if (cmdparams.Length < 8)
+                model = MainConsole.Instance.CmdPrompt("Model name","");
+            else
+                model = cmdparams[7];
+
             UUID principalId = UUID.Zero;
             if (!UUID.TryParse(rawPrincipalId, out principalId))
                 throw new Exception(string.Format("ID {0} is not a valid UUID", rawPrincipalId));
 
-            CreateUser(UUID.Zero, principalId, firstName, lastName, password, email);
+            CreateUser(UUID.Zero, principalId, firstName, lastName, password, email, model);
         }
 
         protected void HandleShowAccount(string module, string[] cmdparams)
@@ -544,7 +550,8 @@ namespace OpenSim.Services.UserAccountService
         /// <param name="lastName"></param>
         /// <param name="password"></param>
         /// <param name="email"></param>
-        public UserAccount CreateUser(UUID scopeID, UUID principalID, string firstName, string lastName, string password, string email)
+        /// <param name="model"></param>
+        public UserAccount CreateUser(UUID scopeID, UUID principalID, string firstName, string lastName, string password, string email, string model = "")
         {
             UserAccount account = GetUserAccount(UUID.Zero, firstName, lastName);
             if (null == account)
@@ -603,7 +610,12 @@ namespace OpenSim.Services.UserAccountService
                         }
 
                         if (m_CreateDefaultAvatarEntries)
-                            CreateDefaultAppearanceEntries(account.PrincipalID);
+                        {
+                            if (String.IsNullOrEmpty(model))
+                                CreateDefaultAppearanceEntries(account.PrincipalID);
+                            else
+                                EstablishAppearance(account.PrincipalID, model);
+                        }
                     }
 
                     m_log.InfoFormat(
@@ -734,6 +746,7 @@ namespace OpenSim.Services.UserAccountService
                 wearables[AvatarWearable.PANTS] = new AvatarWearable(pants.ID, pants.AssetID);
 
                 AvatarAppearance ap = new AvatarAppearance();
+                // this loop works, but is questionable
                 for (int i = 0; i < 6; i++)
                 {
                     ap.SetWearable(i, wearables[i]);
@@ -742,5 +755,205 @@ namespace OpenSim.Services.UserAccountService
                 m_AvatarService.SetAppearance(principalID, ap);
             }
         }
+
+        protected void EstablishAppearance(UUID destinationAgent, string model)
+        {
+            m_log.DebugFormat("[USER ACCOUNT SERVICE]: Establishing new appearance for {0} - {1}",
+                              destinationAgent.ToString(), model);
+
+            string[] modelSpecifiers = model.Split();
+            if (modelSpecifiers.Length != 2)
+            {
+                m_log.WarnFormat("[USER ACCOUNT SERVICE]: Invalid model name \'{0}\'. Falling back to Ruth for {1}", 
+                                 model, destinationAgent);
+                CreateDefaultAppearanceEntries(destinationAgent);
+                return;
+            }
+
+            // Does the source model exist?
+            UserAccount modelAccount = GetUserAccount(UUID.Zero, modelSpecifiers[0], modelSpecifiers[1]);
+            if (modelAccount == null)
+            {
+                m_log.WarnFormat("[USER ACCOUNT SERVICE]: Requested model \'{0}\' not found. Falling back to Ruth for {1}", 
+                                 model, destinationAgent);
+                CreateDefaultAppearanceEntries(destinationAgent);
+                return;
+            }
+
+            // Does the source model have an established appearance herself?
+            AvatarAppearance modelAppearance = m_AvatarService.GetAppearance(modelAccount.PrincipalID);
+            if (modelAppearance == null)
+            {
+                m_log.WarnFormat("USER ACCOUNT SERVICE]: Requested model \'{0}\' does not have an established appearance. Falling back to Ruth for {1}",
+                                 model, destinationAgent);
+                CreateDefaultAppearanceEntries(destinationAgent);
+                return;
+            }
+
+            try
+            {
+                CopyWearablesAndAttachments(destinationAgent, modelAccount.PrincipalID, modelAppearance);
+
+                m_AvatarService.SetAppearance(destinationAgent, modelAppearance);
+            }
+            catch (Exception e)
+            {
+                m_log.WarnFormat("[USER ACCOUNT SERVICE]: Error transferring appearance for {0} : {1}",
+                    destinationAgent, e.Message);
+            }
+
+            m_log.DebugFormat("[USER ACCOUNT SERVICE]: Finished establishing appearance for {0}",
+                destinationAgent.ToString());
+        }
+
+        /// <summary>
+        /// This method is called by EstablishAppearance to do a copy all inventory items
+        /// worn or attached to the Clothing inventory folder of the receiving avatar.
+        /// In parallel the avatar wearables and attachments are updated.
+        /// </summary>
+        private void CopyWearablesAndAttachments(UUID destination, UUID source, AvatarAppearance avatarAppearance)
+        {
+            // Get Clothing folder of receiver
+            InventoryFolderBase destinationFolder = m_InventoryService.GetFolderForType(destination, FolderType.Clothing);
+
+            if (destinationFolder == null)
+                throw new Exception("Cannot locate folder(s)");
+
+            // Missing destination folder? This should *never* be the case
+            if (destinationFolder.Type != (short)FolderType.Clothing)
+            {
+                destinationFolder = new InventoryFolderBase();
+
+                destinationFolder.ID       = UUID.Random();
+                destinationFolder.Name     = "Clothing";
+                destinationFolder.Owner    = destination;
+                destinationFolder.Type     = (short)AssetType.Clothing;
+                destinationFolder.ParentID = m_InventoryService.GetRootFolder(destination).ID;
+                destinationFolder.Version  = 1;
+                m_InventoryService.AddFolder(destinationFolder);     // store base record
+                m_log.ErrorFormat("[USER ACCOUNT SERVICE]: Created folder for destination {0}", source);
+            }
+
+            // Wearables
+            AvatarWearable[] wearables = avatarAppearance.Wearables;
+            AvatarWearable wearable;
+
+            for (int i = 0; i < wearables.Length; i++)
+            {
+                wearable = wearables[i];
+                if (wearable[0].ItemID != UUID.Zero)
+                {
+                    // Get inventory item and copy it
+                    InventoryItemBase item = m_InventoryService.GetItem(source, wearable[0].ItemID);
+
+                    if (item != null)
+                    {
+                        InventoryItemBase destinationItem = new InventoryItemBase(UUID.Random(), destination);
+                        destinationItem.Name = item.Name;
+                        destinationItem.Owner = destination;
+                        destinationItem.Description = item.Description;
+                        destinationItem.InvType = item.InvType;
+                        destinationItem.CreatorId = item.CreatorId;
+                        destinationItem.CreatorData = item.CreatorData;
+                        destinationItem.NextPermissions = item.NextPermissions;
+                        destinationItem.CurrentPermissions = item.CurrentPermissions;
+                        destinationItem.BasePermissions = item.BasePermissions;
+                        destinationItem.EveryOnePermissions = item.EveryOnePermissions;
+                        destinationItem.GroupPermissions = item.GroupPermissions;
+                        destinationItem.AssetType = item.AssetType;
+                        destinationItem.AssetID = item.AssetID;
+                        destinationItem.GroupID = item.GroupID;
+                        destinationItem.GroupOwned = item.GroupOwned;
+                        destinationItem.SalePrice = item.SalePrice;
+                        destinationItem.SaleType = item.SaleType;
+                        destinationItem.Flags = item.Flags;
+                        destinationItem.CreationDate = item.CreationDate;
+                        destinationItem.Folder = destinationFolder.ID;
+                        ApplyNextOwnerPermissions(destinationItem);
+
+                        m_InventoryService.AddItem(destinationItem);
+                        m_log.DebugFormat("[USER ACCOUNT SERVICE]: Added item {0} to folder {1}", destinationItem.ID, destinationFolder.ID);
+
+                        // Wear item
+                        AvatarWearable newWearable = new AvatarWearable();
+                        newWearable.Wear(destinationItem.ID, wearable[0].AssetID);
+                        avatarAppearance.SetWearable(i, newWearable);
+                    }
+                    else
+                    {
+                        m_log.WarnFormat("[USER ACCOUNT SERVICE]: Error transferring {0} to folder {1}", wearable[0].ItemID, destinationFolder.ID);
+                    }
+                }
+            }
+
+            // Attachments
+            List<AvatarAttachment> attachments = avatarAppearance.GetAttachments();
+
+            foreach (AvatarAttachment attachment in attachments)
+            {
+                int attachpoint = attachment.AttachPoint;
+                UUID itemID = attachment.ItemID;
+
+                if (itemID != UUID.Zero)
+                {
+                    // Get inventory item and copy it
+                    InventoryItemBase item = m_InventoryService.GetItem(source, itemID);
+
+                    if (item != null)
+                    {
+                        InventoryItemBase destinationItem = new InventoryItemBase(UUID.Random(), destination);
+                        destinationItem.Name = item.Name;
+                        destinationItem.Owner = destination;
+                        destinationItem.Description = item.Description;
+                        destinationItem.InvType = item.InvType;
+                        destinationItem.CreatorId = item.CreatorId;
+                        destinationItem.CreatorData = item.CreatorData;
+                        destinationItem.NextPermissions = item.NextPermissions;
+                        destinationItem.CurrentPermissions = item.CurrentPermissions;
+                        destinationItem.BasePermissions = item.BasePermissions;
+                        destinationItem.EveryOnePermissions = item.EveryOnePermissions;
+                        destinationItem.GroupPermissions = item.GroupPermissions;
+                        destinationItem.AssetType = item.AssetType;
+                        destinationItem.AssetID = item.AssetID;
+                        destinationItem.GroupID = item.GroupID;
+                        destinationItem.GroupOwned = item.GroupOwned;
+                        destinationItem.SalePrice = item.SalePrice;
+                        destinationItem.SaleType = item.SaleType;
+                        destinationItem.Flags = item.Flags;
+                        destinationItem.CreationDate = item.CreationDate;
+                        destinationItem.Folder = destinationFolder.ID;
+                        ApplyNextOwnerPermissions(destinationItem);
+
+                        m_InventoryService.AddItem(destinationItem);
+                        m_log.DebugFormat("[USER ACCOUNT SERVICE]: Added item {0} to folder {1}", destinationItem.ID, destinationFolder.ID);
+
+                        // Attach item
+                        avatarAppearance.SetAttachment(attachpoint, destinationItem.ID, destinationItem.AssetID);
+                        m_log.DebugFormat("[USER ACCOUNT SERVICE]: Attached {0}", destinationItem.ID);
+                    }
+                    else
+                    {
+                        m_log.WarnFormat("[USER ACCOUNT SERVICE]: Error transferring {0} to folder {1}", itemID, destinationFolder.ID);
+                    }
+                }
+            }
+        }
+
+        /// <summary>
+        /// Apply next owner permissions.
+        /// </summary>
+        private void ApplyNextOwnerPermissions(InventoryItemBase item)
+        {
+            if (item.InvType == (int)InventoryType.Object)
+            {
+                uint perms = item.CurrentPermissions;
+                PermissionsUtil.ApplyFoldedPermissions(item.CurrentPermissions, ref perms);
+                item.CurrentPermissions = perms;
+            }
+
+            item.CurrentPermissions &= item.NextPermissions;
+            item.BasePermissions &= item.NextPermissions;
+            item.EveryOnePermissions &= item.NextPermissions;
+        }
     }
 }