1 files changed, 278 insertions, 117 deletions

diff --git a/linden/indra/llaudio/audioengine.cpp b/linden/indra/llaudio/audioengine.cpp
index 5dd5b28..da9bcba 100644
--- a/linden/indra/llaudio/audioengine.cpp
+++ b/linden/indra/llaudio/audioengine.cpp
@@ -44,14 +44,13 @@
 #include "llaudiodecodemgr.h"
 #include "llassetstorage.h"
 
+#include "llmediamanager.h"
+
 // necessary for grabbing sounds from sim (implemented in viewer)       
 extern void request_sound(const LLUUID &sound_guid);
 
 LLAudioEngine* gAudiop = NULL;
 
-// Maximum amount of time we wait for a transfer to complete before starting
-// off another one.
-const F32 MAX_CURRENT_TRANSFER_TIME = 60.f;
 
 //
 // LLAudioEngine implementation
@@ -75,13 +74,13 @@ void LLAudioEngine::setDefaults()
 
         mListenerp = NULL;
 
-        mMuted = FALSE;
+        mMuted = false;
         mUserData = NULL;
 
         mLastStatus = 0;
 
         mNumChannels = 0;
-        mEnableWind = FALSE;
+        mEnableWind = false;
 
         S32 i;
         for (i = 0; i < MAX_CHANNELS; i++)
@@ -91,15 +90,21 @@ void LLAudioEngine::setDefaults()
         for (i = 0; i < MAX_BUFFERS; i++)
         {
                 mBuffers[i] = NULL;
-        }       
+        }
 
         mMasterGain = 1.f;
         mInternetStreamGain = 0.125f;
         mNextWindUpdate = 0.f;
+
+        mInternetStreamMedia = NULL;
+        mInternetStreamURL.clear();
+
+        for (U32 i = 0; i < LLAudioEngine::AUDIO_TYPE_COUNT; i++)
+                mSecondaryGain[i] = 1.0f;
 }
 
 
-BOOL LLAudioEngine::init(const S32 num_channels, void* userdata)
+bool LLAudioEngine::init(const S32 num_channels, void* userdata)
 {
         setDefaults();
 
@@ -111,7 +116,9 @@ BOOL LLAudioEngine::init(const S32 num_channels, void* userdata)
         // Initialize the decode manager
         gAudioDecodeMgrp = new LLAudioDecodeMgr;
 
-        return TRUE;
+        LL_INFOS("AudioEngine") << "LLAudioEngine::init() AudioEngine successfully initialized" << llendl;
+
+        return true;
 }
 
 
@@ -121,6 +128,9 @@ void LLAudioEngine::shutdown()
         delete gAudioDecodeMgrp;
         gAudioDecodeMgrp = NULL;
 
+        // Clean up wind source
+        cleanupWind();
+
         // Clean up audio sources
         source_map::iterator iter_src;
         for (iter_src = mAllSources.begin(); iter_src != mAllSources.end(); iter_src++)
@@ -141,22 +151,146 @@ void LLAudioEngine::shutdown()
         S32 i;
         for (i = 0; i < MAX_CHANNELS; i++)
         {
-                if (mChannels[i])
-                {
-                        delete mChannels[i];
-                        mChannels[i] = NULL;
-                }
+                delete mChannels[i];
+                mChannels[i] = NULL;
         }
 
         // Clean up buffers
         for (i = 0; i < MAX_BUFFERS; i++)
         {
-                if (mBuffers[i])
+                delete mBuffers[i];
+                mBuffers[i] = NULL;
+        }
+
+        delete mInternetStreamMedia;
+        mInternetStreamMedia = NULL;
+        mInternetStreamURL.clear();
+}
+
+
+// virtual
+void LLAudioEngine::startInternetStream(const std::string& url)
+{
+        LL_INFOS("AudioEngine") << "entered startInternetStream()" << llendl;
+
+        if (!mInternetStreamMedia)
+        {
+                LLMediaManager* mgr = LLMediaManager::getInstance();
+                if (mgr)
                 {
-                        delete mBuffers[i];
-                        mBuffers[i] = NULL;
+                        mInternetStreamMedia = mgr->createSourceFromMimeType(LLURI(url).scheme(), "audio/mpeg"); // assumes that whatever media implementation supports mp3 also supports vorbis.
+                        LL_INFOS("AudioEngine") << "mInternetStreamMedia is now " << mInternetStreamMedia << llendl;
+                }
+        }
+
+        if(!mInternetStreamMedia)
+                return;
+        
+        if (!url.empty()) {
+                LL_INFOS("AudioEngine") << "Starting internet stream: " << url << llendl;
+                mInternetStreamURL = url;
+                mInternetStreamMedia->navigateTo ( url );
+                LL_INFOS("AudioEngine") << "Playing....." << llendl;            
+                mInternetStreamMedia->addCommand(LLMediaBase::COMMAND_START);
+                mInternetStreamMedia->updateMedia();
+        } else {
+                LL_INFOS("AudioEngine") << "setting stream to NULL"<< llendl;
+                mInternetStreamURL.clear();
+                mInternetStreamMedia->addCommand(LLMediaBase::COMMAND_STOP);
+                mInternetStreamMedia->updateMedia();
+        }
+        //#endif
+}
+
+// virtual
+void LLAudioEngine::stopInternetStream()
+{
+        LL_INFOS("AudioEngine") << "entered stopInternetStream()" << llendl;
+        
+        if(mInternetStreamMedia)
+        {
+                if( ! mInternetStreamMedia->addCommand(LLMediaBase::COMMAND_STOP)){
+                        LL_INFOS("AudioEngine") << "attempting to stop stream failed!" << llendl;
+                }
+                mInternetStreamMedia->updateMedia();
+        }
+
+        mInternetStreamURL.clear();
+}
+
+// virtual
+void LLAudioEngine::pauseInternetStream(int pause)
+{
+        LL_INFOS("AudioEngine") << "entered pauseInternetStream()" << llendl;
+
+        if(!mInternetStreamMedia)
+                return;
+        
+        if(pause)
+        {
+                if(! mInternetStreamMedia->addCommand(LLMediaBase::COMMAND_PAUSE))
+                {
+                        LL_INFOS("AudioEngine") << "attempting to pause stream failed!" << llendl;
+                }
+        } else {
+                if(! mInternetStreamMedia->addCommand(LLMediaBase::COMMAND_START))
+                {
+                        LL_INFOS("AudioEngine") << "attempting to unpause stream failed!" << llendl;
                 }
         }
+        mInternetStreamMedia->updateMedia();
+}
+
+// virtual
+void LLAudioEngine::updateInternetStream()
+{
+        if (mInternetStreamMedia)
+                mInternetStreamMedia->updateMedia();
+}
+
+// virtual
+int LLAudioEngine::isInternetStreamPlaying()
+{
+        if (!mInternetStreamMedia)
+                return 0;
+        
+        if (mInternetStreamMedia->getStatus() == LLMediaBase::STATUS_STARTED)
+        {
+                return 1; // Active and playing
+        }       
+
+        if (mInternetStreamMedia->getStatus() == LLMediaBase::STATUS_PAUSED)
+        {
+                return 2; // paused
+        }
+
+        return 0; // Stopped
+}
+
+// virtual
+void LLAudioEngine::getInternetStreamInfo(char* artist, char* title)
+{
+        artist[0] = 0;
+        title[0] = 0;
+}
+
+// virtual
+void LLAudioEngine::setInternetStreamGain(F32 vol)
+{
+        mInternetStreamGain = vol;
+
+        if(!mInternetStreamMedia)
+                return;
+
+        vol = llclamp(vol, 0.f, 1.f);
+        mInternetStreamMedia->setVolume(vol);
+        mInternetStreamMedia->updateMedia();
+}
+
+// virtual
+const std::string& LLAudioEngine::getInternetStreamURL()
+{
+        return mInternetStreamURL;
 }
 
 
@@ -167,6 +301,13 @@ void LLAudioEngine::updateChannels()
         {
                 if (mChannels[i])
                 {
+                        // set secondary gain if type is available
+                        LLAudioSource* source = mChannels[i]->getSource();
+                        if (source)
+                        {
+                                mChannels[i]->setSecondaryGain(mSecondaryGain[source->getType()]);
+                        }
+                        
                         mChannels[i]->updateBuffer();
                         mChannels[i]->update3DPosition();
                         mChannels[i]->updateLoop();
@@ -200,7 +341,7 @@ void LLAudioEngine::idle(F32 max_decode_time)
         {
                 if (mBuffers[i])
                 {
-                        mBuffers[i]->mInUse = FALSE;
+                        mBuffers[i]->mInUse = false;
                 }
         }
 
@@ -245,18 +386,18 @@ void LLAudioEngine::idle(F32 max_decode_time)
                 LLAudioChannel *channelp = getFreeChannel(max_priority);
                 if (channelp)
                 {
-                        //llinfos << "Replacing source in channel due to priority!" << llendl;
+                        //LL_INFOS("AudioEngine") << "Replacing source in channel due to priority!" << llendl;
                         max_sourcep->setChannel(channelp);
                         channelp->setSource(max_sourcep);
                         if (max_sourcep->isSyncSlave())
                         {
                                 // A sync slave, it doesn't start playing until it's synced up with the master.
                                 // Flag this channel as waiting for sync, and return true.
-                                channelp->setWaiting(TRUE);
+                                channelp->setWaiting(true);
                         }
                         else
                         {
-                                channelp->setWaiting(FALSE);
+                                channelp->setWaiting(false);
                                 channelp->play();
                         }
                 }
@@ -396,7 +537,7 @@ void LLAudioEngine::idle(F32 max_decode_time)
                                 if (sync_masterp->getChannel())
                                 {
                                         channelp->playSynced(master_channelp);
-                                        channelp->setWaiting(FALSE);
+                                        channelp->setWaiting(false);
                                 }
                         }
                 }
@@ -412,7 +553,7 @@ void LLAudioEngine::idle(F32 max_decode_time)
                 {
                         if (!mBuffers[i]->mInUse && mBuffers[i]->mLastUseTimer.getElapsedTimeF32() > 30.f)
                         {
-                                //llinfos << "Flushing unused buffer!" << llendl;
+                                //LL_INFOS("AudioEngine") << "Flushing unused buffer!" << llendl;
                                 mBuffers[i]->mAudioDatap->mBufferp = NULL;
                                 delete mBuffers[i];
                                 mBuffers[i] = NULL;
@@ -426,7 +567,7 @@ void LLAudioEngine::idle(F32 max_decode_time)
         {
                 if (mChannels[i])
                 {
-                        mChannels[i]->mLoopedThisFrame = FALSE;
+                        mChannels[i]->mLoopedThisFrame = false;
                 }
         }
 
@@ -437,13 +578,17 @@ void LLAudioEngine::idle(F32 max_decode_time)
         // missed picking it up in all the places that can add
         // or request new data.
         startNextTransfer();
+
+        updateInternetStream();
 }
 
-BOOL LLAudioEngine::updateBufferForData(LLAudioData *adp, const LLUUID &audio_uuid)
+
+
+bool LLAudioEngine::updateBufferForData(LLAudioData *adp, const LLUUID &audio_uuid)
 {
         if (!adp)
         {
-                return FALSE;
+                return false;
         }
 
         // Update the audio buffer first - load a sound if we have it.
@@ -466,14 +611,14 @@ BOOL LLAudioEngine::updateBufferForData(LLAudioData *adp, const LLUUID &audio_uu
                 }
                 else
                 {
-                        return FALSE;
+                        return false;
                 }
         }
-        return TRUE;
+        return true;
 }
 
 
-void LLAudioEngine::enableWind(BOOL enable)
+void LLAudioEngine::enableWind(bool enable)
 {
         if (enable && (!mEnableWind))
         {
@@ -521,8 +666,8 @@ LLAudioBuffer *LLAudioEngine::getFreeBuffer()
 
         if (buffer_id >= 0)
         {
-                llinfos << "Taking over unused buffer " << buffer_id << llendl;
-                //llinfos << "Flushing unused buffer!" << llendl;
+                LL_INFOS("AudioEngine") << "Taking over unused buffer " << buffer_id << llendl;
+                //LL_INFOS("AudioEngine") << "Flushing unused buffer!" << llendl;
                 mBuffers[buffer_id]->mAudioDatap->mBufferp = NULL;
                 delete mBuffers[buffer_id];
                 mBuffers[buffer_id] = createBuffer();
@@ -601,7 +746,7 @@ void LLAudioEngine::cleanupBuffer(LLAudioBuffer *bufferp)
 }
 
 
-BOOL LLAudioEngine::preloadSound(const LLUUID &uuid)
+bool LLAudioEngine::preloadSound(const LLUUID &uuid)
 {
         gAudiop->getAudioData(uuid);    // We don't care about the return value, this is just to make sure
                                                                         // that we have an entry, which will mean that the audio engine knows about this
@@ -609,23 +754,23 @@ BOOL LLAudioEngine::preloadSound(const LLUUID &uuid)
         if (gAudioDecodeMgrp->addDecodeRequest(uuid))
         {
                 // This means that we do have a local copy, and we're working on decoding it.
-                return TRUE;
+                return true;
         }
 
         // At some point we need to have the audio/asset system check the static VFS
         // before it goes off and fetches stuff from the server.
         //llwarns << "Used internal preload for non-local sound" << llendl;
-        return FALSE;
+        return false;
 }
 
 
-BOOL LLAudioEngine::isWindEnabled()
+bool LLAudioEngine::isWindEnabled()
 {
         return mEnableWind;
 }
 
 
-void LLAudioEngine::setMuted(BOOL muted)
+void LLAudioEngine::setMuted(bool muted)
 {
         mMuted = muted;
         enableWind(!mMuted);
@@ -643,6 +788,18 @@ F32 LLAudioEngine::getMasterGain()
         return mMasterGain;
 }
 
+void LLAudioEngine::setSecondaryGain(S32 type, F32 gain)
+{
+        llassert(type < LLAudioEngine::AUDIO_TYPE_COUNT);
+        
+        mSecondaryGain[type] = gain;
+}
+
+F32 LLAudioEngine::getSecondaryGain(S32 type)
+{
+        return mSecondaryGain[type];
+}
+
 F32 LLAudioEngine::getInternetStreamGain()
 {
         return mInternetStreamGain;
@@ -718,10 +875,11 @@ F64 LLAudioEngine::mapWindVecToPan(LLVector3 wind_vec)
 }
 
 
-void LLAudioEngine::triggerSound(const LLUUID &audio_uuid, const LLUUID& owner_id, const F32 gain, const LLVector3d &pos_global)
+void LLAudioEngine::triggerSound(const LLUUID &audio_uuid, const LLUUID& owner_id, const F32 gain,
+                                                                 const S32 type, const LLVector3d &pos_global)
 {
         // Create a new source (since this can't be associated with an existing source.
-        //llinfos << "Localized: " << audio_uuid << llendl;
+        //LL_INFOS("AudioEngine") << "Localized: " << audio_uuid << llendl;
 
         if (mMuted)
         {
@@ -731,11 +889,11 @@ void LLAudioEngine::triggerSound(const LLUUID &audio_uuid, const LLUUID& owner_i
         LLUUID source_id;
         source_id.generate();
 
-        LLAudioSource *asp = new LLAudioSource(source_id, owner_id, gain);
+        LLAudioSource *asp = new LLAudioSource(source_id, owner_id, gain, type);
         gAudiop->addAudioSource(asp);
         if (pos_global.isExactlyZero())
         {
-                asp->setAmbient(TRUE);
+                asp->setAmbient(true);
         }
         else
         {
@@ -914,7 +1072,7 @@ void LLAudioEngine::cleanupAudioSource(LLAudioSource *asp)
 }
 
 
-BOOL LLAudioEngine::hasDecodedFile(const LLUUID &uuid)
+bool LLAudioEngine::hasDecodedFile(const LLUUID &uuid)
 {
         std::string uuid_str;
         uuid.toString(uuid_str);
@@ -925,16 +1083,16 @@ BOOL LLAudioEngine::hasDecodedFile(const LLUUID &uuid)
 
         if (gDirUtilp->fileExists(wav_path))
         {
-                return TRUE;
+                return true;
         }
         else
         {
-                return FALSE;
+                return false;
         }
 }
 
 
-BOOL LLAudioEngine::hasLocalFile(const LLUUID &uuid)
+bool LLAudioEngine::hasLocalFile(const LLUUID &uuid)
 {
         // See if it's in the VFS.
         return gVFS->getExists(uuid, LLAssetType::AT_SOUND);
@@ -943,10 +1101,10 @@ BOOL LLAudioEngine::hasLocalFile(const LLUUID &uuid)
 
 void LLAudioEngine::startNextTransfer()
 {
-        //llinfos << "LLAudioEngine::startNextTransfer()" << llendl;
+        //LL_INFOS("AudioEngine") << "LLAudioEngine::startNextTransfer()" << llendl;
         if (mCurrentTransfer.notNull() || getMuted())
         {
-                //llinfos << "Transfer in progress, aborting" << llendl;
+                //LL_INFOS("AudioEngine") << "Transfer in progress, aborting" << llendl;
                 return;
         }
 
@@ -1127,7 +1285,7 @@ void LLAudioEngine::startNextTransfer()
 
         if (asset_id.notNull())
         {
-                llinfos << "Getting asset data for: " << asset_id << llendl;
+                LL_INFOS("AudioEngine") << "Getting asset data for: " << asset_id << llendl;
                 gAudiop->mCurrentTransfer = asset_id;
                 gAudiop->mCurrentTransferTimer.reset();
                 gAssetStorage->getAssetData(asset_id, LLAssetType::AT_SOUND,
@@ -1135,7 +1293,7 @@ void LLAudioEngine::startNextTransfer()
         }
         else
         {
-                //llinfos << "No pending transfers?" << llendl;
+                //LL_INFOS("AudioEngine") << "No pending transfers?" << llendl;
         }
 }
 
@@ -1145,14 +1303,14 @@ void LLAudioEngine::assetCallback(LLVFS *vfs, const LLUUID &uuid, LLAssetType::E
 {
         if (result_code)
         {
-                llinfos << "Boom, error in audio file transfer: " << LLAssetStorage::getErrorString( result_code ) << " (" << result_code << ")" << llendl;
+                LL_INFOS("AudioEngine") << "Boom, error in audio file transfer: " << LLAssetStorage::getErrorString( result_code ) << " (" << result_code << ")" << llendl;
                 // Need to mark data as bad to avoid constant rerequests.
                 LLAudioData *adp = gAudiop->getAudioData(uuid);
                 if (adp)
         {
-                        adp->setHasValidData(FALSE);
-                        adp->setHasLocalData(FALSE);
-                        adp->setHasDecodedData(FALSE);
+                        adp->setHasValidData(false);
+                        adp->setHasLocalData(false);
+                        adp->setHasDecodedData(false);
                 }
         }
         else
@@ -1165,8 +1323,8 @@ void LLAudioEngine::assetCallback(LLVFS *vfs, const LLUUID &uuid, LLAssetType::E
         }
                 else
                 {
-                        adp->setHasValidData(TRUE);
-                    adp->setHasLocalData(TRUE);
+                        adp->setHasValidData(true);
+                    adp->setHasLocalData(true);
                     gAudioDecodeMgrp->addDecodeRequest(uuid);
                 }
         }
@@ -1180,17 +1338,18 @@ void LLAudioEngine::assetCallback(LLVFS *vfs, const LLUUID &uuid, LLAssetType::E
 //
 
 
-LLAudioSource::LLAudioSource(const LLUUID& id, const LLUUID& owner_id, const F32 gain)
+LLAudioSource::LLAudioSource(const LLUUID& id, const LLUUID& owner_id, const F32 gain, const S32 type)
 :       mID(id),
         mOwnerID(owner_id),
         mPriority(0.f),
         mGain(gain),
-        mAmbient(FALSE),
-        mLoop(FALSE),
-        mSyncMaster(FALSE),
-        mSyncSlave(FALSE),
-        mQueueSounds(FALSE),
-        mPlayedOnce(FALSE),
+        mType(type),
+        mAmbient(false),
+        mLoop(false),
+        mSyncMaster(false),
+        mSyncSlave(false),
+        mQueueSounds(false),
+        mPlayedOnce(false),
         mChannelp(NULL),
         mCurrentDatap(NULL),
         mQueuedDatap(NULL)
@@ -1254,7 +1413,7 @@ void LLAudioSource::updatePriority()
         }
 }
 
-BOOL LLAudioSource::setupChannel()
+bool LLAudioSource::setupChannel()
 {
         LLAudioData *adp = getCurrentData();
 
@@ -1262,7 +1421,7 @@ BOOL LLAudioSource::setupChannel()
         {
                 // We're not ready to play back the sound yet, so don't try and allocate a channel for it.
                 //llwarns << "Aborting, no buffer" << llendl;
-                return FALSE;
+                return false;
         }
 
 
@@ -1280,15 +1439,15 @@ BOOL LLAudioSource::setupChannel()
                 // Now we have to reprioritize.
                 // For now, just don't play the sound.
                 //llwarns << "Aborting, no free channels" << llendl;
-                return FALSE;
+                return false;
         }
 
         mChannelp->setSource(this);
-        return TRUE;
+        return true;
 }
 
 
-BOOL LLAudioSource::play(const LLUUID &audio_uuid)
+bool LLAudioSource::play(const LLUUID &audio_uuid)
 {
         if (audio_uuid.isNull())
         {
@@ -1296,7 +1455,7 @@ BOOL LLAudioSource::play(const LLUUID &audio_uuid)
                 {
                         getChannel()->setSource(NULL);
                         setChannel(NULL);
-                        addAudioData(NULL, TRUE);
+                        addAudioData(NULL, true);
                 }
         }
         // Reset our age timeout if someone attempts to play the source.
@@ -1304,7 +1463,7 @@ BOOL LLAudioSource::play(const LLUUID &audio_uuid)
 
         LLAudioData *adp = gAudiop->getAudioData(audio_uuid);
 
-        BOOL has_buffer = gAudiop->updateBufferForData(adp, audio_uuid);
+        bool has_buffer = gAudiop->updateBufferForData(adp, audio_uuid);
 
 
         addAudioData(adp);
@@ -1312,47 +1471,48 @@ BOOL LLAudioSource::play(const LLUUID &audio_uuid)
         if (!has_buffer)
         {
                 // Don't bother trying to set up a channel or anything, we don't have an audio buffer.
-                return FALSE;
+                return false;
         }
 
         if (!setupChannel())
         {
-                return FALSE;
+                return false;
         }
 
         if (isSyncSlave())
         {
                 // A sync slave, it doesn't start playing until it's synced up with the master.
                 // Flag this channel as waiting for sync, and return true.
-                getChannel()->setWaiting(TRUE);
-                return TRUE;
+                getChannel()->setWaiting(true);
+                return true;
         }
 
         getChannel()->play();
-        return TRUE;
+        return true;
 }
 
 
-BOOL LLAudioSource::isDone()
+bool LLAudioSource::isDone()
 {
         const F32 MAX_AGE = 60.f;
         const F32 MAX_UNPLAYED_AGE = 15.f;
+
         if (isLoop())
         {
                 // Looped sources never die on their own.
-                return FALSE;
+                return false;
         }
 
 
         if (hasPendingPreloads())
         {
-                return FALSE;
+                return false;
         }
 
         if (mQueuedDatap)
         {
                 // Don't kill this sound if we've got something queued up to play.
-                return FALSE;
+                return false;
         }
 
         F32 elapsed = mAgeTimer.getElapsedTimeF32();
@@ -1364,12 +1524,12 @@ BOOL LLAudioSource::isDone()
                 {
                         // We don't have a channel assigned, and it's been
                         // over 5 seconds since we tried to play it.  Don't bother.
-                        //llinfos << "No channel assigned, source is done" << llendl;
-                        return TRUE;
+                        //LL_INFOS("AudioEngine") << "No channel assigned, source is done" << llendl;
+                        return true;
                 }
                 else
                 {
-                        return FALSE;
+                        return false;
                 }
         }
 
@@ -1377,27 +1537,27 @@ BOOL LLAudioSource::isDone()
         {
                 if (elapsed > MAX_AGE)
                 {
-                        // Arbitarily cut off non-looped sounds when they're 20 seconds old.
-                        return TRUE;
+                        // Arbitarily cut off non-looped sounds when they're old.
+                        return true;
                 }
                 else
                 {
                         // Sound is still playing and we haven't timed out, don't kill it.
-                        return FALSE;
+                        return false;
                 }
         }
 
         if ((elapsed > MAX_UNPLAYED_AGE) || mPlayedOnce)
         {
                 // The sound isn't playing back after 5 seconds or we're already done playing it, kill it.
-                return TRUE;
+                return true;
         }
 
-        return FALSE;
+        return false;
 }
 
 
-void LLAudioSource::addAudioData(LLAudioData *adp, const BOOL set_current)
+void LLAudioSource::addAudioData(LLAudioData *adp, const bool set_current)
 {
         // Only handle a single piece of audio data associated with a source right now,
         // until I implement prefetch.
@@ -1465,7 +1625,7 @@ void LLAudioSource::addAudioData(LLAudioData *adp, const BOOL set_current)
 }
 
 
-BOOL LLAudioSource::hasPendingPreloads() const
+bool LLAudioSource::hasPendingPreloads() const
 {
         // Check to see if we've got any preloads on deck for this source
         data_map::const_iterator iter;
@@ -1475,11 +1635,11 @@ BOOL LLAudioSource::hasPendingPreloads() const
                 if (!adp->hasDecodedData())
                 {
                         // This source is still waiting for a preload
-                        return TRUE;
+                        return true;
                 }
         }
 
-        return FALSE;
+        return false;
 }
 
 
@@ -1514,8 +1674,9 @@ LLAudioBuffer *LLAudioSource::getCurrentBuffer()
 LLAudioChannel::LLAudioChannel() :
         mCurrentSourcep(NULL),
         mCurrentBufferp(NULL),
-        mLoopedThisFrame(FALSE),
-        mWaiting(FALSE)
+        mLoopedThisFrame(false),
+        mWaiting(false),
+        mSecondaryGain(1.0f)
 {
 }
 
@@ -1523,7 +1684,7 @@ LLAudioChannel::LLAudioChannel() :
 LLAudioChannel::~LLAudioChannel()
 {
         // Need to disconnect any sources which are using this channel.
-        //llinfos << "Cleaning up audio channel" << llendl;
+        //LL_INFOS("AudioEngine") << "Cleaning up audio channel" << llendl;
         if (mCurrentSourcep)
         {
                 mCurrentSourcep->setChannel(NULL);
@@ -1534,22 +1695,22 @@ LLAudioChannel::~LLAudioChannel()
 
 void LLAudioChannel::setSource(LLAudioSource *sourcep)
 {
-        //llinfos << this << ": setSource(" << sourcep << ")" << llendl;
+        //LL_INFOS("AudioEngine") << this << ": setSource(" << sourcep << ")" << llendl;
 
         if (!sourcep)
         {
                 // Clearing the source for this channel, don't need to do anything.
-                //llinfos << "Clearing source for channel" << llendl;
+                //LL_INFOS("AudioEngine") << "Clearing source for channel" << llendl;
                 cleanup();
                 mCurrentSourcep = NULL;
-                mWaiting = FALSE;
+                mWaiting = false;
                 return;
         }
 
         if (sourcep == mCurrentSourcep)
         {
                 // Don't reallocate the channel, this will make FMOD goofy.
-                //llinfos << "Calling setSource with same source!" << llendl;
+                //LL_INFOS("AudioEngine") << "Calling setSource with same source!" << llendl;
         }
 
         mCurrentSourcep = sourcep;
@@ -1558,13 +1719,13 @@ void LLAudioChannel::setSource(LLAudioSource *sourcep)
 }
 
 
-BOOL LLAudioChannel::updateBuffer()
+bool LLAudioChannel::updateBuffer()
 {
         if (!mCurrentSourcep)
         {
                 // This channel isn't associated with any source, nothing
                 // to be updated
-                return FALSE;
+                return false;
         }
 
         LLAudioBuffer *bufferp = mCurrentSourcep->getCurrentBuffer();
@@ -1574,14 +1735,14 @@ BOOL LLAudioChannel::updateBuffer()
                 {
                         // The source hasn't changed what buffer it's playing
                         bufferp->mLastUseTimer.reset();
-                        bufferp->mInUse = TRUE;
+                        bufferp->mInUse = true;
                 }
-                return FALSE;
+                return false;
         }
 
         //
-        // The source changed what buffer it's playing.  Whe need to clean up the
-        // existing fmod channel
+        // The source changed what buffer it's playing.  We need to clean up
+        // the existing channel
         //
         cleanup();
 
@@ -1589,16 +1750,16 @@ BOOL LLAudioChannel::updateBuffer()
         if (bufferp)
         {
                 bufferp->mLastUseTimer.reset();
-                bufferp->mInUse = TRUE;
+                bufferp->mInUse = true;
         }
 
         if (!mCurrentBufferp)
         {
                 // There's no new buffer to be played, so we just abort.
-                return FALSE;
+                return false;
         }
 
-        return TRUE;
+        return true;
 }
 
 
@@ -1612,9 +1773,9 @@ BOOL LLAudioChannel::updateBuffer()
 LLAudioData::LLAudioData(const LLUUID &uuid) :
         mID(uuid),
         mBufferp(NULL),
-        mHasLocalData(FALSE),
-        mHasDecodedData(FALSE),
-        mHasValidData(TRUE)
+        mHasLocalData(false),
+        mHasDecodedData(false),
+        mHasValidData(true)
 {
         if (uuid.isNull())
         {
@@ -1625,32 +1786,32 @@ LLAudioData::LLAudioData(const LLUUID &uuid) :
         if (gAudiop && gAudiop->hasDecodedFile(uuid))
         {
                 // Already have a decoded version, don't need to decode it.
-                mHasLocalData = TRUE;
-                mHasDecodedData = TRUE;
+                mHasLocalData = true;
+                mHasDecodedData = true;
         }
         else if (gAssetStorage && gAssetStorage->hasLocalAsset(uuid, LLAssetType::AT_SOUND))
         {
-                mHasLocalData = TRUE;
+                mHasLocalData = true;
         }
 }
 
 
-BOOL LLAudioData::load()
+bool LLAudioData::load()
 {
         // For now, just assume we're going to use one buffer per audiodata.
         if (mBufferp)
         {
                 // We already have this sound in a buffer, don't do anything.
-                llinfos << "Already have a buffer for this sound, don't bother loading!" << llendl;
-                return TRUE;
+                LL_INFOS("AudioEngine") << "Already have a buffer for this sound, don't bother loading!" << llendl;
+                return true;
         }
         
         mBufferp = gAudiop->getFreeBuffer();
         if (!mBufferp)
         {
                 // No free buffers, abort.
-                llinfos << "Not able to allocate a new audio buffer, aborting." << llendl;
-                return FALSE;
+                LL_INFOS("AudioEngine") << "Not able to allocate a new audio buffer, aborting." << llendl;
+                return false;
         }
 
         std::string uuid_str;
@@ -1664,10 +1825,10 @@ BOOL LLAudioData::load()
                 gAudiop->cleanupBuffer(mBufferp);
                 mBufferp = NULL;
 
-                return FALSE;
+                return false;
         }
         mBufferp->mAudioDatap = this;
-        return TRUE;
+        return true;
 }