Merge branch 'filter-fixes' into next

6 files changed, 161 insertions, 71 deletions

diff --git a/ChangeLog.txt b/ChangeLog.txt
index 9cb5453..4e74ac3 100644
--- a/ChangeLog.txt
+++ b/ChangeLog.txt
@@ -1,3 +1,10 @@
+2009-01-18  Jacek Antonelli  <jacek.antonelli@gmail.com>
+
+        * linden/indra/newview/llpanelinventory.cpp:
+        LLFolderViewEventListener has type NIT_FOLDER.
+        This fixes folders always showing when filtering.
+
+
 2009-01-17  Jacek Antonelli  <jacek.antonelli@gmail.com>
 
         * linden/indra/newview/llfolderview.cpp:
@@ -19,6 +26,27 @@
         Fixed texture picker not showing textures.
 
 
+        * linden/indra/newview/llinventoryview.cpp: 
+        Cosmetic code cleanup in LLInventoryViewFinder.
+        
+
+        * linden/indra/newview/llinventoryview.cpp:
+        Removed some dead code in LLInventoryViewFinder.
+
+
+        * linden/indra/newview/llinventoryview.cpp:
+        Removed now-useless LLInventoryViewFinder::draw().
+        * linden/indra/newview/llinventoryview.h:
+        Ditto.
+
+
+        * linden/indra/newview/llinventoryview.cpp:
+        Use UI callbacks to initiate rebuilding filter.
+        Instead of rebuilding from draw() every frame.
+        * linden/indra/newview/llinventoryview.h:
+        Ditto.
+
+
 2009-01-15  Jacek Antonelli  <jacek.antonelli@gmail.com>
 
         * linden/indra/newview/llvoavatar.cpp:
@@ -26,6 +54,35 @@
         Patch posted by CG Linden.
 
 
+        * linden/indra/newview/llfolderview.cpp:
+        Fixed folders expanding when Show Filters is opened.
+
+
+        * linden/indra/newview/llinventoryview.cpp:
+        Simplified rebuildFilter() a bit.
+
+
+        * linden/indra/newview/llinventoryview.cpp:
+        LLInventoryViewFinder::rebuildFilter().
+        Refactored from draw().
+
+        * linden/indra/newview/llinventoryview.h:
+        Ditto.
+
+
+2009-01-14  Jacek Antonelli  <jacek.antonelli@gmail.com>
+
+        * linden/indra/newview/llinventoryview.cpp:
+        Don't show empty folders when using filter.
+        This is the old behavior, but I had broken it.
+
+
+        * linden/indra/llinventory/llinventorytype.h:
+        Added inventory ntype for folders.
+        * linden/indra/llinventory/llinventory.cpp:
+        Ditto.
+
+
 2009-01-11  Jacek Antonelli  <jacek.antonelli@gmail.com>
 
         * linden/indra/cmake/GStreamer.cmake:
diff --git a/linden/indra/llinventory/llinventory.cpp b/linden/indra/llinventory/llinventory.cpp
index 0a8a1fb..4b2e810 100644
--- a/linden/indra/llinventory/llinventory.cpp
+++ b/linden/indra/llinventory/llinventory.cpp
@@ -173,6 +173,11 @@ LLInventoryType::NType calc_ntype(
                 case LLInventoryType::IT_ATTACHMENT:
                         return LLInventoryType::NIT_OBJECT;
 
+                        // FOLDERS
+                case LLInventoryType::IT_CATEGORY:
+                case LLInventoryType::IT_ROOT_CATEGORY:
+                        return LLInventoryType::NIT_FOLDER;
+
                         // UNKNOWN TYPE!
                 default:
                         return LLInventoryType::NIT_NONE;
diff --git a/linden/indra/llinventory/llinventorytype.h b/linden/indra/llinventory/llinventorytype.h
index f228cd0..c81733e 100644
--- a/linden/indra/llinventory/llinventorytype.h
+++ b/linden/indra/llinventory/llinventorytype.h
@@ -152,8 +152,11 @@ public:
                 /* Objects */
                 NIT_OBJECT           =  1 << 24,
 
+    /* Folders ("Categories" in the old type system) */
+    NIT_FOLDER           =  1 << 25,
+
                 /* Bitwise OR-ing of all the above */
-                NIT_ALL              =  0x1ffffff,
+                NIT_ALL              =  0x3ffffff,
         };
 
 
diff --git a/linden/indra/newview/llinventoryview.cpp b/linden/indra/newview/llinventoryview.cpp
index 52c3b7e..a265906 100644
--- a/linden/indra/newview/llinventoryview.cpp
+++ b/linden/indra/newview/llinventoryview.cpp
@@ -118,6 +118,21 @@ LLInventoryViewFinder::LLInventoryViewFinder(const std::string& name,
 
         LLUICtrlFactory::getInstance()->buildFloater(this, "floater_inventory_view_finder.xml");
 
+
+        childSetCommitCallback("check_animation",    onCheckFilterType, this);
+        childSetCommitCallback("check_bodypart",     onCheckFilterType, this);
+        childSetCommitCallback("check_calling_card", onCheckFilterType, this);
+        childSetCommitCallback("check_clothing",     onCheckFilterType, this);
+        childSetCommitCallback("check_gesture",      onCheckFilterType, this);
+        childSetCommitCallback("check_landmark",     onCheckFilterType, this);
+        childSetCommitCallback("check_notecard",     onCheckFilterType, this);
+        childSetCommitCallback("check_object",       onCheckFilterType, this);
+        childSetCommitCallback("check_script",       onCheckFilterType, this);
+        childSetCommitCallback("check_sound",        onCheckFilterType, this);
+        childSetCommitCallback("check_texture",      onCheckFilterType, this);
+        childSetCommitCallback("check_snapshot",     onCheckFilterType, this);
+
+
         childSetAction("All", selectAllTypes, this);
         childSetAction("None", selectNoTypes, this);
 
@@ -127,6 +142,8 @@ LLInventoryViewFinder::LLInventoryViewFinder(const std::string& name,
         mSpinSinceDays = getChild<LLSpinCtrl>("spin_days_ago");
         childSetCommitCallback("spin_days_ago", onTimeAgo, this);
 
+        childSetCommitCallback("check_show_empty", onCheckShowEmptyFolders, this);
+
 //      mCheckSinceLogoff   = getChild<LLSpinCtrl>("check_since_logoff");
         childSetCommitCallback("check_since_logoff", onCheckSinceLogoff, this);
 
@@ -136,6 +153,16 @@ LLInventoryViewFinder::LLInventoryViewFinder(const std::string& name,
 }
 
 
+// Callback when an inventory type checkbox is changed.
+void LLInventoryViewFinder::onCheckFilterType(LLUICtrl *ctrl, void *user_data)
+{
+        LLInventoryViewFinder *self = (LLInventoryViewFinder *)user_data;
+        if (!self) return;
+
+        self->rebuildFilter();
+}
+
+
 void LLInventoryViewFinder::onCheckSinceLogoff(LLUICtrl *ctrl, void *user_data)
 {
         LLInventoryViewFinder *self = (LLInventoryViewFinder *)user_data;
@@ -148,6 +175,8 @@ void LLInventoryViewFinder::onCheckSinceLogoff(LLUICtrl *ctrl, void *user_data)
         {
                 self->mSpinSinceHours->set(1.0f);
         }       
+
+        self->rebuildFilter();
 }
 
 void LLInventoryViewFinder::onTimeAgo(LLUICtrl *ctrl, void *user_data)
@@ -161,14 +190,27 @@ void LLInventoryViewFinder::onTimeAgo(LLUICtrl *ctrl, void *user_data)
                 since_logoff = false;
         }
         self->childSetValue("check_since_logoff", since_logoff);
+
+        self->rebuildFilter();
+}
+
+
+void LLInventoryViewFinder::onCheckShowEmptyFolders(LLUICtrl *ctrl, void *user_data)
+{
+        LLInventoryViewFinder *self = (LLInventoryViewFinder *)user_data;
+        if (!self) return;
+
+        self->rebuildFilter();
 }
 
+
 void LLInventoryViewFinder::changeFilter(LLInventoryFilter* filter)
 {
         mFilter = filter;
         updateElementsFromFilter();
 }
 
+
 void LLInventoryViewFinder::updateElementsFromFilter()
 {
         if (!mFilter)
@@ -180,113 +222,116 @@ void LLInventoryViewFinder::updateElementsFromFilter()
         LLInventoryFilter::EFolderShow show_folders = mFilter->getShowFolderState();
         U32 hours = mFilter->getHoursAgo();
 
-        // update the ui elements
+        // Update floater title
         LLFloater::setTitle(mFilter->getName());
 
-        childSetValue("check_animation", (S32) (filter_types & LLInventoryType::NIT_ANIMATION));
-        childSetValue("check_bodypart", (S32) (filter_types & LLInventoryType::NIT_BODYPART));
-        childSetValue("check_calling_card", (S32) (filter_types & LLInventoryType::NIT_CALLCARD));
-        childSetValue("check_clothing", (S32) (filter_types & LLInventoryType::NIT_CLOTHING));
-        childSetValue("check_gesture", (S32) (filter_types & LLInventoryType::NIT_GESTURE));
-        childSetValue("check_landmark", (S32) (filter_types & LLInventoryType::NIT_LANDMARK));
-        childSetValue("check_notecard", (S32) (filter_types & LLInventoryType::NIT_NOTECARD));
-        childSetValue("check_object", (S32) (filter_types & LLInventoryType::NIT_OBJECT));
-        childSetValue("check_script", (S32) (filter_types & LLInventoryType::NIT_SCRIPT_LSL2));
-        childSetValue("check_sound", (S32) (filter_types & LLInventoryType::NIT_SOUND));
-        childSetValue("check_texture", (S32) (filter_types & LLInventoryType::NIT_TEXTURE));
-        childSetValue("check_snapshot", (S32) (filter_types & LLInventoryType::NIT_SNAPSHOT));
-        childSetValue("check_show_empty", show_folders == LLInventoryFilter::SHOW_ALL_FOLDERS);
-        childSetValue("check_since_logoff", mFilter->isSinceLogoff());
-        mSpinSinceHours->set((F32)(hours % 24));
-        mSpinSinceDays->set((F32)(hours / 24));
-}
-
-void LLInventoryViewFinder::draw()
-{
-        U32 filter = 0xffffffff;
-        BOOL filtered_by_all_types = TRUE;
+        // Update type check boxes
+        childSetValue("check_animation",
+                      (S32)(filter_types & LLInventoryType::NIT_ANIMATION));
+        childSetValue("check_bodypart",
+                      (S32)(filter_types & LLInventoryType::NIT_BODYPART));
+        childSetValue("check_calling_card",
+                      (S32)(filter_types & LLInventoryType::NIT_CALLCARD));
+        childSetValue("check_clothing",
+                      (S32)(filter_types & LLInventoryType::NIT_CLOTHING));
+        childSetValue("check_gesture",
+                      (S32)(filter_types & LLInventoryType::NIT_GESTURE));
+        childSetValue("check_landmark",
+                      (S32)(filter_types & LLInventoryType::NIT_LANDMARK));
+        childSetValue("check_notecard",
+                      (S32)(filter_types & LLInventoryType::NIT_NOTECARD));
+        childSetValue("check_object",
+                      (S32)(filter_types & LLInventoryType::NIT_OBJECT));
+        childSetValue("check_script",
+                      (S32)(filter_types & LLInventoryType::NIT_SCRIPT_LSL2));
+        childSetValue("check_sound",
+                      (S32)(filter_types & LLInventoryType::NIT_SOUND));
+        childSetValue("check_texture",
+                      (S32)(filter_types & LLInventoryType::NIT_TEXTURE));
+        childSetValue("check_snapshot",
+                      (S32)(filter_types & LLInventoryType::NIT_SNAPSHOT));
+
+        // Update other check boxes
+        childSetValue("check_show_empty",
+                      show_folders == LLInventoryFilter::SHOW_ALL_FOLDERS);
+        childSetValue("check_since_logoff",
+                      mFilter->isSinceLogoff());
+
+        // Update hours and days spinners
+        mSpinSinceHours->set( (F32)(hours % 24) );
+        mSpinSinceDays->set(  (F32)(hours / 24) );
+}
+
+
+void LLInventoryViewFinder::rebuildFilter()
+{
+        U32 filter = LLInventoryType::NIT_ALL;
 
         if (!childGetValue("check_animation"))
         {
                 filter &= ~(LLInventoryType::NIT_ANIMATION);
-                filtered_by_all_types = FALSE;
         }
 
         if (!childGetValue("check_bodypart"))
         {
                 filter &= ~(LLInventoryType::NIT_BODYPART);
-                filtered_by_all_types = FALSE;
         }
 
         if (!childGetValue("check_calling_card"))
         {
                 filter &= ~(LLInventoryType::NIT_CALLCARD);
-                filtered_by_all_types = FALSE;
         }
 
         if (!childGetValue("check_clothing"))
         {
                 filter &= ~(LLInventoryType::NIT_CLOTHING);
-                filtered_by_all_types = FALSE;
         }
 
         if (!childGetValue("check_gesture"))
         {
                 filter &= ~(LLInventoryType::NIT_GESTURE);
-                filtered_by_all_types = FALSE;
         }
 
         if (!childGetValue("check_landmark"))
-
-
         {
                 filter &= ~(LLInventoryType::NIT_LANDMARK);
-                filtered_by_all_types = FALSE;
         }
 
         if (!childGetValue("check_notecard"))
         {
                 filter &= ~(LLInventoryType::NIT_NOTECARD);
-                filtered_by_all_types = FALSE;
         }
 
         if (!childGetValue("check_object"))
         {
                 filter &= ~(LLInventoryType::NIT_OBJECT);
-                filtered_by_all_types = FALSE;
         }
 
         if (!childGetValue("check_script"))
         {
                 filter &= ~(LLInventoryType::NIT_SCRIPT_LSL2);
-                filtered_by_all_types = FALSE;
         }
 
         if (!childGetValue("check_sound"))
         {
                 filter &= ~(LLInventoryType::NIT_SOUND);
-                filtered_by_all_types = FALSE;
         }
 
         if (!childGetValue("check_texture"))
         {
                 filter &= ~(LLInventoryType::NIT_TEXTURE);
-                filtered_by_all_types = FALSE;
         }
 
         if (!childGetValue("check_snapshot"))
         {
                 filter &= ~(LLInventoryType::NIT_SNAPSHOT);
-                filtered_by_all_types = FALSE;
         }
 
-  /*
-        if (!filtered_by_all_types)
+        if (filter != LLInventoryType::NIT_ALL)
         {
                 // don't include folders in filter, unless I've selected everything
-                filter &= ~(LLInventoryType::NIT_CATEGORY);
+                filter &= ~(LLInventoryType::NIT_FOLDER);
         }
-  */
 
         // update the panel, panel will update the filter
         mInventoryView->mActivePanel->setShowFolderState(getCheckShowEmpty() ?
@@ -310,8 +355,6 @@ void LLInventoryViewFinder::draw()
         mInventoryView->mActivePanel->setHoursAgo(hours);
         mInventoryView->mActivePanel->setSinceLogoff(getCheckSinceLogoff());
         mInventoryView->setFilterTextFromFilter();
-
-        LLFloater::draw();
 }
 
 void  LLInventoryViewFinder::onClose(bool app_quitting)
@@ -364,17 +407,7 @@ void LLInventoryViewFinder::selectAllTypes(void* user_data)
         self->childSetValue("check_texture", TRUE);
         self->childSetValue("check_snapshot", TRUE);
 
-/*
-        self->mCheckCallingCard->set(TRUE);
-        self->mCheckClothing->set(TRUE);
-        self->mCheckGesture->set(TRUE);
-        self->mCheckLandmark->set(TRUE);
-        self->mCheckNotecard->set(TRUE);
-        self->mCheckObject->set(TRUE);
-        self->mCheckScript->set(TRUE);
-        self->mCheckSound->set(TRUE);
-        self->mCheckTexture->set(TRUE);
-        self->mCheckSnapshot->set(TRUE);*/
+        self->rebuildFilter();
 }
 
 //static
@@ -383,20 +416,6 @@ void LLInventoryViewFinder::selectNoTypes(void* user_data)
         LLInventoryViewFinder* self = (LLInventoryViewFinder*)user_data;
         if(!self) return;
 
-        /*
-        self->childSetValue("check_animation", FALSE);
-        self->mCheckCallingCard->set(FALSE);
-        self->mCheckClothing->set(FALSE);
-        self->mCheckGesture->set(FALSE);
-        self->mCheckLandmark->set(FALSE);
-        self->mCheckNotecard->set(FALSE);
-        self->mCheckObject->set(FALSE);
-        self->mCheckScript->set(FALSE);
-        self->mCheckSound->set(FALSE);
-        self->mCheckTexture->set(FALSE);
-        self->mCheckSnapshot->set(FALSE);*/
-
-
         self->childSetValue("check_animation", FALSE);
         self->childSetValue("check_bodypart", FALSE);
         self->childSetValue("check_calling_card", FALSE);
@@ -409,6 +428,8 @@ void LLInventoryViewFinder::selectNoTypes(void* user_data)
         self->childSetValue("check_sound", FALSE);
         self->childSetValue("check_texture", FALSE);
         self->childSetValue("check_snapshot", FALSE);
+
+        self->rebuildFilter();
 }
 
 
diff --git a/linden/indra/newview/llinventoryview.h b/linden/indra/newview/llinventoryview.h
index 80e5768..c5c8532 100644
--- a/linden/indra/newview/llinventoryview.h
+++ b/linden/indra/newview/llinventoryview.h
@@ -162,14 +162,18 @@ public:
         LLInventoryViewFinder(const std::string& name,
                                                 const LLRect& rect,
                                                 LLInventoryView* inventory_view);
-        virtual void draw();
+        virtual void rebuildFilter();
         virtual void onClose(bool app_quitting);
         void changeFilter(LLInventoryFilter* filter);
         void updateElementsFromFilter();
         BOOL getCheckShowEmpty();
         BOOL getCheckSinceLogoff();
 
+        /** Callback when an inventory type checkbox is changed. */
+        static void onCheckFilterType(LLUICtrl *ctrl, void *user_data);
+
         static void onTimeAgo(LLUICtrl*, void *);
+        static void onCheckShowEmptyFolders(LLUICtrl*, void *);
         static void onCheckSinceLogoff(LLUICtrl*, void *);
         static void onCloseBtn(void* user_data);
         static void selectAllTypes(void* user_data);
diff --git a/linden/indra/newview/llpanelinventory.cpp b/linden/indra/newview/llpanelinventory.cpp
index e41ecdc..7277f05 100644
--- a/linden/indra/newview/llpanelinventory.cpp
+++ b/linden/indra/newview/llpanelinventory.cpp
@@ -146,7 +146,7 @@ public:
         virtual BOOL isUpToDate() const { return TRUE; }
         virtual BOOL hasChildren() const { return FALSE; }
         virtual LLInventoryType::EType getInventoryType() const { return LLInventoryType::IT_NONE; }
-        virtual LLInventoryType::NType getNInventoryType() const { return LLInventoryType::NIT_NONE; }
+        virtual LLInventoryType::NType getNInventoryType() const { return LLInventoryType::NIT_FOLDER; }
         // LLDragAndDropBridge functionality
         virtual BOOL startDrag(EDragAndDropType* type, LLUUID* id) const;
         virtual BOOL dragOrDrop(MASK mask, BOOL drop,