Merge remote branch 'aleric/weekly' into weekly

6 files changed, 39 insertions, 43 deletions

diff --git a/linden/doc/contributions.txt b/linden/doc/contributions.txt
index 1cbc2dd..cd708fd 100644
--- a/linden/doc/contributions.txt
+++ b/linden/doc/contributions.txt
@@ -62,24 +62,29 @@ Aleric Inglewood
         SNOW-766
         SNOW-796
         SNOW-800
-        RED-429
-        RED-552
-        RED-553
-        RED-554
-        RED-556
-        RED-560
-        RED-561
-        RED-562
-        RED-565
-        RED-566
-        RED-567
-        RED-573
-        RED-575
-        RED-576
-        RED-577
-        RED-578
-        RED-579
-        RED-581
+        IMP-429
+        IMP-552
+        IMP-553
+        IMP-554
+        IMP-556
+        IMP-560
+        IMP-561
+        IMP-562
+        IMP-565
+        IMP-566
+        IMP-567
+        IMP-573
+        IMP-575
+        IMP-576
+        IMP-577
+        IMP-578
+        IMP-579
+        IMP-581
+        IMP-660
+        IMP-661
+        IMP-662
+        IMP-663
+        IMP-664
 Alissa Sabre
         VWR-81
         VWR-83
diff --git a/linden/indra/llui/llnotifications.cpp b/linden/indra/llui/llnotifications.cpp
index 2459110..4d3ff46 100644
--- a/linden/indra/llui/llnotifications.cpp
+++ b/linden/indra/llui/llnotifications.cpp
@@ -1190,13 +1190,13 @@ void replaceSubstitutionStrings(LLXMLNodePtr node, StringMap& replacements)
                         if (found != replacements.end())
                         {
                                 replacement = found->second;
-                                //llwarns << "replaceSubstituionStrings: value: " << value << " repl: " << replacement << llendl;
+                                //llinfos << "replaceSubstitutionStrings: value: \"" << value << "\" repl: \"" << replacement << "\"." << llendl;
 
                                 it->second->setValue(replacement);
                         }
                         else
                         {
-                                llwarns << "replaceSubstituionStrings FAILURE: value: " << value << " repl: " << replacement << llendl;
+                                llwarns << "replaceSubstitutionStrings FAILURE: could not find replacement \"" << value << "\"." << llendl;
                         }
                 }
         }
diff --git a/linden/indra/llvfs/llvfs.cpp b/linden/indra/llvfs/llvfs.cpp
index 7df2a81..9bf5b59 100644
--- a/linden/indra/llvfs/llvfs.cpp
+++ b/linden/indra/llvfs/llvfs.cpp
@@ -583,8 +583,9 @@ LLVFS::LLVFS(const std::string& index_filename, const std::string& data_filename
                 }
         }
 
-        LL_WARNS("VFS") << "Using index file " << mIndexFilename << LL_ENDL;
-        LL_WARNS("VFS") << "Using data file " << mDataFilename << LL_ENDL;
+        // Success!
+        LL_INFOS("VFS") << "Using index file " << mIndexFilename << LL_ENDL;
+        LL_INFOS("VFS") << "Using data file " << mDataFilename << LL_ENDL;
 
         mValid = VFSVALID_OK;
 }
diff --git a/linden/indra/newview/llappviewer.cpp b/linden/indra/newview/llappviewer.cpp
index e85abb1..4485cdf 100644
--- a/linden/indra/newview/llappviewer.cpp
+++ b/linden/indra/newview/llappviewer.cpp
@@ -440,8 +440,6 @@ static void settings_to_globals()
         gMapScale = gSavedSettings.getF32("MapScale");
         LLHoverView::sShowHoverTips = gSavedSettings.getBOOL("ShowHoverTips");
 
-        LLCubeMap::sUseCubeMaps = LLFeatureManager::getInstance()->isFeatureAvailable("RenderCubeMap");
-
         LLSlider::setScrollWheelMultiplier( gSavedSettings.getS32("SliderScrollWheelMultiplier") );
 
         LLHUDEffectLookAt::sDebugLookAt = gSavedSettings.getBOOL("PersistShowLookAt");
@@ -779,6 +777,9 @@ bool LLAppViewer::init()
         //
         initWindow();
 
+        // initWindow also initializes the Feature List, so now we can initialize this global.
+        LLCubeMap::sUseCubeMaps = LLFeatureManager::getInstance()->isFeatureAvailable("RenderCubeMap");
+
         {
                 BOOL download = gSavedSettings.getBOOL("DownloadClientTags");
 
@@ -2694,35 +2695,32 @@ void LLAppViewer::initMarkerFile()
         std::string llerror_marker_file = gDirUtilp->getExpandedFilename(LL_PATH_LOGS, LLERROR_MARKER_FILE_NAME);
         std::string error_marker_file = gDirUtilp->getExpandedFilename(LL_PATH_LOGS, ERROR_MARKER_FILE_NAME);
 
-        
         if (LLAPRFile::isExist(mMarkerFileName, LL_APR_RB) && !anotherInstanceRunning())
         {
                 gLastExecEvent = LAST_EXEC_FROZE;
                 LL_INFOS("MarkerFile") << "Exec marker found: program froze on previous execution" << LL_ENDL;
         }    
-    
         if(LLAPRFile::isExist(logout_marker_file, LL_APR_RB))
         {
-                LL_INFOS("MarkerFile") << "Last exec LLError crashed, setting LastExecEvent to " << LAST_EXEC_LLERROR_CRASH << LL_ENDL;
                 gLastExecEvent = LAST_EXEC_LOGOUT_FROZE;
+                LL_INFOS("MarkerFile") << "Last exec LLError crashed, setting LastExecEvent to " << gLastExecEvent << LL_ENDL;
+                LLAPRFile::remove(logout_marker_file);
         }
         if(LLAPRFile::isExist(llerror_marker_file, LL_APR_RB))
         {
-                llinfos << "Last exec LLError crashed, setting LastExecEvent to " << LAST_EXEC_LLERROR_CRASH << llendl;
                 if(gLastExecEvent == LAST_EXEC_LOGOUT_FROZE) gLastExecEvent = LAST_EXEC_LOGOUT_CRASH;
                 else gLastExecEvent = LAST_EXEC_LLERROR_CRASH;
+                LL_INFOS("MarkerFile") << "Last exec LLError crashed, setting LastExecEvent to " << gLastExecEvent << LL_ENDL;
+                LLAPRFile::remove(llerror_marker_file);
         }
         if(LLAPRFile::isExist(error_marker_file, LL_APR_RB))
         {
-                LL_INFOS("MarkerFile") << "Last exec crashed, setting LastExecEvent to " << LAST_EXEC_OTHER_CRASH << LL_ENDL;
                 if(gLastExecEvent == LAST_EXEC_LOGOUT_FROZE) gLastExecEvent = LAST_EXEC_LOGOUT_CRASH;
                 else gLastExecEvent = LAST_EXEC_OTHER_CRASH;
+                LL_INFOS("MarkerFile") << "Last exec crashed, setting LastExecEvent to " << gLastExecEvent << LL_ENDL;
+                LLAPRFile::remove(error_marker_file);
         }
         
-        LLAPRFile::remove(logout_marker_file);
-        LLAPRFile::remove(llerror_marker_file);
-        LLAPRFile::remove(error_marker_file);
-        
         // No new markers if another instance is running.
         if(anotherInstanceRunning()) 
         {
diff --git a/linden/indra/newview/llfeaturemanager.cpp b/linden/indra/newview/llfeaturemanager.cpp
index 35613b7..54da31b 100644
--- a/linden/indra/newview/llfeaturemanager.cpp
+++ b/linden/indra/newview/llfeaturemanager.cpp
@@ -250,11 +250,9 @@ BOOL LLFeatureManager::loadFeatureTables()
         mTableVersion = version;
 
         LLFeatureList *flp = NULL;
-        while (!file.eof() && file.good())
+        while (file >> name)
         {
                 char buffer[MAX_STRING];                 /*Flawfinder: ignore*/
-
-                file >> name;
                 
                 if (name.substr(0,2) == "//")
                 {
@@ -263,13 +261,6 @@ BOOL LLFeatureManager::loadFeatureTables()
                         continue;
                 }
 
-                if (name.empty())
-                {
-                        // This is a blank line
-                        file.getline(buffer, MAX_STRING);
-                        continue;
-                }
-
                 if (name == "list")
                 {
                         if (flp)
diff --git a/linden/indra/newview/skins/default/xui/en-us/notifications.xml b/linden/indra/newview/skins/default/xui/en-us/notifications.xml
index 333e362..c69e792 100644
--- a/linden/indra/newview/skins/default/xui/en-us/notifications.xml
+++ b/linden/indra/newview/skins/default/xui/en-us/notifications.xml
@@ -7008,6 +7008,7 @@ IM history could not be found for [NAME].
  type="alert">
 Show Look At is a debug setting that displays where an avatar's head is looking. Be aware: this will *NOT* show where an avatar's camera is actually pointed. This setting should not be relied on for any form of privacy!
   <usetemplate
+   ignoretext="When setting Show Look At"
    name="okignore"
    yestext="OK"/>
 </notification>