| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously, a command is built by string concatenation. Here, the
distinction between a value and multiple params got lost. Solve this
by using an array for shell arguments. As the escaping is now removed
from the `rrd_gen_graph` function, the canvas style needs to manually
add those quotes to make the JS code still work. That only supports
double-quotes, so hopefully nobody creates a name with a double quote
as that would break the fragile JS command line parser.
Separate the rrdtool options from the rrdtool graph command to make the
`$graph_type == 'canvas'` option work (it would otherwise not understand
the `rrdtool graph - -a PNG` option).
Merge the SVG and PNG cases as they are the same except for the
Content-Type header.
Fix a missing html escape in a debug style.
|
|
|
|
| |
This had nothing to do with an RRD data source.
|
| |
|
|
|
|
|
|
|
|
|
|
| |
From the docs:
"No warning is generated if the variable does not exist. That means empty() is
essentially the concise equivalent to !isset($var) || $var == false."
This reverts commit f2a4593558b3a3ec696e9cc1de93fa898b9521bb.
Reported-By: Benoit Monin (https://github.com/pommi/CGP/commit/f2a4593)
|
| |
|
|\
| |
| | |
Fix undefined index for ds_names in type classes
|
| |
| |
| |
| |
| | |
Fix some potential undefined index errors by using the empty function to
access ds_names in type other than default.
|
|/
|
|
|
| |
Reported-By: Julien Genestoux <julien.genestoux@gmail.com>
(https://github.com/pommi/CGP/issues/24)
|
| |
|
|
|
|
| |
Reported-by: Philipp Hellmich <Philipp.Hellmich@Bertelsmann.de>
|
|
|
|
|
|
|
| |
This problem showed up with IPv6 addresses in the NTP plugin.
Forgotten in commit:
v0.3-51-g330c94f [type: escape colons in filenames used in rrd commandline]
|
|
|
|
| |
this should keep the error.log clean
|
| |
|
|
|
|
|
|
|
| |
A colon ':' in a legend argument will mark the end of the legend:
http://oss.oetiker.ch/rrdtool/doc/rrdgraph_graph.en.html#INOTES_on_legend_arguments
Reported-by: Benjamin Dupuis <poil@quake.fr>
|
| |
|
|
|
|
|
| |
Types GenenericIO and GenericStacked were not included in commit:
596dd7d414 [make rrdfiles using utf8 and spaces work]
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
A constructor is added to the Type_Default class. The constructor will
parse GET values (such as host, plugin, pinstance, type, tinstance,
seconds), create an array of all needed rrd files to generate a graph and
substract identifiers from these rrd files.
Because of the constructor (and related functions) it is not needed to
define an array of tinstances to be grouped and shown in one graph. Also
$obj->args don't have to be defined per plugin. This will result in
smaller plugin files.
The type classes are based on the fact that a plugin has multiple type
instances OR multiple rrd data sources. This is called the source and is
retrieved by rrd_get_sources in each rrd_gen_graph function. Also
variables in function rrd_gen_graph have been renamed to better ones.
|
| |
|
|
|
|
|
| |
There was no cpu graph shown with hosts running a 2.4 kernel, because all
defined cpu states were needed.
|
|
Collectd Graph Panel is a frontend for Collectd written in PHP.
The goal of CGP is to provide an easy-to-use frontend for Collectd,
starting with page that shows an overview of all the hosts you are
managing with Collectd.
In this initial import there is support for the plugins that are default
enabled in Collectd. The supported plugins are located in the plugin
directory.
|