aboutsummaryrefslogtreecommitdiffstatshomepage
path: root/type/Base.class.php (follow)
Commit message (Collapse)AuthorAgeFilesLines
* Provide meaningful filenames for graphsAlexander Meshcheryakov2018-06-201-2/+5
| | | Gives decent default name when saving graph from browser as file and distinguishable tab for tabs showing graph.php output.
* Fixes array_search comparison.david2016-10-051-1/+1
| | | | See http://php.net/manual/en/function.array-search.php for details why this is required.
* Bug fix in get_faded_colorStephen Kent2015-06-221-2/+3
|
* Revert "make detail page accessible when using "canvas" graph_type"Peter Wu2014-12-141-0/+2
| | | | | | | This reverts commit 82d88098f4203cf7402d4faf5ad100cada70efaf. Breaks async rendering, see https://github.com/pommi/CGP/issues/106#issuecomment-66896905
* make detail page accessible when using "canvas" graph_typePim van den Berg2014-11-111-2/+0
| | | | Closes #106
* type/base: allow rrdtool graph -l (lower-limit) to be configured via config ↵Pim van den Berg2014-09-251-1/+4
| | | | | | or plugin json Closes #104
* type/base: escape space character in rrdcached FLUSH commandPim van den Berg2014-09-251-1/+1
| | | | Closes #105
* move " on <HOSTNAME>" suffix in graph title to JSONŁukasz Kostka2014-08-251-2/+2
| | | | Closes #101
* fix rrd_escape() not escaping colonsBrad Jorgensen2014-08-251-1/+1
|
* type/base: fix undefined variable rrd_url when graph_type != canvasPim van den Berg2014-08-101-4/+6
|
* Support customized RRD URLsPeter Wu2014-08-101-3/+9
| | | | | | | | | | | Use case: I would like to bypass PHP for serving the RRD files and allow the webserver (nginx) to compress it to reduce load on the Raspberry Pi. I could go through all kinds of URL rewriting, but it is much easier to set `$CONFIG['rrd_url'] = 'rrd/{file}';` instead and add a corresponding location + alias directive to the nginx configuration. This depends on https://github.com/manuelluis/jsrrdgraph/pull/17 to avoid breaking on '='.
* type/base: stop escaping characters manually since we use escapeshellarg()Pim van den Berg2014-07-231-10/+2
| | | | Closes #89
* type/base: print shellcmd when rrd_graph('debug') is calledPim van den Berg2014-07-211-1/+1
|
* Fix regex for strange datadirsPeter Wu2014-07-201-1/+4
| | | | | If a datadir would contain characters with a special meaning in regex (e.g. `/tmp/logs (new)`), then the function would blow up.
* Display a HTTP error if the command failedPeter Wu2014-07-201-1/+4
| | | | ... for instance, when using an overly large "s" parameter.
* Use a more secure command line building methodPeter Wu2014-07-201-43/+61
| | | | | | | | | | | | | | | | | | | Previously, a command is built by string concatenation. Here, the distinction between a value and multiple params got lost. Solve this by using an array for shell arguments. As the escaping is now removed from the `rrd_gen_graph` function, the canvas style needs to manually add those quotes to make the JS code still work. That only supports double-quotes, so hopefully nobody creates a name with a double quote as that would break the fragile JS command line parser. Separate the rrdtool options from the rrdtool graph command to make the `$graph_type == 'canvas'` option work (it would otherwise not understand the `rrdtool graph - -a PNG` option). Merge the SVG and PNG cases as they are the same except for the Content-Type header. Fix a missing html escape in a debug style.
* Fix type confusionPeter Wu2014-07-201-1/+5
| | | | | | | | | index.php expects that collectd_hosts() always return an array for array_diff. Since an empty array evaluates to FALSE anyway, do not change the type and just return the empty array. In base.php, if no files are returned, the loop is never called and three variables are not initialized. Do it now.
* Defensive programming: more urlencode/htmlentitiesPeter Wu2014-07-201-2/+2
| | | | | | | | | | | | | | | | | | Make build_url return an URL, not HTML. This separates presentation from data. plugin_header's return value is unused, remove the unnecessary return. At places where `printf("<tag att='%s'>", $x);` is used, it is now converted to `printf("<tag att=\"%s\">", htmlentities($x));` since the single quote is not escaped by default by htmlentities. In case the canvas style is used, JS should use `textContent` instead of `innerHTML` to avoid reading `&quot;` instead of `"`. Nobody (should) use(s) IE6 anymore, so it is a safe change. While at it, use the standard charset attribute of meta to specify the character set (UTF-8).
* graph: don't overwrite config rrdtool_opts by rrdtool_opts from json pluginPim van den Berg2014-07-161-4/+6
| | | | Closes #86
* type/default: optionally draw min/max spikes in a lighter color in graphsPim van den Berg2014-07-051-0/+2
| | | | Closes #73
* type/base: replace array_merge by + sign to merge a fallback arrayPim van den Berg2014-06-281-2/+2
| | | | | | | array_merge resets the index, while in case of $this->colors and $this->legend, we'd like to keep the index. An irq plugin sample: array(1 => 1, 'ERR' => 'ERR') must not become array(0 => 1, 'ERR' => 'ERR') after an array_merge.
* add percentile support to network traffic graphsPim van den Berg2014-06-241-0/+1
| | | | | | | Set $CONFIG['percentile'] to a number and a XXth percentile line + legend will be added to all network traffic (if_octets) graphs. Closes #81
* Add base option (1GB=1024Mo)Poil2014-05-181-0/+3
|
* type/base: set default title to "Plugin Type (PluginInstance) (Category)"Pim van den Berg2014-05-121-1/+13
|
* type/base: always use rainbow_colors and overwrite them afterwardsPim van den Berg2014-05-031-3/+4
| | | | | | Since the previous commit [type/base: show tinstances not defined in $this->order in graph] all type instances that are not defined in the plugin, are colored black. This way you always have nice colors.
* type/base: show tinstances not defined in $this->order in graphPim van den Berg2014-05-031-6/+5
| | | | | | Previously if $this->order was defined in a graph, only type instances that were defined in $this->order showed up in the graph. Now it merges $this->order and the type instances.
* rename ds_names and dsname to legendPim van den Berg2014-05-031-13/+13
| | | | This had nothing to do with an RRD data source.
* type/base: set default values for rrd_title and rrd_formatPim van den Berg2014-05-031-1/+2
|
* move collectd_flush function to base classPim van den Berg2014-05-031-0/+70
|
* type: move generic functions to base classPim van den Berg2014-05-031-0/+298
generated by cgit v1.1 at 2025-01-10 17:14:09 +0000