diff options
author | Peter Wu | 2014-07-21 00:11:24 +0200 |
---|---|---|
committer | Peter Wu | 2014-07-21 00:11:24 +0200 |
commit | da067f6df3064c019ae9c22432ccf99a08a84915 (patch) | |
tree | 03fd70b003ac5ef075bfe483f1325171ce5fe2a8 /host.php | |
parent | Fix regex for strange datadirs (diff) | |
download | apt-panopticon_cgp-da067f6df3064c019ae9c22432ccf99a08a84915.zip apt-panopticon_cgp-da067f6df3064c019ae9c22432ccf99a08a84915.tar.gz apt-panopticon_cgp-da067f6df3064c019ae9c22432ccf99a08a84915.tar.bz2 apt-panopticon_cgp-da067f6df3064c019ae9c22432ccf99a08a84915.tar.xz |
Fix overly permissive hostname validation, fix host check
`[\w\W]` matches EVERYTHING. Validation failed. Also remove `\d` as that
`\w` is a superset of it.
Also check that the host parameter is actually non-empty, otherwise
`collectd_plugins` will happily return results as the directory
`$CONFIG['datadir'] . '/' . ''` trivially exists...
Diffstat (limited to 'host.php')
-rw-r--r-- | host.php | 2 |
1 files changed, 1 insertions, 1 deletions
@@ -15,7 +15,7 @@ printf("<fieldset id=\"%s\">", htmlentities($host)); | |||
15 | printf("<legend>%s</legend>", htmlentities($host)); | 15 | printf("<legend>%s</legend>", htmlentities($host)); |
16 | 16 | ||
17 | 17 | ||
18 | if (!$plugins = collectd_plugins($host)) { | 18 | if (!strlen($host) || !$plugins = collectd_plugins($host)) { |
19 | echo "Unknown host\n"; | 19 | echo "Unknown host\n"; |
20 | return false; | 20 | return false; |
21 | } | 21 | } |