New OhSilly Threat level detector, and actually use it.

Tries to work in all case.

1 files changed, 157 insertions, 10 deletions

diff --git a/OhSillyThreatDetector.lsl b/OhSillyThreatDetector.lsl
index 4f17ed6..24b3e43 100644
--- a/OhSillyThreatDetector.lsl
+++ b/OhSillyThreatDetector.lsl
@@ -1,6 +1,6 @@
 
 // Detect when OpenSim reports a function was used that triggered a threat level warning.
-// Coz their official method doesn't work, and often their threat levels are set way too high.
+// Coz their official method doesn't always work, and often their threat levels are set way too high.
 
 // This script will send a link message with number DEBUG_CHANNEL, message being the name of the naughty function, 
 // and key of the prim containing the naughty script.  It's up to the naughty script to catch this link message
@@ -9,12 +9,66 @@
 // Since it sniffs on DEBUG_CHANNEL messages, and a script can't hear any message sent by scripts in the same prim,
 // you'll need to put this script in a prim without the naughty scripts you want to check.
 
+// Naturally it looks as if OpenSim has decided that scripts sniffing DEBUG_CHANNEL is a bad idee now.
+
+// Bits of this where taken from the script at the bottom of http://opensimulator.org/wiki/Threat_level
+
+
+// OSSL Function Availability Tester
+//
+// Demonstrates a method by which a script may determine whether or not it is permitted to call
+// various OSSL functions.
+
+integer WhichProbeFunction; // to tell us which function we're probing
+// OpenSim lies.
+list FunctionNames =
+[
+//    "osAvatarName2Key",         // low          (it fails anyway)
+    "osAvatarPlayAnimation",    // very high
+    "osAvatarStopAnimation",    // very high
+    "osForceOtherSit",          // very high
+//    "osGetAgentIP",             // severe
+//    "osGetAgents",              // none         (it fails anyway)
+    "osGetAvatarList",          // none         (it fails anyway)
+    "osMakeNotecard",           // high         (describes what they where when making this decision)
+    "osGetNotecard",            // very high    (describes what they where when making this decision)
+    "osGetInventoryDesc",       // -
+    "osGetNotecardLine",        // very high    (describes what they where when making this decision)
+    "osGetNumberOfNotecardLines",   // very high
+    "osGetRegionSize",          // -            (it fails anyway)
+    "osGetRezzingObject",       // none         (it fails anyway)
+    "osIsNpc",                  // -            (it fails anyway)
+    "osKey2Name",               // low          (it fails anyway)
+    "osMessageObject",          // low          (it fails anyway)
+    "osNpcSit",                 // high
+    "osSetSpeed",               // moderate
+    "osTeleportAgent"           // severe        (it works anyway)
+];
+list FunctionPermitted = []; // 0 = not permitted, 1 = permitted
+
+startProbe()
+{
+//    llSay(0, "Probing OhSilly threat system to see what OpenSim script functions we are allowed use -");
+    WhichProbeFunction = -1;
+    integer i = llGetListLength(FunctionNames);
+    FunctionPermitted = [];
+    while (i--)
+        FunctionPermitted += [-1];
+    llRemoveInventory("OhSillyThreatCard");
+    llSetTimerEvent(0.25); // check only four functions a second, just to be nice.
+}
+
+// The default state uses the timer to call all the OSSL functions we're interested in using, in turn.
+// If the function call fails, the timer event handler will abend, but the script doesn't crash. We can
+// use this fact to check all of our desired functions in turn, and then pass control to the Running
+// state once we've checked them all.
 default
 {
     state_entry()
     {
-//        llSay(DEBUG_CHANNEL, "G'day, I'm " + llGetKey() + " part of " + llGetLinkKey(LINK_ROOT));
         llListen(DEBUG_CHANNEL, "", NULL_KEY, "");
+//llSay(DEBUG_CHANNEL, "G'day, I'm " + llGetKey() + " part of " + llGetLinkKey(LINK_ROOT)
+// + "\nOpenSim sucks with their OhSilly threat system!");
     }
 
     listen(integer channel, string name, key id, string message)
@@ -28,7 +82,7 @@ default
         /* Threat level errors look like this (at least in OpenSim 0.8.2) -
 OSSL Runtime Error: osSetStateEvents permission denied. Script creator is not in the list of users allowed to execute this function and prim owner also has no permission.
 
-There is also (OpenSim 0.9 at least) -
+There is also (OpenSim 0.9.1 at least) -
 Max Zephyr script
 OSSL Runtime Error: permission denied.  All OS functions are disabled.(script: oc_settings event: changed primID:487baa88-d6e5-420c-b18c-f47f5bbd7de4 at <127.9408, 128.0009, 25.75689>)
 
@@ -42,18 +96,111 @@ From the source (NOTE: first version has no function name) -
 ("{0} permission denied. Script creator is not in the list of users allowed to execute this function and prim owner also has no permission.", function
 ("{0} permission denied. Script permissions error.", function
 
-OpenSim 0.9.0.1 doesn't include the "OSSL Runtime Error: " bit at the beginning anymore.
-OpenSim 0.9.2 seems to not even send it to the DEBUG_CHANNEL for scripts anymore.
+OpenSim 0.9.1 seems to not even send it to the DEBUG_CHANNEL for scripts anymore.
         */
-        if ((llGetLinkKey(LINK_ROOT) == root) && ("OSSL Runtime Error: " == llGetSubString(message, 0, 19)))
+        if (llGetLinkKey(LINK_ROOT) == root)
         {
-            list e = llParseStringKeepNulls(llGetSubString(message, 20, -1), [" "], []);
-//llOwnerSay(llList2String(e, 0));
-            if (("permission" == llList2String(e, 1)) && ("denied" == llList2String(e, 2)))
+            integer f = llSubStringIndex(message, "permission denied. ");
+            if (-1 != f)
             {
+                list e = llParseStringKeepNulls(llGetSubString(message, 0, -f), [" "], []);
                 string function = llList2String(e, 0);
-                llMessageLinked(LINK_SET, DEBUG_CHANNEL, function, id);
+                if (("OSSL" == llList2String(e, 0)) && ("Runtime" == llList2String(e, 1)) && ("Error:" == llList2String(e, 2)))
+                    function = llList2String(e, 3);
+                llMessageLinked(LINK_SET, DEBUG_CHANNEL, function, "0");
+llOwnerSay("Found naughty function " + function);
+                llRegionSay(DEBUG_CHANNEL, "OPENSIM SUCKS!");
             }
         }
     }
+
+    link_message(integer sender, integer num, string message, key id)
+    {
+        if ((DEBUG_CHANNEL == num) && ("OHSILLYPROBE" == message))  startProbe();
+        else
+        {
+            integer f = llListFindList(FunctionNames, [message]);
+            if (-1 != f)
+            {
+                FunctionPermitted = llListReplaceList(FunctionPermitted, [(integer) id], f, f);
+//                llSay(0, "BROKEN " + message + " " + id);
+            }
+        }
+    }
+
+    // As noted above, this script wont hear itself when the below tests dump an error.
+    timer()
+    {
+        string name = llList2String(FunctionNames, ++WhichProbeFunction);
+        string BogusKey = "12345678-1234-1234-1234-123456789abc"; // it doesn't need to be valid
+        if ("" == name)
+        {
+            llSetTimerEvent(0.0); // stop the timer
+            llRemoveInventory("OhSillyThreatCard");
+            string s = "The OpenSim script functions we are allowed to use - ";
+            string t = "The Opensim script functions we are NOT ALLOWED to use - ";
+            integer i = llGetListLength(FunctionNames);
+            while (i--)
+            {
+                integer p = llList2Integer(FunctionPermitted, i);
+                if (-1 == p)  p = 0;
+                llMessageLinked(LINK_SET, DEBUG_CHANNEL, 
+                                llList2String(FunctionNames, i), (string) p);
+                if (p)
+                    s += llList2String(FunctionNames, i) + "()  ";
+                else
+                    t += llList2String(FunctionNames, i) + "()  ";
+            }
+//            llSay(0, s);
+            llSay(0, t);
+            return;
+        }
+//        llOwnerSay("Checking OpenSim function " + name + "()"); // say status
+             if ("osAvatarName2Key" == name)
+            osAvatarName2Key("John", "Smith");
+        else if ("osAvatarPlayAnimation" == name)
+            osAvatarPlayAnimation(BogusKey, BogusKey);
+        else if ("osAvatarStopAnimation" == name)
+            osAvatarStopAnimation(BogusKey, BogusKey);
+        else if ("osForceOtherSit" == name)
+            osForceOtherSit(BogusKey, llGetKey());
+        else if ("osGetAgentIP" == name)
+            osGetAgentIP(BogusKey);
+        else if ("osGetAgents" == name)
+            osGetAgents();
+        else if ("osGetAvatarList" == name)
+            osGetAvatarList();
+        else if ("osMakeNotecard" == name)  // Out of order, so the others have something to read.
+            osMakeNotecard("OhSillyThreatCard", [""]);
+        else if ("osGetNotecard" == name)
+            osGetNotecard("OhSillyThreatCard");
+        else if ("osGetInventoryDesc" == name)
+            osGetInventoryDesc("inventory");
+        else if ("osGetNotecardLine" == name)
+            osGetNotecardLine("OhSillyThreatCard", 0);
+        else if ("osGetNumberOfNotecardLines" == name)
+            osGetNumberOfNotecardLines("OhSillyThreatCard");
+        else if ("osGetRegionSize" == name)
+            osGetRegionSize();
+        else if ("osGetRezzingObject" == name)
+            osGetRezzingObject();
+        else if ("osIsNpc" == name)
+            osIsNpc(BogusKey);
+        else if ("osKey2Name" == name)
+            osKey2Name(BogusKey);
+        else if ("osMessageObject" == name)
+            osMessageObject(llGetKey(), "G'day.");
+        else if ("osNpcSit" == name)
+            osNpcSit(BogusKey, llGetKey(), 0);
+        else if ("osSetSpeed" == name)
+            osSetSpeed(BogusKey, 1.0);
+        else if ("osTeleportAgent" == name)
+            osTeleportAgent(BogusKey, ZERO_VECTOR, ZERO_VECTOR);
+
+        // If we got here, then the timer() handler didn't crash, which means the function it checked for
+        // was actually permitted. So we update the list to indicate that we can use that particular function.
+//        llOwnerSay("Working " + name + "()");
+        if (-1 == llList2Integer(FunctionPermitted, WhichProbeFunction))
+            FunctionPermitted = llListReplaceList(FunctionPermitted, [1], WhichProbeFunction, WhichProbeFunction);
+    }
 }