From d188272462f2c8d3e67aead26bb5b15ab243cdab Mon Sep 17 00:00:00 2001
From: SignpostMarv
Date: Fri, 24 Aug 2012 13:52:30 +0100
Subject: refactoring using List.ConvertAll<string>

---
 .../Region/ScriptEngine/Shared/Api/Implementation/LSL_Api.cs  | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)

(limited to 'OpenSim/Region')

diff --git a/OpenSim/Region/ScriptEngine/Shared/Api/Implementation/LSL_Api.cs b/OpenSim/Region/ScriptEngine/Shared/Api/Implementation/LSL_Api.cs
index 0d275f7..a98fb04 100644
--- a/OpenSim/Region/ScriptEngine/Shared/Api/Implementation/LSL_Api.cs
+++ b/OpenSim/Region/ScriptEngine/Shared/Api/Implementation/LSL_Api.cs
@@ -5170,17 +5170,16 @@ namespace OpenSim.Region.ScriptEngine.Shared.Api
         {
 
             string ret = String.Empty;
-            int    x   = 0;
 
             m_host.AddScriptLPS(1);
 
             if (src.Data.Length > 0)
             {
-                ret = src.Data[x++].ToString();
-                for (; x < src.Data.Length; x++)
-                {
-                    ret += ", "+src.Data[x].ToString();
-                }
+                ret = string.Join(", ", 
+                        (new List<object>(src.Data)).ConvertAll<string>(o => 
+                        {
+                            return o.ToString();
+                        }).ToArray());
             }
 
             return ret;
-- 
cgit v1.1


From 582a256646d1093b2c8889d89dbaa88f1c5fc81d Mon Sep 17 00:00:00 2001
From: SignpostMarv
Date: Fri, 24 Aug 2012 13:53:53 +0100
Subject: immediately returning the string.Join operation instead of checking
 if the list has members

---
 .../ScriptEngine/Shared/Api/Implementation/LSL_Api.cs    | 16 +++++-----------
 1 file changed, 5 insertions(+), 11 deletions(-)

(limited to 'OpenSim/Region')

diff --git a/OpenSim/Region/ScriptEngine/Shared/Api/Implementation/LSL_Api.cs b/OpenSim/Region/ScriptEngine/Shared/Api/Implementation/LSL_Api.cs
index a98fb04..bbbc6cc 100644
--- a/OpenSim/Region/ScriptEngine/Shared/Api/Implementation/LSL_Api.cs
+++ b/OpenSim/Region/ScriptEngine/Shared/Api/Implementation/LSL_Api.cs
@@ -5169,20 +5169,14 @@ namespace OpenSim.Region.ScriptEngine.Shared.Api
         public LSL_String llList2CSV(LSL_List src)
         {
 
-            string ret = String.Empty;
 
             m_host.AddScriptLPS(1);
 
-            if (src.Data.Length > 0)
-            {
-                ret = string.Join(", ", 
-                        (new List<object>(src.Data)).ConvertAll<string>(o => 
-                        {
-                            return o.ToString();
-                        }).ToArray());
-            }
-
-            return ret;
+            return string.Join(", ", 
+                    (new List<object>(src.Data)).ConvertAll<string>(o => 
+                    {
+                        return o.ToString();
+                    }).ToArray());
         }
 
         /// <summary>
-- 
cgit v1.1


From 67477290ad34f7350495c2787022eed5d1d535d8 Mon Sep 17 00:00:00 2001
From: SignpostMarv
Date: Fri, 24 Aug 2012 13:56:42 +0100
Subject: stripping superfluous whitespace

Signed-off-by: Melanie <melanie@t-data.com>
---
 OpenSim/Region/ScriptEngine/Shared/Api/Implementation/LSL_Api.cs | 3 ---
 1 file changed, 3 deletions(-)

(limited to 'OpenSim/Region')

diff --git a/OpenSim/Region/ScriptEngine/Shared/Api/Implementation/LSL_Api.cs b/OpenSim/Region/ScriptEngine/Shared/Api/Implementation/LSL_Api.cs
index bbbc6cc..2bfb9b3 100644
--- a/OpenSim/Region/ScriptEngine/Shared/Api/Implementation/LSL_Api.cs
+++ b/OpenSim/Region/ScriptEngine/Shared/Api/Implementation/LSL_Api.cs
@@ -5165,11 +5165,8 @@ namespace OpenSim.Region.ScriptEngine.Shared.Api
         /// separated list. There is a space after
         /// each comma.
         /// </summary>
-
         public LSL_String llList2CSV(LSL_List src)
         {
-
-
             m_host.AddScriptLPS(1);
 
             return string.Join(", ", 
-- 
cgit v1.1