From 9432f3c94d0b0345132e5ff9eaf966b96cf218c2 Mon Sep 17 00:00:00 2001
From: Diva Canto
Date: Tue, 16 Jul 2013 19:04:30 -0700
Subject: Improvements to the ServiceThrottleModule: added a category and an
 itemid to the interface, so that duplicate requests aren't enqueued more than
 once.

---
 .../ServiceThrottle/ServiceThrottleModule.cs       | 35 ++++++++++++++++------
 .../UserManagement/UserManagementModule.cs         |  2 +-
 2 files changed, 27 insertions(+), 10 deletions(-)

(limited to 'OpenSim/Region/CoreModules')

diff --git a/OpenSim/Region/CoreModules/Framework/ServiceThrottle/ServiceThrottleModule.cs b/OpenSim/Region/CoreModules/Framework/ServiceThrottle/ServiceThrottleModule.cs
index a3ca6d6..1554b3e 100644
--- a/OpenSim/Region/CoreModules/Framework/ServiceThrottle/ServiceThrottleModule.cs
+++ b/OpenSim/Region/CoreModules/Framework/ServiceThrottle/ServiceThrottleModule.cs
@@ -50,17 +50,15 @@ namespace OpenSim.Region.CoreModules.Framework
         private readonly List<Scene> m_scenes = new List<Scene>();
         private System.Timers.Timer m_timer = new System.Timers.Timer();
 
-        //private OpenSim.Framework.BlockingQueue<GridRegionRequest> m_RequestQueue = new OpenSim.Framework.BlockingQueue<GridRegionRequest>();
-        // private OpenSim.Framework.DoubleQueue<GridRegionRequest> m_RequestQueue = new OpenSim.Framework.DoubleQueue<GridRegionRequest>();
-        //private Queue<GridRegionRequest> m_RequestQueue = new Queue<GridRegionRequest>();
         private Queue<Action> m_RequestQueue = new Queue<Action>();
+        private Dictionary<string, List<string>> m_Pending = new Dictionary<string, List<string>>();
         private int m_Interval;
 
         #region ISharedRegionModule
 
         public void Initialise(IConfigSource config)
         {
-            m_Interval = Util.GetConfigVarFromSections<int>(config, "Interval", new string[] { "ServiceThrottle" }, 2000);
+            m_Interval = Util.GetConfigVarFromSections<int>(config, "Interval", new string[] { "ServiceThrottle" }, 5000);
 
             m_timer = new System.Timers.Timer();
             m_timer.AutoReset = false;
@@ -159,18 +157,37 @@ namespace OpenSim.Region.CoreModules.Framework
                     client.SendRegionHandle(regionID, r.RegionHandle);
             };
 
-            lock (m_RequestQueue)
-                m_RequestQueue.Enqueue(action);
-
+            Enqueue("region", regionID.ToString(), action);
         }
 
         #endregion Events
 
         #region IServiceThrottleModule
 
-        public void Enqueue(Action continuation)
+        public void Enqueue(string category, string itemid, Action continuation)
         {
-            m_RequestQueue.Enqueue(continuation);
+            lock (m_RequestQueue)
+            {
+                if (m_Pending.ContainsKey(category))
+                {
+                    if (m_Pending[category].Contains(itemid))
+                        // Don't enqueue, it's already pending
+                        return;
+                }
+                else
+                    m_Pending.Add(category, new List<string>());
+
+                m_Pending[category].Add(itemid);
+
+                m_RequestQueue.Enqueue(delegate
+                {
+                    continuation();
+                    lock (m_RequestQueue)
+                    {
+                        m_Pending[category].Remove(itemid);
+                    }
+                });
+            }
         }
 
         #endregion IServiceThrottleModule
diff --git a/OpenSim/Region/CoreModules/Framework/UserManagement/UserManagementModule.cs b/OpenSim/Region/CoreModules/Framework/UserManagement/UserManagementModule.cs
index e8bdcc9..a91adfa 100644
--- a/OpenSim/Region/CoreModules/Framework/UserManagement/UserManagementModule.cs
+++ b/OpenSim/Region/CoreModules/Framework/UserManagement/UserManagementModule.cs
@@ -173,7 +173,7 @@ namespace OpenSim.Region.CoreModules.Framework.UserManagement
                 }
 
                 // Not found in cache, queue continuation
-                m_ServiceThrottle.Enqueue(delegate
+                m_ServiceThrottle.Enqueue("name", uuid.ToString(),  delegate
                 {
                     //m_log.DebugFormat("[YYY]: Name request {0}", uuid);
                     bool foundRealName = TryGetUserNames(uuid, names);
-- 
cgit v1.1