From 9aec36156eec14d1014af2e5f3c6b0cbff0a87d7 Mon Sep 17 00:00:00 2001
From: BlueWall
Date: Sat, 1 Feb 2014 07:57:04 -0500
Subject: Sync code that has moved in development branch with changes in master

---
 .../Servers/HttpServer/JsonRpcRequestManager.cs    | 86 +++++++++++-----------
 1 file changed, 41 insertions(+), 45 deletions(-)

(limited to 'OpenSim/Framework/Servers/HttpServer')

diff --git a/OpenSim/Framework/Servers/HttpServer/JsonRpcRequestManager.cs b/OpenSim/Framework/Servers/HttpServer/JsonRpcRequestManager.cs
index 1d69dcb..a44f471 100644
--- a/OpenSim/Framework/Servers/HttpServer/JsonRpcRequestManager.cs
+++ b/OpenSim/Framework/Servers/HttpServer/JsonRpcRequestManager.cs
@@ -95,9 +95,12 @@ namespace OpenSim.Framework.Servers.HttpServer
             webRequest.ContentType = "application/json-rpc";
             webRequest.Method = "POST";
             
-            Stream dataStream = webRequest.GetRequestStream();
-            dataStream.Write(content, 0, content.Length);
-            dataStream.Close();
+            //Stream dataStream = webRequest.GetRequestStream();
+            //dataStream.Write(content, 0, content.Length);
+            //dataStream.Close();
+
+            using (Stream dataStream = webRequest.GetRequestStream())
+                dataStream.Write(content, 0, content.Length);
             
             WebResponse webResponse = null;
             try
@@ -111,26 +114,18 @@ namespace OpenSim.Framework.Servers.HttpServer
                 return false;
             }
             
-            Stream rstream = webResponse.GetResponseStream();
-            
-            OSDMap mret = new OSDMap();
-            try
+            using (webResponse)
+            using (Stream rstream = webResponse.GetResponseStream())
             {
-                mret = (OSDMap)OSDParser.DeserializeJson(rstream);
+                OSDMap mret = (OSDMap)OSDParser.DeserializeJson(rstream);
+                        
+                if (mret.ContainsKey("error"))
+                    return false;
+            
+                // get params...
+                OSD.DeserializeMembers(ref parameters, (OSDMap)mret["result"]);
+                return true;
             }
-            catch (Exception e)
-            {
-                m_log.DebugFormat("[JSONRPC]: JsonRpcRequest Error {0}", e.Message);
-                return false;
-            }
-            
-            
-            if (mret.ContainsKey("error"))
-                return false;
-            
-            // get params...
-            OSD.DeserializeMembers(ref parameters, (OSDMap) mret["result"]);
-            return true;
         }
         
         /// <summary>
@@ -171,10 +166,9 @@ namespace OpenSim.Framework.Servers.HttpServer
             webRequest.ContentType = "application/json-rpc";
             webRequest.Method = "POST";
             
-            Stream dataStream = webRequest.GetRequestStream();
-            dataStream.Write(content, 0, content.Length);
-            dataStream.Close();
-            
+            using (Stream dataStream = webRequest.GetRequestStream())
+              dataStream.Write(content, 0, content.Length);
+
             WebResponse webResponse = null;
             try
             {
@@ -187,28 +181,30 @@ namespace OpenSim.Framework.Servers.HttpServer
                 return false;
             }
             
-            Stream rstream = webResponse.GetResponseStream();
-            
-            OSDMap response = new OSDMap();
-            try
-            {
-                response = (OSDMap)OSDParser.DeserializeJson(rstream);
-            }
-            catch (Exception e)
-            {
-                m_log.DebugFormat("[JSONRPC]: JsonRpcRequest Error {0}", e.Message);
-                return false;
-            }
-            
-            if(response.ContainsKey("error"))
+            using (webResponse)
+            using (Stream rstream = webResponse.GetResponseStream())
             {
-                data = response["error"];
-                return false;
+                OSDMap response = new OSDMap();
+                try
+                {
+                    response = (OSDMap)OSDParser.DeserializeJson(rstream);
+                }
+                catch (Exception e)
+                {
+                    m_log.DebugFormat("[JSONRPC]: JsonRpcRequest Error {0}", e.Message);
+                    return false;
+                }
+
+                if (response.ContainsKey("error"))
+                {
+                    data = response["error"];
+                    return false;
+                }
+
+                data = response;            
+
+                return true;
             }
-            
-            data = response;
-            
-            return true;
         }
         #endregion Web Util
     }
-- 
cgit v1.1