From e8442485e635aebc34c6f7e01a6be718b45ff149 Mon Sep 17 00:00:00 2001 From: onefang Date: Tue, 24 Mar 2020 14:05:09 +1000 Subject: TODO-- --- src/sledjchisl/sledjchisl.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/sledjchisl/sledjchisl.c b/src/sledjchisl/sledjchisl.c index bbe5474..ba31722 100644 --- a/src/sledjchisl/sledjchisl.c +++ b/src/sledjchisl/sledjchisl.c @@ -4705,7 +4705,6 @@ jit library is loaded or the JIT compiler will not be activated. char *d; // Doing this here coz at this point we should be the correct user. -// TODO - things like sticky bits. if ((! qfile_exist(scBin)) && (! qfile_mkdir(scBin, S_IRUSR | S_IWUSR | S_IXUSR | S_IRGRP | S_IXGRP, true))) C("Unable to create path %s", scBin); if ((! qfile_exist(scEtc)) && (! qfile_mkdir(scEtc, S_IRUSR | S_IWUSR | S_IXUSR | S_IRGRP | S_IXGRP, true))) C("Unable to create path %s", scEtc); if ((! qfile_exist(scLib)) && (! qfile_mkdir(scLib, S_IRUSR | S_IWUSR | S_IXUSR | S_IRGRP | S_IXGRP, true))) C("Unable to create path %s", scLib); @@ -5181,9 +5180,8 @@ fcgiDone: if (0 != WEXITSTATUS(i)) // No such sesion, create it. { memset(toybuf, 0, sizeof(toybuf)); -// TODO - do the sticky bit thing when we create that directory. // The sudo is only so that the session is owned by opensim, otherwise it's owned by whoever ran this script, which is a likely security hole. - // After the session is created, we rely on the caches directory to be group sticky, so that anyone in the opensim group can attach to the tmux socket. + // After the session is created, we rely on the scRun directory to be group sticky, so that anyone in the opensim group can attach to the tmux socket. snprintf(toybuf, sizeof(toybuf), "sudo -Hu %s %s %s/%s new-session -d -s %s -n '%s' \\; split-window -bhp 50 -t '%s:' bash -c './sledjchisl; cd %s; bash'", scUser, Tcmd, scRun, Tsocket, Tconsole, Ttab, Tconsole, scRoot); -- cgit v1.1