From a863eb9da3eba3644933b7622239dde641e7050c Mon Sep 17 00:00:00 2001
From: Melanie Thielker
Date: Tue, 1 Jun 2010 19:01:21 +0200
Subject: One should not lock null objects.

---
 OpenSim/Region/Framework/Scenes/SceneViewer.cs | 13 ++++++++-----
 1 file changed, 8 insertions(+), 5 deletions(-)

diff --git a/OpenSim/Region/Framework/Scenes/SceneViewer.cs b/OpenSim/Region/Framework/Scenes/SceneViewer.cs
index 5cbd8d9..f478a4a 100644
--- a/OpenSim/Region/Framework/Scenes/SceneViewer.cs
+++ b/OpenSim/Region/Framework/Scenes/SceneViewer.cs
@@ -67,14 +67,14 @@ namespace OpenSim.Region.Framework.Scenes
 
         public void SendPrimUpdates()
         {
-            lock(m_pendingObjects)
+            if (m_pendingObjects == null)
             {
-                if (m_pendingObjects == null)
+                if (!m_presence.IsChildAgent || (m_presence.Scene.m_seeIntoRegionFromNeighbor))
                 {
-                    if (!m_presence.IsChildAgent || (m_presence.Scene.m_seeIntoRegionFromNeighbor))
-                    {
-                        m_pendingObjects = new Queue<SceneObjectGroup>();
+                    m_pendingObjects = new Queue<SceneObjectGroup>();
 
+                    lock(m_pendingObjects)
+                    {
                         foreach (EntityBase e in m_presence.Scene.Entities)
                         {
                             if (e != null && e is SceneObjectGroup)
@@ -82,7 +82,10 @@ namespace OpenSim.Region.Framework.Scenes
                         }
                     }
                 }
+            }
 
+            lock(m_pendingObjects)
+            {
                 while (m_pendingObjects != null && m_pendingObjects.Count > 0)
                 {
                     SceneObjectGroup g = m_pendingObjects.Dequeue();
-- 
cgit v1.1