From 9fb3065d336d1907b5946c30010c9066e99e7597 Mon Sep 17 00:00:00 2001 From: Justin Clark-Casey (justincc) Date: Tue, 9 Sep 2014 18:26:41 +0100 Subject: Temporarily add root agent rez attachments work to job engine if it is running rather than as a fire and forget. Experiment to see if serializing attachment rez and send initial data jobs improves other parts of sim performance. --- OpenSim/Framework/Monitoring/Watchdog.cs | 8 ++++---- OpenSim/Region/Framework/Scenes/ScenePresence.cs | 12 ++++++++---- 2 files changed, 12 insertions(+), 8 deletions(-) diff --git a/OpenSim/Framework/Monitoring/Watchdog.cs b/OpenSim/Framework/Monitoring/Watchdog.cs index b00aa5c..ebbf095 100644 --- a/OpenSim/Framework/Monitoring/Watchdog.cs +++ b/OpenSim/Framework/Monitoring/Watchdog.cs @@ -133,7 +133,7 @@ namespace OpenSim.Framework.Monitoring /// /summary> public static event Action OnWatchdogTimeout; - private static JobEngine m_jobEngine; + public static JobEngine JobEngine { get; private set; } /// /// Is this watchdog active? @@ -175,7 +175,7 @@ namespace OpenSim.Framework.Monitoring static Watchdog() { - m_jobEngine = new JobEngine(); + JobEngine = new JobEngine(); m_threads = new Dictionary(); m_watchdogTimer = new System.Timers.Timer(WATCHDOG_INTERVAL_MS); m_watchdogTimer.AutoReset = false; @@ -463,8 +463,8 @@ namespace OpenSim.Framework.Monitoring return; } - if (m_jobEngine.IsRunning) - m_jobEngine.QueueRequest(name, callback, obj); + if (JobEngine.IsRunning) + JobEngine.QueueRequest(name, callback, obj); else RunInThread(callback, name, obj, log); } diff --git a/OpenSim/Region/Framework/Scenes/ScenePresence.cs b/OpenSim/Region/Framework/Scenes/ScenePresence.cs index 2718785..afe6daa 100644 --- a/OpenSim/Region/Framework/Scenes/ScenePresence.cs +++ b/OpenSim/Region/Framework/Scenes/ScenePresence.cs @@ -1228,10 +1228,14 @@ namespace OpenSim.Region.Framework.Scenes // viewers without (e.g. v1 viewers) will not, so we still need to make this call. if (Scene.AttachmentsModule != null) { - Util.FireAndForget(o => - { - Scene.AttachmentsModule.RezAttachments(this); - }); + if (Watchdog.JobEngine.IsRunning) + Watchdog.RunWhenPossible( + "RezAttachments", + o => Scene.AttachmentsModule.RezAttachments(this), + string.Format("Rez attachments for {0} in {1}", Name, Scene.Name), + null); + else + Util.FireAndForget(o => Scene.AttachmentsModule.RezAttachments(this)); } } else -- cgit v1.1