aboutsummaryrefslogtreecommitdiffstatshomepage
path: root/OpenSim (unfollow)
Commit message (Collapse)AuthorFilesLines
2011-09-06Add temporary debugging in HGInventoryBroker and ↵Justin Clark-Casey (justincc)3-19/+33
RemoveXInventoryServiceConnector This is for http://opensimulator.org/mantis/view.php?id=5669 If we can't retrieve an IUserManagement module we complain, and we also warn in the log when its manually set in XISC by HGInventoryBroker
2011-09-06Lock m_pendingObjects when calling GetPendingObjectsCount().Justin Clark-Casey (justincc)1-1/+2
This is only called by a region console command. We should also be locking m_partsUpdateQueue when dequeueing the next part, or locking m_pendingObjects in QueuePartForUpdate(). However, I won't do this now since I don't have time to analyze how this would affect liveness.
2011-09-06Comment out SceneViewer.Reset() and stop calling from Close() since this is ↵Justin Clark-Casey (justincc)1-16/+17
useless work as a closed scene object is never reset. Strictly speaking, we could also stop bothering to clear the m_updateTimes and m_partsUpdateQueue if we are sure that the whole SceneViewer is shortly to be garbage collected anyway, but we'll leave them around for now.
2011-09-06Comment out unused ISceneViewer.Reset() to reduce code complexityJustin Clark-Casey (justincc)1-1/+1
2011-09-06In SceneViewer, introduce an IsEnabled flag and perform Close() under an ↵Justin Clark-Casey (justincc)2-19/+51
m_pendingObjects lock in order to avoid the race condition seen by danbanner in http://opensimulator.org/mantis/view.php?id=5669
2011-09-06refactor: Make logic in AM.AttachObject() clearer by not reusing existing ↵Justin Clark-Casey (justincc)1-14/+19
variables in different contexts
2011-09-06rename AM.AddSceneObjectAsAttachment() to AddSceneObjectAsNewAttachmentInInvJustin Clark-Casey (justincc)1-3/+3
2011-09-06In SetAttachment, if the existing attachment has no asset id then carry on ↵Justin Clark-Casey (justincc)4-6/+43
rather than abort. When a user logs in, the attachment item ids are pulled from persistence in the Avatars table. However, the asset ids are not saved. When the avatar enters a simulator the attachments are set again. If we simply perform an item check then the asset ids (which are now present) are never set, and NPC attachments later fail unless the attachment is detached and reattached. Hopefully resolves part of http://opensimulator.org/mantis/view.php?id=5653
2011-09-06Get rid of the confusing version of ↵Justin Clark-Casey (justincc)2-25/+2
IAttachmentsModule.RezSingleAttachmentFromInventory() with the updateInventoryStatus switch, since this is never called with false
2011-09-06get rid of the unused AttachmentsModule.ShowAttachInUserInventory()Justin Clark-Casey (justincc)1-28/+0
2011-09-06Stop the pointless double setting of every attachment in AvatarAppearance.Justin Clark-Casey (justincc)3-10/+13
The second was already being filtered out so this has no user level effect
2011-09-05Try disabling the inconsistent attachment state check to see if this ↵Justin Clark-Casey (justincc)3-23/+27
actually has an impact. The code in question is over three years old and just be catching an inconsistency rather than being wholly necessary. This commit still carries out the check and prints all the previous log warnings but a 'failure' no longer prevents avatar region crossing or teleport, and it doesn't give the client the error message. This will have some kind of impact on http://opensimulator.org/mantis/view.php?id=5672
2011-09-05Allow the HGInventoryBroker to set the UserManager when it instantiates a ↵Justin Clark-Casey (justincc)2-3/+15
RemoteXInventoryServiceConnector for a visiting HG user. Not doing this causes NREs whenever that user tries to access inventory when Hypergrid is turned on since the Remote connector does not have a scene (which is only used to fetch the UserManager) Aims to address http://opensimulator.org/mantis/view.php?id=5669
2011-09-03Stop NPCs losing attachments when the source avatar takes them off.Justin Clark-Casey (justincc)7-70/+154
This was happening because we were using the source avatar's item IDs in the clone appearance. Switch to using the asset IDs of attachments instead for NPCs. The InventoryAccessModule and AttachmentModule had to be changed to allow rezzing of an object without an associated inventory item. Hopefully goes some way towards resolving http://opensimulator.org/mantis/view.php?id=5653
2011-09-02Comment out Scene.CleanDroppedAttachments() and calls.Justin Clark-Casey (justincc)2-37/+37
This method wasn't actually doing anything since dropped attachments retain a PCode of 9. Also, behaviour of dropped attachments in other places appears to be that they persist after avatar logout rather than get deleted.
2011-09-02Remove redundant RootPart.CreatedSelected = true in IAM.RezObject() since ↵Justin Clark-Casey (justincc)1-2/+0
this is done through parts iteration
2011-09-02Go back to resetting the State parameter for all parts of a SOG when ↵Justin Clark-Casey (justincc)2-5/+14
SOG.ClearPartAttachmentData() is called. Even though we don't use these on rez they are still present after an unlink, after which selecting them causes various viewers to crash Hopefully really does address http://opensimulator.org/mantis/view.php?id=5664
2011-09-02stop passing FromUserInventoryItemID right down into the deserializer.Justin Clark-Casey (justincc)3-30/+7
the code becomes simpler if this is set from the outside - only one place needs to do this.
2011-09-02Move more of IAM.RezObject() into DoPreRezWhenFromItem()Justin Clark-Casey (justincc)2-27/+29
2011-09-02move more of IAM.RezObject() into DoPreRezWhenFromItem()Justin Clark-Casey (justincc)1-63/+85
2011-09-02factor out a section of IAM.RezObject() into DoPreRezWhenFromItem()Justin Clark-Casey (justincc)1-40/+48
2011-09-01refactor: factor out DoPostRezWhenFromItem() from IAM.RezObject()Justin Clark-Casey (justincc)1-3/+8
2011-09-01remove the pointless m_Scene.GetNewRezLocation() call at the top of ↵Justin Clark-Casey (justincc)1-7/+4
IAM.RezObject() since its always recalculated later on anyway
2011-09-01refactor: Move sanity checks to the top of IAM.RezObject() to make the code ↵Justin Clark-Casey (justincc)1-219/+215
more readable
2011-09-01use group.RootPart in IAM.RezObject() rather than ↵Justin Clark-Casey (justincc)1-1/+1
group.GetChildPart(group.UUID);
2011-09-01Remove pointless NRE check in IAM.RezObject() since this can never occurJustin Clark-Casey (justincc)1-15/+1
2011-09-01Remove code which was automatically deleting non-root prims from scene ↵Justin Clark-Casey (justincc)3-32/+4
objects that had previous been attachments. Looks like this code was accidentally uncommented in e1b5c612 from feb 2010. Appears to resolve the rest of http://opensimulator.org/mantis/view.php?id=5664
2011-09-01If the user receiving an inventory folder has left the scene by the time the ↵Justin Clark-Casey (justincc)1-5/+4
acceptence message arrives, then don't send them an inventory update. Doing so causes a NullReferenceException
2011-09-01refactor: use SOG register target waypoints and rots directly instead of ↵Justin Clark-Casey (justincc)2-24/+6
calling through the SOP, which doesn't make conceptual sense anyway.
2011-09-01Eliminate pointless checks of SOG.RootPart != nullJustin Clark-Casey (justincc)12-205/+119
It's never possible for SOG to have no RootPart, except in the first few picosends of the big bang when it's pulled from region persistence or deserialized
2011-09-01refactor: use ParentGroup.UUID directly instead of SOP.GetRootPartUUID()Justin Clark-Casey (justincc)1-17/+6
2011-09-01Fix issue with llGetTorque() where it would only ever return a zero vector.Justin Clark-Casey (justincc)2-10/+1
2011-09-01Remove pointless cluttering SOP.ParentGroup != null checks.Justin Clark-Casey (justincc)16-424/+274
The only times when ParentGroup might be null is during regression tests (which might not be a valid thing) and when scene objects are being constructed from the database. At all other times it's not possible for a SOP not to have a SOG parent.
2011-08-31Fix a bug where the non-root parts of rezzed objects that had previously ↵Justin Clark-Casey (justincc)1-1/+12
been attachments were sending their old attachment values to the client. The root part state is the canonical value, so always send that instead. Sending conflicting attachments states for non-root parts of a rezzed object is enough to crash the client. Fixes http://opensimulator.org/mantis/view.php?id=5664. Many thanks to mewtwo0641 for some fantastic qa work on this one.
2011-08-31Don't set a GridUser entry for NPCs.Justin Clark-Casey (justincc)1-1/+4
Resolves http://opensimulator.org/mantis/view.php?id=5665
2011-08-31move common code into AttachmentsModule.DeleteAttachmentsFromScene()Justin Clark-Casey (justincc)6-25/+37
2011-08-31If a FireAndForget thread terminates with an exception, then catch and log ↵Justin Clark-Casey (justincc)1-1/+15
rather than letting it terminate the simulator. Exceptions don't appear to do this with the SmartThreadPool but they do with UnsafeQueueUserWorkItem (and maybe others)
2011-08-31refactor: move multiple class to set avatar height into associated ↵Justin Clark-Casey (justincc)2-17/+3
SP.AddToPhysicalScene()
2011-08-31get rid of appearance null checks - this is never nullJustin Clark-Casey (justincc)3-35/+17
2011-08-31In WorldCommModule, replace the useless Attachments == null check with ↵Justin Clark-Casey (justincc)1-2/+1
Attachments.Count == 0 instead
2011-08-31minor: remove mono compiler warningJustin Clark-Casey (justincc)1-1/+1
2011-08-31remove pointless m_attachments == null check since this field is never nullJustin Clark-Casey (justincc)1-1/+1
2011-08-31minor: seal up another instance of using the appearance list without lockingJustin Clark-Casey (justincc)2-2/+3
2011-08-31Make SP.Attachments available as sp.GetAttachments() instead.Justin Clark-Casey (justincc)7-72/+98
The approach here, as in other parts of OpenSim, is to return a copy of the list rather than the attachments list itself This prevents callers from forgetting to lock the list when they read it, as was happening in various parts of the codebase. It also improves liveness. This might improve attachment anomolies when performing region crossings.
2011-08-30remove pointless ToArray() call in AttachmentsModule.SaveChangedAttachments()Justin Clark-Casey (justincc)1-1/+1
2011-08-30minor: remove already processed avatar null check in Scene.RemoveClient()Justin Clark-Casey (justincc)3-6/+1
remove some now duplicated method doc
2011-08-30refactor: move SP.SaveChangedAttachments() fully into AttachmentsModuleJustin Clark-Casey (justincc)5-26/+38
2011-08-30refactor: Move ScenePresence.RezAttachments() into AttachmentsModuleJustin Clark-Casey (justincc)6-47/+103
This adds an incomplete IScenePresence to match ISceneEntity
2011-08-30add Name property to ISceneEntityJustin Clark-Casey (justincc)2-2/+6
2011-08-30refactor: migrate DropObject handling fully into AttachmentsModule from SceneJustin Clark-Casey (justincc)6-30/+17
generated by cgit v1.1 at 2024-08-28 23:58:45 +0000