aboutsummaryrefslogtreecommitdiffstatshomepage
path: root/OpenSim/Region (unfollow)
Commit message (Collapse)AuthorFilesLines
2011-09-03Stop NPCs losing attachments when the source avatar takes them off.Justin Clark-Casey (justincc)5-67/+140
This was happening because we were using the source avatar's item IDs in the clone appearance. Switch to using the asset IDs of attachments instead for NPCs. The InventoryAccessModule and AttachmentModule had to be changed to allow rezzing of an object without an associated inventory item. Hopefully goes some way towards resolving http://opensimulator.org/mantis/view.php?id=5653
2011-09-02Comment out Scene.CleanDroppedAttachments() and calls.Justin Clark-Casey (justincc)2-37/+37
This method wasn't actually doing anything since dropped attachments retain a PCode of 9. Also, behaviour of dropped attachments in other places appears to be that they persist after avatar logout rather than get deleted.
2011-09-02Remove redundant RootPart.CreatedSelected = true in IAM.RezObject() since ↵Justin Clark-Casey (justincc)1-2/+0
this is done through parts iteration
2011-09-02Go back to resetting the State parameter for all parts of a SOG when ↵Justin Clark-Casey (justincc)2-5/+14
SOG.ClearPartAttachmentData() is called. Even though we don't use these on rez they are still present after an unlink, after which selecting them causes various viewers to crash Hopefully really does address http://opensimulator.org/mantis/view.php?id=5664
2011-09-02stop passing FromUserInventoryItemID right down into the deserializer.Justin Clark-Casey (justincc)3-30/+7
the code becomes simpler if this is set from the outside - only one place needs to do this.
2011-09-02Move more of IAM.RezObject() into DoPreRezWhenFromItem()Justin Clark-Casey (justincc)2-27/+29
2011-09-02move more of IAM.RezObject() into DoPreRezWhenFromItem()Justin Clark-Casey (justincc)1-63/+85
2011-09-02factor out a section of IAM.RezObject() into DoPreRezWhenFromItem()Justin Clark-Casey (justincc)1-40/+48
2011-09-01refactor: factor out DoPostRezWhenFromItem() from IAM.RezObject()Justin Clark-Casey (justincc)1-3/+8
2011-09-01remove the pointless m_Scene.GetNewRezLocation() call at the top of ↵Justin Clark-Casey (justincc)1-7/+4
IAM.RezObject() since its always recalculated later on anyway
2011-09-01refactor: Move sanity checks to the top of IAM.RezObject() to make the code ↵Justin Clark-Casey (justincc)1-219/+215
more readable
2011-09-01use group.RootPart in IAM.RezObject() rather than ↵Justin Clark-Casey (justincc)1-1/+1
group.GetChildPart(group.UUID);
2011-09-01Remove pointless NRE check in IAM.RezObject() since this can never occurJustin Clark-Casey (justincc)1-15/+1
2011-09-01Remove code which was automatically deleting non-root prims from scene ↵Justin Clark-Casey (justincc)1-0/+4
objects that had previous been attachments. Looks like this code was accidentally uncommented in e1b5c612 from feb 2010. Appears to resolve the rest of http://opensimulator.org/mantis/view.php?id=5664
2011-09-01If the user receiving an inventory folder has left the scene by the time the ↵Justin Clark-Casey (justincc)1-5/+4
acceptence message arrives, then don't send them an inventory update. Doing so causes a NullReferenceException
2011-09-01refactor: use SOG register target waypoints and rots directly instead of ↵Justin Clark-Casey (justincc)2-24/+6
calling through the SOP, which doesn't make conceptual sense anyway.
2011-09-01Eliminate pointless checks of SOG.RootPart != nullJustin Clark-Casey (justincc)12-205/+119
It's never possible for SOG to have no RootPart, except in the first few picosends of the big bang when it's pulled from region persistence or deserialized
2011-09-01refactor: use ParentGroup.UUID directly instead of SOP.GetRootPartUUID()Justin Clark-Casey (justincc)1-17/+6
2011-09-01Fix issue with llGetTorque() where it would only ever return a zero vector.Justin Clark-Casey (justincc)2-10/+1
2011-09-01Remove pointless cluttering SOP.ParentGroup != null checks.Justin Clark-Casey (justincc)16-424/+274
The only times when ParentGroup might be null is during regression tests (which might not be a valid thing) and when scene objects are being constructed from the database. At all other times it's not possible for a SOP not to have a SOG parent.
2011-08-31Fix a bug where the non-root parts of rezzed objects that had previously ↵Justin Clark-Casey (justincc)1-1/+12
been attachments were sending their old attachment values to the client. The root part state is the canonical value, so always send that instead. Sending conflicting attachments states for non-root parts of a rezzed object is enough to crash the client. Fixes http://opensimulator.org/mantis/view.php?id=5664. Many thanks to mewtwo0641 for some fantastic qa work on this one.
2011-08-31Don't set a GridUser entry for NPCs.Justin Clark-Casey (justincc)1-1/+4
Resolves http://opensimulator.org/mantis/view.php?id=5665
2011-08-31move common code into AttachmentsModule.DeleteAttachmentsFromScene()Justin Clark-Casey (justincc)6-25/+37
2011-08-31refactor: move multiple class to set avatar height into associated ↵Justin Clark-Casey (justincc)2-17/+3
SP.AddToPhysicalScene()
2011-08-31get rid of appearance null checks - this is never nullJustin Clark-Casey (justincc)2-35/+16
2011-08-31In WorldCommModule, replace the useless Attachments == null check with ↵Justin Clark-Casey (justincc)1-2/+1
Attachments.Count == 0 instead
2011-08-31remove pointless m_attachments == null check since this field is never nullJustin Clark-Casey (justincc)1-1/+1
2011-08-31minor: seal up another instance of using the appearance list without lockingJustin Clark-Casey (justincc)2-2/+3
2011-08-31Make SP.Attachments available as sp.GetAttachments() instead.Justin Clark-Casey (justincc)7-72/+98
The approach here, as in other parts of OpenSim, is to return a copy of the list rather than the attachments list itself This prevents callers from forgetting to lock the list when they read it, as was happening in various parts of the codebase. It also improves liveness. This might improve attachment anomolies when performing region crossings.
2011-08-30remove pointless ToArray() call in AttachmentsModule.SaveChangedAttachments()Justin Clark-Casey (justincc)1-1/+1
2011-08-30minor: remove already processed avatar null check in Scene.RemoveClient()Justin Clark-Casey (justincc)3-6/+1
remove some now duplicated method doc
2011-08-30refactor: move SP.SaveChangedAttachments() fully into AttachmentsModuleJustin Clark-Casey (justincc)5-26/+38
2011-08-30refactor: Move ScenePresence.RezAttachments() into AttachmentsModuleJustin Clark-Casey (justincc)6-47/+103
This adds an incomplete IScenePresence to match ISceneEntity
2011-08-30add Name property to ISceneEntityJustin Clark-Casey (justincc)1-2/+5
2011-08-30refactor: migrate DropObject handling fully into AttachmentsModule from SceneJustin Clark-Casey (justincc)5-29/+16
2011-08-30Fix bug where attachments were remaining on the avatar after being dropped.Justin Clark-Casey (justincc)2-6/+20
If the inventory service is configured not to allow deletion then these will not disappear from inventory
2011-08-30Fix bug in persisting saved appearances for npcsJustin Clark-Casey (justincc)6-17/+131
Assets have to be marked non-local as well as non-temporary to persist. This is now done. Hopefully addresses http://opensimulator.org/mantis/view.php?id=5660
2011-08-29Use GetMeshKey from PrimitiveBaseShape.Robert Adams2-15/+23
2011-08-28Move GetMeshKey from buried inside Meshmerizer to a public method on ↵Robert Adams1-62/+1
PrimitiveBaseShape Signed-off-by: BlueWall <jamesh@bluewallgroup.com>
2011-08-28Add level of detail specification to optionally reduce the number of ↵Robert Adams2-5/+42
vertices in generated prim meshes Signed-off-by: BlueWall <jamesh@bluewallgroup.com>
2011-08-27Related to #4689 - Adding missing null check for SceneObjectPartMakopoppo2-4/+18
Signed-off-by: BlueWall <jamesh@bluewallgroup.com>
2011-08-27Stop avatars returning from neighbouring regions from stalling on the border ↵Justin Clark-Casey (justincc)1-3/+22
crossing. On making a root agent, we need to reset the ScenePresence.m_movement_flag so that it doesn't remember the movement registered to the client when it exited the initial region. If this is remember, then the client avatar movement isn't updated and it appears to stall in mid-air, though this is resolved with a prod/release of any other direction key. This bug was probably introduced a few weeks ago. Surprised that nobody brought it up.
2011-08-27Eliminate duplicate AttachmentPoint properties by always using the one ↵Justin Clark-Casey (justincc)4-44/+41
stored in the root part's state field.
2011-08-27refactor: camel case AttachmentPoint method arg as per code standardsJustin Clark-Casey (justincc)1-4/+4
2011-08-27refactor: move SOP.IsAttachment and AttachmentPoint up into SOG to avoid ↵Justin Clark-Casey (justincc)15-109/+81
pointless duplication of identical values
2011-08-26BulletSim: add mesh representation. Use meshes for static objects and switch ↵Robert Adams3-129/+228
to hulls for physical objects.
2011-08-26refactor: simplify SOP.AttachedAvatar into SOG.AttachedAvatarJustin Clark-Casey (justincc)7-27/+26
This does a tiny bit to reduce code complexity, memory requirement and the cpu time of pointlessly setting this field to the same value in every SOP
2011-08-26refactor: move SOG.DetachToGround() to ↵Justin Clark-Casey (justincc)2-41/+35
AttachmentsModule.DetachSceneObjectToGround() and remove redundant code
2011-08-26refactor: simplify DetachSingleAttachmentToGround() by retrieving the scene ↵Justin Clark-Casey (justincc)2-11/+12
object group direct
2011-08-26refactor: remove common presence set up in attachments testsJustin Clark-Casey (justincc)1-32/+38