aboutsummaryrefslogtreecommitdiffstatshomepage
path: root/OpenSim/Region (unfollow)
Commit message (Collapse)AuthorFilesLines
2012-06-29Move update of the final optional ODE total frame stat inside the OdeLock ↵Justin Clark-Casey (justincc)1-3/+3
rather than outside to avoid a very occasional race condition with the stat collection thread
2012-06-29refactor: rename _collisionEventPrim to m_collisionEventActors and ↵Justin Clark-Casey (justincc)1-12/+12
_collisionEventPrimChanges to m_collisionEventActorsChanges to reflect their actual contents. These dictionaries handle all actor types, not just physical prims.
2012-06-29Fix a regression where we stopped removing avatars from collision event ↵Justin Clark-Casey (justincc)1-1/+1
reporting on logout, rather than stopping clearing their collision events. This occurred in b18c8c8 (Thu May 17 2012). This was a cause of very occasional race conditions and likely memory leakage as clients came and went from the region.
2012-06-29Add IScene.Name for code clarity to replace the RegionInfo.RegionName used ↵Justin Clark-Casey (justincc)3-32/+33
in many, many log messages.
2012-06-28Change AttachmentsModule.DetachSingleAttachmentToInv() to accept a SOG ↵Justin Clark-Casey (justincc)5-52/+58
directly instead of an item ID to then shuffle through attachments, saving CPU busywork. Almost all callers already had the sog to hand. Still checking that it's really an attachment, but now by inspecting SOG.AttachedAvatar
2012-06-28Rather than iterating through all SOGs in the scene looking for the one that ↵Justin Clark-Casey (justincc)1-24/+17
matches out fromItemID on detach, go through the agent's attachment sog list instead.
2012-06-28Remove code that tried to delete an attachment back to inventory if ↵Justin Clark-Casey (justincc)1-6/+1
RezSingleAttachmentFromInventoryInternal() returned null. null would only ever be returned if the item couldn't be located within inventory and this would happen immediately. In this case, derezzing wouldn't work anyway since there is no item to derez.
2012-06-28If rest of first line after colon is blank then still warn about running in ↵Justin Clark-Casey (justincc)1-11/+18
XEngine if engine specified does not exist. This is to take account of situations where the user was intending to specify a script engine using colon using its default language. This probably generates few false positive as scripts are less likely to end a first line colon with a comment for other purposes.
2012-06-28Avoid reporting false positives when a colon is in a comment in the first ↵Justin Clark-Casey (justincc)1-17/+41
line of a script where the user was not trying to select a different script engine. This works by only posting the "Selected engine unavailable" message if we're falling back on XEngine and the language is one handled by XEngine. In cases where the language is not handled or not allowed, the user will still be notified by the later compiler error. This avoids the overwhelming majority of false positives where the first line contains a : for other reasons (e.g. source control systems, vim settings, etc.) Ultimately, I think it would be better to detect script language/engine with a mechanism that didn't just rely on : detection (e.g like #! in unix scripts).
2012-06-28minor: reuse colon index calculation in XEngine.OnRezScript. The index if a ↵Justin Clark-Casey (justincc)1-2/+2
colon is found on the first line will always be the same as for the whole script.
2012-06-27Fix issue in InventoryArchiveTestCase where it didn't call down to ↵Justin Clark-Casey (justincc)1-1/+2
OpenSimTestCase.SetUp()
2012-06-27refactor: Move ScenePresence <-> AgentData attachments copying code into ↵Justin Clark-Casey (justincc)4-37/+74
AttachmentsModule.
2012-06-27Automatically disable log4net before each regression test so that logging is ↵Justin Clark-Casey (justincc)2-4/+2
confined to a single test if it's turned on. This involves making test classes inherit from a common OpenSimTestCase. This will be applied to more classes as required.
2012-06-26Replace "kill uuid" console command with the more consistent "delete object ↵Justin Clark-Casey (justincc)1-56/+0
uuid", which was present in the last opensim release.
2012-06-26Fix output for help on some object region console commandsJustin Clark-Casey (justincc)1-3/+6
2012-06-26refactor: Remove unnecessary AttachmentModuleTests.m_userId in favour of ↵Justin Clark-Casey (justincc)1-40/+26
local variables
2012-06-26refactor: Use local attachment module variables instead of global m_attMod.Justin Clark-Casey (justincc)1-11/+10
This also avoids confusion between tests where one sets up m_attMod and another accidentally uses it after failing to set one up itself.
2012-06-26refactor: make m_presence a local variable in all AttachmentsModuleTests ↵Justin Clark-Casey (justincc)1-26/+25
since it doesn't need to be global and some tests set up more than one sp
2012-06-26Add regression test to check that attachments in source region are deleting ↵Justin Clark-Casey (justincc)2-18/+120
when an agent teleports to a neighbouring region
2012-06-26If crossing attachments into another region pre-fatpack, clone objects ↵Justin Clark-Casey (justincc)1-17/+26
before changing properties to avoid hud display race condition with update threads. This matches behaviour in fatpack crossing, where attachments are cloned before their properties are changed. This only applies to crossings to simulators running code released before April 2011.
2012-06-26Add stub for llCastRayBlueWall1-0/+5
2012-06-25minor: update currently commented out log message at top of ↵Justin Clark-Casey (justincc)1-1/+3
AvatarFactoryModule.SetAppearance() for future use
2012-06-25When attachments are being saved and deleted for a closing root agent, ↵Justin Clark-Casey (justincc)4-29/+42
delete first to avoid a hud race condition with update threads. If delete doesn't occur first then the update thread can outrace the IsAttachment = false necessary to save attachments and send hud artifacts to other viewers.
2012-06-25In AttachmentsModule.DetachSingleAttachmentToInvInternal(), remove ↵Justin Clark-Casey (justincc)3-2/+42
attachment before changing properties for correct inventory serialization. Serialization of attachments requires IsAttachment = false so that correct positions are serialized instead of avatar position. However, doing this when a hud is still attached allows race conditions with update threads, resulting in hud artifacts on other viewers. This change sets SOG.IsDeleted before serialization changes take place (IsDeleted itself is not a serialized property). LLClientView then screens out any deleted SOGs before sending updates to viewers.
2012-06-23Fix script "Running" behaviorBlueWall6-0/+53
Unchecking "Running" box in script editor now persists. This fixes http://opensimulator.org/mantis/view.php?id=6057
2012-06-22Resolve various race conditions between accessing and removing external ↵Justin Clark-Casey (justincc)1-132/+148
script URLs by more consistently locking on m_UrlMap
2012-06-22Avoid a race condition where an incoming request to a script external URL ↵Justin Clark-Casey (justincc)1-35/+73
can trigger an exception is the URL was being removed at the same time. This involves three steps 1) Return gracefully in UrlModule.HttpRequestHandler() instead of throwing an exception when the url cannot be found in its index 2) Return true instead of false in HasEvents() if no matching request is found in the map. This call will only happen in the first place for raced requests. 3) Return a 404 in GetEvents() if the request is not in the index, rather than a blank 200 OK. Many thanks to Tom Haines in http://opensimulator.org/mantis/view.php?id=6051 for doing some of the work on this.
2012-06-22Avoid race condition between m_PrimObjects iteration in ↵Justin Clark-Casey (justincc)1-14/+14
XEngine.PostObjectEvent and places where the list is modified by extending the m_PrimObjects lock.
2012-06-22If starting scripts on initial sim start, provide INFO level log feedback ↵Justin Clark-Casey (justincc)1-6/+10
each time 50 scripts have been started. This is to provide an indication of what's happening now that the default isn't to report every single script start. Changes XEngine logging level in OpenSim.exe.config from WARN to INFO.
2012-06-22Eliminate unnecessary extra call to TriggerEmptyScriptCompileQueue in ↵Justin Clark-Casey (justincc)1-9/+2
XEngine.DoOnRezScriptQueue() The later invocation of this function will happen on an empty compile queue.
2012-06-22Stop flicking IsAttachment false and then true in ↵Justin Clark-Casey (justincc)1-10/+0
AttachmentsModule.UpdateAttachmentPosition() in order to avoid a hud update race condition. Previously, setting IsAttachment to false then true was necessary to serialize the updated attachment object information. However, UpdateAttachmentPosition no longer does this update. Whilst IsAttachment is set to false there is a race condition where the update thread can wrongly send hud object updates to clients that do not own the hud, resulting in screen artifacts.
2012-06-22Fix bug where attachments would not retain position if just rotated and not ↵Justin Clark-Casey (justincc)1-0/+5
moved. This was because we were not setting AttachedPos in SOG.UpdateGroupPositionPR, unlike UpdateGroupPosition
2012-06-22refactor AttachmentsModule tests to use a common method for standard ↵Justin Clark-Casey (justincc)1-70/+69
attachment item setup
2012-06-22Add regression test for updating attachment positionJustin Clark-Casey (justincc)1-0/+30
2012-06-21Add item id, name, prim name and id to log message when state exists but ↵Justin Clark-Casey (justincc)1-5/+5
loading fails. Drop logging about memory limit exceeded to warn from error
2012-06-21Retrigger build - last jenkins run was glitchedJustin Clark-Casey (justincc)1-1/+2
2012-06-21Add state file location to errors logged when there's some issue with ↵Justin Clark-Casey (justincc)1-4/+4
retrieving state (e.g. exceeds memory limit)
2012-06-20Use HasPrivateAttachmentPoint properties in SOG.DeleteGroupFromScene() ↵Justin Clark-Casey (justincc)1-2/+3
instead of magic numbers
2012-06-20refactor: use SOG.HasPrivateAttachmentPoint in SOP.SendTerseUpdateToClient() ↵Justin Clark-Casey (justincc)1-2/+3
instead of attachmentpoint magic numbers.
2012-06-20Lower warn logging on not having friends/group module on permissions to debug.Justin Clark-Casey (justincc)1-2/+2
It's a valid configuration not to have these modules, but I think it's still worth logging the fact that certain permissions won't work (always return true)
2012-06-20minor: Lower flotsam asset cache warning about not having a FlotsamCache.ini ↵Justin Clark-Casey (justincc)1-1/+1
to debug It's perfectly okay not to have this section.
2012-06-20Comment out the neighbour and land in connectors from info logging that they ↵Justin Clark-Casey (justincc)2-2/+2
are starting up
2012-06-20Comment out recently added log message detailing number of scripts started ↵Justin Clark-Casey (justincc)1-2/+2
when compile queue empties for now
2012-06-20Raise some IO associated Exception logging in XEngine to error level, in ↵Justin Clark-Casey (justincc)1-7/+5
line with other similar cases. Remove more unnecessary Close() calls - these are being triggered by the Dispose() called when exiting the using statement for these sdk io objects.
2012-06-20Log how many scripts are candidates for starting and how many are actually ↵Justin Clark-Casey (justincc)5-66/+166
started. Adds DebugLevel infrastructure to XEngine though currently commented out and unused.
2012-06-20If RegionReady is active, don't falsely say that logins are enabled in the ↵Justin Clark-Casey (justincc)1-2/+2
main scene loop before RegionReady is signalled when initial script compilation finishes. Also raises this logging level to Info from Debug since this information is of high importance. This matches the behaviour of the RegionReady module
2012-06-20minor: If logging because mesh/sculpt data isn't present for an object, log ↵Justin Clark-Casey (justincc)1-1/+1
object UUID rather than local id, since UUID doesn't potentially vary between simulator starts.
2012-06-19Like the assembly and text files, only write the c#-lsl linemap in ↵Justin Clark-Casey (justincc)1-27/+27
XEngine.SetXMLState() if the trust binaries flag is set. This doesn't affect other locations where the map is written, such as on script compilation.
2012-06-19minor: Add a little more detail to IOException logging in XEngine.SetXMLState()Justin Clark-Casey (justincc)1-11/+14
Also removes superflous Close() commands for statements taking place within using() constructs Also adds some comment out debug log messages for future use.
2012-06-16Change read config paramter from max_urls_per_simulator to ↵Justin Clark-Casey (justincc)1-1/+1
max_external_urls_per_simulator, which is what it was meant to be