aboutsummaryrefslogtreecommitdiffstatshomepage
path: root/OpenSim/Region/Framework (unfollow)
Commit message (Collapse)AuthorFilesLines
2012-07-16Revert "Fix script "Running" behavior"Melanie2-16/+0
A better solution using the already present flags must be found. This reverts commit 6d3ee8bb39d47ed7b32e8905fa0b2fc31c5a9f80.
2012-07-13Don't cache regions data on the other unused LocalGridServiceConnector that ↵Justin Clark-Casey (justincc)1-5/+17
the module code still sets up even if we're using one directly instantiated from the RemoteGridServiceConnector. Also improves log messages to indicate which regions are sending/receiving various neighbour protocol messages.
2012-07-12Change very recent AllowedViewerList and BannedViewerList config setting ↵Justin Clark-Casey (justincc)1-4/+4
names in OpenSim.ini.example to AllowedClients and BannedClients to match long-existing settings in [LoginService] Also changes separator from comma to bar to match existing [LoginService] config features. Divergence of config names for identical facilities in different places makes for an unnecessarily confusing user experience.
2012-07-11Many explanitory comments added to the link and delink code inRobert Adams2-23/+93
SOG and SOP. Should have no functionality changes.
2012-07-11Add regression TestDetachScriptedAttachmentToInventory()Justin Clark-Casey (justincc)2-1/+5
This currently only does a relatively crude check for a ScriptState node in the serialized xml
2012-07-10If a part has a sit target and an avatar is already sitting, allow another ↵Justin Clark-Casey (justincc)1-7/+4
avatar to sit in the position given if no sit target was set. Previous behave was that the second avatar could not sit. This matches behaviour observed on the LL grid.
2012-07-10refactor: move management of SOP.SitTargetAvatar into SOP.AddSittingAvatar() ↵Justin Clark-Casey (justincc)2-5/+6
and SOP.RemoveSittingAvatar()
2012-07-10Revert "refactor: Add SOP.IsSitTargetOccupied to improve readability"Justin Clark-Casey (justincc)2-8/+3
This reverts commit c8f0d476d2f775ba4d7afca12eeff527b46bb8e2. On reconsideration, I think this is less readable since immediately following code still sets SitTargetAvatar directly
2012-07-10refactor: Add SOP.IsSitTargetOccupied to improve readabilityJustin Clark-Casey (justincc)2-3/+8
2012-07-10refactor: use sit orientation argument passed in to SP.SendSitResponse() ↵Justin Clark-Casey (justincc)1-4/+2
rather than creating a new copy There are no issues with side-effects since this is a struct.
2012-07-10Move common code to detect whether a part has a valid sit target into a SOP ↵Justin Clark-Casey (justincc)2-30/+20
property rather than being repeated in SP. This also makes the detection in SP.FindNextAvailableSitTarget() and SendSitResponse() identical. Previously they varied slightly (SendSitResponse didn't check for an older type of invalid quaternion) but the practical effect is most probably zero.
2012-07-10Remove log line accidentally left in SP.SendSitResponse()Justin Clark-Casey (justincc)1-1/+1
2012-07-10Fix recent SOP.GetSittingAvatars() to return null if there are no sitting ↵Justin Clark-Casey (justincc)2-6/+32
avatars rather than throwing an exception. Extends sitting avatar regression tests to test new sitters information
2012-07-10When an attachment is detached to inv or derezzed, stop the scripts, update ↵Justin Clark-Casey (justincc)4-7/+96
the known item with script state still in the script engine and then remove the scripts. This is to fix a regression starting from 5301648 where attachments had to start being deleted before persistence in order to avoid race conditions with hud update threads.
2012-07-09Don't allow a prim to be sat upon if its part of an attachmentJustin Clark-Casey (justincc)1-0/+9
2012-07-09Do not allow a script to attach a prim if its being sat upon.Justin Clark-Casey (justincc)3-8/+122
This prevents a stack overflow where a get position on the avatar will refer to the attachment which will in turn refer back to the avatar. This required recording of all sitting avatars on a prim which is done separately from recording the sit target avatar. Recording HashSet is null if there are no sitting avatars in order to save memory.
2012-07-07Remove redundant SetScene() function in Scene.AddSceneObject()Justin Clark-Casey (justincc)3-15/+3
This is always done later on in SceneGraph.AddSceneObject() if the call hasn't failed due to sanity checks. There's no other purpose for this method to exist and it's dangerous/pointless to call in other conditions.
2012-07-06Remove now duplicate interregion object check that should have been removed ↵Justin Clark-Casey (justincc)1-12/+0
a few commits ago in 43a2da9
2012-07-06Add assert to attachment regression tests to check that number of objects in ↵Justin Clark-Casey (justincc)2-5/+24
the scene graph
2012-07-06Mantis 6063 osNpcTouch.Talun1-0/+8
Allow NPCS to touch obects.
2012-07-06Pull prim crossing/teleport checks up into Scene.IncomingCreateObject() from ↵Justin Clark-Casey (justincc)1-14/+27
Scene.AddObject() Only IncomingCreateObject() needs these checks. General object adding does not need to perform crossing perm checks
2012-07-05Add OSSL function osForceAttachToAvatarFromInventory()Justin Clark-Casey (justincc)5-30/+35
This works like osForceAttachToAvatar() but allows an object to be directly specified from the script object's inventory rather than forcing it to be rezzed in the scene first. Still only attaches objects to the owner of the script. This allows one to bypass the complicated co-ordination of first rezzing objects in the scene before attaching them. Threat level high.
2012-07-03Correct spelling mistake m_BanedViewers to m_BannedViewersJustin Clark-Casey (justincc)1-4/+4
2012-07-03minor: Add some method doc to HasGroupChanged and Schedule ↵Justin Clark-Casey (justincc)1-2/+21
GroupForFull/PartUpdate() to indicate when region modules need to invoke them
2012-07-03Fix issue in database tests where sogs being stored are not in a scene.Justin Clark-Casey (justincc)1-1/+1
This puts an extra m_part.ParentGroup.Scene == null check at the top of SceneObjectPartInventory.QueryScriptStates()
2012-07-02Adds a list of viewers that are allowed or banned from the region.Michelle Argus1-0/+65
Signed-off-by: Melanie <melanie@t-data.com>
2012-07-01Add preservation of running state of scripts when drag-copying.Melanie2-2/+38
2012-06-30Removing unused handling of incoming create object by userID and itemID only.Justin Clark-Casey (justincc)1-22/+0
It appears this was never actually used since attachments were rezzed in other code. This was never available on remote simulator comms, only local.
2012-06-30Remove code listed for removal in 0.7.3 that handled script restart for ↵Justin Clark-Casey (justincc)1-16/+0
incoming attachments from pre-fatpack regions (versions of OpenSimulator more than a year old)
2012-06-29Add IScene.Name for code clarity to replace the RegionInfo.RegionName used ↵Justin Clark-Casey (justincc)2-30/+32
in many, many log messages.
2012-06-28Change AttachmentsModule.DetachSingleAttachmentToInv() to accept a SOG ↵Justin Clark-Casey (justincc)2-3/+7
directly instead of an item ID to then shuffle through attachments, saving CPU busywork. Almost all callers already had the sog to hand. Still checking that it's really an attachment, but now by inspecting SOG.AttachedAvatar
2012-06-27refactor: Move ScenePresence <-> AgentData attachments copying code into ↵Justin Clark-Casey (justincc)3-37/+24
AttachmentsModule.
2012-06-25When attachments are being saved and deleted for a closing root agent, ↵Justin Clark-Casey (justincc)3-17/+21
delete first to avoid a hud race condition with update threads. If delete doesn't occur first then the update thread can outrace the IsAttachment = false necessary to save attachments and send hud artifacts to other viewers.
2012-06-25In AttachmentsModule.DetachSingleAttachmentToInvInternal(), remove ↵Justin Clark-Casey (justincc)1-0/+9
attachment before changing properties for correct inventory serialization. Serialization of attachments requires IsAttachment = false so that correct positions are serialized instead of avatar position. However, doing this when a hud is still attached allows race conditions with update threads, resulting in hud artifacts on other viewers. This change sets SOG.IsDeleted before serialization changes take place (IsDeleted itself is not a serialized property). LLClientView then screens out any deleted SOGs before sending updates to viewers.
2012-06-23Fix script "Running" behaviorBlueWall2-0/+16
Unchecking "Running" box in script editor now persists. This fixes http://opensimulator.org/mantis/view.php?id=6057
2012-06-22Fix bug where attachments would not retain position if just rotated and not ↵Justin Clark-Casey (justincc)1-0/+5
moved. This was because we were not setting AttachedPos in SOG.UpdateGroupPositionPR, unlike UpdateGroupPosition
2012-06-20Use HasPrivateAttachmentPoint properties in SOG.DeleteGroupFromScene() ↵Justin Clark-Casey (justincc)1-2/+3
instead of magic numbers
2012-06-20refactor: use SOG.HasPrivateAttachmentPoint in SOP.SendTerseUpdateToClient() ↵Justin Clark-Casey (justincc)1-2/+3
instead of attachmentpoint magic numbers.
2012-06-20Log how many scripts are candidates for starting and how many are actually ↵Justin Clark-Casey (justincc)4-62/+106
started. Adds DebugLevel infrastructure to XEngine though currently commented out and unused.
2012-06-20If RegionReady is active, don't falsely say that logins are enabled in the ↵Justin Clark-Casey (justincc)1-2/+2
main scene loop before RegionReady is signalled when initial script compilation finishes. Also raises this logging level to Info from Debug since this information is of high importance. This matches the behaviour of the RegionReady module
2012-06-20minor: If logging because mesh/sculpt data isn't present for an object, log ↵Justin Clark-Casey (justincc)1-1/+1
object UUID rather than local id, since UUID doesn't potentially vary between simulator starts.
2012-06-14Add SOG.HasPrivateAttachmentPoint to tell if a SOG has a private attachment ↵Justin Clark-Casey (justincc)2-2/+19
point. HUDs attachment points are private. Change SOP.SendFullUpdateToClient() and SoundModule.PlayAttachedSound() to use this rather than different magic number formulations. This also corrects a bug in PlayAttachedSound() where the code assumed that all attachment points over 30 were HUDs. It appears this is no longer true with Neck and Root (Avatar Center)
2012-06-12OnConnectionClosed listeners, retrieve data from IClientAPI.SceneAgent ↵Justin Clark-Casey (justincc)1-1/+1
rather than scanning all scene for the presence with the right id Stop checking IsLoggingOut on these listeners, if called with a root agent then we always want to perform these actions. This covers cases where the client is closed due to manual kick, simulator shutdown, etc.
2012-06-12In PresenceDetector.OnConnectionClose(), use the IsChildAgent check already ↵Justin Clark-Casey (justincc)1-4/+3
available on IClientAPI.SceneAgent rather than retrieving it again by scanning all scenes.
2012-06-11Comment out the scene presence sitting debug log messages for nowJustin Clark-Casey (justincc)1-6/+6
2012-06-08Don't make duplicate call to ScenePresence.Close() separately in ↵Justin Clark-Casey (justincc)3-81/+74
ETM.DoTeleport() if an agent needs closing. This is always done as part of Scene.RemoveClient() Also refactors try/catching in Scene.RemoveClient() to log NREs instead of silently discarding, since these are useful symptoms of problems.
2012-06-08Go back to calling IncomingCloseAgent() in the "kick user" command for ↵Justin Clark-Casey (justincc)1-6/+0
consistency instead of IClientAPI.Close() directly. This no longer double counts child agent removals
2012-06-08Remove duplicate update of user count in Scene.IncomingCloseAgent()Justin Clark-Casey (justincc)3-14/+27
This is already done in Scene.RemoveClient() which IncomingCloseAgent() always ends up calling.
2012-06-08Fix bug with "kick user" reducing agent counts by 2 instead of 1.Justin Clark-Casey (justincc)2-20/+22
This is done by making the kick user command call IClientAPI.Close() rather than routing through Scene.IncomingCloseAgent(), which also called IClientAPI.Close() DisableSimulator for child agents is moved from IncomingCloseAgent() to RemoveClient(), this is not a functional change since IncomingCloseAgent() always ends up calling RemoveClient()
2012-06-07Record the fact that child agents can have asset transactions.Justin Clark-Casey (justincc)2-23/+18
Also change code to grab the agent asset transaction module once.