aboutsummaryrefslogtreecommitdiffstatshomepage
path: root/OpenSim/Region/Framework (unfollow)
Commit message (Collapse)AuthorFilesLines
2011-08-31remove pointless m_attachments == null check since this field is never nullJustin Clark-Casey (justincc)1-1/+1
2011-08-31minor: seal up another instance of using the appearance list without lockingJustin Clark-Casey (justincc)1-1/+2
2011-08-31Make SP.Attachments available as sp.GetAttachments() instead.Justin Clark-Casey (justincc)2-15/+43
The approach here, as in other parts of OpenSim, is to return a copy of the list rather than the attachments list itself This prevents callers from forgetting to lock the list when they read it, as was happening in various parts of the codebase. It also improves liveness. This might improve attachment anomolies when performing region crossings.
2011-08-30minor: remove already processed avatar null check in Scene.RemoveClient()Justin Clark-Casey (justincc)2-5/+1
remove some now duplicated method doc
2011-08-30refactor: move SP.SaveChangedAttachments() fully into AttachmentsModuleJustin Clark-Casey (justincc)4-26/+20
2011-08-30refactor: Move ScenePresence.RezAttachments() into AttachmentsModuleJustin Clark-Casey (justincc)4-46/+64
This adds an incomplete IScenePresence to match ISceneEntity
2011-08-30add Name property to ISceneEntityJustin Clark-Casey (justincc)1-2/+5
2011-08-30refactor: migrate DropObject handling fully into AttachmentsModule from SceneJustin Clark-Casey (justincc)3-13/+4
2011-08-30Fix bug in persisting saved appearances for npcsJustin Clark-Casey (justincc)2-3/+20
Assets have to be marked non-local as well as non-temporary to persist. This is now done. Hopefully addresses http://opensimulator.org/mantis/view.php?id=5660
2011-08-27Related to #4689 - Adding missing null check for SceneObjectPartMakopoppo2-4/+18
Signed-off-by: BlueWall <jamesh@bluewallgroup.com>
2011-08-27Stop avatars returning from neighbouring regions from stalling on the border ↵Justin Clark-Casey (justincc)1-3/+22
crossing. On making a root agent, we need to reset the ScenePresence.m_movement_flag so that it doesn't remember the movement registered to the client when it exited the initial region. If this is remember, then the client avatar movement isn't updated and it appears to stall in mid-air, though this is resolved with a prod/release of any other direction key. This bug was probably introduced a few weeks ago. Surprised that nobody brought it up.
2011-08-27Eliminate duplicate AttachmentPoint properties by always using the one ↵Justin Clark-Casey (justincc)1-18/+18
stored in the root part's state field.
2011-08-27refactor: move SOP.IsAttachment and AttachmentPoint up into SOG to avoid ↵Justin Clark-Casey (justincc)7-73/+42
pointless duplication of identical values
2011-08-26refactor: simplify SOP.AttachedAvatar into SOG.AttachedAvatarJustin Clark-Casey (justincc)3-10/+14
This does a tiny bit to reduce code complexity, memory requirement and the cpu time of pointlessly setting this field to the same value in every SOP
2011-08-26refactor: move SOG.DetachToGround() to ↵Justin Clark-Casey (justincc)1-40/+6
AttachmentsModule.DetachSceneObjectToGround() and remove redundant code
2011-08-26refactor: simplify DetachSingleAttachmentToGround() by retrieving the scene ↵Justin Clark-Casey (justincc)1-2/+2
object group direct
2011-08-26refactor: move sog.DetachToInventoryPrep() into ↵Justin Clark-Casey (justincc)1-28/+4
AttachmentsModule.DetachSingleAttachmentToInv()
2011-08-24remove pointless IsDeleted check on SP.RezAttachments()Justin Clark-Casey (justincc)1-3/+0
IsDeleted is never set for an SP, even though it's on EntityBase. It might be an idea to set it in the future
2011-08-24refactor: simplify EntityBase.IsDeleted propertyJustin Clark-Casey (justincc)3-10/+5
2011-08-24add SOG helper properties IsPhantom, IsTemporary, etc. to improve code ↵Justin Clark-Casey (justincc)1-20/+46
readability use these in some sog methods
2011-08-24refactor: move Scene.Inventory.attachObjectAssetStore() into ↵Justin Clark-Casey (justincc)1-84/+0
AttachmentsModule.AddSceneObjectAsAttachment()
2011-08-24get rid of pointless grp null check in attachObjectAssetStore()Justin Clark-Casey (justincc)1-73/+69
2011-08-24minor: remove hardcoded region numbers with the region size constant and a ↵Justin Clark-Casey (justincc)1-2/+2
currently hardcoded offset
2011-08-24refactor: remove pointless AgentId argument from attachObjectAssetStore()Justin Clark-Casey (justincc)1-1/+1
2011-08-24Fix llAttachToAvatar()Justin Clark-Casey (justincc)2-12/+33
Apart from one obvious bug, this was failing because attempting to serialize the script from inside the script (as part of saving the attachment as an inventory asset) was triggering an extremely long delay. So we now don't do this. The state will be serialized anyway when the avatar normally logs out. The worst that can happen is that if the client/server crashes, the attachment scripts start without previous state.
2011-08-23rename AttachmentsModule.ShowDetachInUserInventory() to ↵Justin Clark-Casey (justincc)1-15/+7
DetachSingleAttachmentToInv() for consistency and to reflect it's actual behaviour
2011-08-23Remove pointless contains check in ScenePresence.RemoveAttachment()Justin Clark-Casey (justincc)1-6/+1
2011-08-22If an attachment fails, then start logging the exception for now, in order ↵Justin Clark-Casey (justincc)2-6/+4
to help with the inconsistent state bug. This also refactors AttachmentsModules to stop pointlessly refetching the ScenePresence in various methods. However, more of this is required.
2011-08-22Add warning log message to say which attachment fails validation in order to ↵Justin Clark-Casey (justincc)1-0/+10
pin down problems with "Inconsistent Attachment State"
2011-08-22Add ISimulatorFeaturesModule so that other modules can register features in ↵Justin Clark-Casey (justincc)1-0/+43
addition to the hardcoded ones.
2011-08-20Add avatar and attachments to llRegionSayBlueWall1-1/+1
llRegionSay will now message avatars on chan 0 and will message attachments on the avatar that listen on channels other than 0. This behavior is consistant with the LL implementation as tested on regions in Agni with one exception: this implementation does not include issue: https://jira.secondlife.com/browse/SCR-66?
2011-08-19Add llRegionSayToBlueWall1-0/+20
llRegionSayTo(key target, integer channel, string messasge) Allows messages to be sent region-wide to a particular prim.
2011-08-19Fix exception when using BasicPhysicsRobert Adams1-2/+2
2011-08-19Stop NPC's getting hypergrid like names in some circumstances.Justin Clark-Casey (justincc)2-15/+64
This meant punching in another AddUser() method in IUserManagement to do a direct name to UUID associated without the account check (since NPCs don't have accounts). May address http://opensimulator.org/mantis/view.php?id=5645
2011-08-18BulletSim: add runtime setting of physics parameters. Update default values.Robert Adams1-0/+7
2011-08-18refactor: fold CreateSceneViewer() back into ScenePresence constructorJustin Clark-Casey (justincc)1-6/+1
2011-08-18refactor: Fold 3 ScenePresence() constructors into one since only one is called.Justin Clark-Casey (justincc)1-9/+2
2011-08-18Don't try to save changed attachment states when an NPC with attachments is ↵Justin Clark-Casey (justincc)5-12/+20
removed from the scene. This is done by introducing a PresenceType enum into ScenePresence which currently has two values, User and Npc. This seems better than a SaveAttachments flag in terms of code comprehension, though I'm still slightly uneasy about introducing these semantics to core objects
2011-08-17Fix issue where loading a new appearance onto an NPC would not remove the ↵Justin Clark-Casey (justincc)1-1/+2
previous attachments from the scene. Addresses http://opensimulator.org/mantis/view.php?id=5636
2011-08-17Add new regression TestRezAttachmentsOnAvatarEntrance() to do simple ↵Justin Clark-Casey (justincc)1-4/+4
attachments check
2011-08-16get rid of logged warnings about lack of some modules - afaik these never ↵Justin Clark-Casey (justincc)1-10/+0
occur in real life and just clutter up tests
2011-08-16relocate AttachmentTests.cs to AttachmentsModuleTests.csJustin Clark-Casey (justincc)1-172/+0
2011-08-15Added console command "delete object outside" to delete all objects outside ↵Snoopy Pfeffer1-2/+37
region boundaries. This is especiyll useful in cases where physical objects outside regions boundaries cause much physics engine lag.
2011-08-11add regression test for osNpcCreate when cloning an in-region avatarJustin Clark-Casey (justincc)1-2/+2
2011-08-11eliminate redundant ground sitting checks since these are already done in ↵Justin Clark-Casey (justincc)1-4/+1
enclosing control structures
2011-08-11eliminate the rotation parameter from SP.HandleMoveToTargetUpdate(). This ↵Justin Clark-Casey (justincc)1-5/+4
can just use the currently set Rotation looks like I spoke to soon about eliminating jerkiness on "go here"/autopilot. It's still there.
2011-08-11instead of setting avatar rotation twice in SP.HandleAgentUpdate(), ↵Justin Clark-Casey (justincc)1-16/+14
eliminate the second setting in AddNewMovement()
2011-08-11get rid of intermediate local store of body rotation in ScenePresence, this ↵Justin Clark-Casey (justincc)1-5/+4
is not used.
2011-08-11Get NPCs to revert to the correct 'resting' animation (e.g. stand or hover) ↵Justin Clark-Casey (justincc)2-2/+14
after finishing their movement. This also fixes judder after an avatar has finished "go here"/autopilot movement in a viewer. This meant reseting the SP.AgentControlFlags since the Animator uses these to determine the correct default animation.
2011-08-11If SP.MoveToTarget has been called with a force walk, begin by landing the ↵Justin Clark-Casey (justincc)1-1/+3
avatar. There is a bug here - once an avatar has landed it glides to its new position instead of performing a walk animation