aboutsummaryrefslogtreecommitdiffstatshomepage
path: root/OpenSim/Region/Framework (unfollow)
Commit message (Collapse)AuthorFilesLines
2011-12-17Fix bug where objects could not be set to a new group if the group had been ↵Justin Clark-Casey (justincc)4-17/+8
created in that client session, or if no other action has been performed on the object. There were two problems here: 1) On object group update, we looked for the group is the IClientAPI group cache rather than in the groups service. This fails to groups created newly in that session 2) On object group update, we weren't setting the HasGroupChanged flag. This meant that the change was not persisted unless some other action set this flag. This commit fixes these issues and hopefully addresses http://opensimulator.org/mantis/view.php?id=5588 This commit also moves HandleObjectGroupUpdate() to the GroupsModule from the Scene.PacketHandlers.cs file
2011-12-16Changed the async approach on close child agents. This may improve crossings ↵Diva Canto2-7/+7
a little bit.
2011-12-17refactor: simplify methods in Scene.PacketHandlers.cs by using ↵Justin Clark-Casey (justincc)2-142/+81
GetGroupByPrim() rather than retrieving GetEntities() and inspecting the entire list
2011-12-16Stop generating client flags when we send out full object updates.Justin Clark-Casey (justincc)3-27/+10
These were entirely unused.
2011-12-16Don't pass on ChaneWaterHeight event from EventManager is new water height ↵Justin Clark-Casey (justincc)1-0/+6
is less than 0 This is to stop bad values and subsequent viewer crashes. Thanks to Michelle Argus for this patch.
2011-12-16No functional changes. Changed the prefix of that log message [CONNECTION ↵Diva Canto2-15/+15
BEGIN] to [SCENE] because that's where the message happens. Also changed the instantiation of a vector object to be done only once instead of every time we receive a position update.
2011-12-15Stop having to call SetHeight again in ScenePresence.AddToPhysicalScene() ↵Justin Clark-Casey (justincc)1-6/+2
when we've already passed size information to the avatar at PhysicsScene.AddAvatar() Eliminate some copypasta for height setting in OdeCharacter
2011-12-15Code cleanup related to ScenePresence.PhysicsActor and OdeScene/OdeCharacterJustin Clark-Casey (justincc)1-27/+32
Stop hiding RemoveAvatar failure, add log messages when characters are removed through defects or re-added unexpectedly. Add commented out log lines for future use. Use automatic property for PhysicsActor for better code readability and simplicity
2011-12-13Just adding a comment to SendFullUpdatToClientDan Lake1-0/+2
2011-12-13Reorder clearing of upate schedule on SOP to before sending updates. Fix ↵Dan Lake1-11/+3
potential race condition.
2011-12-12Cleaned up ScenePresence parameters for Flying, WasFlying, FlyingOld and ↵Dan Lake4-46/+55
IsColliding
2011-12-09Do some clean up Scene.cs log messages.Justin Clark-Casey (justincc)1-24/+38
This prints out both exception message and stacktrace (Exception.ToString()) isn't enough on Windows. This also uses m_log.*Format() which is more efficient than string concat.
2011-12-09Get rid of IScene.PresenceChildStatus() which always had to execute a lookup ↵Justin Clark-Casey (justincc)3-29/+2
in favour of IClientAPI.ISceneAgent.IsChildAgent instead.
2011-12-09remove some unused fields in ScenePresenceJustin Clark-Casey (justincc)1-4/+0
2011-12-09Move client id check in Scene.Inventory.cs:UpdateInventoryItemAsset so that ↵Justin Clark-Casey (justincc)1-4/+6
it doesn't trigger an exception if the item hasn't been found. In this situation we will now put out a slightly more meaningful log error message instead.
2011-12-08Remove unnecessary AgentCircuitData null check from Scene.AddNewClient().Justin Clark-Casey (justincc)2-12/+5
The only caller is the LLUDP stack and this has to validate the UDP circuit itself, so we know that it exists. This allows us to eliminate another null check elsewhere and simplifies the method contract
2011-12-08minor: remove some mono compiler warningsJustin Clark-Casey (justincc)2-3/+1
2011-12-08When a client connects to a scene, send other avatar appearance data ↵Justin Clark-Casey (justincc)1-6/+6
asynchronously to reduce hold up in the IN UDP packet processing loop. This is already being done for the initial object data send.
2011-12-08On a new client circuit, send the initial reply ack to let the client know ↵Justin Clark-Casey (justincc)4-48/+30
it's live before sending other data. This means that avatar/appearance data of other avatars and scene objects for a client will be sent after the ack rather than possibly before. This may stop some avatars appearing grey on login. This introduces a new OpenSim.Framework.ISceneAgent to accompany the existing OpenSim.Framework.ISceneObject and ISceneEntity This allows IClientAPI to handle this as it can't reference OpenSim.Region.Framework.Interfaces
2011-12-08Simplify Scene.AddNewClient()Justin Clark-Casey (justincc)1-17/+28
If sp becomes null right after we've checked or created it, then behaviour down the line is going to be wrong anyway. So instead retain the check/create ScenePresence reference and use this.
2011-12-07Remove unused SceneManager.TryGetAvatarsScene()Justin Clark-Casey (justincc)1-20/+0
It makes far more sense anyway to use TryGetRootScenePresence().Scene, in common with the rest of the code This method could also return any scene for child or root agents, depending in which order the scenes happened to lie in the list
2011-12-07On an Exception in Scene.RemoveClient(), always remove the client (and SP) ↵Justin Clark-Casey (justincc)1-19/+28
structure so that logout on unexpired packets isn't retriggered, causing the same exception
2011-12-07Implement XMLRPCAdmin command admin_teleport_agent.Justin Clark-Casey (justincc)3-3/+42
This allows someone with access to this command on the XMLRPCAdmin interface to teleport an avatar to an arbitrary region and/or position.
2011-12-05Implement IOSHttpRequest and IOSHttpResponse http interfaces and use instead ↵Justin Clark-Casey (justincc)1-1/+1
of OSHttpRequest/OSHttpResponse. This is required for the substitution of different HTTP servers or the newer HttpServer.dll without having to commit to a particular implementation. This is also required to write regression tests that involve the HTTP layer. If you need to recompile, all you need to do is replace OSHttpRequest/OSHttpResponse references with IOSHttpRequest/IOSHttpResponse.
2011-12-05Fix CHANGED_TEXTURE and CHANGED_COLOR.Melanie1-40/+42
2011-12-03Split up test SceneHelpers to provide an AddChildScenePresence() callJustin Clark-Casey (justincc)1-0/+1
2011-12-03Remove T012_TestAddNeighbourRegion() and T013_TestRemoveNeighbourRegion() ↵Justin Clark-Casey (justincc)1-70/+5
since they don't do anything useful.
2011-12-03Extend TestCreateChildScenePresence to make assertions both at CreateAgent ↵Justin Clark-Casey (justincc)1-0/+16
stage and then at Scene.AddClient()
2011-12-03Add beginning of ScenePresenceAgentTests.TestCreateChildScenePresence()Justin Clark-Casey (justincc)1-11/+46
This required an option to be added to NullRegionData via ConnectionString for it to act as a non-static instance, so that regression tests (which only load this class once) don't get hopeless confused and complex to compensate. Normal standalone operation unaffected.
2011-12-03Use GetAgentCircuits() to receive a copy of the AgentCircuitsByUUID ↵Justin Clark-Casey (justincc)1-4/+2
dictionary rather than AgentCircuitManager.AgentCircuits directly in "show circuits" to avoid enumeration exceptions
2011-12-03Add agent circuit number checks to TestCloseAgent()Justin Clark-Casey (justincc)1-0/+4
2011-12-03Correct SOP.GetNumberOfSides() to return 8 for meshes rather than 7Justin Clark-Casey (justincc)1-7/+5
We are returning the actual number of 'sides', not the maximum index number. Also minor format corrections.
2011-12-03Workaround for mesh to correct the number of faces in GetNumberOfSides(). ↵marc1-1/+9
Meshs are handeled as sculpts but can have up to 8 faces (SL restriction the collada format can handle even more). The patch enables all LSL function that adressing faces to behave correct. Like llGetNumberOfSides(); llSetLinkPrimitiveParamsFast(); llSetPrimitiveParams(); llSetColor(); Signed-off-by: marc <mare@sounddog.net>
2011-12-03Update SP.PhysicsCollisionUpdate() doc.Justin Clark-Casey (justincc)1-2/+5
It might be inefficient, but there are collisions every frame if the avatar is walking/standing on the ground or a prim surface
2011-12-03Add method doc to SP.PhysicsCollisionUpdate() to make it clear that it's ↵Justin Clark-Casey (justincc)1-0/+4
called continuously even where there are no collisions
2011-12-03Add basic TestFlyingAnimation() regression testJustin Clark-Casey (justincc)2-2/+75
2011-12-03Stop calling Animator.UpdateMovementAnimations() at the end of ↵Justin Clark-Casey (justincc)1-2/+2
HandleAgentUpdate(). There's no point doing this if it's being called via PhysicsCollisionUpdate
2011-12-03For now, disable mechanism to limit avatar animation updates since this ↵Justin Clark-Casey (justincc)2-23/+28
causes avatars to never reach the correct animation after some actions. This reverts to situation where animation updates are made each frame on SP.PhysicsCollisionUpdate (though a packet is only sent if the anim actually changes). m_updateCount was not being update on various avatar state changes, causing the correct animations to never be sent. Always setting in HandleAgentUpdate() is not enough since the avatar is continually sending AgentUpdate packets. One would need to identify all the conditions under which animations need to play out and set m_updateCount appropriately in SP.HandleAgentUpdate()
2011-12-03refactor: Use just ScenePresenceAnimator.CurrentMovementAnimation rather ↵Justin Clark-Casey (justincc)1-14/+12
than duplicating it with m_movementAnimation
2011-12-03Do a cagent.Anims != null check in SP.CopyFrom()Justin Clark-Casey (justincc)1-1/+3
2011-12-03Rename ScenePresenceAnimator.GetMovementAnimation() -> ↵Justin Clark-Casey (justincc)1-3/+8
DetermineMovementAnimation() for better code readability
2011-12-03Stop SP.HandleAgentUpdate() and PhysicsCollisionUpdate() from being ↵Justin Clark-Casey (justincc)2-12/+13
processed if we're dealing with a child ScenePresence. Neither of these can have any effect on child agents Now leaving warning about trying to set animation on a child agent active. Might temporarily pop up now and again.
2011-12-02Stop some places where we're trying to reset animations in child agents ↵Justin Clark-Casey (justincc)3-16/+23
where such requests are ignored.
2011-12-02Remove pointless Animator.TrySetMovementAnimation("STAND") in ScenePresnece ↵Justin Clark-Casey (justincc)1-3/+0
constructor. Comment was right - it is indeed useless since SP always starts off as child and TrySetMovementAnimation screens out child SP
2011-11-26minor: formatting changes in Scene.PacketHandlers.csJustin Clark-Casey (justincc)1-5/+5
2011-11-26Rip out unused Scene.HandleFetchInventoryDescendentsCAPS().Justin Clark-Casey (justincc)1-58/+0
This has been handled by WebFetchInvDescHandler.Fetch() for some time.
2011-11-25Use the more extensive Utils.AssetTypeToString()/InventoryTypeToString() ↵Justin Clark-Casey (justincc)1-2/+2
conversion rather than the arrays in TaskInventoryItem
2011-11-24Remove bizarre call to PhysicsScene.Simulate(0) in ↵Justin Clark-Casey (justincc)1-4/+2
Scene.GetNearestAllowedPosition() At least on ODE, this wasn't doing any harm but there wasn't any point to it either
2011-11-24When setting packet level logging via "debug packet", apply to all clients, ↵Justin Clark-Casey (justincc)1-14/+10
not just root ones. Also adds scene name and client type (root|child) to logged information.
2011-11-22Stop an exception being thrown and a teleport/border cross failing if the ↵Justin Clark-Casey (justincc)4-29/+22
desintation sim has no active script engines. This involves getting IScene.RequestModuleInterfaces() to return an empty array (as was stated in the method doc) rather than an array containing one null entry. Callers adjusted to stop checking for the list reference being null (which never happened anyway)