aboutsummaryrefslogtreecommitdiffstatshomepage
path: root/OpenSim/Region/Framework/Scenes/ScenePresence.cs (unfollow)
Commit message (Collapse)AuthorFilesLines
2011-10-07Comment out [SCENE PRESENCE] SendAppearanceToAllOtherAgents: log messageJustin Clark-Casey (justincc)1-1/+1
As per earlier discussions with dslake
2011-10-06Fixed line endings from previous commitDan Lake1-47/+47
2011-10-06Refactored "known child region" in ScenePresence. There were 4 differentDan Lake1-67/+67
ways to access the list/dictionary of child regions and locking was inconsistent. There are now public properties which enforce locks. Callers are no longer required to create new copies of lists.
2011-10-06Simplified IsInTransit property on ScenePresence and removed InTransit() ↵Dan Lake1-11/+10
which called IsInTransit=true which called m_inTransit=true. Also removed NotInTransit().
2011-10-06Refactor ScenePresence so gets and sets are through properties. Added ↵Dan Lake1-287/+288
private sets when needed. Removed redundant code when methods replicated what the set already does
2011-10-06Instead of adding stat agentMS in all kinds of places, calculate it instead ↵Justin Clark-Casey (justincc)1-29/+3
in the main Scene.Update() loop, like the other stats Some of the places where agentMS was added were in separate threads launched by the update loop. I don't believe this is correct, since such threads are no longer contributing to frame time. Some of the places were also driven by client input rather than the scene loop. I don't believe it's appropriate to add this kind of stuff to scene loop stats. These changes hopefully have the nice affect of making the broken out frame stats actually add up to the total frame time
2011-10-01Remove unimplementated UpdateMovement() methods from SOG, SOP.Justin Clark-Casey (justincc)1-1/+1
SP still has an implementation but this is now just a public method on SP rather than an abstract one in EntityBase. No point making the code more complex until it actually needs to be,
2011-09-21Commented out new debug statements in ScenePresenceDan Lake1-5/+5
2011-09-22Reinstate option to land an npc when it reaches a target.Justin Clark-Casey (justincc)1-1/+10
This is moved into ScenePresence for now as a general facility
2011-09-21Remove unused and never set SP.PreviousRotationJustin Clark-Casey (justincc)1-8/+0
2011-09-21get rid of an incredibly noisy logging message from the last commitJustin Clark-Casey (justincc)1-1/+1
2011-09-21When calling osNpcMoveTo(), rotate the avatar in the direction of travel.Justin Clark-Casey (justincc)1-2/+21
This stops the npc walking backwards if the target is directly behind. This means that the npc no longer returns to its original rotation once movement has finished. If you want this behaviour, please store and reset the original rotation after movement. This is somewhat to address http://opensimulator.org/mantis/view.php?id=5678
2011-09-20Make debug statements in ScenePresence consistent and add a few moreDan Lake1-10/+14
2011-09-17On setting a new avatar appearance, if height hasn't changed then don't set ↵Justin Clark-Casey (justincc)1-0/+4
that same height in ScenePresence. This prevents unnecessary work in the ODE module, though possibly that should be checking against same size sets itself
2011-09-16Stop the avatar stalling on its first boarder cross when using the ODE pluginJustin Clark-Casey (justincc)1-0/+10
When upgrading the previously child agent to a root, the code was setting the Size parameter on the ODECharacter PhysicsActor. This in turn reset Velocity, which cause the border stall. I'm fixing this by commenting out the Velocity = Vector3.Zero lines since they don't appear to play a useful purpose
2011-09-16minor: I was wrong about OffsetPosition - sometimes it genuinely does return ↵Justin Clark-Casey (justincc)1-0/+4
offset position! Add method doc to explain this.
2011-09-16Remove setter from SP.OffsetPosition, since all sets should flow through ↵Justin Clark-Casey (justincc)1-3/+14
SP.AbsolutePosition OffsetPosition is also misnamed - it returns the absolute position and never contains an offset.
2011-09-13Don't try and delete attachments for child agent closeJustin Clark-Casey (justincc)1-1/+2
2011-09-12eliminate redundant SP.m_regionInfo since it always has the scene.Justin Clark-Casey (justincc)1-8/+6
We were already referencing through the scene in some places.
2011-09-12remove the unused SP.initializeScenePresence()Justin Clark-Casey (justincc)1-23/+2
2011-09-12stop the redundant passing in of RegionInfo to SceneGraph, since the Scene ↵Justin Clark-Casey (justincc)1-4/+4
is always passed in at the same time.
2011-09-12Start locking entire add/remove operations on an ↵Justin Clark-Casey (justincc)1-0/+4
IScenePresence.AttachmentsSyncLock object Attach and detach packets are processed asynchronously when received from a viewer. Bugs like http://opensimulator.org/mantis/view.php?id=5644 indicate that in some situations (such as attaching/detaching entire folders of objects at once), there are race conditions between these threads. Since multiple data structures need to be updated on attach/detach, it's not enough to lock the individual collections. Therefore, this commit introduces a new IScenePresence.AttachmentsSyncLock which add/remove operations lock on.
2011-09-10lock attachments when enumerating through them in ScenePresence.CopyTo().Justin Clark-Casey (justincc)1-20/+24
May have some effect on http://opensimulator.org/mantis/view.php?id=5644
2011-09-10Add extra log information when attachments fail validationJustin Clark-Casey (justincc)1-1/+9
2011-09-05Try disabling the inconsistent attachment state check to see if this ↵Justin Clark-Casey (justincc)1-9/+7
actually has an impact. The code in question is over three years old and just be catching an inconsistency rather than being wholly necessary. This commit still carries out the check and prints all the previous log warnings but a 'failure' no longer prevents avatar region crossing or teleport, and it doesn't give the client the error message. This will have some kind of impact on http://opensimulator.org/mantis/view.php?id=5672
2011-09-03Stop NPCs losing attachments when the source avatar takes them off.Justin Clark-Casey (justincc)1-3/+0
This was happening because we were using the source avatar's item IDs in the clone appearance. Switch to using the asset IDs of attachments instead for NPCs. The InventoryAccessModule and AttachmentModule had to be changed to allow rezzing of an object without an associated inventory item. Hopefully goes some way towards resolving http://opensimulator.org/mantis/view.php?id=5653
2011-08-31move common code into AttachmentsModule.DeleteAttachmentsFromScene()Justin Clark-Casey (justincc)1-13/+1
2011-08-31refactor: move multiple class to set avatar height into associated ↵Justin Clark-Casey (justincc)1-16/+2
SP.AddToPhysicalScene()
2011-08-31get rid of appearance null checks - this is never nullJustin Clark-Casey (justincc)1-35/+15
2011-08-31remove pointless m_attachments == null check since this field is never nullJustin Clark-Casey (justincc)1-1/+1
2011-08-31minor: seal up another instance of using the appearance list without lockingJustin Clark-Casey (justincc)1-1/+2
2011-08-31Make SP.Attachments available as sp.GetAttachments() instead.Justin Clark-Casey (justincc)1-13/+38
The approach here, as in other parts of OpenSim, is to return a copy of the list rather than the attachments list itself This prevents callers from forgetting to lock the list when they read it, as was happening in various parts of the codebase. It also improves liveness. This might improve attachment anomolies when performing region crossings.
2011-08-30minor: remove already processed avatar null check in Scene.RemoveClient()Justin Clark-Casey (justincc)1-4/+0
remove some now duplicated method doc
2011-08-30refactor: move SP.SaveChangedAttachments() fully into AttachmentsModuleJustin Clark-Casey (justincc)1-24/+1
2011-08-30refactor: Move ScenePresence.RezAttachments() into AttachmentsModuleJustin Clark-Casey (justincc)1-45/+1
This adds an incomplete IScenePresence to match ISceneEntity
2011-08-30Fix bug in persisting saved appearances for npcsJustin Clark-Casey (justincc)1-3/+3
Assets have to be marked non-local as well as non-temporary to persist. This is now done. Hopefully addresses http://opensimulator.org/mantis/view.php?id=5660
2011-08-27Stop avatars returning from neighbouring regions from stalling on the border ↵Justin Clark-Casey (justincc)1-3/+22
crossing. On making a root agent, we need to reset the ScenePresence.m_movement_flag so that it doesn't remember the movement registered to the client when it exited the initial region. If this is remember, then the client avatar movement isn't updated and it appears to stall in mid-air, though this is resolved with a prod/release of any other direction key. This bug was probably introduced a few weeks ago. Surprised that nobody brought it up.
2011-08-27refactor: move SOP.IsAttachment and AttachmentPoint up into SOG to avoid ↵Justin Clark-Casey (justincc)1-4/+4
pointless duplication of identical values
2011-08-24remove pointless IsDeleted check on SP.RezAttachments()Justin Clark-Casey (justincc)1-3/+0
IsDeleted is never set for an SP, even though it's on EntityBase. It might be an idea to set it in the future
2011-08-24refactor: simplify EntityBase.IsDeleted propertyJustin Clark-Casey (justincc)1-1/+1
2011-08-23Remove pointless contains check in ScenePresence.RemoveAttachment()Justin Clark-Casey (justincc)1-6/+1
2011-08-22If an attachment fails, then start logging the exception for now, in order ↵Justin Clark-Casey (justincc)1-1/+1
to help with the inconsistent state bug. This also refactors AttachmentsModules to stop pointlessly refetching the ScenePresence in various methods. However, more of this is required.
2011-08-22Add warning log message to say which attachment fails validation in order to ↵Justin Clark-Casey (justincc)1-0/+10
pin down problems with "Inconsistent Attachment State"
2011-08-18refactor: fold CreateSceneViewer() back into ScenePresence constructorJustin Clark-Casey (justincc)1-6/+1
2011-08-18refactor: Fold 3 ScenePresence() constructors into one since only one is called.Justin Clark-Casey (justincc)1-9/+2
2011-08-18Don't try to save changed attachment states when an NPC with attachments is ↵Justin Clark-Casey (justincc)1-3/+9
removed from the scene. This is done by introducing a PresenceType enum into ScenePresence which currently has two values, User and Npc. This seems better than a SaveAttachments flag in terms of code comprehension, though I'm still slightly uneasy about introducing these semantics to core objects
2011-08-16get rid of logged warnings about lack of some modules - afaik these never ↵Justin Clark-Casey (justincc)1-10/+0
occur in real life and just clutter up tests
2011-08-11eliminate redundant ground sitting checks since these are already done in ↵Justin Clark-Casey (justincc)1-4/+1
enclosing control structures
2011-08-11eliminate the rotation parameter from SP.HandleMoveToTargetUpdate(). This ↵Justin Clark-Casey (justincc)1-5/+4
can just use the currently set Rotation looks like I spoke to soon about eliminating jerkiness on "go here"/autopilot. It's still there.
2011-08-11instead of setting avatar rotation twice in SP.HandleAgentUpdate(), ↵Justin Clark-Casey (justincc)1-16/+14
eliminate the second setting in AddNewMovement()
generated by cgit v1.1 at 2024-09-13 13:50:51 +0000