aboutsummaryrefslogtreecommitdiffstatshomepage
path: root/OpenSim/Region/Framework/Scenes/Scene.cs (unfollow)
Commit message (Collapse)AuthorFilesLines
2012-07-18Close() the ScenePresence after we've removed it from the scene graph, to ↵Justin Clark-Casey (justincc)1-10/+16
cut down race conditions when another thread manages the grab the presence after some SP structures have been reset.
2012-07-12Change very recent AllowedViewerList and BannedViewerList config setting ↵Justin Clark-Casey (justincc)1-4/+4
names in OpenSim.ini.example to AllowedClients and BannedClients to match long-existing settings in [LoginService] Also changes separator from comma to bar to match existing [LoginService] config features. Divergence of config names for identical facilities in different places makes for an unnecessarily confusing user experience.
2012-07-10When an attachment is detached to inv or derezzed, stop the scripts, update ↵Justin Clark-Casey (justincc)1-1/+18
the known item with script state still in the script engine and then remove the scripts. This is to fix a regression starting from 5301648 where attachments had to start being deleted before persistence in order to avoid race conditions with hud update threads.
2012-07-07Remove redundant SetScene() function in Scene.AddSceneObject()Justin Clark-Casey (justincc)1-2/+0
This is always done later on in SceneGraph.AddSceneObject() if the call hasn't failed due to sanity checks. There's no other purpose for this method to exist and it's dangerous/pointless to call in other conditions.
2012-07-06Remove now duplicate interregion object check that should have been removed ↵Justin Clark-Casey (justincc)1-12/+0
a few commits ago in 43a2da9
2012-07-06Add assert to attachment regression tests to check that number of objects in ↵Justin Clark-Casey (justincc)1-0/+11
the scene graph
2012-07-06Pull prim crossing/teleport checks up into Scene.IncomingCreateObject() from ↵Justin Clark-Casey (justincc)1-14/+27
Scene.AddObject() Only IncomingCreateObject() needs these checks. General object adding does not need to perform crossing perm checks
2012-07-03Correct spelling mistake m_BanedViewers to m_BannedViewersJustin Clark-Casey (justincc)1-4/+4
2012-07-02Adds a list of viewers that are allowed or banned from the region.Michelle Argus1-0/+65
Signed-off-by: Melanie <melanie@t-data.com>
2012-06-30Removing unused handling of incoming create object by userID and itemID only.Justin Clark-Casey (justincc)1-22/+0
It appears this was never actually used since attachments were rezzed in other code. This was never available on remote simulator comms, only local.
2012-06-30Remove code listed for removal in 0.7.3 that handled script restart for ↵Justin Clark-Casey (justincc)1-16/+0
incoming attachments from pre-fatpack regions (versions of OpenSimulator more than a year old)
2012-06-29Add IScene.Name for code clarity to replace the RegionInfo.RegionName used ↵Justin Clark-Casey (justincc)1-26/+24
in many, many log messages.
2012-06-25When attachments are being saved and deleted for a closing root agent, ↵Justin Clark-Casey (justincc)1-11/+13
delete first to avoid a hud race condition with update threads. If delete doesn't occur first then the update thread can outrace the IsAttachment = false necessary to save attachments and send hud artifacts to other viewers.
2012-06-20If RegionReady is active, don't falsely say that logins are enabled in the ↵Justin Clark-Casey (justincc)1-2/+2
main scene loop before RegionReady is signalled when initial script compilation finishes. Also raises this logging level to Info from Debug since this information is of high importance. This matches the behaviour of the RegionReady module
2012-06-12In PresenceDetector.OnConnectionClose(), use the IsChildAgent check already ↵Justin Clark-Casey (justincc)1-4/+3
available on IClientAPI.SceneAgent rather than retrieving it again by scanning all scenes.
2012-06-08Don't make duplicate call to ScenePresence.Close() separately in ↵Justin Clark-Casey (justincc)1-79/+70
ETM.DoTeleport() if an agent needs closing. This is always done as part of Scene.RemoveClient() Also refactors try/catching in Scene.RemoveClient() to log NREs instead of silently discarding, since these are useful symptoms of problems.
2012-06-08Remove duplicate update of user count in Scene.IncomingCloseAgent()Justin Clark-Casey (justincc)1-10/+0
This is already done in Scene.RemoveClient() which IncomingCloseAgent() always ends up calling.
2012-06-08Fix bug with "kick user" reducing agent counts by 2 instead of 1.Justin Clark-Casey (justincc)1-14/+17
This is done by making the kick user command call IClientAPI.Close() rather than routing through Scene.IncomingCloseAgent(), which also called IClientAPI.Close() DisableSimulator for child agents is moved from IncomingCloseAgent() to RemoveClient(), this is not a functional change since IncomingCloseAgent() always ends up calling RemoveClient()
2012-06-07Record the fact that child agents can have asset transactions.Justin Clark-Casey (justincc)1-6/+6
Also change code to grab the agent asset transaction module once.
2012-06-07Don't send kill object messages to clients when a child agent is closed.Justin Clark-Casey (justincc)1-18/+21
2012-06-05Start sending spare frame time MS viewer stat. Make frame time correctly ↵Justin Clark-Casey (justincc)1-44/+46
display total frame time, not just non-spare time. This makes it easier to see when components of frame time exceed normal permitted frame time. Currently reflect scene frame times.
2012-06-01Instead of updating sim stats root agent, child, objects and scripts ↵Justin Clark-Casey (justincc)1-5/+0
accounts every single scene frame, update in the once every 3 seconds SimStatsReporter run
2012-05-26If restating a region, clean up the physics scene after the main scene has ↵Justin Clark-Casey (justincc)1-4/+4
been closed not before. If this is done before then on ODE agent update calls still incoming can fail as they try to use a raycastmanager that has been disposed. Bullet plugin does nothing on Dispose() However, I wouldn't be at all surprised if individual region restarting was buggy in lots of other areas.
2012-05-25Stop it being possible for an agent to teleport back to its source region ↵Justin Clark-Casey (justincc)1-3/+3
before the source region has finished cleaning up old agent data and structures. If this is allowed, then the client usually gets forcibly logged out and data structures might be put into bad states. To prevent this, the binary state machine of EMT.m_agentsInTransit is replaced with a 4 state machine (Preparing, Transferring, ReceivedAtDestination, CleaningUp). This is necessary because the source region needs to know when the destination region has received the user but a teleport back cannot happen until the source region has cleaned up. Tested on standalone, grid and with v1 and v3 clients.
2012-05-24If an agent is still registered as 'in transit' by the source region, don't ↵Justin Clark-Casey (justincc)1-21/+46
allow an immediate teleport back. This is to help relieve a race condition when an agent teleports then immediately attempts to teleport back before the source region has properly cleaned up/demoted the old ScenePresence. This is rare in viewers but much more possible via scripting or region module. However, more needs to be done since virtually all clean up happens after the transit flag is cleared . Possibly need to add a 'cleaning up' state to in transit. This change required making the EntityTransferModule and HGEntityTransferModule per-region rather than shared, in order to allow separate transit lists. Changes were also required in LocalSimulationConnector. Tested in standalone, grid and with local and remote region crossings with attachments.
2012-05-23Add "show scene" command which lists stats for the currently selected ↵Justin Clark-Casey (justincc)1-1/+6
console scene(s) This includes prim count, script count, avatar count, etc. Information is currently the same as "show stats", though show stats can only show one scene at a time because it listens for the latest outgoing stats packet (a bad approach that needs to change). Might be better to tie this module into the other stats module to display arbitrary stats rather than fetching directly from scene.SimStatsReporter. Console command is "show scene" because "show region" already exists for the grid service, which is unfortunate. Might need to make a distinction between "scene" relating to a live scene and "region" relating to more static region data (url, coords, etc.)
2012-05-18Further refinement on propertiesBlueWall1-7/+4
2012-05-18Cleanup + change properties to set fields with private set : Thanks Justin ↵BlueWall1-2/+4
for the tip.
2012-05-18Provide Telehub setting to allow use of landmarksBlueWall1-0/+7
Setting to allow use of landmarks to override telehub routing. Default is off.
2012-05-17Check agent limit against root agent count rather than both root and child ↵Justin Clark-Casey (justincc)1-15/+32
agents From sl docs such as http://community.secondlife.com/t5/English-Knowledge-Base/Managing-Private-Regions/ta-p/700115 agent should apply to avatars only. This makes sense from a user perspective, and also from a code perspective since child agents with no physics or actions take up a fraction of root agent resources. As such, the check is now only performed in Scene.QueryAccess() - cross and teleport check this before allowing an agent to translocate. This also removes an off-by-one error that could occur in certain circumstances on teleport when a new child agent was double counted when a pre-teleport agent update was performed. This does not affect an existing bug where limits or other QueryAccess() checks are not applied to avatars logging directly into a region.
2012-05-14minor: comment out individual attachment transfer log messages for nowJustin Clark-Casey (justincc)1-4/+4
2012-05-13Add configurable SpawnPointRoutingBlueWall1-19/+62
Will use one of three selected methods to route avatar landing points when using Telehubs. The setting is in [Startup] using SpawnPointRouting = closest/random/sequence closest: The default setting. Routes avatar to the nearest SpawnPoint to the location. random: Picks random SpawnPoints to land the avatar. sequence: Follows a sequence to place the avatar on the next available SpawnPoint location Conflicts: OpenSim/Region/Framework/Scenes/Scene.cs
2012-05-10Add even for terrain tainting and synchronize terrain module with physics ↵Dan Lake1-7/+8
scene before physics simulation step rather than after
2012-04-27Add regression test for teleporting an agent between separated regions on ↵Justin Clark-Casey (justincc)1-2/+6
the same simulator. This involves a large amount of change in test scene setup code to allow test scenes to share shared modules SetupScene is now an instance method that requires an instantiation of SceneHelpers, though other SceneHelpers methods are still static May split these out into separate classes in the future.
2012-04-26Comment out old Scene.HandleLogOffUserFromGrid() to reduce client closing ↵Justin Clark-Casey (justincc)1-35/+35
analysis complexity
2012-04-26minor: Add avatar name to removing agent log messageJustin Clark-Casey (justincc)1-2/+2
2012-04-25Add a configuration switch to turn on/off the use of the trashMic Bowman1-0/+2
folder when deleting objects from a scene. The use of the trash folder causes assets to be created and stored everytime you delete an object from the scene (slows down the delete and adds mostly useless assets to your database). Default is on (use the trash folder) which is the standard behavior.
2012-04-22Fix bug where setting phantom on a prim would result in a server log message ↵Justin Clark-Casey (justincc)1-9/+5
rather than setting phantom. This was an oversight when removing some race conditions from PhysicsActor setting recently. Regression tests extended to probe this code path. Extending regression tests required implementation of a BasicPhysicsPrim (there was none before). However, BasicPhysics plugin is still of no current practical use other than to fill in as a component for other parts of regression testing.
2012-04-07Store FromItemID for attachments once on SOG instead of on every SOP and ↵Justin Clark-Casey (justincc)1-1/+1
only ever using the root part entry. This eliminates some pointless memory use.
2012-04-03remove possible PhysActor unexpectedly null race conditions when changing ↵Justin Clark-Casey (justincc)1-6/+0
prim collision status factor out common SOP physics scene adding code into a common SOP.AddToPhysics() that is the counterpart to the existing RemoveFromPhysics()
2012-04-03Eliminate race condition where many callers would check SOP.PhysicsActor != ↵Justin Clark-Casey (justincc)1-4/+0
null then assume it was still not null in later code. Another thread could come and turn off physics for a part (null PhysicsActor) at any point. Had to turn off localCopy on warp3D CoreModules section in prebuild.xml since on current nant this copies all DLLs in bin/ which can be a very large number with compiled DLLs No obvious reason for doing that copy - nothing else does it.
2012-03-31refactor: Rename SOG.GetChildPart() to GetPart() since it can also return ↵Justin Clark-Casey (justincc)1-2/+2
the 'root' part.
2012-03-31minor: small message adjustment and unnecessary code elimination when ↵Justin Clark-Casey (justincc)1-1/+1
notifying client of no build permission
2012-03-31fix Infinite loading on No Rez http://opensimulator.org/mantis/view.php?id=5932PixelTomsen1-1/+7
2012-03-29Add back parts of reverted changes that were not concerned with child agent ↵Justin Clark-Casey (justincc)1-0/+4
caching. This adds ScenePresence to IClientAPI.SceneAgent earlier on in the add client process so that its information is available to EventManager.OnNewClient() and OnClientLogin() Also add a code comment as to why we're caching friend information for child agents.
2012-03-29Revert "Simplify friends caching by only doing this for root agents - no ↵Justin Clark-Casey (justincc)1-1/+0
functions require caching for child agents." We need to cache child agents so that friends object edit/delete permissions will work across boarders on regions hosted by different simulators. This reverts commit d9f7b8549b3cb9699eb8bd54242d31aac0f8241a.
2012-03-29Revert "Add comment about setting client.SceneAgent in AddNewClient()"Justin Clark-Casey (justincc)1-3/+0
This reverts commit 964cae4f37120db34d0d3e2f08ab998215237dfd.
2012-03-29Add comment about setting client.SceneAgent in AddNewClient()Justin Clark-Casey (justincc)1-0/+3
2012-03-28Simplify friends caching by only doing this for root agents - no functions ↵Justin Clark-Casey (justincc)1-0/+1
require caching for child agents. This allows us to avoid unnecessary multiple calls to the friends service. All friends functions originate from the root agent and only go to other root agents in existing code. This also allows us to eliminate complex ref counting.
2012-03-27More on switching the root folder from under the viewer. More experiments.Diva Canto1-15/+0