aboutsummaryrefslogtreecommitdiffstatshomepage
path: root/OpenSim/Region/CoreModules (unfollow)
Commit message (Collapse)AuthorFilesLines
2011-09-03Stop NPCs losing attachments when the source avatar takes them off.Justin Clark-Casey (justincc)2-60/+83
This was happening because we were using the source avatar's item IDs in the clone appearance. Switch to using the asset IDs of attachments instead for NPCs. The InventoryAccessModule and AttachmentModule had to be changed to allow rezzing of an object without an associated inventory item. Hopefully goes some way towards resolving http://opensimulator.org/mantis/view.php?id=5653
2011-09-02Comment out Scene.CleanDroppedAttachments() and calls.Justin Clark-Casey (justincc)1-1/+1
This method wasn't actually doing anything since dropped attachments retain a PCode of 9. Also, behaviour of dropped attachments in other places appears to be that they persist after avatar logout rather than get deleted.
2011-09-02Remove redundant RootPart.CreatedSelected = true in IAM.RezObject() since ↵Justin Clark-Casey (justincc)1-2/+0
this is done through parts iteration
2011-09-02Go back to resetting the State parameter for all parts of a SOG when ↵Justin Clark-Casey (justincc)1-5/+8
SOG.ClearPartAttachmentData() is called. Even though we don't use these on rez they are still present after an unlink, after which selecting them causes various viewers to crash Hopefully really does address http://opensimulator.org/mantis/view.php?id=5664
2011-09-02stop passing FromUserInventoryItemID right down into the deserializer.Justin Clark-Casey (justincc)1-4/+2
the code becomes simpler if this is set from the outside - only one place needs to do this.
2011-09-02Move more of IAM.RezObject() into DoPreRezWhenFromItem()Justin Clark-Casey (justincc)1-24/+27
2011-09-02move more of IAM.RezObject() into DoPreRezWhenFromItem()Justin Clark-Casey (justincc)1-63/+85
2011-09-02factor out a section of IAM.RezObject() into DoPreRezWhenFromItem()Justin Clark-Casey (justincc)1-40/+48
2011-09-01refactor: factor out DoPostRezWhenFromItem() from IAM.RezObject()Justin Clark-Casey (justincc)1-3/+8
2011-09-01remove the pointless m_Scene.GetNewRezLocation() call at the top of ↵Justin Clark-Casey (justincc)1-7/+4
IAM.RezObject() since its always recalculated later on anyway
2011-09-01refactor: Move sanity checks to the top of IAM.RezObject() to make the code ↵Justin Clark-Casey (justincc)1-219/+215
more readable
2011-09-01use group.RootPart in IAM.RezObject() rather than ↵Justin Clark-Casey (justincc)1-1/+1
group.GetChildPart(group.UUID);
2011-09-01Remove pointless NRE check in IAM.RezObject() since this can never occurJustin Clark-Casey (justincc)1-15/+1
2011-09-01Remove code which was automatically deleting non-root prims from scene ↵Justin Clark-Casey (justincc)1-0/+4
objects that had previous been attachments. Looks like this code was accidentally uncommented in e1b5c612 from feb 2010. Appears to resolve the rest of http://opensimulator.org/mantis/view.php?id=5664
2011-09-01If the user receiving an inventory folder has left the scene by the time the ↵Justin Clark-Casey (justincc)1-5/+4
acceptence message arrives, then don't send them an inventory update. Doing so causes a NullReferenceException
2011-09-01Eliminate pointless checks of SOG.RootPart != nullJustin Clark-Casey (justincc)2-7/+1
It's never possible for SOG to have no RootPart, except in the first few picosends of the big bang when it's pulled from region persistence or deserialized
2011-09-01Remove pointless cluttering SOP.ParentGroup != null checks.Justin Clark-Casey (justincc)3-33/+24
The only times when ParentGroup might be null is during regression tests (which might not be a valid thing) and when scene objects are being constructed from the database. At all other times it's not possible for a SOP not to have a SOG parent.
2011-08-31Don't set a GridUser entry for NPCs.Justin Clark-Casey (justincc)1-1/+4
Resolves http://opensimulator.org/mantis/view.php?id=5665
2011-08-31move common code into AttachmentsModule.DeleteAttachmentsFromScene()Justin Clark-Casey (justincc)2-5/+11
2011-08-31refactor: move multiple class to set avatar height into associated ↵Justin Clark-Casey (justincc)1-1/+1
SP.AddToPhysicalScene()
2011-08-31In WorldCommModule, replace the useless Attachments == null check with ↵Justin Clark-Casey (justincc)1-2/+1
Attachments.Count == 0 instead
2011-08-31minor: seal up another instance of using the appearance list without lockingJustin Clark-Casey (justincc)1-1/+1
2011-08-31Make SP.Attachments available as sp.GetAttachments() instead.Justin Clark-Casey (justincc)4-50/+52
The approach here, as in other parts of OpenSim, is to return a copy of the list rather than the attachments list itself This prevents callers from forgetting to lock the list when they read it, as was happening in various parts of the codebase. It also improves liveness. This might improve attachment anomolies when performing region crossings.
2011-08-30remove pointless ToArray() call in AttachmentsModule.SaveChangedAttachments()Justin Clark-Casey (justincc)1-1/+1
2011-08-30minor: remove already processed avatar null check in Scene.RemoveClient()Justin Clark-Casey (justincc)1-1/+0
remove some now duplicated method doc
2011-08-30refactor: move SP.SaveChangedAttachments() fully into AttachmentsModuleJustin Clark-Casey (justincc)1-0/+18
2011-08-30refactor: Move ScenePresence.RezAttachments() into AttachmentsModuleJustin Clark-Casey (justincc)1-0/+38
This adds an incomplete IScenePresence to match ISceneEntity
2011-08-30refactor: migrate DropObject handling fully into AttachmentsModule from SceneJustin Clark-Casey (justincc)2-16/+12
2011-08-30Fix bug where attachments were remaining on the avatar after being dropped.Justin Clark-Casey (justincc)2-6/+20
If the inventory service is configured not to allow deletion then these will not disappear from inventory
2011-08-30Fix bug in persisting saved appearances for npcsJustin Clark-Casey (justincc)3-13/+111
Assets have to be marked non-local as well as non-temporary to persist. This is now done. Hopefully addresses http://opensimulator.org/mantis/view.php?id=5660
2011-08-27Eliminate duplicate AttachmentPoint properties by always using the one ↵Justin Clark-Casey (justincc)3-26/+23
stored in the root part's state field.
2011-08-27refactor: camel case AttachmentPoint method arg as per code standardsJustin Clark-Casey (justincc)1-4/+4
2011-08-27refactor: move SOP.IsAttachment and AttachmentPoint up into SOG to avoid ↵Justin Clark-Casey (justincc)4-18/+17
pointless duplication of identical values
2011-08-26refactor: simplify SOP.AttachedAvatar into SOG.AttachedAvatarJustin Clark-Casey (justincc)1-10/+5
This does a tiny bit to reduce code complexity, memory requirement and the cpu time of pointlessly setting this field to the same value in every SOP
2011-08-26refactor: move SOG.DetachToGround() to ↵Justin Clark-Casey (justincc)1-1/+29
AttachmentsModule.DetachSceneObjectToGround() and remove redundant code
2011-08-26refactor: simplify DetachSingleAttachmentToGround() by retrieving the scene ↵Justin Clark-Casey (justincc)1-9/+10
object group direct
2011-08-26refactor: remove common presence set up in attachments testsJustin Clark-Casey (justincc)1-32/+38
2011-08-26comment out verbose test logging from last commitJustin Clark-Casey (justincc)1-1/+1
2011-08-26add regression test for detaching an attachment to the sceneJustin Clark-Casey (justincc)1-0/+33
2011-08-26refactor: move sog.DetachToInventoryPrep() into ↵Justin Clark-Casey (justincc)2-8/+19
AttachmentsModule.DetachSingleAttachmentToInv()
2011-08-26Downgrade warning about not saving unchanged attachment to debug instead, ↵Justin Clark-Casey (justincc)1-1/+4
and change text to better indicate what it's saying
2011-08-26Fix a very recent regression from llAttachToAvatar() fix where I ↵Justin Clark-Casey (justincc)1-5/+1
accidentally stopped normal script state persistence on login/logout and attach/detach
2011-08-24Remove forcing of phantom on ground attached objects - attachments can be ↵Justin Clark-Casey (justincc)2-5/+0
both non-phantom and flagged as physical. As per Melanie
2011-08-24extend initial rez regression test to check that attachment is phantomJustin Clark-Casey (justincc)1-9/+14
2011-08-24Make objects attached from the ground phantomJustin Clark-Casey (justincc)2-2/+12
2011-08-24return InventoryItemBase from AddSceneObjectAsAttachment()Justin Clark-Casey (justincc)1-8/+4
2011-08-24refactor: move Scene.Inventory.attachObjectAssetStore() into ↵Justin Clark-Casey (justincc)1-2/+100
AttachmentsModule.AddSceneObjectAsAttachment()
2011-08-24refactor: remove pointless AgentId argument from attachObjectAssetStore()Justin Clark-Casey (justincc)1-1/+1
2011-08-24add TestAddAttachmentFromGround() regression testJustin Clark-Casey (justincc)2-2/+32
2011-08-24Fix llAttachToAvatar()Justin Clark-Casey (justincc)1-10/+25
Apart from one obvious bug, this was failing because attempting to serialize the script from inside the script (as part of saving the attachment as an inventory asset) was triggering an extremely long delay. So we now don't do this. The state will be serialized anyway when the avatar normally logs out. The worst that can happen is that if the client/server crashes, the attachment scripts start without previous state.
generated by cgit v1.1 at 2024-09-14 01:35:44 +0000