aboutsummaryrefslogtreecommitdiffstatshomepage
path: root/OpenSim/Region/CoreModules/Avatar (unfollow)
Commit message (Collapse)AuthorFilesLines
2012-09-19Correctly override and call base OpenSimTestCase.SetUp() method in ↵Justin Clark-Casey (justincc)1-2/+2
GridConnectorsTests and ArchiverTests. Remove unrelated compile warning from AttachmentsModuleTests.
2012-09-12minor: Comment out friends notification log spam for now.Justin Clark-Casey (justincc)1-3/+3
2012-08-29Fix regression introduced in a0d178b2 (Sat Aug 25 02:00:17 2012) where ↵Justin Clark-Casey (justincc)1-32/+32
folders with asset type of 'Folder' and 'Unknown' were accidentally treated as system folders. This prevented more than one additional ordinary folder from being created in the base "My Inventory" user folder. Added regression test for this case. Switched tests to use XInventoryService with mostly implemented TestXInventoryDataPlugin rather than InventoryService Disabled TestLoadIarV0_1SameNameCreator() since this has not been working for a very long time (ever since XInventoryService) started being used since it doesnt' preserve creator data in the same way as InventoryService did and so effectively lost the OSPAs. However, nobody noticed/complained about this issue and OSPAs have been superseded by HG like creator information via the --home save oar/iar switch.
2012-08-20Add --force flag to "kick user" console command to allow bypassing of recent ↵Justin Clark-Casey (justincc)1-1/+1
race condition checks. This is to allow a second attempt to remove an avatar even if "show connections" shows them as already inactive (i.e. close has already been attempted once). You should only attempt --force if a normal kick fails. This is partly for diagnostics as we have seen some connections occasionally remain on lbsa plaza even if they are registered as inactive. This is not a permanent solution and may not work anyway - the ultimate solution is to stop this problem from happening in the first place.
2012-08-20Fix scripted detach of temp attachmentsMelanie1-6/+2
2012-08-14As per lindn spec, disable detach and drop for temp attachmentsMelanie1-0/+8
2012-08-14Lay some groundwork for temp attachments. Decouple attachments from inventory.Melanie2-17/+30
2012-08-03Fix build break.Justin Clark-Casey (justincc)1-1/+1
2012-08-03Update settings loading in AvatarFactoryModule which should have been in ↵Justin Clark-Casey (justincc)1-4/+4
last commit 205f2326
2012-07-25Rename OpenSim.Framework.Statistics to OpenSim.Framework.Monitoring.Justin Clark-Casey (justincc)1-1/+1
This better reflects the long-term purpose of that project and matches Monitoring modules.
2012-07-24Remove bad using statement in AttachmentsModuleTests.Justin Clark-Casey (justincc)1-2/+1
It seems that the mono 2.10.8.1 doesn't choke on this but for some reason 2.4.3 fails.
2012-07-24extend regression TestRezScriptedAttachmentFromInventory() to check actual ↵Justin Clark-Casey (justincc)1-3/+19
start of script rather than just the script status reported by SOG.ContainsScripts()
2012-07-24extend regression TestDetachScriptedAttachementToInventory() to check ↵Justin Clark-Casey (justincc)1-3/+25
correct running status on a re-rezzed attachment
2012-07-23Change attachment handling to remove object from the scene first as perMelanie1-29/+59
justincc's original work. Sample scripts before doing so. Also refactor some crucial common code and eliminate parameters that were only ever used with the same constant value.
2012-07-20Fix the order of operations on detach. The object must always be serializedMelanie1-6/+10
while still in the scene to avoid losing important script state. DeleteSceneObject can not be called before doing this!
2012-07-19Comment out OnIncomingInstantMessage and OnInstantMessage handlers in ↵Justin Clark-Casey (justincc)1-10/+10
GroupsModule, since these led to a private blank method
2012-07-17Fix regression where llGiveInventory() had stopped asking non-owner ↵Justin Clark-Casey (justincc)2-9/+14
receivers to accept/decline. This appears to be a regression from back in commit db91044 (Mon Aug 22 2011) where we started to send TaskInventoryOffered msg dialog rather than InventoryOffered dialog. This is probably correct, but failed because the bucket was too large and because we wouldn't have handled the TaskInventoryDeclined option anyway. This patch handles both of these and make llGiveInventoryList() use TaskInventoryOffered as well Fixes http://opensimulator.org/mantis/view.php?id=6089
2012-07-17Restore update of inventory item on derez/logout. This is necessary to ↵Justin Clark-Casey (justincc)1-1/+6
update the name if this has been changed whilst attached. Note, this behaviour appears to be at variance with the ll grid as of Tues 17 July 2012, testing with viewer 3.2.1. The item name in inventory does not change either at the point of detach or after a relog.
2012-07-17Stop sending the viewer an inventory create message if a known attachment ↵Justin Clark-Casey (justincc)1-4/+1
item is updated. This doesn't seem to make any sense and probably stems from a period when this code was directly involved in attaching objects directly from the scene. This message is already being sent by InventoryAccessModule code instead.
2012-07-11Allow XEngine StartDelay to be configured in the [XEngine] config section.Justin Clark-Casey (justincc)1-1/+2
This is only currently meant for use by regression tests that don't have any issues if XEngine is started up quickly, since no other operations will be occuring simultaneously. Therefore, this is not yet documented externally.
2012-07-11Add regression TestDetachScriptedAttachmentToInventory()Justin Clark-Casey (justincc)2-20/+127
This currently only does a relatively crude check for a ScriptState node in the serialized xml
2012-07-11Add regression TestRezScriptedAttachmentsFromInventory() though this ↵Justin Clark-Casey (justincc)1-1/+26
currently only checks for the presence of script items, not for started scripts
2012-07-10When an attachment is detached to inv or derezzed, stop the scripts, update ↵Justin Clark-Casey (justincc)1-6/+14
the known item with script state still in the script engine and then remove the scripts. This is to fix a regression starting from 5301648 where attachments had to start being deleted before persistence in order to avoid race conditions with hud update threads.
2012-07-09Do not allow a script to attach a prim if its being sat upon.Justin Clark-Casey (justincc)2-1/+40
This prevents a stack overflow where a get position on the avatar will refer to the attachment which will in turn refer back to the avatar. This required recording of all sitting avatars on a prim which is done separately from recording the sit target avatar. Recording HashSet is null if there are no sitting avatars in order to save memory.
2012-07-06minor: Remove some wrong comments in attachments regression testsJustin Clark-Casey (justincc)1-2/+0
2012-07-06Add assert to attachment regression tests to check that number of objects in ↵Justin Clark-Casey (justincc)1-0/+14
the scene graph
2012-07-06refactor: extract method UpdateUserInventoryWithAttachment() from ↵Justin Clark-Casey (justincc)1-29/+38
AttachObject() for better code comprehension
2012-07-05Add OSSL function osForceAttachToAvatarFromInventory()Justin Clark-Casey (justincc)1-1/+1
This works like osForceAttachToAvatar() but allows an object to be directly specified from the script object's inventory rather than forcing it to be rezzed in the scene first. Still only attaches objects to the owner of the script. This allows one to bypass the complicated co-ordination of first rezzing objects in the scene before attaching them. Threat level high.
2012-06-28Change AttachmentsModule.DetachSingleAttachmentToInv() to accept a SOG ↵Justin Clark-Casey (justincc)2-40/+45
directly instead of an item ID to then shuffle through attachments, saving CPU busywork. Almost all callers already had the sog to hand. Still checking that it's really an attachment, but now by inspecting SOG.AttachedAvatar
2012-06-28Rather than iterating through all SOGs in the scene looking for the one that ↵Justin Clark-Casey (justincc)1-24/+17
matches out fromItemID on detach, go through the agent's attachment sog list instead.
2012-06-28Remove code that tried to delete an attachment back to inventory if ↵Justin Clark-Casey (justincc)1-6/+1
RezSingleAttachmentFromInventoryInternal() returned null. null would only ever be returned if the item couldn't be located within inventory and this would happen immediately. In this case, derezzing wouldn't work anyway since there is no item to derez.
2012-06-27Fix issue in InventoryArchiveTestCase where it didn't call down to ↵Justin Clark-Casey (justincc)1-1/+2
OpenSimTestCase.SetUp()
2012-06-27refactor: Move ScenePresence <-> AgentData attachments copying code into ↵Justin Clark-Casey (justincc)1-0/+50
AttachmentsModule.
2012-06-27Automatically disable log4net before each regression test so that logging is ↵Justin Clark-Casey (justincc)2-4/+2
confined to a single test if it's turned on. This involves making test classes inherit from a common OpenSimTestCase. This will be applied to more classes as required.
2012-06-26refactor: Remove unnecessary AttachmentModuleTests.m_userId in favour of ↵Justin Clark-Casey (justincc)1-40/+26
local variables
2012-06-26refactor: Use local attachment module variables instead of global m_attMod.Justin Clark-Casey (justincc)1-11/+10
This also avoids confusion between tests where one sets up m_attMod and another accidentally uses it after failing to set one up itself.
2012-06-26refactor: make m_presence a local variable in all AttachmentsModuleTests ↵Justin Clark-Casey (justincc)1-26/+25
since it doesn't need to be global and some tests set up more than one sp
2012-06-26Add regression test to check that attachments in source region are deleting ↵Justin Clark-Casey (justincc)1-18/+115
when an agent teleports to a neighbouring region
2012-06-25minor: update currently commented out log message at top of ↵Justin Clark-Casey (justincc)1-1/+3
AvatarFactoryModule.SetAppearance() for future use
2012-06-25When attachments are being saved and deleted for a closing root agent, ↵Justin Clark-Casey (justincc)1-12/+21
delete first to avoid a hud race condition with update threads. If delete doesn't occur first then the update thread can outrace the IsAttachment = false necessary to save attachments and send hud artifacts to other viewers.
2012-06-25In AttachmentsModule.DetachSingleAttachmentToInvInternal(), remove ↵Justin Clark-Casey (justincc)1-1/+1
attachment before changing properties for correct inventory serialization. Serialization of attachments requires IsAttachment = false so that correct positions are serialized instead of avatar position. However, doing this when a hud is still attached allows race conditions with update threads, resulting in hud artifacts on other viewers. This change sets SOG.IsDeleted before serialization changes take place (IsDeleted itself is not a serialized property). LLClientView then screens out any deleted SOGs before sending updates to viewers.
2012-06-22Stop flicking IsAttachment false and then true in ↵Justin Clark-Casey (justincc)1-10/+0
AttachmentsModule.UpdateAttachmentPosition() in order to avoid a hud update race condition. Previously, setting IsAttachment to false then true was necessary to serialize the updated attachment object information. However, UpdateAttachmentPosition no longer does this update. Whilst IsAttachment is set to false there is a race condition where the update thread can wrongly send hud object updates to clients that do not own the hud, resulting in screen artifacts.
2012-06-22refactor AttachmentsModule tests to use a common method for standard ↵Justin Clark-Casey (justincc)1-70/+69
attachment item setup
2012-06-22Add regression test for updating attachment positionJustin Clark-Casey (justincc)1-0/+30
2012-06-14correct wrong incomplete comment from previous commit 3c3ea19 in ↵Justin Clark-Casey (justincc)1-1/+2
AttachmentsModule
2012-06-14Fix a bug where scene objects attached as HUDs through scripts would not ↵Justin Clark-Casey (justincc)1-0/+13
disappear for other avatars. We do this by sending a kill message for that object to all other avatars apart from the one that has the hud.
2012-06-04Remove the "Profile" config as it's covered by the replaceable interfaceMelanie1-8/+0
2012-05-29Add console command "teleport user" to allow teleport from the region consoleJustin Clark-Casey (justincc)1-0/+189
See "help teleport user" on the console for more details
2012-05-25Resolve some mono compiler warnings.Justin Clark-Casey (justincc)2-6/+9
2012-05-23Fetch the dialog module reference in AttachmentsModule in RegionLoaded() not ↵Justin Clark-Casey (justincc)1-1/+1
AddRegion() The reference is not guaranteed to be there when AddRegion() is called but will definitely be present at RegionLoaded() if it's going to be present at all.