aboutsummaryrefslogtreecommitdiffstatshomepage
path: root/OpenSim/Region/CoreModules/Avatar/Attachments (unfollow)
Commit message (Collapse)AuthorFilesLines
2012-07-17Restore update of inventory item on derez/logout. This is necessary to ↵Justin Clark-Casey (justincc)1-1/+6
update the name if this has been changed whilst attached. Note, this behaviour appears to be at variance with the ll grid as of Tues 17 July 2012, testing with viewer 3.2.1. The item name in inventory does not change either at the point of detach or after a relog.
2012-07-17Stop sending the viewer an inventory create message if a known attachment ↵Justin Clark-Casey (justincc)1-4/+1
item is updated. This doesn't seem to make any sense and probably stems from a period when this code was directly involved in attaching objects directly from the scene. This message is already being sent by InventoryAccessModule code instead.
2012-07-11Allow XEngine StartDelay to be configured in the [XEngine] config section.Justin Clark-Casey (justincc)1-1/+2
This is only currently meant for use by regression tests that don't have any issues if XEngine is started up quickly, since no other operations will be occuring simultaneously. Therefore, this is not yet documented externally.
2012-07-11Add regression TestDetachScriptedAttachmentToInventory()Justin Clark-Casey (justincc)2-20/+127
This currently only does a relatively crude check for a ScriptState node in the serialized xml
2012-07-11Add regression TestRezScriptedAttachmentsFromInventory() though this ↵Justin Clark-Casey (justincc)1-1/+26
currently only checks for the presence of script items, not for started scripts
2012-07-10When an attachment is detached to inv or derezzed, stop the scripts, update ↵Justin Clark-Casey (justincc)1-6/+14
the known item with script state still in the script engine and then remove the scripts. This is to fix a regression starting from 5301648 where attachments had to start being deleted before persistence in order to avoid race conditions with hud update threads.
2012-07-09Do not allow a script to attach a prim if its being sat upon.Justin Clark-Casey (justincc)2-1/+40
This prevents a stack overflow where a get position on the avatar will refer to the attachment which will in turn refer back to the avatar. This required recording of all sitting avatars on a prim which is done separately from recording the sit target avatar. Recording HashSet is null if there are no sitting avatars in order to save memory.
2012-07-06minor: Remove some wrong comments in attachments regression testsJustin Clark-Casey (justincc)1-2/+0
2012-07-06Add assert to attachment regression tests to check that number of objects in ↵Justin Clark-Casey (justincc)1-0/+14
the scene graph
2012-07-06refactor: extract method UpdateUserInventoryWithAttachment() from ↵Justin Clark-Casey (justincc)1-29/+38
AttachObject() for better code comprehension
2012-07-05Add OSSL function osForceAttachToAvatarFromInventory()Justin Clark-Casey (justincc)1-1/+1
This works like osForceAttachToAvatar() but allows an object to be directly specified from the script object's inventory rather than forcing it to be rezzed in the scene first. Still only attaches objects to the owner of the script. This allows one to bypass the complicated co-ordination of first rezzing objects in the scene before attaching them. Threat level high.
2012-06-28Change AttachmentsModule.DetachSingleAttachmentToInv() to accept a SOG ↵Justin Clark-Casey (justincc)2-40/+45
directly instead of an item ID to then shuffle through attachments, saving CPU busywork. Almost all callers already had the sog to hand. Still checking that it's really an attachment, but now by inspecting SOG.AttachedAvatar
2012-06-28Rather than iterating through all SOGs in the scene looking for the one that ↵Justin Clark-Casey (justincc)1-24/+17
matches out fromItemID on detach, go through the agent's attachment sog list instead.
2012-06-28Remove code that tried to delete an attachment back to inventory if ↵Justin Clark-Casey (justincc)1-6/+1
RezSingleAttachmentFromInventoryInternal() returned null. null would only ever be returned if the item couldn't be located within inventory and this would happen immediately. In this case, derezzing wouldn't work anyway since there is no item to derez.
2012-06-27refactor: Move ScenePresence <-> AgentData attachments copying code into ↵Justin Clark-Casey (justincc)1-0/+50
AttachmentsModule.
2012-06-27Automatically disable log4net before each regression test so that logging is ↵Justin Clark-Casey (justincc)1-3/+1
confined to a single test if it's turned on. This involves making test classes inherit from a common OpenSimTestCase. This will be applied to more classes as required.
2012-06-26refactor: Remove unnecessary AttachmentModuleTests.m_userId in favour of ↵Justin Clark-Casey (justincc)1-40/+26
local variables
2012-06-26refactor: Use local attachment module variables instead of global m_attMod.Justin Clark-Casey (justincc)1-11/+10
This also avoids confusion between tests where one sets up m_attMod and another accidentally uses it after failing to set one up itself.
2012-06-26refactor: make m_presence a local variable in all AttachmentsModuleTests ↵Justin Clark-Casey (justincc)1-26/+25
since it doesn't need to be global and some tests set up more than one sp
2012-06-26Add regression test to check that attachments in source region are deleting ↵Justin Clark-Casey (justincc)1-18/+115
when an agent teleports to a neighbouring region
2012-06-25When attachments are being saved and deleted for a closing root agent, ↵Justin Clark-Casey (justincc)1-12/+21
delete first to avoid a hud race condition with update threads. If delete doesn't occur first then the update thread can outrace the IsAttachment = false necessary to save attachments and send hud artifacts to other viewers.
2012-06-25In AttachmentsModule.DetachSingleAttachmentToInvInternal(), remove ↵Justin Clark-Casey (justincc)1-1/+1
attachment before changing properties for correct inventory serialization. Serialization of attachments requires IsAttachment = false so that correct positions are serialized instead of avatar position. However, doing this when a hud is still attached allows race conditions with update threads, resulting in hud artifacts on other viewers. This change sets SOG.IsDeleted before serialization changes take place (IsDeleted itself is not a serialized property). LLClientView then screens out any deleted SOGs before sending updates to viewers.
2012-06-22Stop flicking IsAttachment false and then true in ↵Justin Clark-Casey (justincc)1-10/+0
AttachmentsModule.UpdateAttachmentPosition() in order to avoid a hud update race condition. Previously, setting IsAttachment to false then true was necessary to serialize the updated attachment object information. However, UpdateAttachmentPosition no longer does this update. Whilst IsAttachment is set to false there is a race condition where the update thread can wrongly send hud object updates to clients that do not own the hud, resulting in screen artifacts.
2012-06-22refactor AttachmentsModule tests to use a common method for standard ↵Justin Clark-Casey (justincc)1-70/+69
attachment item setup
2012-06-22Add regression test for updating attachment positionJustin Clark-Casey (justincc)1-0/+30
2012-06-14correct wrong incomplete comment from previous commit 3c3ea19 in ↵Justin Clark-Casey (justincc)1-1/+2
AttachmentsModule
2012-06-14Fix a bug where scene objects attached as HUDs through scripts would not ↵Justin Clark-Casey (justincc)1-0/+13
disappear for other avatars. We do this by sending a kill message for that object to all other avatars apart from the one that has the hud.
2012-05-25Resolve some mono compiler warnings.Justin Clark-Casey (justincc)1-2/+0
2012-05-23Fetch the dialog module reference in AttachmentsModule in RegionLoaded() not ↵Justin Clark-Casey (justincc)1-1/+1
AddRegion() The reference is not guaranteed to be there when AddRegion() is called but will definitely be present at RegionLoaded() if it's going to be present at all.
2012-05-23Fix bug where an avatar that had an object they owned attached through ↵Justin Clark-Casey (justincc)2-137/+82
llAttachToAvatar() or osForceAttachToAvatar() would wrongly have next permissions come into play when they detached that object and rezzed it in scene. This is because the attachments module code was setting the 'object slam' bit by using PermissionMask.All Solution here is to route the attachment item creation call through the existing inventory code in BasicInventoryAccessModule rather than copy/pasted code in AttachmentsModule itself.
2012-05-05Fire the scripting changed event with CHANGED_OWNER when an object that has ↵Justin Clark-Casey (justincc)1-9/+9
changed owners is rezzed. This needs to occur after the script is resumed rather than before, when the event is just dropped. Addresses http://opensimulator.org/mantis/view.php?id=5890 and http://opensimulator.org/mantis/view.php?id=5952
2012-04-27Add regression test for teleporting an agent between separated regions on ↵Justin Clark-Casey (justincc)1-1/+1
the same simulator. This involves a large amount of change in test scene setup code to allow test scenes to share shared modules SetupScene is now an instance method that requires an instantiation of SceneHelpers, though other SceneHelpers methods are still static May split these out into separate classes in the future.
2012-04-25Comment out some debug ATTACHMENTS log messages for now.Justin Clark-Casey (justincc)1-15/+14
2012-04-24Minor improvements to loggingOren Hurvitz1-1/+3
Eliminated an extra newline in the console if the log line doesn't contain a category (example of a category: "[ASSETS]").
2012-04-07Store FromItemID for attachments once on SOG instead of on every SOP and ↵Justin Clark-Casey (justincc)2-12/+13
only ever using the root part entry. This eliminates some pointless memory use.
2012-02-01Prevent a changed attachment that has been saved from being saved again.Melanie1-0/+1
2012-02-01Straighten out some attachment mess. Don't save attachment states for HGMelanie1-11/+8
visitors at all. On Leaving a sim, save only the changed ones. Don't save all scripted stuff when leaving a sim.
2012-01-07Don't try to save a NPCs attachment states on NPC deleteMelanie1-0/+8
2011-12-09Add commented log lines to FetchInventoryDescendents2 path for future use.Justin Clark-Casey (justincc)1-0/+2
Haven't been able to resolve issue where attachments are removed by the viewer on relog on a localhost
2011-11-06Convert SendKillObject to take a list of uint rather than sending oneMelanie1-1/+1
packet per prim. More to come as we change to make use of this.
2011-10-15remove now redundant m_physical_prim flag from SOP.ApplyPhysics()Justin Clark-Casey (justincc)1-1/+1
2011-10-15factor common code out into SOP.RemoveFromPhysics()Justin Clark-Casey (justincc)1-4/+1
2011-10-04Removed all refs to IClientAPI from IAttachmentsModule. Separated client ↵Dan Lake2-361/+375
handlers for attachments to call public interface and rearranged module file into sections
2011-10-03Removed redundant code in AttachmentsModule and simplified interfaces which ↵Dan Lake2-95/+73
converted back and forth between ScenePresence and IClientAPI. More to be done still.
2011-10-03Remove usage of Linden packet types from inside Attachments Module and interfaceDan Lake1-5/+4
2011-09-30Add Enabled switch in new [Attachments] section in OpenSimDefaults.ini to ↵Justin Clark-Casey (justincc)1-3/+53
allow attachments to be temporarily turned off. This is for debugging purposes. Defaults to Attachments Enabled
2011-09-13Don't try and delete attachments for child agent closeJustin Clark-Casey (justincc)1-0/+32
2011-09-13Remove code from DetachSingleAttachmentToInv() that sets group changed on ↵Justin Clark-Casey (justincc)1-11/+0
all parts, now that we're performing this check in UpdateKnownItem() for other purposes
2011-09-13remove redunant itemID and agentID arguments from UpdateKnownItem().Justin Clark-Casey (justincc)1-6/+4
itemID is always taken taken from the group's stored item id, and agentID is never used.
2011-09-13Remove UpdateKnownItem() from IAttachmentsModule.Justin Clark-Casey (justincc)1-1/+1
It's not appropriate for code outside the attachments module to call this.