aboutsummaryrefslogtreecommitdiffstatshomepage
path: root/OpenSim/Region/CoreModules/Avatar/Attachments (unfollow)
Commit message (Collapse)AuthorFilesLines
2012-02-01Prevent a changed attachment that has been saved from being saved again.Melanie1-0/+1
2012-02-01Straighten out some attachment mess. Don't save attachment states for HGMelanie1-11/+8
visitors at all. On Leaving a sim, save only the changed ones. Don't save all scripted stuff when leaving a sim.
2012-01-07Don't try to save a NPCs attachment states on NPC deleteMelanie1-0/+8
2011-12-09Add commented log lines to FetchInventoryDescendents2 path for future use.Justin Clark-Casey (justincc)1-0/+2
Haven't been able to resolve issue where attachments are removed by the viewer on relog on a localhost
2011-11-06Convert SendKillObject to take a list of uint rather than sending oneMelanie1-1/+1
packet per prim. More to come as we change to make use of this.
2011-10-15remove now redundant m_physical_prim flag from SOP.ApplyPhysics()Justin Clark-Casey (justincc)1-1/+1
2011-10-15factor common code out into SOP.RemoveFromPhysics()Justin Clark-Casey (justincc)1-4/+1
2011-10-04Removed all refs to IClientAPI from IAttachmentsModule. Separated client ↵Dan Lake2-361/+375
handlers for attachments to call public interface and rearranged module file into sections
2011-10-03Removed redundant code in AttachmentsModule and simplified interfaces which ↵Dan Lake2-95/+73
converted back and forth between ScenePresence and IClientAPI. More to be done still.
2011-10-03Remove usage of Linden packet types from inside Attachments Module and interfaceDan Lake1-5/+4
2011-09-30Add Enabled switch in new [Attachments] section in OpenSimDefaults.ini to ↵Justin Clark-Casey (justincc)1-3/+53
allow attachments to be temporarily turned off. This is for debugging purposes. Defaults to Attachments Enabled
2011-09-13Don't try and delete attachments for child agent closeJustin Clark-Casey (justincc)1-0/+32
2011-09-13Remove code from DetachSingleAttachmentToInv() that sets group changed on ↵Justin Clark-Casey (justincc)1-11/+0
all parts, now that we're performing this check in UpdateKnownItem() for other purposes
2011-09-13remove redunant itemID and agentID arguments from UpdateKnownItem().Justin Clark-Casey (justincc)1-6/+4
itemID is always taken taken from the group's stored item id, and agentID is never used.
2011-09-13Remove UpdateKnownItem() from IAttachmentsModule.Justin Clark-Casey (justincc)1-1/+1
It's not appropriate for code outside the attachments module to call this.
2011-09-13minor: remove redundant grp != null check from AM.UpdateKnownItem()Justin Clark-Casey (justincc)1-36/+33
2011-09-13Stop attempts to rewear already worn items from removing and reattaching.Justin Clark-Casey (justincc)1-42/+77
Viewer 2/3 will sometimes attempt to rewear attachments, even though they have already been attached during the main login process. This change ignores those attempts. This stops script failures during login, as the rewearing was racing with the script startup code. It might also help with attachments being abnormally put into deleted state. Hopefully resolves some more of http://opensimulator.org/mantis/view.php?id=5644
2011-09-13Comment out attachments code in Scene.IncomingCreateObject(UUID userID, UUID ↵Justin Clark-Casey (justincc)1-3/+14
itemID) for now As far as I can see, this is only invoked by a PUT request to ObjectHandlers, which is not being used anyway. Invoking attachments code at this point is probably inappropriate since it would still be invoked when the client entered the scene. Being commented to simplify analysis of attachments issues. Can be uncommented when in use. Also, small tweak to lock and log removal of a SOG from the SceneObjectGroupsByLocalPartID collection in SceneGraph.GetGroupByPrim() if an inconsistency is found.
2011-09-12Start locking entire add/remove operations on an ↵Justin Clark-Casey (justincc)1-175/+207
IScenePresence.AttachmentsSyncLock object Attach and detach packets are processed asynchronously when received from a viewer. Bugs like http://opensimulator.org/mantis/view.php?id=5644 indicate that in some situations (such as attaching/detaching entire folders of objects at once), there are race conditions between these threads. Since multiple data structures need to be updated on attach/detach, it's not enough to lock the individual collections. Therefore, this commit introduces a new IScenePresence.AttachmentsSyncLock which add/remove operations lock on.
2011-09-08Remember to set and unset the fire and forget method at the top of the ↵Justin Clark-Casey (justincc)1-3/+7
attachment and npc tests
2011-09-06refactor: Make logic in AM.AttachObject() clearer by not reusing existing ↵Justin Clark-Casey (justincc)1-14/+19
variables in different contexts
2011-09-06rename AM.AddSceneObjectAsAttachment() to AddSceneObjectAsNewAttachmentInInvJustin Clark-Casey (justincc)1-3/+3
2011-09-06In SetAttachment, if the existing attachment has no asset id then carry on ↵Justin Clark-Casey (justincc)1-0/+8
rather than abort. When a user logs in, the attachment item ids are pulled from persistence in the Avatars table. However, the asset ids are not saved. When the avatar enters a simulator the attachments are set again. If we simply perform an item check then the asset ids (which are now present) are never set, and NPC attachments later fail unless the attachment is detached and reattached. Hopefully resolves part of http://opensimulator.org/mantis/view.php?id=5653
2011-09-06Get rid of the confusing version of ↵Justin Clark-Casey (justincc)1-11/+2
IAttachmentsModule.RezSingleAttachmentFromInventory() with the updateInventoryStatus switch, since this is never called with false
2011-09-06get rid of the unused AttachmentsModule.ShowAttachInUserInventory()Justin Clark-Casey (justincc)1-28/+0
2011-09-06Stop the pointless double setting of every attachment in AvatarAppearance.Justin Clark-Casey (justincc)2-6/+3
The second was already being filtered out so this has no user level effect
2011-09-03Stop NPCs losing attachments when the source avatar takes them off.Justin Clark-Casey (justincc)1-28/+48
This was happening because we were using the source avatar's item IDs in the clone appearance. Switch to using the asset IDs of attachments instead for NPCs. The InventoryAccessModule and AttachmentModule had to be changed to allow rezzing of an object without an associated inventory item. Hopefully goes some way towards resolving http://opensimulator.org/mantis/view.php?id=5653
2011-09-01Eliminate pointless checks of SOG.RootPart != nullJustin Clark-Casey (justincc)1-6/+0
It's never possible for SOG to have no RootPart, except in the first few picosends of the big bang when it's pulled from region persistence or deserialized
2011-08-31move common code into AttachmentsModule.DeleteAttachmentsFromScene()Justin Clark-Casey (justincc)1-0/+10
2011-08-31Make SP.Attachments available as sp.GetAttachments() instead.Justin Clark-Casey (justincc)2-17/+12
The approach here, as in other parts of OpenSim, is to return a copy of the list rather than the attachments list itself This prevents callers from forgetting to lock the list when they read it, as was happening in various parts of the codebase. It also improves liveness. This might improve attachment anomolies when performing region crossings.
2011-08-30remove pointless ToArray() call in AttachmentsModule.SaveChangedAttachments()Justin Clark-Casey (justincc)1-1/+1
2011-08-30minor: remove already processed avatar null check in Scene.RemoveClient()Justin Clark-Casey (justincc)1-1/+0
remove some now duplicated method doc
2011-08-30refactor: move SP.SaveChangedAttachments() fully into AttachmentsModuleJustin Clark-Casey (justincc)1-0/+18
2011-08-30refactor: Move ScenePresence.RezAttachments() into AttachmentsModuleJustin Clark-Casey (justincc)1-0/+38
This adds an incomplete IScenePresence to match ISceneEntity
2011-08-30refactor: migrate DropObject handling fully into AttachmentsModule from SceneJustin Clark-Casey (justincc)2-16/+12
2011-08-30Fix bug where attachments were remaining on the avatar after being dropped.Justin Clark-Casey (justincc)2-6/+20
If the inventory service is configured not to allow deletion then these will not disappear from inventory
2011-08-27Eliminate duplicate AttachmentPoint properties by always using the one ↵Justin Clark-Casey (justincc)2-24/+21
stored in the root part's state field.
2011-08-27refactor: camel case AttachmentPoint method arg as per code standardsJustin Clark-Casey (justincc)1-4/+4
2011-08-27refactor: move SOP.IsAttachment and AttachmentPoint up into SOG to avoid ↵Justin Clark-Casey (justincc)2-16/+15
pointless duplication of identical values
2011-08-26refactor: simplify SOP.AttachedAvatar into SOG.AttachedAvatarJustin Clark-Casey (justincc)1-10/+5
This does a tiny bit to reduce code complexity, memory requirement and the cpu time of pointlessly setting this field to the same value in every SOP
2011-08-26refactor: move SOG.DetachToGround() to ↵Justin Clark-Casey (justincc)1-1/+29
AttachmentsModule.DetachSceneObjectToGround() and remove redundant code
2011-08-26refactor: simplify DetachSingleAttachmentToGround() by retrieving the scene ↵Justin Clark-Casey (justincc)1-9/+10
object group direct
2011-08-26refactor: remove common presence set up in attachments testsJustin Clark-Casey (justincc)1-32/+38
2011-08-26comment out verbose test logging from last commitJustin Clark-Casey (justincc)1-1/+1
2011-08-26add regression test for detaching an attachment to the sceneJustin Clark-Casey (justincc)1-0/+33
2011-08-26refactor: move sog.DetachToInventoryPrep() into ↵Justin Clark-Casey (justincc)2-8/+19
AttachmentsModule.DetachSingleAttachmentToInv()
2011-08-26Downgrade warning about not saving unchanged attachment to debug instead, ↵Justin Clark-Casey (justincc)1-1/+4
and change text to better indicate what it's saying
2011-08-26Fix a very recent regression from llAttachToAvatar() fix where I ↵Justin Clark-Casey (justincc)1-5/+1
accidentally stopped normal script state persistence on login/logout and attach/detach
2011-08-24Remove forcing of phantom on ground attached objects - attachments can be ↵Justin Clark-Casey (justincc)2-5/+0
both non-phantom and flagged as physical. As per Melanie
2011-08-24extend initial rez regression test to check that attachment is phantomJustin Clark-Casey (justincc)1-9/+14