aboutsummaryrefslogtreecommitdiffstatshomepage
path: root/OpenSim/Region/CoreModules/Avatar/Attachments (unfollow)
Commit message (Collapse)AuthorFilesLines
2011-08-31move common code into AttachmentsModule.DeleteAttachmentsFromScene()Justin Clark-Casey (justincc)1-0/+10
2011-08-31Make SP.Attachments available as sp.GetAttachments() instead.Justin Clark-Casey (justincc)2-17/+12
The approach here, as in other parts of OpenSim, is to return a copy of the list rather than the attachments list itself This prevents callers from forgetting to lock the list when they read it, as was happening in various parts of the codebase. It also improves liveness. This might improve attachment anomolies when performing region crossings.
2011-08-30remove pointless ToArray() call in AttachmentsModule.SaveChangedAttachments()Justin Clark-Casey (justincc)1-1/+1
2011-08-30minor: remove already processed avatar null check in Scene.RemoveClient()Justin Clark-Casey (justincc)1-1/+0
remove some now duplicated method doc
2011-08-30refactor: move SP.SaveChangedAttachments() fully into AttachmentsModuleJustin Clark-Casey (justincc)1-0/+18
2011-08-30refactor: Move ScenePresence.RezAttachments() into AttachmentsModuleJustin Clark-Casey (justincc)1-0/+38
This adds an incomplete IScenePresence to match ISceneEntity
2011-08-30refactor: migrate DropObject handling fully into AttachmentsModule from SceneJustin Clark-Casey (justincc)2-16/+12
2011-08-30Fix bug where attachments were remaining on the avatar after being dropped.Justin Clark-Casey (justincc)2-6/+20
If the inventory service is configured not to allow deletion then these will not disappear from inventory
2011-08-27Eliminate duplicate AttachmentPoint properties by always using the one ↵Justin Clark-Casey (justincc)2-24/+21
stored in the root part's state field.
2011-08-27refactor: camel case AttachmentPoint method arg as per code standardsJustin Clark-Casey (justincc)1-4/+4
2011-08-27refactor: move SOP.IsAttachment and AttachmentPoint up into SOG to avoid ↵Justin Clark-Casey (justincc)2-16/+15
pointless duplication of identical values
2011-08-26refactor: simplify SOP.AttachedAvatar into SOG.AttachedAvatarJustin Clark-Casey (justincc)1-10/+5
This does a tiny bit to reduce code complexity, memory requirement and the cpu time of pointlessly setting this field to the same value in every SOP
2011-08-26refactor: move SOG.DetachToGround() to ↵Justin Clark-Casey (justincc)1-1/+29
AttachmentsModule.DetachSceneObjectToGround() and remove redundant code
2011-08-26refactor: simplify DetachSingleAttachmentToGround() by retrieving the scene ↵Justin Clark-Casey (justincc)1-9/+10
object group direct
2011-08-26refactor: remove common presence set up in attachments testsJustin Clark-Casey (justincc)1-32/+38
2011-08-26comment out verbose test logging from last commitJustin Clark-Casey (justincc)1-1/+1
2011-08-26add regression test for detaching an attachment to the sceneJustin Clark-Casey (justincc)1-0/+33
2011-08-26refactor: move sog.DetachToInventoryPrep() into ↵Justin Clark-Casey (justincc)2-8/+19
AttachmentsModule.DetachSingleAttachmentToInv()
2011-08-26Downgrade warning about not saving unchanged attachment to debug instead, ↵Justin Clark-Casey (justincc)1-1/+4
and change text to better indicate what it's saying
2011-08-26Fix a very recent regression from llAttachToAvatar() fix where I ↵Justin Clark-Casey (justincc)1-5/+1
accidentally stopped normal script state persistence on login/logout and attach/detach
2011-08-24Remove forcing of phantom on ground attached objects - attachments can be ↵Justin Clark-Casey (justincc)2-5/+0
both non-phantom and flagged as physical. As per Melanie
2011-08-24extend initial rez regression test to check that attachment is phantomJustin Clark-Casey (justincc)1-9/+14
2011-08-24Make objects attached from the ground phantomJustin Clark-Casey (justincc)2-2/+12
2011-08-24return InventoryItemBase from AddSceneObjectAsAttachment()Justin Clark-Casey (justincc)1-8/+4
2011-08-24refactor: move Scene.Inventory.attachObjectAssetStore() into ↵Justin Clark-Casey (justincc)1-2/+100
AttachmentsModule.AddSceneObjectAsAttachment()
2011-08-24refactor: remove pointless AgentId argument from attachObjectAssetStore()Justin Clark-Casey (justincc)1-1/+1
2011-08-24add TestAddAttachmentFromGround() regression testJustin Clark-Casey (justincc)2-2/+32
2011-08-24Fix llAttachToAvatar()Justin Clark-Casey (justincc)1-10/+25
Apart from one obvious bug, this was failing because attempting to serialize the script from inside the script (as part of saving the attachment as an inventory asset) was triggering an extremely long delay. So we now don't do this. The state will be serialized anyway when the avatar normally logs out. The worst that can happen is that if the client/server crashes, the attachment scripts start without previous state.
2011-08-23rename AttachmentsModule.ShowDetachInUserInventory() to ↵Justin Clark-Casey (justincc)2-7/+6
DetachSingleAttachmentToInv() for consistency and to reflect it's actual behaviour
2011-08-23remove mono compiler warningsJustin Clark-Casey (justincc)1-2/+0
2011-08-23replace TestRemoveAttachments() with a more thorough TestRemoveAttachment()Justin Clark-Casey (justincc)1-51/+27
2011-08-23replace old TestAddAttachments() with a more thorough TestAddAttachment()Justin Clark-Casey (justincc)1-7/+28
2011-08-23If an object failed to attach due to an exception, then try and detach it ↵Justin Clark-Casey (justincc)1-1/+2
from the avatar's list of attachments as well as delete it from the scene. This may help with the "Inconsistent attachment state" errors seen on teleport. See http://opensimulator.org/mantis/view.php?id=5644 and linked reports
2011-08-22If an attachment fails, then start logging the exception for now, in order ↵Justin Clark-Casey (justincc)1-55/+80
to help with the inconsistent state bug. This also refactors AttachmentsModules to stop pointlessly refetching the ScenePresence in various methods. However, more of this is required.
2011-08-18Don't try to save changed attachment states when an NPC with attachments is ↵Justin Clark-Casey (justincc)1-2/+2
removed from the scene. This is done by introducing a PresenceType enum into ScenePresence which currently has two values, User and Npc. This seems better than a SaveAttachments flag in terms of code comprehension, though I'm still slightly uneasy about introducing these semantics to core objects
2011-08-17comment out noisy attachments loggingJustin Clark-Casey (justincc)1-5/+5
2011-08-17Fix issue where loading a new appearance onto an NPC would not remove the ↵Justin Clark-Casey (justincc)1-2/+2
previous attachments from the scene. Addresses http://opensimulator.org/mantis/view.php?id=5636
2011-08-17extend test to check that there is one attachment and that it has the right nameJustin Clark-Casey (justincc)1-1/+6
2011-08-17Add new regression TestRezAttachmentsOnAvatarEntrance() to do simple ↵Justin Clark-Casey (justincc)2-7/+17
attachments check
2011-08-16Add new FireAndForgetMethod.None.Justin Clark-Casey (justincc)1-13/+33
This executes the callback on the same thread that made the request. Designed for use only by regression tests that rely on a predicable event ordering.
2011-08-16Move some previously common code back into separate tests. Remove unused ↵Justin Clark-Casey (justincc)1-10/+9
region handle from test.
2011-08-16Isolate existing incomplete attachments tests rather than have them rely on ↵Justin Clark-Casey (justincc)1-5/+5
each other. Much easier to debug this way.
2011-08-16drop number of attachments in test from 3 to 2 to reduce text complexityJustin Clark-Casey (justincc)1-4/+1
2011-08-16remove setting up of second scene in attachments since it's not currently usedJustin Clark-Casey (justincc)1-24/+21
2011-08-16relocate AttachmentTests.cs to AttachmentsModuleTests.csJustin Clark-Casey (justincc)1-0/+172
2011-08-10implement osNpcStopMoveTo() to cancel any current move targetJustin Clark-Casey (justincc)1-2/+2
2011-07-15If object is an attachment, make llGetVel() return the avatar's speed rather ↵Justin Clark-Casey (justincc)1-1/+0
than the object's own zero speed. As per http://opensimulator.org/mantis/view.php?id=5575
2011-04-28Fatpack message on agent transfers: 1 message only (UpdateAgent) containing ↵Diva Canto1-7/+6
the agent and all attachments. Preserves backwards compatibility -- older sims get passed attachments one by one. Meaning that I finally introduced versioning in the simulation service.
2011-01-25Removed a few more spurious appearance saves. When an avatarMic Bowman1-12/+10
enters a region the attachments module tries to update the appearance with attachments that are already part of the appearance. Just added a check to only save if the attachments weren't there before.
2010-12-14reinstate IAttachmentsModule.UpdateAttachmentPosition() since this is being ↵Justin Clark-Casey (justincc)1-0/+16
used by a 3rd party region module and contains non-obvious attachment specific code There are no functional changes. UpdateAttachmentPosition() is adapted to the new approach of only saving attachment state on logout
generated by cgit v1.1 at 2024-09-16 01:16:13 +0000