Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
* | Make SP.Attachments available as sp.GetAttachments() instead. | Justin Clark-Casey (justincc) | 2011-08-31 | 1 | -12/+7 | |
| | | | | | | | The approach here, as in other parts of OpenSim, is to return a copy of the list rather than the attachments list itself This prevents callers from forgetting to lock the list when they read it, as was happening in various parts of the codebase. It also improves liveness. This might improve attachment anomolies when performing region crossings. | |||||
* | remove pointless ToArray() call in AttachmentsModule.SaveChangedAttachments() | Justin Clark-Casey (justincc) | 2011-08-30 | 1 | -1/+1 | |
| | ||||||
* | minor: remove already processed avatar null check in Scene.RemoveClient() | Justin Clark-Casey (justincc) | 2011-08-30 | 1 | -1/+0 | |
| | | | | remove some now duplicated method doc | |||||
* | refactor: move SP.SaveChangedAttachments() fully into AttachmentsModule | Justin Clark-Casey (justincc) | 2011-08-30 | 1 | -0/+18 | |
| | ||||||
* | refactor: Move ScenePresence.RezAttachments() into AttachmentsModule | Justin Clark-Casey (justincc) | 2011-08-30 | 1 | -0/+38 | |
| | | | | This adds an incomplete IScenePresence to match ISceneEntity | |||||
* | refactor: migrate DropObject handling fully into AttachmentsModule from Scene | Justin Clark-Casey (justincc) | 2011-08-30 | 1 | -11/+10 | |
| | ||||||
* | Fix bug where attachments were remaining on the avatar after being dropped. | Justin Clark-Casey (justincc) | 2011-08-30 | 1 | -2/+10 | |
| | | | | If the inventory service is configured not to allow deletion then these will not disappear from inventory | |||||
* | Eliminate duplicate AttachmentPoint properties by always using the one ↵ | Justin Clark-Casey (justincc) | 2011-08-27 | 1 | -21/+21 | |
| | | | | stored in the root part's state field. | |||||
* | refactor: camel case AttachmentPoint method arg as per code standards | Justin Clark-Casey (justincc) | 2011-08-27 | 1 | -4/+4 | |
| | ||||||
* | refactor: move SOP.IsAttachment and AttachmentPoint up into SOG to avoid ↵ | Justin Clark-Casey (justincc) | 2011-08-27 | 1 | -7/+6 | |
| | | | | pointless duplication of identical values | |||||
* | refactor: simplify SOP.AttachedAvatar into SOG.AttachedAvatar | Justin Clark-Casey (justincc) | 2011-08-26 | 1 | -10/+5 | |
| | | | | This does a tiny bit to reduce code complexity, memory requirement and the cpu time of pointlessly setting this field to the same value in every SOP | |||||
* | refactor: move SOG.DetachToGround() to ↵ | Justin Clark-Casey (justincc) | 2011-08-26 | 1 | -1/+29 | |
| | | | | AttachmentsModule.DetachSceneObjectToGround() and remove redundant code | |||||
* | refactor: simplify DetachSingleAttachmentToGround() by retrieving the scene ↵ | Justin Clark-Casey (justincc) | 2011-08-26 | 1 | -9/+10 | |
| | | | | object group direct | |||||
* | refactor: move sog.DetachToInventoryPrep() into ↵ | Justin Clark-Casey (justincc) | 2011-08-26 | 1 | -7/+18 | |
| | | | | AttachmentsModule.DetachSingleAttachmentToInv() | |||||
* | Downgrade warning about not saving unchanged attachment to debug instead, ↵ | Justin Clark-Casey (justincc) | 2011-08-26 | 1 | -1/+4 | |
| | | | | and change text to better indicate what it's saying | |||||
* | Fix a very recent regression from llAttachToAvatar() fix where I ↵ | Justin Clark-Casey (justincc) | 2011-08-26 | 1 | -5/+1 | |
| | | | | accidentally stopped normal script state persistence on login/logout and attach/detach | |||||
* | Remove forcing of phantom on ground attached objects - attachments can be ↵ | Justin Clark-Casey (justincc) | 2011-08-24 | 1 | -2/+0 | |
| | | | | | | both non-phantom and flagged as physical. As per Melanie | |||||
* | Make objects attached from the ground phantom | Justin Clark-Casey (justincc) | 2011-08-24 | 1 | -0/+2 | |
| | ||||||
* | return InventoryItemBase from AddSceneObjectAsAttachment() | Justin Clark-Casey (justincc) | 2011-08-24 | 1 | -8/+4 | |
| | ||||||
* | refactor: move Scene.Inventory.attachObjectAssetStore() into ↵ | Justin Clark-Casey (justincc) | 2011-08-24 | 1 | -2/+100 | |
| | | | | AttachmentsModule.AddSceneObjectAsAttachment() | |||||
* | refactor: remove pointless AgentId argument from attachObjectAssetStore() | Justin Clark-Casey (justincc) | 2011-08-24 | 1 | -1/+1 | |
| | ||||||
* | add TestAddAttachmentFromGround() regression test | Justin Clark-Casey (justincc) | 2011-08-24 | 1 | -1/+1 | |
| | ||||||
* | Fix llAttachToAvatar() | Justin Clark-Casey (justincc) | 2011-08-24 | 1 | -10/+25 | |
| | | | | | | Apart from one obvious bug, this was failing because attempting to serialize the script from inside the script (as part of saving the attachment as an inventory asset) was triggering an extremely long delay. So we now don't do this. The state will be serialized anyway when the avatar normally logs out. The worst that can happen is that if the client/server crashes, the attachment scripts start without previous state. | |||||
* | rename AttachmentsModule.ShowDetachInUserInventory() to ↵ | Justin Clark-Casey (justincc) | 2011-08-23 | 1 | -6/+5 | |
| | | | | DetachSingleAttachmentToInv() for consistency and to reflect it's actual behaviour | |||||
* | If an object failed to attach due to an exception, then try and detach it ↵ | Justin Clark-Casey (justincc) | 2011-08-23 | 1 | -1/+2 | |
| | | | | | | | from the avatar's list of attachments as well as delete it from the scene. This may help with the "Inconsistent attachment state" errors seen on teleport. See http://opensimulator.org/mantis/view.php?id=5644 and linked reports | |||||
* | If an attachment fails, then start logging the exception for now, in order ↵ | Justin Clark-Casey (justincc) | 2011-08-22 | 1 | -55/+80 | |
| | | | | | | to help with the inconsistent state bug. This also refactors AttachmentsModules to stop pointlessly refetching the ScenePresence in various methods. However, more of this is required. | |||||
* | Don't try to save changed attachment states when an NPC with attachments is ↵ | Justin Clark-Casey (justincc) | 2011-08-18 | 1 | -2/+2 | |
| | | | | | | | removed from the scene. This is done by introducing a PresenceType enum into ScenePresence which currently has two values, User and Npc. This seems better than a SaveAttachments flag in terms of code comprehension, though I'm still slightly uneasy about introducing these semantics to core objects | |||||
* | comment out noisy attachments logging | Justin Clark-Casey (justincc) | 2011-08-17 | 1 | -5/+5 | |
| | ||||||
* | Fix issue where loading a new appearance onto an NPC would not remove the ↵ | Justin Clark-Casey (justincc) | 2011-08-17 | 1 | -2/+2 | |
| | | | | | | previous attachments from the scene. Addresses http://opensimulator.org/mantis/view.php?id=5636 | |||||
* | Add new regression TestRezAttachmentsOnAvatarEntrance() to do simple ↵ | Justin Clark-Casey (justincc) | 2011-08-17 | 1 | -1/+1 | |
| | | | | attachments check | |||||
* | implement osNpcStopMoveTo() to cancel any current move target | Justin Clark-Casey (justincc) | 2011-08-10 | 1 | -2/+2 | |
| | ||||||
* | If object is an attachment, make llGetVel() return the avatar's speed rather ↵ | Justin Clark-Casey (justincc) | 2011-07-15 | 1 | -1/+0 | |
| | | | | | | than the object's own zero speed. As per http://opensimulator.org/mantis/view.php?id=5575 | |||||
* | Fatpack message on agent transfers: 1 message only (UpdateAgent) containing ↵ | Diva Canto | 2011-04-28 | 1 | -7/+6 | |
| | | | | the agent and all attachments. Preserves backwards compatibility -- older sims get passed attachments one by one. Meaning that I finally introduced versioning in the simulation service. | |||||
* | Removed a few more spurious appearance saves. When an avatar | Mic Bowman | 2011-01-25 | 1 | -12/+10 | |
| | | | | | | | enters a region the attachments module tries to update the appearance with attachments that are already part of the appearance. Just added a check to only save if the attachments weren't there before. | |||||
* | reinstate IAttachmentsModule.UpdateAttachmentPosition() since this is being ↵ | Justin Clark-Casey (justincc) | 2010-12-14 | 1 | -0/+16 | |
| | | | | | | used by a 3rd party region module and contains non-obvious attachment specific code There are no functional changes. UpdateAttachmentPosition() is adapted to the new approach of only saving attachment state on logout | |||||
* | Only perform the take object permissions check if an object is being ↵ | Justin Clark-Casey (justincc) | 2010-11-23 | 1 | -55/+50 | |
| | | | | attached directly from the scene, not from existing inventory | |||||
* | Change the way attachments are persisted. Editing a worn attachment will now | Melanie | 2010-11-16 | 1 | -22/+12 | |
| | | | | | | | save properly, as will the results of a resizer script working. Attachment positions are no longer saved on each move, but instead are saved once on logout. Attachment script states are saved as part of the attachment now when detaching. | |||||
* | Formatting cleanup. | Jeff Ames | 2010-11-08 | 1 | -1/+1 | |
| | ||||||
* | Detach attachments displaced by other attachments | Melanie | 2010-11-08 | 1 | -4/+8 | |
| | ||||||
* | Bunch of fixes that reduce the number of times appearance | Master ScienceSim | 2010-10-29 | 1 | -19/+13 | |
| | | | | | and avatar data are sent. And the number of times they are stored. | |||||
* | Major refactoring of appearance handling. | Master ScienceSim | 2010-10-20 | 1 | -8/+8 | |
| | | | | | | | | | | | | | | | | | | | AvatarService -- add two new methods, GetAppearance and SetAppearance to get around the lossy encoding in AvatarData. Preseve the old functions to avoid changing the behavior for ROBUST services. AvatarAppearance -- major refactor, moved the various encoding methods used by AgentCircuitData, ClientAgentUpdate and ScenePresence into one location. Changed initialization. AvatarAttachments -- added a class specifically to handle attachments in preparation for additional functionality that will be needed for viewer 2. AvatarFactory -- removed a number of unused or methods duplicated in other locations. Moved in all appearance event handling from ScenePresence. Required a change to IClientAPI that propogated throughout all the IClientAPI implementations. | |||||
* | A couple of more ways attachment point is sent | Latif Khalifa | 2010-10-15 | 1 | -0/+8 | |
| | | | | Signed-off-by: Teravus Ovares (Dan Olivares) <teravus@gmail.com> | |||||
* | Don't distroy attachments when using viewer 2.1+, strip multiple attachment data | Latif Khalifa | 2010-10-14 | 1 | -0/+4 | |
| | ||||||
* | Formatting cleanup. | Jeff Ames | 2010-10-04 | 1 | -1/+1 | |
| | ||||||
* | Prevent dropping someone else's attachments | Melanie | 2010-09-30 | 1 | -0/+3 | |
| | ||||||
* | Changed SceneObjectGroup to store parts with the fast and thread-safe ↵ | John Hurliman | 2010-09-16 | 1 | -7/+3 | |
| | | | | MapAndArray collection | |||||
* | Rename now protected method SetAttachmentInventoryStatus() to ↵ | Justin Clark-Casey (justincc) | 2010-09-13 | 1 | -4/+4 | |
| | | | | ShowAttachInUserInventory() to match ShowDetachInUserInventory() | |||||
* | Remove IAttachmentsModule.SetAttachmentInventoryStatus() from public interface | Justin Clark-Casey (justincc) | 2010-09-13 | 1 | -5/+13 | |
| | | | | No core module is calling and it makes more sense to call methods such as AttachObject() which attach both to the avatar and update inventory appropriately | |||||
* | If attachment fails (e.g. because asset wasn't found) then don't try to set ↵ | Justin Clark-Casey (justincc) | 2010-09-13 | 1 | -4/+2 | |
| | | | | | | attachment as shown in inventory Doing this results in a null reference exception | |||||
* | minor: Clean up log messages generated when an item is attached | Justin Clark-Casey (justincc) | 2010-09-13 | 1 | -2/+4 | |
| |