aboutsummaryrefslogtreecommitdiffstatshomepage
path: root/OpenSim/Region/CoreModules/Avatar/Attachments/AttachmentsModule.cs (unfollow)
Commit message (Collapse)AuthorFilesLines
2011-08-31Make SP.Attachments available as sp.GetAttachments() instead.Justin Clark-Casey (justincc)1-12/+7
The approach here, as in other parts of OpenSim, is to return a copy of the list rather than the attachments list itself This prevents callers from forgetting to lock the list when they read it, as was happening in various parts of the codebase. It also improves liveness. This might improve attachment anomolies when performing region crossings.
2011-08-30remove pointless ToArray() call in AttachmentsModule.SaveChangedAttachments()Justin Clark-Casey (justincc)1-1/+1
2011-08-30minor: remove already processed avatar null check in Scene.RemoveClient()Justin Clark-Casey (justincc)1-1/+0
remove some now duplicated method doc
2011-08-30refactor: move SP.SaveChangedAttachments() fully into AttachmentsModuleJustin Clark-Casey (justincc)1-0/+18
2011-08-30refactor: Move ScenePresence.RezAttachments() into AttachmentsModuleJustin Clark-Casey (justincc)1-0/+38
This adds an incomplete IScenePresence to match ISceneEntity
2011-08-30refactor: migrate DropObject handling fully into AttachmentsModule from SceneJustin Clark-Casey (justincc)1-11/+10
2011-08-30Fix bug where attachments were remaining on the avatar after being dropped.Justin Clark-Casey (justincc)1-2/+10
If the inventory service is configured not to allow deletion then these will not disappear from inventory
2011-08-27Eliminate duplicate AttachmentPoint properties by always using the one ↵Justin Clark-Casey (justincc)1-21/+21
stored in the root part's state field.
2011-08-27refactor: camel case AttachmentPoint method arg as per code standardsJustin Clark-Casey (justincc)1-4/+4
2011-08-27refactor: move SOP.IsAttachment and AttachmentPoint up into SOG to avoid ↵Justin Clark-Casey (justincc)1-7/+6
pointless duplication of identical values
2011-08-26refactor: simplify SOP.AttachedAvatar into SOG.AttachedAvatarJustin Clark-Casey (justincc)1-10/+5
This does a tiny bit to reduce code complexity, memory requirement and the cpu time of pointlessly setting this field to the same value in every SOP
2011-08-26refactor: move SOG.DetachToGround() to ↵Justin Clark-Casey (justincc)1-1/+29
AttachmentsModule.DetachSceneObjectToGround() and remove redundant code
2011-08-26refactor: simplify DetachSingleAttachmentToGround() by retrieving the scene ↵Justin Clark-Casey (justincc)1-9/+10
object group direct
2011-08-26refactor: move sog.DetachToInventoryPrep() into ↵Justin Clark-Casey (justincc)1-7/+18
AttachmentsModule.DetachSingleAttachmentToInv()
2011-08-26Downgrade warning about not saving unchanged attachment to debug instead, ↵Justin Clark-Casey (justincc)1-1/+4
and change text to better indicate what it's saying
2011-08-26Fix a very recent regression from llAttachToAvatar() fix where I ↵Justin Clark-Casey (justincc)1-5/+1
accidentally stopped normal script state persistence on login/logout and attach/detach
2011-08-24Remove forcing of phantom on ground attached objects - attachments can be ↵Justin Clark-Casey (justincc)1-2/+0
both non-phantom and flagged as physical. As per Melanie
2011-08-24Make objects attached from the ground phantomJustin Clark-Casey (justincc)1-0/+2
2011-08-24return InventoryItemBase from AddSceneObjectAsAttachment()Justin Clark-Casey (justincc)1-8/+4
2011-08-24refactor: move Scene.Inventory.attachObjectAssetStore() into ↵Justin Clark-Casey (justincc)1-2/+100
AttachmentsModule.AddSceneObjectAsAttachment()
2011-08-24refactor: remove pointless AgentId argument from attachObjectAssetStore()Justin Clark-Casey (justincc)1-1/+1
2011-08-24add TestAddAttachmentFromGround() regression testJustin Clark-Casey (justincc)1-1/+1
2011-08-24Fix llAttachToAvatar()Justin Clark-Casey (justincc)1-10/+25
Apart from one obvious bug, this was failing because attempting to serialize the script from inside the script (as part of saving the attachment as an inventory asset) was triggering an extremely long delay. So we now don't do this. The state will be serialized anyway when the avatar normally logs out. The worst that can happen is that if the client/server crashes, the attachment scripts start without previous state.
2011-08-23rename AttachmentsModule.ShowDetachInUserInventory() to ↵Justin Clark-Casey (justincc)1-6/+5
DetachSingleAttachmentToInv() for consistency and to reflect it's actual behaviour
2011-08-23If an object failed to attach due to an exception, then try and detach it ↵Justin Clark-Casey (justincc)1-1/+2
from the avatar's list of attachments as well as delete it from the scene. This may help with the "Inconsistent attachment state" errors seen on teleport. See http://opensimulator.org/mantis/view.php?id=5644 and linked reports
2011-08-22If an attachment fails, then start logging the exception for now, in order ↵Justin Clark-Casey (justincc)1-55/+80
to help with the inconsistent state bug. This also refactors AttachmentsModules to stop pointlessly refetching the ScenePresence in various methods. However, more of this is required.
2011-08-18Don't try to save changed attachment states when an NPC with attachments is ↵Justin Clark-Casey (justincc)1-2/+2
removed from the scene. This is done by introducing a PresenceType enum into ScenePresence which currently has two values, User and Npc. This seems better than a SaveAttachments flag in terms of code comprehension, though I'm still slightly uneasy about introducing these semantics to core objects
2011-08-17comment out noisy attachments loggingJustin Clark-Casey (justincc)1-5/+5
2011-08-17Fix issue where loading a new appearance onto an NPC would not remove the ↵Justin Clark-Casey (justincc)1-2/+2
previous attachments from the scene. Addresses http://opensimulator.org/mantis/view.php?id=5636
2011-08-17Add new regression TestRezAttachmentsOnAvatarEntrance() to do simple ↵Justin Clark-Casey (justincc)1-1/+1
attachments check
2011-08-10implement osNpcStopMoveTo() to cancel any current move targetJustin Clark-Casey (justincc)1-2/+2
2011-07-15If object is an attachment, make llGetVel() return the avatar's speed rather ↵Justin Clark-Casey (justincc)1-1/+0
than the object's own zero speed. As per http://opensimulator.org/mantis/view.php?id=5575
2011-04-28Fatpack message on agent transfers: 1 message only (UpdateAgent) containing ↵Diva Canto1-7/+6
the agent and all attachments. Preserves backwards compatibility -- older sims get passed attachments one by one. Meaning that I finally introduced versioning in the simulation service.
2011-01-25Removed a few more spurious appearance saves. When an avatarMic Bowman1-12/+10
enters a region the attachments module tries to update the appearance with attachments that are already part of the appearance. Just added a check to only save if the attachments weren't there before.
2010-12-14reinstate IAttachmentsModule.UpdateAttachmentPosition() since this is being ↵Justin Clark-Casey (justincc)1-0/+16
used by a 3rd party region module and contains non-obvious attachment specific code There are no functional changes. UpdateAttachmentPosition() is adapted to the new approach of only saving attachment state on logout
2010-11-23Only perform the take object permissions check if an object is being ↵Justin Clark-Casey (justincc)1-55/+50
attached directly from the scene, not from existing inventory
2010-11-16Change the way attachments are persisted. Editing a worn attachment will nowMelanie1-22/+12
save properly, as will the results of a resizer script working. Attachment positions are no longer saved on each move, but instead are saved once on logout. Attachment script states are saved as part of the attachment now when detaching.
2010-11-08Formatting cleanup.Jeff Ames1-1/+1
2010-11-08Detach attachments displaced by other attachmentsMelanie1-4/+8
2010-10-29Bunch of fixes that reduce the number of times appearanceMaster ScienceSim1-19/+13
and avatar data are sent. And the number of times they are stored.
2010-10-20Major refactoring of appearance handling.Master ScienceSim1-8/+8
AvatarService -- add two new methods, GetAppearance and SetAppearance to get around the lossy encoding in AvatarData. Preseve the old functions to avoid changing the behavior for ROBUST services. AvatarAppearance -- major refactor, moved the various encoding methods used by AgentCircuitData, ClientAgentUpdate and ScenePresence into one location. Changed initialization. AvatarAttachments -- added a class specifically to handle attachments in preparation for additional functionality that will be needed for viewer 2. AvatarFactory -- removed a number of unused or methods duplicated in other locations. Moved in all appearance event handling from ScenePresence. Required a change to IClientAPI that propogated throughout all the IClientAPI implementations.
2010-10-15A couple of more ways attachment point is sentLatif Khalifa1-0/+8
Signed-off-by: Teravus Ovares (Dan Olivares) <teravus@gmail.com>
2010-10-14Don't distroy attachments when using viewer 2.1+, strip multiple attachment dataLatif Khalifa1-0/+4
2010-10-04Formatting cleanup.Jeff Ames1-1/+1
2010-09-30Prevent dropping someone else's attachmentsMelanie1-0/+3
2010-09-16Changed SceneObjectGroup to store parts with the fast and thread-safe ↵John Hurliman1-7/+3
MapAndArray collection
2010-09-13Rename now protected method SetAttachmentInventoryStatus() to ↵Justin Clark-Casey (justincc)1-4/+4
ShowAttachInUserInventory() to match ShowDetachInUserInventory()
2010-09-13Remove IAttachmentsModule.SetAttachmentInventoryStatus() from public interfaceJustin Clark-Casey (justincc)1-5/+13
No core module is calling and it makes more sense to call methods such as AttachObject() which attach both to the avatar and update inventory appropriately
2010-09-13If attachment fails (e.g. because asset wasn't found) then don't try to set ↵Justin Clark-Casey (justincc)1-4/+2
attachment as shown in inventory Doing this results in a null reference exception
2010-09-13minor: Clean up log messages generated when an item is attachedJustin Clark-Casey (justincc)1-2/+4