aboutsummaryrefslogtreecommitdiffstatshomepage
path: root/OpenSim/Region/ClientStack (unfollow)
Commit message (Collapse)AuthorFilesLines
2012-07-19Make LLClientView instant message handling asynchronous rather than ↵Justin Clark-Casey (justincc)1-1/+1
synchronous to prevent long operations from holding up all inbound packet processing. Giving a large folder from one avatar to another was causing a long delay when handled synchronously, since it took some time to retrieve the necessary data from the inventory service. Handling this asynchronously instead stops this delay from disrupting all avatars in the scene. This has been shown in OSGrid. I see no reason for not handling all IM messages asynchronously, just as incoming chat is handled asynchronously, so this has been switched for all instant messages. Thanks to Nebadon for testing this change out.
2012-07-19Prevent race conditions between two threads that call LLClientView.Close() ↵Justin Clark-Casey (justincc)2-30/+57
simultaneously (e.g. ack timeout and an attempt to reconnect)
2012-07-12Stop redundantly passing in the endpoint to the LLClientView constructor.Justin Clark-Casey (justincc)2-5/+2
This can always be retrieved via the LLUDPClient and is so done in various places already.
2012-07-12Remove IClientIPEndpoint client interface for now.Justin Clark-Casey (justincc)1-20/+1
This may well come back in the future when this subinterface is actually used but it currently isn't and I feel the name was poor. Everything uses IClientAPI.RemoveEndPoint which also returned the full endpoint rather than just the ip address.
2012-07-12Remove IClientAPI.GetClientEP() in favour of existing identical ↵Justin Clark-Casey (justincc)1-5/+0
IClientAPI.RemoteEndpoint.
2012-07-04refactor: rename Watchdog.WATCHDOG_TIMEOUT_MS to DEFAULT_WATCHDOG_TIMEOUT_MS ↵Justin Clark-Casey (justincc)1-2/+2
to reflect what it actually is
2012-06-29Add IScene.Name for code clarity to replace the RegionInfo.RegionName used ↵Justin Clark-Casey (justincc)1-2/+1
in many, many log messages.
2012-06-25In AttachmentsModule.DetachSingleAttachmentToInvInternal(), remove ↵Justin Clark-Casey (justincc)1-1/+32
attachment before changing properties for correct inventory serialization. Serialization of attachments requires IsAttachment = false so that correct positions are serialized instead of avatar position. However, doing this when a hud is still attached allows race conditions with update threads, resulting in hud artifacts on other viewers. This change sets SOG.IsDeleted before serialization changes take place (IsDeleted itself is not a serialized property). LLClientView then screens out any deleted SOGs before sending updates to viewers.
2012-06-15Add region name to UseCircuitCode log messagesJustin Clark-Casey (justincc)1-4/+4
2012-06-15Put all debug console commands into a single Debug section rather than ↵Justin Clark-Casey (justincc)1-1/+1
scattering them over other categories
2012-06-15Add main instance to internal MainServer.m_Servers list to simplify internal ↵Justin Clark-Casey (justincc)2-1/+11
logic. This does require the server to be added before it is set as the main Instance
2012-06-15Get rid of some unnecessary null checks in ↵Justin Clark-Casey (justincc)1-9/+5
RegionApplicationBase.StartupSpecific() - a constructor can never return null. Also adds some method doc to MainServer
2012-06-14Fix very recent regression in 917d753 where I put the ++updatesThisCall ↵Justin Clark-Casey (justincc)1-2/+2
outside the batching part of ProcessEntityUpdates() This stopped any batching happening and since this method is called periodically updates were sent very slowly
2012-06-14If we're going to discard a terse update block because it's now someone ↵Justin Clark-Casey (justincc)1-2/+4
else's hud, then don't still add it to the list of blocks for the update message.
2012-06-14Fix a race condition where an object update for a hud could be sent to ↵Justin Clark-Casey (justincc)1-3/+24
non-owner avatars if the hud was attached directly from within the region. If this happens, then the non-owners would see unremovable huds that they did not own until relog, and sometimes even beyond that. This was due to a race between the entity update and the attachment code when moving an object from within scene to a hud.
2012-06-14Fix not sending TransferInfo when an asset is not found. This clogsMelanie1-4/+29
up the sound pipeline in the viewer.
2012-06-14minor: remove unnecessary IsAttachment = false setting for new object in ↵Justin Clark-Casey (justincc)1-1/+0
UploadObjectAssetModule, property always starts as false
2012-06-13minor: refactor part of LLClientView.ProcessEntityUpdates() to remove ↵Justin Clark-Casey (justincc)1-5/+7
duplicate code
2012-06-13Remove long obsolete and unused IClientAPI.KillEndDone()Justin Clark-Casey (justincc)1-4/+0
2012-06-13Add ObjectUpdate as one of the packets that can be screened out when setting ↵Justin Clark-Casey (justincc)1-1/+2
debug packet level
2012-06-12Remove accidental timeout left in during earlier debugging. Has been in ↵Justin Clark-Casey (justincc)1-1/+1
since two commits ago (b099f26)
2012-06-12Set IClientAPI.IsActive = false early on client removal due to ack timeout ↵Justin Clark-Casey (justincc)1-29/+35
rather than using IsLoggingOut flag. IsActive is more appropriate since unack timeout is not due to voluntary logout. This is in line with operations such as manual kick that do not set the IsLoggingOut flag. It's also slightly better race-wise since it reduces the chance of this operation clashing with another reason for client deactivation (e.g. manual kick).
2012-06-12If the simulator closes a root agent due to ack timeout, then send the ↵Justin Clark-Casey (justincc)1-2/+20
client a kick message with that reason, in case it is somehow still listening.
2012-06-12In PresenceDetector.OnConnectionClose(), use the IsChildAgent check already ↵Justin Clark-Casey (justincc)1-2/+2
available on IClientAPI.SceneAgent rather than retrieving it again by scanning all scenes.
2012-06-08Stop sending a DisableSimulator packet in LLClientView.Close(), which is a ↵Justin Clark-Casey (justincc)1-4/+0
duplicate for child agents and unnecessary for root agents. Close() already calls Scene.RemoveClient() which sends the right eq or udp DisableSimulator message to child agents.
2012-06-08Instead of retrieving the known client again in LLUDPServer.RemoveClient(), ↵Justin Clark-Casey (justincc)1-21/+10
check the IsLoggingOut flag instead. This is slightly better thread-race wise
2012-06-08If logging a client out due to ack timeout, do this asynchronously rather ↵Justin Clark-Casey (justincc)2-10/+20
than synchronously on the outgoing packet loop. This is the same async behaviour as normal logouts. This is necessary because the event queue will sleep the thread for 5 seconds on an ack timeout logout as the client isn't around to pick up the final event queue messages.
2012-06-08Add regression test for client logout due to ack timeout.Justin Clark-Casey (justincc)3-91/+103
2012-06-08Remove null checks at top of LLUDPServer.ProcessInPacket(). Neither packet ↵Justin Clark-Casey (justincc)1-8/+1
nor client are ever null.
2012-06-08Store already retrieve IClientAPI in IncomingPacket structure for later use ↵Justin Clark-Casey (justincc)2-15/+16
rather than doing another retrieve on dequeue. Instead of checking whether the client still exists by trying to retrieve again from the client manager, this patch gets it back from IncomingPacket and checks the IClientAPI.IsActive state.
2012-06-07Log warning if we try to remove a UDP client that has already been removed.Justin Clark-Casey (justincc)1-0/+6
2012-06-07Allow the thread watchdog to accept an alarm method that is invoked if the ↵Justin Clark-Casey (justincc)1-5/+64
timeout is breached. This alarm can then invoke this to log extra information. This is used in LLUDPServer to show which client was being processed when incoming and outgoing udp watchdog alarms are triggered.
2012-06-05Mantis 4597 AgentPaused packet is ignored.Talun1-3/+15
The packet was actually being handled but not acted on. This change extends the default timeout for paused clients to 5 minutes and makes both the paused and non-paused timeout periods configurable.
2012-05-18Fix build break. Comment out EQG deregister/register logging.Justin Clark-Casey (justincc)1-10/+10
2012-05-18Add level 2 debug eq logging which logs event queue polls.Justin Clark-Casey (justincc)1-23/+32
Refactor: eq message logging into common method.
2012-05-18refactor: move EventQueueGet path generation into common method. Rename ↵Justin Clark-Casey (justincc)1-20/+33
some local variables in line with code conventions. Add commented out EQG log lines for future use.
2012-05-09Improve logging on the prim inventory script asset request path for future use.Justin Clark-Casey (justincc)2-6/+9
This adds name and description of the request handler to http request logging when DebugLevel >= 1
2012-05-03Implement optional name and description on http stream handlers so that we ↵Justin Clark-Casey (justincc)12-80/+137
can relate a slow request to what the handler actually does and the agent it serves, if applicable. This is most useful for capabilities where the url is not self-describing.
2012-05-01Add regression test for teleporting between neighbouring regions on the same ↵Justin Clark-Casey (justincc)2-2/+3
simulator This adds a non-advertised wait_for_callback option in [EntityTransfer]. Default is always true. Teleport tests disable the wait for callback from the destination region in order to run within a single thread.
2012-04-27Revert "Revert "Implement bulk inventory update over CAPS (not recursive by ↵Justin Clark-Casey (justincc)1-1/+47
design,"" This reverts commit a90b0e302c110068cec0ee7109e796d2d5fdab4d. Sorry, accidentally reverted this completely by mistake, reverting the revert.
2012-04-27Revert "Implement bulk inventory update over CAPS (not recursive by design,"Justin Clark-Casey (justincc)1-47/+1
This reverts commit 6e7f13a72d4e43f8ca564247e0b56bf5706bbdb1.
2012-04-27Add regression test for teleporting an agent between separated regions on ↵Justin Clark-Casey (justincc)3-3/+3
the same simulator. This involves a large amount of change in test scene setup code to allow test scenes to share shared modules SetupScene is now an instance method that requires an instantiation of SceneHelpers, though other SceneHelpers methods are still static May split these out into separate classes in the future.
2012-04-26Tweak log messages on local region to region teleport path to help with ↵Justin Clark-Casey (justincc)1-1/+3
problem resolution.
2012-04-26minor: Add more detail to unauthorized caps client messageJustin Clark-Casey (justincc)1-1/+4
2012-04-26minor: Add region name to dropped inbound packet messageJustin Clark-Casey (justincc)1-1/+3
2012-04-07Rather than having a FromFolderID property on every single prim and only ↵Justin Clark-Casey (justincc)1-1/+1
ever using the root prim one, store on SOG instead. This reduces pointless memory usage.
2012-04-07Store FromItemID for attachments once on SOG instead of on every SOP and ↵Justin Clark-Casey (justincc)1-1/+1
only ever using the root part entry. This eliminates some pointless memory use.
2012-04-06Packing of folder in SendBulkUpdateInventory always set the folder type to ↵Diva Canto1-1/+2
-1. Not sure if there's a reason for it, but I'm changing it to the given folder type.
2012-03-31Implement bulk inventory update over CAPS (not recursive by design,Melanie1-1/+47
do NOT CHANGE THIS, needed for HG 2.0)
2012-03-29refactor: Stop passing both IClientAPI and agentID to friend event ↵Justin Clark-Casey (justincc)1-7/+6
listeners, these are redundant. Replace a few magic numbers with FriendRights enum already used elsewhere.