aboutsummaryrefslogtreecommitdiffstatshomepage
path: root/OpenSim/Region/ClientStack/Linden/UDP (unfollow)
Commit message (Collapse)AuthorFilesLines
2012-10-25Fix script error messages not showing up in viewer 3 and associated viewers.Justin Clark-Casey (justincc)1-3/+4
Viewer 3 will discard such a message if the chat message owner does not match the avatar. We were filling the ownerID with the primID, so this never matched, hence viewer 3 did not see any script error messages. This commit fills the ownerID in with the prim ownerID so the script owner will receive script error messages. This does not affect viewer 1 and associated viewers which continue to process script errors as normal.
2012-10-23Make it possible to turn the base UDP object packet pools on and off whilst ↵Justin Clark-Casey (justincc)2-38/+131
running via the "debug lludp pool <on|off>" console command. For debug purposes. This does not currently apply to the higher LLUDP packetpool.
2012-10-23Add object count stats for new IncomingPacket and UDPPacketBuffer pools if ↵Justin Clark-Casey (justincc)3-6/+65
they are enabled. Add count stats for existing LLUDP pool. This introduces a pull stat type in addition to the push stat type. A pull stat takes a method on construction which knows how to update the stat on request. In this way, special interfaces for pull stat collection are not necessary.
2012-10-18minor: Remove event method doc from LLClientView that I forgot in the last ↵Justin Clark-Casey (justincc)1-15/+0
commit (1de80c)
2012-10-17Reuse the same AgentUpdateArgs object for each AgentUpdate UDP packet (of ↵Justin Clark-Casey (justincc)1-41/+68
which there are 10 a second) rather than constructing a new one every time. We can do this because AgentUpdate packets are handled synchronously.
2012-10-17Explicitly return only the incoming AgentUpdate packet as this is the only ↵Justin Clark-Casey (justincc)3-8/+30
one we pool atm, rather than attempting to return all incoming packets.
2012-10-17If RecycleBaseUDPPackets = true, also pool IncomingPackets to reduce memory ↵Justin Clark-Casey (justincc)2-2/+30
churn
2012-10-16minor: Make BasicCircuitTests.SetUp() call overriden base method instead of ↵Justin Clark-Casey (justincc)1-1/+2
ignoring it.
2012-10-16Add optional pool for the UDPPacketBuffer objects that handle all incoming ↵Justin Clark-Casey (justincc)2-24/+49
UDP data. Even when an avatar is standing still, it's sending in a constant stream of AgentUpdate packets that the client creates new UDPPacketBuffer objects to handle. This option pools those objects. This reduces memory churn. Currently off by default. Works but the scope can be expanded.
2012-10-16Make it possible to separate start and stop lludp packet processing from the ↵Justin Clark-Casey (justincc)2-31/+129
console for debug processes. This is controlled via the "debug lludp start <in|out|all>" and "debug lludp stop <in|out|all>" region console commands. The command "debug lludp status" will show current status.
2012-10-13minor: Fix and elaborate on log information printed when an unrecognized ↵Justin Clark-Casey (justincc)1-2/+14
estate method is received from the client.
2012-10-12minor: Use && instead of & when deciding whether to print ↵Justin Clark-Casey (justincc)1-1/+1
Improve/ObjectUpdate packet out messages when debug is turned on. Practical effect is probably none.
2012-10-12minor: Fix bug in categorization of blocks reused stat from packetpoolJustin Clark-Casey (justincc)1-1/+1
2012-10-12Add AgentUpdate to PacketPool. This is the most common inbound packet from ↵Justin Clark-Casey (justincc)3-5/+28
viewers.
2012-10-12Fix percentage stats to multiply by 100. Adjust container name for ↵Justin Clark-Casey (justincc)1-2/+2
packetpool stats.
2012-10-12Enable reuse of data blocks for ImprovedTerseObjectUpdate using existing ↵Justin Clark-Casey (justincc)1-1/+3
Packetpool code.
2012-10-11Fix packetpool for ImprovedTerseObjectUpdate packets.Justin Clark-Casey (justincc)3-5/+15
These were neither being returned or in many places reused. Getting packets from a pool rather than deallocating and reallocating reduces memory churn which in turn reduces garbage collection time and frequency.
2012-10-11Extend "show stats" command to "show stats [list|all|<category name>]"Justin Clark-Casey (justincc)1-8/+35
This allows different categories of stats to be shown, with options to list categories or show all stats. Currently categories are scene and simulator and only a very few stats are currently registered via this mechanism. This commit also adds percentage stats for packets and blocks reused from the packet pool.
2012-10-10Lock on AgentCircuitData during Scene.AddClient() and RemoveClient() to ↵Justin Clark-Casey (justincc)1-7/+7
prevent an inactive connection being left behind if the user closes the viewer whilst the connection is being established. This should remove the need to run the console command "kick user --force" when these connections are left around.
2012-10-09Move OpenSim.Data.RegionFlags -> OpenSim.Framework.RegionFlags to make it ↵Justin Clark-Casey (justincc)1-0/+1
easier for other code to use (e.g. LSL_Api) without having to reference OpenSim.Data just for this.
2012-10-06On receiving TaskInventoryAccepted with a destination folder in the binary ↵Justin Clark-Casey (justincc)1-1/+2
bucket slot for RLV, notify the viewer about inventory folder updates. The viewer would not see the folder move without this, either on accept or decline. This commit also updates the TaskInventoryOffered message to better conform with the data LL uses Changes are, agentID is prim owner rather than prim id, agent name is now simply object name rather than name with owner detail, message is just folder name in single quotes, message is not timestamped. However, folder is not renamed "still #RLV/~<name>". Long term solution is probably not to do these operations server-side. Notes will be added to http://opensimulator.org/mantis/view.php?id=6311
2012-10-05Read PacketPool config in LLUDPServer with other config params rather than ↵Justin Clark-Casey (justincc)1-0/+9
in Scene. This is to resolve previous build break. This unnecessarily but harmlessly reads and sets the parameter multiple times - scene was doing the same thing.
2012-10-05refactor: Move OpenSim.Framework.PacketPool to ↵Justin Clark-Casey (justincc)1-0/+249
OpenSim.Region.Clientstack.Linden.UDP This is to allow it to use OpenSim.Framework.Monitoring in the future. This is also a better location since the packet pool is linden udp specific
2012-08-31Replace SendBannedUserList with Avination's version. Untested in core. Not ↵Melanie1-25/+32
even test compiled.
2012-08-20Add --force flag to "kick user" console command to allow bypassing of recent ↵Justin Clark-Casey (justincc)1-5/+9
race condition checks. This is to allow a second attempt to remove an avatar even if "show connections" shows them as already inactive (i.e. close has already been attempted once). You should only attempt --force if a normal kick fails. This is partly for diagnostics as we have seen some connections occasionally remain on lbsa plaza even if they are registered as inactive. This is not a permanent solution and may not work anyway - the ultimate solution is to stop this problem from happening in the first place.
2012-08-19Fix llDialog responses so that they can be heard throughout the region. This ↵Melanie1-1/+1
now conforms to the behaviour in SL.
2012-07-25Rename OpenSim.Framework.Statistics to OpenSim.Framework.Monitoring.Justin Clark-Casey (justincc)2-2/+2
This better reflects the long-term purpose of that project and matches Monitoring modules.
2012-07-24Extend region console "show queues" command to show already collected time ↵Justin Clark-Casey (justincc)1-1/+2
since last packeted received by the simulator from a viewer.
2012-07-19Make LLClientView instant message handling asynchronous rather than ↵Justin Clark-Casey (justincc)1-1/+1
synchronous to prevent long operations from holding up all inbound packet processing. Giving a large folder from one avatar to another was causing a long delay when handled synchronously, since it took some time to retrieve the necessary data from the inventory service. Handling this asynchronously instead stops this delay from disrupting all avatars in the scene. This has been shown in OSGrid. I see no reason for not handling all IM messages asynchronously, just as incoming chat is handled asynchronously, so this has been switched for all instant messages. Thanks to Nebadon for testing this change out.
2012-07-19Prevent race conditions between two threads that call LLClientView.Close() ↵Justin Clark-Casey (justincc)2-30/+57
simultaneously (e.g. ack timeout and an attempt to reconnect)
2012-07-12Stop redundantly passing in the endpoint to the LLClientView constructor.Justin Clark-Casey (justincc)2-5/+2
This can always be retrieved via the LLUDPClient and is so done in various places already.
2012-07-12Remove IClientIPEndpoint client interface for now.Justin Clark-Casey (justincc)1-20/+1
This may well come back in the future when this subinterface is actually used but it currently isn't and I feel the name was poor. Everything uses IClientAPI.RemoveEndPoint which also returned the full endpoint rather than just the ip address.
2012-07-12Remove IClientAPI.GetClientEP() in favour of existing identical ↵Justin Clark-Casey (justincc)1-5/+0
IClientAPI.RemoteEndpoint.
2012-07-04refactor: rename Watchdog.WATCHDOG_TIMEOUT_MS to DEFAULT_WATCHDOG_TIMEOUT_MS ↵Justin Clark-Casey (justincc)1-2/+2
to reflect what it actually is
2012-06-29Add IScene.Name for code clarity to replace the RegionInfo.RegionName used ↵Justin Clark-Casey (justincc)1-2/+1
in many, many log messages.
2012-06-25In AttachmentsModule.DetachSingleAttachmentToInvInternal(), remove ↵Justin Clark-Casey (justincc)1-1/+32
attachment before changing properties for correct inventory serialization. Serialization of attachments requires IsAttachment = false so that correct positions are serialized instead of avatar position. However, doing this when a hud is still attached allows race conditions with update threads, resulting in hud artifacts on other viewers. This change sets SOG.IsDeleted before serialization changes take place (IsDeleted itself is not a serialized property). LLClientView then screens out any deleted SOGs before sending updates to viewers.
2012-06-15Add region name to UseCircuitCode log messagesJustin Clark-Casey (justincc)1-4/+4
2012-06-14Fix very recent regression in 917d753 where I put the ++updatesThisCall ↵Justin Clark-Casey (justincc)1-2/+2
outside the batching part of ProcessEntityUpdates() This stopped any batching happening and since this method is called periodically updates were sent very slowly
2012-06-14If we're going to discard a terse update block because it's now someone ↵Justin Clark-Casey (justincc)1-2/+4
else's hud, then don't still add it to the list of blocks for the update message.
2012-06-14Fix a race condition where an object update for a hud could be sent to ↵Justin Clark-Casey (justincc)1-3/+24
non-owner avatars if the hud was attached directly from within the region. If this happens, then the non-owners would see unremovable huds that they did not own until relog, and sometimes even beyond that. This was due to a race between the entity update and the attachment code when moving an object from within scene to a hud.
2012-06-14Fix not sending TransferInfo when an asset is not found. This clogsMelanie1-4/+29
up the sound pipeline in the viewer.
2012-06-13minor: refactor part of LLClientView.ProcessEntityUpdates() to remove ↵Justin Clark-Casey (justincc)1-5/+7
duplicate code
2012-06-13Remove long obsolete and unused IClientAPI.KillEndDone()Justin Clark-Casey (justincc)1-4/+0
2012-06-13Add ObjectUpdate as one of the packets that can be screened out when setting ↵Justin Clark-Casey (justincc)1-1/+2
debug packet level
2012-06-12Remove accidental timeout left in during earlier debugging. Has been in ↵Justin Clark-Casey (justincc)1-1/+1
since two commits ago (b099f26)
2012-06-12Set IClientAPI.IsActive = false early on client removal due to ack timeout ↵Justin Clark-Casey (justincc)1-29/+35
rather than using IsLoggingOut flag. IsActive is more appropriate since unack timeout is not due to voluntary logout. This is in line with operations such as manual kick that do not set the IsLoggingOut flag. It's also slightly better race-wise since it reduces the chance of this operation clashing with another reason for client deactivation (e.g. manual kick).
2012-06-12If the simulator closes a root agent due to ack timeout, then send the ↵Justin Clark-Casey (justincc)1-2/+20
client a kick message with that reason, in case it is somehow still listening.
2012-06-12In PresenceDetector.OnConnectionClose(), use the IsChildAgent check already ↵Justin Clark-Casey (justincc)1-2/+2
available on IClientAPI.SceneAgent rather than retrieving it again by scanning all scenes.
2012-06-08Stop sending a DisableSimulator packet in LLClientView.Close(), which is a ↵Justin Clark-Casey (justincc)1-4/+0
duplicate for child agents and unnecessary for root agents. Close() already calls Scene.RemoveClient() which sends the right eq or udp DisableSimulator message to child agents.
2012-06-08Instead of retrieving the known client again in LLUDPServer.RemoveClient(), ↵Justin Clark-Casey (justincc)1-21/+10
check the IsLoggingOut flag instead. This is slightly better thread-race wise