aboutsummaryrefslogtreecommitdiffstatshomepage
path: root/OpenSim/Framework (unfollow)
Commit message (Collapse)AuthorFilesLines
2013-07-26Fix regression tests relating to agent transfer by making simulator use last ↵Justin Clark-Casey (justincc)1-0/+5
week's SIMULATOR/0.1 protocol for now.
2013-07-24New Teleport protocol (V2), still compatible with V1 and older. (version of ↵Diva Canto1-5/+6
the destination is being checked) In this new protocol, and as committed before, the viewer is not sent EnableSimulator/EstablishChildCommunication for the destination. Instead, it is sent TeleportFinish directly. TeleportFinish, in turn, makes the viewer send a UserCircuitCode packet followed by CompleteMovementIntoRegion packet. These 2 packets tend to occur one after the other almost immediately to the point that when CMIR arrives the client is not even connected yet and that packet is ignored (there might have been some race conditions here before); then the viewer sends CMIR again within 5-8 secs. But the delay between them may be higher in busier regions, which may lead to race conditions. This commit improves the process so there are are no race conditions at the destination. CompleteMovement (triggered by the viewer) waits until Update has been sent from the origin. Update, in turn, waits until there is a *root* scene presence -- so making sure CompleteMovement has run MakeRoot. In other words, there are two threadlets at the destination, one from the viewer and one from the origin region, waiting for each other to do the right thing. That makes it safe to close the agent at the origin upon return of the Update call without having to wait for callback, because we are absolutely sure that the viewer knows it is in th new region. Note also that in the V1 protocol, the destination was getting UseCircuitCode from the viewer twice -- once on EstablishAgentCommunication and then again on TeleportFinish. The second UCC was being ignored, but it shows how we were not following the expected steps...
2013-07-23Correct issue where the last instance of a sampled stat was shown 3x larger ↵Justin Clark-Casey (justincc)1-1/+2
than it should have been (though internal use was correct)
2013-07-23Improve spacing between data and units on console stats displayJustin Clark-Casey (justincc)1-3/+12
2013-07-23For stats which can show average change over time, show the last sample as ↵Justin Clark-Casey (justincc)1-1/+11
well as the average. This is somewhat cryptic at the moment, need to improve documentation.
2013-07-21EDIT BEAMS!!! They had been missing from OpenSim since ever. Thanks to ↵Diva Canto1-1/+1
lkalif for telling me how to route the information. The viewer effect is under the distance filter, so only avatars with cameras < 10m away see the beams.
2013-07-21Manage AgentUpdates more sanely:Diva Canto1-0/+2
- The existing event to scene has been split into 2: OnAgentUpdate and OnAgentCameraUpdate, to better reflect the two types of updates that the viewer sends. We can run one without the other, which is what happens when the avie is still but the user is camming around - Added thresholds (as opposed to equality) to determine whether the update is significant or not. I thin these thresholds are ok, but we can play with them later - Ignore updates of HeadRotation, which were problematic and aren't being used up stream
2013-07-21Removed verbose debug from previous commitDiva Canto1-1/+0
2013-07-21PollServiceRequestManager: changed the long poll from a Queue to a List. No ↵Diva Canto1-13/+17
need to dequeue and enqueue items every 1sec.
2013-07-21Delay the enqueueing of non-longpoll requests for 100ms. No need to have ↵Diva Canto1-1/+11
these requests actively on the processing queue if it seems they're not ready.
2013-07-18Changed the timoeut of EQ 502s (no events) to 50 secs. The viewer post ↵Diva Canto1-1/+1
requests timeout in 60 secs. There's plenty of room for improvement in handling the EQs. Some other time...
2013-07-18Revert "Revert "I confuse myself. Let's try this variable name instead.""Diva Canto1-3/+3
This reverts commit 52dc7b2a96a28798d55d07d79d003ce5e3d35216.
2013-07-18Revert "Revert "Do the same trick that dahlia did for Dequeue(timeout)""Diva Canto1-2/+3
This reverts commit 5495df74436d6c0039a1500d979a964b003abfdf.
2013-07-18Revert "Revert "Putting the requests back in the queue while testing for ↵Diva Canto1-3/+7
count >0 is not the smartest move..."" This reverts commit 71278919575b0e0222cdbe3c0cefa5919f9a75bc.
2013-07-18Revert "Revert "Didn't mean to commit this change in BlockingQueue.cs""Diva Canto1-1/+1
This reverts commit fda91d93dad1fa6f901e8db5829aa8b70477c97e.
2013-07-18Reverting the reverts I did yesterday. cpu-branch has now beenDiva Canto3-49/+36
successfully tested, and I'm merging back those changes, which proved to be good. Revert "Revert "Cleared up much confusion in PollServiceRequestManager. Here's the history:"" This reverts commit fa2370b32ee57a07f27501152c3c705a883b13d8.
2013-07-18Added MinPoolThreads to ini [Startup] section to control SmartThreadPool.Dan Lake1-3/+5
2013-07-18Fix what apepars to be a bug in DoubleQueue<T>.Enqueue(Queue<T> q, T data) ↵Justin Clark-Casey (justincc)1-1/+1
where the q parmater is ignored and everyghig is always placed on m_lowQueue. No actual impact presently since nothing ends up calling EnqueueHigh()
2013-07-17Revert "Cleared up much confusion in PollServiceRequestManager. Here's the ↵Diva Canto3-36/+49
history:" This reverts commit e46459ef21e1ee5ceaeca70365a7c881d33b09ce.
2013-07-17Revert "Didn't mean to commit this change in BlockingQueue.cs"Diva Canto1-1/+1
This reverts commit 0f5b616fb0ebf9207b3cc81771622ed1290ea7d6.
2013-07-17Revert "Putting the requests back in the queue while testing for count >0 is ↵Diva Canto1-7/+3
not the smartest move..." This reverts commit f4317dc26d670c853d0ea64b401b00f718f09474.
2013-07-17Revert "Do the same trick that dahlia did for Dequeue(timeout)"Diva Canto1-3/+2
This reverts commit af792bc7f2504e9ccf1c8ae7568919785dc397c9.
2013-07-17Revert "I confuse myself. Let's try this variable name instead."Diva Canto1-3/+3
This reverts commit 1d3deda10cf85abd68a5f904d6698ae597a67cc0.
2013-07-17Revert "Now trying DoubleQueue instead of BlockingQueue for the ↵Diva Canto1-2/+2
PollServiceRequestManager." This reverts commit 5f95f4d78e8c7d17b8ba866907156fe6d4444c04.
2013-07-17Revert "This is a completely unreasonable thing to do, effectively defying ↵Diva Canto1-52/+40
the purpose of BlockingQueues. Trying this, to see the effect on CPU." This reverts commit 5232ab0496eb4fe6903a0fd328974ac69df29ad8.
2013-07-17This is a completely unreasonable thing to do, effectively defying the ↵Diva Canto1-40/+52
purpose of BlockingQueues. Trying this, to see the effect on CPU.
2013-07-17Now trying DoubleQueue instead of BlockingQueue for the ↵Diva Canto1-2/+2
PollServiceRequestManager.
2013-07-17I confuse myself. Let's try this variable name instead.Diva Canto1-3/+3
2013-07-17Do the same trick that dahlia did for Dequeue(timeout)Diva Canto1-2/+3
2013-07-17Putting the requests back in the queue while testing for count >0 is not the ↵Diva Canto1-3/+7
smartest move...
2013-07-17Didn't mean to commit this change in BlockingQueue.csDiva Canto1-1/+1
2013-07-17Cleared up much confusion in PollServiceRequestManager. Here's the history:Diva Canto3-49/+36
When Melanie added the web fetch inventory throttle to core, she made the long poll requests (EQs) effectively be handled on an active loop. All those requests, if they existed, were being constantly dequeued, checked for events (which most often they didn't have), and requeued again. This was an active loop thread on a 100ms cycle! This fixes the issue. Now the inventory requests, if they aren't ready to be served, are placed directly back in the queue, but the long poll requests aren't placed there until there are events ready to be sent or timeout has been reached. This puts the LongPollServiceWatcherThread back to 1sec cycle, as it was before.
2013-07-16minor: Add warning method doc about possibly inconsistent results returned ↵Justin Clark-Casey (justincc)1-1/+19
from BlockingQueue.Contains(), Count() and GetQueueArray()
2013-07-16Revert "Revert "MSDN documentation is unclear about whether exiting a lock() ↵Justin Clark-Casey (justincc)1-5/+8
block will trigger a Monitor.Wait() to exit, so avoid some locks that don't actually affect the state of the internal queues in the BlockingQueue class."" This reverts commit 21a09ad3ad42b24bce4fc04c6bcd6f7d9a80af08. After more analysis and discussion, it is apparant that the Count(), Contains() and GetQueueArray() cannot be made thread-safe anyway without external locking And this change appears to have a positive impact on performance. I still believe that Monitor.Exit() will not release any thread for Monitor.Wait(), as per http://msdn.microsoft.com/en-gb/library/vstudio/system.threading.monitor.exit%28v=vs.100%29.aspx so this should in theory make no difference, though mono implementation issues could possibly be coming into play.
2013-07-16Revert "MSDN documentation is unclear about whether exiting a lock() block ↵Justin Clark-Casey (justincc)1-8/+5
will trigger a Monitor.Wait() to exit, so avoid some locks that don't actually affect the state of the internal queues in the BlockingQueue class." This reverts commit 42e2a0d66eaa7e322bce817e9e2cc9a288de167b Reverting because unfortunately this introduces race conditions because Contains(), Count() and GetQueueArray() may now end up returning the wrong result if another thread performs a simultaneous update on m_queue. Code such as PollServiceRequestManager.Stop() relies on the count being correct otherwise a request may be lost. Also, though some of the internal queue methods do not affect state, they are not thread-safe and could return the wrong result generating the same problem lock() generates Monitor.Enter() and Monitor.Exit() under the covers. Monitor.Exit() does not cause Monitor.Wait() to exist, only Pulse() and PulseAll() will do this Reverted with agreement.
2013-07-16MSDN documentation is unclear about whether exiting a lock() block will ↵dahlia1-5/+8
trigger a Monitor.Wait() to exit, so avoid some locks that don't actually affect the state of the internal queues in the BlockingQueue class.
2013-07-15Add request received/handling stats for caps which are served by http poll ↵Justin Clark-Casey (justincc)5-51/+70
handlers. This adds explicit cap poll handler supporting to the Caps classes rather than relying on callers to do the complicated coding. Other refactoring was required to get logic into the right places to support this.
2013-07-15This might address the following observed exception:Diva Canto1-1/+1
17:14:28 - [APPLICATION]: APPLICATION EXCEPTION DETECTED: System.UnhandledExceptionEventArgs Exception: System.InvalidOperationException: Operation is not valid due to the current state of the object at System.Collections.Generic.Queue`1[OpenSim.Region.ClientStack.Linden.WebFetchInvDescModule+aPollRequest].Peek () [0x00011] in /root/install/mono-3.1.0/mono/mcs/class/System/System.Collections.Generic/Queue.cs:158 at System.Collections.Generic.Queue`1[OpenSim.Region.ClientStack.Linden.WebFetchInvDescModule+aPollRequest].Dequeue () [0x00000] in /root/install/mono-3.1.0/mono/mcs/class/System/System.Collections.Generic/Queue.cs:140 at OpenSim.Framework.DoubleQueue`1[OpenSim.Region.ClientStack.Linden.WebFetchInvDescModule+aPollRequest].Dequeue (TimeSpan wait, OpenSim.Region.ClientStack.Linden.aPollRequest& res) [0x0004e] in /home/avacon/opensim_2013-07-14/OpenSim/Framework/Util.cs:2297
2013-07-14Authenticate ChildAgentUpdate too.Diva Canto2-2/+3
2013-07-12Add ToOSDMap() overrides to the Stat subclass CounterStat.Robert Adams3-0/+88
Add a GetStatsAsOSDMap method to StatsManager which allows the filtered fetching of stats for eventual returning over the internets.
2013-07-11Fix regression where llHTTPRequests which did not get an OK response ↵Justin Clark-Casey (justincc)1-1/+6
returned 499 and the exception message in the http_response event rather than the actual response code and body. This was a regression since commit 831e4c3 (Thu Apr 4 00:36:15 2013) This commit also adds a regression test for this case, though this currently only works with Mono This aims to address http://opensimulator.org/mantis/view.php?id=6704
2013-07-10Added show client-stats [first last] command to expose what viewers are ↵Diva Canto1-3/+8
requesting.
2013-07-08Add missing file BaseOutputStreamHandler.cs from recent commit e19defdJustin Clark-Casey (justincc)1-0/+60
2013-07-08minor: remove now unused migration-hack bool from DAMapJustin Clark-Casey (justincc)1-4/+0
2013-07-08BaseHttpServer: if the handler sets the content length, don't override it. ↵Diva Canto1-1/+1
This happens in HEAD handlers.
2013-07-08Add "show caps stats by user" and "show caps stats by cap" console commands ↵Justin Clark-Casey (justincc)7-16/+51
to print various counts of capability invocation by user and by cap This currently prints caps requests received and handled, so that overload of received compared to handled or deadlock can be detected. This involves making BaseStreamHandler and BaseOutputStream record the ints, which means inheritors should subclass ProcessRequest() instead of Handle() However, existing inheriting classes overriding Handle() will still work, albeit without stats recording. "show caps" becomes "show caps list" to disambiguate between show caps commands
2013-07-04Revert "WARNING: BRUTE FORCE DEBUG. AVOID USING THIS COMMIT."Diva Canto1-4/+0
This reverts commit c95a23863ab51810ccc01afd3dd641c18a183305.
2013-07-04WARNING: BRUTE FORCE DEBUG. AVOID USING THIS COMMIT.Diva Canto1-0/+4
2013-06-29Changed HG status notifications timeout down to 15secs from the default 100.Diva Canto1-1/+9
2013-06-29Remove hack to migrate previous experimental-level os materials data.Justin Clark-Casey (justincc)1-9/+0
This didn't seem to be working anyway and it's better not to have such hacks in the code for experimental stuff.