aboutsummaryrefslogtreecommitdiffstatshomepage
Commit message (Collapse)AuthorAgeFilesLines
* Ignore whitespace when reading serialized XML objects.Justin Clark-Casey (justincc)2014-08-299-241/+229
| | | | | | This was previously effectively being done by XmlDocument in the multiple passes through the XML. This change tells XmlReader to ignore whitespace. This also means changing arguments to use XmlReader instead of XmlTextReader (a descendent of XmlReader) directly. XmlReader.Create() has been the recommend way to create XML readers since .NET 2.0 as per MS SDK and is the only way to specific ignore whitespace settings.
* Fix recent regression test TestDeserializeXmlObjectWithOtherParts() which ↵Justin Clark-Casey (justincc)2014-08-291-1/+1
| | | | was not meant to indent the input xml
* Add regression test for deserializing xml objects with more than one ↵Justin Clark-Casey (justincc)2014-08-291-127/+406
| | | | non-root part.
* minor: Eliminate more unnecessary code copying individual parameters for ↵Justin Clark-Casey (justincc)2014-08-281-17/+19
| | | | Vector3 copying in Scene - this is not necessary as Vector3 is a value type
* On code section that rezzes single objects and attachments, reduce CPU use ↵Justin Clark-Casey (justincc)2014-08-285-71/+128
| | | | | | | | by reading asset XML a single time with a stream reader rather than multiple times. Reading large XML documents (e.g. complex attachments) is CPU expensive - this must be done as few times as possible (preferably just once). Reading these documents into XmlDocument is also more resource intensive than using XmlTextReader, as per Microsoft's own publication "Improve .NET Application Performance and Scalability" Optimization of other cases will follow if this change is successful.
* Don't allow update timer to invoke another scene update if the previous is ↵Justin Clark-Casey (justincc)2014-08-261-1/+10
| | | | still active.
* Remove race conditions from where SP.AbsolutePosition could change between ↵Justin Clark-Casey (justincc)2014-08-261-7/+4
| | | | the various property checks.
* Fix frame times when updating scene on timer.Justin Clark-Casey (justincc)2014-08-261-15/+17
|
* Implement experimental non-default mechanism to update scene via a timer ↵Justin Clark-Casey (justincc)2014-08-264-67/+113
| | | | | | | | rather than a persistent thread with sleep. This is to see if an inaccuracy in sleep times under load is responsible for increase in frame times even when there is spare time still available. Can currently only be activated by setting "debug scene set update-on-timer true". Can be switched between timer and thread with sleep updates whilst the scene is running.
* Add back URL endings in examplesBlueWall2014-08-252-4/+4
|
* Remove database connection locking in MySQLXAssetData. This is unnecessary ↵Justin Clark-Casey (justincc)2014-08-221-186/+168
| | | | as connections aren't shared and transactions are already in place where necessary.
* Remove query locking in MySQLUserProfileData. This is not necessary as the ↵Justin Clark-Casey (justincc)2014-08-221-20/+8
| | | | connection is not shared.
* Remove some use of database connection locking from MySQLSimulationData - ↵Justin Clark-Casey (justincc)2014-08-221-318/+298
| | | | | | | | | this has not been necessary for some time as database connections are not shared. However, many locks remain since they may effectively be providing transactionality in some operations (e.g. prim updates across multiple tables). These are candidates for being replaced with proper database transactions, since this would not block unrelated operations (e.g. land save and object save) or unrelated operations on the same tables (e.g. storage of one linkset whilst another is being removed). In practice, any performance deg due to contention is probably rare and short lived as the major prim operations are performed in memory and only persisted some time afterwards.
* Remove lock in MySQLFramework. This is not necessary as the connection is ↵Justin Clark-Casey (justincc)2014-08-221-21/+12
| | | | not shared.
* Removing locking on requests in MySQLAssetData.Justin Clark-Casey (justincc)2014-08-221-161/+144
| | | | | | These locks are not necessary since the connection is taken from the underlying mysql pool and not shared. Such locking is already not done by some other parts of OpenSim.Data.MySQL. Pointed out by arribasim-dev
* Extend drop command to "debug lludp drop <in|out>..." to allow drop of ↵Justin Clark-Casey (justincc)2014-08-192-8/+44
| | | | | | inbound packets. For test/debug purposes.
* Add "debug lludp drop out <add|remove> <packet-name>" console command for ↵Justin Clark-Casey (justincc)2014-08-192-0/+76
| | | | | | | debug/test purposes. This drops all outbound packets that match a given packet name. Can currently only be applied to all connections in a scene.
* minor:Give console feedback when we sit or stand pCampbot bots.Justin Clark-Casey (justincc)2014-08-191-2/+16
| | | | Also only write console lines for actually connected bots.
* Add clientstack.<scene>.OQRERequestsWaiting statJustin Clark-Casey (justincc)2014-08-191-0/+19
| | | | Only present if OQRE is enabled
* Add experimental OutgoingQueueRefillEngine to handle queue refill processing ↵Justin Clark-Casey (justincc)2014-08-193-5/+288
| | | | | | | | | | | on a controlled number of threads rather than the threadpool. Disabled by default. Currently can only be enabled with console "debug lludp oqre start" command, though this can be started and stopped whilst simulator is running. When a connection requires packet queue refill processing (used to populate queues with entity updates, entity prop updates and image queue updates), this is done via Threadpool requests. However, with a very high number of connections (e.g. 100 root + 300 child) a very large number of simultaneous requests may be causing performance issues. This commit adds an experimental engine for processing these requests from a queue with a persistent thread instead. Unlike inbound processing, there are no network requests in this processing that might hold the thread up for a long time. Early implementation - currently only one thread which may (or may not) get overloaded with requests. Added for testing purposes.
* Make LLUDPServer.Scene publicly gettable/privately settable instead of ↵Justin Clark-Casey (justincc)2014-08-193-49/+55
| | | | | | | protected so that other logging code in the clientstack can record more useful information Adds some commented out logging for use again in the future. No functional change.
* Prevent exception if inventory item in llGiveInventory() call doesn't exist.Kevin Cozens2014-08-181-0/+1
|
* Don't allow the last behavior to be removed from a pCampbot botJustin Clark-Casey (justincc)2014-08-152-1/+4
| | | | If you want to stop existing behavious, add the None behaviour.
* Resolve a small race condition on removing bot behaviours that might leave ↵Justin Clark-Casey (justincc)2014-08-151-2/+3
| | | | | | | previous behaviour active Also closes behaviours on disconnect instead of interrupt, though this makes no practical difference. If existing behaviour is None, other added behavious will not take affect until None is removed (as this is an infinite wait until interrupted).
* If a user moves back in sight of a child region before the agent has been ↵Justin Clark-Casey (justincc)2014-08-153-7/+9
| | | | closed on teleport, don't unnecessarily resend all avatar and object data about that region.
* On teleport to a region that already has a child agent established (e.g. a ↵Justin Clark-Casey (justincc)2014-08-157-39/+50
| | | | | | neighbour) don't resend all the initial avatar and object data again. This is unnecessary since it has been received (and data continues to be received) in the existing child connection.
* Added RestrictEmail to make llEmail only send to avatars email address if true.Kevin Cozens2014-08-142-0/+39
|
* Make RootTerseUpdatePeriod and ChildTerseUpdatePeriod configurable in ↵Justin Clark-Casey (justincc)2014-08-142-0/+12
| | | | | | | | | | [InterestManagement] in OpenSim.ini for experimental purposes. If n > 1 for RootTerseUpdatePeriod only every n terse update is actually sent to observers on same region, unless velocity is effectively zero (to stop av drift). If n > 1 for ChildTerseUpdatePeriod only every n terse update is sent to observers in other regions, unless velocity is effectively zero. Defaults are same as before (all packets are sent). Tradeoff is reduction of UDP traffic vs fidelity of observed av mvmt. Increasing n > 1 leads to jerky observed mvmt immediateley for root, though not on child, where experimentally have gone to n = 4 before jerkiness is noticeable.
* Make some existing reprioritization values changeable outside the scene for ↵Justin Clark-Casey (justincc)2014-08-141-15/+18
| | | | | | test purposes, and use more consise property syntax. No functional change.
* Update OpenID server handler with proper interface. fixes ↵BlueWall2014-08-131-1/+1
| | | | http://opensimulator.org/mantis/view.php?id=7301
* On entity transfer of scene presence, replace polling sleep in ↵Justin Clark-Casey (justincc)2014-08-131-14/+13
| | | | | | | SP.WaitForUpdateAgent() with a triggered event instead. Rapid polls are more expensive than triggered events (several polls vs one trigger) and may be problematic on heavily loaded simulators where many threads are vying for processor time. A triggered event is also slightly quicker as there is no maximum 200ms wait between polls.
* Remove redundant origin region lock in SP.CompleteMovement()Justin Clark-Casey (justincc)2014-08-131-6/+1
| | | | This is already going to be correctly set by WaitForUpdateAgent() earlier on in that method, which is always called where a callback to the originating region is required.
* Only set up the UnackedMethod for an outgoing message if that message is ↵Justin Clark-Casey (justincc)2014-08-131-1/+3
| | | | actually meant to get an ack (because it's reliable).
* Terminate 'nothing' behaviour (and potentially others) by signalling using ↵Justin Clark-Casey (justincc)2014-08-135-36/+56
| | | | | | | an event rather than polling connection state every 100ms This kind of polling is very expensive with many bots/polling threads and appears to be the primary cause of bot falloff from the client end at higher loads. Where inbound packet threads can't run in time due to contention and simulator disconnect timeout occurs.
* Add 'server' stats information to pCampbot, as used elsewhere in OpenSimulatorJustin Clark-Casey (justincc)2014-08-135-0/+47
| | | | | This adds the "show stats", "stats record", etc. commands and information on available Threadpool threads, etc. It also adds the Watchdog which logs warnings if time between executions is unexpectedly large.
* For pCampbot, set max number of permitted connections to an endpoint to ↵Justin Clark-Casey (justincc)2014-08-121-0/+4
| | | | | | int.MaxValue This is to avoid issues where many bots connect to a single end point with multiple regions, where each region requires a long-lived poll connection for each bot.
* Update libomv libraries with those built from commit 2208379.Justin Clark-Casey (justincc)2014-08-124-0/+0
| | | | This is to resolve some issues for pCampbot, chiefly with capability connection and inbound handling.
* Avination's Dynamic Floater Module. This works with Singularity viewer only.Melanie Thielker2014-08-122-0/+290
| | | | | It's WIP in that a dialog builder is on it's way. For now, the XML needs to be handmade.
* Move the inventory request lock introduced in git master a58152bd to ↵Justin Clark-Casey (justincc)2014-08-092-27/+47
| | | | | | | HGInventoryBroker to preserve that behaviour there but allow 2 simultaneous inv requests (chiefly WebFetch) rather than 1 This lock serialized all requests and made the inventory throttling in WebFetch redundant. By moving this lock, two simultaneous requests may now take place which may help with http://opensimulator.org/mantis/view.php?id=7054
* Change RootRotationUpdateTolerance from 0.01 to 0.1 in code as well.Justin Clark-Casey (justincc)2014-08-081-1/+1
|
* Change MaxPoolThreads default in code as well from 15 to 300Justin Clark-Casey (justincc)2014-08-081-1/+1
|
* Reduce default rotation AgentUpdate output sensitivity to a setting that ↵Justin Clark-Casey (justincc)2014-08-081-1/+1
| | | | | | | | | | cuts down UDP traffic without obvious adverse effects on observed avatar rotations. Experimentally, on the Linden Lab grid the avatar can rotate slightly before triggering AvatarUpdates, whereas this is practically impossible in OpenSimulator. These updates allow other avatars to see rotations, though sensitivity is low since other avatars can only be seen in one of 8 body rotations. This commit changes sensitivity from 0.01 to 0.1, which better matches LL and reduces UDP traffic which has a beneficial impact on network and CPU load. This has no impact on rotations in the simulator itself so simulation fidelity is the same as before. To change this setting back for test/other purposes, edit RootRotationUpdateTolerance in the [InterestManagement] section of OpenSim.ini
* Change default max threads if SmartThreadPool is used as the main thread ↵Justin Clark-Casey (justincc)2014-08-081-1/+1
| | | | | | | | | pool from 15 to 300 Running out of such threads under heavy load causes delayed packet processing which can lead to spurious UDP resends and knock on issues. We already massively boost the min/max builtin pool worker and IOCP threads (which even with STP are still used for inbound network requests) without obvious adverse effects. The threads are only instantiated if they are required. This change does not affect other async_call_method options.
* Fix short help string for show region command.BlueWall2014-08-061-1/+1
|
* OpenSimExtrasBlueWall2014-08-0615-434/+182
| | | | Move the experimental extra features functionality into the GridService. This sends default values for map, search and destination guide, plus ExportSupported control to the region on startup. Please watch http://opensimulator.org/wiki/SimulatorFeatures_Extras for changes and documentation.
* Fixed crash when using Allowed/Denied Viewers, and the viewer's name is ↵Oren Hurvitz2014-08-061-2/+2
| | | | | | shorter than one of the test strings This fixes http://opensimulator.org/mantis/view.php?id=7294
* Add RootPositionUpdateTolerance, RootRotationUpdateTolerance, and ↵Justin Clark-Casey (justincc)2014-08-062-8/+23
| | | | | | | RootVelocityUpdateTolerance parameters to [InterestManagement] in OpenSimDefaults.ini These govern when AgentUpdates are sent to observers on position, rotation and velocity changes to an avatar (including the avatar themselves). Higher values reduce AgentUpdate traffic but at a certain level will degrade smoothness of avatar and perceived avatar movement.
* refactor: Rename recent new Client*UpdateTolerance to Root*UpdateTolerance ↵Justin Clark-Casey (justincc)2014-08-063-19/+19
| | | | for better accuracy and consistency with other similar parameters
* Fixed premature closing of the connection in DataSnapshotManagerOren Hurvitz2014-08-051-14/+14
|
* Go back to disconnecting bots in parallel since serially is too slow.Justin Clark-Casey (justincc)2014-08-051-3/+5
| | | | However, disconnecting now halts any current connection, with the possible exception of the single currently connecting bot.