32 files changed, 1408 insertions, 777 deletions
diff --git a/OpenSim/Region/ClientStack/LindenUDP/LLClientView.cs b/OpenSim/Region/ClientStack/LindenUDP/LLClientView.cs
index 4221212..ac16b02 100644
--- a/OpenSim/Region/ClientStack/LindenUDP/LLClientView.cs
+++ b/OpenSim/Region/ClientStack/LindenUDP/LLClientView.cs
@@ -785,6 +785,10 @@ namespace OpenSim.Region.ClientStack.LindenUDP
        public virtual void SendLayerData(float[] map)
        {
            Util.FireAndForget(DoSendLayerData, map);
+            // Send it sync, and async. It's not that much data
+            // and it improves user experience just so much!
+            DoSendLayerData(map);
        }
        /// <summary>
@@ -797,16 +801,13 @@ namespace OpenSim.Region.ClientStack.LindenUDP
            try
            {
-                //for (int y = 0; y < 16; y++)
+                for (int y = 0; y < 16; y++)
-                //{
+                {
-                //    for (int x = 0; x < 16; x++)
+                    for (int x = 0; x < 16; x+=4)
-                //    {
+                    {
-                //        SendLayerData(x, y, map);
+                        SendLayerPacket(x, y, map);
-                //    }
+                    }
-                //}
+                }
-                // Send LayerData in a spiral pattern. Fun!
-                SendLayerTopRight(map, 0, 0, 15, 15);
            }
            catch (Exception e)
            {
@@ -814,51 +815,35 @@ namespace OpenSim.Region.ClientStack.LindenUDP
            }
        }
-        private void SendLayerTopRight(float[] map, int x1, int y1, int x2, int y2)
-        {
-            // Row
-            for (int i = x1; i <= x2; i++)
-                SendLayerData(i, y1, map);
-            // Column
-            for (int j = y1 + 1; j <= y2; j++)
-                SendLayerData(x2, j, map);
-            if (x2 - x1 > 0)
-                SendLayerBottomLeft(map, x1, y1 + 1, x2 - 1, y2);
-        }
-        void SendLayerBottomLeft(float[] map, int x1, int y1, int x2, int y2)
-        {
-            // Row in reverse
-            for (int i = x2; i >= x1; i--)
-                SendLayerData(i, y2, map);
-            // Column in reverse
-            for (int j = y2 - 1; j >= y1; j--)
-                SendLayerData(x1, j, map);
-            if (x2 - x1 > 0)
-                SendLayerTopRight(map, x1 + 1, y1, x2, y2 - 1);
-        }
        /// <summary>
        /// Sends a set of four patches (x, x+1, ..., x+3) to the client
        /// </summary>
        /// <param name="map">heightmap</param>
        /// <param name="px">X coordinate for patches 0..12</param>
        /// <param name="py">Y coordinate for patches 0..15</param>
-        // private void SendLayerPacket(float[] map, int y, int x)
+        private void SendLayerPacket(int x, int y, float[] map)
-        // {
+        {
-        //     int[] patches = new int[4];
+            int[] patches = new int[4];
-        //     patches[0] = x + 0 + y * 16;
+            patches[0] = x + 0 + y * 16;
-        //     patches[1] = x + 1 + y * 16;
+            patches[1] = x + 1 + y * 16;
-        //     patches[2] = x + 2 + y * 16;
+            patches[2] = x + 2 + y * 16;
-        //     patches[3] = x + 3 + y * 16;
+            patches[3] = x + 3 + y * 16;
-        //     Packet layerpack = LLClientView.TerrainManager.CreateLandPacket(map, patches);
+            float[] heightmap = (map.Length == 65536) ?
-        //     OutPacket(layerpack, ThrottleOutPacketType.Land);
+                map :
-        // }
+                LLHeightFieldMoronize(map);
+            try
+            {
+                Packet layerpack = TerrainCompressor.CreateLandPacket(heightmap, patches);
+                OutPacket(layerpack, ThrottleOutPacketType.Land);
+            }
+            catch
+            {
+                for (int px = x ; px < x + 4 ; px++)
+                    SendLayerData(px, y, map);
+            }
+        }
        /// <summary>
        /// Sends a specified patch to a client
@@ -3136,7 +3121,6 @@ namespace OpenSim.Region.ClientStack.LindenUDP
            objupdate.ObjectData = new ObjectUpdatePacket.ObjectDataBlock[1];
            objupdate.ObjectData[0] = CreateAvatarUpdateBlock(data);
            OutPacket(objupdate, ThrottleOutPacketType.Task);
        }
@@ -3187,8 +3171,7 @@ namespace OpenSim.Region.ClientStack.LindenUDP
                    terse.ObjectData[i] = m_avatarTerseUpdates.Dequeue();
            }
-            // HACK: Using the task category until the tiered reprioritization code is in
+            OutPacket(terse, ThrottleOutPacketType.State);
-            OutPacket(terse, ThrottleOutPacketType.Task);
        }
        public void SendCoarseLocationUpdate(List<UUID> users, List<Vector3> CoarseLocations)
diff --git a/OpenSim/Region/ClientStack/LindenUDP/LLUDPServer.cs b/OpenSim/Region/ClientStack/LindenUDP/LLUDPServer.cs
index c773c05..98bb4f7 100644
--- a/OpenSim/Region/ClientStack/LindenUDP/LLUDPServer.cs
+++ b/OpenSim/Region/ClientStack/LindenUDP/LLUDPServer.cs
@@ -399,6 +399,7 @@ namespace OpenSim.Region.ClientStack.LindenUDP
            #region Queue or Send
            OutgoingPacket outgoingPacket = new OutgoingPacket(udpClient, buffer, category);
+            outgoingPacket.Type = type;
            if (!outgoingPacket.Client.EnqueueOutgoing(outgoingPacket))
                SendPacketFinal(outgoingPacket);
@@ -510,6 +511,7 @@ namespace OpenSim.Region.ClientStack.LindenUDP
            byte flags = buffer.Data[0];
            bool isResend = (flags & Helpers.MSG_RESENT) != 0;
            bool isReliable = (flags & Helpers.MSG_RELIABLE) != 0;
+            bool sendSynchronous = false;
            LLUDPClient udpClient = outgoingPacket.Client;
            if (!udpClient.IsConnected)
@@ -565,9 +567,28 @@ namespace OpenSim.Region.ClientStack.LindenUDP
            if (isReliable)
                Interlocked.Add(ref udpClient.UnackedBytes, outgoingPacket.Buffer.DataLength);
-            // Put the UDP payload on the wire
+            //Some packet types need to be sent synchonously.
-            AsyncBeginSend(buffer);
+            //Sorry, i know it's not optimal, but until the LL client
+            //manages packets correctly and re-orders them as required, this is necessary.
+            
+            // Put the UDP payload on the wire
+            if (outgoingPacket.Type == PacketType.ImprovedTerseObjectUpdate)
+            {
+                SyncBeginPrioritySend(buffer, 2); // highest priority
+            }
+            else if (outgoingPacket.Type == PacketType.ObjectUpdate
+                || outgoingPacket.Type == PacketType.LayerData)
+            {
+                SyncBeginPrioritySend(buffer, 1); // medium priority
+            }
+            else
+            {
+                SyncBeginPrioritySend(buffer, 0); // normal priority
+            }
+            
+            //AsyncBeginSend(buffer);
+            
            // Keep track of when this packet was sent out (right now)
            outgoingPacket.TickCount = Environment.TickCount & Int32.MaxValue;
        }
@@ -842,7 +863,7 @@ namespace OpenSim.Region.ClientStack.LindenUDP
            Buffer.BlockCopy(packetData, 0, buffer.Data, 0, length);
-            AsyncBeginSend(buffer);
+            SyncBeginPrioritySend(buffer, 1); //Setting this to a medium priority should help minimise resends
        }
        private bool IsClientAuthorized(UseCircuitCodePacket useCircuitCode, out AuthenticateResponse sessionInfo)
diff --git a/OpenSim/Region/ClientStack/LindenUDP/OpenSimUDPBase.cs b/OpenSim/Region/ClientStack/LindenUDP/OpenSimUDPBase.cs
index d2779ba..de2cd24 100644
--- a/OpenSim/Region/ClientStack/LindenUDP/OpenSimUDPBase.cs
+++ b/OpenSim/Region/ClientStack/LindenUDP/OpenSimUDPBase.cs
@@ -29,6 +29,7 @@ using System;
 using System.Net;
 using System.Net.Sockets;
 using System.Threading;
+using System.Collections.Generic;
 using log4net;
 namespace OpenMetaverse
@@ -52,12 +53,30 @@ namespace OpenMetaverse
        /// <summary>Local IP address to bind to in server mode</summary>
        protected IPAddress m_localBindAddress;
+        /// <summary>
+        /// Standard queue for our outgoing SyncBeginPrioritySend
+        /// </summary>
+        private List<UDPPacketBuffer> m_standardQueue = new List<UDPPacketBuffer>();
+        /// <summary>
+        /// Medium priority queue for our outgoing SyncBeginPrioritySend
+        /// </summary>
+        private List<UDPPacketBuffer> m_mediumPriorityQueue = new List<UDPPacketBuffer>();
+        /// <summary>
+        /// Prioritised queue for our outgoing SyncBeginPrioritySend
+        /// </summary>
+        private List<UDPPacketBuffer> m_priorityQueue = new List<UDPPacketBuffer>();
        /// <summary>UDP socket, used in either client or server mode</summary>
        private Socket m_udpSocket;
        /// <summary>Flag to process packets asynchronously or synchronously</summary>
        private bool m_asyncPacketHandling;
+        /// <summary>Are we currently sending data asynchronously?</summary>
+        private volatile bool m_sendingData = false;
        /// <summary>The all important shutdown flag</summary>
        private volatile bool m_shutdownFlag = true;
@@ -246,7 +265,51 @@ namespace OpenMetaverse
            }
        }
-        public void AsyncBeginSend(UDPPacketBuffer buf)
+        public void SyncBeginPrioritySend(UDPPacketBuffer buf, int Priority)
+        {
+            if (!m_shutdownFlag)
+            {
+                if (!m_sendingData)
+                {
+                    m_sendingData = true;
+                    try
+                    {
+                        AsyncBeginSend(buf);
+                    }
+                    catch (SocketException) { }
+                    catch (ObjectDisposedException) { }
+                }
+                else
+                {
+                    if (Priority == 2)
+                    {
+                        lock (m_priorityQueue)
+                        {
+                            m_priorityQueue.Add(buf);
+                        }
+                    }
+                    else
+                    {
+                        if (Priority != 0)
+                        {
+                            lock (m_mediumPriorityQueue)
+                            {
+                                m_mediumPriorityQueue.Add(buf);
+                            }
+                        }
+                        else
+                        {
+                            lock (m_standardQueue)
+                            {
+                                m_standardQueue.Add(buf);
+                            }
+                        }
+                    }
+                }
+            }
+        }
+        private void AsyncBeginSend(UDPPacketBuffer buf)
        {
            if (!m_shutdownFlag)
            {
@@ -270,8 +333,48 @@ namespace OpenMetaverse
        {
            try
            {
-//                UDPPacketBuffer buf = (UDPPacketBuffer)result.AsyncState;
                m_udpSocket.EndSendTo(result);
+                if (m_sendingData)
+                {
+                    lock (m_priorityQueue)
+                    {
+                        if (m_priorityQueue.Count > 0)
+                        {
+                            UDPPacketBuffer buf = m_priorityQueue[0];
+                            m_priorityQueue.RemoveAt(0);
+                            AsyncBeginSend(buf);
+                        }
+                        else
+                        {
+                            lock (m_mediumPriorityQueue)
+                            {
+                                if (m_mediumPriorityQueue.Count > 0)
+                                {
+                                    UDPPacketBuffer buf = m_mediumPriorityQueue[0];
+                                    m_mediumPriorityQueue.RemoveAt(0);
+                                    AsyncBeginSend(buf);
+                                }
+                                else
+                                {
+                                    lock (m_standardQueue)
+                                    {
+                                        if (m_standardQueue.Count > 0)
+                                        {
+                                            UDPPacketBuffer buf = m_standardQueue[0];
+                                            m_standardQueue.RemoveAt(0);
+                                            AsyncBeginSend(buf);
+                                        }
+                                        else
+                                        {
+                                            m_sendingData = false;
+                                        }
+                                    }
+                                }
+                            }
+                        }
+                    }
+                }
            }
            catch (SocketException) { }
            catch (ObjectDisposedException) { }
diff --git a/OpenSim/Region/ClientStack/LindenUDP/OutgoingPacket.cs b/OpenSim/Region/ClientStack/LindenUDP/OutgoingPacket.cs
index 1a1a1cb..7dc42d3 100644
--- a/OpenSim/Region/ClientStack/LindenUDP/OutgoingPacket.cs
+++ b/OpenSim/Region/ClientStack/LindenUDP/OutgoingPacket.cs
@@ -28,6 +28,7 @@
 using System;
 using OpenSim.Framework;
 using OpenMetaverse;
+using OpenMetaverse.Packets;
 namespace OpenSim.Region.ClientStack.LindenUDP
 {
@@ -52,7 +53,8 @@ namespace OpenSim.Region.ClientStack.LindenUDP
        public int TickCount;
        /// <summary>Category this packet belongs to</summary>
        public ThrottleOutPacketType Category;
+        /// <summary>The type of packet so its delivery method can be determined</summary>
+        public PacketType Type;
        /// <summary>
        /// Default constructor
        /// </summary>
diff --git a/OpenSim/Region/CoreModules/Avatar/Chat/ChatModule.cs b/OpenSim/Region/CoreModules/Avatar/Chat/ChatModule.cs
index cd59bdb..1e63e3e 100644
--- a/OpenSim/Region/CoreModules/Avatar/Chat/ChatModule.cs
+++ b/OpenSim/Region/CoreModules/Avatar/Chat/ChatModule.cs
@@ -49,7 +49,7 @@ namespace OpenSim.Region.CoreModules.Avatar.Chat
        private int m_shoutdistance = 100;
        private int m_whisperdistance = 10;
        private List<Scene> m_scenes = new List<Scene>();
+        private string m_adminPrefix = "";
        internal object m_syncy = new object();
        internal IConfig m_config;
@@ -76,6 +76,7 @@ namespace OpenSim.Region.CoreModules.Avatar.Chat
            m_whisperdistance = config.Configs["Chat"].GetInt("whisper_distance", m_whisperdistance);
            m_saydistance = config.Configs["Chat"].GetInt("say_distance", m_saydistance);
            m_shoutdistance = config.Configs["Chat"].GetInt("shout_distance", m_shoutdistance);
+            m_adminPrefix = config.Configs["Chat"].GetString("admin_prefix", "");
        }
        public virtual void AddRegion(Scene scene)
@@ -185,6 +186,7 @@ namespace OpenSim.Region.CoreModules.Avatar.Chat
        protected virtual void DeliverChatToAvatars(ChatSourceType sourceType, OSChatMessage c)
        {
            string fromName = c.From;
+            string fromNamePrefix = "";
            UUID fromID = UUID.Zero;
            string message = c.Message;
            IScene scene = c.Scene;
@@ -207,7 +209,10 @@ namespace OpenSim.Region.CoreModules.Avatar.Chat
                fromPos = avatar.AbsolutePosition;
                fromName = avatar.Name;
                fromID = c.Sender.AgentId;
+                if (avatar.GodLevel > 200)
+                {
+                    fromNamePrefix = m_adminPrefix;
+                }
                break;
            case ChatSourceType.Object:
@@ -227,7 +232,7 @@ namespace OpenSim.Region.CoreModules.Avatar.Chat
                s.ForEachScenePresence(
                    delegate(ScenePresence presence)
                    {
-                        TrySendChatMessage(presence, fromPos, regionPos, fromID, fromName, c.Type, message, sourceType);
+                        TrySendChatMessage(presence, fromPos, regionPos, fromID, fromNamePrefix+fromName, c.Type, message, sourceType);
                    }
                );
            }
@@ -266,25 +271,29 @@ namespace OpenSim.Region.CoreModules.Avatar.Chat
            }
            
            // m_log.DebugFormat("[CHAT] Broadcast: fromID {0} fromName {1}, cType {2}, sType {3}", fromID, fromName, cType, sourceType);
+            if (c.Scene != null)
-            ((Scene)c.Scene).ForEachScenePresence(
+            {
-                delegate(ScenePresence presence)
+                ((Scene)c.Scene).ForEachScenePresence
-                {
+                (
-                    // ignore chat from child agents
+                    delegate(ScenePresence presence)
-                    if (presence.IsChildAgent) return;
+                    {
-                    
+                        // ignore chat from child agents
-                    IClientAPI client = presence.ControllingClient;
+                        if (presence.IsChildAgent) return;
-                    
+                        
-                    // don't forward SayOwner chat from objects to
+                        IClientAPI client = presence.ControllingClient;
-                    // non-owner agents
+                        
-                    if ((c.Type == ChatTypeEnum.Owner) &&
+                        // don't forward SayOwner chat from objects to
-                        (null != c.SenderObject) &&
+                        // non-owner agents
-                        (((SceneObjectPart)c.SenderObject).OwnerID != client.AgentId))
+                        if ((c.Type == ChatTypeEnum.Owner) &&
-                        return;
+                            (null != c.SenderObject) &&
-                    
+                            (((SceneObjectPart)c.SenderObject).OwnerID != client.AgentId))
-                    client.SendChatMessage(c.Message, (byte)cType, CenterOfRegion, fromName, fromID, 
+                            return;
-                                           (byte)sourceType, (byte)ChatAudibleLevel.Fully);
+                        
-                });
+                        client.SendChatMessage(c.Message, (byte)cType, CenterOfRegion, fromName, fromID, 
+                                               (byte)sourceType, (byte)ChatAudibleLevel.Fully);
+                    }
+                );
+             }
        }
diff --git a/OpenSim/Region/CoreModules/Avatar/InstantMessage/OfflineMessageModule.cs b/OpenSim/Region/CoreModules/Avatar/InstantMessage/OfflineMessageModule.cs
index 1614b70..7f9e5af 100644
--- a/OpenSim/Region/CoreModules/Avatar/InstantMessage/OfflineMessageModule.cs
+++ b/OpenSim/Region/CoreModules/Avatar/InstantMessage/OfflineMessageModule.cs
@@ -164,19 +164,22 @@ namespace OpenSim.Region.CoreModules.Avatar.InstantMessage
            List<GridInstantMessage>msglist = SynchronousRestObjectPoster.BeginPostObject<UUID, List<GridInstantMessage>>(
                    "POST", m_RestURL+"/RetrieveMessages/", client.AgentId);
-            foreach (GridInstantMessage im in msglist)
+            if (msglist != null)
            {
-                // client.SendInstantMessage(im);
+                foreach (GridInstantMessage im in msglist)
+                {
-                // Send through scene event manager so all modules get a chance
+                    // client.SendInstantMessage(im);
-                // to look at this message before it gets delivered.
-                //
+                    // Send through scene event manager so all modules get a chance
-                // Needed for proper state management for stored group
+                    // to look at this message before it gets delivered.
-                // invitations
+                    //
-                //
+                    // Needed for proper state management for stored group
-                Scene s = FindScene(client.AgentId);
+                    // invitations
-                if (s != null)
+                    //
-                    s.EventManager.TriggerIncomingInstantMessage(im);
+                    Scene s = FindScene(client.AgentId);
+                    if (s != null)
+                        s.EventManager.TriggerIncomingInstantMessage(im);
+                }
            }
        }
diff --git a/OpenSim/Region/CoreModules/Avatar/Inventory/Transfer/InventoryTransferModule.cs b/OpenSim/Region/CoreModules/Avatar/Inventory/Transfer/InventoryTransferModule.cs
index d9a021f..b60b32b 100644
--- a/OpenSim/Region/CoreModules/Avatar/Inventory/Transfer/InventoryTransferModule.cs
+++ b/OpenSim/Region/CoreModules/Avatar/Inventory/Transfer/InventoryTransferModule.cs
@@ -389,7 +389,7 @@ namespace OpenSim.Region.CoreModules.Avatar.Inventory.Transfer
        {
            // Check if this is ours to handle
            //
-            m_log.Info("OnFridInstantMessage");
+            //m_log.Info("OnFridInstantMessage");
            if (msg.dialog != (byte) InstantMessageDialog.InventoryOffered)
                return;
diff --git a/OpenSim/Region/CoreModules/World/Archiver/ArchiveReadRequest.cs b/OpenSim/Region/CoreModules/World/Archiver/ArchiveReadRequest.cs
index 34b81d8..114dd13 100644
--- a/OpenSim/Region/CoreModules/World/Archiver/ArchiveReadRequest.cs
+++ b/OpenSim/Region/CoreModules/World/Archiver/ArchiveReadRequest.cs
@@ -247,21 +247,20 @@ namespace OpenSim.Region.CoreModules.World.Archiver
                    // Fix ownership/creator of inventory items
                    // Not doing so results in inventory items
                    // being no copy/no mod for everyone
-                    lock (part.TaskInventory)
+                    part.TaskInventory.LockItemsForRead(true);
+                    TaskInventoryDictionary inv = part.TaskInventory;
+                    foreach (KeyValuePair<UUID, TaskInventoryItem> kvp in inv)
                    {
-                        TaskInventoryDictionary inv = part.TaskInventory;
+                        if (!ResolveUserUuid(kvp.Value.OwnerID))
-                        foreach (KeyValuePair<UUID, TaskInventoryItem> kvp in inv)
                        {
-                            if (!ResolveUserUuid(kvp.Value.OwnerID))
+                            kvp.Value.OwnerID = masterAvatarId;
-                            {
+                        }
-                                kvp.Value.OwnerID = masterAvatarId;
+                        if (!ResolveUserUuid(kvp.Value.CreatorID))
-                            }
+                        {
-                            if (!ResolveUserUuid(kvp.Value.CreatorID))
+                            kvp.Value.CreatorID = masterAvatarId;
-                            {
-                                kvp.Value.CreatorID = masterAvatarId;
-                            }
                        }
                    }
+                    part.TaskInventory.LockItemsForRead(false);
                }
                if (m_scene.AddRestoredSceneObject(sceneObject, true, false))
diff --git a/OpenSim/Region/Framework/Scenes/Animation/ScenePresenceAnimator.cs b/OpenSim/Region/Framework/Scenes/Animation/ScenePresenceAnimator.cs
index 2e4c260..30a95ce 100644
--- a/OpenSim/Region/Framework/Scenes/Animation/ScenePresenceAnimator.cs
+++ b/OpenSim/Region/Framework/Scenes/Animation/ScenePresenceAnimator.cs
@@ -156,8 +156,8 @@ namespace OpenSim.Region.Framework.Scenes.Animation
            Vector3 left = Vector3.Transform(Vector3.UnitY, rotMatrix);
            // Check control flags
-            bool heldForward = (controlFlags & AgentManager.ControlFlags.AGENT_CONTROL_AT_POS) == AgentManager.ControlFlags.AGENT_CONTROL_AT_POS;
+            bool heldForward = ((controlFlags & AgentManager.ControlFlags.AGENT_CONTROL_AT_POS) == AgentManager.ControlFlags.AGENT_CONTROL_AT_POS || (controlFlags & AgentManager.ControlFlags.AGENT_CONTROL_NUDGE_AT_POS) == AgentManager.ControlFlags.AGENT_CONTROL_NUDGE_AT_POS);
-            bool heldBack = (controlFlags & AgentManager.ControlFlags.AGENT_CONTROL_AT_NEG) == AgentManager.ControlFlags.AGENT_CONTROL_AT_NEG;
+            bool heldBack = ((controlFlags & AgentManager.ControlFlags.AGENT_CONTROL_AT_NEG) == AgentManager.ControlFlags.AGENT_CONTROL_AT_NEG || (controlFlags & AgentManager.ControlFlags.AGENT_CONTROL_NUDGE_AT_NEG) == AgentManager.ControlFlags.AGENT_CONTROL_NUDGE_AT_NEG);
            bool heldLeft = (controlFlags & AgentManager.ControlFlags.AGENT_CONTROL_LEFT_POS) == AgentManager.ControlFlags.AGENT_CONTROL_LEFT_POS;
            bool heldRight = (controlFlags & AgentManager.ControlFlags.AGENT_CONTROL_LEFT_NEG) == AgentManager.ControlFlags.AGENT_CONTROL_LEFT_NEG;
            //bool heldTurnLeft = (controlFlags & AgentManager.ControlFlags.AGENT_CONTROL_TURN_LEFT) == AgentManager.ControlFlags.AGENT_CONTROL_TURN_LEFT;
diff --git a/OpenSim/Region/Framework/Scenes/Scene.Inventory.cs b/OpenSim/Region/Framework/Scenes/Scene.Inventory.cs
index 66fb918..83208e9 100644
--- a/OpenSim/Region/Framework/Scenes/Scene.Inventory.cs
+++ b/OpenSim/Region/Framework/Scenes/Scene.Inventory.cs
@@ -840,8 +840,12 @@ namespace OpenSim.Region.Framework.Scenes
        public void RemoveTaskInventory(IClientAPI remoteClient, UUID itemID, uint localID)
        {
            SceneObjectPart part = GetSceneObjectPart(localID);
-            SceneObjectGroup group = part.ParentGroup;
+            SceneObjectGroup group = null;
-            if (group != null)
+            if (part != null)
+            {
+                group = part.ParentGroup;
+            }            
+            if (part != null && group != null)
            {
                TaskInventoryItem item = group.GetInventoryItem(localID, itemID);
                if (item == null)
diff --git a/OpenSim/Region/Framework/Scenes/Scene.cs b/OpenSim/Region/Framework/Scenes/Scene.cs
index f444e51..4ffa1a2 100644
--- a/OpenSim/Region/Framework/Scenes/Scene.cs
+++ b/OpenSim/Region/Framework/Scenes/Scene.cs
@@ -1164,16 +1164,16 @@ namespace OpenSim.Region.Framework.Scenes
                    // Check if any objects have reached their targets
                    CheckAtTargets();
-                    // Update SceneObjectGroups that have scheduled themselves for updates
-                    // Objects queue their updates onto all scene presences
-                    if (m_frame % m_update_objects == 0)
-                        m_sceneGraph.UpdateObjectGroups();
                    // Run through all ScenePresences looking for updates
                    // Presence updates and queued object updates for each presence are sent to clients
                    if (m_frame % m_update_presences == 0)
                        m_sceneGraph.UpdatePresences();
+                    // Update SceneObjectGroups that have scheduled themselves for updates
+                    // Objects queue their updates onto all scene presences
+                    if (m_frame % m_update_objects == 0)
+                        m_sceneGraph.UpdateObjectGroups();
                    int TempPhysicsMS2 = Environment.TickCount;
                    if ((m_frame % m_update_physics == 0) && m_physics_enabled)
                        m_sceneGraph.UpdatePreparePhysics();
diff --git a/OpenSim/Region/Framework/Scenes/SceneObjectGroup.cs b/OpenSim/Region/Framework/Scenes/SceneObjectGroup.cs
index bcc9b37..ea4f2c7 100644
--- a/OpenSim/Region/Framework/Scenes/SceneObjectGroup.cs
+++ b/OpenSim/Region/Framework/Scenes/SceneObjectGroup.cs
@@ -1734,6 +1734,45 @@ namespace OpenSim.Region.Framework.Scenes
            }
        }
+        public void rotLookAt(Quaternion target, float strength, float damping)
+        {
+            SceneObjectPart rootpart = m_rootPart;
+            if (rootpart != null)
+            {
+                if (IsAttachment)
+                {
+                /*
+                    ScenePresence avatar = m_scene.GetScenePresence(rootpart.AttachedAvatar);
+                    if (avatar != null)
+                    {
+                    Rotate the Av?
+                    } */
+                }
+                else
+                {
+                    if (rootpart.PhysActor != null)
+                    {
+                        rootpart.PhysActor.APIDTarget = new Quaternion(target.X, target.Y, target.Z, target.W);
+                        rootpart.PhysActor.APIDStrength = strength;
+                        rootpart.PhysActor.APIDDamping = damping;
+                        rootpart.PhysActor.APIDActive = true;
+                    }
+                }
+            }
+        }
+        public void stopLookAt()
+        {
+            SceneObjectPart rootpart = m_rootPart;
+            if (rootpart != null)
+            {
+                if (rootpart.PhysActor != null)
+                {
+                    rootpart.PhysActor.APIDActive = false;
+                }
+            }
+        
+        }
        /// <summary>
        /// Uses a PID to attempt to clamp the object on the Z axis at the given height over tau seconds.
        /// </summary>
diff --git a/OpenSim/Region/Framework/Scenes/SceneObjectPart.cs b/OpenSim/Region/Framework/Scenes/SceneObjectPart.cs
index 6f1b458..bbece2f 100644
--- a/OpenSim/Region/Framework/Scenes/SceneObjectPart.cs
+++ b/OpenSim/Region/Framework/Scenes/SceneObjectPart.cs
@@ -389,12 +389,16 @@ namespace OpenSim.Region.Framework.Scenes
        }
        /// <value>
-        /// Access should be via Inventory directly - this property temporarily remains for xml serialization purposes
+        /// Get the inventory list
        /// </value>
        public TaskInventoryDictionary TaskInventory
        {
-            get { return m_inventory.Items; }
+            get {
-            set { m_inventory.Items = value; }
+                return m_inventory.Items;
+            }
+            set {
+                m_inventory.Items = value;
+            }
        }
        public uint ObjectFlags
@@ -1064,14 +1068,6 @@ namespace OpenSim.Region.Framework.Scenes
            }
        }
-        /// <summary>
-        /// Clear all pending updates of parts to clients
-        /// </summary>
-        private void ClearUpdateSchedule()
-        {
-            m_updateFlag = 0;
-        }
        private void SendObjectPropertiesToClient(UUID AgentID)
        {
            ScenePresence[] avatars = m_parentGroup.Scene.GetScenePresences();
@@ -2109,17 +2105,18 @@ namespace OpenSim.Region.Framework.Scenes
                //Trys to fetch sound id from prim's inventory.
                //Prim's inventory doesn't support non script items yet
                
-                lock (TaskInventory)
+                TaskInventory.LockItemsForRead(true);
+                foreach (KeyValuePair<UUID, TaskInventoryItem> item in TaskInventory)
                {
-                    foreach (KeyValuePair<UUID, TaskInventoryItem> item in TaskInventory)
+                    if (item.Value.Name == sound)
                    {
-                        if (item.Value.Name == sound)
+                        soundID = item.Value.ItemID;
-                        {
+                        break;
-                            soundID = item.Value.ItemID;
-                            break;
-                        }
                    }
                }
+                TaskInventory.LockItemsForRead(false);
            }
            List<ScenePresence> avatarts = m_parentGroup.Scene.GetAvatars();
@@ -2185,6 +2182,11 @@ namespace OpenSim.Region.Framework.Scenes
            ParentGroup.HasGroupChanged = true;
            ScheduleFullUpdate();
        }
+        
+        public void RotLookAt(Quaternion target, float strength, float damping)
+        {
+            m_parentGroup.rotLookAt(target, strength, damping);
+        }
        /// <summary>
        /// Schedules this prim for a full update
@@ -2389,8 +2391,8 @@ namespace OpenSim.Region.Framework.Scenes
        {
            const float ROTATION_TOLERANCE = 0.01f;
            const float VELOCITY_TOLERANCE = 0.001f;
-            const float POSITION_TOLERANCE = 0.05f;
+            const float POSITION_TOLERANCE = 0.05f; // I don't like this, but I suppose it's necessary
-            const int TIME_MS_TOLERANCE = 3000;
+            const int TIME_MS_TOLERANCE = 200; //llSetPos has a 200ms delay. This should NOT be 3 seconds.
            if (m_updateFlag == 1)
            {
@@ -2404,7 +2406,7 @@ namespace OpenSim.Region.Framework.Scenes
                    Environment.TickCount - m_lastTerseSent > TIME_MS_TOLERANCE)
                {
                    AddTerseUpdateToAllAvatars();
-                    ClearUpdateSchedule();
+                    
                    // This causes the Scene to 'poll' physical objects every couple of frames
                    // bad, so it's been replaced by an event driven method.
@@ -2422,16 +2424,18 @@ namespace OpenSim.Region.Framework.Scenes
                    m_lastAngularVelocity = AngularVelocity;
                    m_lastTerseSent = Environment.TickCount;
                }
+                //Moved this outside of the if clause so updates don't get blocked.. *sigh*
+                m_updateFlag = 0; //Why were we calling a function to do this? Inefficient! *screams* 
            }
            else
            {
                if (m_updateFlag == 2) // is a new prim, just created/reloaded or has major changes
                {
                    AddFullUpdateToAllAvatars();
-                    ClearUpdateSchedule();
+                    m_updateFlag = 0; //Same here
                }
            }
-            ClearUpdateSchedule();
+            m_updateFlag = 0;
        }
        /// <summary>
@@ -2458,17 +2462,16 @@ namespace OpenSim.Region.Framework.Scenes
            if (!UUID.TryParse(sound, out soundID))
            {
                // search sound file from inventory
-                lock (TaskInventory)
+                TaskInventory.LockItemsForRead(true);
+                foreach (KeyValuePair<UUID, TaskInventoryItem> item in TaskInventory)
                {
-                    foreach (KeyValuePair<UUID, TaskInventoryItem> item in TaskInventory)
+                    if (item.Value.Name == sound && item.Value.Type == (int)AssetType.Sound)
                    {
-                        if (item.Value.Name == sound && item.Value.Type == (int)AssetType.Sound)
+                        soundID = item.Value.ItemID;
-                        {
+                        break;
-                            soundID = item.Value.ItemID;
-                            break;
-                        }
                    }
                }
+                TaskInventory.LockItemsForRead(false);
            }
            if (soundID == UUID.Zero)
@@ -2684,6 +2687,13 @@ namespace OpenSim.Region.Framework.Scenes
            SetText(text);
        }
+        public void StopLookAt()
+        {
+            m_parentGroup.stopLookAt();
+            m_parentGroup.ScheduleGroupForTerseUpdate();        
+        }        
+        
        public void StopMoveToTarget()
        {
            m_parentGroup.stopMoveToTarget();
diff --git a/OpenSim/Region/Framework/Scenes/SceneObjectPartInventory.cs b/OpenSim/Region/Framework/Scenes/SceneObjectPartInventory.cs
index f4ca877..abb04cd 100644
--- a/OpenSim/Region/Framework/Scenes/SceneObjectPartInventory.cs
+++ b/OpenSim/Region/Framework/Scenes/SceneObjectPartInventory.cs
@@ -80,7 +80,9 @@ namespace OpenSim.Region.Framework.Scenes
        /// </value>
        protected internal TaskInventoryDictionary Items
        {
-            get { return m_items; }
+            get { 
+                return m_items; 
+            }
            set
            {
                m_items = value;
@@ -116,22 +118,25 @@ namespace OpenSim.Region.Framework.Scenes
        /// <param name="linkNum">Link number for the part</param>
        public void ResetInventoryIDs()
        {
-            lock (Items)
+            m_items.LockItemsForWrite(true);
+            if (0 == Items.Count)
            {
-                if (0 == Items.Count)
+                m_items.LockItemsForWrite(false);
-                    return;
+                return;
+            }
-                HasInventoryChanged = true;
+            HasInventoryChanged = true;
-                m_part.ParentGroup.HasGroupChanged = true;
+            m_part.ParentGroup.HasGroupChanged = true;
-                IList<TaskInventoryItem> items = new List<TaskInventoryItem>(Items.Values);
+            IList<TaskInventoryItem> items = new List<TaskInventoryItem>(Items.Values);
-                Items.Clear();
+            Items.Clear();
-                foreach (TaskInventoryItem item in items)
+            foreach (TaskInventoryItem item in items)
-                {
+            {
-                    item.ResetIDs(m_part.UUID);
+                item.ResetIDs(m_part.UUID);
-                    Items.Add(item.ItemID, item);
+                Items.Add(item.ItemID, item);
-                }
            }
+            m_items.LockItemsForWrite(false);
        }
        /// <summary>
@@ -140,25 +145,25 @@ namespace OpenSim.Region.Framework.Scenes
        /// <param name="ownerId"></param>
        public void ChangeInventoryOwner(UUID ownerId)
        {
-            lock (Items)
+            m_items.LockItemsForWrite(true);
+            if (0 == Items.Count)
            {
-                if (0 == Items.Count)
+                m_items.LockItemsForWrite(false);
-                {
+                return;
-                    return;
+            }
-                }
-                HasInventoryChanged = true;
+            HasInventoryChanged = true;
-                m_part.ParentGroup.HasGroupChanged = true;
+            m_part.ParentGroup.HasGroupChanged = true;
-                IList<TaskInventoryItem> items = new List<TaskInventoryItem>(Items.Values);
+            IList<TaskInventoryItem> items = new List<TaskInventoryItem>(Items.Values);
-                foreach (TaskInventoryItem item in items)
+            foreach (TaskInventoryItem item in items)
+            {
+                if (ownerId != item.OwnerID)
                {
-                    if (ownerId != item.OwnerID)
+                    item.LastOwnerID = item.OwnerID;
-                    {
+                    item.OwnerID = ownerId;
-                        item.LastOwnerID = item.OwnerID;
-                        item.OwnerID = ownerId;
-                    }
                }
            }
+            m_items.LockItemsForWrite(false);
        }
        /// <summary>
@@ -167,24 +172,24 @@ namespace OpenSim.Region.Framework.Scenes
        /// <param name="groupID"></param>
        public void ChangeInventoryGroup(UUID groupID)
        {
-            lock (Items)
+            m_items.LockItemsForWrite(true);
+            if (0 == Items.Count)
            {
-                if (0 == Items.Count)
+                m_items.LockItemsForWrite(false);
-                {
+                return;
-                    return;
+            }
-                }
-                HasInventoryChanged = true;
+            HasInventoryChanged = true;
-                m_part.ParentGroup.HasGroupChanged = true;
+            m_part.ParentGroup.HasGroupChanged = true;
-                IList<TaskInventoryItem> items = new List<TaskInventoryItem>(Items.Values);
+            IList<TaskInventoryItem> items = new List<TaskInventoryItem>(Items.Values);
-                foreach (TaskInventoryItem item in items)
+            foreach (TaskInventoryItem item in items)
+            {
+                if (groupID != item.GroupID)
                {
-                    if (groupID != item.GroupID)
+                    item.GroupID = groupID;
-                    {
-                        item.GroupID = groupID;
-                    }
                }
            }
+            m_items.LockItemsForWrite(false);
        }
        /// <summary>
@@ -192,14 +197,14 @@ namespace OpenSim.Region.Framework.Scenes
        /// </summary>
        public void CreateScriptInstances(int startParam, bool postOnRez, string engine, int stateSource)
        {
-            lock (m_items)
+            Items.LockItemsForRead(true);
+            IList<TaskInventoryItem> items = new List<TaskInventoryItem>(Items.Values);
+            Items.LockItemsForRead(false);
+            foreach (TaskInventoryItem item in items)
            {
-                foreach (TaskInventoryItem item in Items.Values)
+                if ((int)InventoryType.LSL == item.InvType)
                {
-                    if ((int)InventoryType.LSL == item.InvType)
+                    CreateScriptInstance(item, startParam, postOnRez, engine, stateSource);
-                    {
-                        CreateScriptInstance(item, startParam, postOnRez, engine, stateSource);
-                    }
                }
            }
        }
@@ -209,17 +214,20 @@ namespace OpenSim.Region.Framework.Scenes
        /// </summary>
        public void RemoveScriptInstances()
        {
-            lock (Items)
+            Items.LockItemsForRead(true);
+            IList<TaskInventoryItem> items = new List<TaskInventoryItem>(Items.Values);
+            Items.LockItemsForRead(false);
+            foreach (TaskInventoryItem item in items)
            {
-                foreach (TaskInventoryItem item in Items.Values)
+                if ((int)InventoryType.LSL == item.InvType)
                {
-                    if ((int)InventoryType.LSL == item.InvType)
+                    RemoveScriptInstance(item.ItemID);
-                    {
+                    m_part.RemoveScriptEvents(item.ItemID);
-                        RemoveScriptInstance(item.ItemID);
-                        m_part.RemoveScriptEvents(item.ItemID);
-                    }
                }
            }
+            
        }
        /// <summary>
@@ -244,8 +252,10 @@ namespace OpenSim.Region.Framework.Scenes
                if (stateSource == 1 && // Prim crossing
                        m_part.ParentGroup.Scene.m_trustBinaries)
                {
+                    m_items.LockItemsForWrite(true);
                    m_items[item.ItemID].PermsMask = 0;
                    m_items[item.ItemID].PermsGranter = UUID.Zero;
+                    m_items.LockItemsForWrite(false);
                    m_part.ParentGroup.Scene.EventManager.TriggerRezScript(
                        m_part.LocalId, item.ItemID, String.Empty, startParam, postOnRez, engine, stateSource);
                    m_part.ParentGroup.AddActiveScriptCount(1);
@@ -266,8 +276,10 @@ namespace OpenSim.Region.Framework.Scenes
                                   {
                                       if (m_part.ParentGroup.m_savedScriptState != null)
                                           RestoreSavedScriptState(item.OldItemID, item.ItemID);
+                                       m_items.LockItemsForWrite(true);
                                       m_items[item.ItemID].PermsMask = 0;
                                       m_items[item.ItemID].PermsGranter = UUID.Zero;
+                                       m_items.LockItemsForWrite(false);
                                       string script = Utils.BytesToString(asset.Data);
                                       m_part.ParentGroup.Scene.EventManager.TriggerRezScript(
                                            m_part.LocalId, item.ItemID, script, startParam, postOnRez, engine, stateSource);
@@ -302,20 +314,22 @@ namespace OpenSim.Region.Framework.Scenes
        /// </param>
        public void CreateScriptInstance(UUID itemId, int startParam, bool postOnRez, string engine, int stateSource)
        {
-            lock (m_items)
+            m_items.LockItemsForRead(true);
+            if (m_items.ContainsKey(itemId))
            {
-                if (m_items.ContainsKey(itemId))
+                TaskInventoryItem item = m_items[itemId];
-                {
+                m_items.LockItemsForRead(false);
-                    CreateScriptInstance(m_items[itemId], startParam, postOnRez, engine, stateSource);
+                CreateScriptInstance(item, startParam, postOnRez, engine, stateSource);
-                }
-                else
-                {
-                    m_log.ErrorFormat(
-                        "[PRIM INVENTORY]: " +
-                        "Couldn't start script with ID {0} since it couldn't be found for prim {1}, {2}",
-                        itemId, m_part.Name, m_part.UUID);
-                }
            }
+            else
+            {
+                m_items.LockItemsForRead(false);
+                m_log.ErrorFormat(
+                    "[PRIM INVENTORY]: " +
+                    "Couldn't start script with ID {0} since it couldn't be found for prim {1}, {2}",
+                    itemId, m_part.Name, m_part.UUID);
+            }
+            
        }
        /// <summary>
@@ -346,11 +360,16 @@ namespace OpenSim.Region.Framework.Scenes
        /// <returns></returns>
        private bool InventoryContainsName(string name)
        {
-            foreach (TaskInventoryItem item in Items.Values)
+            m_items.LockItemsForRead(true);
+            foreach (TaskInventoryItem item in m_items.Values)
            {
                if (item.Name == name)
+                {
+                    m_items.LockItemsForRead(false);
                    return true;
+                }
            }
+            m_items.LockItemsForRead(false);
            return false;
        }
@@ -392,7 +411,9 @@ namespace OpenSim.Region.Framework.Scenes
        /// <param name="item"></param>
        public void AddInventoryItemExclusive(TaskInventoryItem item, bool allowedDrop)
        {
+            m_items.LockItemsForRead(true);
            List<TaskInventoryItem> il = new List<TaskInventoryItem>(m_items.Values);
+            m_items.LockItemsForRead(false);
            foreach (TaskInventoryItem i in il)
            {
                if (i.Name == item.Name)
@@ -429,15 +450,14 @@ namespace OpenSim.Region.Framework.Scenes
            item.ParentPartID = m_part.UUID;
            item.Name = name;
-            lock (m_items)
+            m_items.LockItemsForWrite(true);
-            {
+            m_items.Add(item.ItemID, item);
-                m_items.Add(item.ItemID, item);
+            m_items.LockItemsForWrite(false);
                if (allowedDrop) 
                    m_part.TriggerScriptChangedEvent(Changed.ALLOWED_DROP);
                else
                    m_part.TriggerScriptChangedEvent(Changed.INVENTORY);
-            }
+            
            m_inventorySerial++;
            //m_inventorySerial += 2;
@@ -454,14 +474,13 @@ namespace OpenSim.Region.Framework.Scenes
        /// <param name="items"></param>
        public void RestoreInventoryItems(ICollection<TaskInventoryItem> items)
        {
-            lock (m_items)
+            m_items.LockItemsForWrite(true);
+            foreach (TaskInventoryItem item in items)
            {
-                foreach (TaskInventoryItem item in items)
+                m_items.Add(item.ItemID, item);
-                {
+                m_part.TriggerScriptChangedEvent(Changed.INVENTORY);
-                    m_items.Add(item.ItemID, item);
-                    m_part.TriggerScriptChangedEvent(Changed.INVENTORY);
-                }
            }
+            m_items.LockItemsForWrite(false);
            m_inventorySerial++;
        }
@@ -474,8 +493,9 @@ namespace OpenSim.Region.Framework.Scenes
        public TaskInventoryItem GetInventoryItem(UUID itemId)
        {
            TaskInventoryItem item;
+            m_items.LockItemsForRead(true);
            m_items.TryGetValue(itemId, out item);
+            m_items.LockItemsForRead(false);
            return item;
        }
@@ -487,45 +507,45 @@ namespace OpenSim.Region.Framework.Scenes
        /// <returns>false if the item did not exist, true if the update occurred successfully</returns>
        public bool UpdateInventoryItem(TaskInventoryItem item)
        {
-            lock (m_items)
+            m_items.LockItemsForWrite(true);
+            if (m_items.ContainsKey(item.ItemID))
            {
-                if (m_items.ContainsKey(item.ItemID))
+                item.ParentID = m_part.UUID;
+                item.ParentPartID = m_part.UUID;
+                item.Flags = m_items[item.ItemID].Flags;
+                if (item.AssetID == UUID.Zero)
                {
-                    item.ParentID = m_part.UUID;
+                    item.AssetID = m_items[item.ItemID].AssetID;
-                    item.ParentPartID = m_part.UUID;
+                }
-                    item.Flags = m_items[item.ItemID].Flags;
+                else if ((InventoryType)item.Type == InventoryType.Notecard)
-                    if (item.AssetID == UUID.Zero)
+                {
-                    {
+                    ScenePresence presence = m_part.ParentGroup.Scene.GetScenePresence(item.OwnerID);
-                        item.AssetID = m_items[item.ItemID].AssetID;
-                    }
-                    else if ((InventoryType)item.Type == InventoryType.Notecard)
-                    {
-                        ScenePresence presence = m_part.ParentGroup.Scene.GetScenePresence(item.OwnerID);
-                        if (presence != null)
+                    if (presence != null)
-                        {
+                    {
-                            presence.ControllingClient.SendAgentAlertMessage(
+                        presence.ControllingClient.SendAgentAlertMessage(
-                                    "Notecard saved", false);
+                                "Notecard saved", false);
-                        }
                    }
+                }
-                    m_items[item.ItemID] = item;
+                m_items[item.ItemID] = item;
-                    m_inventorySerial++;
+                m_inventorySerial++;
-                    m_part.TriggerScriptChangedEvent(Changed.INVENTORY);
+                m_part.TriggerScriptChangedEvent(Changed.INVENTORY);
-                    HasInventoryChanged = true;
-                    m_part.ParentGroup.HasGroupChanged = true;
-                    return true;
+                HasInventoryChanged = true;
-                }
+                m_part.ParentGroup.HasGroupChanged = true;
-                else
+                m_items.LockItemsForWrite(false);
-                {
+                return true;
-                    m_log.ErrorFormat(
+            }
-                        "[PRIM INVENTORY]: " +
+            else
-                        "Tried to retrieve item ID {0} from prim {1}, {2} but the item does not exist in this inventory",
+            {
-                        item.ItemID, m_part.Name, m_part.UUID);
+                m_log.ErrorFormat(
-                }
+                    "[PRIM INVENTORY]: " +
+                    "Tried to retrieve item ID {0} from prim {1}, {2} but the item does not exist in this inventory",
+                    item.ItemID, m_part.Name, m_part.UUID);
            }
+            m_items.LockItemsForWrite(false);
            return false;
        }
@@ -538,51 +558,54 @@ namespace OpenSim.Region.Framework.Scenes
        /// in this prim's inventory.</returns>
        public int RemoveInventoryItem(UUID itemID)
        {
-            lock (m_items)
+            m_items.LockItemsForRead(true);
+            if (m_items.ContainsKey(itemID))
            {
-                if (m_items.ContainsKey(itemID))
+                int type = m_items[itemID].InvType;
+                m_items.LockItemsForRead(false);
+                if (type == 10) // Script
                {
-                    int type = m_items[itemID].InvType;
+                    m_part.ParentGroup.Scene.EventManager.TriggerRemoveScript(m_part.LocalId, itemID);
-                    if (type == 10) // Script
+                }
-                    {
+                m_items.LockItemsForWrite(true);
-                        m_part.ParentGroup.Scene.EventManager.TriggerRemoveScript(m_part.LocalId, itemID);
+                m_items.Remove(itemID);
-                    }
+                m_items.LockItemsForWrite(false);
-                    m_items.Remove(itemID);
+                m_inventorySerial++;
-                    m_inventorySerial++;
+                m_part.TriggerScriptChangedEvent(Changed.INVENTORY);
-                    m_part.TriggerScriptChangedEvent(Changed.INVENTORY);
-                    HasInventoryChanged = true;
-                    m_part.ParentGroup.HasGroupChanged = true;
-                    int scriptcount = 0;
+                HasInventoryChanged = true;
-                    lock (m_items)
+                m_part.ParentGroup.HasGroupChanged = true;
-                    {
-                        foreach (TaskInventoryItem item in m_items.Values)
-                        {
-                            if (item.Type == 10)
-                            {
-                                scriptcount++;
-                            }
-                        }
-                    }
-                    if (scriptcount <= 0)
+                int scriptcount = 0;
+                m_items.LockItemsForRead(true);
+                foreach (TaskInventoryItem item in m_items.Values)
+                {
+                    if (item.Type == 10)
                    {
-                        m_part.RemFlag(PrimFlags.Scripted);
+                        scriptcount++;
                    }
-                    m_part.ScheduleFullUpdate();
-                    return type;
                }
-                else
+                m_items.LockItemsForRead(false);
+                
+                if (scriptcount <= 0)
                {
-                    m_log.ErrorFormat(
+                    m_part.RemFlag(PrimFlags.Scripted);
-                        "[PRIM INVENTORY]: " +
-                        "Tried to remove item ID {0} from prim {1}, {2} but the item does not exist in this inventory",
-                        itemID, m_part.Name, m_part.UUID);
                }
+                m_part.ScheduleFullUpdate();
+                return type;
+            }
+            else
+            {
+                m_log.ErrorFormat(
+                    "[PRIM INVENTORY]: " +
+                    "Tried to remove item ID {0} from prim {1}, {2} but the item does not exist in this inventory",
+                    itemID, m_part.Name, m_part.UUID);
            }
+            m_items.LockItemsForWrite(false);
            return -1;
        }
@@ -635,52 +658,53 @@ namespace OpenSim.Region.Framework.Scenes
            // isn't available (such as drag from prim inventory to agent inventory)
            InventoryStringBuilder invString = new InventoryStringBuilder(m_part.UUID, UUID.Zero);
-            lock (m_items)
+            m_items.LockItemsForRead(true);
+            foreach (TaskInventoryItem item in m_items.Values)
            {
-                foreach (TaskInventoryItem item in m_items.Values)
+                UUID ownerID = item.OwnerID;
-                {
+                uint everyoneMask = 0;
-                    UUID ownerID = item.OwnerID;
+                uint baseMask = item.BasePermissions;
-                    uint everyoneMask = 0;
+                uint ownerMask = item.CurrentPermissions;
-                    uint baseMask = item.BasePermissions;
-                    uint ownerMask = item.CurrentPermissions;
-                    invString.AddItemStart();
+                invString.AddItemStart();
-                    invString.AddNameValueLine("item_id", item.ItemID.ToString());
+                invString.AddNameValueLine("item_id", item.ItemID.ToString());
-                    invString.AddNameValueLine("parent_id", m_part.UUID.ToString());
+                invString.AddNameValueLine("parent_id", m_part.UUID.ToString());
-                    invString.AddPermissionsStart();
+                invString.AddPermissionsStart();
-                    invString.AddNameValueLine("base_mask", Utils.UIntToHexString(baseMask));
+                invString.AddNameValueLine("base_mask", Utils.UIntToHexString(baseMask));
-                    invString.AddNameValueLine("owner_mask", Utils.UIntToHexString(ownerMask));
+                invString.AddNameValueLine("owner_mask", Utils.UIntToHexString(ownerMask));
-                    invString.AddNameValueLine("group_mask", Utils.UIntToHexString(0));
+                invString.AddNameValueLine("group_mask", Utils.UIntToHexString(0));
-                    invString.AddNameValueLine("everyone_mask", Utils.UIntToHexString(everyoneMask));
+                invString.AddNameValueLine("everyone_mask", Utils.UIntToHexString(everyoneMask));
-                    invString.AddNameValueLine("next_owner_mask", Utils.UIntToHexString(item.NextPermissions));
+                invString.AddNameValueLine("next_owner_mask", Utils.UIntToHexString(item.NextPermissions));
-                    invString.AddNameValueLine("creator_id", item.CreatorID.ToString());
+                invString.AddNameValueLine("creator_id", item.CreatorID.ToString());
-                    invString.AddNameValueLine("owner_id", ownerID.ToString());
+                invString.AddNameValueLine("owner_id", ownerID.ToString());
-                    invString.AddNameValueLine("last_owner_id", item.LastOwnerID.ToString());
+                invString.AddNameValueLine("last_owner_id", item.LastOwnerID.ToString());
-                    invString.AddNameValueLine("group_id", item.GroupID.ToString());
+                invString.AddNameValueLine("group_id", item.GroupID.ToString());
-                    invString.AddSectionEnd();
+                invString.AddSectionEnd();
-                    invString.AddNameValueLine("asset_id", item.AssetID.ToString());
+                invString.AddNameValueLine("asset_id", item.AssetID.ToString());
-                    invString.AddNameValueLine("type", TaskInventoryItem.Types[item.Type]);
+                invString.AddNameValueLine("type", TaskInventoryItem.Types[item.Type]);
-                    invString.AddNameValueLine("inv_type", TaskInventoryItem.InvTypes[item.InvType]);
+                invString.AddNameValueLine("inv_type", TaskInventoryItem.InvTypes[item.InvType]);
-                    invString.AddNameValueLine("flags", Utils.UIntToHexString(item.Flags));
+                invString.AddNameValueLine("flags", Utils.UIntToHexString(item.Flags));
-                    invString.AddSaleStart();
+                invString.AddSaleStart();
-                    invString.AddNameValueLine("sale_type", "not");
+                invString.AddNameValueLine("sale_type", "not");
-                    invString.AddNameValueLine("sale_price", "0");
+                invString.AddNameValueLine("sale_price", "0");
-                    invString.AddSectionEnd();
+                invString.AddSectionEnd();
-                    invString.AddNameValueLine("name", item.Name + "|");
+                invString.AddNameValueLine("name", item.Name + "|");
-                    invString.AddNameValueLine("desc", item.Description + "|");
+                invString.AddNameValueLine("desc", item.Description + "|");
-                    invString.AddNameValueLine("creation_date", item.CreationDate.ToString());
+                invString.AddNameValueLine("creation_date", item.CreationDate.ToString());
-                    invString.AddSectionEnd();
+                invString.AddSectionEnd();
-                }
            }
+            int count = m_items.Count;
+            m_items.LockItemsForRead(false);
            fileData = Utils.StringToBytes(invString.BuildString);
@@ -701,10 +725,9 @@ namespace OpenSim.Region.Framework.Scenes
        {
            if (HasInventoryChanged)
            {
-                lock (Items)
+                Items.LockItemsForRead(true);
-                {
+                datastore.StorePrimInventory(m_part.UUID, Items.Values);
-                    datastore.StorePrimInventory(m_part.UUID, Items.Values);
+                Items.LockItemsForRead(false);
-                }
                HasInventoryChanged = false;
            }
diff --git a/OpenSim/Region/Framework/Scenes/ScenePresence.cs b/OpenSim/Region/Framework/Scenes/ScenePresence.cs
index 5604e3d..4c8c94f 100644
--- a/OpenSim/Region/Framework/Scenes/ScenePresence.cs
+++ b/OpenSim/Region/Framework/Scenes/ScenePresence.cs
@@ -73,7 +73,7 @@ namespace OpenSim.Region.Framework.Scenes
 //        {
 //            m_log.Debug("[ScenePresence] Destructor called");
 //        }
+        
        private static readonly ILog m_log = LogManager.GetLogger(MethodBase.GetCurrentMethod().DeclaringType);
        private static readonly byte[] BAKE_INDICES = new byte[] { 8, 9, 10, 11, 19, 20 };
@@ -89,7 +89,8 @@ namespace OpenSim.Region.Framework.Scenes
        /// rotation, prim cut, prim twist, prim taper, and prim shear. See mantis
        /// issue #1716
        /// </summary>
-        private static readonly Vector3 SIT_TARGET_ADJUSTMENT = new Vector3(0.1f, 0.0f, 0.3f);
+//        private static readonly Vector3 SIT_TARGET_ADJUSTMENT = new Vector3(0.1f, 0.0f, 0.3f);
+        private static readonly Vector3 SIT_TARGET_ADJUSTMENT = new Vector3(0.0f, 0.0f, 0.418f);
        public UUID currentParcelUUID = UUID.Zero;
@@ -113,7 +114,8 @@ namespace OpenSim.Region.Framework.Scenes
        public Vector3 lastKnownAllowedPosition;
        public bool sentMessageAboutRestrictedParcelFlyingDown;
        public Vector4 CollisionPlane = Vector4.UnitW;
+        
+                private Vector3 m_avInitialPos;         // used to calculate unscripted sit rotation
        private Vector3 m_lastPosition;
        private Quaternion m_lastRotation;
        private Vector3 m_lastVelocity;
@@ -144,7 +146,6 @@ namespace OpenSim.Region.Framework.Scenes
        private int m_perfMonMS;
        private bool m_setAlwaysRun;
-        
        private bool m_forceFly;
        private bool m_flyDisabled;
@@ -168,7 +169,8 @@ namespace OpenSim.Region.Framework.Scenes
        protected RegionInfo m_regionInfo;
        protected ulong crossingFromRegion;
-        private readonly Vector3[] Dir_Vectors = new Vector3[6];
+        private readonly Vector3[] Dir_Vectors = new Vector3[9];
+        private bool m_isNudging = false;
        // Position of agent's camera in world (region cordinates)
        protected Vector3 m_CameraCenter;
@@ -232,6 +234,8 @@ namespace OpenSim.Region.Framework.Scenes
            DIR_CONTROL_FLAG_RIGHT = AgentManager.ControlFlags.AGENT_CONTROL_LEFT_NEG,
            DIR_CONTROL_FLAG_UP = AgentManager.ControlFlags.AGENT_CONTROL_UP_POS,
            DIR_CONTROL_FLAG_DOWN = AgentManager.ControlFlags.AGENT_CONTROL_UP_NEG,
+            DIR_CONTROL_FLAG_FORWARD_NUDGE = AgentManager.ControlFlags.AGENT_CONTROL_NUDGE_AT_POS,
+            DIR_CONTROL_FLAG_BACK_NUDGE = AgentManager.ControlFlags.AGENT_CONTROL_NUDGE_AT_NEG,
            DIR_CONTROL_FLAG_DOWN_NUDGE = AgentManager.ControlFlags.AGENT_CONTROL_NUDGE_UP_NEG
        }
        
@@ -716,21 +720,41 @@ namespace OpenSim.Region.Framework.Scenes
            Dir_Vectors[3] = -Vector3.UnitY; //RIGHT
            Dir_Vectors[4] = Vector3.UnitZ; //UP
            Dir_Vectors[5] = -Vector3.UnitZ; //DOWN
-            Dir_Vectors[5] = new Vector3(0f, 0f, -0.5f); //DOWN_Nudge
+            Dir_Vectors[6] = new Vector3(0.5f, 0f, 0f); //FORWARD_NUDGE
+            Dir_Vectors[7] = new Vector3(-0.5f, 0f, 0f);  //BACK_NUDGE
+            Dir_Vectors[8] = new Vector3(0f, 0f, -0.5f); //DOWN_Nudge
        }
        private Vector3[] GetWalkDirectionVectors()
        {
-            Vector3[] vector = new Vector3[6];
+            Vector3[] vector = new Vector3[9];
            vector[0] = new Vector3(m_CameraUpAxis.Z, 0f, -m_CameraAtAxis.Z); //FORWARD
            vector[1] = new Vector3(-m_CameraUpAxis.Z, 0f, m_CameraAtAxis.Z); //BACK
            vector[2] = Vector3.UnitY; //LEFT
            vector[3] = -Vector3.UnitY; //RIGHT
            vector[4] = new Vector3(m_CameraAtAxis.Z, 0f, m_CameraUpAxis.Z); //UP
            vector[5] = new Vector3(-m_CameraAtAxis.Z, 0f, -m_CameraUpAxis.Z); //DOWN
-            vector[5] = new Vector3(-m_CameraAtAxis.Z, 0f, -m_CameraUpAxis.Z); //DOWN_Nudge
+            vector[6] = new Vector3(m_CameraUpAxis.Z, 0f, -m_CameraAtAxis.Z); //FORWARD_NUDGE
+            vector[7] = new Vector3(-m_CameraUpAxis.Z, 0f, m_CameraAtAxis.Z); //BACK_NUDGE
+            vector[8] = new Vector3(-m_CameraAtAxis.Z, 0f, -m_CameraUpAxis.Z); //DOWN_Nudge
            return vector;
        }
+        
+        private bool[] GetDirectionIsNudge()
+        {
+            bool[] isNudge = new bool[9];
+            isNudge[0] = false; //FORWARD
+            isNudge[1] = false; //BACK
+            isNudge[2] = false; //LEFT
+            isNudge[3] = false; //RIGHT
+            isNudge[4] = false; //UP
+            isNudge[5] = false; //DOWN
+            isNudge[6] = true; //FORWARD_NUDGE
+            isNudge[7] = true; //BACK_NUDGE
+            isNudge[8] = true; //DOWN_Nudge
+            return isNudge;
+        }
        #endregion
@@ -1147,7 +1171,6 @@ namespace OpenSim.Region.Framework.Scenes
            //    // m_log.Debug("DEBUG: HandleAgentUpdate: child agent");
            //    return;
            //}
            m_perfMonMS = Environment.TickCount;
            ++m_movementUpdateCount;
@@ -1229,7 +1252,6 @@ namespace OpenSim.Region.Framework.Scenes
                    m_scene.PhysicsScene.RaycastWorld(m_pos, Vector3.Normalize(m_CameraCenter - posAdjusted), Vector3.Distance(m_CameraCenter, posAdjusted) + 0.3f, RayCastCameraCallback);
                }
            }
            lock (scriptedcontrols)
            {
                if (scriptedcontrols.Count > 0)
@@ -1261,7 +1283,6 @@ namespace OpenSim.Region.Framework.Scenes
            {
                return;
            }
            if (m_allowMovement)
            {
                int i = 0;
@@ -1289,6 +1310,11 @@ namespace OpenSim.Region.Framework.Scenes
                    update_rotation = true;
                }
+                //guilty until proven innocent..
+                bool Nudging = true;
+                //Basically, if there is at least one non-nudge control then we don't need
+                //to worry about stopping the avatar
                if (m_parentID == 0)
                {
                    bool bAllowUpdateMoveToPosition = false;
@@ -1303,6 +1329,12 @@ namespace OpenSim.Region.Framework.Scenes
                    else
                        dirVectors = Dir_Vectors;
+                    bool[] isNudge = GetDirectionIsNudge();
+                    
+                    
+                    
                    foreach (Dir_ControlFlags DCF in DIR_CONTROL_FLAGS)
                    {
                        if (((uint)flags & (uint)DCF) != 0)
@@ -1312,6 +1344,10 @@ namespace OpenSim.Region.Framework.Scenes
                            try
                            {
                                agent_control_v3 += dirVectors[i];
+                                if (isNudge[i] == false)
+                                {
+                                    Nudging = false;
+                                }
                            }
                            catch (IndexOutOfRangeException)
                            {
@@ -1373,6 +1409,9 @@ namespace OpenSim.Region.Framework.Scenes
                                // Ignore z component of vector
                                Vector3 LocalVectorToTarget2D = new Vector3((float)(LocalVectorToTarget3D.X), (float)(LocalVectorToTarget3D.Y), 0f);
                                LocalVectorToTarget2D.Normalize();
+                                
+                                //We're not nudging
+                                Nudging = false;
                                agent_control_v3 += LocalVectorToTarget2D;
                                // update avatar movement flags. the avatar coordinate system is as follows:
@@ -1455,7 +1494,7 @@ namespace OpenSim.Region.Framework.Scenes
                    //                    m_log.DebugFormat(
                    //                        "In {0} adding velocity to {1} of {2}", m_scene.RegionInfo.RegionName, Name, agent_control_v3);
-                    AddNewMovement(agent_control_v3, q);
+                    AddNewMovement(agent_control_v3, q, Nudging);
                    if (update_movementflag)
                        Animator.UpdateMovementAnimations();
@@ -1538,7 +1577,7 @@ namespace OpenSim.Region.Framework.Scenes
                        Velocity = Vector3.Zero;
                        SendFullUpdateToAllClients();
-                        //HandleAgentSit(ControllingClient, m_requestedSitTargetUUID);
+                        HandleAgentSit(ControllingClient, m_requestedSitTargetUUID);  //KF ??
                    }
                    //ControllingClient.SendSitResponse(m_requestedSitTargetID, m_requestedSitOffset, Quaternion.Identity, false, Vector3.Zero, Vector3.Zero, false);
                    m_requestedSitTargetUUID = UUID.Zero;
@@ -1576,21 +1615,19 @@ namespace OpenSim.Region.Framework.Scenes
                SceneObjectPart part = m_scene.GetSceneObjectPart(m_parentID);
                if (part != null)
                {
+                    part.TaskInventory.LockItemsForRead(true);
                    TaskInventoryDictionary taskIDict = part.TaskInventory;
                    if (taskIDict != null)
                    {
-                        lock (taskIDict)
+                        foreach (UUID taskID in taskIDict.Keys)
                        {
-                            foreach (UUID taskID in taskIDict.Keys)
+                            UnRegisterControlEventsToScript(LocalId, taskID);
-                            {
+                            taskIDict[taskID].PermsMask &= ~(
-                                UnRegisterControlEventsToScript(LocalId, taskID);
+                                2048 | //PERMISSION_CONTROL_CAMERA
-                                taskIDict[taskID].PermsMask &= ~(
+                                4); // PERMISSION_TAKE_CONTROLS
-                                    2048 | //PERMISSION_CONTROL_CAMERA
-                                    4); // PERMISSION_TAKE_CONTROLS
-                            }
                        }
                    }
+                    part.TaskInventory.LockItemsForRead(false);
                    // Reset sit target.
                    if (part.GetAvatarOnSitTarget() == UUID)
                        part.SetAvatarOnSitTarget(UUID.Zero);
@@ -1651,7 +1688,7 @@ namespace OpenSim.Region.Framework.Scenes
                bool SitTargetisSet =
                    (!(avSitOffSet.X == 0f && avSitOffSet.Y == 0f && avSitOffSet.Z == 0f && avSitOrientation.W == 1f &&
                       avSitOrientation.X == 0f && avSitOrientation.Y == 0f && avSitOrientation.Z == 0f));
+                                                        // this test is probably failing
                if (SitTargetisSet && SitTargetUnOccupied)
                {
                    //switch the target to this prim
@@ -1678,26 +1715,37 @@ namespace OpenSim.Region.Framework.Scenes
            {
                // TODO: determine position to sit at based on scene geometry; don't trust offset from client
                // see http://wiki.secondlife.com/wiki/User:Andrew_Linden/Office_Hours/2007_11_06 for details on how LL does it
+                
+                                // part is the prim to sit on
+                                // offset is the vector distance from that prim center to the click-spot
+                                // UUID  is the UUID of the Avatar doing the clicking
+                                
+                                m_avInitialPos = AbsolutePosition;                      // saved to calculate unscripted sit rotation
+                                
                // Is a sit target available?
                Vector3 avSitOffSet = part.SitTargetPosition;
                Quaternion avSitOrientation = part.SitTargetOrientation;
                UUID avOnTargetAlready = part.GetAvatarOnSitTarget();
                bool SitTargetUnOccupied = (!(avOnTargetAlready != UUID.Zero));
-                bool SitTargetisSet =
+//                bool SitTargetisSet =
-                    (!(avSitOffSet.X == 0f && avSitOffSet.Y == 0f && avSitOffSet.Z == 0f && avSitOrientation.W == 0f &&
+//                  (!(avSitOffSet.X == 0f && avSitOffSet.Y == 0f && avSitOffSet.Z == 0f && avSitOrientation.W == 0f &&
-                       avSitOrientation.X == 0f && avSitOrientation.Y == 0f && avSitOrientation.Z == 1f));
+//                   avSitOrientation.X == 0f && avSitOrientation.Y == 0f && avSitOrientation.Z == 1f));
+                bool SitTargetisSet = ((Vector3.Zero != avSitOffSet)  || (Quaternion.Identity != avSitOrientation));
+                    
+//Console.WriteLine("SendSitResponse offset=" + offset + "  UnOccup=" + SitTargetUnOccupied +
+//                                      "    TargSet=" + SitTargetisSet);
+                                        
                if (SitTargetisSet && SitTargetUnOccupied)
                {
                    part.SetAvatarOnSitTarget(UUID);
                    offset = new Vector3(avSitOffSet.X, avSitOffSet.Y, avSitOffSet.Z);
                    sitOrientation = avSitOrientation;
-                    autopilot = false;
+                    autopilot = false;                                          // Jump direct to scripted llSitPos()
                }
-                pos = part.AbsolutePosition + offset;
+                pos = part.AbsolutePosition + offset;           // Region position where clicked
                //if (Math.Abs(part.AbsolutePosition.Z - AbsolutePosition.Z) > 1)
                //{
                   // offset = pos;
@@ -1710,17 +1758,17 @@ namespace OpenSim.Region.Framework.Scenes
                    m_sitAvatarHeight = m_physicsActor.Size.Z;
                    if (autopilot)
-                    {
+                    {                           // its not a scripted sit
                        if (Util.GetDistanceTo(AbsolutePosition, pos) < 4.5)
                        {
-                            autopilot = false;
+                            autopilot = false;          // close enough
                            RemoveFromPhysicalScene();
-                            AbsolutePosition = pos + new Vector3(0.0f, 0.0f, m_sitAvatarHeight);
+                            AbsolutePosition = pos + new Vector3(0.0f, 0.0f, (m_sitAvatarHeight / 2.0f));  // Warp av to Prim
-                        }
+                        } // else the autopilot will get us close
                    }
                    else
-                    {
+                    {   // its a scripted sit
                        RemoveFromPhysicalScene();
                    }
                }
@@ -1823,26 +1871,41 @@ namespace OpenSim.Region.Framework.Scenes
                {
                    if (part.GetAvatarOnSitTarget() == UUID)
                    {
+                        // Scripted sit
                        Vector3 sitTargetPos = part.SitTargetPosition;
                        Quaternion sitTargetOrient = part.SitTargetOrientation;
-                        //Quaternion vq = new Quaternion(sitTargetPos.X, sitTargetPos.Y+0.2f, sitTargetPos.Z+0.2f, 0);
-                        //Quaternion nq = new Quaternion(-sitTargetOrient.X, -sitTargetOrient.Y, -sitTargetOrient.Z, sitTargetOrient.w);
-                        //Quaternion result = (sitTargetOrient * vq) * nq;
                        m_pos = new Vector3(sitTargetPos.X, sitTargetPos.Y, sitTargetPos.Z);
                        m_pos += SIT_TARGET_ADJUSTMENT;
                        m_bodyRot = sitTargetOrient;
-                        //Rotation = sitTargetOrient;
                        m_parentPosition = part.AbsolutePosition;
-                        //SendTerseUpdateToAllClients();
                    }
                    else
                    {
-                        m_pos -= part.AbsolutePosition;
+                        // Non-scripted sit by Kitto Flora 21Nov09
+                        // Calculate angle of line from prim to Av
+                                float y_diff = (m_avInitialPos.Y - part.AbsolutePosition.Y);
+                        float x_diff = ( m_avInitialPos.X - part.AbsolutePosition.X);
+                        if(Math.Abs(x_diff) < 0.001f) x_diff = 0.001f;                  // avoid div by 0
+                        if(Math.Abs(y_diff) < 0.001f) y_diff = 0.001f;                  // avoid pol flip at 0
+                        float sit_angle = (float)Math.Atan2( (double)y_diff, (double)x_diff);
+                                                Quaternion partIRot = Quaternion.Inverse(part.GetWorldRotation());
+                                                // NOTE: when sitting m_ pos and m_bodyRot are *relative* to the prim location/rotation, not 'World'.
+                        //  Av sits at world euler <0,0, z>, translated by part rotation 
+                        m_bodyRot = partIRot * Quaternion.CreateFromEulers(0f, 0f, sit_angle);          // sit at 0,0,inv-click
+                        m_pos = new Vector3(0f, 0f, 0.05f) + 
+                                        (new Vector3(0.0f, 0f, 0.625f) * partIRot) + 
+                                        (new Vector3(0.25f, 0f, 0.0f) * m_bodyRot);  // sit at center of prim
                        m_parentPosition = part.AbsolutePosition;
+                        //Set up raytrace to find top surface of prim
+                                    Vector3 size = part.Scale;
+                                                float mag = 0.1f + (float)Math.Sqrt((size.X * size.X) + (size.Y * size.Y) + (size.Z * size.Z));
+                                                Vector3 start =  part.AbsolutePosition + new Vector3(0f, 0f, mag);
+                                                Vector3 down = new Vector3(0f, 0f, -1f);    
+                            m_scene.PhysicsScene.RaycastWorld(
+                                start,          // Vector3 position,
+                                down,           // Vector3 direction,
+                                mag,            // float length,
+                                SitAltitudeCallback);           // retMethod
                    }
                }
                else
@@ -1857,11 +1920,22 @@ namespace OpenSim.Region.Framework.Scenes
            Animator.TrySetMovementAnimation(sitAnimation);
            SendFullUpdateToAllClients();
-            // This may seem stupid, but Our Full updates don't send avatar rotation :P
-            // So we're also sending a terse update (which has avatar rotation)
-            // [Update] We do now.
-            //SendTerseUpdateToAllClients();
        }
+        
+        public void SitAltitudeCallback(bool hitYN, Vector3 collisionPoint, uint localid, float distance)
+        {
+//                      Console.WriteLine("[RAYCASTRESULT]: Hit={0}, Point={1}, ID={2}, Dist={3}", hitYN, collisionPoint, localid, distance);
+                        if(hitYN)
+                        {
+                                // m_pos = Av offset from prim center to make look like on center
+                                // m_parentPosition = Actual center pos of prim
+                                // collisionPoint = spot on prim where we want to sit
+                                SceneObjectPart part = m_scene.GetSceneObjectPart(localid);
+                                Vector3 offset =  (collisionPoint - m_parentPosition) * Quaternion.Inverse(part.RotationOffset);
+                                m_pos += offset;
+//                              Console.WriteLine("m_pos={0},  offset={1}       newsit={2}",  m_pos,  offset,  newsit);
+                        }
+                }
        /// <summary>
        /// Event handler for the 'Always run' setting on the client
@@ -1891,7 +1965,7 @@ namespace OpenSim.Region.Framework.Scenes
        /// </summary>
        /// <param name="vec">The vector in which to move.  This is relative to the rotation argument</param>
        /// <param name="rotation">The direction in which this avatar should now face.
-        public void AddNewMovement(Vector3 vec, Quaternion rotation)
+        public void AddNewMovement(Vector3 vec, Quaternion rotation, bool Nudging)
        {
            if (m_isChildAgent)
            {
@@ -1965,7 +2039,7 @@ namespace OpenSim.Region.Framework.Scenes
            // TODO: Add the force instead of only setting it to support multiple forces per frame?
            m_forceToApply = direc;
+            m_isNudging = Nudging;
            m_scene.StatsReporter.AddAgentTime(Environment.TickCount - m_perfMonMS);
        }
@@ -1980,7 +2054,7 @@ namespace OpenSim.Region.Framework.Scenes
            const float POSITION_TOLERANCE = 0.05f;
            //const int TIME_MS_TOLERANCE = 3000;
-            SendPrimUpdates();
+            
            if (m_newCoarseLocations)
            {
@@ -2016,6 +2090,9 @@ namespace OpenSim.Region.Framework.Scenes
                    CheckForBorderCrossing();
                CheckForSignificantMovement(); // sends update to the modules.
            }
+            
+            //Sending prim updates AFTER the avatar terse updates are sent
+            SendPrimUpdates();
        }
        #endregion
@@ -2869,14 +2946,24 @@ namespace OpenSim.Region.Framework.Scenes
        {
            if (m_forceToApply.HasValue)
            {
-                Vector3 force = m_forceToApply.Value;
+                Vector3 force = m_forceToApply.Value;
                m_updateflag = true;
-//                movementvector = force;
                Velocity = force;
                m_forceToApply = null;
            }
+            else
+            {
+                if (m_isNudging)
+                {
+                    Vector3 force = Vector3.Zero;
+                    m_updateflag = true;
+                    Velocity = force;
+                    m_isNudging = false;
+                }
+            }
        }
        public override void SetText(string text, Vector3 color, double alpha)
@@ -3585,4 +3672,4 @@ namespace OpenSim.Region.Framework.Scenes
            }
        }
    }
-}
-\ No newline at end of file
+}
diff --git a/OpenSim/Region/Physics/BasicPhysicsPlugin/BasicPhysicsActor.cs b/OpenSim/Region/Physics/BasicPhysicsPlugin/BasicPhysicsActor.cs
index 8df997e..f411dd7 100644
--- a/OpenSim/Region/Physics/BasicPhysicsPlugin/BasicPhysicsActor.cs
+++ b/OpenSim/Region/Physics/BasicPhysicsPlugin/BasicPhysicsActor.cs
@@ -303,6 +303,26 @@ namespace OpenSim.Region.Physics.BasicPhysicsPlugin
            set { return; }
        }
+        public override Quaternion APIDTarget 
+        { 
+                set { return; }
+        }
+        
+        public override bool APIDActive
+        { 
+                set { return; }
+        }
+        
+        public override float APIDStrength
+        { 
+                set { return; }
+        }
+        
+        public override float APIDDamping
+        { 
+                set { return; }
+        }
        public override void SubscribeEvents(int ms)
        {
        }
diff --git a/OpenSim/Region/Physics/BulletDotNETPlugin/BulletDotNETCharacter.cs b/OpenSim/Region/Physics/BulletDotNETPlugin/BulletDotNETCharacter.cs
index 5ed3b14..98681d6 100644
--- a/OpenSim/Region/Physics/BulletDotNETPlugin/BulletDotNETCharacter.cs
+++ b/OpenSim/Region/Physics/BulletDotNETPlugin/BulletDotNETCharacter.cs
@@ -619,6 +619,12 @@ namespace OpenSim.Region.Physics.BulletDotNETPlugin
        {
            set { return; }
        }
+        
+        public override Quaternion APIDTarget { set { return; } }
+        public override bool APIDActive { set { return; } }
+        public override float APIDStrength { set { return; } }
+        public override float APIDDamping { set { return; } }
+        
        /// <summary>
        /// Adds the force supplied to the Target Velocity
diff --git a/OpenSim/Region/Physics/BulletDotNETPlugin/BulletDotNETPrim.cs b/OpenSim/Region/Physics/BulletDotNETPlugin/BulletDotNETPrim.cs
index 5b542db..d931f126 100644
--- a/OpenSim/Region/Physics/BulletDotNETPlugin/BulletDotNETPrim.cs
+++ b/OpenSim/Region/Physics/BulletDotNETPlugin/BulletDotNETPrim.cs
@@ -565,6 +565,11 @@ namespace OpenSim.Region.Physics.BulletDotNETPlugin
        public override PIDHoverType PIDHoverType { set { m_PIDHoverType = value; } }
        public override float PIDHoverTau { set { m_PIDHoverTau = value; } }
+        public override Quaternion APIDTarget { set { return; } }
+        public override bool APIDActive { set { return; } }
+        public override float APIDStrength { set { return; } }
+        public override float APIDDamping { set { return; } }
+        
        public override void AddForce(Vector3 force, bool pushforce)
        {
diff --git a/OpenSim/Region/Physics/BulletXPlugin/BulletXPlugin.cs b/OpenSim/Region/Physics/BulletXPlugin/BulletXPlugin.cs
index 1e94ee2..d5d146e 100644
--- a/OpenSim/Region/Physics/BulletXPlugin/BulletXPlugin.cs
+++ b/OpenSim/Region/Physics/BulletXPlugin/BulletXPlugin.cs
@@ -1238,6 +1238,26 @@ namespace OpenSim.Region.Physics.BulletXPlugin
        public override PIDHoverType PIDHoverType { set { return; } }
        public override float PIDHoverTau { set { return; } }
+        public override OpenMetaverse.Quaternion APIDTarget
+        {
+            set { return; }
+        }
+        public override bool APIDActive
+        {
+            set { return; }
+        }
+        public override float APIDStrength
+        {
+            set { return; }
+        }
+        public override float APIDDamping
+        {
+            set { return; }
+        }
        public override void SubscribeEvents(int ms)
        {
diff --git a/OpenSim/Region/Physics/Manager/PhysicsActor.cs b/OpenSim/Region/Physics/Manager/PhysicsActor.cs
index f58129d..b82586f 100644
--- a/OpenSim/Region/Physics/Manager/PhysicsActor.cs
+++ b/OpenSim/Region/Physics/Manager/PhysicsActor.cs
@@ -243,7 +243,12 @@ namespace OpenSim.Region.Physics.Manager
        public abstract PIDHoverType PIDHoverType { set;}
        public abstract float PIDHoverTau { set;}
+                // For RotLookAt        
+        public abstract Quaternion APIDTarget { set;}
+        public abstract bool APIDActive { set;}
+        public abstract float APIDStrength { set;}
+        public abstract float APIDDamping { set;}
+        
        public abstract void AddForce(Vector3 force, bool pushforce);
        public abstract void AddAngularForce(Vector3 force, bool pushforce);
        public abstract void SetMomentum(Vector3 momentum);
@@ -476,6 +481,12 @@ namespace OpenSim.Region.Physics.Manager
        public override bool PIDHoverActive { set { return; } }
        public override PIDHoverType PIDHoverType { set { return; } }
        public override float PIDHoverTau { set { return; } }
+        
+        public override Quaternion APIDTarget { set { return; } }
+        public override bool APIDActive { set { return; } }
+        public override float APIDStrength { set { return; } }
+        public override float APIDDamping { set { return; } }
+        
        public override void SetMomentum(Vector3 momentum)
        {
diff --git a/OpenSim/Region/Physics/OdePlugin/ODECharacter.cs b/OpenSim/Region/Physics/OdePlugin/ODECharacter.cs
index 1bc4a25..905d3ba 100644
--- a/OpenSim/Region/Physics/OdePlugin/ODECharacter.cs
+++ b/OpenSim/Region/Physics/OdePlugin/ODECharacter.cs
@@ -1196,6 +1196,28 @@ namespace OpenSim.Region.Physics.OdePlugin
        public override bool PIDHoverActive { set { return; } }
        public override PIDHoverType PIDHoverType { set { return; } }
        public override float PIDHoverTau { set { return; } }
+        
+        public override Quaternion APIDTarget
+        {
+            set { return; }
+        }
+        public override bool APIDActive
+        {
+            set { return; }
+        }
+        public override float APIDStrength
+        {
+            set { return; }
+        }
+        public override float APIDDamping
+        {
+            set { return; }
+        }
        public override void SubscribeEvents(int ms)
        {
diff --git a/OpenSim/Region/Physics/OdePlugin/ODEDynamics.cs b/OpenSim/Region/Physics/OdePlugin/ODEDynamics.cs
index 39cdc0f..78b15be 100644
--- a/OpenSim/Region/Physics/OdePlugin/ODEDynamics.cs
+++ b/OpenSim/Region/Physics/OdePlugin/ODEDynamics.cs
@@ -23,6 +23,19 @@
 * ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
 * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ *
+ * Revised Aug, Sept 2009 by Kitto Flora. ODEDynamics.cs replaces
+ * ODEVehicleSettings.cs. It and ODEPrim.cs are re-organised:
+ * ODEPrim.cs contains methods dealing with Prim editing, Prim
+ * characteristics and Kinetic motion.
+ * ODEDynamics.cs contains methods dealing with Prim Physical motion
+ * (dynamics) and the associated settings. Old Linear and angular
+ * motors for dynamic motion have been replace with  MoveLinear()
+ * and MoveAngular(); 'Physical' is used only to switch ODE dynamic 
+ * simualtion on/off; VEHICAL_TYPE_NONE/VEHICAL_TYPE_<other> is to
+ * switch between 'VEHICLE' parameter use and general dynamics
+ * settings use.
+ * 
 */
 /* Revised Aug, Sept 2009 by Kitto Flora. ODEDynamics.cs replaces
@@ -120,7 +133,7 @@ namespace OpenSim.Region.Physics.OdePlugin
 //        private float m_VhoverEfficiency = 0f;
        private float m_VhoverTimescale = 0f;
        private float m_VhoverTargetHeight = -1.0f;     // if <0 then no hover, else its the current target height 
-        private float m_VehicleBuoyancy = 0f;                   //KF: m_VehicleBuoyancy is set by VEHICLE_BUOYANCY for a vehicle.
+        private float m_VehicleBuoyancy = 0f;                   // Set by VEHICLE_BUOYANCY, for a vehicle.
                                // Modifies gravity. Slider between -1 (double-gravity) and 1 (full anti-gravity) 
                                // KF: So far I have found no good method to combine a script-requested .Z velocity and gravity.
                                // Therefore only m_VehicleBuoyancy=1 (0g) will use the script-requested .Z velocity. 
@@ -479,7 +492,7 @@ namespace OpenSim.Region.Physics.OdePlugin
                Quaternion rotq = new Quaternion(rot.X, rot.Y, rot.Z, rot.W);   // rotq = rotation of object
                m_dir *= rotq;                                                  // apply obj rotation to velocity vector
-                        // add Gravity andBuoyancy
+                        // add Gravity and Buoyancy
                        // KF: So far I have found no good method to combine a script-requested
                        // .Z velocity and gravity. Therefore only 0g will used script-requested
                        // .Z velocity. >0g (m_VehicleBuoyancy < 1) will used modified gravity only.
@@ -561,6 +574,7 @@ namespace OpenSim.Region.Physics.OdePlugin
                private Vector3 m_angularFrictionTimescale = Vector3.Zero;              // body angular velocity  decay rate
                private Vector3 m_lastAngularVelocity = Vector3.Zero;                   // what was last applied to body
                        */
+//if(frcount == 0) Console.WriteLine("MoveAngular ");   
        
                // Get what the body is doing, this includes 'external' influences
                d.Vector3 angularVelocity = d.BodyGetAngularVel(Body);
@@ -636,7 +650,7 @@ namespace OpenSim.Region.Physics.OdePlugin
                        // Deflection section tba
                        
                        // Sum velocities
-                        m_lastAngularVelocity = m_angularMotorVelocity + vertattr; // + bank + deflection
+                        m_lastAngularVelocity = m_angularMotorVelocity + vertattr; // tba: + bank + deflection
                        
                if (!m_lastAngularVelocity.ApproxEquals(Vector3.Zero, 0.01f))
            {
diff --git a/OpenSim/Region/Physics/OdePlugin/ODEPrim.cs b/OpenSim/Region/Physics/OdePlugin/ODEPrim.cs
index 17552d2..b0e9a91 100644
--- a/OpenSim/Region/Physics/OdePlugin/ODEPrim.cs
+++ b/OpenSim/Region/Physics/OdePlugin/ODEPrim.cs
@@ -21,6 +21,18 @@
 * ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
 * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ *
+ * Revised August 26 2009 by Kitto Flora. ODEDynamics.cs replaces
+ * ODEVehicleSettings.cs. It and ODEPrim.cs are re-organised:
+ * ODEPrim.cs contains methods dealing with Prim editing, Prim
+ * characteristics and Kinetic motion.
+ * ODEDynamics.cs contains methods dealing with Prim Physical motion
+ * (dynamics) and the associated settings. Old Linear and angular
+ * motors for dynamic motion have been replace with  MoveLinear()
+ * and MoveAngular(); 'Physical' is used only to switch ODE dynamic 
+ * simualtion on/off; VEHICAL_TYPE_NONE/VEHICAL_TYPE_<other> is to
+ * switch between 'VEHICLE' parameter use and general dynamics
+ * settings use.
 */
 /*
@@ -81,7 +93,12 @@ namespace OpenSim.Region.Physics.OdePlugin
        private float m_PIDTau;
        private float PID_D = 35f;
        private float PID_G = 25f;
-        private bool m_usePID;
+        private bool m_usePID = false;
+        
+        private Quaternion m_APIDTarget = new Quaternion();
+        private float m_APIDStrength = 0.5f;
+        private float m_APIDDamping = 0.5f;
+        private bool m_useAPID = false;
        // KF: These next 7 params apply to llSetHoverHeight(float height, integer water, float tau),
        // and are for non-VEHICLES only.
@@ -182,6 +199,9 @@ namespace OpenSim.Region.Physics.OdePlugin
        private ODEDynamics m_vehicle;
        internal int m_material = (int)Material.Wood;
+        
+        private int frcount = 0;                                                                                // Used to limit dynamics debug output to 
        public OdePrim(String primName, OdeScene parent_scene, Vector3 pos, Vector3 size,
                       Quaternion rotation, IMesh mesh, PrimitiveBaseShape pbs, bool pisPhysical, CollisionLocker dode)
@@ -1558,9 +1578,14 @@ Console.WriteLine(" JointCreateFixed");
            float fy = 0;
            float fz = 0;
+            frcount++;                                  // used to limit debug comment output
+            if (frcount > 100)
+                frcount = 0;
                
            if (IsPhysical && (Body != IntPtr.Zero) && !m_isSelected && !childPrim)             // KF: Only move root prims.
            {
+//if(frcount == 0) Console.WriteLine("Move " +  m_primName + "  VTyp " + m_vehicle.Type +
+                        //                      "    usePID=" + m_usePID  + "    seHover=" + m_useHoverPID  + "  useAPID=" + m_useAPID);                
                if (m_vehicle.Type != Vehicle.TYPE_NONE)
                {
                        // 'VEHICLES' are dealt with in ODEDynamics.cs
@@ -1568,7 +1593,6 @@ Console.WriteLine(" JointCreateFixed");
                }
                else
                {
-//Console.WriteLine("Move " +  m_primName);             
                        if(!d.BodyIsEnabled (Body))  d.BodyEnable (Body); // KF add 161009
                        // NON-'VEHICLES' are dealt with here
                        if (d.BodyIsEnabled(Body) && !m_angularlock.ApproxEquals(Vector3.Zero, 0.003f))
@@ -1590,21 +1614,18 @@ Console.WriteLine(" JointCreateFixed");
                    //m_log.Info(m_collisionFlags.ToString());
                        
-                        //KF: m_buoyancy should be set by llSetBuoyancy() for non-vehicle.
+                        //KF: m_buoyancy is set by llSetBuoyancy() and is for non-vehicle.
-                        // would come from SceneObjectPart.cs, public void SetBuoyancy(float fvalue) , PhysActor.Buoyancy = fvalue; ??
                        // m_buoyancy: (unlimited value) <0=Falls fast; 0=1g; 1=0g; >1 = floats up 
-                        // gravityz multiplier = 1 - m_buoyancy
+                        // NB Prims in ODE are no subject to global gravity
-                        fz = _parent_scene.gravityz * (1.0f - m_buoyancy) * m_mass;
+                        fz = _parent_scene.gravityz * (1.0f - m_buoyancy) * m_mass; // force = acceleration * mass
                        if (m_usePID)
                        {
-//Console.WriteLine("PID " +  m_primName);              
+//if(frcount == 0) Console.WriteLine("PID " +  m_primName);             
-                        // KF - this is for object move? eg. llSetPos() ?
+                        // KF - this is for object MoveToTarget.
+                        
                            //if (!d.BodyIsEnabled(Body))
                            //d.BodySetForce(Body, 0f, 0f, 0f);
-                            // If we're using the PID controller, then we have no gravity
-                            //fz = (-1 * _parent_scene.gravityz) * m_mass;      //KF: ?? Prims have no global gravity,so simply...
-                            fz = 0f;
                            //  no lock; for now it's only called from within Simulate()
        
@@ -1739,7 +1760,7 @@ Console.WriteLine(" JointCreateFixed");
                            d.BodySetPosition(Body, pos.X, pos.Y, m_targetHoverHeight);
                            d.BodySetLinearVel(Body, vel.X, vel.Y, 0);
                            d.BodyAddForce(Body, 0, 0, fz);
-                            return;
+                    //KF this prevents furthur motions        return;
                        }
                        else
                        {
@@ -1748,8 +1769,46 @@ Console.WriteLine(" JointCreateFixed");
                            // We're flying and colliding with something
                            fz = fz + ((_target_velocity.Z - vel.Z) * (PID_D) * m_mass);
                        }
-                    }
+                    } // end m_useHoverPID && !m_usePID
+                    
+                        if (m_useAPID)
+                        {
+                                // RotLookAt, apparently overrides all other rotation sources. Inputs:
+                                // Quaternion m_APIDTarget
+                                                // float m_APIDStrength         // From SL experiments, this is the time to get there
+                                                // float m_APIDDamping          // From SL experiments, this is damping, 1.0 = damped, 0.1 = wobbly
+                                                                                                        // Also in SL the mass of the object has no effect on time to get there.
+                                                // Factors:
+//if(frcount == 0) Console.WriteLine("APID ");                                                  
+                                    // get present body rotation
+                                    float limit = 1.0f;
+                                    float scaler = 50f;         // adjusts damping time
+                                    float RLAservo = 0f;
+                                    
+                                    d.Quaternion rot = d.BodyGetQuaternion(Body);
+                                    Quaternion rotq = new Quaternion(rot.X, rot.Y, rot.Z, rot.W);
+                                    Quaternion rot_diff = Quaternion.Inverse(rotq) * m_APIDTarget;
+                        float diff_angle;
+                        Vector3 diff_axis;
+                        rot_diff.GetAxisAngle(out diff_axis, out diff_angle);
+                        diff_axis.Normalize();
+                                                if(diff_angle > 0.01f)                  // diff_angle is always +ve
+                                                {
+//                              PhysicsVector rotforce = new PhysicsVector(diff_axis.X, diff_axis.Y, diff_axis.Z);
+                                Vector3 rotforce = new Vector3(diff_axis.X, diff_axis.Y, diff_axis.Z);
+                            rotforce = rotforce * rotq;
+                            if(diff_angle > limit) diff_angle = limit;          // cap the rotate rate
+//                          RLAservo = timestep / m_APIDStrength * m_mass * scaler;
+  //                        rotforce = rotforce * RLAservo * diff_angle ;
+    //                      d.BodyAddRelTorque(Body, rotforce.X, rotforce.Y, rotforce.Z);
+                            RLAservo = timestep / m_APIDStrength * scaler;
+                            rotforce = rotforce * RLAservo * diff_angle ;
+                                                        d.BodySetAngularVel (Body,  rotforce.X, rotforce.Y, rotforce.Z);
+//Console.WriteLine("axis= " + diff_axis + "    angle= " + diff_angle + "servo= " + RLAservo);                                                  
+                                                }
+//if(frcount == 0) Console.WriteLine("mass= " + m_mass + "  servo= " + RLAservo + "   angle= " + diff_angle);                                                   
+                        } // end m_useAPID
+                        
                    fx *= m_mass;
                    fy *= m_mass;
                    //fz *= m_mass;
@@ -2816,6 +2875,12 @@ Console.WriteLine(" JointCreateFixed");
        }
        public override bool PIDActive { set { m_usePID = value; } }
        public override float PIDTau { set { m_PIDTau = value; } }
+        
+                // For RotLookAt        
+        public override Quaternion APIDTarget { set { m_APIDTarget = value; } }
+        public override bool APIDActive { set { m_useAPID = value; } }
+        public override float APIDStrength { set { m_APIDStrength = value; } }
+        public override float APIDDamping { set { m_APIDDamping = value; } }
        public override float PIDHoverHeight { set { m_PIDHoverHeight = value; ; } }
        public override bool PIDHoverActive { set { m_useHoverPID = value; } }
diff --git a/OpenSim/Region/Physics/POSPlugin/POSCharacter.cs b/OpenSim/Region/Physics/POSPlugin/POSCharacter.cs
index 26cd1dd..566b4e7 100644
--- a/OpenSim/Region/Physics/POSPlugin/POSCharacter.cs
+++ b/OpenSim/Region/Physics/POSPlugin/POSCharacter.cs
@@ -304,6 +304,27 @@ namespace OpenSim.Region.Physics.POSPlugin
        {
            set { return; }
        }
+        
+        public override Quaternion APIDTarget
+        {
+            set { return; }
+        }
+        public override bool APIDActive
+        {
+            set { return; }
+        }
+        public override float APIDStrength
+        {
+            set { return; }
+        }
+        public override float APIDDamping
+        {
+            set { return; }
+        }
        public override void SubscribeEvents(int ms)
        {
diff --git a/OpenSim/Region/Physics/POSPlugin/POSPrim.cs b/OpenSim/Region/Physics/POSPlugin/POSPrim.cs
index 96c3e26..847b634 100644
--- a/OpenSim/Region/Physics/POSPlugin/POSPrim.cs
+++ b/OpenSim/Region/Physics/POSPlugin/POSPrim.cs
@@ -299,6 +299,26 @@ namespace OpenSim.Region.Physics.POSPlugin
        {
            set { return; }
        }
+        public override Quaternion APIDTarget
+        {
+            set { return; }
+        }
+        public override bool APIDActive
+        {
+            set { return; }
+        }
+        public override float APIDStrength
+        {
+            set { return; }
+        }
+        public override float APIDDamping
+        {
+            set { return; }
+        }
        public override void SubscribeEvents(int ms)
        {
diff --git a/OpenSim/Region/Physics/PhysXPlugin/PhysXPlugin.cs b/OpenSim/Region/Physics/PhysXPlugin/PhysXPlugin.cs
index 8bdb18d..24eb6b1 100644
--- a/OpenSim/Region/Physics/PhysXPlugin/PhysXPlugin.cs
+++ b/OpenSim/Region/Physics/PhysXPlugin/PhysXPlugin.cs
@@ -498,6 +498,28 @@ namespace OpenSim.Region.Physics.PhysXPlugin
        public override bool PIDHoverActive { set { return; } }
        public override PIDHoverType PIDHoverType { set { return; } }
        public override float PIDHoverTau { set { return; } }
+        
+        public override Quaternion APIDTarget
+        {
+            set { return; }
+        }
+        public override bool APIDActive
+        {
+            set { return; }
+        }
+        public override float APIDStrength
+        {
+            set { return; }
+        }
+        public override float APIDDamping
+        {
+            set { return; }
+        }
        public override void SubscribeEvents(int ms)
        {
@@ -780,6 +802,28 @@ namespace OpenSim.Region.Physics.PhysXPlugin
        public override bool PIDHoverActive { set { return; } }
        public override PIDHoverType PIDHoverType { set { return; } }
        public override float PIDHoverTau { set { return; } }
+        
+        public override Quaternion APIDTarget
+        {
+            set { return; }
+        }
+        public override bool APIDActive
+        {
+            set { return; }
+        }
+        public override float APIDStrength
+        {
+            set { return; }
+        }
+        public override float APIDDamping
+        {
+            set { return; }
+        }
+        
        public override void SubscribeEvents(int ms)
        {
diff --git a/OpenSim/Region/ScriptEngine/Shared/Api/Implementation/LSL_Api.cs b/OpenSim/Region/ScriptEngine/Shared/Api/Implementation/LSL_Api.cs
index 9c62775..a94cd46 100644
--- a/OpenSim/Region/ScriptEngine/Shared/Api/Implementation/LSL_Api.cs
+++ b/OpenSim/Region/ScriptEngine/Shared/Api/Implementation/LSL_Api.cs
@@ -28,6 +28,7 @@
 using System;
 using System.Collections;
 using System.Collections.Generic;
+using System.Diagnostics; //for [DebuggerNonUserCode]
 using System.Runtime.Remoting.Lifetime;
 using System.Text;
 using System.Threading;
@@ -151,6 +152,7 @@ namespace OpenSim.Region.ScriptEngine.Shared.Api
            get { return m_ScriptEngine.World; }
        }
+        [DebuggerNonUserCode]
        public void state(string newState)
        {
            m_ScriptEngine.SetState(m_itemID, newState);
@@ -160,6 +162,7 @@ namespace OpenSim.Region.ScriptEngine.Shared.Api
        /// Reset the named script. The script must be present
        /// in the same prim.
        /// </summary>
+        [DebuggerNonUserCode]
        public void llResetScript()
        {
            m_host.AddScriptLPS(1);
@@ -272,40 +275,48 @@ namespace OpenSim.Region.ScriptEngine.Shared.Api
        protected UUID InventorySelf()
        {
            UUID invItemID = new UUID();
+            bool unlock = false;
-            lock (m_host.TaskInventory)
+            if (!m_host.TaskInventory.IsReadLockedByMe())
+            {
+                m_host.TaskInventory.LockItemsForRead(true);
+                unlock = true;
+            }
+            foreach (KeyValuePair<UUID, TaskInventoryItem> inv in m_host.TaskInventory)
            {
-                foreach (KeyValuePair<UUID, TaskInventoryItem> inv in m_host.TaskInventory)
+                if (inv.Value.Type == 10 && inv.Value.ItemID == m_itemID)
                {
-                    if (inv.Value.Type == 10 && inv.Value.ItemID == m_itemID)
+                    invItemID = inv.Key;
-                    {
+                    break;
-                        invItemID = inv.Key;
-                        break;
-                    }
                }
            }
+            if (unlock)
+            {
+                m_host.TaskInventory.LockItemsForRead(false);
+            }
            return invItemID;
        }
        protected UUID InventoryKey(string name, int type)
        {
            m_host.AddScriptLPS(1);
+            m_host.TaskInventory.LockItemsForRead(true);
-            lock (m_host.TaskInventory)
+            
+            foreach (KeyValuePair<UUID, TaskInventoryItem> inv in m_host.TaskInventory)
            {
-                foreach (KeyValuePair<UUID, TaskInventoryItem> inv in m_host.TaskInventory)
+                if (inv.Value.Name == name)
                {
-                    if (inv.Value.Name == name)
+                    m_host.TaskInventory.LockItemsForRead(false);
+                    
+                    if (inv.Value.Type != type)
                    {
-                        if (inv.Value.Type != type)
+                        return UUID.Zero;
-                            return UUID.Zero;
-                        return inv.Value.AssetID;
                    }
+                    return inv.Value.AssetID;
                }
            }
+            m_host.TaskInventory.LockItemsForRead(false);
            return UUID.Zero;
        }
@@ -313,17 +324,21 @@ namespace OpenSim.Region.ScriptEngine.Shared.Api
        {
            m_host.AddScriptLPS(1);
-            lock (m_host.TaskInventory)
+            
+            m_host.TaskInventory.LockItemsForRead(true);
+            foreach (KeyValuePair<UUID, TaskInventoryItem> inv in m_host.TaskInventory)
            {
-                foreach (KeyValuePair<UUID, TaskInventoryItem> inv in m_host.TaskInventory)
+                if (inv.Value.Name == name)
                {
-                    if (inv.Value.Name == name)
+                    m_host.TaskInventory.LockItemsForRead(false);
-                    {
+                    return inv.Value.AssetID;
-                        return inv.Value.AssetID;
-                    }
                }
            }
+            m_host.TaskInventory.LockItemsForRead(false);
            return UUID.Zero;
        }
@@ -2534,12 +2549,9 @@ namespace OpenSim.Region.ScriptEngine.Shared.Api
            m_host.AddScriptLPS(1);
+            m_host.TaskInventory.LockItemsForRead(true);
            TaskInventoryItem item = m_host.TaskInventory[invItemID];
+            m_host.TaskInventory.LockItemsForRead(false);
-            lock (m_host.TaskInventory)
-            {
-                item = m_host.TaskInventory[invItemID];
-            }
            if (item.PermsGranter == UUID.Zero)
                return 0;
@@ -2614,6 +2626,7 @@ namespace OpenSim.Region.ScriptEngine.Shared.Api
            if (dist > m_ScriptDistanceFactor * 10.0f)
                return;
+            //Clone is thread-safe
            TaskInventoryDictionary partInventory = (TaskInventoryDictionary)m_host.TaskInventory.Clone();
            foreach (KeyValuePair<UUID, TaskInventoryItem> inv in partInventory)
@@ -2699,11 +2712,21 @@ namespace OpenSim.Region.ScriptEngine.Shared.Api
            // Orient the object to the angle calculated
            llSetRot(rot);
        }
+        
+        public void llRotLookAt(LSL_Rotation target, double strength, double damping)
+        {
+            m_host.AddScriptLPS(1);
+//            NotImplemented("llRotLookAt");
+            m_host.RotLookAt(Rot2Quaternion(target), (float)strength, (float)damping);
+            
+        }
        public void llStopLookAt()
        {
            m_host.AddScriptLPS(1);
-            NotImplemented("llStopLookAt");
+//            NotImplemented("llStopLookAt");
+            m_host.StopLookAt();
        }
        public void llSetTimerEvent(double sec)
@@ -2737,13 +2760,17 @@ namespace OpenSim.Region.ScriptEngine.Shared.Api
        {
            TaskInventoryItem item;
-            lock (m_host.TaskInventory)
+            m_host.TaskInventory.LockItemsForRead(true);
+            if (!m_host.TaskInventory.ContainsKey(InventorySelf()))
            {
-                if (!m_host.TaskInventory.ContainsKey(InventorySelf()))
+                m_host.TaskInventory.LockItemsForRead(false);
-                    return;
+                return;
-                else
+            }
-                    item = m_host.TaskInventory[InventorySelf()];
+            else
+            {
+                item = m_host.TaskInventory[InventorySelf()];
            }
+            m_host.TaskInventory.LockItemsForRead(false);
            if (item.PermsGranter != UUID.Zero)
            {
@@ -2765,13 +2792,21 @@ namespace OpenSim.Region.ScriptEngine.Shared.Api
        {
            TaskInventoryItem item;
+            m_host.TaskInventory.LockItemsForRead(true);
            lock (m_host.TaskInventory)
            {
+                
                if (!m_host.TaskInventory.ContainsKey(InventorySelf()))
+                {
+                    m_host.TaskInventory.LockItemsForRead(false);
                    return;
+                }
                else
+                {
                    item = m_host.TaskInventory[InventorySelf()];
+                }
            }
+            m_host.TaskInventory.LockItemsForRead(false);
            m_host.AddScriptLPS(1);
@@ -2808,13 +2843,19 @@ namespace OpenSim.Region.ScriptEngine.Shared.Api
            TaskInventoryItem item;
-            lock (m_host.TaskInventory)
+            m_host.TaskInventory.LockItemsForRead(true);
+            if (!m_host.TaskInventory.ContainsKey(InventorySelf()))
            {
-                if (!m_host.TaskInventory.ContainsKey(InventorySelf()))
+                m_host.TaskInventory.LockItemsForRead(false);
-                    return;
+                return;
-                else
-                    item = m_host.TaskInventory[InventorySelf()];
            }
+            else
+            {
+                item = m_host.TaskInventory[InventorySelf()];
+            }
+            m_host.TaskInventory.LockItemsForRead(false);
            if (item.PermsGranter != m_host.OwnerID)
                return;
@@ -2840,13 +2881,19 @@ namespace OpenSim.Region.ScriptEngine.Shared.Api
            TaskInventoryItem item;
-            lock (m_host.TaskInventory)
+            m_host.TaskInventory.LockItemsForRead(true);
+            if (!m_host.TaskInventory.ContainsKey(InventorySelf()))
            {
-                if (!m_host.TaskInventory.ContainsKey(InventorySelf()))
+                m_host.TaskInventory.LockItemsForRead(false);
-                    return;
+                return;
-                else
-                    item = m_host.TaskInventory[InventorySelf()];
            }
+            else
+            {
+                item = m_host.TaskInventory[InventorySelf()];
+            }
+            m_host.TaskInventory.LockItemsForRead(false);
            if (item.PermsGranter != m_host.OwnerID)
                return;
@@ -3047,12 +3094,6 @@ namespace OpenSim.Region.ScriptEngine.Shared.Api
            m_host.AddScriptLPS(1);
        }
-        public void llRotLookAt(LSL_Rotation target, double strength, double damping)
-        {
-            m_host.AddScriptLPS(1);
-            NotImplemented("llRotLookAt");
-        }
        public LSL_Integer llStringLength(string str)
        {
            m_host.AddScriptLPS(1);
@@ -3076,14 +3117,17 @@ namespace OpenSim.Region.ScriptEngine.Shared.Api
            TaskInventoryItem item;
-            lock (m_host.TaskInventory)
+            m_host.TaskInventory.LockItemsForRead(true);
+            if (!m_host.TaskInventory.ContainsKey(InventorySelf()))
            {
-                if (!m_host.TaskInventory.ContainsKey(InventorySelf()))
+                m_host.TaskInventory.LockItemsForRead(false);
-                    return;
+                return;
-                else
-                    item = m_host.TaskInventory[InventorySelf()];
            }
+            else
+            {
+                item = m_host.TaskInventory[InventorySelf()];
+            }
+            m_host.TaskInventory.LockItemsForRead(false);
            if (item.PermsGranter == UUID.Zero)
                return;
@@ -3113,13 +3157,18 @@ namespace OpenSim.Region.ScriptEngine.Shared.Api
            TaskInventoryItem item;
-            lock (m_host.TaskInventory)
+            m_host.TaskInventory.LockItemsForRead(true);
+            if (!m_host.TaskInventory.ContainsKey(InventorySelf()))
            {
-                if (!m_host.TaskInventory.ContainsKey(InventorySelf()))
+                m_host.TaskInventory.LockItemsForRead(false);
-                    return;
+                return;
-                else
+            }
-                    item = m_host.TaskInventory[InventorySelf()];
+            else
+            {
+                item = m_host.TaskInventory[InventorySelf()];
            }
+            m_host.TaskInventory.LockItemsForRead(false);
+            
            if (item.PermsGranter == UUID.Zero)
                return;
@@ -3192,10 +3241,18 @@ namespace OpenSim.Region.ScriptEngine.Shared.Api
            TaskInventoryItem item;
-            lock (m_host.TaskInventory)
+            m_host.TaskInventory.LockItemsForRead(true);
+            if (!m_host.TaskInventory.ContainsKey(invItemID))
+            {
+                m_host.TaskInventory.LockItemsForRead(false);
+                return;
+            }
+            else
            {
                item = m_host.TaskInventory[invItemID];
            }
+            m_host.TaskInventory.LockItemsForRead(false);
            if (agentID == UUID.Zero || perm == 0) // Releasing permissions
            {
@@ -3227,11 +3284,10 @@ namespace OpenSim.Region.ScriptEngine.Shared.Api
                if ((perm & (~implicitPerms)) == 0) // Requested only implicit perms
                {
-                    lock (m_host.TaskInventory)
+                    m_host.TaskInventory.LockItemsForWrite(true);
-                    {
+                    m_host.TaskInventory[invItemID].PermsGranter = agentID;
-                        m_host.TaskInventory[invItemID].PermsGranter = agentID;
+                    m_host.TaskInventory[invItemID].PermsMask = perm;
-                        m_host.TaskInventory[invItemID].PermsMask = perm;
+                    m_host.TaskInventory.LockItemsForWrite(false);
-                    }
                    m_ScriptEngine.PostScriptEvent(m_itemID, new EventParams(
                            "run_time_permissions", new Object[] {
@@ -3251,11 +3307,10 @@ namespace OpenSim.Region.ScriptEngine.Shared.Api
                if ((perm & (~implicitPerms)) == 0) // Requested only implicit perms
                {
-                    lock (m_host.TaskInventory)
+                    m_host.TaskInventory.LockItemsForWrite(true);
-                    {
+                    m_host.TaskInventory[invItemID].PermsGranter = agentID;
-                        m_host.TaskInventory[invItemID].PermsGranter = agentID;
+                    m_host.TaskInventory[invItemID].PermsMask = perm;
-                        m_host.TaskInventory[invItemID].PermsMask = perm;
+                    m_host.TaskInventory.LockItemsForWrite(false);
-                    }
                    m_ScriptEngine.PostScriptEvent(m_itemID, new EventParams(
                            "run_time_permissions", new Object[] {
@@ -3276,11 +3331,10 @@ namespace OpenSim.Region.ScriptEngine.Shared.Api
                if (!m_waitingForScriptAnswer)
                {
-                    lock (m_host.TaskInventory)
+                    m_host.TaskInventory.LockItemsForWrite(true);
-                    {
+                    m_host.TaskInventory[invItemID].PermsGranter = agentID;
-                        m_host.TaskInventory[invItemID].PermsGranter = agentID;
+                    m_host.TaskInventory[invItemID].PermsMask = 0;
-                        m_host.TaskInventory[invItemID].PermsMask = 0;
+                    m_host.TaskInventory.LockItemsForWrite(false);
-                    }
                    presence.ControllingClient.OnScriptAnswer += handleScriptAnswer;
                    m_waitingForScriptAnswer=true;
@@ -3315,10 +3369,11 @@ namespace OpenSim.Region.ScriptEngine.Shared.Api
            if ((answer & ScriptBaseClass.PERMISSION_TAKE_CONTROLS) == 0)
                llReleaseControls();
-            lock (m_host.TaskInventory)
+            
-            {
+            m_host.TaskInventory.LockItemsForWrite(true);
-                m_host.TaskInventory[invItemID].PermsMask = answer;
+            m_host.TaskInventory[invItemID].PermsMask = answer;
-            }
+            m_host.TaskInventory.LockItemsForWrite(false);
+            
            m_ScriptEngine.PostScriptEvent(m_itemID, new EventParams(
                    "run_time_permissions", new Object[] {
@@ -3330,16 +3385,17 @@ namespace OpenSim.Region.ScriptEngine.Shared.Api
        {
            m_host.AddScriptLPS(1);
-            lock (m_host.TaskInventory)
+            m_host.TaskInventory.LockItemsForRead(true);
+            
+            foreach (TaskInventoryItem item in m_host.TaskInventory.Values)
            {
-                foreach (TaskInventoryItem item in m_host.TaskInventory.Values)
+                if (item.Type == 10 && item.ItemID == m_itemID)
                {
-                    if (item.Type == 10 && item.ItemID == m_itemID)
+                    m_host.TaskInventory.LockItemsForRead(false);
-                    {
+                    return item.PermsGranter.ToString();
-                        return item.PermsGranter.ToString();
-                    }
                }
            }
+            m_host.TaskInventory.LockItemsForRead(false);
            return UUID.Zero.ToString();
        }
@@ -3348,19 +3404,20 @@ namespace OpenSim.Region.ScriptEngine.Shared.Api
        {
            m_host.AddScriptLPS(1);
-            lock (m_host.TaskInventory)
+            m_host.TaskInventory.LockItemsForRead(true);
+            foreach (TaskInventoryItem item in m_host.TaskInventory.Values)
            {
-                foreach (TaskInventoryItem item in m_host.TaskInventory.Values)
+                if (item.Type == 10 && item.ItemID == m_itemID)
                {
-                    if (item.Type == 10 && item.ItemID == m_itemID)
+                    int perms = item.PermsMask;
-                    {
+                    if (m_automaticLinkPermission)
-                        int perms = item.PermsMask;
+                        perms |= ScriptBaseClass.PERMISSION_CHANGE_LINKS;
-                        if (m_automaticLinkPermission)
+                    m_host.TaskInventory.LockItemsForRead(false);
-                            perms |= ScriptBaseClass.PERMISSION_CHANGE_LINKS;
+                    return perms;
-                        return perms;
-                    }
                }
            }
+            m_host.TaskInventory.LockItemsForRead(false);
            return 0;
        }
@@ -3393,11 +3450,10 @@ namespace OpenSim.Region.ScriptEngine.Shared.Api
            UUID invItemID = InventorySelf();
            TaskInventoryItem item;
-            lock (m_host.TaskInventory)
+            m_host.TaskInventory.LockItemsForRead(true);
-            {
+            item = m_host.TaskInventory[invItemID];
-                item = m_host.TaskInventory[invItemID];
+            m_host.TaskInventory.LockItemsForRead(false);
-            }
+             
            if ((item.PermsMask & ScriptBaseClass.PERMISSION_CHANGE_LINKS) == 0
                && !m_automaticLinkPermission)
            {
@@ -3450,16 +3506,16 @@ namespace OpenSim.Region.ScriptEngine.Shared.Api
            m_host.AddScriptLPS(1);
            UUID invItemID = InventorySelf();
-            lock (m_host.TaskInventory)
+            m_host.TaskInventory.LockItemsForRead(true);
-            {
                if ((m_host.TaskInventory[invItemID].PermsMask & ScriptBaseClass.PERMISSION_CHANGE_LINKS) == 0
                    && !m_automaticLinkPermission)
                {
                    ShoutError("Script trying to link but PERMISSION_CHANGE_LINKS permission not set!");
+                    m_host.TaskInventory.LockItemsForRead(false);
                    return;
                }
-            }
+            m_host.TaskInventory.LockItemsForRead(false);
+            
            if (linknum < ScriptBaseClass.LINK_THIS)
                return;
@@ -3628,17 +3684,16 @@ namespace OpenSim.Region.ScriptEngine.Shared.Api
            m_host.AddScriptLPS(1);
            int count = 0;
-            lock (m_host.TaskInventory)
+            m_host.TaskInventory.LockItemsForRead(true);
+            foreach (KeyValuePair<UUID, TaskInventoryItem> inv in m_host.TaskInventory)
            {
-                foreach (KeyValuePair<UUID, TaskInventoryItem> inv in m_host.TaskInventory)
+                if (inv.Value.Type == type || type == -1)
                {
-                    if (inv.Value.Type == type || type == -1)
+                    count = count + 1;
-                    {
-                        count = count + 1;
-                    }
                }
            }
+            
+            m_host.TaskInventory.LockItemsForRead(false);
            return count;
        }
@@ -3647,16 +3702,15 @@ namespace OpenSim.Region.ScriptEngine.Shared.Api
            m_host.AddScriptLPS(1);
            ArrayList keys = new ArrayList();
-            lock (m_host.TaskInventory)
+            m_host.TaskInventory.LockItemsForRead(true);
+            foreach (KeyValuePair<UUID, TaskInventoryItem> inv in m_host.TaskInventory)
            {
-                foreach (KeyValuePair<UUID, TaskInventoryItem> inv in m_host.TaskInventory)
+                if (inv.Value.Type == type || type == -1)
                {
-                    if (inv.Value.Type == type || type == -1)
+                    keys.Add(inv.Value.Name);
-                    {
-                        keys.Add(inv.Value.Name);
-                    }
                }
            }
+            m_host.TaskInventory.LockItemsForRead(false);
            if (keys.Count == 0)
            {
@@ -3693,20 +3747,19 @@ namespace OpenSim.Region.ScriptEngine.Shared.Api
            }
            // move the first object found with this inventory name
-            lock (m_host.TaskInventory)
+            m_host.TaskInventory.LockItemsForRead(true);
+            foreach (KeyValuePair<UUID, TaskInventoryItem> inv in m_host.TaskInventory)
            {
-                foreach (KeyValuePair<UUID, TaskInventoryItem> inv in m_host.TaskInventory)
+                if (inv.Value.Name == inventory)
                {
-                    if (inv.Value.Name == inventory)
+                    found = true;
-                    {
+                    objId = inv.Key;
-                        found = true;
+                    assetType = inv.Value.Type;
-                        objId = inv.Key;
+                    objName = inv.Value.Name;
-                        assetType = inv.Value.Type;
+                    break;
-                        objName = inv.Value.Name;
-                        break;
-                    }
                }
            }
+            m_host.TaskInventory.LockItemsForRead(false);
            if (!found)
            {
@@ -3751,24 +3804,26 @@ namespace OpenSim.Region.ScriptEngine.Shared.Api
            ScriptSleep(3000);
        }
+        [DebuggerNonUserCode]
        public void llRemoveInventory(string name)
        {
            m_host.AddScriptLPS(1);
-            lock (m_host.TaskInventory)
+            m_host.TaskInventory.LockItemsForRead(true);
+            foreach (TaskInventoryItem item in m_host.TaskInventory.Values)
            {
-                foreach (TaskInventoryItem item in m_host.TaskInventory.Values)
+                if (item.Name == name)
                {
-                    if (item.Name == name)
+                    if (item.ItemID == m_itemID)
-                    {
+                        throw new ScriptDeleteException();
-                        if (item.ItemID == m_itemID)
+                    else
-                            throw new ScriptDeleteException();
+                        m_host.Inventory.RemoveInventoryItem(item.ItemID);
-                        else
-                            m_host.Inventory.RemoveInventoryItem(item.ItemID);
+                    m_host.TaskInventory.LockItemsForRead(false);
-                        return;
+                    return;
-                    }
                }
            }
+            m_host.TaskInventory.LockItemsForRead(false);
        }
        public void llSetText(string text, LSL_Vector color, double alpha)
@@ -3857,6 +3912,7 @@ namespace OpenSim.Region.ScriptEngine.Shared.Api
        {
            m_host.AddScriptLPS(1);
+            //Clone is thread safe
            TaskInventoryDictionary itemDictionary = (TaskInventoryDictionary)m_host.TaskInventory.Clone();
            foreach (TaskInventoryItem item in itemDictionary.Values)
@@ -3947,17 +4003,16 @@ namespace OpenSim.Region.ScriptEngine.Shared.Api
            UUID soundId = UUID.Zero;
            if (!UUID.TryParse(impact_sound, out soundId))
            {
-                lock (m_host.TaskInventory)
+                m_host.TaskInventory.LockItemsForRead(true);
+                foreach (TaskInventoryItem item in m_host.TaskInventory.Values)
                {
-                    foreach (TaskInventoryItem item in m_host.TaskInventory.Values)
+                    if (item.Type == (int)AssetType.Sound && item.Name == impact_sound)
                    {
-                        if (item.Type == (int)AssetType.Sound && item.Name == impact_sound)
+                        soundId = item.AssetID;
-                        {
+                        break;
-                            soundId = item.AssetID;
-                            break;
-                        }
                    }
                }
+                m_host.TaskInventory.LockItemsForRead(false);
            }
            m_host.CollisionSound = soundId;
            m_host.CollisionSoundVolume = (float)impact_volume;
@@ -4003,6 +4058,7 @@ namespace OpenSim.Region.ScriptEngine.Shared.Api
            UUID partItemID;
            foreach (SceneObjectPart part in parts)
            {
+                //Clone is thread safe
                TaskInventoryDictionary itemsDictionary = (TaskInventoryDictionary)part.TaskInventory.Clone();
                foreach (TaskInventoryItem item in itemsDictionary.Values)
@@ -4210,17 +4266,16 @@ namespace OpenSim.Region.ScriptEngine.Shared.Api
            m_host.AddScriptLPS(1);
-            lock (m_host.TaskInventory)
+            m_host.TaskInventory.LockItemsForRead(true);
+            foreach (TaskInventoryItem item in m_host.TaskInventory.Values)
            {
-                foreach (TaskInventoryItem item in m_host.TaskInventory.Values)
+                if (item.Type == 10 && item.ItemID == m_itemID)
                {
-                    if (item.Type == 10 && item.ItemID == m_itemID)
+                    result =  item.Name!=null?item.Name:String.Empty;
-                    {
+                    break;
-                        result =  item.Name!=null?item.Name:String.Empty;
-                        break;
-                    }
                }
            }
+            m_host.TaskInventory.LockItemsForRead(false);
            return result;
        }
@@ -4478,23 +4533,24 @@ namespace OpenSim.Region.ScriptEngine.Shared.Api
        {
            m_host.AddScriptLPS(1);
-            lock (m_host.TaskInventory)
+            m_host.TaskInventory.LockItemsForRead(true);
+            foreach (KeyValuePair<UUID, TaskInventoryItem> inv in m_host.TaskInventory)
            {
-                foreach (KeyValuePair<UUID, TaskInventoryItem> inv in m_host.TaskInventory)
+                if (inv.Value.Name == name)
                {
-                    if (inv.Value.Name == name)
+                    if ((inv.Value.CurrentPermissions & (uint)(PermissionMask.Copy | PermissionMask.Transfer | PermissionMask.Modify)) == (uint)(PermissionMask.Copy | PermissionMask.Transfer | PermissionMask.Modify))
                    {
-                        if ((inv.Value.CurrentPermissions & (uint)(PermissionMask.Copy | PermissionMask.Transfer | PermissionMask.Modify)) == (uint)(PermissionMask.Copy | PermissionMask.Transfer | PermissionMask.Modify))
+                        m_host.TaskInventory.LockItemsForRead(false);
-                        {
+                        return inv.Value.AssetID.ToString();
-                            return inv.Value.AssetID.ToString();
+                    }
-                        }
+                    else
-                        else
+                    {
-                        {
+                        m_host.TaskInventory.LockItemsForRead(false);
-                            return UUID.Zero.ToString();
+                        return UUID.Zero.ToString();
-                        }
                    }
                }
            }
+            m_host.TaskInventory.LockItemsForRead(false);
            return UUID.Zero.ToString();
        }
@@ -5989,14 +6045,16 @@ namespace OpenSim.Region.ScriptEngine.Shared.Api
        protected UUID GetTaskInventoryItem(string name)
        {
-            lock (m_host.TaskInventory)
+            m_host.TaskInventory.LockItemsForRead(true);
+            foreach (KeyValuePair<UUID, TaskInventoryItem> inv in m_host.TaskInventory)
            {
-                foreach (KeyValuePair<UUID, TaskInventoryItem> inv in m_host.TaskInventory)
+                if (inv.Value.Name == name)
                {
-                    if (inv.Value.Name == name)
+                    m_host.TaskInventory.LockItemsForRead(false);
-                        return inv.Key;
+                    return inv.Key;
                }
            }
+            m_host.TaskInventory.LockItemsForRead(false);
            return UUID.Zero;
        }
@@ -6307,22 +6365,21 @@ namespace OpenSim.Region.ScriptEngine.Shared.Api
            }
            // copy the first script found with this inventory name
-            lock (m_host.TaskInventory)
+            m_host.TaskInventory.LockItemsForRead(true);
+            foreach (KeyValuePair<UUID, TaskInventoryItem> inv in m_host.TaskInventory)
            {
-                foreach (KeyValuePair<UUID, TaskInventoryItem> inv in m_host.TaskInventory)
+                if (inv.Value.Name == name)
                {
-                    if (inv.Value.Name == name)
+                    // make sure the object is a script
+                    if (10 == inv.Value.Type)
                    {
-                        // make sure the object is a script
+                        found = true;
-                        if (10 == inv.Value.Type)
+                        srcId = inv.Key;
-                        {
+                        break;
-                            found = true;
-                            srcId = inv.Key;
-                            break;
-                        }
                    }
                }
            }
+            m_host.TaskInventory.LockItemsForRead(false);
            if (!found)
            {
@@ -8125,28 +8182,28 @@ namespace OpenSim.Region.ScriptEngine.Shared.Api
        {
            m_host.AddScriptLPS(1);
-            lock (m_host.TaskInventory)
+            m_host.TaskInventory.LockItemsForRead(true);
+            foreach (KeyValuePair<UUID, TaskInventoryItem> inv in m_host.TaskInventory)
            {
-                foreach (KeyValuePair<UUID, TaskInventoryItem> inv in m_host.TaskInventory)
+                if (inv.Value.Name == item)
                {
-                    if (inv.Value.Name == item)
+                    m_host.TaskInventory.LockItemsForRead(false);
+                    switch (mask)
                    {
-                        switch (mask)
+                        case 0:
-                        {
+                            return (int)inv.Value.BasePermissions;
-                            case 0:
+                        case 1:
-                                return (int)inv.Value.BasePermissions;
+                            return (int)inv.Value.CurrentPermissions;
-                            case 1:
+                        case 2:
-                                return (int)inv.Value.CurrentPermissions;
+                            return (int)inv.Value.GroupPermissions;
-                            case 2:
+                        case 3:
-                                return (int)inv.Value.GroupPermissions;
+                            return (int)inv.Value.EveryonePermissions;
-                            case 3:
+                        case 4:
-                                return (int)inv.Value.EveryonePermissions;
+                            return (int)inv.Value.NextPermissions;
-                            case 4:
-                                return (int)inv.Value.NextPermissions;
-                        }
                    }
                }
            }
+            m_host.TaskInventory.LockItemsForRead(false);
            return -1;
        }
@@ -8161,16 +8218,16 @@ namespace OpenSim.Region.ScriptEngine.Shared.Api
        {
            m_host.AddScriptLPS(1);
-            lock (m_host.TaskInventory)
+            m_host.TaskInventory.LockItemsForRead(true);
+            foreach (KeyValuePair<UUID, TaskInventoryItem> inv in m_host.TaskInventory)
            {
-                foreach (KeyValuePair<UUID, TaskInventoryItem> inv in m_host.TaskInventory)
+                if (inv.Value.Name == item)
                {
-                    if (inv.Value.Name == item)
+                    m_host.TaskInventory.LockItemsForRead(false);
-                    {
+                    return inv.Value.CreatorID.ToString();
-                        return inv.Value.CreatorID.ToString();
-                    }
                }
            }
+            m_host.TaskInventory.LockItemsForRead(false);
            llSay(0, "No item name '" + item + "'");
@@ -8694,16 +8751,16 @@ namespace OpenSim.Region.ScriptEngine.Shared.Api
        {
            m_host.AddScriptLPS(1);
-            lock (m_host.TaskInventory)
+            m_host.TaskInventory.LockItemsForRead(true);
+            foreach (KeyValuePair<UUID, TaskInventoryItem> inv in m_host.TaskInventory)
            {
-                foreach (KeyValuePair<UUID, TaskInventoryItem> inv in m_host.TaskInventory)
+                if (inv.Value.Name == name)
                {
-                    if (inv.Value.Name == name)
+                    m_host.TaskInventory.LockItemsForRead(false);
-                    {
+                    return inv.Value.Type;
-                        return inv.Value.Type;
-                    }
                }
            }
+            m_host.TaskInventory.LockItemsForRead(false);
            return -1;
        }
@@ -8734,17 +8791,20 @@ namespace OpenSim.Region.ScriptEngine.Shared.Api
            if (invItemID == UUID.Zero)
                return new LSL_Vector();
-            lock (m_host.TaskInventory)
+            m_host.TaskInventory.LockItemsForRead(true);
+            if (m_host.TaskInventory[invItemID].PermsGranter == UUID.Zero)
            {
-                if (m_host.TaskInventory[invItemID].PermsGranter == UUID.Zero)
+                m_host.TaskInventory.LockItemsForRead(false);
-                   return new LSL_Vector();
+                return new LSL_Vector();
+            }
-                if ((m_host.TaskInventory[invItemID].PermsMask & ScriptBaseClass.PERMISSION_TRACK_CAMERA) == 0)
+            if ((m_host.TaskInventory[invItemID].PermsMask & ScriptBaseClass.PERMISSION_TRACK_CAMERA) == 0)
-                {
+            {
-                    ShoutError("No permissions to track the camera");
+                ShoutError("No permissions to track the camera");
-                    return new LSL_Vector();
+                m_host.TaskInventory.LockItemsForRead(false);
-                }
+                return new LSL_Vector();
            }
+            m_host.TaskInventory.LockItemsForRead(false);
            ScenePresence presence = World.GetScenePresence(m_host.OwnerID);
            if (presence != null)
@@ -8762,17 +8822,19 @@ namespace OpenSim.Region.ScriptEngine.Shared.Api
            if (invItemID == UUID.Zero)
                return new LSL_Rotation();
-            lock (m_host.TaskInventory)
+            m_host.TaskInventory.LockItemsForRead(true);
+            if (m_host.TaskInventory[invItemID].PermsGranter == UUID.Zero)
            {
-                if (m_host.TaskInventory[invItemID].PermsGranter == UUID.Zero)
+                m_host.TaskInventory.LockItemsForRead(false);
-                   return new LSL_Rotation();
+                return new LSL_Rotation();
-                if ((m_host.TaskInventory[invItemID].PermsMask & ScriptBaseClass.PERMISSION_TRACK_CAMERA) == 0)
-                {
-                    ShoutError("No permissions to track the camera");
-                    return new LSL_Rotation();
-                }
            }
+            if ((m_host.TaskInventory[invItemID].PermsMask & ScriptBaseClass.PERMISSION_TRACK_CAMERA) == 0)
+            {
+                ShoutError("No permissions to track the camera");
+                m_host.TaskInventory.LockItemsForRead(false);
+                return new LSL_Rotation();
+            }
+            m_host.TaskInventory.LockItemsForRead(false);
            ScenePresence presence = World.GetScenePresence(m_host.OwnerID);
            if (presence != null)
@@ -8922,14 +8984,21 @@ namespace OpenSim.Region.ScriptEngine.Shared.Api
            if (objectID == UUID.Zero) return;
            UUID agentID;
-            lock (m_host.TaskInventory)
+            m_host.TaskInventory.LockItemsForRead(true);
-            {
+            // we need the permission first, to know which avatar we want to set the camera for
-                // we need the permission first, to know which avatar we want to set the camera for
+            agentID = m_host.TaskInventory[invItemID].PermsGranter;
-                agentID = m_host.TaskInventory[invItemID].PermsGranter;
-                if (agentID == UUID.Zero) return;
+            if (agentID == UUID.Zero)
-                if ((m_host.TaskInventory[invItemID].PermsMask & ScriptBaseClass.PERMISSION_CONTROL_CAMERA) == 0) return;
+            {
+                m_host.TaskInventory.LockItemsForRead(false);
+                return;
            }
+            if ((m_host.TaskInventory[invItemID].PermsMask & ScriptBaseClass.PERMISSION_CONTROL_CAMERA) == 0)
+            {
+                m_host.TaskInventory.LockItemsForRead(false);
+                return;
+            }
+            m_host.TaskInventory.LockItemsForRead(false);
            ScenePresence presence = World.GetScenePresence(agentID);
@@ -8979,12 +9048,19 @@ namespace OpenSim.Region.ScriptEngine.Shared.Api
            // we need the permission first, to know which avatar we want to clear the camera for
            UUID agentID;
-            lock (m_host.TaskInventory)
+            m_host.TaskInventory.LockItemsForRead(true);
+            agentID = m_host.TaskInventory[invItemID].PermsGranter;
+            if (agentID == UUID.Zero)
+            {
+                m_host.TaskInventory.LockItemsForRead(false);
+                return;
+            }
+            if ((m_host.TaskInventory[invItemID].PermsMask & ScriptBaseClass.PERMISSION_CONTROL_CAMERA) == 0)
            {
-                agentID = m_host.TaskInventory[invItemID].PermsGranter;
+                m_host.TaskInventory.LockItemsForRead(false);
-                if (agentID == UUID.Zero) return;
+                return;
-                if ((m_host.TaskInventory[invItemID].PermsMask & ScriptBaseClass.PERMISSION_CONTROL_CAMERA) == 0) return;
            }
+            m_host.TaskInventory.LockItemsForRead(false);
            ScenePresence presence = World.GetScenePresence(agentID);
@@ -9441,15 +9517,19 @@ namespace OpenSim.Region.ScriptEngine.Shared.Api
        internal UUID ScriptByName(string name)
        {
-            lock (m_host.TaskInventory)
+            m_host.TaskInventory.LockItemsForRead(true);
+            foreach (TaskInventoryItem item in m_host.TaskInventory.Values)
            {
-                foreach (TaskInventoryItem item in m_host.TaskInventory.Values)
+                if (item.Type == 10 && item.Name == name)
                {
-                    if (item.Type == 10 && item.Name == name)
+                    m_host.TaskInventory.LockItemsForRead(false);
-                        return item.ItemID;
+                    return item.ItemID;
                }
            }
+            m_host.TaskInventory.LockItemsForRead(false);
            return UUID.Zero;
        }
@@ -9490,6 +9570,7 @@ namespace OpenSim.Region.ScriptEngine.Shared.Api
        {
            m_host.AddScriptLPS(1);
+            //Clone is thread safe
            TaskInventoryDictionary itemsDictionary = (TaskInventoryDictionary)m_host.TaskInventory.Clone();
            UUID assetID = UUID.Zero;
@@ -9552,6 +9633,7 @@ namespace OpenSim.Region.ScriptEngine.Shared.Api
        {
            m_host.AddScriptLPS(1);
+            //Clone is thread safe
            TaskInventoryDictionary itemsDictionary = (TaskInventoryDictionary)m_host.TaskInventory.Clone();
            UUID assetID = UUID.Zero;
diff --git a/OpenSim/Region/ScriptEngine/Shared/Api/Implementation/OSSL_Api.cs b/OpenSim/Region/ScriptEngine/Shared/Api/Implementation/OSSL_Api.cs
index 7fdbac8..83322eb 100644
--- a/OpenSim/Region/ScriptEngine/Shared/Api/Implementation/OSSL_Api.cs
+++ b/OpenSim/Region/ScriptEngine/Shared/Api/Implementation/OSSL_Api.cs
@@ -728,18 +728,17 @@ namespace OpenSim.Region.ScriptEngine.Shared.Api
                if (target != null)
                {
                    UUID animID=UUID.Zero;
-                    lock (m_host.TaskInventory)
+                    m_host.TaskInventory.LockItemsForRead(true);
+                    foreach (KeyValuePair<UUID, TaskInventoryItem> inv in m_host.TaskInventory)
                    {
-                        foreach (KeyValuePair<UUID, TaskInventoryItem> inv in m_host.TaskInventory)
+                        if (inv.Value.Name == animation)
                        {
-                            if (inv.Value.Name == animation)
+                            if (inv.Value.Type == (int)AssetType.Animation)
-                            {
+                                animID = inv.Value.AssetID;
-                                if (inv.Value.Type == (int)AssetType.Animation)
+                            continue;
-                                    animID = inv.Value.AssetID;
-                                continue;
-                            }
                        }
                    }
+                    m_host.TaskInventory.LockItemsForRead(false);
                    if (animID == UUID.Zero)
                        target.Animator.AddAnimation(animation, m_host.UUID);
                    else
@@ -761,18 +760,17 @@ namespace OpenSim.Region.ScriptEngine.Shared.Api
                if (target != null)
                {
                    UUID animID=UUID.Zero;
-                    lock (m_host.TaskInventory)
+                    m_host.TaskInventory.LockItemsForRead(true);
+                    foreach (KeyValuePair<UUID, TaskInventoryItem> inv in m_host.TaskInventory)
                    {
-                        foreach (KeyValuePair<UUID, TaskInventoryItem> inv in m_host.TaskInventory)
+                        if (inv.Value.Name == animation)
                        {
-                            if (inv.Value.Name == animation)
+                            if (inv.Value.Type == (int)AssetType.Animation)
-                            {
+                                animID = inv.Value.AssetID;
-                                if (inv.Value.Type == (int)AssetType.Animation)
+                            continue;
-                                    animID = inv.Value.AssetID;
-                                continue;
-                            }
                        }
                    }
+                    m_host.TaskInventory.LockItemsForRead(false);
                    
                    if (animID == UUID.Zero)
                        target.Animator.RemoveAnimation(animation);
@@ -1541,6 +1539,7 @@ namespace OpenSim.Region.ScriptEngine.Shared.Api
            if (!UUID.TryParse(name, out assetID))
            {
+                m_host.TaskInventory.LockItemsForRead(true);
                foreach (TaskInventoryItem item in m_host.TaskInventory.Values)
                {
                    if (item.Type == 7 && item.Name == name)
@@ -1548,6 +1547,7 @@ namespace OpenSim.Region.ScriptEngine.Shared.Api
                        assetID = item.AssetID;
                    }
                }
+                m_host.TaskInventory.LockItemsForRead(false);
            }
            if (assetID == UUID.Zero)
@@ -1594,6 +1594,7 @@ namespace OpenSim.Region.ScriptEngine.Shared.Api
            if (!UUID.TryParse(name, out assetID))
            {
+                m_host.TaskInventory.LockItemsForRead(true);
                foreach (TaskInventoryItem item in m_host.TaskInventory.Values)
                {
                    if (item.Type == 7 && item.Name == name)
@@ -1601,6 +1602,7 @@ namespace OpenSim.Region.ScriptEngine.Shared.Api
                        assetID = item.AssetID;
                    }
                }
+                m_host.TaskInventory.LockItemsForRead(false);
            }
            if (assetID == UUID.Zero)
@@ -1651,6 +1653,7 @@ namespace OpenSim.Region.ScriptEngine.Shared.Api
            if (!UUID.TryParse(name, out assetID))
            {
+                m_host.TaskInventory.LockItemsForRead(true);
                foreach (TaskInventoryItem item in m_host.TaskInventory.Values)
                {
                    if (item.Type == 7 && item.Name == name)
@@ -1658,6 +1661,7 @@ namespace OpenSim.Region.ScriptEngine.Shared.Api
                        assetID = item.AssetID;
                    }
                }
+                m_host.TaskInventory.LockItemsForRead(false);
            }
            if (assetID == UUID.Zero)
diff --git a/OpenSim/Region/ScriptEngine/Shared/Api/Runtime/Executor.cs b/OpenSim/Region/ScriptEngine/Shared/Api/Runtime/Executor.cs
index 7f67599..15e0408 100644
--- a/OpenSim/Region/ScriptEngine/Shared/Api/Runtime/Executor.cs
+++ b/OpenSim/Region/ScriptEngine/Shared/Api/Runtime/Executor.cs
@@ -27,6 +27,7 @@
 using System;
 using System.Collections.Generic;
+using System.Diagnostics; //for [DebuggerNonUserCode]
 using System.Reflection;
 using System.Runtime.Remoting.Lifetime;
 using OpenSim.Region.ScriptEngine.Shared;
@@ -131,6 +132,7 @@ namespace OpenSim.Region.ScriptEngine.Shared.ScriptBase
            return (eventFlags);
        }
+        [DebuggerNonUserCode]
        public void ExecuteEvent(string state, string FunctionName, object[] args)
        {
            // IMPORTANT: Types and MemberInfo-derived objects require a LOT of memory.
diff --git a/OpenSim/Region/ScriptEngine/Shared/Api/Runtime/ScriptBase.cs b/OpenSim/Region/ScriptEngine/Shared/Api/Runtime/ScriptBase.cs
index 121159c..a44abb0 100644
--- a/OpenSim/Region/ScriptEngine/Shared/Api/Runtime/ScriptBase.cs
+++ b/OpenSim/Region/ScriptEngine/Shared/Api/Runtime/ScriptBase.cs
@@ -33,6 +33,7 @@ using System.Threading;
 using System.Reflection;
 using System.Collections;
 using System.Collections.Generic;
+using System.Diagnostics; //for [DebuggerNonUserCode]
 using OpenSim.Region.ScriptEngine.Interfaces;
 using OpenSim.Region.ScriptEngine.Shared;
 using OpenSim.Region.ScriptEngine.Shared.Api.Runtime;
@@ -90,6 +91,7 @@ namespace OpenSim.Region.ScriptEngine.Shared.ScriptBase
            return (int)m_Executor.GetStateEventFlags(state);
        }
+        [DebuggerNonUserCode]
        public void ExecuteEvent(string state, string FunctionName, object[] args)
        {
            m_Executor.ExecuteEvent(state, FunctionName, args);
diff --git a/OpenSim/Region/ScriptEngine/Shared/Instance/ScriptInstance.cs b/OpenSim/Region/ScriptEngine/Shared/Instance/ScriptInstance.cs
index 41b5d49..0f4a9ad 100644
--- a/OpenSim/Region/ScriptEngine/Shared/Instance/ScriptInstance.cs
+++ b/OpenSim/Region/ScriptEngine/Shared/Instance/ScriptInstance.cs
@@ -27,6 +27,7 @@
 using System;
 using System.IO;
+using System.Diagnostics; //for [DebuggerNonUserCode]
 using System.Runtime.Remoting;
 using System.Runtime.Remoting.Lifetime;
 using System.Threading;
@@ -237,13 +238,12 @@ namespace OpenSim.Region.ScriptEngine.Shared.Instance
            if (part != null)
            {
-                lock (part.TaskInventory)
+                part.TaskInventory.LockItemsForRead(true);
+                if (part.TaskInventory.ContainsKey(m_ItemID))
                {
-                    if (part.TaskInventory.ContainsKey(m_ItemID))
+                    m_thisScriptTask = part.TaskInventory[m_ItemID];
-                    {
-                        m_thisScriptTask = part.TaskInventory[m_ItemID];
-                    }
                }
+                part.TaskInventory.LockItemsForRead(false);
            }
            ApiManager am = new ApiManager();
@@ -428,14 +428,15 @@ namespace OpenSim.Region.ScriptEngine.Shared.Instance
            {
                int permsMask;
                UUID permsGranter;
-                lock (part.TaskInventory)
+                part.TaskInventory.LockItemsForRead(true);
+                if (!part.TaskInventory.ContainsKey(m_ItemID))
                {
-                    if (!part.TaskInventory.ContainsKey(m_ItemID))
+                    part.TaskInventory.LockItemsForRead(false);
-                        return;
+                    return;
-                    permsGranter = part.TaskInventory[m_ItemID].PermsGranter;
-                    permsMask = part.TaskInventory[m_ItemID].PermsMask;
                }
+                permsGranter = part.TaskInventory[m_ItemID].PermsGranter;
+                permsMask = part.TaskInventory[m_ItemID].PermsMask;
+                part.TaskInventory.LockItemsForRead(false);
                if ((permsMask & ScriptBaseClass.PERMISSION_TAKE_CONTROLS) != 0)
                {
@@ -544,6 +545,7 @@ namespace OpenSim.Region.ScriptEngine.Shared.Instance
            return true;
        }
+        [DebuggerNonUserCode] //Prevents the debugger from farting in this function
        public void SetState(string state)
        {
            if (state == State)
@@ -555,7 +557,7 @@ namespace OpenSim.Region.ScriptEngine.Shared.Instance
                                       new DetectParams[0]));
            PostEvent(new EventParams("state_entry", new Object[0],
                                       new DetectParams[0]));
+            
            throw new EventAbortException();
        }
@@ -638,154 +640,158 @@ namespace OpenSim.Region.ScriptEngine.Shared.Instance
        /// <returns></returns>
        public object EventProcessor()
        {
+        EventParams data = null;
+        lock (m_EventQueue)
+        {
            lock (m_Script)
            {
-                EventParams data = null;
+                data = (EventParams) m_EventQueue.Dequeue();
+                if (data == null) // Shouldn't happen
-                lock (m_EventQueue)
                {
-                    data = (EventParams) m_EventQueue.Dequeue();
+                    if ((m_EventQueue.Count > 0) && m_RunEvents && (!m_ShuttingDown))
-                    if (data == null) // Shouldn't happen
                    {
-                        if ((m_EventQueue.Count > 0) && m_RunEvents && (!m_ShuttingDown))
+                        m_CurrentResult = m_Engine.QueueEventHandler(this);
-                        {
-                            m_CurrentResult = m_Engine.QueueEventHandler(this);
-                        }
-                        else
-                        {
-                            m_CurrentResult = null;
-                        }
-                        return 0;
                    }
+                    else
-                    if (data.EventName == "timer")
-                        m_TimerQueued = false;
-                    if (data.EventName == "control")
                    {
-                        if (m_ControlEventsInQueue > 0)
+                        m_CurrentResult = null;
-                            m_ControlEventsInQueue--;
                    }
-                    if (data.EventName == "collision")
+                    return 0;
-                        m_CollisionInQueue = false;
                }
-                
-                //m_log.DebugFormat("[XENGINE]: Processing event {0} for {1}", data.EventName, this);
-                m_DetectParams = data.DetectParams;
+                if (data.EventName == "timer")
+                    m_TimerQueued = false;
-                if (data.EventName == "state") // Hardcoded state change
+                if (data.EventName == "control")
                {
-    //                m_log.DebugFormat("[Script] Script {0}.{1} state set to {2}",
+                    if (m_ControlEventsInQueue > 0)
-    //                        m_PrimName, m_ScriptName, data.Params[0].ToString());
+                        m_ControlEventsInQueue--;
-                    m_State=data.Params[0].ToString();
+                }
-                    AsyncCommandManager.RemoveScript(m_Engine,
+                if (data.EventName == "collision")
-                        m_LocalID, m_ItemID);
+                    m_CollisionInQueue = false;
+            }
+        }
+        lock(m_Script)
+        {
+            
+            //m_log.DebugFormat("[XENGINE]: Processing event {0} for {1}", data.EventName, this);
-                    SceneObjectPart part = m_Engine.World.GetSceneObjectPart(
+            m_DetectParams = data.DetectParams;
-                        m_LocalID);
-                    if (part != null)
+            if (data.EventName == "state") // Hardcoded state change
-                    {
+            {
-                        part.SetScriptEvents(m_ItemID,
+//                m_log.DebugFormat("[Script] Script {0}.{1} state set to {2}",
-                                             (int)m_Script.GetStateEventFlags(State));
+//                        m_PrimName, m_ScriptName, data.Params[0].ToString());
-                    }
+                m_State=data.Params[0].ToString();
+                AsyncCommandManager.RemoveScript(m_Engine,
+                    m_LocalID, m_ItemID);
+                SceneObjectPart part = m_Engine.World.GetSceneObjectPart(
+                    m_LocalID);
+                if (part != null)
+                {
+                    part.SetScriptEvents(m_ItemID,
+                                         (int)m_Script.GetStateEventFlags(State));
                }
-                else
+            }
+            else
+            {
+                if (m_Engine.World.PipeEventsForScript(m_LocalID) ||
+                    data.EventName == "control") // Don't freeze avies!
                {
-                    if (m_Engine.World.PipeEventsForScript(m_LocalID) ||
+                    SceneObjectPart part = m_Engine.World.GetSceneObjectPart(
-                        data.EventName == "control") // Don't freeze avies!
+                        m_LocalID);
-                    {
+    //                m_log.DebugFormat("[Script] Delivered event {2} in state {3} to {0}.{1}",
-                        SceneObjectPart part = m_Engine.World.GetSceneObjectPart(
+    //                        m_PrimName, m_ScriptName, data.EventName, m_State);
-                            m_LocalID);
-        //                m_log.DebugFormat("[Script] Delivered event {2} in state {3} to {0}.{1}",
-        //                        m_PrimName, m_ScriptName, data.EventName, m_State);
-                        try
+                    try
-                        {
+                    {
-                            m_CurrentEvent = data.EventName;
+                        m_CurrentEvent = data.EventName;
-                            m_EventStart = DateTime.Now;
+                        m_EventStart = DateTime.Now;
-                            m_InEvent = true;
+                        m_InEvent = true;
-                            m_Script.ExecuteEvent(State, data.EventName, data.Params);
+                        m_Script.ExecuteEvent(State, data.EventName, data.Params);
-                            m_InEvent = false;
+                        m_InEvent = false;
-                            m_CurrentEvent = String.Empty;
+                        m_CurrentEvent = String.Empty;
-                            if (m_SaveState)
+                        if (m_SaveState)
-                            {
+                        {
-                                // This will be the very first event we deliver
+                            // This will be the very first event we deliver
-                                // (state_entry) in default state
+                            // (state_entry) in default state
-                                //
+                            //
-                                SaveState(m_Assembly);
+                            SaveState(m_Assembly);
-                                m_SaveState = false;
+                            m_SaveState = false;
-                            }
                        }
-                        catch (Exception e)
+                    }
-                        {
+                    catch (Exception e)
-                            // m_log.DebugFormat("[SCRIPT] Exception: {0}", e.Message);
+                    {
-                            m_InEvent = false;
+                        // m_log.DebugFormat("[SCRIPT] Exception: {0}", e.Message);
-                            m_CurrentEvent = String.Empty;
+                        m_InEvent = false;
+                        m_CurrentEvent = String.Empty;
-                            if ((!(e is TargetInvocationException) || (!(e.InnerException is SelfDeleteException) && !(e.InnerException is ScriptDeleteException))) && !(e is ThreadAbortException))
+                        if ((!(e is TargetInvocationException) || (!(e.InnerException is SelfDeleteException) && !(e.InnerException is ScriptDeleteException))) && !(e is ThreadAbortException))
-                            {
+                        {
-                                try
+                            try
-                                {
-                                    // DISPLAY ERROR INWORLD
-                                    string text = FormatException(e);
-                                    if (text.Length > 1000)
-                                        text = text.Substring(0, 1000);
-                                    m_Engine.World.SimChat(Utils.StringToBytes(text),
-                                                           ChatTypeEnum.DebugChannel, 2147483647,
-                                                           part.AbsolutePosition,
-                                                           part.Name, part.UUID, false);
-                                }
-                                catch (Exception)
-                                {
-                                }
-                                // catch (Exception e2) // LEGIT: User Scripting
-                                // {
-                                    // m_log.Error("[SCRIPT]: "+
-                                      //           "Error displaying error in-world: " +
-                                        //         e2.ToString());
-                                 //    m_log.Error("[SCRIPT]: " +
-                                   //              "Errormessage: Error compiling script:\r\n" +
-                                     //            e.ToString());
-                                // }
-                            }
-                            else if ((e is TargetInvocationException) && (e.InnerException is SelfDeleteException))
                            {
-                                m_InSelfDelete = true;
+                                // DISPLAY ERROR INWORLD
-                                if (part != null && part.ParentGroup != null)
+                                string text = FormatException(e);
-                                    m_Engine.World.DeleteSceneObject(part.ParentGroup, false);
+                                if (text.Length > 1000)
+                                    text = text.Substring(0, 1000);
+                                m_Engine.World.SimChat(Utils.StringToBytes(text),
+                                                       ChatTypeEnum.DebugChannel, 2147483647,
+                                                       part.AbsolutePosition,
+                                                       part.Name, part.UUID, false);
                            }
-                            else if ((e is TargetInvocationException) && (e.InnerException is ScriptDeleteException))
+                            catch (Exception)
                            {
-                                m_InSelfDelete = true;
-                                if (part != null && part.ParentGroup != null)
-                                    part.Inventory.RemoveInventoryItem(m_ItemID);
                            }
+                            // catch (Exception e2) // LEGIT: User Scripting
+                            // {
+                                // m_log.Error("[SCRIPT]: "+
+                                  //           "Error displaying error in-world: " +
+                                    //         e2.ToString());
+                             //    m_log.Error("[SCRIPT]: " +
+                               //              "Errormessage: Error compiling script:\r\n" +
+                                 //            e.ToString());
+                            // }
+                        }
+                        else if ((e is TargetInvocationException) && (e.InnerException is SelfDeleteException))
+                        {
+                            m_InSelfDelete = true;
+                            if (part != null && part.ParentGroup != null)
+                                m_Engine.World.DeleteSceneObject(part.ParentGroup, false);
+                        }
+                        else if ((e is TargetInvocationException) && (e.InnerException is ScriptDeleteException))
+                        {
+                            m_InSelfDelete = true;
+                            if (part != null && part.ParentGroup != null)
+                                part.Inventory.RemoveInventoryItem(m_ItemID);
                        }
                    }
                }
+            }
-                lock (m_EventQueue)
+            lock (m_EventQueue)
+            {
+                if ((m_EventQueue.Count > 0) && m_RunEvents && (!m_ShuttingDown))
                {
-                    if ((m_EventQueue.Count > 0) && m_RunEvents && (!m_ShuttingDown))
+                    m_CurrentResult = m_Engine.QueueEventHandler(this);
-                    {
+                }
-                        m_CurrentResult = m_Engine.QueueEventHandler(this);
+                else
-                    }
+                {
-                    else
+                    m_CurrentResult = null;
-                    {
-                        m_CurrentResult = null;
-                    }
                }
+            }
-                m_DetectParams = null;
+            m_DetectParams = null;
-                return 0;
+            return 0;
-            }
+        }
        }
        public int EventTime()
@@ -824,6 +830,7 @@ namespace OpenSim.Region.ScriptEngine.Shared.Instance
                    new Object[0], new DetectParams[0]));
        }
+        [DebuggerNonUserCode] //Stops the VS debugger from farting in this function
        public void ApiResetScript()
        {
            // bool running = Running;
diff --git a/OpenSim/Region/ScriptEngine/XEngine/XEngine.cs b/OpenSim/Region/ScriptEngine/XEngine/XEngine.cs
index a60c0ba..8b94f28 100644
--- a/OpenSim/Region/ScriptEngine/XEngine/XEngine.cs
+++ b/OpenSim/Region/ScriptEngine/XEngine/XEngine.cs
@@ -30,6 +30,7 @@ using System.IO;
 using System.Threading;
 using System.Collections;
 using System.Collections.Generic;
+using System.Diagnostics; //for [DebuggerNonUserCode]
 using System.Security;
 using System.Security.Policy;
 using System.Reflection;
@@ -1119,6 +1120,7 @@ namespace OpenSim.Region.ScriptEngine.XEngine
            return false;
        }
+        [DebuggerNonUserCode]
        public void ApiResetScript(UUID itemID)
        {
            IScriptInstance instance = GetInstance(itemID);
@@ -1170,6 +1172,7 @@ namespace OpenSim.Region.ScriptEngine.XEngine
            return UUID.Zero;
        }
+        [DebuggerNonUserCode]
        public void SetState(UUID itemID, string newState)
        {
            IScriptInstance instance = GetInstance(itemID);