diff options
Diffstat (limited to 'OpenSim/Region/ScriptEngine/XEngine/XEngine.cs')
-rw-r--r-- | OpenSim/Region/ScriptEngine/XEngine/XEngine.cs | 338 |
1 files changed, 208 insertions, 130 deletions
diff --git a/OpenSim/Region/ScriptEngine/XEngine/XEngine.cs b/OpenSim/Region/ScriptEngine/XEngine/XEngine.cs index b050349..916e27f 100644 --- a/OpenSim/Region/ScriptEngine/XEngine/XEngine.cs +++ b/OpenSim/Region/ScriptEngine/XEngine/XEngine.cs | |||
@@ -30,6 +30,7 @@ using System.IO; | |||
30 | using System.Threading; | 30 | using System.Threading; |
31 | using System.Collections; | 31 | using System.Collections; |
32 | using System.Collections.Generic; | 32 | using System.Collections.Generic; |
33 | using System.Diagnostics; //for [DebuggerNonUserCode] | ||
33 | using System.Security; | 34 | using System.Security; |
34 | using System.Security.Policy; | 35 | using System.Security.Policy; |
35 | using System.Reflection; | 36 | using System.Reflection; |
@@ -102,6 +103,8 @@ namespace OpenSim.Region.ScriptEngine.XEngine | |||
102 | private Dictionary<UUID, IScriptInstance> m_Scripts = | 103 | private Dictionary<UUID, IScriptInstance> m_Scripts = |
103 | new Dictionary<UUID, IScriptInstance>(); | 104 | new Dictionary<UUID, IScriptInstance>(); |
104 | 105 | ||
106 | private OpenMetaverse.ReaderWriterLockSlim m_scriptsLock = new OpenMetaverse.ReaderWriterLockSlim(); | ||
107 | |||
105 | // Maps the asset ID to the assembly | 108 | // Maps the asset ID to the assembly |
106 | 109 | ||
107 | private Dictionary<UUID, string> m_Assemblies = | 110 | private Dictionary<UUID, string> m_Assemblies = |
@@ -124,6 +127,71 @@ namespace OpenSim.Region.ScriptEngine.XEngine | |||
124 | IWorkItemResult m_CurrentCompile = null; | 127 | IWorkItemResult m_CurrentCompile = null; |
125 | private Dictionary<UUID, int> m_CompileDict = new Dictionary<UUID, int>(); | 128 | private Dictionary<UUID, int> m_CompileDict = new Dictionary<UUID, int>(); |
126 | 129 | ||
130 | private void lockScriptsForRead(bool locked) | ||
131 | { | ||
132 | if (locked) | ||
133 | { | ||
134 | if (m_scriptsLock.RecursiveReadCount > 0) | ||
135 | { | ||
136 | m_log.Error("[XEngine.m_Scripts] Recursive read lock requested. This should not happen and means something needs to be fixed. For now though, it's safe to continue."); | ||
137 | m_scriptsLock.ExitReadLock(); | ||
138 | } | ||
139 | if (m_scriptsLock.RecursiveWriteCount > 0) | ||
140 | { | ||
141 | m_log.Error("[XEngine.m_Scripts] Recursive write lock requested. This should not happen and means something needs to be fixed."); | ||
142 | m_scriptsLock.ExitWriteLock(); | ||
143 | } | ||
144 | |||
145 | while (!m_scriptsLock.TryEnterReadLock(60000)) | ||
146 | { | ||
147 | m_log.Error("[XEngine.m_Scripts] Thread lock detected while trying to aquire READ lock of m_scripts in XEngine. I'm going to try to solve the thread lock automatically to preserve region stability, but this needs to be fixed."); | ||
148 | if (m_scriptsLock.IsWriteLockHeld) | ||
149 | { | ||
150 | m_scriptsLock = new OpenMetaverse.ReaderWriterLockSlim(); | ||
151 | } | ||
152 | } | ||
153 | } | ||
154 | else | ||
155 | { | ||
156 | if (m_scriptsLock.RecursiveReadCount > 0) | ||
157 | { | ||
158 | m_scriptsLock.ExitReadLock(); | ||
159 | } | ||
160 | } | ||
161 | } | ||
162 | private void lockScriptsForWrite(bool locked) | ||
163 | { | ||
164 | if (locked) | ||
165 | { | ||
166 | if (m_scriptsLock.RecursiveReadCount > 0) | ||
167 | { | ||
168 | m_log.Error("[XEngine.m_Scripts] Recursive read lock requested. This should not happen and means something needs to be fixed. For now though, it's safe to continue."); | ||
169 | m_scriptsLock.ExitReadLock(); | ||
170 | } | ||
171 | if (m_scriptsLock.RecursiveWriteCount > 0) | ||
172 | { | ||
173 | m_log.Error("[XEngine.m_Scripts] Recursive write lock requested. This should not happen and means something needs to be fixed."); | ||
174 | m_scriptsLock.ExitWriteLock(); | ||
175 | } | ||
176 | |||
177 | while (!m_scriptsLock.TryEnterWriteLock(60000)) | ||
178 | { | ||
179 | m_log.Error("[XEngine.m_Scripts] Thread lock detected while trying to aquire WRITE lock of m_scripts in XEngine. I'm going to try to solve the thread lock automatically to preserve region stability, but this needs to be fixed."); | ||
180 | if (m_scriptsLock.IsWriteLockHeld) | ||
181 | { | ||
182 | m_scriptsLock = new OpenMetaverse.ReaderWriterLockSlim(); | ||
183 | } | ||
184 | } | ||
185 | } | ||
186 | else | ||
187 | { | ||
188 | if (m_scriptsLock.RecursiveWriteCount > 0) | ||
189 | { | ||
190 | m_scriptsLock.ExitWriteLock(); | ||
191 | } | ||
192 | } | ||
193 | } | ||
194 | |||
127 | public string ScriptEngineName | 195 | public string ScriptEngineName |
128 | { | 196 | { |
129 | get { return "XEngine"; } | 197 | get { return "XEngine"; } |
@@ -263,43 +331,45 @@ namespace OpenSim.Region.ScriptEngine.XEngine | |||
263 | 331 | ||
264 | public void RemoveRegion(Scene scene) | 332 | public void RemoveRegion(Scene scene) |
265 | { | 333 | { |
266 | lock (m_Scripts) | 334 | lockScriptsForRead(true); |
335 | foreach (IScriptInstance instance in m_Scripts.Values) | ||
267 | { | 336 | { |
268 | foreach (IScriptInstance instance in m_Scripts.Values) | 337 | // Force a final state save |
338 | // | ||
339 | if (m_Assemblies.ContainsKey(instance.AssetID)) | ||
269 | { | 340 | { |
270 | // Force a final state save | 341 | string assembly = m_Assemblies[instance.AssetID]; |
271 | // | 342 | instance.SaveState(assembly); |
272 | if (m_Assemblies.ContainsKey(instance.AssetID)) | 343 | } |
273 | { | ||
274 | string assembly = m_Assemblies[instance.AssetID]; | ||
275 | instance.SaveState(assembly); | ||
276 | } | ||
277 | 344 | ||
278 | // Clear the event queue and abort the instance thread | 345 | // Clear the event queue and abort the instance thread |
279 | // | 346 | // |
280 | instance.ClearQueue(); | 347 | instance.ClearQueue(); |
281 | instance.Stop(0); | 348 | instance.Stop(0); |
282 | 349 | ||
283 | // Release events, timer, etc | 350 | // Release events, timer, etc |
284 | // | 351 | // |
285 | instance.DestroyScriptInstance(); | 352 | instance.DestroyScriptInstance(); |
286 | 353 | ||
287 | // Unload scripts and app domains | 354 | // Unload scripts and app domains |
288 | // Must be done explicitly because they have infinite | 355 | // Must be done explicitly because they have infinite |
289 | // lifetime | 356 | // lifetime |
290 | // | 357 | // |
291 | m_DomainScripts[instance.AppDomain].Remove(instance.ItemID); | 358 | m_DomainScripts[instance.AppDomain].Remove(instance.ItemID); |
292 | if (m_DomainScripts[instance.AppDomain].Count == 0) | 359 | if (m_DomainScripts[instance.AppDomain].Count == 0) |
293 | { | 360 | { |
294 | m_DomainScripts.Remove(instance.AppDomain); | 361 | m_DomainScripts.Remove(instance.AppDomain); |
295 | UnloadAppDomain(instance.AppDomain); | 362 | UnloadAppDomain(instance.AppDomain); |
296 | } | ||
297 | } | 363 | } |
298 | m_Scripts.Clear(); | ||
299 | m_PrimObjects.Clear(); | ||
300 | m_Assemblies.Clear(); | ||
301 | m_DomainScripts.Clear(); | ||
302 | } | 364 | } |
365 | lockScriptsForRead(false); | ||
366 | lockScriptsForWrite(true); | ||
367 | m_Scripts.Clear(); | ||
368 | lockScriptsForWrite(false); | ||
369 | m_PrimObjects.Clear(); | ||
370 | m_Assemblies.Clear(); | ||
371 | m_DomainScripts.Clear(); | ||
372 | |||
303 | lock (m_ScriptEngines) | 373 | lock (m_ScriptEngines) |
304 | { | 374 | { |
305 | m_ScriptEngines.Remove(this); | 375 | m_ScriptEngines.Remove(this); |
@@ -358,22 +428,20 @@ namespace OpenSim.Region.ScriptEngine.XEngine | |||
358 | 428 | ||
359 | List<IScriptInstance> instances = new List<IScriptInstance>(); | 429 | List<IScriptInstance> instances = new List<IScriptInstance>(); |
360 | 430 | ||
361 | lock (m_Scripts) | 431 | lockScriptsForRead(true); |
362 | { | 432 | foreach (IScriptInstance instance in m_Scripts.Values) |
363 | foreach (IScriptInstance instance in m_Scripts.Values) | ||
364 | instances.Add(instance); | 433 | instances.Add(instance); |
365 | } | 434 | lockScriptsForRead(false); |
366 | 435 | ||
367 | foreach (IScriptInstance i in instances) | 436 | foreach (IScriptInstance i in instances) |
368 | { | 437 | { |
369 | string assembly = String.Empty; | 438 | string assembly = String.Empty; |
370 | 439 | ||
371 | lock (m_Scripts) | 440 | |
372 | { | ||
373 | if (!m_Assemblies.ContainsKey(i.AssetID)) | 441 | if (!m_Assemblies.ContainsKey(i.AssetID)) |
374 | continue; | 442 | continue; |
375 | assembly = m_Assemblies[i.AssetID]; | 443 | assembly = m_Assemblies[i.AssetID]; |
376 | } | 444 | |
377 | 445 | ||
378 | i.SaveState(assembly); | 446 | i.SaveState(assembly); |
379 | } | 447 | } |
@@ -702,92 +770,95 @@ namespace OpenSim.Region.ScriptEngine.XEngine | |||
702 | } | 770 | } |
703 | 771 | ||
704 | ScriptInstance instance = null; | 772 | ScriptInstance instance = null; |
705 | lock (m_Scripts) | 773 | // Create the object record |
774 | lockScriptsForRead(true); | ||
775 | if ((!m_Scripts.ContainsKey(itemID)) || | ||
776 | (m_Scripts[itemID].AssetID != assetID)) | ||
706 | { | 777 | { |
707 | // Create the object record | 778 | lockScriptsForRead(false); |
708 | 779 | ||
709 | if ((!m_Scripts.ContainsKey(itemID)) || | 780 | UUID appDomain = assetID; |
710 | (m_Scripts[itemID].AssetID != assetID)) | ||
711 | { | ||
712 | UUID appDomain = assetID; | ||
713 | 781 | ||
714 | if (part.ParentGroup.IsAttachment) | 782 | if (part.ParentGroup.IsAttachment) |
715 | appDomain = part.ParentGroup.RootPart.UUID; | 783 | appDomain = part.ParentGroup.RootPart.UUID; |
716 | 784 | ||
717 | if (!m_AppDomains.ContainsKey(appDomain)) | 785 | if (!m_AppDomains.ContainsKey(appDomain)) |
786 | { | ||
787 | try | ||
718 | { | 788 | { |
719 | try | 789 | AppDomainSetup appSetup = new AppDomainSetup(); |
720 | { | 790 | // appSetup.ApplicationBase = Path.Combine( |
721 | AppDomainSetup appSetup = new AppDomainSetup(); | 791 | // "ScriptEngines", |
722 | // appSetup.ApplicationBase = Path.Combine( | 792 | // m_Scene.RegionInfo.RegionID.ToString()); |
723 | // "ScriptEngines", | 793 | |
724 | // m_Scene.RegionInfo.RegionID.ToString()); | 794 | Evidence baseEvidence = AppDomain.CurrentDomain.Evidence; |
725 | 795 | Evidence evidence = new Evidence(baseEvidence); | |
726 | Evidence baseEvidence = AppDomain.CurrentDomain.Evidence; | 796 | |
727 | Evidence evidence = new Evidence(baseEvidence); | 797 | AppDomain sandbox; |
728 | 798 | if (m_AppDomainLoading) | |
729 | AppDomain sandbox; | 799 | sandbox = AppDomain.CreateDomain( |
730 | if (m_AppDomainLoading) | 800 | m_Scene.RegionInfo.RegionID.ToString(), |
731 | sandbox = AppDomain.CreateDomain( | 801 | evidence, appSetup); |
732 | m_Scene.RegionInfo.RegionID.ToString(), | 802 | else |
733 | evidence, appSetup); | 803 | sandbox = AppDomain.CurrentDomain; |
734 | else | 804 | |
735 | sandbox = AppDomain.CurrentDomain; | 805 | //PolicyLevel sandboxPolicy = PolicyLevel.CreateAppDomainLevel(); |
736 | 806 | //AllMembershipCondition sandboxMembershipCondition = new AllMembershipCondition(); | |
737 | //PolicyLevel sandboxPolicy = PolicyLevel.CreateAppDomainLevel(); | 807 | //PermissionSet sandboxPermissionSet = sandboxPolicy.GetNamedPermissionSet("Internet"); |
738 | //AllMembershipCondition sandboxMembershipCondition = new AllMembershipCondition(); | 808 | //PolicyStatement sandboxPolicyStatement = new PolicyStatement(sandboxPermissionSet); |
739 | //PermissionSet sandboxPermissionSet = sandboxPolicy.GetNamedPermissionSet("Internet"); | 809 | //CodeGroup sandboxCodeGroup = new UnionCodeGroup(sandboxMembershipCondition, sandboxPolicyStatement); |
740 | //PolicyStatement sandboxPolicyStatement = new PolicyStatement(sandboxPermissionSet); | 810 | //sandboxPolicy.RootCodeGroup = sandboxCodeGroup; |
741 | //CodeGroup sandboxCodeGroup = new UnionCodeGroup(sandboxMembershipCondition, sandboxPolicyStatement); | 811 | //sandbox.SetAppDomainPolicy(sandboxPolicy); |
742 | //sandboxPolicy.RootCodeGroup = sandboxCodeGroup; | 812 | |
743 | //sandbox.SetAppDomainPolicy(sandboxPolicy); | 813 | m_AppDomains[appDomain] = sandbox; |
744 | 814 | ||
745 | m_AppDomains[appDomain] = sandbox; | 815 | m_AppDomains[appDomain].AssemblyResolve += |
746 | 816 | new ResolveEventHandler( | |
747 | m_AppDomains[appDomain].AssemblyResolve += | 817 | AssemblyResolver.OnAssemblyResolve); |
748 | new ResolveEventHandler( | 818 | m_DomainScripts[appDomain] = new List<UUID>(); |
749 | AssemblyResolver.OnAssemblyResolve); | 819 | } |
750 | m_DomainScripts[appDomain] = new List<UUID>(); | 820 | catch (Exception e) |
751 | } | 821 | { |
752 | catch (Exception e) | 822 | m_log.ErrorFormat("[XEngine] Exception creating app domain:\n {0}", e.ToString()); |
823 | m_ScriptErrorMessage += "Exception creating app domain:\n"; | ||
824 | m_ScriptFailCount++; | ||
825 | lock (m_AddingAssemblies) | ||
753 | { | 826 | { |
754 | m_log.ErrorFormat("[XEngine] Exception creating app domain:\n {0}", e.ToString()); | 827 | m_AddingAssemblies[assembly]--; |
755 | m_ScriptErrorMessage += "Exception creating app domain:\n"; | ||
756 | m_ScriptFailCount++; | ||
757 | lock (m_AddingAssemblies) | ||
758 | { | ||
759 | m_AddingAssemblies[assembly]--; | ||
760 | } | ||
761 | return false; | ||
762 | } | 828 | } |
829 | return false; | ||
763 | } | 830 | } |
764 | m_DomainScripts[appDomain].Add(itemID); | 831 | } |
765 | 832 | m_DomainScripts[appDomain].Add(itemID); | |
766 | instance = new ScriptInstance(this, part, | 833 | |
767 | itemID, assetID, assembly, | 834 | instance = new ScriptInstance(this, part, |
768 | m_AppDomains[appDomain], | 835 | itemID, assetID, assembly, |
769 | part.ParentGroup.RootPart.Name, | 836 | m_AppDomains[appDomain], |
770 | item.Name, startParam, postOnRez, | 837 | part.ParentGroup.RootPart.Name, |
771 | stateSource, m_MaxScriptQueue); | 838 | item.Name, startParam, postOnRez, |
772 | 839 | stateSource, m_MaxScriptQueue); | |
773 | m_log.DebugFormat( | 840 | |
841 | m_log.DebugFormat( | ||
774 | "[XEngine] Loaded script {0}.{1}, script UUID {2}, prim UUID {3} @ {4}.{5}", | 842 | "[XEngine] Loaded script {0}.{1}, script UUID {2}, prim UUID {3} @ {4}.{5}", |
775 | part.ParentGroup.RootPart.Name, item.Name, assetID, part.UUID, | 843 | part.ParentGroup.RootPart.Name, item.Name, assetID, part.UUID, |
776 | part.ParentGroup.RootPart.AbsolutePosition, part.ParentGroup.Scene.RegionInfo.RegionName); | 844 | part.ParentGroup.RootPart.AbsolutePosition, part.ParentGroup.Scene.RegionInfo.RegionName); |
777 | 845 | ||
778 | if (presence != null) | 846 | if (presence != null) |
779 | { | 847 | { |
780 | ShowScriptSaveResponse(item.OwnerID, | 848 | ShowScriptSaveResponse(item.OwnerID, |
781 | assetID, "Compile successful", true); | 849 | assetID, "Compile successful", true); |
782 | } | ||
783 | |||
784 | instance.AppDomain = appDomain; | ||
785 | instance.LineMap = linemap; | ||
786 | |||
787 | m_Scripts[itemID] = instance; | ||
788 | } | 850 | } |
789 | } | ||
790 | 851 | ||
852 | instance.AppDomain = appDomain; | ||
853 | instance.LineMap = linemap; | ||
854 | lockScriptsForWrite(true); | ||
855 | m_Scripts[itemID] = instance; | ||
856 | lockScriptsForWrite(false); | ||
857 | } | ||
858 | else | ||
859 | { | ||
860 | lockScriptsForRead(false); | ||
861 | } | ||
791 | lock (m_PrimObjects) | 862 | lock (m_PrimObjects) |
792 | { | 863 | { |
793 | if (!m_PrimObjects.ContainsKey(localID)) | 864 | if (!m_PrimObjects.ContainsKey(localID)) |
@@ -806,9 +877,9 @@ namespace OpenSim.Region.ScriptEngine.XEngine | |||
806 | m_AddingAssemblies[assembly]--; | 877 | m_AddingAssemblies[assembly]--; |
807 | } | 878 | } |
808 | 879 | ||
809 | if (instance != null) | 880 | if (instance!=null) |
810 | instance.Init(); | 881 | instance.Init(); |
811 | 882 | ||
812 | return true; | 883 | return true; |
813 | } | 884 | } |
814 | 885 | ||
@@ -821,20 +892,23 @@ namespace OpenSim.Region.ScriptEngine.XEngine | |||
821 | m_CompileDict.Remove(itemID); | 892 | m_CompileDict.Remove(itemID); |
822 | } | 893 | } |
823 | 894 | ||
824 | IScriptInstance instance = null; | 895 | lockScriptsForRead(true); |
825 | 896 | // Do we even have it? | |
826 | lock (m_Scripts) | 897 | if (!m_Scripts.ContainsKey(itemID)) |
827 | { | 898 | { |
828 | // Do we even have it? | 899 | lockScriptsForRead(false); |
829 | if (!m_Scripts.ContainsKey(itemID)) | 900 | return; |
830 | return; | ||
831 | |||
832 | instance=m_Scripts[itemID]; | ||
833 | m_Scripts.Remove(itemID); | ||
834 | } | 901 | } |
902 | |||
835 | 903 | ||
904 | IScriptInstance instance=m_Scripts[itemID]; | ||
905 | lockScriptsForRead(false); | ||
906 | lockScriptsForWrite(true); | ||
907 | m_Scripts.Remove(itemID); | ||
908 | lockScriptsForWrite(false); | ||
836 | instance.ClearQueue(); | 909 | instance.ClearQueue(); |
837 | instance.Stop(0); | 910 | instance.Stop(0); |
911 | |||
838 | // bool objectRemoved = false; | 912 | // bool objectRemoved = false; |
839 | 913 | ||
840 | lock (m_PrimObjects) | 914 | lock (m_PrimObjects) |
@@ -870,11 +944,12 @@ namespace OpenSim.Region.ScriptEngine.XEngine | |||
870 | ObjectRemoved handlerObjectRemoved = OnObjectRemoved; | 944 | ObjectRemoved handlerObjectRemoved = OnObjectRemoved; |
871 | if (handlerObjectRemoved != null) | 945 | if (handlerObjectRemoved != null) |
872 | { | 946 | { |
873 | SceneObjectPart part = m_Scene.GetSceneObjectPart(localID); | 947 | SceneObjectPart part = m_Scene.GetSceneObjectPart(localID); |
874 | handlerObjectRemoved(part.UUID); | 948 | handlerObjectRemoved(part.UUID); |
875 | } | 949 | } |
876 | 950 | ||
877 | 951 | CleanAssemblies(); | |
952 | |||
878 | ScriptRemoved handlerScriptRemoved = OnScriptRemoved; | 953 | ScriptRemoved handlerScriptRemoved = OnScriptRemoved; |
879 | if (handlerScriptRemoved != null) | 954 | if (handlerScriptRemoved != null) |
880 | handlerScriptRemoved(itemID); | 955 | handlerScriptRemoved(itemID); |
@@ -1133,12 +1208,14 @@ namespace OpenSim.Region.ScriptEngine.XEngine | |||
1133 | private IScriptInstance GetInstance(UUID itemID) | 1208 | private IScriptInstance GetInstance(UUID itemID) |
1134 | { | 1209 | { |
1135 | IScriptInstance instance; | 1210 | IScriptInstance instance; |
1136 | lock (m_Scripts) | 1211 | lockScriptsForRead(true); |
1212 | if (!m_Scripts.ContainsKey(itemID)) | ||
1137 | { | 1213 | { |
1138 | if (!m_Scripts.ContainsKey(itemID)) | 1214 | lockScriptsForRead(false); |
1139 | return null; | 1215 | return null; |
1140 | instance = m_Scripts[itemID]; | ||
1141 | } | 1216 | } |
1217 | instance = m_Scripts[itemID]; | ||
1218 | lockScriptsForRead(false); | ||
1142 | return instance; | 1219 | return instance; |
1143 | } | 1220 | } |
1144 | 1221 | ||
@@ -1162,6 +1239,7 @@ namespace OpenSim.Region.ScriptEngine.XEngine | |||
1162 | return false; | 1239 | return false; |
1163 | } | 1240 | } |
1164 | 1241 | ||
1242 | [DebuggerNonUserCode] | ||
1165 | public void ApiResetScript(UUID itemID) | 1243 | public void ApiResetScript(UUID itemID) |
1166 | { | 1244 | { |
1167 | IScriptInstance instance = GetInstance(itemID); | 1245 | IScriptInstance instance = GetInstance(itemID); |
@@ -1213,6 +1291,7 @@ namespace OpenSim.Region.ScriptEngine.XEngine | |||
1213 | return UUID.Zero; | 1291 | return UUID.Zero; |
1214 | } | 1292 | } |
1215 | 1293 | ||
1294 | [DebuggerNonUserCode] | ||
1216 | public void SetState(UUID itemID, string newState) | 1295 | public void SetState(UUID itemID, string newState) |
1217 | { | 1296 | { |
1218 | IScriptInstance instance = GetInstance(itemID); | 1297 | IScriptInstance instance = GetInstance(itemID); |
@@ -1233,11 +1312,10 @@ namespace OpenSim.Region.ScriptEngine.XEngine | |||
1233 | { | 1312 | { |
1234 | List<IScriptInstance> instances = new List<IScriptInstance>(); | 1313 | List<IScriptInstance> instances = new List<IScriptInstance>(); |
1235 | 1314 | ||
1236 | lock (m_Scripts) | 1315 | lockScriptsForRead(true); |
1237 | { | 1316 | foreach (IScriptInstance instance in m_Scripts.Values) |
1238 | foreach (IScriptInstance instance in m_Scripts.Values) | ||
1239 | instances.Add(instance); | 1317 | instances.Add(instance); |
1240 | } | 1318 | lockScriptsForRead(false); |
1241 | 1319 | ||
1242 | foreach (IScriptInstance i in instances) | 1320 | foreach (IScriptInstance i in instances) |
1243 | { | 1321 | { |