1 files changed, 27 insertions, 58 deletions

diff --git a/OpenSim/Region/Framework/Scenes/SceneObjectGroup.cs b/OpenSim/Region/Framework/Scenes/SceneObjectGroup.cs
index 13d1d4e..1c6f2d1 100644
--- a/OpenSim/Region/Framework/Scenes/SceneObjectGroup.cs
+++ b/OpenSim/Region/Framework/Scenes/SceneObjectGroup.cs
@@ -418,6 +418,7 @@ namespace OpenSim.Region.Framework.Scenes
                         RootPart.ScriptSetPhysicsStatus(false);
                         Scene.SimChat(Utils.StringToBytes("Hit Sandbox Limit"),
                               ChatTypeEnum.DebugChannel, 0x7FFFFFFF, RootPart.AbsolutePosition, Name, UUID, false);
+                        lockPartsForRead(false);
                         return;
                     }
                 }
@@ -530,8 +531,8 @@ namespace OpenSim.Region.Framework.Scenes
         private List<SceneObjectPart> m_PlaySoundSlavePrims = new List<SceneObjectPart>();
         public List<SceneObjectPart> PlaySoundSlavePrims
         {
-            get { return m_LoopSoundSlavePrims; }
-            set { m_LoopSoundSlavePrims = value; }
+            get { return m_PlaySoundSlavePrims; }
+            set { m_PlaySoundSlavePrims = value; }
         }
 
         private SceneObjectPart m_LoopSoundMasterPrim = null;
@@ -686,7 +687,7 @@ namespace OpenSim.Region.Framework.Scenes
             ApplyPhysics(m_scene.m_physicalPrim);
 
             // Don't trigger the update here - otherwise some client issues occur when multiple updates are scheduled
-            // for the same object with very different properties.  The caller must schedule the update.            
+            // for the same object with very different properties.  The caller must schedule the update.
             //ScheduleGroupForFullUpdate();
         }
 
@@ -1040,6 +1041,11 @@ namespace OpenSim.Region.Framework.Scenes
 
         public void SaveScriptedState(XmlTextWriter writer)
         {
+            SaveScriptedState(writer, false);
+        }
+
+        public void SaveScriptedState(XmlTextWriter writer, bool oldIDs)
+        {
             XmlDocument doc = new XmlDocument();
             Dictionary<UUID,string> states = new Dictionary<UUID,string>();
 
@@ -1049,7 +1055,7 @@ namespace OpenSim.Region.Framework.Scenes
                 foreach (SceneObjectPart part in m_parts.Values)
                 {
                     
-                    Dictionary<UUID,string> pstates = part.Inventory.GetScriptStates();
+                    Dictionary<UUID,string> pstates = part.Inventory.GetScriptStates(oldIDs);
                     foreach (UUID itemid in pstates.Keys)
                     {
                         states.Add(itemid, pstates[itemid]);
@@ -1411,21 +1417,20 @@ namespace OpenSim.Region.Framework.Scenes
             {
 //                    part.Inventory.RemoveScriptInstances();
                 
-                ScenePresence[] avatars = Scene.GetScenePresences();
-                for (int i = 0; i < avatars.Length; i++)
+                Scene.ForEachScenePresence(delegate (ScenePresence sp)
                 {
-                    if (avatars[i].ParentID == LocalId)
+                    if (sp.ParentID == LocalId)
                     {
-                        avatars[i].StandUp();
+                        sp.StandUp();
                     }
 
                     if (!silent)
                     {
                         part.UpdateFlag = 0;
                         if (part == m_rootPart)
-                            avatars[i].ControllingClient.SendKillObject(m_regionHandle, part.LocalId);
+                            sp.ControllingClient.SendKillObject(m_regionHandle, part.LocalId);
                     }
-                }
+                });
                 
             }
             
@@ -1647,11 +1652,10 @@ namespace OpenSim.Region.Framework.Scenes
 
         #endregion
 
-        #region Client Updating
-
         public void SendFullUpdateToClient(IClientAPI remoteClient)
         {
-            SendPartFullUpdate(remoteClient, RootPart, m_scene.Permissions.GenerateClientFlags(remoteClient.AgentId, RootPart.UUID));
+            RootPart.SendFullUpdate(
+                remoteClient, m_scene.Permissions.GenerateClientFlags(remoteClient.AgentId, RootPart.UUID));
 
             lockPartsForRead(true);
             {
@@ -1659,42 +1663,12 @@ namespace OpenSim.Region.Framework.Scenes
                 {
                     
                     if (part != RootPart)
-                        SendPartFullUpdate(remoteClient, part, m_scene.Permissions.GenerateClientFlags(remoteClient.AgentId, part.UUID));
-                    
+                        part.SendFullUpdate(
+                            remoteClient, m_scene.Permissions.GenerateClientFlags(remoteClient.AgentId, part.UUID));
                 }
             }
-            lockPartsForRead(false);
         }
 
-        /// <summary>
-        /// Send a full update to the client for the given part
-        /// </summary>
-        /// <param name="remoteClient"></param>
-        /// <param name="part"></param>
-        internal void SendPartFullUpdate(IClientAPI remoteClient, SceneObjectPart part, uint clientFlags)
-        {
-//            m_log.DebugFormat(
-//                "[SOG]: Sendinging part full update to {0} for {1} {2}", remoteClient.Name, part.Name, part.LocalId);
-            
-            if (m_rootPart.UUID == part.UUID)
-            {
-                if (IsAttachment)
-                {
-                    part.SendFullUpdateToClient(remoteClient, m_rootPart.AttachedPos, clientFlags);
-                }
-                else
-                {
-                    part.SendFullUpdateToClient(remoteClient, AbsolutePosition, clientFlags);
-                }
-            }
-            else
-            {
-                part.SendFullUpdateToClient(remoteClient, clientFlags);
-            }
-        }
-
-        #endregion
-
         #region Copying
 
         /// <summary>
@@ -2206,14 +2180,12 @@ namespace OpenSim.Region.Framework.Scenes
         public void ScheduleTerseUpdateToAvatar(ScenePresence presence)
         {
             lockPartsForRead(true);
+
+            foreach (SceneObjectPart part in m_parts.Values)
             {
-                foreach (SceneObjectPart part in m_parts.Values)
-                {
-                    
-                    part.AddTerseUpdateToAvatar(presence);
-                    
-                }
+                part.AddTerseUpdateToAvatar(presence);
             }
+
             lockPartsForRead(false);
         }
 
@@ -2246,14 +2218,11 @@ namespace OpenSim.Region.Framework.Scenes
         public void ScheduleGroupForTerseUpdate()
         {
             lockPartsForRead(true);
+            foreach (SceneObjectPart part in m_parts.Values)
             {
-                foreach (SceneObjectPart part in m_parts.Values)
-                {
-                    
-                    part.ScheduleTerseUpdate();
-                    
-                }
+                part.ScheduleTerseUpdate();
             }
+
             lockPartsForRead(false);
         }
 
@@ -3107,8 +3076,8 @@ namespace OpenSim.Region.Framework.Scenes
                     {
                         if (obPart.UUID != m_rootPart.UUID)
                         {
-                            obPart.IgnoreUndoUpdate = true;
                             Vector3 oldSize = new Vector3(obPart.Scale);
+                            obPart.IgnoreUndoUpdate = true;
 
                             float f = 1.0f;
                             float a = 1.0f;