1 files changed, 20 insertions, 22 deletions

diff --git a/OpenSim/Region/Framework/Scenes/Scene.Inventory.cs b/OpenSim/Region/Framework/Scenes/Scene.Inventory.cs
index 3044017..62a831e 100644
--- a/OpenSim/Region/Framework/Scenes/Scene.Inventory.cs
+++ b/OpenSim/Region/Framework/Scenes/Scene.Inventory.cs
@@ -35,7 +35,7 @@ using OpenMetaverse;
 using OpenMetaverse.Packets;
 using log4net;
 using OpenSim.Framework;
-using OpenSim.Framework.Communications.Cache;
+
 using OpenSim.Region.Framework;
 using OpenSim.Region.Framework.Interfaces;
 using OpenSim.Region.Framework.Scenes.Serialization;
@@ -101,12 +101,6 @@ namespace OpenSim.Region.Framework.Scenes
                 {
                     userlevel = 1;
                 }
-                // TODO: remove this cruft once MasterAvatar is fully deprecated
-                //
-                if (m_regInfo.MasterAvatarAssignedUUID == AgentID)
-                {
-                    userlevel = 2;
-                }
                 EventManager.TriggerOnNewInventoryItemUploadComplete(AgentID, item.AssetID, item.Name, userlevel);
             }
             else
@@ -573,7 +567,9 @@ namespace OpenSim.Region.Framework.Scenes
                 "[AGENT INVENTORY]: CopyInventoryItem received by {0} with oldAgentID {1}, oldItemID {2}, new FolderID {3}, newName {4}",
                 remoteClient.AgentId, oldAgentID, oldItemID, newFolderID, newName);
 
-            InventoryItemBase item = CommsManager.UserProfileCacheService.LibraryRoot.FindItem(oldItemID);
+            InventoryItemBase item = null;
+            if (LibraryService != null && LibraryService.LibraryRootFolder != null)
+                item = LibraryService.LibraryRootFolder.FindItem(oldItemID);
 
             if (item == null)
             {
@@ -742,13 +738,9 @@ namespace OpenSim.Region.Framework.Scenes
 
             if (transactionID == UUID.Zero)
             {
-                CachedUserInfo userInfo
-                    = CommsManager.UserProfileCacheService.GetUserDetails(remoteClient.AgentId);
-
-                if (userInfo != null)
+                ScenePresence presence;
+                if (TryGetAvatar(remoteClient.AgentId, out presence))
                 {
-                    ScenePresence presence;
-                    TryGetAvatar(remoteClient.AgentId, out presence);
                     byte[] data = null;
 
                     if (invType == (sbyte)InventoryType.Landmark && presence != null)
@@ -770,7 +762,7 @@ namespace OpenSim.Region.Framework.Scenes
                 else
                 {
                     m_log.ErrorFormat(
-                        "userInfo for agent uuid {0} unexpectedly null in CreateNewInventoryItem",
+                        "ScenePresence for agent uuid {0} unexpectedly not found in CreateNewInventoryItem",
                         remoteClient.AgentId);
                 }
             }
@@ -1161,15 +1153,21 @@ namespace OpenSim.Region.Framework.Scenes
 
         private void SendInventoryUpdate(IClientAPI client, InventoryFolderBase folder, bool fetchFolders, bool fetchItems)
         {
+            if (folder == null)
+                return;
+
             m_log.DebugFormat("[AGENT INVENTORY]: Send Inventory Folder {0} Update to {1} {2}", folder.Name, client.FirstName, client.LastName);
             InventoryCollection contents = InventoryService.GetFolderContent(client.AgentId, folder.ID);
             InventoryFolderBase containingFolder = new InventoryFolderBase();
             containingFolder.ID = folder.ID;
             containingFolder.Owner = client.AgentId;
             containingFolder = InventoryService.GetFolder(containingFolder);
-            int version = containingFolder.Version;
+            if (containingFolder != null)
+            {
+                int version = containingFolder.Version;
 
-            client.SendInventoryFolderDetails(client.AgentId, folder.ID, contents.Items, contents.Folders, version, fetchFolders, fetchItems);
+                client.SendInventoryFolderDetails(client.AgentId, folder.ID, contents.Items, contents.Folders, version, fetchFolders, fetchItems);
+            }
         }
 
         /// <summary>
@@ -1211,9 +1209,9 @@ namespace OpenSim.Region.Framework.Scenes
                         item = InventoryService.GetItem(item);
 
                         // Try library
-                        if (null == item)
+                        if (null == item && LibraryService != null && LibraryService.LibraryRootFolder != null)
                         {
-                            item = CommsManager.UserProfileCacheService.LibraryRoot.FindItem(itemID);
+                            item = LibraryService.LibraryRootFolder.FindItem(itemID);
                         }
 
                         if (item != null)
@@ -1280,9 +1278,9 @@ namespace OpenSim.Region.Framework.Scenes
 
                 // Try library
                 // XXX clumsy, possibly should be one call
-                if (null == item)
+                if (null == item && LibraryService != null && LibraryService.LibraryRootFolder != null)
                 {
-                    item = CommsManager.UserProfileCacheService.LibraryRoot.FindItem(itemID);
+                    item = LibraryService.LibraryRootFolder.FindItem(itemID);
                 }
 
                 if (item != null)
@@ -2405,7 +2403,7 @@ namespace OpenSim.Region.Framework.Scenes
                 // XXYY!!
                 InventoryItemBase item = new InventoryItemBase(itemID, remoteClient.AgentId);
                 item = InventoryService.GetItem(item);
-                presence.Appearance.SetAttachment((int)AttachmentPt, itemID, item.AssetID /*att.UUID*/);
+                presence.Appearance.SetAttachment((int)AttachmentPt, itemID, item.AssetID /* att.UUID */);
 
                 if (m_AvatarFactory != null)
                 {