1 files changed, 87 insertions, 347 deletions

diff --git a/OpenSim/Region/CoreModules/World/Archiver/ArchiveReadRequest.cs b/OpenSim/Region/CoreModules/World/Archiver/ArchiveReadRequest.cs
index ade5e76..619550c 100644
--- a/OpenSim/Region/CoreModules/World/Archiver/ArchiveReadRequest.cs
+++ b/OpenSim/Region/CoreModules/World/Archiver/ArchiveReadRequest.cs
@@ -43,7 +43,6 @@ using OpenSim.Region.Framework.Interfaces;
 using OpenSim.Region.Framework.Scenes;
 using OpenSim.Region.Framework.Scenes.Serialization;
 using OpenSim.Services.Interfaces;
-using System.Threading;
 
 namespace OpenSim.Region.CoreModules.World.Archiver
 {
@@ -53,30 +52,7 @@ namespace OpenSim.Region.CoreModules.World.Archiver
     public class ArchiveReadRequest
     {
         private static readonly ILog m_log = LogManager.GetLogger(MethodBase.GetCurrentMethod().DeclaringType);
-
-        /// <summary>
-        /// Contains data used while dearchiving a single scene.
-        /// </summary>
-        private class DearchiveContext
-        {
-            public Scene Scene { get; set; }
-
-            public List<string> SerialisedSceneObjects { get; set; }
-
-            public List<string> SerialisedParcels { get; set; }
-
-            public List<SceneObjectGroup> SceneObjects { get; set; }
-
-            public DearchiveContext(Scene scene)
-            {
-                Scene = scene;
-                SerialisedSceneObjects = new List<string>();
-                SerialisedParcels = new List<string>();
-                SceneObjects = new List<SceneObjectGroup>();
-            }
-        }
         
-
         /// <summary>
         /// The maximum major version of OAR that we can read.  Minor versions shouldn't need a max number since version
         /// bumps here should be compatible.
@@ -86,10 +62,9 @@ namespace OpenSim.Region.CoreModules.World.Archiver
         /// <summary>
         /// Has the control file been loaded for this archive?
         /// </summary>
-        public bool ControlFileLoaded { get; private set; }
+        public bool ControlFileLoaded { get; private set; }        
 
-        protected string m_loadPath;
-        protected Scene m_rootScene;
+        protected Scene m_scene;
         protected Stream m_loadStream;
         protected Guid m_requestId;
         protected string m_errorMessage;
@@ -116,27 +91,16 @@ namespace OpenSim.Region.CoreModules.World.Archiver
             {
                 if (m_UserMan == null)
                 {
-                    m_UserMan = m_rootScene.RequestModuleInterface<IUserManagement>();
+                    m_UserMan = m_scene.RequestModuleInterface<IUserManagement>();
                 }
                 return m_UserMan;
             }
         }
 
-        /// <summary>
-        /// Used to cache lookups for valid groups.
-        /// </summary>
-        private IDictionary<UUID, bool> m_validGroupUuids = new Dictionary<UUID, bool>();
-
-        private IGroupsModule m_groupsModule;
-
-        private IAssetService m_assetService = null;
-
-
         public ArchiveReadRequest(Scene scene, string loadPath, bool merge, bool skipAssets, Guid requestId)
         {
-            m_rootScene = scene;
+            m_scene = scene;
 
-            m_loadPath = loadPath;
             try
             {
                 m_loadStream = new GZipStream(ArchiveHelpers.GetStream(loadPath), CompressionMode.Decompress);
@@ -156,15 +120,11 @@ namespace OpenSim.Region.CoreModules.World.Archiver
 
             // Zero can never be a valid user id
             m_validUserUuids[UUID.Zero] = false;
-
-            m_groupsModule = m_rootScene.RequestModuleInterface<IGroupsModule>();
-            m_assetService = m_rootScene.AssetService;
         }
 
         public ArchiveReadRequest(Scene scene, Stream loadStream, bool merge, bool skipAssets, Guid requestId)
         {
-            m_rootScene = scene;
-            m_loadPath = null;
+            m_scene = scene;
             m_loadStream = loadStream;
             m_merge = merge;
             m_skipAssets = skipAssets;
@@ -172,9 +132,6 @@ namespace OpenSim.Region.CoreModules.World.Archiver
 
             // Zero can never be a valid user id
             m_validUserUuids[UUID.Zero] = false;
-
-            m_groupsModule = m_rootScene.RequestModuleInterface<IGroupsModule>();
-            m_assetService = m_rootScene.AssetService;
         }
 
         /// <summary>
@@ -182,25 +139,25 @@ namespace OpenSim.Region.CoreModules.World.Archiver
         /// </summary>
         public void DearchiveRegion()
         {
+            // The same code can handle dearchiving 0.1 and 0.2 OpenSim Archive versions
+            DearchiveRegion0DotStar();
+        }
+
+        private void DearchiveRegion0DotStar()
+        {
             int successfulAssetRestores = 0;
             int failedAssetRestores = 0;
+            List<string> serialisedSceneObjects = new List<string>();
+            List<string> serialisedParcels = new List<string>();
+            string filePath = "NONE";
 
-            DearchiveScenesInfo dearchivedScenes;
-
-            // We dearchive all the scenes at once, because the files in the TAR archive might be mixed.
-            // Therefore, we have to keep track of the dearchive context of all the scenes.
-            Dictionary<UUID, DearchiveContext> sceneContexts = new Dictionary<UUID, DearchiveContext>();
-
-            string fullPath = "NONE";
-            TarArchiveReader archive = null;
+            TarArchiveReader archive = new TarArchiveReader(m_loadStream);
             byte[] data;
             TarArchiveReader.TarEntryType entryType;
-
+            
             try
             {
-                FindAndLoadControlFile(out archive, out dearchivedScenes);
-
-                while ((data = archive.ReadEntry(out fullPath, out entryType)) != null)
+                while ((data = archive.ReadEntry(out filePath, out entryType)) != null)
                 {
                     //m_log.DebugFormat(
                     //    "[ARCHIVER]: Successfully read {0} ({1} bytes)", filePath, data.Length);
@@ -208,30 +165,9 @@ namespace OpenSim.Region.CoreModules.World.Archiver
                     if (TarArchiveReader.TarEntryType.TYPE_DIRECTORY == entryType)
                         continue;
 
-
-                    // Find the scene that this file belongs to
-
-                    Scene scene;
-                    string filePath;
-                    if (!dearchivedScenes.GetRegionFromPath(fullPath, out scene, out filePath))
-                        continue;   // this file belongs to a region that we're not loading
-
-                    DearchiveContext sceneContext = null;
-                    if (scene != null)
-                    {
-                        if (!sceneContexts.TryGetValue(scene.RegionInfo.RegionID, out sceneContext))
-                        {
-                            sceneContext = new DearchiveContext(scene);
-                            sceneContexts.Add(scene.RegionInfo.RegionID, sceneContext);
-                        }
-                    }
-
-
-                    // Process the file
-
                     if (filePath.StartsWith(ArchiveConstants.OBJECTS_PATH))
                     {
-                        sceneContext.SerialisedSceneObjects.Add(Encoding.UTF8.GetString(data));
+                        serialisedSceneObjects.Add(Encoding.UTF8.GetString(data));
                     }
                     else if (filePath.StartsWith(ArchiveConstants.ASSETS_PATH) && !m_skipAssets)
                     {
@@ -245,19 +181,19 @@ namespace OpenSim.Region.CoreModules.World.Archiver
                     }
                     else if (!m_merge && filePath.StartsWith(ArchiveConstants.TERRAINS_PATH))
                     {
-                        LoadTerrain(scene, filePath, data);
+                        LoadTerrain(filePath, data);
                     }
                     else if (!m_merge && filePath.StartsWith(ArchiveConstants.SETTINGS_PATH))
                     {
-                        LoadRegionSettings(scene, filePath, data, dearchivedScenes);
+                        LoadRegionSettings(filePath, data);
                     } 
                     else if (!m_merge && filePath.StartsWith(ArchiveConstants.LANDDATA_PATH))
                     {
-                        sceneContext.SerialisedParcels.Add(Encoding.UTF8.GetString(data));
+                        serialisedParcels.Add(Encoding.UTF8.GetString(data));
                     } 
                     else if (filePath == ArchiveConstants.CONTROL_FILE_PATH)
                     {
-                        // Ignore, because we already read the control file
+                        LoadControlFile(filePath, data);
                     }
                 }
 
@@ -265,16 +201,15 @@ namespace OpenSim.Region.CoreModules.World.Archiver
             }
             catch (Exception e)
             {
-                m_log.Error(
-                    String.Format("[ARCHIVER]: Aborting load with error in archive file {0} ", fullPath), e);
+                m_log.ErrorFormat(
+                    "[ARCHIVER]: Aborting load with error in archive file {0}.  {1}", filePath, e);
                 m_errorMessage += e.ToString();
-                m_rootScene.EventManager.TriggerOarFileLoaded(m_requestId, new List<UUID>(), m_errorMessage);
+                m_scene.EventManager.TriggerOarFileLoaded(m_requestId, m_errorMessage);
                 return;
             }
             finally
             {
-                if (archive != null)
-                    archive.Close();
+                archive.Close();
             }
 
             if (!m_skipAssets)
@@ -288,143 +223,32 @@ namespace OpenSim.Region.CoreModules.World.Archiver
                 }
             }
 
-            foreach (DearchiveContext sceneContext in sceneContexts.Values)
+            if (!m_merge)
             {
-                m_log.InfoFormat("[ARCHIVER]: Loading region {0}", sceneContext.Scene.RegionInfo.RegionName);
-
-                if (!m_merge)
-                {
-                    m_log.Info("[ARCHIVER]: Clearing all existing scene objects");
-                    sceneContext.Scene.DeleteAllSceneObjects();
-                }
-
-                try
-                {
-                    LoadParcels(sceneContext.Scene, sceneContext.SerialisedParcels);
-                    LoadObjects(sceneContext.Scene, sceneContext.SerialisedSceneObjects, sceneContext.SceneObjects);
-                    
-                    // Inform any interested parties that the region has changed. We waited until now so that all
-                    // of the region's objects will be loaded when we send this notification.
-                    IEstateModule estateModule = sceneContext.Scene.RequestModuleInterface<IEstateModule>();
-                    if (estateModule != null)
-                        estateModule.TriggerRegionInfoChange();
-                }
-                catch (Exception e)
-                {
-                    m_log.Error("[ARCHIVER]: Error loading parcels or objects ", e);
-                    m_errorMessage += e.ToString();
-                    m_rootScene.EventManager.TriggerOarFileLoaded(m_requestId, new List<UUID>(), m_errorMessage);
-                    return;
-                }
+                m_log.Info("[ARCHIVER]: Clearing all existing scene objects");
+                m_scene.DeleteAllSceneObjects();
             }
 
-            // Start the scripts. We delayed this because we want the OAR to finish loading ASAP, so
-            // that users can enter the scene. If we allow the scripts to start in the loop above
-            // then they significantly increase the time until the OAR finishes loading.
-            Util.FireAndForget(delegate(object o)
-            {
-                Thread.Sleep(15000);
-                m_log.Info("[ARCHIVER]: Starting scripts in scene objects");
-
-                foreach (DearchiveContext sceneContext in sceneContexts.Values)
-                {
-                    foreach (SceneObjectGroup sceneObject in sceneContext.SceneObjects)
-                    {
-                        sceneObject.CreateScriptInstances(0, false, sceneContext.Scene.DefaultScriptEngine, 0); // StateSource.RegionStart
-                        sceneObject.ResumeScripts();
-                    }
-
-                    sceneContext.SceneObjects.Clear();
-                }
-            });
+            LoadParcels(serialisedParcels);
+            LoadObjects(serialisedSceneObjects);
 
             m_log.InfoFormat("[ARCHIVER]: Successfully loaded archive");
 
-            m_rootScene.EventManager.TriggerOarFileLoaded(m_requestId, dearchivedScenes.GetLoadedScenes(), m_errorMessage);
-        }
-
-        /// <summary>
-        /// Searches through the files in the archive for the control file, and reads it.
-        /// We must read the control file first, in order to know which regions are available.
-        /// </summary>
-        /// <remarks>
-        /// In most cases the control file *is* first, since that's how we create archives. However,
-        /// it's possible that someone rewrote the archive externally so we can't rely on this fact.
-        /// </remarks>
-        /// <param name="archive"></param>
-        /// <param name="dearchivedScenes"></param>
-        private void FindAndLoadControlFile(out TarArchiveReader archive, out DearchiveScenesInfo dearchivedScenes)
-        {
-            archive = new TarArchiveReader(m_loadStream);
-            dearchivedScenes = new DearchiveScenesInfo();
-
-            string filePath;
-            byte[] data;
-            TarArchiveReader.TarEntryType entryType;
-            bool firstFile = true;
-
-            while ((data = archive.ReadEntry(out filePath, out entryType)) != null)
-            {
-                if (TarArchiveReader.TarEntryType.TYPE_DIRECTORY == entryType)
-                    continue;
-                    
-                if (filePath == ArchiveConstants.CONTROL_FILE_PATH)
-                {
-                    LoadControlFile(filePath, data, dearchivedScenes);
-
-                    // Find which scenes are available in the simulator
-                    ArchiveScenesGroup simulatorScenes = new ArchiveScenesGroup();
-                    SceneManager.Instance.ForEachScene(delegate(Scene scene2)
-                    {
-                        simulatorScenes.AddScene(scene2);
-                    });
-                    simulatorScenes.CalcSceneLocations();
-                    dearchivedScenes.SetSimulatorScenes(m_rootScene, simulatorScenes);
-
-                    // If the control file wasn't the first file then reset the read pointer
-                    if (!firstFile)
-                    {
-                        m_log.Warn("Control file wasn't the first file in the archive");
-                        if (m_loadStream.CanSeek)
-                        {
-                            m_loadStream.Seek(0, SeekOrigin.Begin);
-                        }
-                        else if (m_loadPath != null)
-                        {
-                            archive.Close();
-                            archive = null;
-                            m_loadStream.Close();
-                            m_loadStream = null;
-                            m_loadStream = new GZipStream(ArchiveHelpers.GetStream(m_loadPath), CompressionMode.Decompress);
-                            archive = new TarArchiveReader(m_loadStream);
-                        }
-                        else
-                        {
-                            // There isn't currently a scenario where this happens, but it's best to add a check just in case
-                            throw new Exception("Error reading archive: control file wasn't the first file, and the input stream doesn't allow seeking");
-                        }
-                    }
-
-                    return;
-                }
-
-                firstFile = false;
-            }
-
-            throw new Exception("Control file not found");
+            m_scene.EventManager.TriggerOarFileLoaded(m_requestId, m_errorMessage);
         }
         
         /// <summary>
         /// Load serialized scene objects.
         /// </summary>
-        protected void LoadObjects(Scene scene, List<string> serialisedSceneObjects, List<SceneObjectGroup> sceneObjects)
+        /// <param name="serialisedSceneObjects"></param>
+        protected void LoadObjects(List<string> serialisedSceneObjects)
         {
             // Reload serialized prims
             m_log.InfoFormat("[ARCHIVER]: Loading {0} scene objects.  Please wait.", serialisedSceneObjects.Count);
 
-            UUID oldTelehubUUID = scene.RegionInfo.RegionSettings.TelehubObject;
+            UUID oldTelehubUUID = m_scene.RegionInfo.RegionSettings.TelehubObject;
 
-            IRegionSerialiserModule serialiser = scene.RequestModuleInterface<IRegionSerialiserModule>();
+            IRegionSerialiserModule serialiser = m_scene.RequestModuleInterface<IRegionSerialiserModule>();
             int sceneObjectsLoadedCount = 0;
 
             foreach (string serialisedSceneObject in serialisedSceneObjects)
@@ -445,7 +269,7 @@ namespace OpenSim.Region.CoreModules.World.Archiver
 
                 SceneObjectGroup sceneObject = serialiser.DeserializeGroupFromXml2(serialisedSceneObject);
 
-                bool isTelehub = (sceneObject.UUID == oldTelehubUUID) && (oldTelehubUUID != UUID.Zero);
+                bool isTelehub = (sceneObject.UUID == oldTelehubUUID);
 
                 // For now, give all incoming scene objects new uuids.  This will allow scenes to be cloned
                 // on the same region server and multiple examples a single object archive to be imported
@@ -455,8 +279,8 @@ namespace OpenSim.Region.CoreModules.World.Archiver
                 if (isTelehub)
                 {
                     // Change the Telehub Object to the new UUID
-                    scene.RegionInfo.RegionSettings.TelehubObject = sceneObject.UUID;
-                    scene.RegionInfo.RegionSettings.Save();
+                    m_scene.RegionInfo.RegionSettings.TelehubObject = sceneObject.UUID;
+                    m_scene.RegionInfo.RegionSettings.Save();
                     oldTelehubUUID = UUID.Zero;
                 }
 
@@ -466,20 +290,17 @@ namespace OpenSim.Region.CoreModules.World.Archiver
                 {
                     if (part.CreatorData == null || part.CreatorData == string.Empty)
                     {
-                        if (!ResolveUserUuid(scene, part.CreatorID))
-                            part.CreatorID = scene.RegionInfo.EstateSettings.EstateOwner;
+                        if (!ResolveUserUuid(part.CreatorID))
+                            part.CreatorID = m_scene.RegionInfo.EstateSettings.EstateOwner;
                     }
                     if (UserManager != null)
                         UserManager.AddUser(part.CreatorID, part.CreatorData);
 
-                    if (!ResolveUserUuid(scene, part.OwnerID))
-                        part.OwnerID = scene.RegionInfo.EstateSettings.EstateOwner;
-
-                    if (!ResolveUserUuid(scene, part.LastOwnerID))
-                        part.LastOwnerID = scene.RegionInfo.EstateSettings.EstateOwner;
+                    if (!ResolveUserUuid(part.OwnerID))
+                        part.OwnerID = m_scene.RegionInfo.EstateSettings.EstateOwner;
 
-                    if (!ResolveGroupUuid(part.GroupID))
-                        part.GroupID = UUID.Zero;
+                    if (!ResolveUserUuid(part.LastOwnerID))
+                        part.LastOwnerID = m_scene.RegionInfo.EstateSettings.EstateOwner;
 
                     // And zap any troublesome sit target information
 //                    part.SitTargetOrientation = new Quaternion(0, 0, 0, 1);
@@ -490,14 +311,14 @@ namespace OpenSim.Region.CoreModules.World.Archiver
                     // being no copy/no mod for everyone
                     lock (part.TaskInventory)
                     {
-                        if (!ResolveUserUuid(scene, part.CreatorID))
-                            part.CreatorID = scene.RegionInfo.EstateSettings.EstateOwner;
+                        if (!ResolveUserUuid(part.CreatorID))
+                            part.CreatorID = m_scene.RegionInfo.EstateSettings.EstateOwner;
     
-                        if (!ResolveUserUuid(scene, part.OwnerID))
-                            part.OwnerID = scene.RegionInfo.EstateSettings.EstateOwner;
+                        if (!ResolveUserUuid(part.OwnerID))
+                            part.OwnerID = m_scene.RegionInfo.EstateSettings.EstateOwner;
     
-                        if (!ResolveUserUuid(scene, part.LastOwnerID))
-                            part.LastOwnerID = scene.RegionInfo.EstateSettings.EstateOwner;
+                        if (!ResolveUserUuid(part.LastOwnerID))
+                            part.LastOwnerID = m_scene.RegionInfo.EstateSettings.EstateOwner;
     
                         // And zap any troublesome sit target information
                         part.SitTargetOrientation = new Quaternion(0, 0, 0, 1);
@@ -510,31 +331,26 @@ namespace OpenSim.Region.CoreModules.World.Archiver
                         TaskInventoryDictionary inv = part.TaskInventory;
                         foreach (KeyValuePair<UUID, TaskInventoryItem> kvp in inv)
                         {
-                            if (!ResolveUserUuid(scene, kvp.Value.OwnerID))
+                            if (!ResolveUserUuid(kvp.Value.OwnerID))
                             {
-                                kvp.Value.OwnerID = scene.RegionInfo.EstateSettings.EstateOwner;
+                                kvp.Value.OwnerID = m_scene.RegionInfo.EstateSettings.EstateOwner;
                             }
-
                             if (kvp.Value.CreatorData == null || kvp.Value.CreatorData == string.Empty)
                             {
-                                if (!ResolveUserUuid(scene, kvp.Value.CreatorID))
-                                    kvp.Value.CreatorID = scene.RegionInfo.EstateSettings.EstateOwner;
+                                if (!ResolveUserUuid(kvp.Value.CreatorID))
+                                    kvp.Value.CreatorID = m_scene.RegionInfo.EstateSettings.EstateOwner;
                             }
-
                             if (UserManager != null)
                                 UserManager.AddUser(kvp.Value.CreatorID, kvp.Value.CreatorData);
-
-                            if (!ResolveGroupUuid(kvp.Value.GroupID))
-                                kvp.Value.GroupID = UUID.Zero;
                         }
                         part.TaskInventory.LockItemsForRead(false);
                     }
                 }
 
-                if (scene.AddRestoredSceneObject(sceneObject, true, false))
+                if (m_scene.AddRestoredSceneObject(sceneObject, true, false))
                 {
                     sceneObjectsLoadedCount++;
-                    sceneObject.CreateScriptInstances(0, false, scene.DefaultScriptEngine, 0);
+                    sceneObject.CreateScriptInstances(0, false, m_scene.DefaultScriptEngine, 0);
                     sceneObject.ResumeScripts();
                 }
             }
@@ -549,17 +365,16 @@ namespace OpenSim.Region.CoreModules.World.Archiver
             if (oldTelehubUUID != UUID.Zero)
             {
                 m_log.WarnFormat("Telehub object not found: {0}", oldTelehubUUID);
-                scene.RegionInfo.RegionSettings.TelehubObject = UUID.Zero;
-                scene.RegionInfo.RegionSettings.ClearSpawnPoints();
+                m_scene.RegionInfo.RegionSettings.TelehubObject = UUID.Zero;
+                m_scene.RegionInfo.RegionSettings.ClearSpawnPoints();
             }
         }
         
         /// <summary>
         /// Load serialized parcels.
         /// </summary>
-        /// <param name="scene"></param>
         /// <param name="serialisedParcels"></param>
-        protected void LoadParcels(Scene scene, List<string> serialisedParcels)
+        protected void LoadParcels(List<string> serialisedParcels)
         {
             // Reload serialized parcels
             m_log.InfoFormat("[ARCHIVER]: Loading {0} parcels.  Please wait.", serialisedParcels.Count);
@@ -567,27 +382,9 @@ namespace OpenSim.Region.CoreModules.World.Archiver
             foreach (string serialisedParcel in serialisedParcels)
             {
                 LandData parcel = LandDataSerializer.Deserialize(serialisedParcel);
+                if (!ResolveUserUuid(parcel.OwnerID))
+                    parcel.OwnerID = m_scene.RegionInfo.EstateSettings.EstateOwner;
                 
-                // Validate User and Group UUID's
-
-                if (!ResolveUserUuid(scene, parcel.OwnerID))
-                    parcel.OwnerID = m_rootScene.RegionInfo.EstateSettings.EstateOwner;
-
-                if (!ResolveGroupUuid(parcel.GroupID))
-                {
-                    parcel.GroupID = UUID.Zero;
-                    parcel.IsGroupOwned = false;
-                }
-
-                List<LandAccessEntry> accessList = new List<LandAccessEntry>();
-                foreach (LandAccessEntry entry in parcel.ParcelAccessList)
-                {
-                    if (ResolveUserUuid(scene, entry.AgentID))
-                        accessList.Add(entry);
-                    // else, drop this access rule
-                }
-                parcel.ParcelAccessList = accessList;
-
 //                m_log.DebugFormat(
 //                    "[ARCHIVER]: Adding parcel {0}, local id {1}, area {2}", 
 //                    parcel.Name, parcel.LocalID, parcel.Area);
@@ -598,24 +395,23 @@ namespace OpenSim.Region.CoreModules.World.Archiver
             if (!m_merge)
             {
                 bool setupDefaultParcel = (landData.Count == 0);
-                scene.LandChannel.Clear(setupDefaultParcel);
+                m_scene.LandChannel.Clear(setupDefaultParcel);
             }
             
-            scene.EventManager.TriggerIncomingLandDataFromStorage(landData);
+            m_scene.EventManager.TriggerIncomingLandDataFromStorage(landData);
             m_log.InfoFormat("[ARCHIVER]: Restored {0} parcels.", landData.Count);
         }
 
         /// <summary>
         /// Look up the given user id to check whether it's one that is valid for this grid.
         /// </summary>
-        /// <param name="scene"></param>
         /// <param name="uuid"></param>
         /// <returns></returns>
-        private bool ResolveUserUuid(Scene scene, UUID uuid)
+        private bool ResolveUserUuid(UUID uuid)
         {
             if (!m_validUserUuids.ContainsKey(uuid))
             {
-                UserAccount account = scene.UserAccountService.GetUserAccount(scene.RegionInfo.ScopeID, uuid);
+                UserAccount account = m_scene.UserAccountService.GetUserAccount(m_scene.RegionInfo.ScopeID, uuid);
                 m_validUserUuids.Add(uuid, account != null);
             }
 
@@ -623,30 +419,6 @@ namespace OpenSim.Region.CoreModules.World.Archiver
         }
 
         /// <summary>
-        /// Look up the given group id to check whether it's one that is valid for this grid.
-        /// </summary>
-        /// <param name="uuid"></param>
-        /// <returns></returns>
-        private bool ResolveGroupUuid(UUID uuid)
-        {
-            if (uuid == UUID.Zero)
-                return true;    // this means the object has no group
-
-            if (!m_validGroupUuids.ContainsKey(uuid))
-            {
-                bool exists;
-                
-                if (m_groupsModule == null)
-                    exists = false;
-                else
-                    exists = (m_groupsModule.GetGroupRecord(uuid) != null);
-
-                m_validGroupUuids.Add(uuid, exists);
-            }
-
-            return m_validGroupUuids[uuid];
-        }
-
         /// Load an asset
         /// </summary>
         /// <param name="assetFilename"></param>
@@ -670,7 +442,7 @@ namespace OpenSim.Region.CoreModules.World.Archiver
             string extension = filename.Substring(i);
             string uuid = filename.Remove(filename.Length - extension.Length);
 
-            if (m_assetService.GetMetadata(uuid) != null)
+            if (m_scene.AssetService.GetMetadata(uuid) != null)
             {
                 // m_log.DebugFormat("[ARCHIVER]: found existing asset {0}",uuid);
                 return true;
@@ -690,7 +462,7 @@ namespace OpenSim.Region.CoreModules.World.Archiver
 
                 // We're relying on the asset service to do the sensible thing and not store the asset if it already
                 // exists.
-                m_assetService.Store(asset);
+                m_scene.AssetService.Store(asset);
 
                 /**
                  * Create layers on decode for image assets.  This is likely to significantly increase the time to load archives so
@@ -718,14 +490,12 @@ namespace OpenSim.Region.CoreModules.World.Archiver
         /// <summary>
         /// Load region settings data
         /// </summary>
-        /// <param name="scene"></param>
         /// <param name="settingsPath"></param>
         /// <param name="data"></param>
-        /// <param name="dearchivedScenes"></param>
         /// <returns>
         /// true if settings were loaded successfully, false otherwise
         /// </returns>
-        private bool LoadRegionSettings(Scene scene, string settingsPath, byte[] data, DearchiveScenesInfo dearchivedScenes)
+        private bool LoadRegionSettings(string settingsPath, byte[] data)
         {
             RegionSettings loadedRegionSettings;
 
@@ -741,7 +511,7 @@ namespace OpenSim.Region.CoreModules.World.Archiver
                 return false;
             }
 
-            RegionSettings currentRegionSettings = scene.RegionInfo.RegionSettings;
+            RegionSettings currentRegionSettings = m_scene.RegionInfo.RegionSettings;
 
             currentRegionSettings.AgentLimit = loadedRegionSettings.AgentLimit;
             currentRegionSettings.AllowDamage = loadedRegionSettings.AllowDamage;
@@ -778,14 +548,12 @@ namespace OpenSim.Region.CoreModules.World.Archiver
             foreach (SpawnPoint sp in loadedRegionSettings.SpawnPoints())
                 currentRegionSettings.AddSpawnPoint(sp);
 
-            currentRegionSettings.LoadedCreationDateTime = dearchivedScenes.LoadedCreationDateTime;
-            currentRegionSettings.LoadedCreationID = dearchivedScenes.GetOriginalRegionID(scene.RegionInfo.RegionID).ToString();
-
             currentRegionSettings.Save();
 
-            scene.TriggerEstateSunUpdate();
+            m_scene.TriggerEstateSunUpdate();
             
-            IEstateModule estateModule = scene.RequestModuleInterface<IEstateModule>();
+            IEstateModule estateModule = m_scene.RequestModuleInterface<IEstateModule>();
+
             if (estateModule != null)
                 estateModule.sendRegionHandshakeToAll();
 
@@ -795,15 +563,14 @@ namespace OpenSim.Region.CoreModules.World.Archiver
         /// <summary>
         /// Load terrain data
         /// </summary>
-        /// <param name="scene"></param>
         /// <param name="terrainPath"></param>
         /// <param name="data"></param>
         /// <returns>
         /// true if terrain was resolved successfully, false otherwise.
         /// </returns>
-        private bool LoadTerrain(Scene scene, string terrainPath, byte[] data)
+        private bool LoadTerrain(string terrainPath, byte[] data)
         {
-            ITerrainModule terrainModule = scene.RequestModuleInterface<ITerrainModule>();
+            ITerrainModule terrainModule = m_scene.RequestModuleInterface<ITerrainModule>();
 
             MemoryStream ms = new MemoryStream(data);
             terrainModule.LoadFromStream(terrainPath, ms);
@@ -819,18 +586,17 @@ namespace OpenSim.Region.CoreModules.World.Archiver
         /// </summary>
         /// <param name="path"></param>
         /// <param name="data"></param>
-        /// <param name="dearchivedScenes"></param>
-        public DearchiveScenesInfo LoadControlFile(string path, byte[] data, DearchiveScenesInfo dearchivedScenes)
+        public void LoadControlFile(string path, byte[] data)
         {
             XmlNamespaceManager nsmgr = new XmlNamespaceManager(new NameTable());
             XmlParserContext context = new XmlParserContext(null, nsmgr, null, XmlSpace.None);
             XmlTextReader xtr = new XmlTextReader(Encoding.ASCII.GetString(data), XmlNodeType.Document, context);
 
-            // Loaded metadata will be empty if no information exists in the archive
-            dearchivedScenes.LoadedCreationDateTime = 0;
-            dearchivedScenes.DefaultOriginalID = "";
+            RegionSettings currentRegionSettings = m_scene.RegionInfo.RegionSettings;
 
-            bool multiRegion = false;
+            // Loaded metadata will empty if no information exists in the archive
+            currentRegionSettings.LoadedCreationDateTime = 0;
+            currentRegionSettings.LoadedCreationID = "";
 
             while (xtr.Read()) 
             {
@@ -856,44 +622,18 @@ namespace OpenSim.Region.CoreModules.World.Archiver
                     {
                         int value;
                         if (Int32.TryParse(xtr.ReadElementContentAsString(), out value))
-                            dearchivedScenes.LoadedCreationDateTime = value;
+                            currentRegionSettings.LoadedCreationDateTime = value;
                     } 
-                    else if (xtr.Name.ToString() == "row")
-                    {
-                        multiRegion = true;
-                        dearchivedScenes.StartRow();
-                    }
-                    else if (xtr.Name.ToString() == "region")
-                    {
-                        dearchivedScenes.StartRegion();
-                    }
-                    else if (xtr.Name.ToString() == "id")
-                    {
-                        string id = xtr.ReadElementContentAsString();
-                        dearchivedScenes.DefaultOriginalID = id;
-                        if (multiRegion)
-                            dearchivedScenes.SetRegionOriginalID(id);
-                    }
-                    else if (xtr.Name.ToString() == "dir")
+                    else if (xtr.Name.ToString() == "id") 
                     {
-                        dearchivedScenes.SetRegionDirectory(xtr.ReadElementContentAsString());
+                        currentRegionSettings.LoadedCreationID = xtr.ReadElementContentAsString();
                     }
                 }
             }
-
-            dearchivedScenes.MultiRegionFormat = multiRegion;
-            if (!multiRegion)
-            {
-                // Add the single scene
-                dearchivedScenes.StartRow();
-                dearchivedScenes.StartRegion();
-                dearchivedScenes.SetRegionOriginalID(dearchivedScenes.DefaultOriginalID);
-                dearchivedScenes.SetRegionDirectory("");
-            }
-
+            
+            currentRegionSettings.Save();
+            
             ControlFileLoaded = true;
-
-            return dearchivedScenes;
         }
     }
-}
+}
\ No newline at end of file