To keep things consistent allowing an UnregisterModuleInterface... Force the GodModule to request the dialog module interface on a kickuser call and not to use the 'in memory cached one'. Thanks Ar3s for locating the offending inconsistency.

1 files changed, 13 insertions, 5 deletions

diff --git a/OpenSim/Region/CoreModules/Avatar/Gods/GodsModule.cs b/OpenSim/Region/CoreModules/Avatar/Gods/GodsModule.cs
index 2e3312f..81ce268 100644
--- a/OpenSim/Region/CoreModules/Avatar/Gods/GodsModule.cs
+++ b/OpenSim/Region/CoreModules/Avatar/Gods/GodsModule.cs
@@ -121,6 +121,7 @@ namespace OpenSim.Region.CoreModules.Avatar.Gods
 
             if (sp != null || agentID == kickUserID)
             {
+                m_dialogModule = m_scene.RequestModuleInterface<IDialogModule>();
                 if (m_scene.Permissions.IsGod(godID))
                 {
                     if (kickflags == 0)
@@ -162,20 +163,27 @@ namespace OpenSim.Region.CoreModules.Avatar.Gods
                     if (kickflags == 1)
                     {
                         sp.AllowMovement = false;
-                        m_dialogModule.SendAlertToUser(agentID, Utils.BytesToString(reason));
-                        m_dialogModule.SendAlertToUser(godID, "User Frozen");
+                        if (m_dialogModule != null)
+                        {
+                            m_dialogModule.SendAlertToUser(agentID, Utils.BytesToString(reason));
+                            m_dialogModule.SendAlertToUser(godID, "User Frozen");
+                        }
                     }
                     
                     if (kickflags == 2)
                     {
                         sp.AllowMovement = true;
-                        m_dialogModule.SendAlertToUser(agentID, Utils.BytesToString(reason));
-                        m_dialogModule.SendAlertToUser(godID, "User Unfrozen");
+                        if (m_dialogModule != null)
+                        {
+                            m_dialogModule.SendAlertToUser(agentID, Utils.BytesToString(reason));
+                            m_dialogModule.SendAlertToUser(godID, "User Unfrozen");
+                        }
                     }
                 }
                 else
                 {
-                    m_dialogModule.SendAlertToUser(godID, "Kick request denied");
+                    if (m_dialogModule != null)
+                        m_dialogModule.SendAlertToUser(godID, "Kick request denied");
                 }
             }
         }