Make SP.Attachments available as sp.GetAttachments() instead.

The approach here, as in other parts of OpenSim, is to return a copy of the list rather than the attachments list itself
This prevents callers from forgetting to lock the list when they read it, as was happening in various parts of the codebase.
It also improves liveness.
This might improve attachment anomolies when performing region crossings.

1 files changed, 5 insertions, 2 deletions

diff --git a/OpenSim/Region/Framework/Interfaces/IScenePresence.cs b/OpenSim/Region/Framework/Interfaces/IScenePresence.cs
index b07c821..788b36f 100644
--- a/OpenSim/Region/Framework/Interfaces/IScenePresence.cs
+++ b/OpenSim/Region/Framework/Interfaces/IScenePresence.cs
@@ -58,10 +58,13 @@ namespace OpenSim.Region.Framework.Interfaces
         /// <summary>
         /// The scene objects attached to this avatar.
         /// </summary>
+        /// <returns>
+        /// A copy of the list.
+        /// </returns>
         /// <remarks>
         ///  Do not change this list directly - use methods such as
-        /// AddAttachment() and RemoveAttachment().  Lock this list when performing any read operations upon it.
+        /// AddAttachment() and RemoveAttachment().
         /// </remarks>
-        List<SceneObjectGroup> Attachments { get; }
+        List<SceneObjectGroup> GetAttachments();
     }
 }
\ No newline at end of file