diff options
author | Adam Frisby | 2008-05-01 16:35:00 +0000 |
---|---|---|
committer | Adam Frisby | 2008-05-01 16:35:00 +0000 |
commit | 13526097f24b7a8ad63b1d482c44b44397fa055f (patch) | |
tree | 7a82c20ed7c63e2aea5ad3863325e37f64e1cbea /OpenSim/Region/Environment/Modules/World | |
parent | * Breaking all the code, breaking all the code..! (diff) | |
download | opensim-SC_OLD-13526097f24b7a8ad63b1d482c44b44397fa055f.zip opensim-SC_OLD-13526097f24b7a8ad63b1d482c44b44397fa055f.tar.gz opensim-SC_OLD-13526097f24b7a8ad63b1d482c44b44397fa055f.tar.bz2 opensim-SC_OLD-13526097f24b7a8ad63b1d482c44b44397fa055f.tar.xz |
* Spring cleaning on Region.Environment.
* Converted a large number of read-only fields to be actually, readonly.
* Reformatted code sections.
* Removed redundant code.
Diffstat (limited to 'OpenSim/Region/Environment/Modules/World')
14 files changed, 55 insertions, 56 deletions
diff --git a/OpenSim/Region/Environment/Modules/World/Land/LandChannel.cs b/OpenSim/Region/Environment/Modules/World/Land/LandChannel.cs index 9ac3cc3..20d02c4 100644 --- a/OpenSim/Region/Environment/Modules/World/Land/LandChannel.cs +++ b/OpenSim/Region/Environment/Modules/World/Land/LandChannel.cs | |||
@@ -44,8 +44,8 @@ namespace OpenSim.Region.Environment.Modules.World.Land | |||
44 | //Land types set with flags in ParcelOverlay. | 44 | //Land types set with flags in ParcelOverlay. |
45 | //Only one of these can be used. | 45 | //Only one of these can be used. |
46 | public const float BAN_LINE_SAFETY_HIEGHT = 100; | 46 | public const float BAN_LINE_SAFETY_HIEGHT = 100; |
47 | public const byte LAND_FLAG_PROPERTY_BORDER_SOUTH = (byte) 128; //Equals 10000000 | 47 | public const byte LAND_FLAG_PROPERTY_BORDER_SOUTH = 128; //Equals 10000000 |
48 | public const byte LAND_FLAG_PROPERTY_BORDER_WEST = (byte) 64; //Equals 01000000 | 48 | public const byte LAND_FLAG_PROPERTY_BORDER_WEST = 64; //Equals 01000000 |
49 | 49 | ||
50 | //RequestResults (I think these are right, they seem to work): | 50 | //RequestResults (I think these are right, they seem to work): |
51 | public const int LAND_RESULT_MULTIPLE = 1; // The request they made contained more than a single peice of land | 51 | public const int LAND_RESULT_MULTIPLE = 1; // The request they made contained more than a single peice of land |
@@ -55,26 +55,26 @@ namespace OpenSim.Region.Environment.Modules.World.Land | |||
55 | public const int LAND_SELECT_OBJECTS_GROUP = 4; | 55 | public const int LAND_SELECT_OBJECTS_GROUP = 4; |
56 | public const int LAND_SELECT_OBJECTS_OTHER = 8; | 56 | public const int LAND_SELECT_OBJECTS_OTHER = 8; |
57 | public const int LAND_SELECT_OBJECTS_OWNER = 2; | 57 | public const int LAND_SELECT_OBJECTS_OWNER = 2; |
58 | public const byte LAND_TYPE_IS_BEING_AUCTIONED = (byte) 5; //Equals 00000101 | 58 | public const byte LAND_TYPE_IS_BEING_AUCTIONED = 5; //Equals 00000101 |
59 | public const byte LAND_TYPE_IS_FOR_SALE = (byte) 4; //Equals 00000100 | 59 | public const byte LAND_TYPE_IS_FOR_SALE = 4; //Equals 00000100 |
60 | public const byte LAND_TYPE_OWNED_BY_GROUP = (byte) 2; //Equals 00000010 | 60 | public const byte LAND_TYPE_OWNED_BY_GROUP = 2; //Equals 00000010 |
61 | public const byte LAND_TYPE_OWNED_BY_OTHER = (byte) 1; //Equals 00000001 | 61 | public const byte LAND_TYPE_OWNED_BY_OTHER = 1; //Equals 00000001 |
62 | public const byte LAND_TYPE_OWNED_BY_REQUESTER = (byte) 3; //Equals 00000011 | 62 | public const byte LAND_TYPE_OWNED_BY_REQUESTER = 3; //Equals 00000011 |
63 | public const byte LAND_TYPE_PUBLIC = (byte) 0; //Equals 00000000 | 63 | public const byte LAND_TYPE_PUBLIC = 0; //Equals 00000000 |
64 | 64 | ||
65 | //These are other constants. Yay! | 65 | //These are other constants. Yay! |
66 | public const int START_LAND_LOCAL_ID = 1; | 66 | public const int START_LAND_LOCAL_ID = 1; |
67 | 67 | ||
68 | #endregion | 68 | #endregion |
69 | 69 | ||
70 | private int[,] landIDList = new int[64,64]; | 70 | private readonly int[,] landIDList = new int[64,64]; |
71 | private Dictionary<int, ILandObject> landList = new Dictionary<int, ILandObject>(); | 71 | private readonly Dictionary<int, ILandObject> landList = new Dictionary<int, ILandObject>(); |
72 | private readonly Scene m_scene; | ||
72 | 73 | ||
73 | private bool landPrimCountTainted = false; | 74 | private bool landPrimCountTainted; |
74 | private int lastLandLocalID = START_LAND_LOCAL_ID - 1; | 75 | private int lastLandLocalID = START_LAND_LOCAL_ID - 1; |
75 | 76 | ||
76 | private bool m_allowedForcefulBans = true; | 77 | private bool m_allowedForcefulBans = true; |
77 | private Scene m_scene; | ||
78 | 78 | ||
79 | public LandChannel(Scene scene) | 79 | public LandChannel(Scene scene) |
80 | { | 80 | { |
@@ -192,7 +192,7 @@ namespace OpenSim.Region.Environment.Modules.World.Land | |||
192 | { | 192 | { |
193 | lastLandLocalID++; | 193 | lastLandLocalID++; |
194 | new_land.landData.localID = lastLandLocalID; | 194 | new_land.landData.localID = lastLandLocalID; |
195 | landList.Add(lastLandLocalID, (LandObject) new_land.Copy()); | 195 | landList.Add(lastLandLocalID, new_land.Copy()); |
196 | 196 | ||
197 | 197 | ||
198 | bool[,] landBitmap = new_land.getLandBitmap(); | 198 | bool[,] landBitmap = new_land.getLandBitmap(); |
@@ -532,7 +532,7 @@ namespace OpenSim.Region.Environment.Modules.World.Land | |||
532 | { | 532 | { |
533 | for (x = 0; x < 64; x++) | 533 | for (x = 0; x < 64; x++) |
534 | { | 534 | { |
535 | byte tempByte = (byte) 0; //This represents the byte for the current 4x4 | 535 | byte tempByte = 0; //This represents the byte for the current 4x4 |
536 | ILandObject currentParcelBlock = null; | 536 | ILandObject currentParcelBlock = null; |
537 | 537 | ||
538 | try | 538 | try |
@@ -611,7 +611,7 @@ namespace OpenSim.Region.Environment.Modules.World.Land | |||
611 | packet = (ParcelOverlayPacket) PacketPool.Instance.GetPacket(PacketType.ParcelOverlay); | 611 | packet = (ParcelOverlayPacket) PacketPool.Instance.GetPacket(PacketType.ParcelOverlay); |
612 | packet.ParcelData.Data = byteArray; | 612 | packet.ParcelData.Data = byteArray; |
613 | packet.ParcelData.SequenceID = sequenceID; | 613 | packet.ParcelData.SequenceID = sequenceID; |
614 | remote_client.OutPacket((Packet) packet, ThrottleOutPacketType.Task); | 614 | remote_client.OutPacket(packet, ThrottleOutPacketType.Task); |
615 | sequenceID++; | 615 | sequenceID++; |
616 | byteArray = new byte[LAND_BLOCKS_PER_PACKET]; | 616 | byteArray = new byte[LAND_BLOCKS_PER_PACKET]; |
617 | } | 617 | } |
diff --git a/OpenSim/Region/Environment/Modules/World/Land/LandManagementModule.cs b/OpenSim/Region/Environment/Modules/World/Land/LandManagementModule.cs index 877bed5..e6e1ae4 100644 --- a/OpenSim/Region/Environment/Modules/World/Land/LandManagementModule.cs +++ b/OpenSim/Region/Environment/Modules/World/Land/LandManagementModule.cs | |||
@@ -45,14 +45,14 @@ namespace OpenSim.Region.Environment.Modules.World.Land | |||
45 | 45 | ||
46 | m_scene.EventManager.OnParcelPrimCountAdd += landChannel.addPrimToLandPrimCounts; | 46 | m_scene.EventManager.OnParcelPrimCountAdd += landChannel.addPrimToLandPrimCounts; |
47 | m_scene.EventManager.OnParcelPrimCountUpdate += landChannel.updateLandPrimCounts; | 47 | m_scene.EventManager.OnParcelPrimCountUpdate += landChannel.updateLandPrimCounts; |
48 | m_scene.EventManager.OnAvatarEnteringNewParcel += new EventManager.AvatarEnteringNewParcel(landChannel.handleAvatarChangingParcel); | 48 | m_scene.EventManager.OnAvatarEnteringNewParcel += landChannel.handleAvatarChangingParcel; |
49 | m_scene.EventManager.OnClientMovement += new EventManager.ClientMovement(landChannel.handleAnyClientMovement); | 49 | m_scene.EventManager.OnClientMovement += landChannel.handleAnyClientMovement; |
50 | m_scene.EventManager.OnValidateLandBuy += landChannel.handleLandValidationRequest; | 50 | m_scene.EventManager.OnValidateLandBuy += landChannel.handleLandValidationRequest; |
51 | m_scene.EventManager.OnLandBuy += landChannel.handleLandBuyRequest; | 51 | m_scene.EventManager.OnLandBuy += landChannel.handleLandBuyRequest; |
52 | 52 | ||
53 | lock (m_scene) | 53 | lock (m_scene) |
54 | { | 54 | { |
55 | m_scene.LandChannel = (ILandChannel) landChannel; | 55 | m_scene.LandChannel = landChannel; |
56 | } | 56 | } |
57 | } | 57 | } |
58 | 58 | ||
diff --git a/OpenSim/Region/Environment/Modules/World/Land/LandObject.cs b/OpenSim/Region/Environment/Modules/World/Land/LandObject.cs index e297b10..54fe9ae 100644 --- a/OpenSim/Region/Environment/Modules/World/Land/LandObject.cs +++ b/OpenSim/Region/Environment/Modules/World/Land/LandObject.cs | |||
@@ -73,6 +73,8 @@ namespace OpenSim.Region.Environment.Modules.World.Land | |||
73 | get { return m_scene.RegionInfo.RegionID; } | 73 | get { return m_scene.RegionInfo.RegionID; } |
74 | } | 74 | } |
75 | 75 | ||
76 | #endregion | ||
77 | |||
76 | #region Constructors | 78 | #region Constructors |
77 | 79 | ||
78 | public LandObject(LLUUID owner_id, bool is_group_owned, Scene scene) | 80 | public LandObject(LLUUID owner_id, bool is_group_owned, Scene scene) |
@@ -98,7 +100,7 @@ namespace OpenSim.Region.Environment.Modules.World.Land | |||
98 | { | 100 | { |
99 | if (x >= 0 && y >= 0 && x <= Constants.RegionSize && x <= Constants.RegionSize) | 101 | if (x >= 0 && y >= 0 && x <= Constants.RegionSize && x <= Constants.RegionSize) |
100 | { | 102 | { |
101 | return (landBitmap[x / 4, y / 4] == true); | 103 | return landBitmap[x / 4, y / 4]; |
102 | } | 104 | } |
103 | else | 105 | else |
104 | { | 106 | { |
@@ -148,7 +150,7 @@ namespace OpenSim.Region.Environment.Modules.World.Land | |||
148 | updatePacket.ParcelData.GroupID = landData.groupID; | 150 | updatePacket.ParcelData.GroupID = landData.groupID; |
149 | updatePacket.ParcelData.GroupPrims = landData.groupPrims; | 151 | updatePacket.ParcelData.GroupPrims = landData.groupPrims; |
150 | updatePacket.ParcelData.IsGroupOwned = landData.isGroupOwned; | 152 | updatePacket.ParcelData.IsGroupOwned = landData.isGroupOwned; |
151 | updatePacket.ParcelData.LandingType = (byte) landData.landingType; | 153 | updatePacket.ParcelData.LandingType = landData.landingType; |
152 | updatePacket.ParcelData.LocalID = landData.localID; | 154 | updatePacket.ParcelData.LocalID = landData.localID; |
153 | if (landData.area > 0) | 155 | if (landData.area > 0) |
154 | { | 156 | { |
@@ -212,7 +214,7 @@ namespace OpenSim.Region.Environment.Modules.World.Land | |||
212 | landData.selectedPrims; | 214 | landData.selectedPrims; |
213 | updatePacket.ParcelData.UserLocation = landData.userLocation; | 215 | updatePacket.ParcelData.UserLocation = landData.userLocation; |
214 | updatePacket.ParcelData.UserLookAt = landData.userLookAt; | 216 | updatePacket.ParcelData.UserLookAt = landData.userLookAt; |
215 | remote_client.OutPacket((Packet) updatePacket, ThrottleOutPacketType.Task); | 217 | remote_client.OutPacket(updatePacket, ThrottleOutPacketType.Task); |
216 | } | 218 | } |
217 | 219 | ||
218 | public void updateLandProperties(ParcelPropertiesUpdatePacket packet, IClientAPI remote_client) | 220 | public void updateLandProperties(ParcelPropertiesUpdatePacket packet, IClientAPI remote_client) |
@@ -355,7 +357,7 @@ namespace OpenSim.Region.Environment.Modules.World.Land | |||
355 | { | 357 | { |
356 | ParcelAccessListReplyPacket.ListBlock listBlock = new ParcelAccessListReplyPacket.ListBlock(); | 358 | ParcelAccessListReplyPacket.ListBlock listBlock = new ParcelAccessListReplyPacket.ListBlock(); |
357 | 359 | ||
358 | listBlock.Flags = (uint) 0; | 360 | listBlock.Flags = 0; |
359 | listBlock.ID = entry.AgentID; | 361 | listBlock.ID = entry.AgentID; |
360 | listBlock.Time = 0; | 362 | listBlock.Time = 0; |
361 | 363 | ||
@@ -367,7 +369,7 @@ namespace OpenSim.Region.Environment.Modules.World.Land | |||
367 | { | 369 | { |
368 | ParcelAccessListReplyPacket.ListBlock listBlock = new ParcelAccessListReplyPacket.ListBlock(); | 370 | ParcelAccessListReplyPacket.ListBlock listBlock = new ParcelAccessListReplyPacket.ListBlock(); |
369 | 371 | ||
370 | listBlock.Flags = (uint) 0; | 372 | listBlock.Flags = 0; |
371 | listBlock.ID = LLUUID.Zero; | 373 | listBlock.ID = LLUUID.Zero; |
372 | listBlock.Time = 0; | 374 | listBlock.Time = 0; |
373 | 375 | ||
@@ -390,7 +392,7 @@ namespace OpenSim.Region.Environment.Modules.World.Land | |||
390 | replyPacket.Data.SequenceID = 0; | 392 | replyPacket.Data.SequenceID = 0; |
391 | 393 | ||
392 | replyPacket.List = createAccessListArrayByFlag(ParcelManager.AccessList.Access); | 394 | replyPacket.List = createAccessListArrayByFlag(ParcelManager.AccessList.Access); |
393 | remote_client.OutPacket((Packet) replyPacket, ThrottleOutPacketType.Task); | 395 | remote_client.OutPacket(replyPacket, ThrottleOutPacketType.Task); |
394 | } | 396 | } |
395 | 397 | ||
396 | if (flags == (uint) ParcelManager.AccessList.Ban || flags == (uint) ParcelManager.AccessList.Both) | 398 | if (flags == (uint) ParcelManager.AccessList.Ban || flags == (uint) ParcelManager.AccessList.Both) |
@@ -402,7 +404,7 @@ namespace OpenSim.Region.Environment.Modules.World.Land | |||
402 | replyPacket.Data.SequenceID = 0; | 404 | replyPacket.Data.SequenceID = 0; |
403 | 405 | ||
404 | replyPacket.List = createAccessListArrayByFlag(ParcelManager.AccessList.Ban); | 406 | replyPacket.List = createAccessListArrayByFlag(ParcelManager.AccessList.Ban); |
405 | remote_client.OutPacket((Packet) replyPacket, ThrottleOutPacketType.Task); | 407 | remote_client.OutPacket(replyPacket, ThrottleOutPacketType.Task); |
406 | } | 408 | } |
407 | } | 409 | } |
408 | 410 | ||
@@ -482,7 +484,7 @@ namespace OpenSim.Region.Environment.Modules.World.Land | |||
482 | { | 484 | { |
483 | for (y = 0; y < 64; y++) | 485 | for (y = 0; y < 64; y++) |
484 | { | 486 | { |
485 | if (landBitmap[x, y] == true) | 487 | if (landBitmap[x, y]) |
486 | { | 488 | { |
487 | if (min_x > x) min_x = x; | 489 | if (min_x > x) min_x = x; |
488 | if (min_y > y) min_y = y; | 490 | if (min_y > y) min_y = y; |
@@ -499,7 +501,7 @@ namespace OpenSim.Region.Environment.Modules.World.Land | |||
499 | if (ty > 255) | 501 | if (ty > 255) |
500 | ty = 255; | 502 | ty = 255; |
501 | landData.AABBMin = | 503 | landData.AABBMin = |
502 | new LLVector3((float) (min_x * 4), (float) (min_y * 4), | 504 | new LLVector3((min_x * 4), (min_y * 4), |
503 | (float) m_scene.Heightmap[tx, ty]); | 505 | (float) m_scene.Heightmap[tx, ty]); |
504 | 506 | ||
505 | tx = max_x * 4; | 507 | tx = max_x * 4; |
@@ -509,7 +511,7 @@ namespace OpenSim.Region.Environment.Modules.World.Land | |||
509 | if (ty > 255) | 511 | if (ty > 255) |
510 | ty = 255; | 512 | ty = 255; |
511 | landData.AABBMax = | 513 | landData.AABBMax = |
512 | new LLVector3((float) (max_x * 4), (float) (max_y * 4), | 514 | new LLVector3((max_x * 4), (max_y * 4), |
513 | (float) m_scene.Heightmap[tx, ty]); | 515 | (float) m_scene.Heightmap[tx, ty]); |
514 | landData.area = tempArea; | 516 | landData.area = tempArea; |
515 | } | 517 | } |
@@ -657,7 +659,7 @@ namespace OpenSim.Region.Environment.Modules.World.Land | |||
657 | if (i % 8 == 0) | 659 | if (i % 8 == 0) |
658 | { | 660 | { |
659 | tempConvertArr[byteNum] = tempByte; | 661 | tempConvertArr[byteNum] = tempByte; |
660 | tempByte = (byte) 0; | 662 | tempByte = 0; |
661 | i = 0; | 663 | i = 0; |
662 | byteNum++; | 664 | byteNum++; |
663 | } | 665 | } |
@@ -677,7 +679,7 @@ namespace OpenSim.Region.Environment.Modules.World.Land | |||
677 | tempByte = landData.landBitmapByteArray[i]; | 679 | tempByte = landData.landBitmapByteArray[i]; |
678 | for (bitNum = 0; bitNum < 8; bitNum++) | 680 | for (bitNum = 0; bitNum < 8; bitNum++) |
679 | { | 681 | { |
680 | bool bit = Convert.ToBoolean(Convert.ToByte(tempByte >> bitNum) & (byte) 1); | 682 | bool bit = Convert.ToBoolean(Convert.ToByte(tempByte >> bitNum) & 1); |
681 | tempConvertMap[x, y] = bit; | 683 | tempConvertMap[x, y] = bit; |
682 | x++; | 684 | x++; |
683 | if (x > 63) | 685 | if (x > 63) |
@@ -751,7 +753,7 @@ namespace OpenSim.Region.Environment.Modules.World.Land | |||
751 | resultLocalIDs.RemoveAt(0); | 753 | resultLocalIDs.RemoveAt(0); |
752 | } | 754 | } |
753 | pack.Data = data; | 755 | pack.Data = data; |
754 | remote_client.OutPacket((Packet) pack, ThrottleOutPacketType.Task); | 756 | remote_client.OutPacket(pack, ThrottleOutPacketType.Task); |
755 | } | 757 | } |
756 | } | 758 | } |
757 | 759 | ||
@@ -922,7 +924,5 @@ namespace OpenSim.Region.Environment.Modules.World.Land | |||
922 | #endregion | 924 | #endregion |
923 | 925 | ||
924 | #endregion | 926 | #endregion |
925 | |||
926 | #endregion | ||
927 | } | 927 | } |
928 | } \ No newline at end of file | 928 | } \ No newline at end of file |
diff --git a/OpenSim/Region/Environment/Modules/World/Serialiser/SerialiserModule.cs b/OpenSim/Region/Environment/Modules/World/Serialiser/SerialiserModule.cs index 4406e17..854d2ee 100644 --- a/OpenSim/Region/Environment/Modules/World/Serialiser/SerialiserModule.cs +++ b/OpenSim/Region/Environment/Modules/World/Serialiser/SerialiserModule.cs | |||
@@ -37,10 +37,10 @@ namespace OpenSim.Region.Environment.Modules.World.Serialiser | |||
37 | { | 37 | { |
38 | public class SerialiserModule : IRegionModule, IRegionSerialiser | 38 | public class SerialiserModule : IRegionModule, IRegionSerialiser |
39 | { | 39 | { |
40 | private Commander m_commander = new Commander("Export"); | 40 | private readonly Commander m_commander = new Commander("Export"); |
41 | private List<Scene> m_regions = new List<Scene>(); | 41 | private readonly List<Scene> m_regions = new List<Scene>(); |
42 | private readonly List<IFileSerialiser> m_serialisers = new List<IFileSerialiser>(); | ||
42 | private string m_savedir = "exports" + "/"; | 43 | private string m_savedir = "exports" + "/"; |
43 | private List<IFileSerialiser> m_serialisers = new List<IFileSerialiser>(); | ||
44 | 44 | ||
45 | #region IRegionModule Members | 45 | #region IRegionModule Members |
46 | 46 | ||
@@ -105,8 +105,8 @@ namespace OpenSim.Region.Environment.Modules.World.Serialiser | |||
105 | 105 | ||
106 | TextWriter regionInfoWriter = new StreamWriter(saveDir + "README.TXT"); | 106 | TextWriter regionInfoWriter = new StreamWriter(saveDir + "README.TXT"); |
107 | regionInfoWriter.WriteLine("Region Name: " + scene.RegionInfo.RegionName); | 107 | regionInfoWriter.WriteLine("Region Name: " + scene.RegionInfo.RegionName); |
108 | regionInfoWriter.WriteLine("Region ID: " + scene.RegionInfo.RegionID.ToString()); | 108 | regionInfoWriter.WriteLine("Region ID: " + scene.RegionInfo.RegionID); |
109 | regionInfoWriter.WriteLine("Backup Time: UTC " + DateTime.UtcNow.ToString()); | 109 | regionInfoWriter.WriteLine("Backup Time: UTC " + DateTime.UtcNow); |
110 | regionInfoWriter.WriteLine("Serialise Version: 0.1"); | 110 | regionInfoWriter.WriteLine("Serialise Version: 0.1"); |
111 | regionInfoWriter.Close(); | 111 | regionInfoWriter.Close(); |
112 | 112 | ||
@@ -141,7 +141,7 @@ namespace OpenSim.Region.Environment.Modules.World.Serialiser | |||
141 | { | 141 | { |
142 | if (region.RegionInfo.RegionName == (string) args[0]) | 142 | if (region.RegionInfo.RegionName == (string) args[0]) |
143 | { | 143 | { |
144 | List<string> results = SerialiseRegion(region, m_savedir + region.RegionInfo.RegionID.ToString() + "/"); | 144 | List<string> results = SerialiseRegion(region, m_savedir + region.RegionInfo.RegionID + "/"); |
145 | } | 145 | } |
146 | } | 146 | } |
147 | } | 147 | } |
@@ -150,7 +150,7 @@ namespace OpenSim.Region.Environment.Modules.World.Serialiser | |||
150 | { | 150 | { |
151 | foreach (Scene region in m_regions) | 151 | foreach (Scene region in m_regions) |
152 | { | 152 | { |
153 | List<string> results = SerialiseRegion(region, m_savedir + region.RegionInfo.RegionID.ToString() + "/"); | 153 | List<string> results = SerialiseRegion(region, m_savedir + region.RegionInfo.RegionID + "/"); |
154 | } | 154 | } |
155 | } | 155 | } |
156 | 156 | ||
diff --git a/OpenSim/Region/Environment/Modules/World/Sun/SunModule.cs b/OpenSim/Region/Environment/Modules/World/Sun/SunModule.cs index 47ce258..05fae22 100644 --- a/OpenSim/Region/Environment/Modules/World/Sun/SunModule.cs +++ b/OpenSim/Region/Environment/Modules/World/Sun/SunModule.cs | |||
@@ -127,7 +127,7 @@ namespace OpenSim.Region.Environment.Modules.World.Sun | |||
127 | { | 127 | { |
128 | long m_addticks = (DateTime.Now.Ticks - m_start) * m_dilation; | 128 | long m_addticks = (DateTime.Now.Ticks - m_start) * m_dilation; |
129 | DateTime dt = new DateTime(m_start + m_addticks); | 129 | DateTime dt = new DateTime(m_start + m_addticks); |
130 | return (double) dt.Hour + ((double) dt.Minute / 60.0); | 130 | return dt.Hour + (dt.Minute / 60.0); |
131 | } | 131 | } |
132 | 132 | ||
133 | private LLVector3 SunPos(double hour) | 133 | private LLVector3 SunPos(double hour) |
diff --git a/OpenSim/Region/Environment/Modules/World/Terrain/Effects/CookieCutter.cs b/OpenSim/Region/Environment/Modules/World/Terrain/Effects/CookieCutter.cs index a2e0c40..331c49d 100644 --- a/OpenSim/Region/Environment/Modules/World/Terrain/Effects/CookieCutter.cs +++ b/OpenSim/Region/Environment/Modules/World/Terrain/Effects/CookieCutter.cs | |||
@@ -78,7 +78,7 @@ namespace OpenSim.Region.Environment.Modules.World.Terrain.Effects | |||
78 | { | 78 | { |
79 | for (y = 0; y < map.Height; y++) | 79 | for (y = 0; y < map.Height; y++) |
80 | { | 80 | { |
81 | if (cliffMask[x, y] == true) | 81 | if (cliffMask[x, y]) |
82 | eroder.PaintEffect(map, x, y, 4, 0.1); | 82 | eroder.PaintEffect(map, x, y, 4, 0.1); |
83 | } | 83 | } |
84 | } | 84 | } |
diff --git a/OpenSim/Region/Environment/Modules/World/Terrain/FileLoaders/LLRAW.cs b/OpenSim/Region/Environment/Modules/World/Terrain/FileLoaders/LLRAW.cs index 5d6723f..90728da 100644 --- a/OpenSim/Region/Environment/Modules/World/Terrain/FileLoaders/LLRAW.cs +++ b/OpenSim/Region/Environment/Modules/World/Terrain/FileLoaders/LLRAW.cs | |||
@@ -47,7 +47,7 @@ namespace OpenSim.Region.Environment.Modules.World.Terrain.FileLoaders | |||
47 | { | 47 | { |
48 | for (x = 0; x < retval.Width; x++) | 48 | for (x = 0; x < retval.Width; x++) |
49 | { | 49 | { |
50 | retval[x, y] = (double) bs.ReadByte() * ((double) bs.ReadByte() / 127.0); | 50 | retval[x, y] = bs.ReadByte() * (bs.ReadByte() / 127.0); |
51 | bs.ReadBytes(11); // Advance the stream to next bytes. | 51 | bs.ReadBytes(11); // Advance the stream to next bytes. |
52 | } | 52 | } |
53 | } | 53 | } |
@@ -76,7 +76,7 @@ namespace OpenSim.Region.Environment.Modules.World.Terrain.FileLoaders | |||
76 | { | 76 | { |
77 | for (j = 0; j < 256; j++) | 77 | for (j = 0; j < 256; j++) |
78 | { | 78 | { |
79 | lookupHeightTable[i + (j * 256)] = ((double) i * ((double) j / 127.0)); | 79 | lookupHeightTable[i + (j * 256)] = (i * (j / 127.0)); |
80 | } | 80 | } |
81 | } | 81 | } |
82 | 82 | ||
diff --git a/OpenSim/Region/Environment/Modules/World/Terrain/FileLoaders/Terragen.cs b/OpenSim/Region/Environment/Modules/World/Terrain/FileLoaders/Terragen.cs index 7cb4b00..04c3f1a 100644 --- a/OpenSim/Region/Environment/Modules/World/Terrain/FileLoaders/Terragen.cs +++ b/OpenSim/Region/Environment/Modules/World/Terrain/FileLoaders/Terragen.cs | |||
@@ -50,14 +50,14 @@ namespace OpenSim.Region.Environment.Modules.World.Terrain.FileLoaders | |||
50 | BinaryReader bs = new BinaryReader(s); | 50 | BinaryReader bs = new BinaryReader(s); |
51 | 51 | ||
52 | bool eof = false; | 52 | bool eof = false; |
53 | if (ASCIIEncoding.ASCII.GetString(bs.ReadBytes(16)) == "TERRAGENTERRAIN ") | 53 | if (Encoding.ASCII.GetString(bs.ReadBytes(16)) == "TERRAGENTERRAIN ") |
54 | { | 54 | { |
55 | // Terragen file | 55 | // Terragen file |
56 | while (eof == false) | 56 | while (eof == false) |
57 | { | 57 | { |
58 | int w = 256; | 58 | int w = 256; |
59 | int h = 256; | 59 | int h = 256; |
60 | string tmp = ASCIIEncoding.ASCII.GetString(bs.ReadBytes(4)); | 60 | string tmp = Encoding.ASCII.GetString(bs.ReadBytes(4)); |
61 | switch (tmp) | 61 | switch (tmp) |
62 | { | 62 | { |
63 | case "SIZE": | 63 | case "SIZE": |
@@ -84,7 +84,7 @@ namespace OpenSim.Region.Environment.Modules.World.Terrain.FileLoaders | |||
84 | { | 84 | { |
85 | for (y = 0; y < h; y++) | 85 | for (y = 0; y < h; y++) |
86 | { | 86 | { |
87 | retval[x, y] = (double) baseHeight + (double) bs.ReadInt16() * (double) heightScale / 65536.0; | 87 | retval[x, y] = baseHeight + bs.ReadInt16() * (double) heightScale / 65536.0; |
88 | } | 88 | } |
89 | } | 89 | } |
90 | break; | 90 | break; |
diff --git a/OpenSim/Region/Environment/Modules/World/Terrain/PaintBrushes/FlattenSphere.cs b/OpenSim/Region/Environment/Modules/World/Terrain/PaintBrushes/FlattenSphere.cs index dee455f..fa52a00 100644 --- a/OpenSim/Region/Environment/Modules/World/Terrain/PaintBrushes/FlattenSphere.cs +++ b/OpenSim/Region/Environment/Modules/World/Terrain/PaintBrushes/FlattenSphere.cs | |||
@@ -31,7 +31,6 @@ namespace OpenSim.Region.Environment.Modules.World.Terrain.PaintBrushes | |||
31 | { | 31 | { |
32 | public class FlattenSphere : ITerrainPaintableEffect | 32 | public class FlattenSphere : ITerrainPaintableEffect |
33 | { | 33 | { |
34 | |||
35 | #region ITerrainPaintableEffect Members | 34 | #region ITerrainPaintableEffect Members |
36 | 35 | ||
37 | public void PaintEffect(ITerrainChannel map, double rx, double ry, double strength, double duration) | 36 | public void PaintEffect(ITerrainChannel map, double rx, double ry, double strength, double duration) |
diff --git a/OpenSim/Region/Environment/Modules/World/Terrain/PaintBrushes/NoiseSphere.cs b/OpenSim/Region/Environment/Modules/World/Terrain/PaintBrushes/NoiseSphere.cs index 8ae583e..5037533 100644 --- a/OpenSim/Region/Environment/Modules/World/Terrain/PaintBrushes/NoiseSphere.cs +++ b/OpenSim/Region/Environment/Modules/World/Terrain/PaintBrushes/NoiseSphere.cs | |||
@@ -57,7 +57,7 @@ namespace OpenSim.Region.Environment.Modules.World.Terrain.PaintBrushes | |||
57 | z *= z; | 57 | z *= z; |
58 | z -= ((x - rx) * (x - rx)) + ((y - ry) * (y - ry)); | 58 | z -= ((x - rx) * (x - rx)) + ((y - ry) * (y - ry)); |
59 | 59 | ||
60 | double noise = TerrainUtil.PerlinNoise2D((double) x / (double) Constants.RegionSize, (double) y / (double) Constants.RegionSize, 8, 1.0); | 60 | double noise = TerrainUtil.PerlinNoise2D(x / (double) Constants.RegionSize, y / (double) Constants.RegionSize, 8, 1.0); |
61 | 61 | ||
62 | if (z > 0.0) | 62 | if (z > 0.0) |
63 | map[x, y] += noise * z * duration; | 63 | map[x, y] += noise * z * duration; |
diff --git a/OpenSim/Region/Environment/Modules/World/Terrain/PaintBrushes/RevertSphere.cs b/OpenSim/Region/Environment/Modules/World/Terrain/PaintBrushes/RevertSphere.cs index b47e041..acce32e 100644 --- a/OpenSim/Region/Environment/Modules/World/Terrain/PaintBrushes/RevertSphere.cs +++ b/OpenSim/Region/Environment/Modules/World/Terrain/PaintBrushes/RevertSphere.cs | |||
@@ -32,7 +32,7 @@ namespace OpenSim.Region.Environment.Modules.World.Terrain.PaintBrushes | |||
32 | { | 32 | { |
33 | public class RevertSphere : ITerrainPaintableEffect | 33 | public class RevertSphere : ITerrainPaintableEffect |
34 | { | 34 | { |
35 | private ITerrainChannel m_revertmap; | 35 | private readonly ITerrainChannel m_revertmap; |
36 | 36 | ||
37 | public RevertSphere(ITerrainChannel revertmap) | 37 | public RevertSphere(ITerrainChannel revertmap) |
38 | { | 38 | { |
diff --git a/OpenSim/Region/Environment/Modules/World/Terrain/TerrainException.cs b/OpenSim/Region/Environment/Modules/World/Terrain/TerrainException.cs index f5c0fe4..2411de0 100644 --- a/OpenSim/Region/Environment/Modules/World/Terrain/TerrainException.cs +++ b/OpenSim/Region/Environment/Modules/World/Terrain/TerrainException.cs | |||
@@ -31,7 +31,7 @@ namespace OpenSim.Region.Environment.Modules.World.Terrain | |||
31 | { | 31 | { |
32 | public class TerrainException : Exception | 32 | public class TerrainException : Exception |
33 | { | 33 | { |
34 | public TerrainException() : base() | 34 | public TerrainException() |
35 | { | 35 | { |
36 | } | 36 | } |
37 | 37 | ||
diff --git a/OpenSim/Region/Environment/Modules/World/Terrain/TerrainModule.cs b/OpenSim/Region/Environment/Modules/World/Terrain/TerrainModule.cs index eff6159..c105620 100644 --- a/OpenSim/Region/Environment/Modules/World/Terrain/TerrainModule.cs +++ b/OpenSim/Region/Environment/Modules/World/Terrain/TerrainModule.cs | |||
@@ -83,7 +83,7 @@ namespace OpenSim.Region.Environment.Modules.World.Terrain | |||
83 | private Dictionary<string, ITerrainEffect> m_plugineffects; | 83 | private Dictionary<string, ITerrainEffect> m_plugineffects; |
84 | private ITerrainChannel m_revert; | 84 | private ITerrainChannel m_revert; |
85 | private Scene m_scene; | 85 | private Scene m_scene; |
86 | private bool m_tainted = false; | 86 | private bool m_tainted; |
87 | 87 | ||
88 | #region ICommandableModule Members | 88 | #region ICommandableModule Members |
89 | 89 | ||
@@ -223,6 +223,8 @@ namespace OpenSim.Region.Environment.Modules.World.Terrain | |||
223 | } | 223 | } |
224 | } | 224 | } |
225 | 225 | ||
226 | #endregion | ||
227 | |||
226 | #region Plugin Loading Methods | 228 | #region Plugin Loading Methods |
227 | 229 | ||
228 | private void LoadPlugins() | 230 | private void LoadPlugins() |
@@ -276,8 +278,6 @@ namespace OpenSim.Region.Environment.Modules.World.Terrain | |||
276 | 278 | ||
277 | #endregion | 279 | #endregion |
278 | 280 | ||
279 | #endregion | ||
280 | |||
281 | /// <summary> | 281 | /// <summary> |
282 | /// Installs into terrain module the standard suite of brushes | 282 | /// Installs into terrain module the standard suite of brushes |
283 | /// </summary> | 283 | /// </summary> |
diff --git a/OpenSim/Region/Environment/Modules/World/TreePopulator/TreePopulatorModule.cs b/OpenSim/Region/Environment/Modules/World/TreePopulator/TreePopulatorModule.cs index 4b22700..d964fe4 100644 --- a/OpenSim/Region/Environment/Modules/World/TreePopulator/TreePopulatorModule.cs +++ b/OpenSim/Region/Environment/Modules/World/TreePopulator/TreePopulatorModule.cs | |||
@@ -66,10 +66,10 @@ namespace OpenSim.Region.Environment.Modules.World.TreePopulator | |||
66 | m_trees = new List<LLUUID>(); | 66 | m_trees = new List<LLUUID>(); |
67 | m_scene = scene; | 67 | m_scene = scene; |
68 | 68 | ||
69 | m_scene.EventManager.OnPluginConsole += new EventManager.OnPluginConsoleDelegate(EventManager_OnPluginConsole); | 69 | m_scene.EventManager.OnPluginConsole += EventManager_OnPluginConsole; |
70 | 70 | ||
71 | Timer CalculateTrees = new Timer(m_tree_updates); | 71 | Timer CalculateTrees = new Timer(m_tree_updates); |
72 | CalculateTrees.Elapsed += new ElapsedEventHandler(CalculateTrees_Elapsed); | 72 | CalculateTrees.Elapsed += CalculateTrees_Elapsed; |
73 | CalculateTrees.Start(); | 73 | CalculateTrees.Start(); |
74 | m_log.Debug("[TREES]: Initialised tree module"); | 74 | m_log.Debug("[TREES]: Initialised tree module"); |
75 | } | 75 | } |