* Optimized usings

* shortened references
* Removed redundant 'this'
* Normalized EOF

2 files changed, 77 insertions, 79 deletions

diff --git a/OpenSim/Region/Environment/LandManagement/Land.cs b/OpenSim/Region/Environment/LandManagement/Land.cs
index 7977c78..ff16319 100644
--- a/OpenSim/Region/Environment/LandManagement/Land.cs
+++ b/OpenSim/Region/Environment/LandManagement/Land.cs
@@ -32,7 +32,6 @@ using libsecondlife;
 using libsecondlife.Packets;
 using OpenSim.Framework;
 using OpenSim.Region.Environment.Scenes;
-using OpenSim.Region.Environment.Interfaces;
 
 namespace OpenSim.Region.Environment.LandManagement
 {
@@ -98,7 +97,6 @@ namespace OpenSim.Region.Environment.LandManagement
             return newLand;
         }
 
-
         #endregion
 
         #region Packet Request Handling
@@ -202,7 +200,7 @@ namespace OpenSim.Region.Environment.LandManagement
                 //Needs later group support
                 LandData newData = landData.Copy();
                 newData.authBuyerID = packet.ParcelData.AuthBuyerID;
-                newData.category = (Parcel.ParcelCategory)packet.ParcelData.Category;
+                newData.category = (Parcel.ParcelCategory) packet.ParcelData.Category;
                 newData.landDesc = Helpers.FieldToUTF8String(packet.ParcelData.Desc);
                 newData.groupID = packet.ParcelData.GroupID;
                 newData.landingType = packet.ParcelData.LandingType;
@@ -222,8 +220,6 @@ namespace OpenSim.Region.Environment.LandManagement
                 m_scene.LandManager.updateLandObject(landData.localID, newData);
 
                 sendLandUpdateToAvatarsOverMe();
-
-                
             }
         }
 
@@ -242,13 +238,13 @@ namespace OpenSim.Region.Environment.LandManagement
 
         public bool isBannedFromLand(LLUUID avatar)
         {
-            if ((this.landData.landFlags & (uint)Parcel.ParcelFlags.UseBanList) > 0)
+            if ((landData.landFlags & (uint) Parcel.ParcelFlags.UseBanList) > 0)
             {
                 ParcelManager.ParcelAccessEntry entry = new ParcelManager.ParcelAccessEntry();
                 entry.AgentID = avatar;
                 entry.Flags = ParcelManager.AccessList.Ban;
                 entry.Time = new DateTime();
-                if (this.landData.parcelAccessList.Contains(entry))
+                if (landData.parcelAccessList.Contains(entry))
                 {
                     //They are banned, so lets send them a notice about this parcel
                     return true;
@@ -259,13 +255,13 @@ namespace OpenSim.Region.Environment.LandManagement
 
         public bool isRestrictedFromLand(LLUUID avatar)
         {
-            if ((this.landData.landFlags & (uint)Parcel.ParcelFlags.UseAccessList) > 0)
+            if ((landData.landFlags & (uint) Parcel.ParcelFlags.UseAccessList) > 0)
             {
                 ParcelManager.ParcelAccessEntry entry = new ParcelManager.ParcelAccessEntry();
                 entry.AgentID = avatar;
                 entry.Flags = ParcelManager.AccessList.Access;
                 entry.Time = new DateTime();
-                if (!this.landData.parcelAccessList.Contains(entry))
+                if (!landData.parcelAccessList.Contains(entry))
                 {
                     //They are not allowed in this parcel, but not banned, so lets send them a notice about this parcel
                     return true;
@@ -310,7 +306,7 @@ namespace OpenSim.Region.Environment.LandManagement
                 {
                     ParcelAccessListReplyPacket.ListBlock listBlock = new ParcelAccessListReplyPacket.ListBlock();
 
-                    listBlock.Flags = (uint)0;
+                    listBlock.Flags = (uint) 0;
                     listBlock.ID = entry.AgentID;
                     listBlock.Time = 0;
 
@@ -322,7 +318,7 @@ namespace OpenSim.Region.Environment.LandManagement
             {
                 ParcelAccessListReplyPacket.ListBlock listBlock = new ParcelAccessListReplyPacket.ListBlock();
 
-                listBlock.Flags = (uint)0;
+                listBlock.Flags = (uint) 0;
                 listBlock.ID = LLUUID.Zero;
                 listBlock.Time = 0;
 
@@ -331,38 +327,37 @@ namespace OpenSim.Region.Environment.LandManagement
             return list.ToArray();
         }
 
-        public void sendAccessList(LLUUID agentID, LLUUID sessionID, uint flags, int sequenceID, IClientAPI remote_client)
+        public void sendAccessList(LLUUID agentID, LLUUID sessionID, uint flags, int sequenceID,
+                                   IClientAPI remote_client)
         {
-                
             ParcelAccessListReplyPacket replyPacket;
 
-            if (flags == (uint)ParcelManager.AccessList.Access || flags == (uint)ParcelManager.AccessList.Both)
+            if (flags == (uint) ParcelManager.AccessList.Access || flags == (uint) ParcelManager.AccessList.Both)
             {
                 replyPacket = new ParcelAccessListReplyPacket();
                 replyPacket.Data.AgentID = agentID;
-                replyPacket.Data.Flags = (uint)ParcelManager.AccessList.Access;
-                replyPacket.Data.LocalID = this.landData.localID;
+                replyPacket.Data.Flags = (uint) ParcelManager.AccessList.Access;
+                replyPacket.Data.LocalID = landData.localID;
                 replyPacket.Data.SequenceID = 0;
 
                 replyPacket.List = createAccessListArrayByFlag(ParcelManager.AccessList.Access);
-                remote_client.OutPacket((Packet)replyPacket, ThrottleOutPacketType.Task);
+                remote_client.OutPacket((Packet) replyPacket, ThrottleOutPacketType.Task);
             }
 
-            if (flags == (uint)ParcelManager.AccessList.Ban || flags == (uint)ParcelManager.AccessList.Both)
+            if (flags == (uint) ParcelManager.AccessList.Ban || flags == (uint) ParcelManager.AccessList.Both)
             {
                 replyPacket = new ParcelAccessListReplyPacket();
                 replyPacket.Data.AgentID = agentID;
-                replyPacket.Data.Flags = (uint)ParcelManager.AccessList.Ban;
-                replyPacket.Data.LocalID = this.landData.localID;
+                replyPacket.Data.Flags = (uint) ParcelManager.AccessList.Ban;
+                replyPacket.Data.LocalID = landData.localID;
                 replyPacket.Data.SequenceID = 0;
 
                 replyPacket.List = createAccessListArrayByFlag(ParcelManager.AccessList.Ban);
-                remote_client.OutPacket((Packet)replyPacket, ThrottleOutPacketType.Task);
+                remote_client.OutPacket((Packet) replyPacket, ThrottleOutPacketType.Task);
             }
-            
         }
 
-        public void updateAccessList(uint flags,  List<ParcelManager.ParcelAccessEntry> entries, IClientAPI remote_client)
+        public void updateAccessList(uint flags, List<ParcelManager.ParcelAccessEntry> entries, IClientAPI remote_client)
         {
             LandData newData = landData.Copy();
 
@@ -370,11 +365,11 @@ namespace OpenSim.Region.Environment.LandManagement
             {
                 entries.Clear();
             }
-            
+
             List<ParcelManager.ParcelAccessEntry> toRemove = new List<ParcelManager.ParcelAccessEntry>();
             foreach (ParcelManager.ParcelAccessEntry entry in newData.parcelAccessList)
             {
-                if (entry.Flags == (ParcelManager.AccessList)flags)
+                if (entry.Flags == (ParcelManager.AccessList) flags)
                 {
                     toRemove.Add(entry);
                 }
@@ -388,8 +383,8 @@ namespace OpenSim.Region.Environment.LandManagement
             {
                 ParcelManager.ParcelAccessEntry temp = new ParcelManager.ParcelAccessEntry();
                 temp.AgentID = entry.AgentID;
-                temp.Time = new DateTime() ; //Pointless? Yes.
-                temp.Flags = (ParcelManager.AccessList)flags;
+                temp.Time = new DateTime(); //Pointless? Yes.
+                temp.Flags = (ParcelManager.AccessList) flags;
 
                 if (!newData.parcelAccessList.Contains(temp))
                 {
@@ -398,7 +393,6 @@ namespace OpenSim.Region.Environment.LandManagement
             }
 
             m_scene.LandManager.updateLandObject(landData.localID, newData);
-
         }
 
         #endregion
@@ -437,7 +431,6 @@ namespace OpenSim.Region.Environment.LandManagement
                 new LLVector3((float) (max_x*4), (float) (max_y*4),
                               (float) m_scene.Terrain.GetHeight((max_x*4), (max_y*4)));
             landData.area = tempArea;
-
         }
 
         public void updateLandBitmapByteArray()
@@ -650,9 +643,9 @@ namespace OpenSim.Region.Environment.LandManagement
                     {
                         resultLocalIDs.Add(obj.LocalId);
                     }
-                    // else if (request_type == LandManager.LAND_SELECT_OBJECTS_GROUP && ...) // TODO: group support
-                    // {
-                    // }
+                        // else if (request_type == LandManager.LAND_SELECT_OBJECTS_GROUP && ...) // TODO: group support
+                        // {
+                        // }
                     else if (request_type == LandManager.LAND_SELECT_OBJECTS_OTHER &&
                              obj.OwnerID != remote_client.AgentId)
                     {
@@ -732,10 +725,8 @@ namespace OpenSim.Region.Environment.LandManagement
 
                     num++;
                 }
-                
+
                 pack.Data = dataBlock;
-                
-                
             }
             remote_client.OutPacket(pack, ThrottleOutPacketType.Task);
         }
diff --git a/OpenSim/Region/Environment/LandManagement/LandManager.cs b/OpenSim/Region/Environment/LandManagement/LandManager.cs
index ecd458d..772fe2e 100644
--- a/OpenSim/Region/Environment/LandManagement/LandManager.cs
+++ b/OpenSim/Region/Environment/LandManagement/LandManager.cs
@@ -27,11 +27,13 @@
 */
 using System;
 using System.Collections.Generic;
+using Axiom.Math;
 using libsecondlife;
 using libsecondlife.Packets;
 using OpenSim.Framework;
+using OpenSim.Framework.Console;
 using OpenSim.Region.Environment.Scenes;
-using OpenSim.Region.Environment.Interfaces;
+using OpenSim.Region.Physics.Manager;
 
 namespace OpenSim.Region.Environment.LandManagement
 {
@@ -93,7 +95,7 @@ namespace OpenSim.Region.Environment.LandManagement
         private readonly RegionInfo m_regInfo;
 
         public bool allowedForcefulBans = true;
-        
+
         #endregion
 
         #region Constructors
@@ -103,14 +105,13 @@ namespace OpenSim.Region.Environment.LandManagement
             m_scene = scene;
             m_regInfo = reginfo;
             landIDList.Initialize();
-            scene.EventManager.OnAvatarEnteringNewParcel += new EventManager.AvatarEnteringNewParcel(handleAvatarChangingParcel);
-            scene.EventManager.OnClientMovement += new EventManager.ClientMovement(this.handleAnyClientMovement);
+            scene.EventManager.OnAvatarEnteringNewParcel +=
+                new EventManager.AvatarEnteringNewParcel(handleAvatarChangingParcel);
+            scene.EventManager.OnClientMovement += new EventManager.ClientMovement(handleAnyClientMovement);
         }
 
-
-
         #endregion
-        
+
         #region Member Functions
 
         #region Land Object From Storage Functions
@@ -147,7 +148,6 @@ namespace OpenSim.Region.Environment.LandManagement
         /// <returns></returns>
         public Land createBaseLand()
         {
-            
             return new Land(LLUUID.Zero, false, m_scene);
         }
 
@@ -175,7 +175,7 @@ namespace OpenSim.Region.Environment.LandManagement
                 }
             }
             landList[lastLandLocalID].forceUpdateLandInfo();
-            m_scene.EventManager.TriggerLandObjectAdded(new_land,m_scene.RegionInfo.RegionID);
+            m_scene.EventManager.TriggerLandObjectAdded(new_land, m_scene.RegionInfo.RegionID);
             return new_land;
         }
 
@@ -207,7 +207,7 @@ namespace OpenSim.Region.Environment.LandManagement
             if (landList.ContainsKey(local_id))
             {
                 landList[local_id].landData = newData.Copy();
-                m_scene.EventManager.TriggerLandObjectUpdated((uint)local_id, landList[local_id]);
+                m_scene.EventManager.TriggerLandObjectUpdated((uint) local_id, landList[local_id]);
             }
             else
             {
@@ -335,7 +335,7 @@ namespace OpenSim.Region.Environment.LandManagement
 
             //Now add the new land object
             Land result = addLandObject(newLand);
-            updateLandObject(startLandObject.landData.localID,startLandObject.landData);
+            updateLandObject(startLandObject.landData.localID, startLandObject.landData);
             result.sendLandUpdateToAvatarsOverMe();
 
 
@@ -463,11 +463,11 @@ namespace OpenSim.Region.Environment.LandManagement
                             Land southParcel = null;
                             if (x > 0)
                             {
-                                westParcel = getLandObject((x - 1) * 4, y * 4);
+                                westParcel = getLandObject((x - 1)*4, y*4);
                             }
                             if (y > 0)
                             {
-                                southParcel = getLandObject(x * 4, (y - 1) * 4);
+                                southParcel = getLandObject(x*4, (y - 1)*4);
                             }
 
                             if (x == 0)
@@ -496,14 +496,15 @@ namespace OpenSim.Region.Environment.LandManagement
                                 packet = new ParcelOverlayPacket();
                                 packet.ParcelData.Data = byteArray;
                                 packet.ParcelData.SequenceID = sequenceID;
-                                remote_client.OutPacket((Packet)packet, ThrottleOutPacketType.Task);
+                                remote_client.OutPacket((Packet) packet, ThrottleOutPacketType.Task);
                                 sequenceID++;
                                 byteArray = new byte[LAND_BLOCKS_PER_PACKET];
                             }
                         }
-                        catch (System.Exception e)
+                        catch (Exception e)
                         {
-                            OpenSim.Framework.Console.MainLog.Instance.Debug("LAND", "Skipped Land checks because avatar is out of bounds: " + e.Message);
+                            MainLog.Instance.Debug("LAND",
+                                                   "Skipped Land checks because avatar is out of bounds: " + e.Message);
                         }
                     }
                 }
@@ -599,7 +600,6 @@ namespace OpenSim.Region.Environment.LandManagement
 
         public List<Land> parcelsNearPoint(LLVector3 position)
         {
-            
             List<Land> parcelsNear = new List<Land>();
             int x, y;
             for (x = -4; x <= 4; x += 4)
@@ -617,22 +617,25 @@ namespace OpenSim.Region.Environment.LandManagement
                 }
             }
 
-            return parcelsNear;           
-
+            return parcelsNear;
         }
 
         public void sendYouAreBannedNotice(ScenePresence avatar)
         {
             if (allowedForcefulBans)
             {
-                avatar.ControllingClient.SendAlertMessage("You are not allowed on this parcel because you are banned. Please go away. <3 OpenSim Developers");
+                avatar.ControllingClient.SendAlertMessage(
+                    "You are not allowed on this parcel because you are banned. Please go away. <3 OpenSim Developers");
 
-                avatar.PhysicsActor.Position = new OpenSim.Region.Physics.Manager.PhysicsVector(avatar.lastKnownAllowedPosition.x, avatar.lastKnownAllowedPosition.y, avatar.lastKnownAllowedPosition.z);
-                avatar.PhysicsActor.Velocity = new OpenSim.Region.Physics.Manager.PhysicsVector(0, 0, 0);
+                avatar.PhysicsActor.Position =
+                    new PhysicsVector(avatar.lastKnownAllowedPosition.x, avatar.lastKnownAllowedPosition.y,
+                                      avatar.lastKnownAllowedPosition.z);
+                avatar.PhysicsActor.Velocity = new PhysicsVector(0, 0, 0);
             }
             else
             {
-                avatar.ControllingClient.SendAlertMessage("You are not allowed on this parcel because you are banned; however, the grid administrator has disabled ban lines globally. Please obey the land owner's requests or you can be banned from the entire sim! <3 OpenSim Developers");
+                avatar.ControllingClient.SendAlertMessage(
+                    "You are not allowed on this parcel because you are banned; however, the grid administrator has disabled ban lines globally. Please obey the land owner's requests or you can be banned from the entire sim! <3 OpenSim Developers");
             }
         }
 
@@ -651,7 +654,8 @@ namespace OpenSim.Region.Environment.LandManagement
                         }
                         else if (parcelAvatarIsEntering.isRestrictedFromLand(avatar.UUID))
                         {
-                            avatar.ControllingClient.SendAlertMessage("You are not allowed on this parcel because the land owner has restricted access. For now, you can enter, but please respect the land owner's decisions (or he can ban you!). <3 OpenSim Developers");
+                            avatar.ControllingClient.SendAlertMessage(
+                                "You are not allowed on this parcel because the land owner has restricted access. For now, you can enter, but please respect the land owner's decisions (or he can ban you!). <3 OpenSim Developers");
                         }
                         else
                         {
@@ -668,7 +672,6 @@ namespace OpenSim.Region.Environment.LandManagement
 
         public void sendOutNearestBanLine(IClientAPI avatar)
         {
-            
             List<ScenePresence> avatars = m_scene.GetAvatars();
             foreach (ScenePresence presence in avatars)
             {
@@ -679,15 +682,14 @@ namespace OpenSim.Region.Environment.LandManagement
                     {
                         if (checkBan.isBannedFromLand(avatar.AgentId))
                         {
-                            checkBan.sendLandProperties(-30000, false, (int)ParcelManager.ParcelResult.Single, avatar);
+                            checkBan.sendLandProperties(-30000, false, (int) ParcelManager.ParcelResult.Single, avatar);
                             return; //Only send one
                         }
                         else if (checkBan.isRestrictedFromLand(avatar.AgentId))
                         {
-                            checkBan.sendLandProperties(-40000, false, (int)ParcelManager.ParcelResult.Single, avatar);
+                            checkBan.sendLandProperties(-40000, false, (int) ParcelManager.ParcelResult.Single, avatar);
                             return; //Only send one
                         }
-
                     }
                     return;
                 }
@@ -696,8 +698,8 @@ namespace OpenSim.Region.Environment.LandManagement
 
         public void sendLandUpdate(ScenePresence avatar)
         {
-            Land over = getLandObject((int)Math.Min(255, Math.Max(0, Math.Round(avatar.AbsolutePosition.X))),
-                                      (int)Math.Min(255, Math.Max(0, Math.Round(avatar.AbsolutePosition.Y))));
+            Land over = getLandObject((int) Math.Min(255, Math.Max(0, Math.Round(avatar.AbsolutePosition.X))),
+                                      (int) Math.Min(255, Math.Max(0, Math.Round(avatar.AbsolutePosition.Y))));
 
             if (over != null)
             {
@@ -705,10 +707,10 @@ namespace OpenSim.Region.Environment.LandManagement
                 if (avatar.currentParcelUUID != over.landData.globalID)
                 {
                     avatar.currentParcelUUID = over.landData.globalID;
-                    m_scene.EventManager.TriggerAvatarEnteringNewParcel(avatar, over.landData.localID, this.m_scene.RegionInfo.RegionID);
+                    m_scene.EventManager.TriggerAvatarEnteringNewParcel(avatar, over.landData.localID,
+                                                                        m_scene.RegionInfo.RegionID);
                 }
             }
-
         }
 
         public void handleSignificantClientMovement(IClientAPI remote_client)
@@ -722,16 +724,18 @@ namespace OpenSim.Region.Environment.LandManagement
                 Land parcel = getLandObject(clientAvatar.AbsolutePosition.X, clientAvatar.AbsolutePosition.Y);
                 if (parcel != null)
                 {
-                    if (clientAvatar.AbsolutePosition.Z < BAN_LINE_SAFETY_HIEGHT && clientAvatar.sentMessageAboutRestrictedParcelFlyingDown)
+                    if (clientAvatar.AbsolutePosition.Z < BAN_LINE_SAFETY_HIEGHT &&
+                        clientAvatar.sentMessageAboutRestrictedParcelFlyingDown)
                     {
-
-                        handleAvatarChangingParcel(clientAvatar, parcel.landData.localID, m_scene.RegionInfo.RegionID); //They are going below the safety line!
+                        handleAvatarChangingParcel(clientAvatar, parcel.landData.localID, m_scene.RegionInfo.RegionID);
+                            //They are going below the safety line!
                         if (!parcel.isBannedFromLand(clientAvatar.UUID))
                         {
                             clientAvatar.sentMessageAboutRestrictedParcelFlyingDown = false;
                         }
                     }
-                    else if (clientAvatar.AbsolutePosition.Z < BAN_LINE_SAFETY_HIEGHT && parcel.isBannedFromLand(clientAvatar.UUID))
+                    else if (clientAvatar.AbsolutePosition.Z < BAN_LINE_SAFETY_HIEGHT &&
+                             parcel.isBannedFromLand(clientAvatar.UUID))
                     {
                         sendYouAreBannedNotice(clientAvatar);
                     }
@@ -739,30 +743,33 @@ namespace OpenSim.Region.Environment.LandManagement
             }
         }
 
-        public void handleAnyClientMovement(ScenePresence avatar) //Like handleSignificantClientMovement, but called with an AgentUpdate regardless of distance. 
+        public void handleAnyClientMovement(ScenePresence avatar)
+            //Like handleSignificantClientMovement, but called with an AgentUpdate regardless of distance. 
         {
             Land over = getLandObject(avatar.AbsolutePosition.X, avatar.AbsolutePosition.Y);
             if (over != null)
             {
                 if (!over.isBannedFromLand(avatar.UUID) || avatar.AbsolutePosition.Z >= BAN_LINE_SAFETY_HIEGHT)
                 {
-                    avatar.lastKnownAllowedPosition = new Axiom.Math.Vector3(avatar.AbsolutePosition.X, avatar.AbsolutePosition.Y, avatar.AbsolutePosition.Z);
-
-
+                    avatar.lastKnownAllowedPosition =
+                        new Vector3(avatar.AbsolutePosition.X, avatar.AbsolutePosition.Y, avatar.AbsolutePosition.Z);
                 }
             }
         }
 
 
-        public void handleParcelAccessRequest(LLUUID agentID, LLUUID sessionID, uint flags, int sequenceID, int landLocalID, IClientAPI remote_client)
+        public void handleParcelAccessRequest(LLUUID agentID, LLUUID sessionID, uint flags, int sequenceID,
+                                              int landLocalID, IClientAPI remote_client)
         {
             if (landList.ContainsKey(landLocalID))
             {
-                landList[landLocalID].sendAccessList(agentID, sessionID, flags, sequenceID,remote_client);
+                landList[landLocalID].sendAccessList(agentID, sessionID, flags, sequenceID, remote_client);
             }
         }
 
-        public void handleParcelAccessUpdateRequest(LLUUID agentID, LLUUID sessionID,uint flags, int landLocalID, List<libsecondlife.ParcelManager.ParcelAccessEntry> entries, IClientAPI remote_client)
+        public void handleParcelAccessUpdateRequest(LLUUID agentID, LLUUID sessionID, uint flags, int landLocalID,
+                                                    List<ParcelManager.ParcelAccessEntry> entries,
+                                                    IClientAPI remote_client)
         {
             if (landList.ContainsKey(landLocalID))
             {
@@ -849,4 +856,4 @@ namespace OpenSim.Region.Environment.LandManagement
     }
 
     #endregion
-}
+}
\ No newline at end of file